]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
19cd76f4abafbed78d9a54fac525d6ad26bc9e06
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2006 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 int bdb_modify_internal(
31         Operation *op,
32         DB_TXN *tid,
33         Modifications *modlist,
34         Entry *e,
35         const char **text,
36         char *textbuf,
37         size_t textlen )
38 {
39         int rc, err;
40         Modification    *mod;
41         Modifications   *ml;
42         Attribute       *save_attrs;
43         Attribute       *ap;
44         int                     glue_attr_delete = 0;
45
46         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
47                 e->e_id, e->e_dn, 0);
48
49         if ( !acl_check_modlist( op, e, modlist )) {
50                 return LDAP_INSUFFICIENT_ACCESS;
51         }
52
53         /* save_attrs will be disposed of by bdb_cache_modify */
54         save_attrs = e->e_attrs;
55         e->e_attrs = attrs_dup( e->e_attrs );
56
57         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
58                 int match;
59                 mod = &ml->sml_mod;
60                 switch( mod->sm_op ) {
61                 case LDAP_MOD_ADD:
62                 case LDAP_MOD_REPLACE:
63                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
64                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
65                                         slap_schema.si_ad_structuralObjectClass->
66                                                 ad_type->sat_equality,
67                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
68                                         &mod->sm_values[0], &scbva[0], text );
69                                 if ( !match ) glue_attr_delete = 1;
70                         }
71                 }
72                 if ( glue_attr_delete )
73                         break;
74         }
75
76         if ( glue_attr_delete ) {
77                 Attribute       **app = &e->e_attrs;
78                 while ( *app != NULL ) {
79                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
80                                 Attribute *save = *app;
81                                 *app = (*app)->a_next;
82                                 attr_free( save );
83                                 continue;
84                         }
85                         app = &(*app)->a_next;
86                 }
87         }
88
89         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
90                 mod = &ml->sml_mod;
91
92                 switch ( mod->sm_op ) {
93                 case LDAP_MOD_ADD:
94                         Debug(LDAP_DEBUG_ARGS,
95                                 "bdb_modify_internal: add %s\n",
96                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
97                         err = modify_add_values( e, mod, get_permissiveModify(op),
98                                 text, textbuf, textlen );
99                         if( err != LDAP_SUCCESS ) {
100                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
101                                         err, *text, 0);
102                         }
103                         break;
104
105                 case LDAP_MOD_DELETE:
106                         if ( glue_attr_delete ) {
107                                 err = LDAP_SUCCESS;
108                                 break;
109                         }
110
111                         Debug(LDAP_DEBUG_ARGS,
112                                 "bdb_modify_internal: delete %s\n",
113                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
114                         err = modify_delete_values( e, mod, get_permissiveModify(op),
115                                 text, textbuf, textlen );
116                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
117                         if( err != LDAP_SUCCESS ) {
118                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
119                                         err, *text, 0);
120                         }
121                         break;
122
123                 case LDAP_MOD_REPLACE:
124                         Debug(LDAP_DEBUG_ARGS,
125                                 "bdb_modify_internal: replace %s\n",
126                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
127                         err = modify_replace_values( e, mod, get_permissiveModify(op),
128                                 text, textbuf, textlen );
129                         if( err != LDAP_SUCCESS ) {
130                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
131                                         err, *text, 0);
132                         }
133                         break;
134
135                 case LDAP_MOD_INCREMENT:
136                         Debug(LDAP_DEBUG_ARGS,
137                                 "bdb_modify_internal: increment %s\n",
138                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
139                         err = modify_increment_values( e, mod, get_permissiveModify(op),
140                                 text, textbuf, textlen );
141                         if( err != LDAP_SUCCESS ) {
142                                 Debug(LDAP_DEBUG_ARGS,
143                                         "bdb_modify_internal: %d %s\n",
144                                         err, *text, 0);
145                         }
146                         break;
147
148                 case SLAP_MOD_SOFTADD:
149                         Debug(LDAP_DEBUG_ARGS,
150                                 "bdb_modify_internal: softadd %s\n",
151                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
152                         /* Avoid problems in index_add_mods()
153                          * We need to add index if necessary.
154                          */
155                         mod->sm_op = LDAP_MOD_ADD;
156
157                         err = modify_add_values( e, mod, get_permissiveModify(op),
158                                 text, textbuf, textlen );
159
160                         mod->sm_op = SLAP_MOD_SOFTADD;
161
162                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
163                                 err = LDAP_SUCCESS;
164                         }
165
166                         if( err != LDAP_SUCCESS ) {
167                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
168                                         err, *text, 0);
169                         }
170                         break;
171
172                 default:
173                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
174                                 mod->sm_op, 0, 0);
175                         *text = "Invalid modify operation";
176                         err = LDAP_OTHER;
177                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
178                                 err, *text, 0);
179                 }
180
181                 if ( err != LDAP_SUCCESS ) {
182                         attrs_free( e->e_attrs );
183                         e->e_attrs = save_attrs;
184                         /* unlock entry, delete from cache */
185                         return err; 
186                 }
187
188                 /* If objectClass was modified, reset the flags */
189                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
190                         e->e_ocflags = 0;
191                 }
192
193                 if ( glue_attr_delete ) e->e_ocflags = 0;
194
195                 /* check if modified attribute was indexed
196                  * but not in case of NOOP... */
197                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
198                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
199                         ap = attr_find( save_attrs, mod->sm_desc );
200                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
201
202                         ap = attr_find( e->e_attrs, mod->sm_desc );
203                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
204                 }
205         }
206
207         /* check that the entry still obeys the schema */
208         rc = entry_schema_check( op, e, save_attrs, get_manageDIT(op),
209                 text, textbuf, textlen );
210         if ( rc != LDAP_SUCCESS || op->o_noop ) {
211                 attrs_free( e->e_attrs );
212                 /* clear the indexing flags */
213                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
214                         ap->a_flags = 0;
215                 }
216                 e->e_attrs = save_attrs;
217
218                 if ( rc != LDAP_SUCCESS ) {
219                         Debug( LDAP_DEBUG_ANY,
220                                 "entry failed schema check: %s\n",
221                                 *text, 0, 0 );
222                 }
223
224                 /* if NOOP then silently revert to saved attrs */
225                 return rc;
226         }
227
228         /* update the indices of the modified attributes */
229
230         /* start with deleting the old index entries */
231         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
232                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
233                         rc = bdb_index_values( op, tid, ap->a_desc,
234                                 ap->a_nvals,
235                                 e->e_id, SLAP_INDEX_DELETE_OP );
236                         if ( rc != LDAP_SUCCESS ) {
237                                 attrs_free( e->e_attrs );
238                                 e->e_attrs = save_attrs;
239                                 Debug( LDAP_DEBUG_ANY,
240                                        "Attribute index delete failure",
241                                        0, 0, 0 );
242                                 return rc;
243                         }
244                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
245                 }
246         }
247
248         /* add the new index entries */
249         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
250                 if (ap->a_flags & SLAP_ATTR_IXADD) {
251                         rc = bdb_index_values( op, tid, ap->a_desc,
252                                 ap->a_nvals,
253                                 e->e_id, SLAP_INDEX_ADD_OP );
254                         if ( rc != LDAP_SUCCESS ) {
255                                 attrs_free( e->e_attrs );
256                                 e->e_attrs = save_attrs;
257                                 Debug( LDAP_DEBUG_ANY,
258                                        "Attribute index add failure",
259                                        0, 0, 0 );
260                                 return rc;
261                         }
262                         ap->a_flags &= ~SLAP_ATTR_IXADD;
263                 }
264         }
265
266         return rc;
267 }
268
269
270 int
271 bdb_modify( Operation *op, SlapReply *rs )
272 {
273         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
274         Entry           *e = NULL;
275         EntryInfo       *ei = NULL;
276         int             manageDSAit = get_manageDSAit( op );
277         char textbuf[SLAP_TEXT_BUFLEN];
278         size_t textlen = sizeof textbuf;
279         DB_TXN  *ltid = NULL, *lt2;
280         struct bdb_op_info opinfo = {0};
281         Entry           dummy = {0};
282         int                     fakeroot = 0;
283
284         u_int32_t       locker = 0;
285         DB_LOCK         lock;
286
287         int             num_retries = 0;
288
289         LDAPControl **preread_ctrl = NULL;
290         LDAPControl **postread_ctrl = NULL;
291         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
292         int num_ctrls = 0;
293
294         int rc;
295
296 #ifdef LDAP_X_TXN
297         int settle = 0;
298 #endif
299
300         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
301                 op->o_req_dn.bv_val, 0, 0 );
302
303 #ifdef LDAP_X_TXN
304         if( op->o_txnSpec ) {
305                 /* acquire connection lock */
306                 ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
307                 if( op->o_conn->c_txn == CONN_TXN_INACTIVE ) {
308                         rs->sr_text = "invalid transaction identifier";
309                         rs->sr_err = LDAP_X_TXN_ID_INVALID;
310                         goto txnReturn;
311                 } else if( op->o_conn->c_txn == CONN_TXN_SETTLE ) {
312                         settle=1;
313                         goto txnReturn;
314                 }
315
316                 if( op->o_conn->c_txn_backend == NULL ) {
317                         op->o_conn->c_txn_backend = op->o_bd;
318
319                 } else if( op->o_conn->c_txn_backend != op->o_bd ) {
320                         rs->sr_text = "transaction cannot span multiple database contexts";
321                         rs->sr_err = LDAP_AFFECTS_MULTIPLE_DSAS;
322                         goto txnReturn;
323                 }
324
325                 /* insert operation into transaction */
326
327                 rs->sr_text = "transaction specified";
328                 rs->sr_err = LDAP_SUCCESS;
329
330 txnReturn:
331                 /* release connection lock */
332                 ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
333
334                 if( !settle ) {
335                         send_ldap_result( op, rs );
336                         return rs->sr_err;
337                 }
338         }
339 #endif
340
341         ctrls[num_ctrls] = NULL;
342
343         slap_mods_opattrs( op, &op->orm_modlist, 1 );
344
345         if( 0 ) {
346 retry:  /* transaction retry */
347                 if ( dummy.e_attrs ) {
348                         attrs_free( dummy.e_attrs );
349                         dummy.e_attrs = NULL;
350                 }
351                 if( e != NULL ) {
352                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
353                         e = NULL;
354                 }
355                 Debug(LDAP_DEBUG_TRACE,
356                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
357
358                 rs->sr_err = TXN_ABORT( ltid );
359                 ltid = NULL;
360                 op->o_private = NULL;
361                 op->o_do_not_cache = opinfo.boi_acl_cache;
362                 if( rs->sr_err != 0 ) {
363                         rs->sr_err = LDAP_OTHER;
364                         rs->sr_text = "internal error";
365                         goto return_results;
366                 }
367                 if ( op->o_abandon ) {
368                         rs->sr_err = SLAPD_ABANDON;
369                         goto return_results;
370                 }
371                 bdb_trans_backoff( ++num_retries );
372         }
373
374         /* begin transaction */
375         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
376                 bdb->bi_db_opflags );
377         rs->sr_text = NULL;
378         if( rs->sr_err != 0 ) {
379                 Debug( LDAP_DEBUG_TRACE,
380                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
381                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
382                 rs->sr_err = LDAP_OTHER;
383                 rs->sr_text = "internal error";
384                 goto return_results;
385         }
386
387         locker = TXN_ID ( ltid );
388
389         opinfo.boi_bdb = op->o_bd;
390         opinfo.boi_txn = ltid;
391         opinfo.boi_locker = locker;
392         opinfo.boi_err = 0;
393         opinfo.boi_acl_cache = op->o_do_not_cache;
394         op->o_private = &opinfo;
395
396         /* get entry or ancestor */
397         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
398                 locker, &lock );
399
400         if ( rs->sr_err != 0 ) {
401                 Debug( LDAP_DEBUG_TRACE,
402                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
403                         rs->sr_err, 0, 0 );
404                 switch( rs->sr_err ) {
405                 case DB_LOCK_DEADLOCK:
406                 case DB_LOCK_NOTGRANTED:
407                         goto retry;
408                 case DB_NOTFOUND:
409                         if ( BER_BVISEMPTY( &op->o_req_ndn )) {
410                                 struct berval gluebv = BER_BVC("glue");
411                                 e = ch_calloc( 1, sizeof(Entry));
412                                 e->e_name.bv_val = ch_strdup( "" );
413                                 ber_dupbv( &e->e_nname, &e->e_name );
414                                 attr_merge_one( e, slap_schema.si_ad_objectClass,
415                                         &gluebv, NULL );
416                                 attr_merge_one( e, slap_schema.si_ad_structuralObjectClass,
417                                         &gluebv, NULL );
418                                 e->e_private = ei;
419                                 fakeroot = 1;
420                                 rs->sr_err = 0;
421                         }
422                         break;
423                 case LDAP_BUSY:
424                         rs->sr_text = "ldap server busy";
425                         goto return_results;
426                 default:
427                         rs->sr_err = LDAP_OTHER;
428                         rs->sr_text = "internal error";
429                         goto return_results;
430                 }
431         }
432
433         if ( !fakeroot ) {
434                 e = ei->bei_e;
435         }
436
437         /* acquire and lock entry */
438         /* FIXME: dn2entry() should return non-glue entry */
439         if (( rs->sr_err == DB_NOTFOUND ) ||
440                 ( !manageDSAit && e && is_entry_glue( e )))
441         {
442                 if ( e != NULL ) {
443                         rs->sr_matched = ch_strdup( e->e_dn );
444                         rs->sr_ref = is_entry_referral( e )
445                                 ? get_entry_referrals( op, e )
446                                 : NULL;
447                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
448                         e = NULL;
449
450                 } else {
451                         rs->sr_ref = referral_rewrite( default_referral, NULL,
452                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
453                 }
454
455                 rs->sr_err = LDAP_REFERRAL;
456                 send_ldap_result( op, rs );
457
458                 if ( rs->sr_ref != default_referral ) {
459                         ber_bvarray_free( rs->sr_ref );
460                 }
461                 free( (char *)rs->sr_matched );
462                 rs->sr_ref = NULL;
463                 rs->sr_matched = NULL;
464
465                 goto done;
466         }
467
468         if ( !manageDSAit && is_entry_referral( e ) ) {
469                 /* entry is a referral, don't allow modify */
470                 rs->sr_ref = get_entry_referrals( op, e );
471
472                 Debug( LDAP_DEBUG_TRACE,
473                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
474                         0, 0, 0 );
475
476                 rs->sr_err = LDAP_REFERRAL;
477                 rs->sr_matched = e->e_name.bv_val;
478                 send_ldap_result( op, rs );
479
480                 ber_bvarray_free( rs->sr_ref );
481                 rs->sr_ref = NULL;
482                 rs->sr_matched = NULL;
483                 goto done;
484         }
485
486         if ( get_assert( op ) &&
487                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
488         {
489                 rs->sr_err = LDAP_ASSERTION_FAILED;
490                 goto return_results;
491         }
492
493         if( op->o_preread ) {
494                 if( preread_ctrl == NULL ) {
495                         preread_ctrl = &ctrls[num_ctrls++];
496                         ctrls[num_ctrls] = NULL;
497                 }
498                 if ( slap_read_controls( op, rs, e,
499                         &slap_pre_read_bv, preread_ctrl ) )
500                 {
501                         Debug( LDAP_DEBUG_TRACE,
502                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read failed!\n",
503                                 0, 0, 0 );
504                         goto return_results;
505                 }
506         }
507
508         /* nested transaction */
509         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
510         rs->sr_text = NULL;
511         if( rs->sr_err != 0 ) {
512                 Debug( LDAP_DEBUG_TRACE,
513                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
514                         db_strerror(rs->sr_err), rs->sr_err, 0 );
515                 rs->sr_err = LDAP_OTHER;
516                 rs->sr_text = "internal error";
517                 goto return_results;
518         }
519         /* Modify the entry */
520         dummy = *e;
521         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
522                 &dummy, &rs->sr_text, textbuf, textlen );
523
524         if( rs->sr_err != LDAP_SUCCESS ) {
525                 Debug( LDAP_DEBUG_TRACE,
526                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
527                         rs->sr_err, 0, 0 );
528                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
529                         rs->sr_err = opinfo.boi_err;
530                 }
531                 /* Only free attrs if they were dup'd.  */
532                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
533                 switch( rs->sr_err ) {
534                 case DB_LOCK_DEADLOCK:
535                 case DB_LOCK_NOTGRANTED:
536                         goto retry;
537                 }
538                 goto return_results;
539         }
540
541         /* change the entry itself */
542         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
543         if ( rs->sr_err != 0 ) {
544                 Debug( LDAP_DEBUG_TRACE,
545                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
546                         rs->sr_err, 0, 0 );
547                 switch( rs->sr_err ) {
548                 case DB_LOCK_DEADLOCK:
549                 case DB_LOCK_NOTGRANTED:
550                         goto retry;
551                 }
552                 rs->sr_text = "entry update failed";
553                 goto return_results;
554         }
555
556         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
557                 rs->sr_err = LDAP_OTHER;
558                 rs->sr_text = "txn_commit(2) failed";
559                 goto return_results;
560         }
561
562         if( op->o_postread ) {
563                 if( postread_ctrl == NULL ) {
564                         postread_ctrl = &ctrls[num_ctrls++];
565                         ctrls[num_ctrls] = NULL;
566                 }
567                 if( slap_read_controls( op, rs, &dummy,
568                         &slap_post_read_bv, postread_ctrl ) )
569                 {
570                         Debug( LDAP_DEBUG_TRACE,
571                                 "<=- " LDAP_XSTRING(bdb_modify)
572                                 ": post-read failed!\n", 0, 0, 0 );
573                         goto return_results;
574                 }
575         }
576
577         if( op->o_noop ) {
578                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
579                         rs->sr_text = "txn_abort (no-op) failed";
580                 } else {
581                         rs->sr_err = LDAP_X_NO_OPERATION;
582                         ltid = NULL;
583                         goto return_results;
584                 }
585         } else {
586                 /* may have changed in bdb_modify_internal() */
587                 e->e_ocflags = dummy.e_ocflags;
588                 if ( fakeroot ) {
589                         e->e_private = NULL;
590                         entry_free( e );
591                         e = NULL;
592                         attrs_free( dummy.e_attrs );
593
594                 } else {
595                         rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
596                         switch( rc ) {
597                         case DB_LOCK_DEADLOCK:
598                         case DB_LOCK_NOTGRANTED:
599                                 goto retry;
600                         }
601                 }
602                 dummy.e_attrs = NULL;
603
604                 rs->sr_err = TXN_COMMIT( ltid, 0 );
605         }
606         ltid = NULL;
607         op->o_private = NULL;
608
609         if( rs->sr_err != 0 ) {
610                 Debug( LDAP_DEBUG_TRACE,
611                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
612                         op->o_noop ? "abort (no-op)" : "commit",
613                         db_strerror(rs->sr_err), rs->sr_err );
614                 rs->sr_err = LDAP_OTHER;
615                 rs->sr_text = "commit failed";
616
617                 goto return_results;
618         }
619
620         Debug( LDAP_DEBUG_TRACE,
621                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
622                 op->o_noop ? " (no-op)" : "",
623                 dummy.e_id, op->o_req_dn.bv_val );
624
625         rs->sr_err = LDAP_SUCCESS;
626         rs->sr_text = NULL;
627         if( num_ctrls ) rs->sr_ctrls = ctrls;
628
629 return_results:
630         if( dummy.e_attrs ) {
631                 attrs_free( dummy.e_attrs );
632         }
633         send_ldap_result( op, rs );
634
635         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
636                 TXN_CHECKPOINT( bdb->bi_dbenv,
637                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
638         }
639
640 done:
641         slap_graduate_commit_csn( op );
642
643         if( ltid != NULL ) {
644                 TXN_ABORT( ltid );
645         }
646         op->o_private = NULL;
647
648         if( e != NULL ) {
649                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
650         }
651
652         if( preread_ctrl != NULL ) {
653                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
654                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
655         }
656         if( postread_ctrl != NULL ) {
657                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
658                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
659         }
660         return rs->sr_err;
661 }