]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
Fix negative caching again, be sure it's really from zero entries returned
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2006 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 int bdb_modify_internal(
31         Operation *op,
32         DB_TXN *tid,
33         Modifications *modlist,
34         Entry *e,
35         const char **text,
36         char *textbuf,
37         size_t textlen )
38 {
39         int rc, err;
40         Modification    *mod;
41         Modifications   *ml;
42         Attribute       *save_attrs;
43         Attribute       *ap;
44         int                     glue_attr_delete = 0;
45
46         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
47                 e->e_id, e->e_dn, 0);
48
49         if ( !acl_check_modlist( op, e, modlist )) {
50                 return LDAP_INSUFFICIENT_ACCESS;
51         }
52
53         /* save_attrs will be disposed of by bdb_cache_modify */
54         save_attrs = e->e_attrs;
55         e->e_attrs = attrs_dup( e->e_attrs );
56
57         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
58                 int match;
59                 mod = &ml->sml_mod;
60                 switch( mod->sm_op ) {
61                 case LDAP_MOD_ADD:
62                 case LDAP_MOD_REPLACE:
63                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
64                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
65                                         slap_schema.si_ad_structuralObjectClass->
66                                                 ad_type->sat_equality,
67                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
68                                         &mod->sm_values[0], &scbva[0], text );
69                                 if ( !match ) glue_attr_delete = 1;
70                         }
71                 }
72                 if ( glue_attr_delete )
73                         break;
74         }
75
76         if ( glue_attr_delete ) {
77                 Attribute       **app = &e->e_attrs;
78                 while ( *app != NULL ) {
79                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
80                                 Attribute *save = *app;
81                                 *app = (*app)->a_next;
82                                 attr_free( save );
83                                 continue;
84                         }
85                         app = &(*app)->a_next;
86                 }
87         }
88
89         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
90                 mod = &ml->sml_mod;
91
92                 switch ( mod->sm_op ) {
93                 case LDAP_MOD_ADD:
94                         Debug(LDAP_DEBUG_ARGS,
95                                 "bdb_modify_internal: add %s\n",
96                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
97                         err = modify_add_values( e, mod, get_permissiveModify(op),
98                                 text, textbuf, textlen );
99                         if( err != LDAP_SUCCESS ) {
100                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
101                                         err, *text, 0);
102                         }
103                         break;
104
105                 case LDAP_MOD_DELETE:
106                         if ( glue_attr_delete ) {
107                                 err = LDAP_SUCCESS;
108                                 break;
109                         }
110
111                         Debug(LDAP_DEBUG_ARGS,
112                                 "bdb_modify_internal: delete %s\n",
113                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
114                         err = modify_delete_values( e, mod, get_permissiveModify(op),
115                                 text, textbuf, textlen );
116                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
117                         if( err != LDAP_SUCCESS ) {
118                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
119                                         err, *text, 0);
120                         }
121                         break;
122
123                 case LDAP_MOD_REPLACE:
124                         Debug(LDAP_DEBUG_ARGS,
125                                 "bdb_modify_internal: replace %s\n",
126                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
127                         err = modify_replace_values( e, mod, get_permissiveModify(op),
128                                 text, textbuf, textlen );
129                         if( err != LDAP_SUCCESS ) {
130                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
131                                         err, *text, 0);
132                         }
133                         break;
134
135                 case LDAP_MOD_INCREMENT:
136                         Debug(LDAP_DEBUG_ARGS,
137                                 "bdb_modify_internal: increment %s\n",
138                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
139                         err = modify_increment_values( e, mod, get_permissiveModify(op),
140                                 text, textbuf, textlen );
141                         if( err != LDAP_SUCCESS ) {
142                                 Debug(LDAP_DEBUG_ARGS,
143                                         "bdb_modify_internal: %d %s\n",
144                                         err, *text, 0);
145                         }
146                         break;
147
148                 case SLAP_MOD_SOFTADD:
149                         Debug(LDAP_DEBUG_ARGS,
150                                 "bdb_modify_internal: softadd %s\n",
151                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
152                         /* Avoid problems in index_add_mods()
153                          * We need to add index if necessary.
154                          */
155                         mod->sm_op = LDAP_MOD_ADD;
156
157                         err = modify_add_values( e, mod, get_permissiveModify(op),
158                                 text, textbuf, textlen );
159
160                         mod->sm_op = SLAP_MOD_SOFTADD;
161
162                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
163                                 err = LDAP_SUCCESS;
164                         }
165
166                         if( err != LDAP_SUCCESS ) {
167                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
168                                         err, *text, 0);
169                         }
170                         break;
171
172                 default:
173                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
174                                 mod->sm_op, 0, 0);
175                         *text = "Invalid modify operation";
176                         err = LDAP_OTHER;
177                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
178                                 err, *text, 0);
179                 }
180
181                 if ( err != LDAP_SUCCESS ) {
182                         attrs_free( e->e_attrs );
183                         e->e_attrs = save_attrs;
184                         /* unlock entry, delete from cache */
185                         return err; 
186                 }
187
188                 /* If objectClass was modified, reset the flags */
189                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
190                         e->e_ocflags = 0;
191                 }
192
193                 if ( glue_attr_delete ) e->e_ocflags = 0;
194
195                 /* check if modified attribute was indexed
196                  * but not in case of NOOP... */
197                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
198                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
199                         ap = attr_find( save_attrs, mod->sm_desc );
200                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
201
202                         ap = attr_find( e->e_attrs, mod->sm_desc );
203                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
204                 }
205         }
206
207         /* check that the entry still obeys the schema */
208         rc = entry_schema_check( op, e, save_attrs, get_manageDIT(op),
209                 text, textbuf, textlen );
210         if ( rc != LDAP_SUCCESS || op->o_noop ) {
211                 attrs_free( e->e_attrs );
212                 /* clear the indexing flags */
213                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
214                         ap->a_flags = 0;
215                 }
216                 e->e_attrs = save_attrs;
217
218                 if ( rc != LDAP_SUCCESS ) {
219                         Debug( LDAP_DEBUG_ANY,
220                                 "entry failed schema check: %s\n",
221                                 *text, 0, 0 );
222                 }
223
224                 /* if NOOP then silently revert to saved attrs */
225                 return rc;
226         }
227
228         /* update the indices of the modified attributes */
229
230         /* start with deleting the old index entries */
231         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
232                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
233                         rc = bdb_index_values( op, tid, ap->a_desc,
234                                 ap->a_nvals,
235                                 e->e_id, SLAP_INDEX_DELETE_OP );
236                         if ( rc != LDAP_SUCCESS ) {
237                                 attrs_free( e->e_attrs );
238                                 e->e_attrs = save_attrs;
239                                 Debug( LDAP_DEBUG_ANY,
240                                        "Attribute index delete failure",
241                                        0, 0, 0 );
242                                 return rc;
243                         }
244                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
245                 }
246         }
247
248         /* add the new index entries */
249         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
250                 if (ap->a_flags & SLAP_ATTR_IXADD) {
251                         rc = bdb_index_values( op, tid, ap->a_desc,
252                                 ap->a_nvals,
253                                 e->e_id, SLAP_INDEX_ADD_OP );
254                         if ( rc != LDAP_SUCCESS ) {
255                                 attrs_free( e->e_attrs );
256                                 e->e_attrs = save_attrs;
257                                 Debug( LDAP_DEBUG_ANY,
258                                        "Attribute index add failure",
259                                        0, 0, 0 );
260                                 return rc;
261                         }
262                         ap->a_flags &= ~SLAP_ATTR_IXADD;
263                 }
264         }
265
266         return rc;
267 }
268
269
270 int
271 bdb_modify( Operation *op, SlapReply *rs )
272 {
273         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
274         Entry           *e = NULL;
275         EntryInfo       *ei = NULL;
276         int             manageDSAit = get_manageDSAit( op );
277         char textbuf[SLAP_TEXT_BUFLEN];
278         size_t textlen = sizeof textbuf;
279         DB_TXN  *ltid = NULL, *lt2;
280         struct bdb_op_info opinfo = {0};
281         Entry           dummy = {0};
282         int                     fakeroot = 0;
283
284         u_int32_t       locker = 0;
285         DB_LOCK         lock;
286
287         int             num_retries = 0;
288
289         LDAPControl **preread_ctrl = NULL;
290         LDAPControl **postread_ctrl = NULL;
291         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
292         int num_ctrls = 0;
293
294         int rc;
295
296         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
297                 op->o_req_dn.bv_val, 0, 0 );
298
299         ctrls[num_ctrls] = NULL;
300
301         if ( !SLAP_SHADOW( op->o_bd ))
302                 slap_mods_opattrs( op, &op->orm_modlist, 1 );
303
304         if( 0 ) {
305 retry:  /* transaction retry */
306                 if ( dummy.e_attrs ) {
307                         attrs_free( dummy.e_attrs );
308                         dummy.e_attrs = NULL;
309                 }
310                 if( e != NULL ) {
311                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
312                         e = NULL;
313                 }
314                 Debug(LDAP_DEBUG_TRACE,
315                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
316
317                 rs->sr_err = TXN_ABORT( ltid );
318                 ltid = NULL;
319                 op->o_private = NULL;
320                 op->o_do_not_cache = opinfo.boi_acl_cache;
321                 if( rs->sr_err != 0 ) {
322                         rs->sr_err = LDAP_OTHER;
323                         rs->sr_text = "internal error";
324                         goto return_results;
325                 }
326                 if ( op->o_abandon ) {
327                         rs->sr_err = SLAPD_ABANDON;
328                         goto return_results;
329                 }
330                 bdb_trans_backoff( ++num_retries );
331         }
332
333         /* begin transaction */
334         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
335                 bdb->bi_db_opflags );
336         rs->sr_text = NULL;
337         if( rs->sr_err != 0 ) {
338                 Debug( LDAP_DEBUG_TRACE,
339                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
340                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
341                 rs->sr_err = LDAP_OTHER;
342                 rs->sr_text = "internal error";
343                 goto return_results;
344         }
345
346         locker = TXN_ID ( ltid );
347
348         opinfo.boi_bdb = op->o_bd;
349         opinfo.boi_txn = ltid;
350         opinfo.boi_locker = locker;
351         opinfo.boi_err = 0;
352         opinfo.boi_acl_cache = op->o_do_not_cache;
353         op->o_private = &opinfo;
354
355         /* get entry or ancestor */
356         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
357                 locker, &lock );
358
359         if ( rs->sr_err != 0 ) {
360                 Debug( LDAP_DEBUG_TRACE,
361                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
362                         rs->sr_err, 0, 0 );
363                 switch( rs->sr_err ) {
364                 case DB_LOCK_DEADLOCK:
365                 case DB_LOCK_NOTGRANTED:
366                         goto retry;
367                 case DB_NOTFOUND:
368                         if ( BER_BVISEMPTY( &op->o_req_ndn )) {
369                                 struct berval gluebv = BER_BVC("glue");
370                                 e = ch_calloc( 1, sizeof(Entry));
371                                 e->e_name.bv_val = ch_strdup( "" );
372                                 ber_dupbv( &e->e_nname, &e->e_name );
373                                 attr_merge_one( e, slap_schema.si_ad_objectClass,
374                                         &gluebv, NULL );
375                                 attr_merge_one( e, slap_schema.si_ad_structuralObjectClass,
376                                         &gluebv, NULL );
377                                 e->e_private = ei;
378                                 fakeroot = 1;
379                                 rs->sr_err = 0;
380                         }
381                         break;
382                 case LDAP_BUSY:
383                         rs->sr_text = "ldap server busy";
384                         goto return_results;
385                 default:
386                         rs->sr_err = LDAP_OTHER;
387                         rs->sr_text = "internal error";
388                         goto return_results;
389                 }
390         }
391
392         if ( !fakeroot ) {
393                 e = ei->bei_e;
394         }
395
396         /* acquire and lock entry */
397         /* FIXME: dn2entry() should return non-glue entry */
398         if (( rs->sr_err == DB_NOTFOUND ) ||
399                 ( !manageDSAit && e && is_entry_glue( e )))
400         {
401                 if ( e != NULL ) {
402                         rs->sr_matched = ch_strdup( e->e_dn );
403                         rs->sr_ref = is_entry_referral( e )
404                                 ? get_entry_referrals( op, e )
405                                 : NULL;
406                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
407                         e = NULL;
408
409                 } else {
410                         rs->sr_ref = referral_rewrite( default_referral, NULL,
411                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
412                 }
413
414                 rs->sr_err = LDAP_REFERRAL;
415                 send_ldap_result( op, rs );
416
417                 if ( rs->sr_ref != default_referral ) {
418                         ber_bvarray_free( rs->sr_ref );
419                 }
420                 free( (char *)rs->sr_matched );
421                 rs->sr_ref = NULL;
422                 rs->sr_matched = NULL;
423
424                 goto done;
425         }
426
427         if ( !manageDSAit && is_entry_referral( e ) ) {
428                 /* entry is a referral, don't allow modify */
429                 rs->sr_ref = get_entry_referrals( op, e );
430
431                 Debug( LDAP_DEBUG_TRACE,
432                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
433                         0, 0, 0 );
434
435                 rs->sr_err = LDAP_REFERRAL;
436                 rs->sr_matched = e->e_name.bv_val;
437                 send_ldap_result( op, rs );
438
439                 ber_bvarray_free( rs->sr_ref );
440                 rs->sr_ref = NULL;
441                 rs->sr_matched = NULL;
442                 goto done;
443         }
444
445         if ( get_assert( op ) &&
446                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
447         {
448                 rs->sr_err = LDAP_ASSERTION_FAILED;
449                 goto return_results;
450         }
451
452         if( op->o_preread ) {
453                 if( preread_ctrl == NULL ) {
454                         preread_ctrl = &ctrls[num_ctrls++];
455                         ctrls[num_ctrls] = NULL;
456                 }
457                 if ( slap_read_controls( op, rs, e,
458                         &slap_pre_read_bv, preread_ctrl ) )
459                 {
460                         Debug( LDAP_DEBUG_TRACE,
461                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read failed!\n",
462                                 0, 0, 0 );
463                         goto return_results;
464                 }
465         }
466
467         /* nested transaction */
468         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
469         rs->sr_text = NULL;
470         if( rs->sr_err != 0 ) {
471                 Debug( LDAP_DEBUG_TRACE,
472                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
473                         db_strerror(rs->sr_err), rs->sr_err, 0 );
474                 rs->sr_err = LDAP_OTHER;
475                 rs->sr_text = "internal error";
476                 goto return_results;
477         }
478         /* Modify the entry */
479         dummy = *e;
480         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
481                 &dummy, &rs->sr_text, textbuf, textlen );
482
483         if( rs->sr_err != LDAP_SUCCESS ) {
484                 Debug( LDAP_DEBUG_TRACE,
485                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
486                         rs->sr_err, 0, 0 );
487                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
488                         rs->sr_err = opinfo.boi_err;
489                 }
490                 /* Only free attrs if they were dup'd.  */
491                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
492                 switch( rs->sr_err ) {
493                 case DB_LOCK_DEADLOCK:
494                 case DB_LOCK_NOTGRANTED:
495                         goto retry;
496                 }
497                 goto return_results;
498         }
499
500         /* change the entry itself */
501         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
502         if ( rs->sr_err != 0 ) {
503                 Debug( LDAP_DEBUG_TRACE,
504                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
505                         rs->sr_err, 0, 0 );
506                 switch( rs->sr_err ) {
507                 case DB_LOCK_DEADLOCK:
508                 case DB_LOCK_NOTGRANTED:
509                         goto retry;
510                 }
511                 rs->sr_text = "entry update failed";
512                 goto return_results;
513         }
514
515         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
516                 rs->sr_err = LDAP_OTHER;
517                 rs->sr_text = "txn_commit(2) failed";
518                 goto return_results;
519         }
520
521         if( op->o_postread ) {
522                 if( postread_ctrl == NULL ) {
523                         postread_ctrl = &ctrls[num_ctrls++];
524                         ctrls[num_ctrls] = NULL;
525                 }
526                 if( slap_read_controls( op, rs, &dummy,
527                         &slap_post_read_bv, postread_ctrl ) )
528                 {
529                         Debug( LDAP_DEBUG_TRACE,
530                                 "<=- " LDAP_XSTRING(bdb_modify)
531                                 ": post-read failed!\n", 0, 0, 0 );
532                         goto return_results;
533                 }
534         }
535
536         if( op->o_noop ) {
537                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
538                         rs->sr_text = "txn_abort (no-op) failed";
539                 } else {
540                         rs->sr_err = LDAP_X_NO_OPERATION;
541                         ltid = NULL;
542                         goto return_results;
543                 }
544         } else {
545                 /* may have changed in bdb_modify_internal() */
546                 e->e_ocflags = dummy.e_ocflags;
547                 if ( fakeroot ) {
548                         e->e_private = NULL;
549                         entry_free( e );
550                         e = NULL;
551                         attrs_free( dummy.e_attrs );
552
553                 } else {
554                         rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
555                         switch( rc ) {
556                         case DB_LOCK_DEADLOCK:
557                         case DB_LOCK_NOTGRANTED:
558                                 goto retry;
559                         }
560                 }
561                 dummy.e_attrs = NULL;
562
563                 rs->sr_err = TXN_COMMIT( ltid, 0 );
564         }
565         ltid = NULL;
566         op->o_private = NULL;
567
568         if( rs->sr_err != 0 ) {
569                 Debug( LDAP_DEBUG_TRACE,
570                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
571                         op->o_noop ? "abort (no-op)" : "commit",
572                         db_strerror(rs->sr_err), rs->sr_err );
573                 rs->sr_err = LDAP_OTHER;
574                 rs->sr_text = "commit failed";
575
576                 goto return_results;
577         }
578
579         Debug( LDAP_DEBUG_TRACE,
580                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
581                 op->o_noop ? " (no-op)" : "",
582                 dummy.e_id, op->o_req_dn.bv_val );
583
584         rs->sr_err = LDAP_SUCCESS;
585         rs->sr_text = NULL;
586         if( num_ctrls ) rs->sr_ctrls = ctrls;
587
588 return_results:
589         if( dummy.e_attrs ) {
590                 attrs_free( dummy.e_attrs );
591         }
592         send_ldap_result( op, rs );
593         if ( !SLAP_SHADOW( op->o_bd ))
594                 slap_graduate_commit_csn( op );
595
596         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
597                 TXN_CHECKPOINT( bdb->bi_dbenv,
598                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
599         }
600
601 done:
602         if( ltid != NULL ) {
603                 TXN_ABORT( ltid );
604         }
605         op->o_private = NULL;
606
607         if( e != NULL ) {
608                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
609         }
610
611         if( preread_ctrl != NULL ) {
612                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
613                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
614         }
615         if( postread_ctrl != NULL ) {
616                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
617                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
618         }
619         return rs->sr_err;
620 }