]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
540280ab5b054e22d63e282c47a9081b50b65bda
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2014 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 static void
31 bdb_modify_idxflags(
32         Operation *op,
33         AttributeDescription *desc,
34         int got_delete,
35         Attribute *newattrs,
36         Attribute *oldattrs )
37 {
38         struct berval   ix_at;
39         AttrInfo        *ai;
40
41         /* check if modified attribute was indexed
42          * but not in case of NOOP... */
43         ai = bdb_index_mask( op->o_bd, desc, &ix_at );
44         if ( ai ) {
45                 if ( got_delete ) {
46                         Attribute       *ap;
47                         struct berval   ix2;
48
49                         ap = attr_find( oldattrs, desc );
50                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
51
52                         /* Find all other attrs that index to same slot */
53                         for ( ap = newattrs; ap; ap = ap->a_next ) {
54                                 ai = bdb_index_mask( op->o_bd, ap->a_desc, &ix2 );
55                                 if ( ai && ix2.bv_val == ix_at.bv_val )
56                                         ap->a_flags |= SLAP_ATTR_IXADD;
57                         }
58
59                 } else {
60                         Attribute       *ap;
61
62                         ap = attr_find( newattrs, desc );
63                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
64                 }
65         }
66 }
67
68 int bdb_modify_internal(
69         Operation *op,
70         DB_TXN *tid,
71         Modifications *modlist,
72         Entry *e,
73         const char **text,
74         char *textbuf,
75         size_t textlen )
76 {
77         int rc, err;
78         Modification    *mod;
79         Modifications   *ml;
80         Attribute       *save_attrs;
81         Attribute       *ap;
82         int                     glue_attr_delete = 0;
83         int                     got_delete;
84
85         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
86                 e->e_id, e->e_dn, 0);
87
88         if ( !acl_check_modlist( op, e, modlist )) {
89                 return LDAP_INSUFFICIENT_ACCESS;
90         }
91
92         /* save_attrs will be disposed of by bdb_cache_modify */
93         save_attrs = e->e_attrs;
94         e->e_attrs = attrs_dup( e->e_attrs );
95
96         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
97                 int match;
98                 mod = &ml->sml_mod;
99                 switch( mod->sm_op ) {
100                 case LDAP_MOD_ADD:
101                 case LDAP_MOD_REPLACE:
102                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
103                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
104                                         slap_schema.si_ad_structuralObjectClass->
105                                                 ad_type->sat_equality,
106                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
107                                         &mod->sm_values[0], &scbva[0], text );
108                                 if ( !match ) glue_attr_delete = 1;
109                         }
110                 }
111                 if ( glue_attr_delete )
112                         break;
113         }
114
115         if ( glue_attr_delete ) {
116                 Attribute       **app = &e->e_attrs;
117                 while ( *app != NULL ) {
118                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
119                                 Attribute *save = *app;
120                                 *app = (*app)->a_next;
121                                 attr_free( save );
122                                 continue;
123                         }
124                         app = &(*app)->a_next;
125                 }
126         }
127
128         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
129                 mod = &ml->sml_mod;
130                 got_delete = 0;
131
132                 switch ( mod->sm_op ) {
133                 case LDAP_MOD_ADD:
134                         Debug(LDAP_DEBUG_ARGS,
135                                 "bdb_modify_internal: add %s\n",
136                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
137                         err = modify_add_values( e, mod, get_permissiveModify(op),
138                                 text, textbuf, textlen );
139                         if( err != LDAP_SUCCESS ) {
140                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
141                                         err, *text, 0);
142                         }
143                         break;
144
145                 case LDAP_MOD_DELETE:
146                         if ( glue_attr_delete ) {
147                                 err = LDAP_SUCCESS;
148                                 break;
149                         }
150
151                         Debug(LDAP_DEBUG_ARGS,
152                                 "bdb_modify_internal: delete %s\n",
153                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
154                         err = modify_delete_values( e, mod, get_permissiveModify(op),
155                                 text, textbuf, textlen );
156                         if( err != LDAP_SUCCESS ) {
157                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
158                                         err, *text, 0);
159                         } else {
160                                 got_delete = 1;
161                         }
162                         break;
163
164                 case LDAP_MOD_REPLACE:
165                         Debug(LDAP_DEBUG_ARGS,
166                                 "bdb_modify_internal: replace %s\n",
167                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
168                         err = modify_replace_values( e, mod, get_permissiveModify(op),
169                                 text, textbuf, textlen );
170                         if( err != LDAP_SUCCESS ) {
171                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
172                                         err, *text, 0);
173                         } else {
174                                 got_delete = 1;
175                         }
176                         break;
177
178                 case LDAP_MOD_INCREMENT:
179                         Debug(LDAP_DEBUG_ARGS,
180                                 "bdb_modify_internal: increment %s\n",
181                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
182                         err = modify_increment_values( e, mod, get_permissiveModify(op),
183                                 text, textbuf, textlen );
184                         if( err != LDAP_SUCCESS ) {
185                                 Debug(LDAP_DEBUG_ARGS,
186                                         "bdb_modify_internal: %d %s\n",
187                                         err, *text, 0);
188                         } else {
189                                 got_delete = 1;
190                         }
191                         break;
192
193                 case SLAP_MOD_SOFTADD:
194                         Debug(LDAP_DEBUG_ARGS,
195                                 "bdb_modify_internal: softadd %s\n",
196                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
197                         /* Avoid problems in index_add_mods()
198                          * We need to add index if necessary.
199                          */
200                         mod->sm_op = LDAP_MOD_ADD;
201
202                         err = modify_add_values( e, mod, get_permissiveModify(op),
203                                 text, textbuf, textlen );
204
205                         mod->sm_op = SLAP_MOD_SOFTADD;
206
207                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
208                                 err = LDAP_SUCCESS;
209                         }
210
211                         if( err != LDAP_SUCCESS ) {
212                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
213                                         err, *text, 0);
214                         }
215                         break;
216
217                 case SLAP_MOD_SOFTDEL:
218                         Debug(LDAP_DEBUG_ARGS,
219                                 "bdb_modify_internal: softdel %s\n",
220                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
221                         /* Avoid problems in index_delete_mods()
222                          * We need to add index if necessary.
223                          */
224                         mod->sm_op = LDAP_MOD_DELETE;
225
226                         err = modify_delete_values( e, mod, get_permissiveModify(op),
227                                 text, textbuf, textlen );
228
229                         mod->sm_op = SLAP_MOD_SOFTDEL;
230
231                         if ( err == LDAP_SUCCESS ) {
232                                 got_delete = 1;
233                         } else if ( err == LDAP_NO_SUCH_ATTRIBUTE ) {
234                                 err = LDAP_SUCCESS;
235                         }
236
237                         if( err != LDAP_SUCCESS ) {
238                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
239                                         err, *text, 0);
240                         }
241                         break;
242
243                 case SLAP_MOD_ADD_IF_NOT_PRESENT:
244                         if ( attr_find( e->e_attrs, mod->sm_desc ) != NULL ) {
245                                 /* skip */
246                                 err = LDAP_SUCCESS;
247                                 break;
248                         }
249
250                         Debug(LDAP_DEBUG_ARGS,
251                                 "bdb_modify_internal: add_if_not_present %s\n",
252                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
253                         /* Avoid problems in index_add_mods()
254                          * We need to add index if necessary.
255                          */
256                         mod->sm_op = LDAP_MOD_ADD;
257
258                         err = modify_add_values( e, mod, get_permissiveModify(op),
259                                 text, textbuf, textlen );
260
261                         mod->sm_op = SLAP_MOD_ADD_IF_NOT_PRESENT;
262
263                         if( err != LDAP_SUCCESS ) {
264                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
265                                         err, *text, 0);
266                         }
267                         break;
268
269                 default:
270                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
271                                 mod->sm_op, 0, 0);
272                         *text = "Invalid modify operation";
273                         err = LDAP_OTHER;
274                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
275                                 err, *text, 0);
276                 }
277
278                 if ( err != LDAP_SUCCESS ) {
279                         attrs_free( e->e_attrs );
280                         e->e_attrs = save_attrs;
281                         /* unlock entry, delete from cache */
282                         return err; 
283                 }
284
285                 /* If objectClass was modified, reset the flags */
286                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
287                         e->e_ocflags = 0;
288                 }
289
290                 if ( glue_attr_delete ) e->e_ocflags = 0;
291
292
293                 /* check if modified attribute was indexed
294                  * but not in case of NOOP... */
295                 if ( !op->o_noop ) {
296                         bdb_modify_idxflags( op, mod->sm_desc, got_delete, e->e_attrs, save_attrs );
297                 }
298         }
299
300         /* check that the entry still obeys the schema */
301         ap = NULL;
302         rc = entry_schema_check( op, e, save_attrs, get_relax(op), 0, &ap,
303                 text, textbuf, textlen );
304         if ( rc != LDAP_SUCCESS || op->o_noop ) {
305                 attrs_free( e->e_attrs );
306                 /* clear the indexing flags */
307                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
308                         ap->a_flags &= ~(SLAP_ATTR_IXADD|SLAP_ATTR_IXDEL);
309                 }
310                 e->e_attrs = save_attrs;
311
312                 if ( rc != LDAP_SUCCESS ) {
313                         Debug( LDAP_DEBUG_ANY,
314                                 "entry failed schema check: %s\n",
315                                 *text, 0, 0 );
316                 }
317
318                 /* if NOOP then silently revert to saved attrs */
319                 return rc;
320         }
321
322         /* structuralObjectClass modified! */
323         if ( ap ) {
324                 assert( ap->a_desc == slap_schema.si_ad_structuralObjectClass );
325                 if ( !op->o_noop ) {
326                         bdb_modify_idxflags( op, slap_schema.si_ad_structuralObjectClass,
327                                 1, e->e_attrs, save_attrs );
328                 }
329         }
330
331         /* update the indices of the modified attributes */
332
333         /* start with deleting the old index entries */
334         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
335                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
336                         struct berval *vals;
337                         Attribute *a2;
338                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
339                         a2 = attr_find( e->e_attrs, ap->a_desc );
340                         if ( a2 ) {
341                                 /* need to detect which values were deleted */
342                                 int i, j;
343                                 /* let add know there were deletes */
344                                 if ( a2->a_flags & SLAP_ATTR_IXADD )
345                                         a2->a_flags |= SLAP_ATTR_IXDEL;
346                                 vals = op->o_tmpalloc( (ap->a_numvals + 1) *
347                                         sizeof(struct berval), op->o_tmpmemctx );
348                                 j = 0;
349                                 for ( i=0; i < ap->a_numvals; i++ ) {
350                                         rc = attr_valfind( a2, SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
351                                                 &ap->a_nvals[i], NULL, op->o_tmpmemctx );
352                                         /* Save deleted values */
353                                         if ( rc == LDAP_NO_SUCH_ATTRIBUTE )
354                                                 vals[j++] = ap->a_nvals[i];
355                                 }
356                                 BER_BVZERO(vals+j);
357                         } else {
358                                 /* attribute was completely deleted */
359                                 vals = ap->a_nvals;
360                         }
361                         rc = 0;
362                         if ( !BER_BVISNULL( vals )) {
363                                 rc = bdb_index_values( op, tid, ap->a_desc,
364                                         vals, e->e_id, SLAP_INDEX_DELETE_OP );
365                                 if ( rc != LDAP_SUCCESS ) {
366                                         Debug( LDAP_DEBUG_ANY,
367                                                 "%s: attribute \"%s\" index delete failure\n",
368                                                 op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
369                                         attrs_free( e->e_attrs );
370                                         e->e_attrs = save_attrs;
371                                 }
372                         }
373                         if ( vals != ap->a_nvals )
374                                 op->o_tmpfree( vals, op->o_tmpmemctx );
375                         if ( rc ) return rc;
376                 }
377         }
378
379         /* add the new index entries */
380         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
381                 if (ap->a_flags & SLAP_ATTR_IXADD) {
382                         ap->a_flags &= ~SLAP_ATTR_IXADD;
383                         if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
384                                 /* if any values were deleted, we must readd index
385                                  * for all remaining values.
386                                  */
387                                 ap->a_flags &= ~SLAP_ATTR_IXDEL;
388                                 rc = bdb_index_values( op, tid, ap->a_desc,
389                                         ap->a_nvals,
390                                         e->e_id, SLAP_INDEX_ADD_OP );
391                         } else {
392                                 int found = 0;
393                                 /* if this was only an add, we only need to index
394                                  * the added values.
395                                  */
396                                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
397                                         struct berval *vals;
398                                         if ( ml->sml_desc != ap->a_desc || !ml->sml_numvals )
399                                                 continue;
400                                         found = 1;
401                                         switch( ml->sml_op ) {
402                                         case LDAP_MOD_ADD:
403                                         case LDAP_MOD_REPLACE:
404                                         case LDAP_MOD_INCREMENT:
405                                         case SLAP_MOD_SOFTADD:
406                                         case SLAP_MOD_ADD_IF_NOT_PRESENT:
407                                                 if ( ml->sml_op == LDAP_MOD_INCREMENT )
408                                                         vals = ap->a_nvals;
409                                                 else if ( ml->sml_nvalues )
410                                                         vals = ml->sml_nvalues;
411                                                 else
412                                                         vals = ml->sml_values;
413                                                 rc = bdb_index_values( op, tid, ap->a_desc,
414                                                         vals, e->e_id, SLAP_INDEX_ADD_OP );
415                                                 break;
416                                         }
417                                         if ( rc )
418                                                 break;
419                                 }
420                                 /* This attr was affected by a modify of a subtype, so
421                                  * there was no direct match in the modlist. Just readd
422                                  * all of its values.
423                                  */
424                                 if ( !found ) {
425                                         rc = bdb_index_values( op, tid, ap->a_desc,
426                                                 ap->a_nvals,
427                                                 e->e_id, SLAP_INDEX_ADD_OP );
428                                 }
429                         }
430                         if ( rc != LDAP_SUCCESS ) {
431                                 Debug( LDAP_DEBUG_ANY,
432                                        "%s: attribute \"%s\" index add failure\n",
433                                         op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
434                                 attrs_free( e->e_attrs );
435                                 e->e_attrs = save_attrs;
436                                 return rc;
437                         }
438                 }
439         }
440
441         return rc;
442 }
443
444
445 int
446 bdb_modify( Operation *op, SlapReply *rs )
447 {
448         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
449         Entry           *e = NULL;
450         EntryInfo       *ei = NULL;
451         int             manageDSAit = get_manageDSAit( op );
452         char textbuf[SLAP_TEXT_BUFLEN];
453         size_t textlen = sizeof textbuf;
454         DB_TXN  *ltid = NULL, *lt2;
455         struct bdb_op_info opinfo = {{{ 0 }}};
456         Entry           dummy = {0};
457
458         DB_LOCK         lock;
459
460         int             num_retries = 0;
461
462         LDAPControl **preread_ctrl = NULL;
463         LDAPControl **postread_ctrl = NULL;
464         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
465         int num_ctrls = 0;
466
467         int rc;
468
469         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
470                 op->o_req_dn.bv_val, 0, 0 );
471
472 #ifdef LDAP_X_TXN
473         if( op->o_txnSpec && txn_preop( op, rs ))
474                 return rs->sr_err;
475 #endif
476
477         ctrls[num_ctrls] = NULL;
478
479         /* Don't touch the opattrs, if this is a contextCSN update
480          * initiated from updatedn */
481         if ( !be_isupdate(op) || !op->orm_modlist || op->orm_modlist->sml_next ||
482                  op->orm_modlist->sml_desc != slap_schema.si_ad_contextCSN ) {
483
484                 slap_mods_opattrs( op, &op->orm_modlist, 1 );
485         }
486
487         if( 0 ) {
488 retry:  /* transaction retry */
489                 if ( dummy.e_attrs ) {
490                         attrs_free( dummy.e_attrs );
491                         dummy.e_attrs = NULL;
492                 }
493                 if( e != NULL ) {
494                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
495                         e = NULL;
496                 }
497                 Debug(LDAP_DEBUG_TRACE,
498                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
499
500                 rs->sr_err = TXN_ABORT( ltid );
501                 ltid = NULL;
502                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
503                 opinfo.boi_oe.oe_key = NULL;
504                 op->o_do_not_cache = opinfo.boi_acl_cache;
505                 if( rs->sr_err != 0 ) {
506                         rs->sr_err = LDAP_OTHER;
507                         rs->sr_text = "internal error";
508                         goto return_results;
509                 }
510                 if ( op->o_abandon ) {
511                         rs->sr_err = SLAPD_ABANDON;
512                         goto return_results;
513                 }
514                 bdb_trans_backoff( ++num_retries );
515         }
516
517         /* begin transaction */
518         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
519                 bdb->bi_db_opflags );
520         rs->sr_text = NULL;
521         if( rs->sr_err != 0 ) {
522                 Debug( LDAP_DEBUG_TRACE,
523                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
524                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
525                 rs->sr_err = LDAP_OTHER;
526                 rs->sr_text = "internal error";
527                 goto return_results;
528         }
529         Debug( LDAP_DEBUG_TRACE, LDAP_XSTRING(bdb_modify) ": txn1 id: %x\n",
530                 ltid->id(ltid), 0, 0 );
531
532         opinfo.boi_oe.oe_key = bdb;
533         opinfo.boi_txn = ltid;
534         opinfo.boi_err = 0;
535         opinfo.boi_acl_cache = op->o_do_not_cache;
536         LDAP_SLIST_INSERT_HEAD( &op->o_extra, &opinfo.boi_oe, oe_next );
537
538         /* get entry or ancestor */
539         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
540                 &lock );
541
542         if ( rs->sr_err != 0 ) {
543                 Debug( LDAP_DEBUG_TRACE,
544                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
545                         rs->sr_err, 0, 0 );
546                 switch( rs->sr_err ) {
547                 case DB_LOCK_DEADLOCK:
548                 case DB_LOCK_NOTGRANTED:
549                         goto retry;
550                 case DB_NOTFOUND:
551                         break;
552                 case LDAP_BUSY:
553                         rs->sr_text = "ldap server busy";
554                         goto return_results;
555                 default:
556                         rs->sr_err = LDAP_OTHER;
557                         rs->sr_text = "internal error";
558                         goto return_results;
559                 }
560         }
561
562         e = ei->bei_e;
563
564         /* acquire and lock entry */
565         /* FIXME: dn2entry() should return non-glue entry */
566         if (( rs->sr_err == DB_NOTFOUND ) ||
567                 ( !manageDSAit && e && is_entry_glue( e )))
568         {
569                 if ( e != NULL ) {
570                         rs->sr_matched = ch_strdup( e->e_dn );
571                         rs->sr_ref = is_entry_referral( e )
572                                 ? get_entry_referrals( op, e )
573                                 : NULL;
574                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
575                         e = NULL;
576
577                 } else {
578                         rs->sr_ref = referral_rewrite( default_referral, NULL,
579                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
580                 }
581
582                 rs->sr_err = LDAP_REFERRAL;
583                 send_ldap_result( op, rs );
584
585                 if ( rs->sr_ref != default_referral ) {
586                         ber_bvarray_free( rs->sr_ref );
587                 }
588                 free( (char *)rs->sr_matched );
589                 rs->sr_ref = NULL;
590                 rs->sr_matched = NULL;
591
592                 goto done;
593         }
594
595         if ( !manageDSAit && is_entry_referral( e ) ) {
596                 /* entry is a referral, don't allow modify */
597                 rs->sr_ref = get_entry_referrals( op, e );
598
599                 Debug( LDAP_DEBUG_TRACE,
600                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
601                         0, 0, 0 );
602
603                 rs->sr_err = LDAP_REFERRAL;
604                 rs->sr_matched = e->e_name.bv_val;
605                 send_ldap_result( op, rs );
606
607                 ber_bvarray_free( rs->sr_ref );
608                 rs->sr_ref = NULL;
609                 rs->sr_matched = NULL;
610                 goto done;
611         }
612
613         if ( get_assert( op ) &&
614                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
615         {
616                 rs->sr_err = LDAP_ASSERTION_FAILED;
617                 goto return_results;
618         }
619
620         if( op->o_preread ) {
621                 if( preread_ctrl == NULL ) {
622                         preread_ctrl = &ctrls[num_ctrls++];
623                         ctrls[num_ctrls] = NULL;
624                 }
625                 if ( slap_read_controls( op, rs, e,
626                         &slap_pre_read_bv, preread_ctrl ) )
627                 {
628                         Debug( LDAP_DEBUG_TRACE,
629                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read "
630                                 "failed!\n", 0, 0, 0 );
631                         if ( op->o_preread & SLAP_CONTROL_CRITICAL ) {
632                                 /* FIXME: is it correct to abort
633                                  * operation if control fails? */
634                                 goto return_results;
635                         }
636                 }
637         }
638
639         /* nested transaction */
640         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
641         rs->sr_text = NULL;
642         if( rs->sr_err != 0 ) {
643                 Debug( LDAP_DEBUG_TRACE,
644                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
645                         db_strerror(rs->sr_err), rs->sr_err, 0 );
646                 rs->sr_err = LDAP_OTHER;
647                 rs->sr_text = "internal error";
648                 goto return_results;
649         }
650         Debug( LDAP_DEBUG_TRACE, LDAP_XSTRING(bdb_modify) ": txn2 id: %x\n",
651                 lt2->id(lt2), 0, 0 );
652         /* Modify the entry */
653         dummy = *e;
654         rs->sr_err = bdb_modify_internal( op, lt2, op->orm_modlist,
655                 &dummy, &rs->sr_text, textbuf, textlen );
656
657         if( rs->sr_err != LDAP_SUCCESS ) {
658                 Debug( LDAP_DEBUG_TRACE,
659                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
660                         rs->sr_err, 0, 0 );
661                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
662                         rs->sr_err = opinfo.boi_err;
663                 }
664                 /* Only free attrs if they were dup'd.  */
665                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
666                 switch( rs->sr_err ) {
667                 case DB_LOCK_DEADLOCK:
668                 case DB_LOCK_NOTGRANTED:
669                         goto retry;
670                 }
671                 goto return_results;
672         }
673
674         /* change the entry itself */
675         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
676         if ( rs->sr_err != 0 ) {
677                 Debug( LDAP_DEBUG_TRACE,
678                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
679                         rs->sr_err, 0, 0 );
680                 switch( rs->sr_err ) {
681                 case DB_LOCK_DEADLOCK:
682                 case DB_LOCK_NOTGRANTED:
683                         goto retry;
684                 }
685                 rs->sr_text = "entry update failed";
686                 goto return_results;
687         }
688
689         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
690                 rs->sr_err = LDAP_OTHER;
691                 rs->sr_text = "txn_commit(2) failed";
692                 goto return_results;
693         }
694
695         if( op->o_postread ) {
696                 if( postread_ctrl == NULL ) {
697                         postread_ctrl = &ctrls[num_ctrls++];
698                         ctrls[num_ctrls] = NULL;
699                 }
700                 if( slap_read_controls( op, rs, &dummy,
701                         &slap_post_read_bv, postread_ctrl ) )
702                 {
703                         Debug( LDAP_DEBUG_TRACE,
704                                 "<=- " LDAP_XSTRING(bdb_modify)
705                                 ": post-read failed!\n", 0, 0, 0 );
706                         if ( op->o_postread & SLAP_CONTROL_CRITICAL ) {
707                                 /* FIXME: is it correct to abort
708                                  * operation if control fails? */
709                                 goto return_results;
710                         }
711                 }
712         }
713
714         if( op->o_noop ) {
715                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
716                         rs->sr_text = "txn_abort (no-op) failed";
717                 } else {
718                         rs->sr_err = LDAP_X_NO_OPERATION;
719                         ltid = NULL;
720                         /* Only free attrs if they were dup'd.  */
721                         if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
722                         goto return_results;
723                 }
724         } else {
725                 /* may have changed in bdb_modify_internal() */
726                 e->e_ocflags = dummy.e_ocflags;
727                 rc = bdb_cache_modify( bdb, e, dummy.e_attrs, ltid, &lock );
728                 switch( rc ) {
729                 case DB_LOCK_DEADLOCK:
730                 case DB_LOCK_NOTGRANTED:
731                         goto retry;
732                 }
733                 dummy.e_attrs = NULL;
734
735                 rs->sr_err = TXN_COMMIT( ltid, 0 );
736         }
737         ltid = NULL;
738         LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
739         opinfo.boi_oe.oe_key = NULL;
740
741         if( rs->sr_err != 0 ) {
742                 Debug( LDAP_DEBUG_TRACE,
743                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
744                         op->o_noop ? "abort (no-op)" : "commit",
745                         db_strerror(rs->sr_err), rs->sr_err );
746                 rs->sr_err = LDAP_OTHER;
747                 rs->sr_text = "commit failed";
748
749                 goto return_results;
750         }
751
752         Debug( LDAP_DEBUG_TRACE,
753                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
754                 op->o_noop ? " (no-op)" : "",
755                 dummy.e_id, op->o_req_dn.bv_val );
756
757         rs->sr_err = LDAP_SUCCESS;
758         rs->sr_text = NULL;
759         if( num_ctrls ) rs->sr_ctrls = ctrls;
760
761 return_results:
762         if( dummy.e_attrs ) {
763                 attrs_free( dummy.e_attrs );
764         }
765         send_ldap_result( op, rs );
766
767         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp_kbyte ) {
768                 TXN_CHECKPOINT( bdb->bi_dbenv,
769                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
770         }
771
772 done:
773         slap_graduate_commit_csn( op );
774
775         if( ltid != NULL ) {
776                 TXN_ABORT( ltid );
777         }
778         if ( opinfo.boi_oe.oe_key ) {
779                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
780         }
781
782         if( e != NULL ) {
783                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
784         }
785
786         if( preread_ctrl != NULL && (*preread_ctrl) != NULL ) {
787                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
788                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
789         }
790         if( postread_ctrl != NULL && (*postread_ctrl) != NULL ) {
791                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
792                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
793         }
794
795         rs->sr_text = NULL;
796
797         return rs->sr_err;
798 }