]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
5a1e857d0e92033a87d842313c38a3bf742a985f
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2003 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24 #include "external.h"
25
26 int bdb_modify_internal(
27         Operation *op,
28         DB_TXN *tid,
29         Modifications *modlist,
30         Entry *e,
31         const char **text,
32         char *textbuf,
33         size_t textlen )
34 {
35         int rc, err;
36         Modification    *mod;
37         Modifications   *ml;
38         Attribute       *save_attrs;
39         Attribute       *ap;
40
41 #ifdef NEW_LOGGING
42         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify_internal: 0x%08lx: %s\n", 
43                 e->e_id, e->e_dn, 0 );
44 #else
45         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
46                 e->e_id, e->e_dn, 0);
47 #endif
48
49         if ( !acl_check_modlist( op, e, modlist )) {
50                 return LDAP_INSUFFICIENT_ACCESS;
51         }
52
53         /* save_attrs will be disposed of by bdb_cache_modify */
54         save_attrs = e->e_attrs;
55         e->e_attrs = attrs_dup( e->e_attrs );
56
57         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
58                 mod = &ml->sml_mod;
59
60                 switch ( mod->sm_op ) {
61                 case LDAP_MOD_ADD:
62 #ifdef NEW_LOGGING
63                         LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify_internal: add\n", 0,0,0);
64 #else
65                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
66 #endif
67                         err = modify_add_values( e, mod, get_permissiveModify(op),
68                                 text, textbuf, textlen );
69                         if( err != LDAP_SUCCESS ) {
70 #ifdef NEW_LOGGING
71                                 LDAP_LOG ( OPERATION, ERR, 
72                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
73 #else
74                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
75                                         err, *text, 0);
76 #endif
77                         }
78                         break;
79
80                 case LDAP_MOD_DELETE:
81 #ifdef NEW_LOGGING
82                         LDAP_LOG ( OPERATION, DETAIL1, 
83                                 "bdb_modify_internal: delete\n", 0, 0, 0 );
84 #else
85                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
86 #endif
87                         err = modify_delete_values( e, mod, get_permissiveModify(op),
88                                 text, textbuf, textlen );
89                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
90                         if( err != LDAP_SUCCESS ) {
91 #ifdef NEW_LOGGING
92                                 LDAP_LOG ( OPERATION, ERR, 
93                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
94 #else
95                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
96                                         err, *text, 0);
97 #endif
98                         }
99                         break;
100
101                 case LDAP_MOD_REPLACE:
102 #ifdef NEW_LOGGING
103                         LDAP_LOG ( OPERATION, DETAIL1, 
104                                 "bdb_modify_internal: replace\n", 0, 0, 0 );
105 #else
106                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
107 #endif
108                         err = modify_replace_values( e, mod, get_permissiveModify(op),
109                                 text, textbuf, textlen );
110                         if( err != LDAP_SUCCESS ) {
111 #ifdef NEW_LOGGING
112                                 LDAP_LOG ( OPERATION, ERR, 
113                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
114 #else
115                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
116                                         err, *text, 0);
117 #endif
118                         }
119                         break;
120
121                 case LDAP_MOD_INCREMENT:
122 #ifdef NEW_LOGGING
123                         LDAP_LOG ( OPERATION, DETAIL1, 
124                                 "bdb_modify_internal: increment\n", 0, 0, 0 );
125 #else
126                         Debug(LDAP_DEBUG_ARGS,
127                                 "bdb_modify_internal: increment\n", 0, 0, 0);
128 #endif
129                         err = modify_increment_values( e, mod, get_permissiveModify(op),
130                                 text, textbuf, textlen );
131                         if( err != LDAP_SUCCESS ) {
132 #ifdef NEW_LOGGING
133                                 LDAP_LOG ( OPERATION, ERR, 
134                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
135 #else
136                                 Debug(LDAP_DEBUG_ARGS,
137                                         "bdb_modify_internal: %d %s\n",
138                                         err, *text, 0);
139 #endif
140                         }
141                         break;
142
143                 case SLAP_MOD_SOFTADD:
144 #ifdef NEW_LOGGING
145                         LDAP_LOG ( OPERATION, DETAIL1, 
146                                 "bdb_modify_internal: softadd\n",0,0,0 );
147 #else
148                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
149 #endif
150                         /* Avoid problems in index_add_mods()
151                          * We need to add index if necessary.
152                          */
153                         mod->sm_op = LDAP_MOD_ADD;
154
155                         err = modify_add_values( e, mod, get_permissiveModify(op),
156                                 text, textbuf, textlen );
157
158                         mod->sm_op = SLAP_MOD_SOFTADD;
159
160                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
161                                 err = LDAP_SUCCESS;
162                         }
163
164                         if( err != LDAP_SUCCESS ) {
165 #ifdef NEW_LOGGING
166                                 LDAP_LOG ( OPERATION, ERR, 
167                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
168 #else
169                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
170                                         err, *text, 0);
171 #endif
172                         }
173                         break;
174
175                 default:
176 #ifdef NEW_LOGGING
177                                 LDAP_LOG ( OPERATION, ERR, 
178                                         "bdb_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
179 #else
180                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
181                                 mod->sm_op, 0, 0);
182 #endif
183                         *text = "Invalid modify operation";
184                         err = LDAP_OTHER;
185 #ifdef NEW_LOGGING
186                                 LDAP_LOG ( OPERATION, ERR, 
187                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
188 #else
189                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
190                                 err, *text, 0);
191 #endif
192                 }
193
194                 if ( err != LDAP_SUCCESS ) {
195                         attrs_free( e->e_attrs );
196                         e->e_attrs = save_attrs;
197                         /* unlock entry, delete from cache */
198                         return err; 
199                 }
200
201                 /* If objectClass was modified, reset the flags */
202                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
203                         e->e_ocflags = 0;
204                 }
205
206                 /* check if modified attribute was indexed
207                  * but not in case of NOOP... */
208                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
209                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
210                         ap = attr_find( save_attrs, mod->sm_desc );
211                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
212
213                         ap = attr_find( e->e_attrs, mod->sm_desc );
214                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
215                 }
216         }
217
218         /* check that the entry still obeys the schema */
219         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
220         if ( rc != LDAP_SUCCESS || op->o_noop ) {
221                 attrs_free( e->e_attrs );
222                 e->e_attrs = save_attrs;
223
224                 if ( rc != LDAP_SUCCESS ) {
225 #ifdef NEW_LOGGING
226                         LDAP_LOG ( OPERATION, ERR, "bdb_modify_internal: "
227                                 "entry failed schema check %s\n", 
228                                 *text, 0, 0 );
229 #else
230                         Debug( LDAP_DEBUG_ANY,
231                                 "entry failed schema check: %s\n",
232                                 *text, 0, 0 );
233 #endif
234                 }
235
236                 /* if NOOP then silently revert to saved attrs */
237                 return rc;
238         }
239
240         /* update the indices of the modified attributes */
241
242         /* start with deleting the old index entries */
243         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
244                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
245                         rc = bdb_index_values( op, tid, ap->a_desc,
246                                 ap->a_nvals,
247                                 e->e_id, SLAP_INDEX_DELETE_OP );
248                         if ( rc != LDAP_SUCCESS ) {
249                                 attrs_free( e->e_attrs );
250                                 e->e_attrs = save_attrs;
251 #ifdef NEW_LOGGING
252                                 LDAP_LOG ( OPERATION, ERR, 
253                                         "bdb_modify_internal: attribute index delete failure\n",
254                                         0, 0, 0 );
255 #else
256                                 Debug( LDAP_DEBUG_ANY,
257                                        "Attribute index delete failure",
258                                        0, 0, 0 );
259 #endif
260                                 return rc;
261                         }
262                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
263                 }
264         }
265
266         /* add the new index entries */
267         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
268                 if (ap->a_flags & SLAP_ATTR_IXADD) {
269                         rc = bdb_index_values( op, tid, ap->a_desc,
270                                 ap->a_nvals,
271                                 e->e_id, SLAP_INDEX_ADD_OP );
272                         if ( rc != LDAP_SUCCESS ) {
273                                 attrs_free( e->e_attrs );
274                                 e->e_attrs = save_attrs;
275 #ifdef NEW_LOGGING
276                                 LDAP_LOG ( OPERATION, ERR, 
277                                         "bdb_modify_internal: attribute index add failure\n", 
278                                         0, 0, 0 );
279 #else
280                                 Debug( LDAP_DEBUG_ANY,
281                                        "Attribute index add failure",
282                                        0, 0, 0 );
283 #endif
284                                 return rc;
285                         }
286                         ap->a_flags &= ~SLAP_ATTR_IXADD;
287                 }
288         }
289
290         return rc;
291 }
292
293
294 int
295 bdb_modify( Operation *op, SlapReply *rs )
296 {
297         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
298         Entry           *e = NULL;
299         EntryInfo       *ei = NULL;
300         int             manageDSAit = get_manageDSAit( op );
301         char textbuf[SLAP_TEXT_BUFLEN];
302         size_t textlen = sizeof textbuf;
303         DB_TXN  *ltid = NULL, *lt2;
304         struct bdb_op_info opinfo;
305         Entry           dummy;
306
307         u_int32_t       locker = 0;
308         DB_LOCK         lock;
309
310         int             num_retries = 0;
311
312         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
313         int num_ctrls = 0;
314
315         Operation* ps_list;
316         struct psid_entry *pm_list, *pm_prev;
317         int rc;
318         EntryInfo       *suffix_ei;
319         Entry           *ctxcsn_e;
320         int                     ctxcsn_added = 0;
321
322 #ifdef NEW_LOGGING
323         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
324 #else
325         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
326 #endif
327
328         if( 0 ) {
329 retry:  /* transaction retry */
330                 if( e != NULL ) {
331                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
332                         e = NULL;
333                 }
334 #ifdef NEW_LOGGING
335                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: retrying...\n", 0, 0, 0 );
336 #else
337                 Debug(LDAP_DEBUG_TRACE,
338                         "bdb_modify: retrying...\n", 0, 0, 0);
339 #endif
340
341                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
342                 while ( pm_list != NULL ) {
343                         LDAP_LIST_REMOVE ( pm_list, ps_link );
344                         pm_prev = pm_list;
345                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
346                         ch_free( pm_prev );
347                 }
348
349                 rs->sr_err = TXN_ABORT( ltid );
350                 ltid = NULL;
351                 op->o_private = NULL;
352                 op->o_do_not_cache = opinfo.boi_acl_cache;
353                 if( rs->sr_err != 0 ) {
354                         rs->sr_err = LDAP_OTHER;
355                         rs->sr_text = "internal error";
356                         goto return_results;
357                 }
358                 ldap_pvt_thread_yield();
359                 bdb_trans_backoff( ++num_retries );
360         }
361
362         /* begin transaction */
363         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
364                 bdb->bi_db_opflags );
365         rs->sr_text = NULL;
366         if( rs->sr_err != 0 ) {
367 #ifdef NEW_LOGGING
368                 LDAP_LOG ( OPERATION, DETAIL1, 
369                         "bdb_modify: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
370 #else
371                 Debug( LDAP_DEBUG_TRACE,
372                         "bdb_modify: txn_begin failed: %s (%d)\n",
373                         db_strerror(rs->sr_err), rs->sr_err, 0 );
374 #endif
375                 rs->sr_err = LDAP_OTHER;
376                 rs->sr_text = "internal error";
377                 goto return_results;
378         }
379
380         locker = TXN_ID ( ltid );
381
382         opinfo.boi_bdb = op->o_bd;
383         opinfo.boi_txn = ltid;
384         opinfo.boi_locker = locker;
385         opinfo.boi_err = 0;
386         opinfo.boi_acl_cache = op->o_do_not_cache;
387         op->o_private = &opinfo;
388
389         /* get entry or ancestor */
390         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
391                 locker, &lock );
392
393         if ( rs->sr_err != 0 ) {
394 #ifdef NEW_LOGGING
395                 LDAP_LOG ( OPERATION, DETAIL1, 
396                         "bdb_modify: dn2entry failed: (%d)\n", rs->sr_err, 0, 0 );
397 #else
398                 Debug( LDAP_DEBUG_TRACE,
399                         "bdb_modify: dn2entry failed (%d)\n",
400                         rs->sr_err, 0, 0 );
401 #endif
402                 switch( rs->sr_err ) {
403                 case DB_LOCK_DEADLOCK:
404                 case DB_LOCK_NOTGRANTED:
405                         goto retry;
406                 case DB_NOTFOUND:
407                         break;
408                 case LDAP_BUSY:
409                         rs->sr_text = "ldap server busy";
410                         goto return_results;
411                 default:
412                         rs->sr_err = LDAP_OTHER;
413                         rs->sr_text = "internal error";
414                         goto return_results;
415                 }
416         }
417
418         e = ei->bei_e;
419         /* acquire and lock entry */
420         /* FIXME: dn2entry() should return non-glue entry */
421         if (( rs->sr_err == DB_NOTFOUND ) || ( !manageDSAit && e && is_entry_glue( e ))) {
422                 if ( e != NULL ) {
423                         rs->sr_matched = ch_strdup( e->e_dn );
424                         rs->sr_ref = is_entry_referral( e )
425                                 ? get_entry_referrals( op, e )
426                                 : NULL;
427                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
428                         e = NULL;
429
430                 } else {
431                         BerVarray deref = NULL;
432                         if ( !LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
433                                 syncinfo_t *si;
434                                 LDAP_STAILQ_FOREACH( si, &op->o_bd->be_syncinfo, si_next ) {
435                                         struct berval tmpbv;
436                                         ber_dupbv( &tmpbv, &si->si_provideruri_bv[0] );
437                                         ber_bvarray_add( &deref, &tmpbv );
438                 }
439                         } else {
440                                 deref = default_referral;
441                         }
442                         rs->sr_ref = referral_rewrite( deref, NULL, &op->o_req_dn,
443                                 LDAP_SCOPE_DEFAULT );
444                 }
445
446                 rs->sr_err = LDAP_REFERRAL;
447                 send_ldap_result( op, rs );
448
449                 if ( rs->sr_ref != default_referral ) {
450                         ber_bvarray_free( rs->sr_ref );
451                 }
452                 free( (char *)rs->sr_matched );
453                 rs->sr_ref = NULL;
454                 rs->sr_matched = NULL;
455
456                 goto done;
457         }
458
459         if ( !manageDSAit && is_entry_referral( e ) ) {
460                 /* entry is a referral, don't allow modify */
461                 rs->sr_ref = get_entry_referrals( op, e );
462
463 #ifdef NEW_LOGGING
464                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: entry is referral\n", 0, 0, 0 );
465 #else
466                 Debug( LDAP_DEBUG_TRACE,
467                         "bdb_modify: entry is referral\n",
468                         0, 0, 0 );
469 #endif
470
471                 rs->sr_err = LDAP_REFERRAL;
472                 rs->sr_matched = e->e_name.bv_val;
473                 send_ldap_result( op, rs );
474
475                 ber_bvarray_free( rs->sr_ref );
476                 rs->sr_ref = NULL;
477                 rs->sr_matched = NULL;
478                 goto done;
479         }
480
481         if ( get_assert( op ) &&
482                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
483         {
484                 rs->sr_err = LDAP_ASSERTION_FAILED;
485                 goto return_results;
486         }
487
488         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop && !op->o_no_psearch ) {
489                 ldap_pvt_thread_rdwr_rlock( &bdb->bi_pslist_rwlock );
490                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
491                         bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
492                 }
493                 ldap_pvt_thread_rdwr_runlock( &bdb->bi_pslist_rwlock );
494         }
495
496         if( op->o_preread ) {
497                 if ( slap_read_controls( op, rs, e,
498                         &slap_pre_read_bv, &ctrls[num_ctrls] ) )
499                 {
500 #ifdef NEW_LOGGING
501                         LDAP_LOG ( OPERATION, DETAIL1,
502                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
503 #else
504                         Debug( LDAP_DEBUG_TRACE,
505                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
506 #endif
507                         goto return_results;
508                 }
509                 ctrls[++num_ctrls] = NULL;
510                 op->o_preread = 0; /* prevent redo on retry */
511         }
512
513         /* nested transaction */
514         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
515                 bdb->bi_db_opflags );
516         rs->sr_text = NULL;
517         if( rs->sr_err != 0 ) {
518 #ifdef NEW_LOGGING
519                 LDAP_LOG ( OPERATION, ERR, 
520                         "bdb_modify: txn_begin(2) failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
521 #else
522                 Debug( LDAP_DEBUG_TRACE,
523                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
524                         db_strerror(rs->sr_err), rs->sr_err, 0 );
525 #endif
526                 rs->sr_err = LDAP_OTHER;
527                 rs->sr_text = "internal error";
528                 goto return_results;
529         }
530         /* Modify the entry */
531         dummy = *e;
532         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
533                 &dummy, &rs->sr_text, textbuf, textlen );
534
535         if( rs->sr_err != LDAP_SUCCESS ) {
536 #ifdef NEW_LOGGING
537                 LDAP_LOG ( OPERATION, ERR, 
538                         "bdb_modify: modify failed (%d)\n", rs->sr_err, 0, 0 );
539 #else
540                 Debug( LDAP_DEBUG_TRACE,
541                         "bdb_modify: modify failed (%d)\n",
542                         rs->sr_err, 0, 0 );
543 #endif
544                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
545                         rs->sr_err = opinfo.boi_err;
546                 }
547                 switch( rs->sr_err ) {
548                 case DB_LOCK_DEADLOCK:
549                 case DB_LOCK_NOTGRANTED:
550                         goto retry;
551                 }
552                 goto return_results;
553         }
554
555         if( op->o_postread ) {
556                 if( slap_read_controls( op, rs, e,
557                         &slap_post_read_bv, &ctrls[num_ctrls] ) )
558                 {
559 #ifdef NEW_LOGGING
560                         LDAP_LOG ( OPERATION, DETAIL1,
561                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
562 #else
563                         Debug( LDAP_DEBUG_TRACE,
564                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
565 #endif
566                         goto return_results;
567                 }
568                 ctrls[++num_ctrls] = NULL;
569                 op->o_postread = 0;  /* prevent redo on retry */
570                 /* FIXME: should read entry on the last retry */
571         }
572
573         /* change the entry itself */
574         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
575         if ( rs->sr_err != 0 ) {
576 #ifdef NEW_LOGGING
577                 LDAP_LOG ( OPERATION, ERR, 
578                         "bdb_modify: id2entry update failed (%d)\n", rs->sr_err, 0, 0 );
579 #else
580                 Debug( LDAP_DEBUG_TRACE,
581                         "bdb_modify: id2entry update failed (%d)\n",
582                         rs->sr_err, 0, 0 );
583 #endif
584                 switch( rs->sr_err ) {
585                 case DB_LOCK_DEADLOCK:
586                 case DB_LOCK_NOTGRANTED:
587                         goto retry;
588                 }
589                 rs->sr_text = "entry update failed";
590                 goto return_results;
591         }
592
593         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
594                 rs->sr_err = LDAP_OTHER;
595                 rs->sr_text = "txn_commit(2) failed";
596                 goto return_results;
597         }
598
599         if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
600                 rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
601                         &ctxcsn_e, &ctxcsn_added, locker );
602                 switch ( rc ) {
603                 case BDB_CSN_ABORT :
604                         goto return_results;
605                 case BDB_CSN_RETRY :
606                         goto retry;
607                 }
608         }
609
610         if( op->o_noop ) {
611                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
612                         rs->sr_text = "txn_abort (no-op) failed";
613                 } else {
614                         rs->sr_err = LDAP_NO_OPERATION;
615                         goto return_results;
616                 }
617         } else {
618                 bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
619
620                 if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
621                         if ( ctxcsn_added ) {
622                                 bdb_cache_add( bdb, suffix_ei, ctxcsn_e,
623                                         (struct berval *)&slap_ldapsync_cn_bv, locker );
624                         }
625                 }
626
627                 if ( rs->sr_err == LDAP_SUCCESS ) {
628                         /* Loop through in-scope entries for each psearch spec */
629                         ldap_pvt_thread_rdwr_rlock( &bdb->bi_pslist_rwlock );
630                         LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
631                                 bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
632                         }
633                         ldap_pvt_thread_rdwr_runlock( &bdb->bi_pslist_rwlock );
634                         pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
635                         while ( pm_list != NULL ) {
636                                 bdb_psearch(op, rs, pm_list->ps_op,
637                                                         e, LDAP_PSEARCH_BY_SCOPEOUT);
638                                 LDAP_LIST_REMOVE ( pm_list, ps_link );
639                                 pm_prev = pm_list;
640                                 pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
641                                 ch_free( pm_prev );
642                         }
643                 }
644
645                 rs->sr_err = TXN_COMMIT( ltid, 0 );
646         }
647         ltid = NULL;
648         op->o_private = NULL;
649
650         if( rs->sr_err != 0 ) {
651 #ifdef NEW_LOGGING
652                 LDAP_LOG ( OPERATION, ERR, 
653                         "bdb_modify: txn_%s failed %s (%d)\n", 
654                         op->o_noop ? "abort (no_op)" : "commit",
655                         db_strerror(rs->sr_err), rs->sr_err );
656 #else
657                 Debug( LDAP_DEBUG_TRACE,
658                         "bdb_modify: txn_%s failed: %s (%d)\n",
659                         op->o_noop ? "abort (no-op)" : "commit",
660                         db_strerror(rs->sr_err), rs->sr_err );
661 #endif
662                 rs->sr_err = LDAP_OTHER;
663                 rs->sr_text = "commit failed";
664
665                 goto return_results;
666         }
667
668 #ifdef NEW_LOGGING
669         LDAP_LOG ( OPERATION, DETAIL1, 
670                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n", 
671                 op->o_noop ? " (no_op)" : "", e->e_id, e->e_dn );
672 #else
673         Debug( LDAP_DEBUG_TRACE,
674                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
675                 op->o_noop ? " (no-op)" : "",
676                 e->e_id, e->e_dn );
677 #endif
678
679         rs->sr_err = LDAP_SUCCESS;
680         rs->sr_text = NULL;
681         if( num_ctrls ) rs->sr_ctrls = ctrls;
682
683 return_results:
684         send_ldap_result( op, rs );
685
686         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
687                 ldap_pvt_thread_yield();
688                 TXN_CHECKPOINT( bdb->bi_dbenv,
689                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
690         }
691
692 done:
693         if( ltid != NULL ) {
694                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
695                 while ( pm_list != NULL ) {
696                         LDAP_LIST_REMOVE ( pm_list, ps_link );
697                         pm_prev = pm_list;
698                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
699                         ch_free( pm_prev );
700                 }
701                 TXN_ABORT( ltid );
702                 op->o_private = NULL;
703         }
704
705         if( e != NULL ) {
706                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
707         }
708         return rs->sr_err;
709 }