]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
Don't crash if attr_find() fails (Howard, you might like to review this)
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /*
4  * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
5  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
6  */
7
8 #include "portable.h"
9
10 #include <stdio.h>
11 #include <ac/string.h>
12 #include <ac/time.h>
13
14 #include "back-bdb.h"
15 #include "external.h"
16
17 #define INDEXED 0x2000
18 #define NULLIFIED       0x4000
19
20 int bdb_modify_internal(
21         Operation *op,
22         DB_TXN *tid,
23         Modifications *modlist,
24         Entry *e,
25         const char **text,
26         char *textbuf,
27         size_t textlen )
28 {
29         int rc, err;
30         Modification    *mod;
31         Modifications   *ml;
32         Attribute       *save_attrs;
33         Attribute       *ap;
34
35 #ifdef NEW_LOGGING
36         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify_internal: 0x%08lx: %s\n", 
37                 e->e_id, e->e_dn, 0 );
38 #else
39         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
40                 e->e_id, e->e_dn, 0);
41 #endif
42
43         if ( !acl_check_modlist( op, e, modlist )) {
44                 return LDAP_INSUFFICIENT_ACCESS;
45         }
46
47         /* save_attrs will be disposed of by bdb_cache_modify */
48         save_attrs = e->e_attrs;
49         e->e_attrs = attrs_dup( e->e_attrs );
50
51         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
52                 mod = &ml->sml_mod;
53
54                 switch ( mod->sm_op ) {
55                 case LDAP_MOD_ADD:
56 #ifdef NEW_LOGGING
57                         LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify_internal: add\n", 0,0,0);
58 #else
59                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
60 #endif
61                         err = modify_add_values( e, mod, get_permissiveModify(op),
62                                 text, textbuf, textlen );
63                         if( err != LDAP_SUCCESS ) {
64 #ifdef NEW_LOGGING
65                                 LDAP_LOG ( OPERATION, ERR, 
66                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
67 #else
68                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
69                                         err, *text, 0);
70 #endif
71                         }
72                         break;
73
74                 case LDAP_MOD_DELETE:
75 #ifdef NEW_LOGGING
76                         LDAP_LOG ( OPERATION, DETAIL1, 
77                                 "bdb_modify_internal: delete\n", 0, 0, 0 );
78 #else
79                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
80 #endif
81                         err = modify_delete_values( e, mod, get_permissiveModify(op),
82                                 text, textbuf, textlen );
83                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
84                         if( err != LDAP_SUCCESS ) {
85 #ifdef NEW_LOGGING
86                                 LDAP_LOG ( OPERATION, ERR, 
87                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
88 #else
89                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
90                                         err, *text, 0);
91 #endif
92                         }
93                         break;
94
95                 case LDAP_MOD_REPLACE:
96 #ifdef NEW_LOGGING
97                         LDAP_LOG ( OPERATION, DETAIL1, 
98                                 "bdb_modify_internal: replace\n", 0, 0, 0 );
99 #else
100                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
101 #endif
102                         err = modify_replace_values( e, mod, get_permissiveModify(op),
103                                 text, textbuf, textlen );
104                         if( err != LDAP_SUCCESS ) {
105 #ifdef NEW_LOGGING
106                                 LDAP_LOG ( OPERATION, ERR, 
107                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
108 #else
109                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
110                                         err, *text, 0);
111 #endif
112                         }
113                         break;
114
115                 case SLAP_MOD_SOFTADD:
116 #ifdef NEW_LOGGING
117                         LDAP_LOG ( OPERATION, DETAIL1, 
118                                 "bdb_modify_internal: softadd\n",0,0,0 );
119 #else
120                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
121 #endif
122                         /* Avoid problems in index_add_mods()
123                          * We need to add index if necessary.
124                          */
125                         mod->sm_op = LDAP_MOD_ADD;
126
127                         err = modify_add_values( e, mod, get_permissiveModify(op),
128                                 text, textbuf, textlen );
129
130                         mod->sm_op = SLAP_MOD_SOFTADD;
131
132                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
133                                 err = LDAP_SUCCESS;
134                         }
135
136                         if( err != LDAP_SUCCESS ) {
137 #ifdef NEW_LOGGING
138                                 LDAP_LOG ( OPERATION, ERR, 
139                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
140 #else
141                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
142                                         err, *text, 0);
143 #endif
144                         }
145                         break;
146
147                 default:
148 #ifdef NEW_LOGGING
149                                 LDAP_LOG ( OPERATION, ERR, 
150                                         "bdb_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
151 #else
152                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
153                                 mod->sm_op, 0, 0);
154 #endif
155                         *text = "Invalid modify operation";
156                         err = LDAP_OTHER;
157 #ifdef NEW_LOGGING
158                                 LDAP_LOG ( OPERATION, ERR, 
159                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
160 #else
161                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
162                                 err, *text, 0);
163 #endif
164                 }
165
166                 if ( err != LDAP_SUCCESS ) {
167                         attrs_free( e->e_attrs );
168                         e->e_attrs = save_attrs;
169                         /* unlock entry, delete from cache */
170                         return err; 
171                 }
172
173                 /* If objectClass was modified, reset the flags */
174                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
175                         e->e_ocflags = 0;
176                 }
177         }
178
179         /* check that the entry still obeys the schema */
180         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
181         if ( rc != LDAP_SUCCESS || op->o_noop ) {
182                 attrs_free( e->e_attrs );
183                 e->e_attrs = save_attrs;
184
185                 if ( rc != LDAP_SUCCESS ) {
186 #ifdef NEW_LOGGING
187                         LDAP_LOG ( OPERATION, ERR, "bdb_modify_internal: "
188                                 "entry failed schema check %s\n", 
189                                 *text, 0, 0 );
190 #else
191                         Debug( LDAP_DEBUG_ANY,
192                                 "entry failed schema check: %s\n",
193                                 *text, 0, 0 );
194 #endif
195                 }
196
197                 /* if NOOP then silently revert to saved attrs */
198                 return rc;
199         }
200
201         /* update the indices of the modified attributes */
202         if ( !op->o_noop ) {
203                 Modifications *m2;
204
205                 /* First look for any deletes that would nullify any adds
206                  * in this request. I.e., deleting an entire attribute after
207                  * assigning some values to it.
208                  */
209                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
210                         if (bdb_index_is_indexed( op->o_bd, ml->sml_desc ))
211                                 continue;
212                         switch ( ml->sml_op ) {
213                         case LDAP_MOD_DELETE:
214                                 /* If just deleting specific values, ignore */
215                                 if ( ml->sml_bvalues ) break;
216                         case LDAP_MOD_REPLACE:
217                                 for ( m2 = modlist; m2 != ml; m2 = m2->sml_next ) {
218                                         if ( m2->sml_desc == ml->sml_desc &&
219                                                 m2->sml_op != LDAP_MOD_DELETE )
220                                                 m2->sml_op |= NULLIFIED;
221                                 }
222                                 break;
223                         }
224                         ml->sml_op |= INDEXED;
225                 }
226                 /* Now index the modifications */
227                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
228                         if ( ! (ml->sml_op & INDEXED) ) continue;
229                         ml->sml_op ^= INDEXED;
230                         switch ( ml->sml_op ) {
231                         case LDAP_MOD_DELETE:
232                                 if ( ml->sml_bvalues ) {
233                                         rc = bdb_index_values( op, tid, ml->sml_desc,
234                                                 ml->sml_nvalues ? ml->sml_nvalues : ml->sml_bvalues,
235                                                 e->e_id, SLAP_INDEX_DELETE_OP );
236                                         break;
237                                 }
238                                 /* FALLTHRU */
239                         case LDAP_MOD_REPLACE:
240                         /* A nullified replace still does its delete action */
241                         case LDAP_MOD_REPLACE | NULLIFIED:
242                                 ap = attr_find( save_attrs, ml->sml_desc );
243                                 if ( ap != NULL ) {
244                                         rc = bdb_index_values( op, tid, ap->a_desc,
245                                                 ap->a_nvals,
246                                                 e->e_id, SLAP_INDEX_DELETE_OP );
247                                 } else {
248                                         rc = LDAP_SUCCESS;
249                                 }
250                                 if ( rc || ml->sml_op == LDAP_MOD_DELETE ||
251                                         (ml->sml_op & NULLIFIED))
252                                         break;
253                                 /* FALLTHRU */
254                         case LDAP_MOD_ADD:
255                         case SLAP_MOD_SOFTADD:
256                                 rc = bdb_index_values( op, tid, ml->sml_desc,
257                                         ml->sml_nvalues ? ml->sml_nvalues : ml->sml_bvalues,
258                                         e->e_id, SLAP_INDEX_ADD_OP );
259                                 break;
260                         }
261                         ml->sml_op &= ~NULLIFIED;
262                         if ( rc != LDAP_SUCCESS ) {
263                                 attrs_free( e->e_attrs );
264                                 e->e_attrs = save_attrs;
265 #ifdef NEW_LOGGING
266                                 LDAP_LOG ( OPERATION, ERR, 
267                                         "bdb_modify_internal: attribute index update failure\n",
268                                         0, 0, 0 );
269 #else
270                                 Debug( LDAP_DEBUG_ANY,
271                                        "Attribute index update failure",
272                                        0, 0, 0 );
273 #endif
274                                 /* reset our flags */
275                                 for (; ml; ml=ml->sml_next ) {
276                                         ml->sml_op &= ~(INDEXED | NULLIFIED);
277                                 }
278                                 break;
279                         }
280                 }
281         }
282
283         return rc;
284 }
285
286
287 int
288 bdb_modify( Operation *op, SlapReply *rs )
289 {
290         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
291         Entry           *e = NULL;
292         EntryInfo       *ei = NULL;
293         int             manageDSAit = get_manageDSAit( op );
294         char textbuf[SLAP_TEXT_BUFLEN];
295         size_t textlen = sizeof textbuf;
296         DB_TXN  *ltid = NULL, *lt2;
297         struct bdb_op_info opinfo;
298         Entry           dummy;
299
300         u_int32_t       locker = 0;
301         DB_LOCK         lock;
302
303         int             noop = 0;
304
305 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
306         Operation* ps_list;
307         struct psid_entry *pm_list, *pm_prev;
308 #endif
309
310 #ifdef NEW_LOGGING
311         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
312 #else
313         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
314 #endif
315
316         if( 0 ) {
317 retry:  /* transaction retry */
318                 if( e != NULL ) {
319                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
320                         e = NULL;
321                 }
322 #ifdef NEW_LOGGING
323                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: retrying...\n", 0, 0, 0 );
324 #else
325                 Debug(LDAP_DEBUG_TRACE,
326                         "bdb_modify: retrying...\n", 0, 0, 0);
327 #endif
328
329 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
330                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
331                 while ( pm_list != NULL ) {
332                         LDAP_LIST_REMOVE ( pm_list, ps_link );
333                         pm_prev = pm_list;
334                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
335                         ch_free( pm_prev );
336                 }
337 #endif
338
339                 rs->sr_err = TXN_ABORT( ltid );
340                 ltid = NULL;
341                 op->o_private = NULL;
342                 op->o_do_not_cache = opinfo.boi_acl_cache;
343                 if( rs->sr_err != 0 ) {
344                         rs->sr_err = LDAP_OTHER;
345                         rs->sr_text = "internal error";
346                         goto return_results;
347                 }
348                 ldap_pvt_thread_yield();
349         }
350
351         /* begin transaction */
352         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
353                 bdb->bi_db_opflags );
354         rs->sr_text = NULL;
355         if( rs->sr_err != 0 ) {
356 #ifdef NEW_LOGGING
357                 LDAP_LOG ( OPERATION, DETAIL1, 
358                         "bdb_modify: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
359 #else
360                 Debug( LDAP_DEBUG_TRACE,
361                         "bdb_modify: txn_begin failed: %s (%d)\n",
362                         db_strerror(rs->sr_err), rs->sr_err, 0 );
363 #endif
364                 rs->sr_err = LDAP_OTHER;
365                 rs->sr_text = "internal error";
366                 goto return_results;
367         }
368
369         locker = TXN_ID ( ltid );
370
371         opinfo.boi_bdb = op->o_bd;
372         opinfo.boi_txn = ltid;
373         opinfo.boi_locker = locker;
374         opinfo.boi_err = 0;
375         opinfo.boi_acl_cache = op->o_do_not_cache;
376         op->o_private = &opinfo;
377
378         /* get entry or ancestor */
379         rs->sr_err = bdb_dn2entry( op->o_bd, ltid, &op->o_req_ndn, &ei, 1,
380                 locker, &lock, op->o_tmpmemctx );
381
382         if ( rs->sr_err != 0 ) {
383 #ifdef NEW_LOGGING
384                 LDAP_LOG ( OPERATION, DETAIL1, 
385                         "bdb_modify: dn2entry failed: (%d)\n", rs->sr_err, 0, 0 );
386 #else
387                 Debug( LDAP_DEBUG_TRACE,
388                         "bdb_modify: dn2entry failed (%d)\n",
389                         rs->sr_err, 0, 0 );
390 #endif
391                 switch( rs->sr_err ) {
392                 case DB_LOCK_DEADLOCK:
393                 case DB_LOCK_NOTGRANTED:
394                         goto retry;
395                 case DB_NOTFOUND:
396                         break;
397                 case LDAP_BUSY:
398                         rs->sr_text = "ldap server busy";
399                         goto return_results;
400                 default:
401                         rs->sr_err = LDAP_OTHER;
402                         rs->sr_text = "internal error";
403                         goto return_results;
404                 }
405         }
406
407         e = ei->bei_e;
408         /* acquire and lock entry */
409         if ( rs->sr_err == DB_NOTFOUND ) {
410                 if ( e != NULL ) {
411                         rs->sr_matched = ch_strdup( e->e_dn );
412                         rs->sr_ref = is_entry_referral( e )
413                                 ? get_entry_referrals( op, e )
414                                 : NULL;
415                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
416                         e = NULL;
417
418                 } else {
419                         rs->sr_ref = referral_rewrite( default_referral,
420                                 NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
421                 }
422
423                 rs->sr_err = LDAP_REFERRAL;
424                 send_ldap_result( op, rs );
425
426                 ber_bvarray_free( rs->sr_ref );
427                 free( (char *)rs->sr_matched );
428                 rs->sr_ref = NULL;
429                 rs->sr_matched = NULL;
430
431                 goto done;
432         }
433
434         if ( !manageDSAit && is_entry_referral( e ) ) {
435                 /* entry is a referral, don't allow modify */
436                 rs->sr_ref = get_entry_referrals( op, e );
437
438 #ifdef NEW_LOGGING
439                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: entry is referral\n", 0, 0, 0 );
440 #else
441                 Debug( LDAP_DEBUG_TRACE,
442                         "bdb_modify: entry is referral\n",
443                         0, 0, 0 );
444 #endif
445
446                 rs->sr_err = LDAP_REFERRAL;
447                 rs->sr_matched = e->e_name.bv_val;
448                 send_ldap_result( op, rs );
449
450                 ber_bvarray_free( rs->sr_ref );
451                 rs->sr_ref = NULL;
452                 rs->sr_matched = NULL;
453                 goto done;
454         }
455
456 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
457         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
458                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
459                         bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
460                 }
461         }
462 #endif
463         
464         /* nested transaction */
465         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
466                 bdb->bi_db_opflags );
467         rs->sr_text = NULL;
468         if( rs->sr_err != 0 ) {
469 #ifdef NEW_LOGGING
470                 LDAP_LOG ( OPERATION, ERR, 
471                         "bdb_modify: txn_begin(2) failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
472 #else
473                 Debug( LDAP_DEBUG_TRACE,
474                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
475                         db_strerror(rs->sr_err), rs->sr_err, 0 );
476 #endif
477                 rs->sr_err = LDAP_OTHER;
478                 rs->sr_text = "internal error";
479                 goto return_results;
480         }
481         /* Modify the entry */
482         dummy = *e;
483         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
484                 &dummy, &rs->sr_text, textbuf, textlen );
485
486         if( rs->sr_err != LDAP_SUCCESS ) {
487 #ifdef NEW_LOGGING
488                 LDAP_LOG ( OPERATION, ERR, 
489                         "bdb_modify: modify failed (%d)\n", rs->sr_err, 0, 0 );
490 #else
491                 Debug( LDAP_DEBUG_TRACE,
492                         "bdb_modify: modify failed (%d)\n",
493                         rs->sr_err, 0, 0 );
494 #endif
495                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
496                         rs->sr_err = opinfo.boi_err;
497                 }
498                 switch( rs->sr_err ) {
499                 case DB_LOCK_DEADLOCK:
500                 case DB_LOCK_NOTGRANTED:
501                         goto retry;
502                 }
503                 goto return_results;
504         }
505
506         /* change the entry itself */
507         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
508         if ( rs->sr_err != 0 ) {
509 #ifdef NEW_LOGGING
510                 LDAP_LOG ( OPERATION, ERR, 
511                         "bdb_modify: id2entry update failed (%d)\n", rs->sr_err, 0, 0 );
512 #else
513                 Debug( LDAP_DEBUG_TRACE,
514                         "bdb_modify: id2entry update failed (%d)\n",
515                         rs->sr_err, 0, 0 );
516 #endif
517                 switch( rs->sr_err ) {
518                 case DB_LOCK_DEADLOCK:
519                 case DB_LOCK_NOTGRANTED:
520                         goto retry;
521                 }
522                 rs->sr_text = "entry update failed";
523                 goto return_results;
524         }
525         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
526                 rs->sr_err = LDAP_OTHER;
527                 rs->sr_text = "txn_commit(2) failed";
528                 goto return_results;
529         }
530
531         if( op->o_noop ) {
532                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
533                         rs->sr_text = "txn_abort (no-op) failed";
534                 } else {
535                         noop = 1;
536                         rs->sr_err = LDAP_SUCCESS;
537                 }
538         } else {
539                 bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
540                 rs->sr_err = TXN_COMMIT( ltid, 0 );
541         }
542         ltid = NULL;
543         op->o_private = NULL;
544
545         if( rs->sr_err != 0 ) {
546 #ifdef NEW_LOGGING
547                 LDAP_LOG ( OPERATION, ERR, 
548                         "bdb_modify: txn_%s failed %s (%d)\n", 
549                         op->o_noop ? "abort (no_op)" : "commit", db_strerror(rs->sr_err), rs->sr_err );
550 #else
551                 Debug( LDAP_DEBUG_TRACE,
552                         "bdb_modify: txn_%s failed: %s (%d)\n",
553                         op->o_noop ? "abort (no-op)" : "commit",
554                         db_strerror(rs->sr_err), rs->sr_err );
555 #endif
556                 rs->sr_err = LDAP_OTHER;
557                 rs->sr_text = "commit failed";
558
559         } else {
560 #ifdef NEW_LOGGING
561                 LDAP_LOG ( OPERATION, DETAIL1, 
562                         "bdb_modify: updated%s id=%08lx dn=\"%s\"\n", 
563                         op->o_noop ? " (no_op)" : "", e->e_id, e->e_dn );
564 #else
565                 Debug( LDAP_DEBUG_TRACE,
566                         "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
567                         op->o_noop ? " (no-op)" : "",
568                         e->e_id, e->e_dn );
569 #endif
570                 rs->sr_err = LDAP_SUCCESS;
571                 rs->sr_text = NULL;
572         }
573
574 return_results:
575         send_ldap_result( op, rs );
576
577 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
578         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
579                 /* Loop through in-scope entries for each psearch spec */
580                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
581                         bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
582                 }
583                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
584                 while ( pm_list != NULL ) {
585                         bdb_psearch(op, rs, pm_list->ps_op,
586                                                 e, LDAP_PSEARCH_BY_SCOPEOUT);
587                         LDAP_LIST_REMOVE ( pm_list, ps_link );
588                         pm_prev = pm_list;
589                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
590                         ch_free( pm_prev );
591                 }
592         }
593 #endif
594
595         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
596                 ldap_pvt_thread_yield();
597                 TXN_CHECKPOINT( bdb->bi_dbenv,
598                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
599         }
600
601 done:
602         if( ltid != NULL ) {
603 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
604                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
605                 while ( pm_list != NULL ) {
606                         LDAP_LIST_REMOVE ( pm_list, ps_link );
607                         pm_prev = pm_list;
608                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
609                         ch_free( pm_prev );
610                 }
611 #endif
612                 TXN_ABORT( ltid );
613                 op->o_private = NULL;
614         }
615
616         if( e != NULL ) {
617                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
618         }
619         return ( ( rs->sr_err == LDAP_SUCCESS ) ? noop : rs->sr_err );
620 }