git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c

   1 /* modify.c - bdb backend modify routine */
   2 /* $OpenLDAP$ */
   3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
   4  *
   5  * Copyright 2000-2007 The OpenLDAP Foundation.
   6  * All rights reserved.
   7  *
   8  * Redistribution and use in source and binary forms, with or without
   9  * modification, are permitted only as authorized by the OpenLDAP
  10  * Public License.
  11  *
  12  * A copy of this license is available in the file LICENSE in the
  13  * top-level directory of the distribution or, alternatively, at
  14  * <http://www.OpenLDAP.org/license.html>.
  15  */
  16
  17 #include "portable.h"
  18
  19 #include <stdio.h>
  20 #include <ac/string.h>
  21 #include <ac/time.h>
  22
  23 #include "back-bdb.h"
  24
  25 static struct berval scbva[] = {
  26         BER_BVC("glue"),
  27         BER_BVNULL
  28 };
  29
  30 int bdb_modify_internal(
  31         Operation *op,
  32         DB_TXN *tid,
  33         Modifications *modlist,
  34         Entry *e,
  35         const char **text,
  36         char *textbuf,
  37         size_t textlen )
  38 {
  39         int rc, err;
  40         Modification    *mod;
  41         Modifications   *ml;
  42         Attribute       *save_attrs;
  43         Attribute       *ap;
  44         int                     glue_attr_delete = 0;
  45         int                     got_delete;
  46         struct berval ix_at;
  47         AttrInfo *ai;
  48
  49         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
  50                 e->e_id, e->e_dn, 0);
  51
  52         if ( !acl_check_modlist( op, e, modlist )) {
  53                 return LDAP_INSUFFICIENT_ACCESS;
  54         }
  55
  56         /* save_attrs will be disposed of by bdb_cache_modify */
  57         save_attrs = e->e_attrs;
  58         e->e_attrs = attrs_dup( e->e_attrs );
  59
  60         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  61                 int match;
  62                 mod = &ml->sml_mod;
  63                 switch( mod->sm_op ) {
  64                 case LDAP_MOD_ADD:
  65                 case LDAP_MOD_REPLACE:
  66                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
  67                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
  68                                         slap_schema.si_ad_structuralObjectClass->
  69                                                 ad_type->sat_equality,
  70                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
  71                                         &mod->sm_values[0], &scbva[0], text );
  72                                 if ( !match ) glue_attr_delete = 1;
  73                         }
  74                 }
  75                 if ( glue_attr_delete )
  76                         break;
  77         }
  78
  79         if ( glue_attr_delete ) {
  80                 Attribute       **app = &e->e_attrs;
  81                 while ( *app != NULL ) {
  82                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
  83                                 Attribute *save = *app;
  84                                 *app = (*app)->a_next;
  85                                 attr_free( save );
  86                                 continue;
  87                         }
  88                         app = &(*app)->a_next;
  89                 }
  90         }
  91
  92         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  93                 mod = &ml->sml_mod;
  94                 got_delete = 0;
  95
  96                 switch ( mod->sm_op ) {
  97                 case LDAP_MOD_ADD:
  98                         Debug(LDAP_DEBUG_ARGS,
  99                                 "bdb_modify_internal: add %s\n",
 100                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 101                         err = modify_add_values( e, mod, get_permissiveModify(op),
 102                                 text, textbuf, textlen );
 103                         if( err != LDAP_SUCCESS ) {
 104                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 105                                         err, *text, 0);
 106                         }
 107                         break;
 108
 109                 case LDAP_MOD_DELETE:
 110                         if ( glue_attr_delete ) {
 111                                 err = LDAP_SUCCESS;
 112                                 break;
 113                         }
 114
 115                         Debug(LDAP_DEBUG_ARGS,
 116                                 "bdb_modify_internal: delete %s\n",
 117                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 118                         err = modify_delete_values( e, mod, get_permissiveModify(op),
 119                                 text, textbuf, textlen );
 120                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
 121                         if( err != LDAP_SUCCESS ) {
 122                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 123                                         err, *text, 0);
 124                         } else {
 125                                 got_delete = 1;
 126                         }
 127                         break;
 128
 129                 case LDAP_MOD_REPLACE:
 130                         Debug(LDAP_DEBUG_ARGS,
 131                                 "bdb_modify_internal: replace %s\n",
 132                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 133                         err = modify_replace_values( e, mod, get_permissiveModify(op),
 134                                 text, textbuf, textlen );
 135                         if( err != LDAP_SUCCESS ) {
 136                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 137                                         err, *text, 0);
 138                         } else {
 139                                 got_delete = 1;
 140                         }
 141                         break;
 142
 143                 case LDAP_MOD_INCREMENT:
 144                         Debug(LDAP_DEBUG_ARGS,
 145                                 "bdb_modify_internal: increment %s\n",
 146                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 147                         err = modify_increment_values( e, mod, get_permissiveModify(op),
 148                                 text, textbuf, textlen );
 149                         if( err != LDAP_SUCCESS ) {
 150                                 Debug(LDAP_DEBUG_ARGS,
 151                                         "bdb_modify_internal: %d %s\n",
 152                                         err, *text, 0);
 153                         } else {
 154                                 got_delete = 1;
 155                         }
 156                         break;
 157
 158                 case SLAP_MOD_SOFTADD:
 159                         Debug(LDAP_DEBUG_ARGS,
 160                                 "bdb_modify_internal: softadd %s\n",
 161                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 162                         /* Avoid problems in index_add_mods()
 163                          * We need to add index if necessary.
 164                          */
 165                         mod->sm_op = LDAP_MOD_ADD;
 166
 167                         err = modify_add_values( e, mod, get_permissiveModify(op),
 168                                 text, textbuf, textlen );
 169
 170                         mod->sm_op = SLAP_MOD_SOFTADD;
 171
 172                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
 173                                 err = LDAP_SUCCESS;
 174                         }
 175
 176                         if( err != LDAP_SUCCESS ) {
 177                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 178                                         err, *text, 0);
 179                         }
 180                         break;
 181
 182                 default:
 183                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
 184                                 mod->sm_op, 0, 0);
 185                         *text = "Invalid modify operation";
 186                         err = LDAP_OTHER;
 187                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 188                                 err, *text, 0);
 189                 }
 190
 191                 if ( err != LDAP_SUCCESS ) {
 192                         attrs_free( e->e_attrs );
 193                         e->e_attrs = save_attrs;
 194                         /* unlock entry, delete from cache */
 195                         return err;
 196                 }
 197
 198                 /* If objectClass was modified, reset the flags */
 199                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
 200                         e->e_ocflags = 0;
 201                 }
 202
 203                 if ( glue_attr_delete ) e->e_ocflags = 0;
 204
 205                 /* check if modified attribute was indexed
 206                  * but not in case of NOOP... */
 207                 ai = bdb_index_mask( op->o_bd, mod->sm_desc, &ix_at );
 208                 if ( ai && !op->o_noop ) {
 209                         if ( got_delete ) {
 210                                 struct berval ix2;
 211
 212                                 ap = attr_find( save_attrs, mod->sm_desc );
 213                                 if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
 214
 215                                 /* Find all other attrs that index to same slot */
 216                                 for ( ap = e->e_attrs; ap; ap=ap->a_next ) {
 217                                         ai = bdb_index_mask( op->o_bd, ap->a_desc, &ix2 );
 218                                         if ( ai && ix2.bv_val == ix_at.bv_val )
 219                                                 ap->a_flags |= SLAP_ATTR_IXADD;
 220                                 }
 221                         } else {
 222                                 ap = attr_find( e->e_attrs, mod->sm_desc );
 223                                 if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
 224                         }
 225                 }
 226         }
 227
 228         /* check that the entry still obeys the schema */
 229         rc = entry_schema_check( op, e, save_attrs, get_relax(op), 0,
 230                 text, textbuf, textlen );
 231         if ( rc != LDAP_SUCCESS || op->o_noop ) {
 232                 attrs_free( e->e_attrs );
 233                 /* clear the indexing flags */
 234                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 235                         ap->a_flags &= ~(SLAP_ATTR_IXADD|SLAP_ATTR_IXDEL);
 236                 }
 237                 e->e_attrs = save_attrs;
 238
 239                 if ( rc != LDAP_SUCCESS ) {
 240                         Debug( LDAP_DEBUG_ANY,
 241                                 "entry failed schema check: %s\n",
 242                                 *text, 0, 0 );
 243                 }
 244
 245                 /* if NOOP then silently revert to saved attrs */
 246                 return rc;
 247         }
 248
 249         /* update the indices of the modified attributes */
 250
 251         /* start with deleting the old index entries */
 252         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 253                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
 254                         rc = bdb_index_values( op, tid, ap->a_desc,
 255                                 ap->a_nvals,
 256                                 e->e_id, SLAP_INDEX_DELETE_OP );
 257                         if ( rc != LDAP_SUCCESS ) {
 258                                 attrs_free( e->e_attrs );
 259                                 e->e_attrs = save_attrs;
 260                                 Debug( LDAP_DEBUG_ANY,
 261                                        "Attribute index delete failure",
 262                                        0, 0, 0 );
 263                                 return rc;
 264                         }
 265                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
 266                 }
 267         }
 268
 269         /* add the new index entries */
 270         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
 271                 if (ap->a_flags & SLAP_ATTR_IXADD) {
 272                         rc = bdb_index_values( op, tid, ap->a_desc,
 273                                 ap->a_nvals,
 274                                 e->e_id, SLAP_INDEX_ADD_OP );
 275                         if ( rc != LDAP_SUCCESS ) {
 276                                 attrs_free( e->e_attrs );
 277                                 e->e_attrs = save_attrs;
 278                                 Debug( LDAP_DEBUG_ANY,
 279                                        "Attribute index add failure",
 280                                        0, 0, 0 );
 281                                 return rc;
 282                         }
 283                         ap->a_flags &= ~SLAP_ATTR_IXADD;
 284                 }
 285         }
 286
 287         return rc;
 288 }
 289
 290
 291 int
 292 bdb_modify( Operation *op, SlapReply *rs )
 293 {
 294         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
 295         Entry           *e = NULL;
 296         EntryInfo       *ei = NULL;
 297         int             manageDSAit = get_manageDSAit( op );
 298         char textbuf[SLAP_TEXT_BUFLEN];
 299         size_t textlen = sizeof textbuf;
 300         DB_TXN  *ltid = NULL, *lt2;
 301         struct bdb_op_info opinfo = {0};
 302         Entry           dummy = {0};
 303         int                     fakeroot = 0;
 304
 305         BDB_LOCKER      locker = 0;
 306         DB_LOCK         lock;
 307
 308         int             num_retries = 0;
 309
 310         LDAPControl **preread_ctrl = NULL;
 311         LDAPControl **postread_ctrl = NULL;
 312         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
 313         int num_ctrls = 0;
 314
 315         int rc;
 316
 317 #ifdef LDAP_X_TXN
 318         int settle = 0;
 319 #endif
 320
 321         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
 322                 op->o_req_dn.bv_val, 0, 0 );
 323
 324 #ifdef LDAP_X_TXN
 325         if( op->o_txnSpec ) {
 326                 /* acquire connection lock */
 327                 ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
 328                 if( op->o_conn->c_txn == CONN_TXN_INACTIVE ) {
 329                         rs->sr_text = "invalid transaction identifier";
 330                         rs->sr_err = LDAP_X_TXN_ID_INVALID;
 331                         goto txnReturn;
 332                 } else if( op->o_conn->c_txn == CONN_TXN_SETTLE ) {
 333                         settle=1;
 334                         goto txnReturn;
 335                 }
 336
 337                 if( op->o_conn->c_txn_backend == NULL ) {
 338                         op->o_conn->c_txn_backend = op->o_bd;
 339
 340                 } else if( op->o_conn->c_txn_backend != op->o_bd ) {
 341                         rs->sr_text = "transaction cannot span multiple database contexts";
 342                         rs->sr_err = LDAP_AFFECTS_MULTIPLE_DSAS;
 343                         goto txnReturn;
 344                 }
 345
 346                 /* insert operation into transaction */
 347
 348                 rs->sr_text = "transaction specified";
 349                 rs->sr_err = LDAP_X_TXN_SPECIFY_OKAY;
 350
 351 txnReturn:
 352                 /* release connection lock */
 353                 ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
 354
 355                 if( !settle ) {
 356                         send_ldap_result( op, rs );
 357                         return rs->sr_err;
 358                 }
 359         }
 360 #endif
 361
 362         ctrls[num_ctrls] = NULL;
 363
 364         slap_mods_opattrs( op, &op->orm_modlist, 1 );
 365
 366         if( 0 ) {
 367 retry:  /* transaction retry */
 368                 if ( dummy.e_attrs ) {
 369                         attrs_free( dummy.e_attrs );
 370                         dummy.e_attrs = NULL;
 371                 }
 372                 if( e != NULL ) {
 373                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
 374                         e = NULL;
 375                 }
 376                 Debug(LDAP_DEBUG_TRACE,
 377                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
 378
 379                 rs->sr_err = TXN_ABORT( ltid );
 380                 ltid = NULL;
 381                 op->o_private = NULL;
 382                 op->o_do_not_cache = opinfo.boi_acl_cache;
 383                 if( rs->sr_err != 0 ) {
 384                         rs->sr_err = LDAP_OTHER;
 385                         rs->sr_text = "internal error";
 386                         goto return_results;
 387                 }
 388                 if ( op->o_abandon ) {
 389                         rs->sr_err = SLAPD_ABANDON;
 390                         goto return_results;
 391                 }
 392                 bdb_trans_backoff( ++num_retries );
 393         }
 394
 395         /* begin transaction */
 396         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid,
 397                 bdb->bi_db_opflags );
 398         rs->sr_text = NULL;
 399         if( rs->sr_err != 0 ) {
 400                 Debug( LDAP_DEBUG_TRACE,
 401                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
 402                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
 403                 rs->sr_err = LDAP_OTHER;
 404                 rs->sr_text = "internal error";
 405                 goto return_results;
 406         }
 407
 408         locker = TXN_ID ( ltid );
 409
 410         opinfo.boi_bdb = op->o_bd;
 411         opinfo.boi_txn = ltid;
 412         opinfo.boi_locker = locker;
 413         opinfo.boi_err = 0;
 414         opinfo.boi_acl_cache = op->o_do_not_cache;
 415         op->o_private = &opinfo;
 416
 417         /* get entry or ancestor */
 418         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
 419                 locker, &lock );
 420
 421         if ( rs->sr_err != 0 ) {
 422                 Debug( LDAP_DEBUG_TRACE,
 423                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
 424                         rs->sr_err, 0, 0 );
 425                 switch( rs->sr_err ) {
 426                 case DB_LOCK_DEADLOCK:
 427                 case DB_LOCK_NOTGRANTED:
 428                         goto retry;
 429                 case DB_NOTFOUND:
 430                         if ( BER_BVISEMPTY( &op->o_req_ndn )) {
 431                                 struct berval gluebv = BER_BVC("glue");
 432                                 e = ch_calloc( 1, sizeof(Entry));
 433                                 e->e_name.bv_val = ch_strdup( "" );
 434                                 ber_dupbv( &e->e_nname, &e->e_name );
 435                                 attr_merge_one( e, slap_schema.si_ad_objectClass,
 436                                         &gluebv, NULL );
 437                                 attr_merge_one( e, slap_schema.si_ad_structuralObjectClass,
 438                                         &gluebv, NULL );
 439                                 e->e_private = ei;
 440                                 fakeroot = 1;
 441                                 rs->sr_err = 0;
 442                         }
 443                         break;
 444                 case LDAP_BUSY:
 445                         rs->sr_text = "ldap server busy";
 446                         goto return_results;
 447                 default:
 448                         rs->sr_err = LDAP_OTHER;
 449                         rs->sr_text = "internal error";
 450                         goto return_results;
 451                 }
 452         }
 453
 454         if ( !fakeroot ) {
 455                 e = ei->bei_e;
 456         }
 457
 458         /* acquire and lock entry */
 459         /* FIXME: dn2entry() should return non-glue entry */
 460         if (( rs->sr_err == DB_NOTFOUND ) ||
 461                 ( !manageDSAit && e && is_entry_glue( e )))
 462         {
 463                 if ( e != NULL ) {
 464                         rs->sr_matched = ch_strdup( e->e_dn );
 465                         rs->sr_ref = is_entry_referral( e )
 466                                 ? get_entry_referrals( op, e )
 467                                 : NULL;
 468                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
 469                         e = NULL;
 470
 471                 } else {
 472                         rs->sr_ref = referral_rewrite( default_referral, NULL,
 473                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
 474                 }
 475
 476                 rs->sr_err = LDAP_REFERRAL;
 477                 send_ldap_result( op, rs );
 478
 479                 if ( rs->sr_ref != default_referral ) {
 480                         ber_bvarray_free( rs->sr_ref );
 481                 }
 482                 free( (char *)rs->sr_matched );
 483                 rs->sr_ref = NULL;
 484                 rs->sr_matched = NULL;
 485
 486                 goto done;
 487         }
 488
 489         if ( !manageDSAit && is_entry_referral( e ) ) {
 490                 /* entry is a referral, don't allow modify */
 491                 rs->sr_ref = get_entry_referrals( op, e );
 492
 493                 Debug( LDAP_DEBUG_TRACE,
 494                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
 495                         0, 0, 0 );
 496
 497                 rs->sr_err = LDAP_REFERRAL;
 498                 rs->sr_matched = e->e_name.bv_val;
 499                 send_ldap_result( op, rs );
 500
 501                 ber_bvarray_free( rs->sr_ref );
 502                 rs->sr_ref = NULL;
 503                 rs->sr_matched = NULL;
 504                 goto done;
 505         }
 506
 507         if ( get_assert( op ) &&
 508                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
 509         {
 510                 rs->sr_err = LDAP_ASSERTION_FAILED;
 511                 goto return_results;
 512         }
 513
 514         if( op->o_preread ) {
 515                 if( preread_ctrl == NULL ) {
 516                         preread_ctrl = &ctrls[num_ctrls++];
 517                         ctrls[num_ctrls] = NULL;
 518                 }
 519                 if ( slap_read_controls( op, rs, e,
 520                         &slap_pre_read_bv, preread_ctrl ) )
 521                 {
 522                         Debug( LDAP_DEBUG_TRACE,
 523                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read "
 524                                 "failed!\n", 0, 0, 0 );
 525                         if ( op->o_preread & SLAP_CONTROL_CRITICAL ) {
 526                                 /* FIXME: is it correct to abort
 527                                  * operation if control fails? */
 528                                 goto return_results;
 529                         }
 530                 }
 531         }
 532
 533         /* nested transaction */
 534         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
 535         rs->sr_text = NULL;
 536         if( rs->sr_err != 0 ) {
 537                 Debug( LDAP_DEBUG_TRACE,
 538                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
 539                         db_strerror(rs->sr_err), rs->sr_err, 0 );
 540                 rs->sr_err = LDAP_OTHER;
 541                 rs->sr_text = "internal error";
 542                 goto return_results;
 543         }
 544         /* Modify the entry */
 545         dummy = *e;
 546         rs->sr_err = bdb_modify_internal( op, lt2, op->orm_modlist,
 547                 &dummy, &rs->sr_text, textbuf, textlen );
 548
 549         if( rs->sr_err != LDAP_SUCCESS ) {
 550                 Debug( LDAP_DEBUG_TRACE,
 551                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
 552                         rs->sr_err, 0, 0 );
 553                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
 554                         rs->sr_err = opinfo.boi_err;
 555                 }
 556                 /* Only free attrs if they were dup'd.  */
 557                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
 558                 switch( rs->sr_err ) {
 559                 case DB_LOCK_DEADLOCK:
 560                 case DB_LOCK_NOTGRANTED:
 561                         goto retry;
 562                 }
 563                 goto return_results;
 564         }
 565
 566         /* change the entry itself */
 567         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
 568         if ( rs->sr_err != 0 ) {
 569                 Debug( LDAP_DEBUG_TRACE,
 570                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
 571                         rs->sr_err, 0, 0 );
 572                 switch( rs->sr_err ) {
 573                 case DB_LOCK_DEADLOCK:
 574                 case DB_LOCK_NOTGRANTED:
 575                         goto retry;
 576                 }
 577                 rs->sr_text = "entry update failed";
 578                 goto return_results;
 579         }
 580
 581         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
 582                 rs->sr_err = LDAP_OTHER;
 583                 rs->sr_text = "txn_commit(2) failed";
 584                 goto return_results;
 585         }
 586
 587         if( op->o_postread ) {
 588                 if( postread_ctrl == NULL ) {
 589                         postread_ctrl = &ctrls[num_ctrls++];
 590                         ctrls[num_ctrls] = NULL;
 591                 }
 592                 if( slap_read_controls( op, rs, &dummy,
 593                         &slap_post_read_bv, postread_ctrl ) )
 594                 {
 595                         Debug( LDAP_DEBUG_TRACE,
 596                                 "<=- " LDAP_XSTRING(bdb_modify)
 597                                 ": post-read failed!\n", 0, 0, 0 );
 598                         if ( op->o_postread & SLAP_CONTROL_CRITICAL ) {
 599                                 /* FIXME: is it correct to abort
 600                                  * operation if control fails? */
 601                                 goto return_results;
 602                         }
 603                 }
 604         }
 605
 606         if( op->o_noop ) {
 607                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
 608                         rs->sr_text = "txn_abort (no-op) failed";
 609                 } else {
 610                         rs->sr_err = LDAP_X_NO_OPERATION;
 611                         ltid = NULL;
 612                         /* Only free attrs if they were dup'd.  */
 613                         if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
 614                         goto return_results;
 615                 }
 616         } else {
 617                 /* may have changed in bdb_modify_internal() */
 618                 e->e_ocflags = dummy.e_ocflags;
 619                 if ( fakeroot ) {
 620                         e->e_private = NULL;
 621                         entry_free( e );
 622                         e = NULL;
 623                         attrs_free( dummy.e_attrs );
 624
 625                 } else {
 626                         rc = bdb_cache_modify( bdb, e, dummy.e_attrs, locker, &lock );
 627                         switch( rc ) {
 628                         case DB_LOCK_DEADLOCK:
 629                         case DB_LOCK_NOTGRANTED:
 630                                 goto retry;
 631                         }
 632                 }
 633                 dummy.e_attrs = NULL;
 634
 635                 rs->sr_err = TXN_COMMIT( ltid, 0 );
 636         }
 637         ltid = NULL;
 638         op->o_private = NULL;
 639
 640         if( rs->sr_err != 0 ) {
 641                 Debug( LDAP_DEBUG_TRACE,
 642                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
 643                         op->o_noop ? "abort (no-op)" : "commit",
 644                         db_strerror(rs->sr_err), rs->sr_err );
 645                 rs->sr_err = LDAP_OTHER;
 646                 rs->sr_text = "commit failed";
 647
 648                 goto return_results;
 649         }
 650
 651         Debug( LDAP_DEBUG_TRACE,
 652                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
 653                 op->o_noop ? " (no-op)" : "",
 654                 dummy.e_id, op->o_req_dn.bv_val );
 655
 656         rs->sr_err = LDAP_SUCCESS;
 657         rs->sr_text = NULL;
 658         if( num_ctrls ) rs->sr_ctrls = ctrls;
 659
 660 return_results:
 661         if( dummy.e_attrs ) {
 662                 attrs_free( dummy.e_attrs );
 663         }
 664         send_ldap_result( op, rs );
 665
 666         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp_kbyte ) {
 667                 TXN_CHECKPOINT( bdb->bi_dbenv,
 668                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
 669         }
 670
 671 done:
 672         slap_graduate_commit_csn( op );
 673
 674         if( ltid != NULL ) {
 675                 TXN_ABORT( ltid );
 676         }
 677         op->o_private = NULL;
 678
 679         if( e != NULL ) {
 680                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
 681         }
 682
 683         if( preread_ctrl != NULL && (*preread_ctrl) != NULL ) {
 684                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
 685                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
 686         }
 687         if( postread_ctrl != NULL && (*postread_ctrl) != NULL ) {
 688                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
 689                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
 690         }
 691         return rs->sr_err;
 692 }