]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
Fix prev commit
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2011 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 static void
31 bdb_modify_idxflags(
32         Operation *op,
33         AttributeDescription *desc,
34         int got_delete,
35         Attribute *newattrs,
36         Attribute *oldattrs )
37 {
38         struct berval   ix_at;
39         AttrInfo        *ai;
40
41         /* check if modified attribute was indexed
42          * but not in case of NOOP... */
43         ai = bdb_index_mask( op->o_bd, desc, &ix_at );
44         if ( ai ) {
45                 if ( got_delete ) {
46                         Attribute       *ap;
47                         struct berval   ix2;
48
49                         ap = attr_find( oldattrs, desc );
50                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
51
52                         /* Find all other attrs that index to same slot */
53                         for ( ap = newattrs; ap; ap = ap->a_next ) {
54                                 ai = bdb_index_mask( op->o_bd, ap->a_desc, &ix2 );
55                                 if ( ai && ix2.bv_val == ix_at.bv_val )
56                                         ap->a_flags |= SLAP_ATTR_IXADD;
57                         }
58
59                 } else {
60                         Attribute       *ap;
61
62                         ap = attr_find( newattrs, desc );
63                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
64                 }
65         }
66 }
67
68 int bdb_modify_internal(
69         Operation *op,
70         DB_TXN *tid,
71         Modifications *modlist,
72         Entry *e,
73         const char **text,
74         char *textbuf,
75         size_t textlen )
76 {
77         int rc, err;
78         Modification    *mod;
79         Modifications   *ml;
80         Attribute       *save_attrs;
81         Attribute       *ap;
82         int                     glue_attr_delete = 0;
83         int                     got_delete;
84
85         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
86                 e->e_id, e->e_dn, 0);
87
88         if ( !acl_check_modlist( op, e, modlist )) {
89                 return LDAP_INSUFFICIENT_ACCESS;
90         }
91
92         /* save_attrs will be disposed of by bdb_cache_modify */
93         save_attrs = e->e_attrs;
94         e->e_attrs = attrs_dup( e->e_attrs );
95
96         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
97                 int match;
98                 mod = &ml->sml_mod;
99                 switch( mod->sm_op ) {
100                 case LDAP_MOD_ADD:
101                 case LDAP_MOD_REPLACE:
102                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
103                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
104                                         slap_schema.si_ad_structuralObjectClass->
105                                                 ad_type->sat_equality,
106                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
107                                         &mod->sm_values[0], &scbva[0], text );
108                                 if ( !match ) glue_attr_delete = 1;
109                         }
110                 }
111                 if ( glue_attr_delete )
112                         break;
113         }
114
115         if ( glue_attr_delete ) {
116                 Attribute       **app = &e->e_attrs;
117                 while ( *app != NULL ) {
118                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
119                                 Attribute *save = *app;
120                                 *app = (*app)->a_next;
121                                 attr_free( save );
122                                 continue;
123                         }
124                         app = &(*app)->a_next;
125                 }
126         }
127
128         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
129                 mod = &ml->sml_mod;
130                 got_delete = 0;
131
132                 switch ( mod->sm_op ) {
133                 case LDAP_MOD_ADD:
134                         Debug(LDAP_DEBUG_ARGS,
135                                 "bdb_modify_internal: add %s\n",
136                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
137                         err = modify_add_values( e, mod, get_permissiveModify(op),
138                                 text, textbuf, textlen );
139                         if( err != LDAP_SUCCESS ) {
140                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
141                                         err, *text, 0);
142                         }
143                         break;
144
145                 case LDAP_MOD_DELETE:
146                         if ( glue_attr_delete ) {
147                                 err = LDAP_SUCCESS;
148                                 break;
149                         }
150
151                         Debug(LDAP_DEBUG_ARGS,
152                                 "bdb_modify_internal: delete %s\n",
153                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
154                         err = modify_delete_values( e, mod, get_permissiveModify(op),
155                                 text, textbuf, textlen );
156                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
157                         if( err != LDAP_SUCCESS ) {
158                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
159                                         err, *text, 0);
160                         } else {
161                                 got_delete = 1;
162                         }
163                         break;
164
165                 case LDAP_MOD_REPLACE:
166                         Debug(LDAP_DEBUG_ARGS,
167                                 "bdb_modify_internal: replace %s\n",
168                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
169                         err = modify_replace_values( e, mod, get_permissiveModify(op),
170                                 text, textbuf, textlen );
171                         if( err != LDAP_SUCCESS ) {
172                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
173                                         err, *text, 0);
174                         } else {
175                                 got_delete = 1;
176                         }
177                         break;
178
179                 case LDAP_MOD_INCREMENT:
180                         Debug(LDAP_DEBUG_ARGS,
181                                 "bdb_modify_internal: increment %s\n",
182                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
183                         err = modify_increment_values( e, mod, get_permissiveModify(op),
184                                 text, textbuf, textlen );
185                         if( err != LDAP_SUCCESS ) {
186                                 Debug(LDAP_DEBUG_ARGS,
187                                         "bdb_modify_internal: %d %s\n",
188                                         err, *text, 0);
189                         } else {
190                                 got_delete = 1;
191                         }
192                         break;
193
194                 case SLAP_MOD_SOFTADD:
195                         Debug(LDAP_DEBUG_ARGS,
196                                 "bdb_modify_internal: softadd %s\n",
197                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
198                         /* Avoid problems in index_add_mods()
199                          * We need to add index if necessary.
200                          */
201                         mod->sm_op = LDAP_MOD_ADD;
202
203                         err = modify_add_values( e, mod, get_permissiveModify(op),
204                                 text, textbuf, textlen );
205
206                         mod->sm_op = SLAP_MOD_SOFTADD;
207
208                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
209                                 err = LDAP_SUCCESS;
210                         }
211
212                         if( err != LDAP_SUCCESS ) {
213                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
214                                         err, *text, 0);
215                         }
216                         break;
217
218                 case SLAP_MOD_SOFTDEL:
219                         Debug(LDAP_DEBUG_ARGS,
220                                 "bdb_modify_internal: softdel %s\n",
221                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
222                         /* Avoid problems in index_delete_mods()
223                          * We need to add index if necessary.
224                          */
225                         mod->sm_op = LDAP_MOD_DELETE;
226
227                         err = modify_delete_values( e, mod, get_permissiveModify(op),
228                                 text, textbuf, textlen );
229
230                         mod->sm_op = SLAP_MOD_SOFTDEL;
231
232                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
233                                 err = LDAP_SUCCESS;
234                         }
235
236                         if( err != LDAP_SUCCESS ) {
237                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
238                                         err, *text, 0);
239                         }
240                         break;
241
242                 case SLAP_MOD_ADD_IF_NOT_PRESENT:
243                         if ( attr_find( e->e_attrs, mod->sm_desc ) != NULL ) {
244                                 /* skip */
245                                 err = LDAP_SUCCESS;
246                                 break;
247                         }
248
249                         Debug(LDAP_DEBUG_ARGS,
250                                 "bdb_modify_internal: add_if_not_present %s\n",
251                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
252                         /* Avoid problems in index_add_mods()
253                          * We need to add index if necessary.
254                          */
255                         mod->sm_op = LDAP_MOD_ADD;
256
257                         err = modify_add_values( e, mod, get_permissiveModify(op),
258                                 text, textbuf, textlen );
259
260                         mod->sm_op = SLAP_MOD_ADD_IF_NOT_PRESENT;
261
262                         if( err != LDAP_SUCCESS ) {
263                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
264                                         err, *text, 0);
265                         }
266                         break;
267
268                 default:
269                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
270                                 mod->sm_op, 0, 0);
271                         *text = "Invalid modify operation";
272                         err = LDAP_OTHER;
273                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
274                                 err, *text, 0);
275                 }
276
277                 if ( err != LDAP_SUCCESS ) {
278                         attrs_free( e->e_attrs );
279                         e->e_attrs = save_attrs;
280                         /* unlock entry, delete from cache */
281                         return err; 
282                 }
283
284                 /* If objectClass was modified, reset the flags */
285                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
286                         e->e_ocflags = 0;
287                 }
288
289                 if ( glue_attr_delete ) e->e_ocflags = 0;
290
291
292                 /* check if modified attribute was indexed
293                  * but not in case of NOOP... */
294                 if ( !op->o_noop ) {
295                         bdb_modify_idxflags( op, mod->sm_desc, got_delete, e->e_attrs, save_attrs );
296                 }
297         }
298
299         /* check that the entry still obeys the schema */
300         ap = NULL;
301         rc = entry_schema_check( op, e, save_attrs, get_relax(op), 0, &ap,
302                 text, textbuf, textlen );
303         if ( rc != LDAP_SUCCESS || op->o_noop ) {
304                 attrs_free( e->e_attrs );
305                 /* clear the indexing flags */
306                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
307                         ap->a_flags &= ~(SLAP_ATTR_IXADD|SLAP_ATTR_IXDEL);
308                 }
309                 e->e_attrs = save_attrs;
310
311                 if ( rc != LDAP_SUCCESS ) {
312                         Debug( LDAP_DEBUG_ANY,
313                                 "entry failed schema check: %s\n",
314                                 *text, 0, 0 );
315                 }
316
317                 /* if NOOP then silently revert to saved attrs */
318                 return rc;
319         }
320
321         /* structuralObjectClass modified! */
322         if ( ap ) {
323                 assert( ap->a_desc == slap_schema.si_ad_structuralObjectClass );
324                 if ( !op->o_noop ) {
325                         bdb_modify_idxflags( op, slap_schema.si_ad_structuralObjectClass,
326                                 1, e->e_attrs, save_attrs );
327                 }
328         }
329
330         /* update the indices of the modified attributes */
331
332         /* start with deleting the old index entries */
333         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
334                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
335                         struct berval *vals;
336                         Attribute *a2;
337                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
338                         a2 = attr_find( e->e_attrs, ap->a_desc );
339                         if ( a2 ) {
340                                 /* need to detect which values were deleted */
341                                 int i, j;
342                                 vals = op->o_tmpalloc( (ap->a_numvals + 1) *
343                                         sizeof(struct berval), op->o_tmpmemctx );
344                                 j = 0;
345                                 for ( i=0; i < ap->a_numvals; i++ ) {
346                                         rc = attr_valfind( a2, SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
347                                                 &ap->a_nvals[i], NULL, op->o_tmpmemctx );
348                                         /* Save deleted values */
349                                         if ( rc == LDAP_NO_SUCH_ATTRIBUTE )
350                                                 vals[j++] = ap->a_nvals[i];
351                                 }
352                                 BER_BVZERO(vals+j);
353                         } else {
354                                 /* attribute was completely deleted */
355                                 vals = ap->a_nvals;
356                         }
357                         rc = 0;
358                         if ( !BER_BVISNULL( vals )) {
359                                 rc = bdb_index_values( op, tid, ap->a_desc,
360                                         vals, e->e_id, SLAP_INDEX_DELETE_OP );
361                                 if ( rc != LDAP_SUCCESS ) {
362                                         Debug( LDAP_DEBUG_ANY,
363                                                 "%s: attribute \"%s\" index delete failure\n",
364                                                 op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
365                                         attrs_free( e->e_attrs );
366                                         e->e_attrs = save_attrs;
367                                 }
368                         }
369                         if ( vals != ap->a_nvals )
370                                 op->o_tmpfree( vals, op->o_tmpmemctx );
371                         if ( rc ) return rc;
372                 }
373         }
374
375         /* add the new index entries */
376         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
377                 if (ap->a_flags & SLAP_ATTR_IXADD) {
378                         ap->a_flags &= ~SLAP_ATTR_IXADD;
379                         rc = bdb_index_values( op, tid, ap->a_desc,
380                                 ap->a_nvals,
381                                 e->e_id, SLAP_INDEX_ADD_OP );
382                         if ( rc != LDAP_SUCCESS ) {
383                                 Debug( LDAP_DEBUG_ANY,
384                                        "%s: attribute \"%s\" index add failure\n",
385                                         op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
386                                 attrs_free( e->e_attrs );
387                                 e->e_attrs = save_attrs;
388                                 return rc;
389                         }
390                 }
391         }
392
393         return rc;
394 }
395
396
397 int
398 bdb_modify( Operation *op, SlapReply *rs )
399 {
400         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
401         Entry           *e = NULL;
402         EntryInfo       *ei = NULL;
403         int             manageDSAit = get_manageDSAit( op );
404         char textbuf[SLAP_TEXT_BUFLEN];
405         size_t textlen = sizeof textbuf;
406         DB_TXN  *ltid = NULL, *lt2;
407         struct bdb_op_info opinfo = {{{ 0 }}};
408         Entry           dummy = {0};
409
410         DB_LOCK         lock;
411
412         int             num_retries = 0;
413
414         LDAPControl **preread_ctrl = NULL;
415         LDAPControl **postread_ctrl = NULL;
416         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
417         int num_ctrls = 0;
418
419         int rc;
420
421 #ifdef LDAP_X_TXN
422         int settle = 0;
423 #endif
424
425         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
426                 op->o_req_dn.bv_val, 0, 0 );
427
428 #ifdef LDAP_X_TXN
429         if( op->o_txnSpec ) {
430                 /* acquire connection lock */
431                 ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
432                 if( op->o_conn->c_txn == CONN_TXN_INACTIVE ) {
433                         rs->sr_text = "invalid transaction identifier";
434                         rs->sr_err = LDAP_X_TXN_ID_INVALID;
435                         goto txnReturn;
436                 } else if( op->o_conn->c_txn == CONN_TXN_SETTLE ) {
437                         settle=1;
438                         goto txnReturn;
439                 }
440
441                 if( op->o_conn->c_txn_backend == NULL ) {
442                         op->o_conn->c_txn_backend = op->o_bd;
443
444                 } else if( op->o_conn->c_txn_backend != op->o_bd ) {
445                         rs->sr_text = "transaction cannot span multiple database contexts";
446                         rs->sr_err = LDAP_AFFECTS_MULTIPLE_DSAS;
447                         goto txnReturn;
448                 }
449
450                 /* insert operation into transaction */
451
452                 rs->sr_text = "transaction specified";
453                 rs->sr_err = LDAP_X_TXN_SPECIFY_OKAY;
454
455 txnReturn:
456                 /* release connection lock */
457                 ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
458
459                 if( !settle ) {
460                         send_ldap_result( op, rs );
461                         return rs->sr_err;
462                 }
463         }
464 #endif
465
466         ctrls[num_ctrls] = NULL;
467
468         /* Don't touch the opattrs, if this is a contextCSN update
469          * initiated from updatedn */
470         if ( !be_isupdate(op) || !op->orm_modlist || op->orm_modlist->sml_next ||
471                  op->orm_modlist->sml_desc != slap_schema.si_ad_contextCSN ) {
472
473                 slap_mods_opattrs( op, &op->orm_modlist, 1 );
474         }
475
476         if( 0 ) {
477 retry:  /* transaction retry */
478                 if ( dummy.e_attrs ) {
479                         attrs_free( dummy.e_attrs );
480                         dummy.e_attrs = NULL;
481                 }
482                 if( e != NULL ) {
483                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
484                         e = NULL;
485                 }
486                 Debug(LDAP_DEBUG_TRACE,
487                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
488
489                 rs->sr_err = TXN_ABORT( ltid );
490                 ltid = NULL;
491                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
492                 opinfo.boi_oe.oe_key = NULL;
493                 op->o_do_not_cache = opinfo.boi_acl_cache;
494                 if( rs->sr_err != 0 ) {
495                         rs->sr_err = LDAP_OTHER;
496                         rs->sr_text = "internal error";
497                         goto return_results;
498                 }
499                 if ( op->o_abandon ) {
500                         rs->sr_err = SLAPD_ABANDON;
501                         goto return_results;
502                 }
503                 bdb_trans_backoff( ++num_retries );
504         }
505
506         /* begin transaction */
507         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
508                 bdb->bi_db_opflags );
509         rs->sr_text = NULL;
510         if( rs->sr_err != 0 ) {
511                 Debug( LDAP_DEBUG_TRACE,
512                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
513                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
514                 rs->sr_err = LDAP_OTHER;
515                 rs->sr_text = "internal error";
516                 goto return_results;
517         }
518
519         opinfo.boi_oe.oe_key = bdb;
520         opinfo.boi_txn = ltid;
521         opinfo.boi_err = 0;
522         opinfo.boi_acl_cache = op->o_do_not_cache;
523         LDAP_SLIST_INSERT_HEAD( &op->o_extra, &opinfo.boi_oe, oe_next );
524
525         /* get entry or ancestor */
526         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
527                 &lock );
528
529         if ( rs->sr_err != 0 ) {
530                 Debug( LDAP_DEBUG_TRACE,
531                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
532                         rs->sr_err, 0, 0 );
533                 switch( rs->sr_err ) {
534                 case DB_LOCK_DEADLOCK:
535                 case DB_LOCK_NOTGRANTED:
536                         goto retry;
537                 case DB_NOTFOUND:
538                         break;
539                 case LDAP_BUSY:
540                         rs->sr_text = "ldap server busy";
541                         goto return_results;
542                 default:
543                         rs->sr_err = LDAP_OTHER;
544                         rs->sr_text = "internal error";
545                         goto return_results;
546                 }
547         }
548
549         e = ei->bei_e;
550
551         /* acquire and lock entry */
552         /* FIXME: dn2entry() should return non-glue entry */
553         if (( rs->sr_err == DB_NOTFOUND ) ||
554                 ( !manageDSAit && e && is_entry_glue( e )))
555         {
556                 if ( e != NULL ) {
557                         rs->sr_matched = ch_strdup( e->e_dn );
558                         rs->sr_ref = is_entry_referral( e )
559                                 ? get_entry_referrals( op, e )
560                                 : NULL;
561                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
562                         e = NULL;
563
564                 } else {
565                         rs->sr_ref = referral_rewrite( default_referral, NULL,
566                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
567                 }
568
569                 rs->sr_err = LDAP_REFERRAL;
570                 send_ldap_result( op, rs );
571
572                 if ( rs->sr_ref != default_referral ) {
573                         ber_bvarray_free( rs->sr_ref );
574                 }
575                 free( (char *)rs->sr_matched );
576                 rs->sr_ref = NULL;
577                 rs->sr_matched = NULL;
578
579                 goto done;
580         }
581
582         if ( !manageDSAit && is_entry_referral( e ) ) {
583                 /* entry is a referral, don't allow modify */
584                 rs->sr_ref = get_entry_referrals( op, e );
585
586                 Debug( LDAP_DEBUG_TRACE,
587                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
588                         0, 0, 0 );
589
590                 rs->sr_err = LDAP_REFERRAL;
591                 rs->sr_matched = e->e_name.bv_val;
592                 send_ldap_result( op, rs );
593
594                 ber_bvarray_free( rs->sr_ref );
595                 rs->sr_ref = NULL;
596                 rs->sr_matched = NULL;
597                 goto done;
598         }
599
600         if ( get_assert( op ) &&
601                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
602         {
603                 rs->sr_err = LDAP_ASSERTION_FAILED;
604                 goto return_results;
605         }
606
607         if( op->o_preread ) {
608                 if( preread_ctrl == NULL ) {
609                         preread_ctrl = &ctrls[num_ctrls++];
610                         ctrls[num_ctrls] = NULL;
611                 }
612                 if ( slap_read_controls( op, rs, e,
613                         &slap_pre_read_bv, preread_ctrl ) )
614                 {
615                         Debug( LDAP_DEBUG_TRACE,
616                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read "
617                                 "failed!\n", 0, 0, 0 );
618                         if ( op->o_preread & SLAP_CONTROL_CRITICAL ) {
619                                 /* FIXME: is it correct to abort
620                                  * operation if control fails? */
621                                 goto return_results;
622                         }
623                 }
624         }
625
626         /* nested transaction */
627         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
628         rs->sr_text = NULL;
629         if( rs->sr_err != 0 ) {
630                 Debug( LDAP_DEBUG_TRACE,
631                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
632                         db_strerror(rs->sr_err), rs->sr_err, 0 );
633                 rs->sr_err = LDAP_OTHER;
634                 rs->sr_text = "internal error";
635                 goto return_results;
636         }
637         /* Modify the entry */
638         dummy = *e;
639         rs->sr_err = bdb_modify_internal( op, lt2, op->orm_modlist,
640                 &dummy, &rs->sr_text, textbuf, textlen );
641
642         if( rs->sr_err != LDAP_SUCCESS ) {
643                 Debug( LDAP_DEBUG_TRACE,
644                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
645                         rs->sr_err, 0, 0 );
646                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
647                         rs->sr_err = opinfo.boi_err;
648                 }
649                 /* Only free attrs if they were dup'd.  */
650                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
651                 switch( rs->sr_err ) {
652                 case DB_LOCK_DEADLOCK:
653                 case DB_LOCK_NOTGRANTED:
654                         goto retry;
655                 }
656                 goto return_results;
657         }
658
659         /* change the entry itself */
660         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
661         if ( rs->sr_err != 0 ) {
662                 Debug( LDAP_DEBUG_TRACE,
663                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
664                         rs->sr_err, 0, 0 );
665                 switch( rs->sr_err ) {
666                 case DB_LOCK_DEADLOCK:
667                 case DB_LOCK_NOTGRANTED:
668                         goto retry;
669                 }
670                 rs->sr_text = "entry update failed";
671                 goto return_results;
672         }
673
674         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
675                 rs->sr_err = LDAP_OTHER;
676                 rs->sr_text = "txn_commit(2) failed";
677                 goto return_results;
678         }
679
680         if( op->o_postread ) {
681                 if( postread_ctrl == NULL ) {
682                         postread_ctrl = &ctrls[num_ctrls++];
683                         ctrls[num_ctrls] = NULL;
684                 }
685                 if( slap_read_controls( op, rs, &dummy,
686                         &slap_post_read_bv, postread_ctrl ) )
687                 {
688                         Debug( LDAP_DEBUG_TRACE,
689                                 "<=- " LDAP_XSTRING(bdb_modify)
690                                 ": post-read failed!\n", 0, 0, 0 );
691                         if ( op->o_postread & SLAP_CONTROL_CRITICAL ) {
692                                 /* FIXME: is it correct to abort
693                                  * operation if control fails? */
694                                 goto return_results;
695                         }
696                 }
697         }
698
699         if( op->o_noop ) {
700                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
701                         rs->sr_text = "txn_abort (no-op) failed";
702                 } else {
703                         rs->sr_err = LDAP_X_NO_OPERATION;
704                         ltid = NULL;
705                         /* Only free attrs if they were dup'd.  */
706                         if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
707                         goto return_results;
708                 }
709         } else {
710                 /* may have changed in bdb_modify_internal() */
711                 e->e_ocflags = dummy.e_ocflags;
712                 rc = bdb_cache_modify( bdb, e, dummy.e_attrs, ltid, &lock );
713                 switch( rc ) {
714                 case DB_LOCK_DEADLOCK:
715                 case DB_LOCK_NOTGRANTED:
716                         goto retry;
717                 }
718                 dummy.e_attrs = NULL;
719
720                 rs->sr_err = TXN_COMMIT( ltid, 0 );
721         }
722         ltid = NULL;
723         LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
724         opinfo.boi_oe.oe_key = NULL;
725
726         if( rs->sr_err != 0 ) {
727                 Debug( LDAP_DEBUG_TRACE,
728                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
729                         op->o_noop ? "abort (no-op)" : "commit",
730                         db_strerror(rs->sr_err), rs->sr_err );
731                 rs->sr_err = LDAP_OTHER;
732                 rs->sr_text = "commit failed";
733
734                 goto return_results;
735         }
736
737         Debug( LDAP_DEBUG_TRACE,
738                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
739                 op->o_noop ? " (no-op)" : "",
740                 dummy.e_id, op->o_req_dn.bv_val );
741
742         rs->sr_err = LDAP_SUCCESS;
743         rs->sr_text = NULL;
744         if( num_ctrls ) rs->sr_ctrls = ctrls;
745
746 return_results:
747         if( dummy.e_attrs ) {
748                 attrs_free( dummy.e_attrs );
749         }
750         send_ldap_result( op, rs );
751
752         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp_kbyte ) {
753                 TXN_CHECKPOINT( bdb->bi_dbenv,
754                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
755         }
756
757 done:
758         slap_graduate_commit_csn( op );
759
760         if( ltid != NULL ) {
761                 TXN_ABORT( ltid );
762         }
763         if ( opinfo.boi_oe.oe_key ) {
764                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
765         }
766
767         if( e != NULL ) {
768                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
769         }
770
771         if( preread_ctrl != NULL && (*preread_ctrl) != NULL ) {
772                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
773                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
774         }
775         if( postread_ctrl != NULL && (*postread_ctrl) != NULL ) {
776                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
777                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
778         }
779
780         rs->sr_text = NULL;
781
782         return rs->sr_err;
783 }