]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
Optimize modify_internal, only reindex the actual modified values, not
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /*
4  * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
5  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
6  */
7
8 #include "portable.h"
9
10 #include <stdio.h>
11 #include <ac/string.h>
12 #include <ac/time.h>
13
14 #include "back-bdb.h"
15 #include "external.h"
16
17 #define INDEXED 0x2000
18 #define NULLIFIED       0x4000
19
20 int bdb_modify_internal(
21         Operation *op,
22         DB_TXN *tid,
23         Modifications *modlist,
24         Entry *e,
25         const char **text,
26         char *textbuf,
27         size_t textlen )
28 {
29         int rc, err;
30         Modification    *mod;
31         Modifications   *ml;
32         Attribute       *save_attrs;
33         Attribute       *ap;
34
35 #ifdef NEW_LOGGING
36         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify_internal: 0x%08lx: %s\n", 
37                 e->e_id, e->e_dn, 0 );
38 #else
39         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
40                 e->e_id, e->e_dn, 0);
41 #endif
42
43         if ( !acl_check_modlist( op, e, modlist )) {
44                 return LDAP_INSUFFICIENT_ACCESS;
45         }
46
47         /* save_attrs will be disposed of by bdb_cache_modify */
48         save_attrs = e->e_attrs;
49         e->e_attrs = attrs_dup( e->e_attrs );
50
51         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
52                 mod = &ml->sml_mod;
53
54                 switch ( mod->sm_op ) {
55                 case LDAP_MOD_ADD:
56 #ifdef NEW_LOGGING
57                         LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify_internal: add\n", 0,0,0);
58 #else
59                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
60 #endif
61                         err = modify_add_values( e, mod, get_permissiveModify(op),
62                                 text, textbuf, textlen );
63                         if( err != LDAP_SUCCESS ) {
64 #ifdef NEW_LOGGING
65                                 LDAP_LOG ( OPERATION, ERR, 
66                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
67 #else
68                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
69                                         err, *text, 0);
70 #endif
71                         }
72                         break;
73
74                 case LDAP_MOD_DELETE:
75 #ifdef NEW_LOGGING
76                         LDAP_LOG ( OPERATION, DETAIL1, 
77                                 "bdb_modify_internal: delete\n", 0, 0, 0 );
78 #else
79                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
80 #endif
81                         err = modify_delete_values( e, mod, get_permissiveModify(op),
82                                 text, textbuf, textlen );
83                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
84                         if( err != LDAP_SUCCESS ) {
85 #ifdef NEW_LOGGING
86                                 LDAP_LOG ( OPERATION, ERR, 
87                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
88 #else
89                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
90                                         err, *text, 0);
91 #endif
92                         }
93                         break;
94
95                 case LDAP_MOD_REPLACE:
96 #ifdef NEW_LOGGING
97                         LDAP_LOG ( OPERATION, DETAIL1, 
98                                 "bdb_modify_internal: replace\n", 0, 0, 0 );
99 #else
100                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
101 #endif
102                         err = modify_replace_values( e, mod, get_permissiveModify(op),
103                                 text, textbuf, textlen );
104                         if( err != LDAP_SUCCESS ) {
105 #ifdef NEW_LOGGING
106                                 LDAP_LOG ( OPERATION, ERR, 
107                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
108 #else
109                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
110                                         err, *text, 0);
111 #endif
112                         }
113                         break;
114
115                 case SLAP_MOD_SOFTADD:
116 #ifdef NEW_LOGGING
117                         LDAP_LOG ( OPERATION, DETAIL1, 
118                                 "bdb_modify_internal: softadd\n",0,0,0 );
119 #else
120                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
121 #endif
122                         /* Avoid problems in index_add_mods()
123                          * We need to add index if necessary.
124                          */
125                         mod->sm_op = LDAP_MOD_ADD;
126
127                         err = modify_add_values( e, mod, get_permissiveModify(op),
128                                 text, textbuf, textlen );
129
130                         mod->sm_op = SLAP_MOD_SOFTADD;
131
132                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
133                                 err = LDAP_SUCCESS;
134                         }
135
136                         if( err != LDAP_SUCCESS ) {
137 #ifdef NEW_LOGGING
138                                 LDAP_LOG ( OPERATION, ERR, 
139                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
140 #else
141                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
142                                         err, *text, 0);
143 #endif
144                         }
145                         break;
146
147                 default:
148 #ifdef NEW_LOGGING
149                                 LDAP_LOG ( OPERATION, ERR, 
150                                         "bdb_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
151 #else
152                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
153                                 mod->sm_op, 0, 0);
154 #endif
155                         *text = "Invalid modify operation";
156                         err = LDAP_OTHER;
157 #ifdef NEW_LOGGING
158                                 LDAP_LOG ( OPERATION, ERR, 
159                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
160 #else
161                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
162                                 err, *text, 0);
163 #endif
164                 }
165
166                 if ( err != LDAP_SUCCESS ) {
167                         attrs_free( e->e_attrs );
168                         e->e_attrs = save_attrs;
169                         /* unlock entry, delete from cache */
170                         return err; 
171                 }
172
173                 /* If objectClass was modified, reset the flags */
174                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
175                         e->e_ocflags = 0;
176                 }
177         }
178
179         /* check that the entry still obeys the schema */
180         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
181         if ( rc != LDAP_SUCCESS || op->o_noop ) {
182                 attrs_free( e->e_attrs );
183                 e->e_attrs = save_attrs;
184
185                 if ( rc != LDAP_SUCCESS ) {
186 #ifdef NEW_LOGGING
187                         LDAP_LOG ( OPERATION, ERR, "bdb_modify_internal: "
188                                 "entry failed schema check %s\n", 
189                                 *text, 0, 0 );
190 #else
191                         Debug( LDAP_DEBUG_ANY,
192                                 "entry failed schema check: %s\n",
193                                 *text, 0, 0 );
194 #endif
195                 }
196
197                 /* if NOOP then silently revert to saved attrs */
198                 return rc;
199         }
200
201         /* update the indices of the modified attributes */
202         if ( !op->o_noop ) {
203                 Modifications *m2;
204
205                 /* First look for any deletes that would nullify any adds
206                  * in this request. I.e., deleting an entire attribute after
207                  * assigning some values to it.
208                  */
209                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
210                         if (bdb_index_is_indexed( op->o_bd, ml->sml_desc ))
211                                 continue;
212                         switch ( ml->sml_op ) {
213                         case LDAP_MOD_DELETE:
214                                 /* If just deleting specific values, ignore */
215                                 if ( ml->sml_bvalues ) break;
216                         case LDAP_MOD_REPLACE:
217                                 for ( m2 = modlist; m2 != ml; m2 = m2->sml_next ) {
218                                         if ( m2->sml_desc == ml->sml_desc &&
219                                                 m2->sml_op != LDAP_MOD_DELETE )
220                                                 m2->sml_op |= NULLIFIED;
221                                 }
222                                 break;
223                         }
224                         ml->sml_op |= INDEXED;
225                 }
226                 /* Now index the modifications */
227                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
228                         if ( ! (ml->sml_op & INDEXED) ) continue;
229                         ml->sml_op ^= INDEXED;
230                         switch ( ml->sml_op ) {
231                         case LDAP_MOD_DELETE:
232                                 if ( ml->sml_bvalues ) {
233                                         rc = bdb_index_values( op, tid, ml->sml_desc,
234                                                 ml->sml_nvalues ? ml->sml_nvalues : ml->sml_bvalues,
235                                                 e->e_id, SLAP_INDEX_DELETE_OP );
236                                         break;
237                                 }
238                                 /* FALLTHRU */
239                         case LDAP_MOD_REPLACE:
240                         /* A nullified replace still does its delete action */
241                         case LDAP_MOD_REPLACE | NULLIFIED:
242                                 ap = attr_find( save_attrs, ml->sml_desc );
243                                 rc = bdb_index_values( op, tid, ap->a_desc,
244                                         ap->a_nvals,
245                                         e->e_id, SLAP_INDEX_DELETE_OP );
246                                 if ( rc || ml->sml_op == LDAP_MOD_DELETE ||
247                                         (ml->sml_op & NULLIFIED))
248                                         break;
249                                 /* FALLTHRU */
250                         case LDAP_MOD_ADD:
251                         case SLAP_MOD_SOFTADD:
252                                 rc = bdb_index_values( op, tid, ml->sml_desc,
253                                         ml->sml_nvalues ? ml->sml_nvalues : ml->sml_bvalues,
254                                         e->e_id, SLAP_INDEX_ADD_OP );
255                                 break;
256                         }
257                         ml->sml_op &= ~NULLIFIED;
258                         if ( rc != LDAP_SUCCESS ) {
259                                 attrs_free( e->e_attrs );
260                                 e->e_attrs = save_attrs;
261 #ifdef NEW_LOGGING
262                                 LDAP_LOG ( OPERATION, ERR, 
263                                         "bdb_modify_internal: attribute index update failure\n",
264                                         0, 0, 0 );
265 #else
266                                 Debug( LDAP_DEBUG_ANY,
267                                        "Attribute index update failure",
268                                        0, 0, 0 );
269 #endif
270                                 /* reset our flags */
271                                 for (; ml; ml=ml->sml_next ) {
272                                         ml->sml_op &= ~(INDEXED | NULLIFIED);
273                                 }
274                                 break;
275                         }
276                 }
277         }
278
279         return rc;
280 }
281
282
283 int
284 bdb_modify( Operation *op, SlapReply *rs )
285 {
286         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
287         Entry           *e = NULL;
288         EntryInfo       *ei = NULL;
289         int             manageDSAit = get_manageDSAit( op );
290         char textbuf[SLAP_TEXT_BUFLEN];
291         size_t textlen = sizeof textbuf;
292         DB_TXN  *ltid = NULL, *lt2;
293         struct bdb_op_info opinfo;
294         Entry           dummy;
295
296         u_int32_t       locker = 0;
297         DB_LOCK         lock;
298
299         int             noop = 0;
300
301 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
302         Operation* ps_list;
303         struct psid_entry *pm_list, *pm_prev;
304 #endif
305
306 #ifdef NEW_LOGGING
307         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
308 #else
309         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
310 #endif
311
312         if( 0 ) {
313 retry:  /* transaction retry */
314                 if( e != NULL ) {
315                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
316                         e = NULL;
317                 }
318 #ifdef NEW_LOGGING
319                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: retrying...\n", 0, 0, 0 );
320 #else
321                 Debug(LDAP_DEBUG_TRACE,
322                         "bdb_modify: retrying...\n", 0, 0, 0);
323 #endif
324
325 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
326                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
327                 while ( pm_list != NULL ) {
328                         LDAP_LIST_REMOVE ( pm_list, ps_link );
329                         pm_prev = pm_list;
330                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
331                         ch_free( pm_prev );
332                 }
333 #endif
334
335                 rs->sr_err = TXN_ABORT( ltid );
336                 ltid = NULL;
337                 op->o_private = NULL;
338                 op->o_do_not_cache = opinfo.boi_acl_cache;
339                 if( rs->sr_err != 0 ) {
340                         rs->sr_err = LDAP_OTHER;
341                         rs->sr_text = "internal error";
342                         goto return_results;
343                 }
344                 ldap_pvt_thread_yield();
345         }
346
347         /* begin transaction */
348         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
349                 bdb->bi_db_opflags );
350         rs->sr_text = NULL;
351         if( rs->sr_err != 0 ) {
352 #ifdef NEW_LOGGING
353                 LDAP_LOG ( OPERATION, DETAIL1, 
354                         "bdb_modify: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
355 #else
356                 Debug( LDAP_DEBUG_TRACE,
357                         "bdb_modify: txn_begin failed: %s (%d)\n",
358                         db_strerror(rs->sr_err), rs->sr_err, 0 );
359 #endif
360                 rs->sr_err = LDAP_OTHER;
361                 rs->sr_text = "internal error";
362                 goto return_results;
363         }
364
365         locker = TXN_ID ( ltid );
366
367         opinfo.boi_bdb = op->o_bd;
368         opinfo.boi_txn = ltid;
369         opinfo.boi_locker = locker;
370         opinfo.boi_err = 0;
371         opinfo.boi_acl_cache = op->o_do_not_cache;
372         op->o_private = &opinfo;
373
374         /* get entry or ancestor */
375         rs->sr_err = bdb_dn2entry( op->o_bd, ltid, &op->o_req_ndn, &ei, 1,
376                 locker, &lock, op->o_tmpmemctx );
377
378         if ( rs->sr_err != 0 ) {
379 #ifdef NEW_LOGGING
380                 LDAP_LOG ( OPERATION, DETAIL1, 
381                         "bdb_modify: dn2entry failed: (%d)\n", rs->sr_err, 0, 0 );
382 #else
383                 Debug( LDAP_DEBUG_TRACE,
384                         "bdb_modify: dn2entry failed (%d)\n",
385                         rs->sr_err, 0, 0 );
386 #endif
387                 switch( rs->sr_err ) {
388                 case DB_LOCK_DEADLOCK:
389                 case DB_LOCK_NOTGRANTED:
390                         goto retry;
391                 case DB_NOTFOUND:
392                         break;
393                 case LDAP_BUSY:
394                         rs->sr_text = "ldap server busy";
395                         goto return_results;
396                 default:
397                         rs->sr_err = LDAP_OTHER;
398                         rs->sr_text = "internal error";
399                         goto return_results;
400                 }
401         }
402
403         e = ei->bei_e;
404         /* acquire and lock entry */
405         if ( rs->sr_err == DB_NOTFOUND ) {
406                 if ( e != NULL ) {
407                         rs->sr_matched = ch_strdup( e->e_dn );
408                         rs->sr_ref = is_entry_referral( e )
409                                 ? get_entry_referrals( op, e )
410                                 : NULL;
411                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
412                         e = NULL;
413
414                 } else {
415                         rs->sr_ref = referral_rewrite( default_referral,
416                                 NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
417                 }
418
419                 rs->sr_err = LDAP_REFERRAL;
420                 send_ldap_result( op, rs );
421
422                 ber_bvarray_free( rs->sr_ref );
423                 free( (char *)rs->sr_matched );
424                 rs->sr_ref = NULL;
425                 rs->sr_matched = NULL;
426
427                 goto done;
428         }
429
430         if ( !manageDSAit && is_entry_referral( e ) ) {
431                 /* entry is a referral, don't allow modify */
432                 rs->sr_ref = get_entry_referrals( op, e );
433
434 #ifdef NEW_LOGGING
435                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: entry is referral\n", 0, 0, 0 );
436 #else
437                 Debug( LDAP_DEBUG_TRACE,
438                         "bdb_modify: entry is referral\n",
439                         0, 0, 0 );
440 #endif
441
442                 rs->sr_err = LDAP_REFERRAL;
443                 rs->sr_matched = e->e_name.bv_val;
444                 send_ldap_result( op, rs );
445
446                 ber_bvarray_free( rs->sr_ref );
447                 rs->sr_ref = NULL;
448                 rs->sr_matched = NULL;
449                 goto done;
450         }
451
452 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
453         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
454                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
455                         bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
456                 }
457         }
458 #endif
459         
460         /* nested transaction */
461         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
462                 bdb->bi_db_opflags );
463         rs->sr_text = NULL;
464         if( rs->sr_err != 0 ) {
465 #ifdef NEW_LOGGING
466                 LDAP_LOG ( OPERATION, ERR, 
467                         "bdb_modify: txn_begin(2) failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
468 #else
469                 Debug( LDAP_DEBUG_TRACE,
470                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
471                         db_strerror(rs->sr_err), rs->sr_err, 0 );
472 #endif
473                 rs->sr_err = LDAP_OTHER;
474                 rs->sr_text = "internal error";
475                 goto return_results;
476         }
477         /* Modify the entry */
478         dummy = *e;
479         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
480                 &dummy, &rs->sr_text, textbuf, textlen );
481
482         if( rs->sr_err != LDAP_SUCCESS ) {
483 #ifdef NEW_LOGGING
484                 LDAP_LOG ( OPERATION, ERR, 
485                         "bdb_modify: modify failed (%d)\n", rs->sr_err, 0, 0 );
486 #else
487                 Debug( LDAP_DEBUG_TRACE,
488                         "bdb_modify: modify failed (%d)\n",
489                         rs->sr_err, 0, 0 );
490 #endif
491                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
492                         rs->sr_err = opinfo.boi_err;
493                 }
494                 switch( rs->sr_err ) {
495                 case DB_LOCK_DEADLOCK:
496                 case DB_LOCK_NOTGRANTED:
497                         goto retry;
498                 }
499                 goto return_results;
500         }
501
502         /* change the entry itself */
503         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
504         if ( rs->sr_err != 0 ) {
505 #ifdef NEW_LOGGING
506                 LDAP_LOG ( OPERATION, ERR, 
507                         "bdb_modify: id2entry update failed (%d)\n", rs->sr_err, 0, 0 );
508 #else
509                 Debug( LDAP_DEBUG_TRACE,
510                         "bdb_modify: id2entry update failed (%d)\n",
511                         rs->sr_err, 0, 0 );
512 #endif
513                 switch( rs->sr_err ) {
514                 case DB_LOCK_DEADLOCK:
515                 case DB_LOCK_NOTGRANTED:
516                         goto retry;
517                 }
518                 rs->sr_text = "entry update failed";
519                 goto return_results;
520         }
521         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
522                 rs->sr_err = LDAP_OTHER;
523                 rs->sr_text = "txn_commit(2) failed";
524                 goto return_results;
525         }
526
527         if( op->o_noop ) {
528                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
529                         rs->sr_text = "txn_abort (no-op) failed";
530                 } else {
531                         noop = 1;
532                         rs->sr_err = LDAP_SUCCESS;
533                 }
534         } else {
535                 bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
536                 rs->sr_err = TXN_COMMIT( ltid, 0 );
537         }
538         ltid = NULL;
539         op->o_private = NULL;
540
541         if( rs->sr_err != 0 ) {
542 #ifdef NEW_LOGGING
543                 LDAP_LOG ( OPERATION, ERR, 
544                         "bdb_modify: txn_%s failed %s (%d)\n", 
545                         op->o_noop ? "abort (no_op)" : "commit", db_strerror(rs->sr_err), rs->sr_err );
546 #else
547                 Debug( LDAP_DEBUG_TRACE,
548                         "bdb_modify: txn_%s failed: %s (%d)\n",
549                         op->o_noop ? "abort (no-op)" : "commit",
550                         db_strerror(rs->sr_err), rs->sr_err );
551 #endif
552                 rs->sr_err = LDAP_OTHER;
553                 rs->sr_text = "commit failed";
554
555         } else {
556 #ifdef NEW_LOGGING
557                 LDAP_LOG ( OPERATION, DETAIL1, 
558                         "bdb_modify: updated%s id=%08lx dn=\"%s\"\n", 
559                         op->o_noop ? " (no_op)" : "", e->e_id, e->e_dn );
560 #else
561                 Debug( LDAP_DEBUG_TRACE,
562                         "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
563                         op->o_noop ? " (no-op)" : "",
564                         e->e_id, e->e_dn );
565 #endif
566                 rs->sr_err = LDAP_SUCCESS;
567                 rs->sr_text = NULL;
568         }
569
570 return_results:
571         send_ldap_result( op, rs );
572
573 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
574         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
575                 /* Loop through in-scope entries for each psearch spec */
576                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
577                         bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
578                 }
579                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
580                 while ( pm_list != NULL ) {
581                         bdb_psearch(op, rs, pm_list->ps_op,
582                                                 e, LDAP_PSEARCH_BY_SCOPEOUT);
583                         LDAP_LIST_REMOVE ( pm_list, ps_link );
584                         pm_prev = pm_list;
585                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
586                         ch_free( pm_prev );
587                 }
588         }
589 #endif
590
591         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
592                 ldap_pvt_thread_yield();
593                 TXN_CHECKPOINT( bdb->bi_dbenv,
594                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
595         }
596
597 done:
598         if( ltid != NULL ) {
599 #if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC)
600                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
601                 while ( pm_list != NULL ) {
602                         LDAP_LIST_REMOVE ( pm_list, ps_link );
603                         pm_prev = pm_list;
604                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
605                         ch_free( pm_prev );
606                 }
607 #endif
608                 TXN_ABORT( ltid );
609                 op->o_private = NULL;
610         }
611
612         if( e != NULL ) {
613                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
614         }
615         return ( ( rs->sr_err == LDAP_SUCCESS ) ? noop : rs->sr_err );
616 }