git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c

   1 /* modify.c - bdb backend modify routine */
   2 /* $OpenLDAP$ */
   3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
   4  *
   5  * Copyright 2000-2006 The OpenLDAP Foundation.
   6  * All rights reserved.
   7  *
   8  * Redistribution and use in source and binary forms, with or without
   9  * modification, are permitted only as authorized by the OpenLDAP
  10  * Public License.
  11  *
  12  * A copy of this license is available in the file LICENSE in the
  13  * top-level directory of the distribution or, alternatively, at
  14  * <http://www.OpenLDAP.org/license.html>.
  15  */
  16
  17 #include "portable.h"
  18
  19 #include <stdio.h>
  20 #include <ac/string.h>
  21 #include <ac/time.h>
  22
  23 #include "back-bdb.h"
  24
  25 static struct berval scbva[] = {
  26         BER_BVC("glue"),
  27         BER_BVNULL
  28 };
  29
  30 int bdb_modify_internal(
  31         Operation *op,
  32         DB_TXN *tid,
  33         Modifications *modlist,
  34         Entry *e,
  35         const char **text,
  36         char *textbuf,
  37         size_t textlen )
  38 {
  39         int rc, err;
  40         Modification    *mod;
  41         Modifications   *ml;
  42         Attribute       *save_attrs;
  43         Attribute       *ap;
  44         int                     glue_attr_delete = 0;
  45
  46         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
  47                 e->e_id, e->e_dn, 0);
  48
  49         if ( !acl_check_modlist( op, e, modlist )) {
  50                 return LDAP_INSUFFICIENT_ACCESS;
  51         }
  52
  53         /* save_attrs will be disposed of by bdb_cache_modify */
  54         save_attrs = e->e_attrs;
  55         e->e_attrs = attrs_dup( e->e_attrs );
  56
  57         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  58                 int match;
  59                 mod = &ml->sml_mod;
  60                 switch( mod->sm_op ) {
  61                 case LDAP_MOD_ADD:
  62                 case LDAP_MOD_REPLACE:
  63                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
  64                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
  65                                         slap_schema.si_ad_structuralObjectClass->
  66                                                 ad_type->sat_equality,
  67                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
  68                                         &mod->sm_values[0], &scbva[0], text );
  69                                 if ( !match ) glue_attr_delete = 1;
  70                         }
  71                 }
  72                 if ( glue_attr_delete )
  73                         break;
  74         }
  75
  76         if ( glue_attr_delete ) {
  77                 Attribute       **app = &e->e_attrs;
  78                 while ( *app != NULL ) {
  79                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
  80                                 Attribute *save = *app;
  81                                 *app = (*app)->a_next;
  82                                 attr_free( save );
  83                                 continue;
  84                         }
  85                         app = &(*app)->a_next;
  86                 }
  87         }
  88
  89         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  90                 mod = &ml->sml_mod;
  91
  92                 switch ( mod->sm_op ) {
  93                 case LDAP_MOD_ADD:
  94                         Debug(LDAP_DEBUG_ARGS,
  95                                 "bdb_modify_internal: add %s\n",
  96                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
  97                         err = modify_add_values( e, mod, get_permissiveModify(op),
  98                                 text, textbuf, textlen );
  99                         if( err != LDAP_SUCCESS ) {
 100                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 101                                         err, *text, 0);
 102                         }
 103                         break;
 104
 105                 case LDAP_MOD_DELETE:
 106                         if ( glue_attr_delete ) {
 107                                 err = LDAP_SUCCESS;
 108                                 break;
 109                         }
 110
 111                         Debug(LDAP_DEBUG_ARGS,
 112                                 "bdb_modify_internal: delete %s\n",
 113                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 114                         err = modify_delete_values( e, mod, get_permissiveModify(op),
 115                                 text, textbuf, textlen );
 116                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
 117                         if( err != LDAP_SUCCESS ) {
 118                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 119                                         err, *text, 0);
 120                         }
 121                         break;
 122
 123                 case LDAP_MOD_REPLACE:
 124                         Debug(LDAP_DEBUG_ARGS,
 125                                 "bdb_modify_internal: replace %s\n",
 126                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 127                         err = modify_replace_values( e, mod, get_permissiveModify(op),
 128                                 text, textbuf, textlen );
 129                         if( err != LDAP_SUCCESS ) {
 130                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 131                                         err, *text, 0);
 132                         }
 133                         break;
 134
 135                 case LDAP_MOD_INCREMENT:
 136                         Debug(LDAP_DEBUG_ARGS,
 137                                 "bdb_modify_internal: increment %s\n",
 138                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 139                         err = modify_increment_values( e, mod, get_permissiveModify(op),
 140                                 text, textbuf, textlen );
 141                         if( err != LDAP_SUCCESS ) {
 142                                 Debug(LDAP_DEBUG_ARGS,
 143                                         "bdb_modify_internal: %d %s\n",
 144                                         err, *text, 0);
 145                         }
 146                         break;
 147
 148                 case SLAP_MOD_SOFTADD:
 149                         Debug(LDAP_DEBUG_ARGS,
 150                                 "bdb_modify_internal: softadd %s\n",
 151                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
 152                         /* Avoid problems in index_add_mods()
 153                          * We need to add index if necessary.
 154                          */
 155                         mod->sm_op = LDAP_MOD_ADD;
 156
 157                         err = modify_add_values( e, mod, get_permissiveModify(op),
 158                                 text, textbuf, textlen );
 159
 160                         mod->sm_op = SLAP_MOD_SOFTADD;
 161
 162                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
 163                                 err = LDAP_SUCCESS;
 164                         }
 165
 166                         if( err != LDAP_SUCCESS ) {
 167                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 168                                         err, *text, 0);
 169                         }
 170                         break;
 171
 172                 default:
 173                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
 174                                 mod->sm_op, 0, 0);
 175                         *text = "Invalid modify operation";
 176                         err = LDAP_OTHER;
 177                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 178                                 err, *text, 0);
 179                 }
 180
 181                 if ( err != LDAP_SUCCESS ) {
 182                         attrs_free( e->e_attrs );
 183                         e->e_attrs = save_attrs;
 184                         /* unlock entry, delete from cache */
 185                         return err;
 186                 }
 187
 188                 /* If objectClass was modified, reset the flags */
 189                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
 190                         e->e_ocflags = 0;
 191                 }
 192
 193                 if ( glue_attr_delete ) e->e_ocflags = 0;
 194
 195                 /* check if modified attribute was indexed
 196                  * but not in case of NOOP... */
 197                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
 198                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
 199                         ap = attr_find( save_attrs, mod->sm_desc );
 200                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
 201
 202                         ap = attr_find( e->e_attrs, mod->sm_desc );
 203                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
 204                 }
 205         }
 206
 207         /* check that the entry still obeys the schema */
 208         rc = entry_schema_check( op, e, save_attrs, get_manageDIT(op),
 209                 text, textbuf, textlen );
 210         if ( rc != LDAP_SUCCESS || op->o_noop ) {
 211                 attrs_free( e->e_attrs );
 212                 /* clear the indexing flags */
 213                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 214                         ap->a_flags = 0;
 215                 }
 216                 e->e_attrs = save_attrs;
 217
 218                 if ( rc != LDAP_SUCCESS ) {
 219                         Debug( LDAP_DEBUG_ANY,
 220                                 "entry failed schema check: %s\n",
 221                                 *text, 0, 0 );
 222                 }
 223
 224                 /* if NOOP then silently revert to saved attrs */
 225                 return rc;
 226         }
 227
 228         /* update the indices of the modified attributes */
 229
 230         /* start with deleting the old index entries */
 231         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 232                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
 233                         rc = bdb_index_values( op, tid, ap->a_desc,
 234                                 ap->a_nvals,
 235                                 e->e_id, SLAP_INDEX_DELETE_OP );
 236                         if ( rc != LDAP_SUCCESS ) {
 237                                 attrs_free( e->e_attrs );
 238                                 e->e_attrs = save_attrs;
 239                                 Debug( LDAP_DEBUG_ANY,
 240                                        "Attribute index delete failure",
 241                                        0, 0, 0 );
 242                                 return rc;
 243                         }
 244                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
 245                 }
 246         }
 247
 248         /* add the new index entries */
 249         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
 250                 if (ap->a_flags & SLAP_ATTR_IXADD) {
 251                         rc = bdb_index_values( op, tid, ap->a_desc,
 252                                 ap->a_nvals,
 253                                 e->e_id, SLAP_INDEX_ADD_OP );
 254                         if ( rc != LDAP_SUCCESS ) {
 255                                 attrs_free( e->e_attrs );
 256                                 e->e_attrs = save_attrs;
 257                                 Debug( LDAP_DEBUG_ANY,
 258                                        "Attribute index add failure",
 259                                        0, 0, 0 );
 260                                 return rc;
 261                         }
 262                         ap->a_flags &= ~SLAP_ATTR_IXADD;
 263                 }
 264         }
 265
 266         return rc;
 267 }
 268
 269
 270 int
 271 bdb_modify( Operation *op, SlapReply *rs )
 272 {
 273         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
 274         Entry           *e = NULL;
 275         EntryInfo       *ei = NULL;
 276         int             manageDSAit = get_manageDSAit( op );
 277         char textbuf[SLAP_TEXT_BUFLEN];
 278         size_t textlen = sizeof textbuf;
 279         DB_TXN  *ltid = NULL, *lt2;
 280         struct bdb_op_info opinfo = {0};
 281         Entry           dummy = {0};
 282         int                     fakeroot = 0;
 283
 284         u_int32_t       locker = 0;
 285         DB_LOCK         lock;
 286
 287         int             num_retries = 0;
 288
 289         LDAPControl **preread_ctrl = NULL;
 290         LDAPControl **postread_ctrl = NULL;
 291         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
 292         int num_ctrls = 0;
 293
 294         int rc;
 295
 296         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
 297                 op->o_req_dn.bv_val, 0, 0 );
 298
 299 #ifdef LDAP_X_TXN
 300         if( op->o_txnSpec ) {
 301                 /* acquire connection lock */
 302                 ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
 303                 if( op->o_conn->c_txn == 0 ) {
 304                         rs->sr_text = "invalid transaction identifier";
 305                         rs->sr_err = LDAP_X_TXN_ID_INVALID;
 306                         goto txnReturn;
 307                 }
 308                 if( op->o_conn->c_txn_backend == NULL ) {
 309                         op->o_conn->c_txn_backend = op->o_bd;
 310
 311                 } else if( op->o_conn->c_txn_backend != op->o_bd ) {
 312                         rs->sr_text = "transaction cannot span multiple database contexts";
 313                         rs->sr_err = LDAP_AFFECTS_MULTIPLE_DSAS;
 314                         goto txnReturn;
 315                 }
 316
 317                 /* insert operation into transaction */
 318
 319                 rs->sr_text = "transaction specified";
 320                 rs->sr_err = LDAP_SUCCESS;
 321
 322 txnReturn:
 323                 /* release connection lock */
 324                 ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
 325
 326                 send_ldap_result( op, rs );
 327                 return rs->sr_err;
 328         }
 329 #endif
 330
 331         ctrls[num_ctrls] = NULL;
 332
 333         slap_mods_opattrs( op, &op->orm_modlist, 1 );
 334
 335         if( 0 ) {
 336 retry:  /* transaction retry */
 337                 if ( dummy.e_attrs ) {
 338                         attrs_free( dummy.e_attrs );
 339                         dummy.e_attrs = NULL;
 340                 }
 341                 if( e != NULL ) {
 342                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
 343                         e = NULL;
 344                 }
 345                 Debug(LDAP_DEBUG_TRACE,
 346                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
 347
 348                 rs->sr_err = TXN_ABORT( ltid );
 349                 ltid = NULL;
 350                 op->o_private = NULL;
 351                 op->o_do_not_cache = opinfo.boi_acl_cache;
 352                 if( rs->sr_err != 0 ) {
 353                         rs->sr_err = LDAP_OTHER;
 354                         rs->sr_text = "internal error";
 355                         goto return_results;
 356                 }
 357                 if ( op->o_abandon ) {
 358                         rs->sr_err = SLAPD_ABANDON;
 359                         goto return_results;
 360                 }
 361                 bdb_trans_backoff( ++num_retries );
 362         }
 363
 364         /* begin transaction */
 365         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid,
 366                 bdb->bi_db_opflags );
 367         rs->sr_text = NULL;
 368         if( rs->sr_err != 0 ) {
 369                 Debug( LDAP_DEBUG_TRACE,
 370                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
 371                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
 372                 rs->sr_err = LDAP_OTHER;
 373                 rs->sr_text = "internal error";
 374                 goto return_results;
 375         }
 376
 377         locker = TXN_ID ( ltid );
 378
 379         opinfo.boi_bdb = op->o_bd;
 380         opinfo.boi_txn = ltid;
 381         opinfo.boi_locker = locker;
 382         opinfo.boi_err = 0;
 383         opinfo.boi_acl_cache = op->o_do_not_cache;
 384         op->o_private = &opinfo;
 385
 386         /* get entry or ancestor */
 387         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
 388                 locker, &lock );
 389
 390         if ( rs->sr_err != 0 ) {
 391                 Debug( LDAP_DEBUG_TRACE,
 392                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
 393                         rs->sr_err, 0, 0 );
 394                 switch( rs->sr_err ) {
 395                 case DB_LOCK_DEADLOCK:
 396                 case DB_LOCK_NOTGRANTED:
 397                         goto retry;
 398                 case DB_NOTFOUND:
 399                         if ( BER_BVISEMPTY( &op->o_req_ndn )) {
 400                                 struct berval gluebv = BER_BVC("glue");
 401                                 e = ch_calloc( 1, sizeof(Entry));
 402                                 e->e_name.bv_val = ch_strdup( "" );
 403                                 ber_dupbv( &e->e_nname, &e->e_name );
 404                                 attr_merge_one( e, slap_schema.si_ad_objectClass,
 405                                         &gluebv, NULL );
 406                                 attr_merge_one( e, slap_schema.si_ad_structuralObjectClass,
 407                                         &gluebv, NULL );
 408                                 e->e_private = ei;
 409                                 fakeroot = 1;
 410                                 rs->sr_err = 0;
 411                         }
 412                         break;
 413                 case LDAP_BUSY:
 414                         rs->sr_text = "ldap server busy";
 415                         goto return_results;
 416                 default:
 417                         rs->sr_err = LDAP_OTHER;
 418                         rs->sr_text = "internal error";
 419                         goto return_results;
 420                 }
 421         }
 422
 423         if ( !fakeroot ) {
 424                 e = ei->bei_e;
 425         }
 426
 427         /* acquire and lock entry */
 428         /* FIXME: dn2entry() should return non-glue entry */
 429         if (( rs->sr_err == DB_NOTFOUND ) ||
 430                 ( !manageDSAit && e && is_entry_glue( e )))
 431         {
 432                 if ( e != NULL ) {
 433                         rs->sr_matched = ch_strdup( e->e_dn );
 434                         rs->sr_ref = is_entry_referral( e )
 435                                 ? get_entry_referrals( op, e )
 436                                 : NULL;
 437                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
 438                         e = NULL;
 439
 440                 } else {
 441                         rs->sr_ref = referral_rewrite( default_referral, NULL,
 442                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
 443                 }
 444
 445                 rs->sr_err = LDAP_REFERRAL;
 446                 send_ldap_result( op, rs );
 447
 448                 if ( rs->sr_ref != default_referral ) {
 449                         ber_bvarray_free( rs->sr_ref );
 450                 }
 451                 free( (char *)rs->sr_matched );
 452                 rs->sr_ref = NULL;
 453                 rs->sr_matched = NULL;
 454
 455                 goto done;
 456         }
 457
 458         if ( !manageDSAit && is_entry_referral( e ) ) {
 459                 /* entry is a referral, don't allow modify */
 460                 rs->sr_ref = get_entry_referrals( op, e );
 461
 462                 Debug( LDAP_DEBUG_TRACE,
 463                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
 464                         0, 0, 0 );
 465
 466                 rs->sr_err = LDAP_REFERRAL;
 467                 rs->sr_matched = e->e_name.bv_val;
 468                 send_ldap_result( op, rs );
 469
 470                 ber_bvarray_free( rs->sr_ref );
 471                 rs->sr_ref = NULL;
 472                 rs->sr_matched = NULL;
 473                 goto done;
 474         }
 475
 476         if ( get_assert( op ) &&
 477                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
 478         {
 479                 rs->sr_err = LDAP_ASSERTION_FAILED;
 480                 goto return_results;
 481         }
 482
 483         if( op->o_preread ) {
 484                 if( preread_ctrl == NULL ) {
 485                         preread_ctrl = &ctrls[num_ctrls++];
 486                         ctrls[num_ctrls] = NULL;
 487                 }
 488                 if ( slap_read_controls( op, rs, e,
 489                         &slap_pre_read_bv, preread_ctrl ) )
 490                 {
 491                         Debug( LDAP_DEBUG_TRACE,
 492                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read failed!\n",
 493                                 0, 0, 0 );
 494                         goto return_results;
 495                 }
 496         }
 497
 498         /* nested transaction */
 499         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
 500         rs->sr_text = NULL;
 501         if( rs->sr_err != 0 ) {
 502                 Debug( LDAP_DEBUG_TRACE,
 503                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
 504                         db_strerror(rs->sr_err), rs->sr_err, 0 );
 505                 rs->sr_err = LDAP_OTHER;
 506                 rs->sr_text = "internal error";
 507                 goto return_results;
 508         }
 509         /* Modify the entry */
 510         dummy = *e;
 511         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
 512                 &dummy, &rs->sr_text, textbuf, textlen );
 513
 514         if( rs->sr_err != LDAP_SUCCESS ) {
 515                 Debug( LDAP_DEBUG_TRACE,
 516                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
 517                         rs->sr_err, 0, 0 );
 518                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
 519                         rs->sr_err = opinfo.boi_err;
 520                 }
 521                 /* Only free attrs if they were dup'd.  */
 522                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
 523                 switch( rs->sr_err ) {
 524                 case DB_LOCK_DEADLOCK:
 525                 case DB_LOCK_NOTGRANTED:
 526                         goto retry;
 527                 }
 528                 goto return_results;
 529         }
 530
 531         /* change the entry itself */
 532         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
 533         if ( rs->sr_err != 0 ) {
 534                 Debug( LDAP_DEBUG_TRACE,
 535                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
 536                         rs->sr_err, 0, 0 );
 537                 switch( rs->sr_err ) {
 538                 case DB_LOCK_DEADLOCK:
 539                 case DB_LOCK_NOTGRANTED:
 540                         goto retry;
 541                 }
 542                 rs->sr_text = "entry update failed";
 543                 goto return_results;
 544         }
 545
 546         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
 547                 rs->sr_err = LDAP_OTHER;
 548                 rs->sr_text = "txn_commit(2) failed";
 549                 goto return_results;
 550         }
 551
 552         if( op->o_postread ) {
 553                 if( postread_ctrl == NULL ) {
 554                         postread_ctrl = &ctrls[num_ctrls++];
 555                         ctrls[num_ctrls] = NULL;
 556                 }
 557                 if( slap_read_controls( op, rs, &dummy,
 558                         &slap_post_read_bv, postread_ctrl ) )
 559                 {
 560                         Debug( LDAP_DEBUG_TRACE,
 561                                 "<=- " LDAP_XSTRING(bdb_modify)
 562                                 ": post-read failed!\n", 0, 0, 0 );
 563                         goto return_results;
 564                 }
 565         }
 566
 567         if( op->o_noop ) {
 568                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
 569                         rs->sr_text = "txn_abort (no-op) failed";
 570                 } else {
 571                         rs->sr_err = LDAP_X_NO_OPERATION;
 572                         ltid = NULL;
 573                         goto return_results;
 574                 }
 575         } else {
 576                 /* may have changed in bdb_modify_internal() */
 577                 e->e_ocflags = dummy.e_ocflags;
 578                 if ( fakeroot ) {
 579                         e->e_private = NULL;
 580                         entry_free( e );
 581                         e = NULL;
 582                         attrs_free( dummy.e_attrs );
 583
 584                 } else {
 585                         rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
 586                         switch( rc ) {
 587                         case DB_LOCK_DEADLOCK:
 588                         case DB_LOCK_NOTGRANTED:
 589                                 goto retry;
 590                         }
 591                 }
 592                 dummy.e_attrs = NULL;
 593
 594                 rs->sr_err = TXN_COMMIT( ltid, 0 );
 595         }
 596         ltid = NULL;
 597         op->o_private = NULL;
 598
 599         if( rs->sr_err != 0 ) {
 600                 Debug( LDAP_DEBUG_TRACE,
 601                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
 602                         op->o_noop ? "abort (no-op)" : "commit",
 603                         db_strerror(rs->sr_err), rs->sr_err );
 604                 rs->sr_err = LDAP_OTHER;
 605                 rs->sr_text = "commit failed";
 606
 607                 goto return_results;
 608         }
 609
 610         Debug( LDAP_DEBUG_TRACE,
 611                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
 612                 op->o_noop ? " (no-op)" : "",
 613                 dummy.e_id, op->o_req_dn.bv_val );
 614
 615         rs->sr_err = LDAP_SUCCESS;
 616         rs->sr_text = NULL;
 617         if( num_ctrls ) rs->sr_ctrls = ctrls;
 618
 619 return_results:
 620         if( dummy.e_attrs ) {
 621                 attrs_free( dummy.e_attrs );
 622         }
 623         send_ldap_result( op, rs );
 624
 625         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
 626                 TXN_CHECKPOINT( bdb->bi_dbenv,
 627                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
 628         }
 629
 630 done:
 631         slap_graduate_commit_csn( op );
 632
 633         if( ltid != NULL ) {
 634                 TXN_ABORT( ltid );
 635         }
 636         op->o_private = NULL;
 637
 638         if( e != NULL ) {
 639                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
 640         }
 641
 642         if( preread_ctrl != NULL ) {
 643                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
 644                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
 645         }
 646         if( postread_ctrl != NULL ) {
 647                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
 648                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
 649         }
 650         return rs->sr_err;
 651 }