]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
Happy New Year
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2011 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 static void
31 bdb_modify_idxflags(
32         Operation *op,
33         AttributeDescription *desc,
34         int got_delete,
35         Attribute *newattrs,
36         Attribute *oldattrs )
37 {
38         struct berval   ix_at;
39         AttrInfo        *ai;
40
41         /* check if modified attribute was indexed
42          * but not in case of NOOP... */
43         ai = bdb_index_mask( op->o_bd, desc, &ix_at );
44         if ( ai ) {
45                 if ( got_delete ) {
46                         Attribute       *ap;
47                         struct berval   ix2;
48
49                         ap = attr_find( oldattrs, desc );
50                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
51
52                         /* Find all other attrs that index to same slot */
53                         for ( ap = newattrs; ap; ap = ap->a_next ) {
54                                 ai = bdb_index_mask( op->o_bd, ap->a_desc, &ix2 );
55                                 if ( ai && ix2.bv_val == ix_at.bv_val )
56                                         ap->a_flags |= SLAP_ATTR_IXADD;
57                         }
58
59                 } else {
60                         Attribute       *ap;
61
62                         ap = attr_find( newattrs, desc );
63                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
64                 }
65         }
66 }
67
68 int bdb_modify_internal(
69         Operation *op,
70         DB_TXN *tid,
71         Modifications *modlist,
72         Entry *e,
73         const char **text,
74         char *textbuf,
75         size_t textlen )
76 {
77         int rc, err;
78         Modification    *mod;
79         Modifications   *ml;
80         Attribute       *save_attrs;
81         Attribute       *ap;
82         int                     glue_attr_delete = 0;
83         int                     got_delete;
84
85         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
86                 e->e_id, e->e_dn, 0);
87
88         if ( !acl_check_modlist( op, e, modlist )) {
89                 return LDAP_INSUFFICIENT_ACCESS;
90         }
91
92         /* save_attrs will be disposed of by bdb_cache_modify */
93         save_attrs = e->e_attrs;
94         e->e_attrs = attrs_dup( e->e_attrs );
95
96         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
97                 int match;
98                 mod = &ml->sml_mod;
99                 switch( mod->sm_op ) {
100                 case LDAP_MOD_ADD:
101                 case LDAP_MOD_REPLACE:
102                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
103                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
104                                         slap_schema.si_ad_structuralObjectClass->
105                                                 ad_type->sat_equality,
106                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
107                                         &mod->sm_values[0], &scbva[0], text );
108                                 if ( !match ) glue_attr_delete = 1;
109                         }
110                 }
111                 if ( glue_attr_delete )
112                         break;
113         }
114
115         if ( glue_attr_delete ) {
116                 Attribute       **app = &e->e_attrs;
117                 while ( *app != NULL ) {
118                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
119                                 Attribute *save = *app;
120                                 *app = (*app)->a_next;
121                                 attr_free( save );
122                                 continue;
123                         }
124                         app = &(*app)->a_next;
125                 }
126         }
127
128         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
129                 mod = &ml->sml_mod;
130                 got_delete = 0;
131
132                 switch ( mod->sm_op ) {
133                 case LDAP_MOD_ADD:
134                         Debug(LDAP_DEBUG_ARGS,
135                                 "bdb_modify_internal: add %s\n",
136                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
137                         err = modify_add_values( e, mod, get_permissiveModify(op),
138                                 text, textbuf, textlen );
139                         if( err != LDAP_SUCCESS ) {
140                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
141                                         err, *text, 0);
142                         }
143                         break;
144
145                 case LDAP_MOD_DELETE:
146                         if ( glue_attr_delete ) {
147                                 err = LDAP_SUCCESS;
148                                 break;
149                         }
150
151                         Debug(LDAP_DEBUG_ARGS,
152                                 "bdb_modify_internal: delete %s\n",
153                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
154                         err = modify_delete_values( e, mod, get_permissiveModify(op),
155                                 text, textbuf, textlen );
156                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
157                         if( err != LDAP_SUCCESS ) {
158                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
159                                         err, *text, 0);
160                         } else {
161                                 got_delete = 1;
162                         }
163                         break;
164
165                 case LDAP_MOD_REPLACE:
166                         Debug(LDAP_DEBUG_ARGS,
167                                 "bdb_modify_internal: replace %s\n",
168                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
169                         err = modify_replace_values( e, mod, get_permissiveModify(op),
170                                 text, textbuf, textlen );
171                         if( err != LDAP_SUCCESS ) {
172                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
173                                         err, *text, 0);
174                         } else {
175                                 got_delete = 1;
176                         }
177                         break;
178
179                 case LDAP_MOD_INCREMENT:
180                         Debug(LDAP_DEBUG_ARGS,
181                                 "bdb_modify_internal: increment %s\n",
182                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
183                         err = modify_increment_values( e, mod, get_permissiveModify(op),
184                                 text, textbuf, textlen );
185                         if( err != LDAP_SUCCESS ) {
186                                 Debug(LDAP_DEBUG_ARGS,
187                                         "bdb_modify_internal: %d %s\n",
188                                         err, *text, 0);
189                         } else {
190                                 got_delete = 1;
191                         }
192                         break;
193
194                 case SLAP_MOD_SOFTADD:
195                         Debug(LDAP_DEBUG_ARGS,
196                                 "bdb_modify_internal: softadd %s\n",
197                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
198                         /* Avoid problems in index_add_mods()
199                          * We need to add index if necessary.
200                          */
201                         mod->sm_op = LDAP_MOD_ADD;
202
203                         err = modify_add_values( e, mod, get_permissiveModify(op),
204                                 text, textbuf, textlen );
205
206                         mod->sm_op = SLAP_MOD_SOFTADD;
207
208                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
209                                 err = LDAP_SUCCESS;
210                         }
211
212                         if( err != LDAP_SUCCESS ) {
213                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
214                                         err, *text, 0);
215                         }
216                         break;
217
218                 case SLAP_MOD_SOFTDEL:
219                         Debug(LDAP_DEBUG_ARGS,
220                                 "bdb_modify_internal: softdel %s\n",
221                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
222                         /* Avoid problems in index_delete_mods()
223                          * We need to add index if necessary.
224                          */
225                         mod->sm_op = LDAP_MOD_DELETE;
226
227                         err = modify_delete_values( e, mod, get_permissiveModify(op),
228                                 text, textbuf, textlen );
229
230                         mod->sm_op = SLAP_MOD_SOFTDEL;
231
232                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
233                                 err = LDAP_SUCCESS;
234                         }
235
236                         if( err != LDAP_SUCCESS ) {
237                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
238                                         err, *text, 0);
239                         }
240                         break;
241
242                 case SLAP_MOD_ADD_IF_NOT_PRESENT:
243                         if ( attr_find( e->e_attrs, mod->sm_desc ) != NULL ) {
244                                 /* skip */
245                                 err = LDAP_SUCCESS;
246                                 break;
247                         }
248
249                         Debug(LDAP_DEBUG_ARGS,
250                                 "bdb_modify_internal: add_if_not_present %s\n",
251                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
252                         /* Avoid problems in index_add_mods()
253                          * We need to add index if necessary.
254                          */
255                         mod->sm_op = LDAP_MOD_ADD;
256
257                         err = modify_add_values( e, mod, get_permissiveModify(op),
258                                 text, textbuf, textlen );
259
260                         mod->sm_op = SLAP_MOD_ADD_IF_NOT_PRESENT;
261
262                         if( err != LDAP_SUCCESS ) {
263                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
264                                         err, *text, 0);
265                         }
266                         break;
267
268                 default:
269                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
270                                 mod->sm_op, 0, 0);
271                         *text = "Invalid modify operation";
272                         err = LDAP_OTHER;
273                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
274                                 err, *text, 0);
275                 }
276
277                 if ( err != LDAP_SUCCESS ) {
278                         attrs_free( e->e_attrs );
279                         e->e_attrs = save_attrs;
280                         /* unlock entry, delete from cache */
281                         return err; 
282                 }
283
284                 /* If objectClass was modified, reset the flags */
285                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
286                         e->e_ocflags = 0;
287                 }
288
289                 if ( glue_attr_delete ) e->e_ocflags = 0;
290
291
292                 /* check if modified attribute was indexed
293                  * but not in case of NOOP... */
294                 if ( !op->o_noop ) {
295                         bdb_modify_idxflags( op, mod->sm_desc, got_delete, e->e_attrs, save_attrs );
296                 }
297         }
298
299         /* check that the entry still obeys the schema */
300         ap = NULL;
301         rc = entry_schema_check( op, e, save_attrs, get_relax(op), 0, &ap,
302                 text, textbuf, textlen );
303         if ( rc != LDAP_SUCCESS || op->o_noop ) {
304                 attrs_free( e->e_attrs );
305                 /* clear the indexing flags */
306                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
307                         ap->a_flags &= ~(SLAP_ATTR_IXADD|SLAP_ATTR_IXDEL);
308                 }
309                 e->e_attrs = save_attrs;
310
311                 if ( rc != LDAP_SUCCESS ) {
312                         Debug( LDAP_DEBUG_ANY,
313                                 "entry failed schema check: %s\n",
314                                 *text, 0, 0 );
315                 }
316
317                 /* if NOOP then silently revert to saved attrs */
318                 return rc;
319         }
320
321         /* structuralObjectClass modified! */
322         if ( ap ) {
323                 assert( ap->a_desc == slap_schema.si_ad_structuralObjectClass );
324                 if ( !op->o_noop ) {
325                         bdb_modify_idxflags( op, slap_schema.si_ad_structuralObjectClass,
326                                 1, e->e_attrs, save_attrs );
327                 }
328         }
329
330         /* update the indices of the modified attributes */
331
332         /* start with deleting the old index entries */
333         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
334                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
335                         struct berval *vals;
336                         Attribute *a2;
337                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
338                         a2 = attr_find( e->e_attrs, ap->a_desc );
339                         if ( a2 ) {
340                                 /* need to detect which values were deleted */
341                                 int i, j;
342                                 struct berval tmp;
343                                 j = ap->a_numvals;
344                                 for ( i=0; i<j; ) {
345                                         rc = attr_valfind( a2, SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
346                                                 &ap->a_nvals[i], NULL, op->o_tmpmemctx );
347                                         /* Move deleted values to end of array */
348                                         if ( rc == LDAP_NO_SUCH_ATTRIBUTE ) {
349                                                 j--;
350                                                 if ( i != j ) {
351                                                         tmp = ap->a_nvals[j];
352                                                         ap->a_nvals[j] = ap->a_nvals[i];
353                                                         ap->a_nvals[i] = tmp;
354                                                         tmp = ap->a_vals[j];
355                                                         ap->a_vals[j] = ap->a_vals[i];
356                                                         ap->a_vals[i] = tmp;
357                                                 }
358                                                 continue;
359                                         }
360                                         i++;
361                                 }
362                                 vals = &ap->a_nvals[j];
363                         } else {
364                                 /* attribute was completely deleted */
365                                 vals = ap->a_nvals;
366                         }
367                         if ( !BER_BVISNULL( vals )) {
368                                 rc = bdb_index_values( op, tid, ap->a_desc,
369                                         vals, e->e_id, SLAP_INDEX_DELETE_OP );
370                                 if ( rc != LDAP_SUCCESS ) {
371                                         Debug( LDAP_DEBUG_ANY,
372                                                 "%s: attribute \"%s\" index delete failure\n",
373                                                 op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
374                                         attrs_free( e->e_attrs );
375                                         e->e_attrs = save_attrs;
376                                         return rc;
377                                 }
378                         }
379                 }
380         }
381
382         /* add the new index entries */
383         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
384                 if (ap->a_flags & SLAP_ATTR_IXADD) {
385                         ap->a_flags &= ~SLAP_ATTR_IXADD;
386                         rc = bdb_index_values( op, tid, ap->a_desc,
387                                 ap->a_nvals,
388                                 e->e_id, SLAP_INDEX_ADD_OP );
389                         if ( rc != LDAP_SUCCESS ) {
390                                 Debug( LDAP_DEBUG_ANY,
391                                        "%s: attribute \"%s\" index add failure\n",
392                                         op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
393                                 attrs_free( e->e_attrs );
394                                 e->e_attrs = save_attrs;
395                                 return rc;
396                         }
397                 }
398         }
399
400         return rc;
401 }
402
403
404 int
405 bdb_modify( Operation *op, SlapReply *rs )
406 {
407         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
408         Entry           *e = NULL;
409         EntryInfo       *ei = NULL;
410         int             manageDSAit = get_manageDSAit( op );
411         char textbuf[SLAP_TEXT_BUFLEN];
412         size_t textlen = sizeof textbuf;
413         DB_TXN  *ltid = NULL, *lt2;
414         struct bdb_op_info opinfo = {{{ 0 }}};
415         Entry           dummy = {0};
416
417         DB_LOCK         lock;
418
419         int             num_retries = 0;
420
421         LDAPControl **preread_ctrl = NULL;
422         LDAPControl **postread_ctrl = NULL;
423         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
424         int num_ctrls = 0;
425
426         int rc;
427
428 #ifdef LDAP_X_TXN
429         int settle = 0;
430 #endif
431
432         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
433                 op->o_req_dn.bv_val, 0, 0 );
434
435 #ifdef LDAP_X_TXN
436         if( op->o_txnSpec ) {
437                 /* acquire connection lock */
438                 ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
439                 if( op->o_conn->c_txn == CONN_TXN_INACTIVE ) {
440                         rs->sr_text = "invalid transaction identifier";
441                         rs->sr_err = LDAP_X_TXN_ID_INVALID;
442                         goto txnReturn;
443                 } else if( op->o_conn->c_txn == CONN_TXN_SETTLE ) {
444                         settle=1;
445                         goto txnReturn;
446                 }
447
448                 if( op->o_conn->c_txn_backend == NULL ) {
449                         op->o_conn->c_txn_backend = op->o_bd;
450
451                 } else if( op->o_conn->c_txn_backend != op->o_bd ) {
452                         rs->sr_text = "transaction cannot span multiple database contexts";
453                         rs->sr_err = LDAP_AFFECTS_MULTIPLE_DSAS;
454                         goto txnReturn;
455                 }
456
457                 /* insert operation into transaction */
458
459                 rs->sr_text = "transaction specified";
460                 rs->sr_err = LDAP_X_TXN_SPECIFY_OKAY;
461
462 txnReturn:
463                 /* release connection lock */
464                 ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
465
466                 if( !settle ) {
467                         send_ldap_result( op, rs );
468                         return rs->sr_err;
469                 }
470         }
471 #endif
472
473         ctrls[num_ctrls] = NULL;
474
475         /* Don't touch the opattrs, if this is a contextCSN update
476          * initiated from updatedn */
477         if ( !be_isupdate(op) || !op->orm_modlist || op->orm_modlist->sml_next ||
478                  op->orm_modlist->sml_desc != slap_schema.si_ad_contextCSN ) {
479
480                 slap_mods_opattrs( op, &op->orm_modlist, 1 );
481         }
482
483         if( 0 ) {
484 retry:  /* transaction retry */
485                 if ( dummy.e_attrs ) {
486                         attrs_free( dummy.e_attrs );
487                         dummy.e_attrs = NULL;
488                 }
489                 if( e != NULL ) {
490                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
491                         e = NULL;
492                 }
493                 Debug(LDAP_DEBUG_TRACE,
494                         LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
495
496                 rs->sr_err = TXN_ABORT( ltid );
497                 ltid = NULL;
498                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
499                 opinfo.boi_oe.oe_key = NULL;
500                 op->o_do_not_cache = opinfo.boi_acl_cache;
501                 if( rs->sr_err != 0 ) {
502                         rs->sr_err = LDAP_OTHER;
503                         rs->sr_text = "internal error";
504                         goto return_results;
505                 }
506                 if ( op->o_abandon ) {
507                         rs->sr_err = SLAPD_ABANDON;
508                         goto return_results;
509                 }
510                 bdb_trans_backoff( ++num_retries );
511         }
512
513         /* begin transaction */
514         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
515                 bdb->bi_db_opflags );
516         rs->sr_text = NULL;
517         if( rs->sr_err != 0 ) {
518                 Debug( LDAP_DEBUG_TRACE,
519                         LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
520                         "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
521                 rs->sr_err = LDAP_OTHER;
522                 rs->sr_text = "internal error";
523                 goto return_results;
524         }
525
526         opinfo.boi_oe.oe_key = bdb;
527         opinfo.boi_txn = ltid;
528         opinfo.boi_err = 0;
529         opinfo.boi_acl_cache = op->o_do_not_cache;
530         LDAP_SLIST_INSERT_HEAD( &op->o_extra, &opinfo.boi_oe, oe_next );
531
532         /* get entry or ancestor */
533         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
534                 &lock );
535
536         if ( rs->sr_err != 0 ) {
537                 Debug( LDAP_DEBUG_TRACE,
538                         LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
539                         rs->sr_err, 0, 0 );
540                 switch( rs->sr_err ) {
541                 case DB_LOCK_DEADLOCK:
542                 case DB_LOCK_NOTGRANTED:
543                         goto retry;
544                 case DB_NOTFOUND:
545                         break;
546                 case LDAP_BUSY:
547                         rs->sr_text = "ldap server busy";
548                         goto return_results;
549                 default:
550                         rs->sr_err = LDAP_OTHER;
551                         rs->sr_text = "internal error";
552                         goto return_results;
553                 }
554         }
555
556         e = ei->bei_e;
557
558         /* acquire and lock entry */
559         /* FIXME: dn2entry() should return non-glue entry */
560         if (( rs->sr_err == DB_NOTFOUND ) ||
561                 ( !manageDSAit && e && is_entry_glue( e )))
562         {
563                 if ( e != NULL ) {
564                         rs->sr_matched = ch_strdup( e->e_dn );
565                         rs->sr_ref = is_entry_referral( e )
566                                 ? get_entry_referrals( op, e )
567                                 : NULL;
568                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
569                         e = NULL;
570
571                 } else {
572                         rs->sr_ref = referral_rewrite( default_referral, NULL,
573                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
574                 }
575
576                 rs->sr_err = LDAP_REFERRAL;
577                 send_ldap_result( op, rs );
578
579                 if ( rs->sr_ref != default_referral ) {
580                         ber_bvarray_free( rs->sr_ref );
581                 }
582                 free( (char *)rs->sr_matched );
583                 rs->sr_ref = NULL;
584                 rs->sr_matched = NULL;
585
586                 goto done;
587         }
588
589         if ( !manageDSAit && is_entry_referral( e ) ) {
590                 /* entry is a referral, don't allow modify */
591                 rs->sr_ref = get_entry_referrals( op, e );
592
593                 Debug( LDAP_DEBUG_TRACE,
594                         LDAP_XSTRING(bdb_modify) ": entry is referral\n",
595                         0, 0, 0 );
596
597                 rs->sr_err = LDAP_REFERRAL;
598                 rs->sr_matched = e->e_name.bv_val;
599                 send_ldap_result( op, rs );
600
601                 ber_bvarray_free( rs->sr_ref );
602                 rs->sr_ref = NULL;
603                 rs->sr_matched = NULL;
604                 goto done;
605         }
606
607         if ( get_assert( op ) &&
608                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
609         {
610                 rs->sr_err = LDAP_ASSERTION_FAILED;
611                 goto return_results;
612         }
613
614         if( op->o_preread ) {
615                 if( preread_ctrl == NULL ) {
616                         preread_ctrl = &ctrls[num_ctrls++];
617                         ctrls[num_ctrls] = NULL;
618                 }
619                 if ( slap_read_controls( op, rs, e,
620                         &slap_pre_read_bv, preread_ctrl ) )
621                 {
622                         Debug( LDAP_DEBUG_TRACE,
623                                 "<=- " LDAP_XSTRING(bdb_modify) ": pre-read "
624                                 "failed!\n", 0, 0, 0 );
625                         if ( op->o_preread & SLAP_CONTROL_CRITICAL ) {
626                                 /* FIXME: is it correct to abort
627                                  * operation if control fails? */
628                                 goto return_results;
629                         }
630                 }
631         }
632
633         /* nested transaction */
634         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
635         rs->sr_text = NULL;
636         if( rs->sr_err != 0 ) {
637                 Debug( LDAP_DEBUG_TRACE,
638                         LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
639                         db_strerror(rs->sr_err), rs->sr_err, 0 );
640                 rs->sr_err = LDAP_OTHER;
641                 rs->sr_text = "internal error";
642                 goto return_results;
643         }
644         /* Modify the entry */
645         dummy = *e;
646         rs->sr_err = bdb_modify_internal( op, lt2, op->orm_modlist,
647                 &dummy, &rs->sr_text, textbuf, textlen );
648
649         if( rs->sr_err != LDAP_SUCCESS ) {
650                 Debug( LDAP_DEBUG_TRACE,
651                         LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
652                         rs->sr_err, 0, 0 );
653                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
654                         rs->sr_err = opinfo.boi_err;
655                 }
656                 /* Only free attrs if they were dup'd.  */
657                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
658                 switch( rs->sr_err ) {
659                 case DB_LOCK_DEADLOCK:
660                 case DB_LOCK_NOTGRANTED:
661                         goto retry;
662                 }
663                 goto return_results;
664         }
665
666         /* change the entry itself */
667         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
668         if ( rs->sr_err != 0 ) {
669                 Debug( LDAP_DEBUG_TRACE,
670                         LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
671                         rs->sr_err, 0, 0 );
672                 switch( rs->sr_err ) {
673                 case DB_LOCK_DEADLOCK:
674                 case DB_LOCK_NOTGRANTED:
675                         goto retry;
676                 }
677                 rs->sr_text = "entry update failed";
678                 goto return_results;
679         }
680
681         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
682                 rs->sr_err = LDAP_OTHER;
683                 rs->sr_text = "txn_commit(2) failed";
684                 goto return_results;
685         }
686
687         if( op->o_postread ) {
688                 if( postread_ctrl == NULL ) {
689                         postread_ctrl = &ctrls[num_ctrls++];
690                         ctrls[num_ctrls] = NULL;
691                 }
692                 if( slap_read_controls( op, rs, &dummy,
693                         &slap_post_read_bv, postread_ctrl ) )
694                 {
695                         Debug( LDAP_DEBUG_TRACE,
696                                 "<=- " LDAP_XSTRING(bdb_modify)
697                                 ": post-read failed!\n", 0, 0, 0 );
698                         if ( op->o_postread & SLAP_CONTROL_CRITICAL ) {
699                                 /* FIXME: is it correct to abort
700                                  * operation if control fails? */
701                                 goto return_results;
702                         }
703                 }
704         }
705
706         if( op->o_noop ) {
707                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
708                         rs->sr_text = "txn_abort (no-op) failed";
709                 } else {
710                         rs->sr_err = LDAP_X_NO_OPERATION;
711                         ltid = NULL;
712                         /* Only free attrs if they were dup'd.  */
713                         if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
714                         goto return_results;
715                 }
716         } else {
717                 /* may have changed in bdb_modify_internal() */
718                 e->e_ocflags = dummy.e_ocflags;
719                 rc = bdb_cache_modify( bdb, e, dummy.e_attrs, ltid, &lock );
720                 switch( rc ) {
721                 case DB_LOCK_DEADLOCK:
722                 case DB_LOCK_NOTGRANTED:
723                         goto retry;
724                 }
725                 dummy.e_attrs = NULL;
726
727                 rs->sr_err = TXN_COMMIT( ltid, 0 );
728         }
729         ltid = NULL;
730         LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
731         opinfo.boi_oe.oe_key = NULL;
732
733         if( rs->sr_err != 0 ) {
734                 Debug( LDAP_DEBUG_TRACE,
735                         LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
736                         op->o_noop ? "abort (no-op)" : "commit",
737                         db_strerror(rs->sr_err), rs->sr_err );
738                 rs->sr_err = LDAP_OTHER;
739                 rs->sr_text = "commit failed";
740
741                 goto return_results;
742         }
743
744         Debug( LDAP_DEBUG_TRACE,
745                 LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
746                 op->o_noop ? " (no-op)" : "",
747                 dummy.e_id, op->o_req_dn.bv_val );
748
749         rs->sr_err = LDAP_SUCCESS;
750         rs->sr_text = NULL;
751         if( num_ctrls ) rs->sr_ctrls = ctrls;
752
753 return_results:
754         if( dummy.e_attrs ) {
755                 attrs_free( dummy.e_attrs );
756         }
757         send_ldap_result( op, rs );
758
759         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp_kbyte ) {
760                 TXN_CHECKPOINT( bdb->bi_dbenv,
761                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
762         }
763
764 done:
765         slap_graduate_commit_csn( op );
766
767         if( ltid != NULL ) {
768                 TXN_ABORT( ltid );
769         }
770         if ( opinfo.boi_oe.oe_key ) {
771                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.boi_oe, OpExtra, oe_next );
772         }
773
774         if( e != NULL ) {
775                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
776         }
777
778         if( preread_ctrl != NULL && (*preread_ctrl) != NULL ) {
779                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
780                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
781         }
782         if( postread_ctrl != NULL && (*postread_ctrl) != NULL ) {
783                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
784                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
785         }
786
787         rs->sr_text = NULL;
788
789         return rs->sr_err;
790 }