git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c

   1 /* modify.c - bdb backend modify routine */
   2 /* $OpenLDAP$ */
   3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
   4  *
   5  * Copyright 2000-2004 The OpenLDAP Foundation.
   6  * All rights reserved.
   7  *
   8  * Redistribution and use in source and binary forms, with or without
   9  * modification, are permitted only as authorized by the OpenLDAP
  10  * Public License.
  11  *
  12  * A copy of this license is available in the file LICENSE in the
  13  * top-level directory of the distribution or, alternatively, at
  14  * <http://www.OpenLDAP.org/license.html>.
  15  */
  16
  17 #include "portable.h"
  18
  19 #include <stdio.h>
  20 #include <ac/string.h>
  21 #include <ac/time.h>
  22
  23 #include "back-bdb.h"
  24
  25 static struct berval scbva[] = {
  26         BER_BVC("glue"),
  27         BER_BVNULL
  28 };
  29
  30 int bdb_modify_internal(
  31         Operation *op,
  32         DB_TXN *tid,
  33         Modifications *modlist,
  34         Entry *e,
  35         const char **text,
  36         char *textbuf,
  37         size_t textlen )
  38 {
  39         int rc, err;
  40         Modification    *mod;
  41         Modifications   *ml;
  42         Attribute       *save_attrs;
  43         Attribute       *ap;
  44         int                     glue_attr_delete = 0;
  45
  46         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
  47                 e->e_id, e->e_dn, 0);
  48
  49         if ( !acl_check_modlist( op, e, modlist )) {
  50                 return LDAP_INSUFFICIENT_ACCESS;
  51         }
  52
  53         /* save_attrs will be disposed of by bdb_cache_modify */
  54         save_attrs = e->e_attrs;
  55         e->e_attrs = attrs_dup( e->e_attrs );
  56
  57         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  58                 int match;
  59                 mod = &ml->sml_mod;
  60                 switch( mod->sm_op ) {
  61                 case LDAP_MOD_ADD:
  62                 case LDAP_MOD_REPLACE:
  63                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
  64                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
  65                                 slap_schema.si_ad_structuralObjectClass->ad_type->sat_equality,
  66                                 SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
  67                                 &mod->sm_values[0], &scbva[0], text );
  68                                 if ( !match )
  69                                         glue_attr_delete = 1;
  70                         }
  71                 }
  72                 if ( glue_attr_delete )
  73                         break;
  74         }
  75
  76         if ( glue_attr_delete ) {
  77                 Attribute       **app = &e->e_attrs;
  78                 while ( *app != NULL ) {
  79                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
  80                                 Attribute *save = *app;
  81                                 *app = (*app)->a_next;
  82                                 attr_free( save );
  83                                 continue;
  84                         }
  85                         app = &(*app)->a_next;
  86                 }
  87         }
  88
  89         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  90                 mod = &ml->sml_mod;
  91
  92                 switch ( mod->sm_op ) {
  93                 case LDAP_MOD_ADD:
  94                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
  95                         err = modify_add_values( e, mod, get_permissiveModify(op),
  96                                 text, textbuf, textlen );
  97                         if( err != LDAP_SUCCESS ) {
  98                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
  99                                         err, *text, 0);
 100                         }
 101                         break;
 102
 103                 case LDAP_MOD_DELETE:
 104                         if ( glue_attr_delete ) {
 105                                 err = LDAP_SUCCESS;
 106                                 break;
 107                         }
 108
 109                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
 110                         err = modify_delete_values( e, mod, get_permissiveModify(op),
 111                                 text, textbuf, textlen );
 112                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
 113                         if( err != LDAP_SUCCESS ) {
 114                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 115                                         err, *text, 0);
 116                         }
 117                         break;
 118
 119                 case LDAP_MOD_REPLACE:
 120                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
 121                         err = modify_replace_values( e, mod, get_permissiveModify(op),
 122                                 text, textbuf, textlen );
 123                         if( err != LDAP_SUCCESS ) {
 124                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 125                                         err, *text, 0);
 126                         }
 127                         break;
 128
 129                 case LDAP_MOD_INCREMENT:
 130                         Debug(LDAP_DEBUG_ARGS,
 131                                 "bdb_modify_internal: increment\n", 0, 0, 0);
 132                         err = modify_increment_values( e, mod, get_permissiveModify(op),
 133                                 text, textbuf, textlen );
 134                         if( err != LDAP_SUCCESS ) {
 135                                 Debug(LDAP_DEBUG_ARGS,
 136                                         "bdb_modify_internal: %d %s\n",
 137                                         err, *text, 0);
 138                         }
 139                         break;
 140
 141                 case SLAP_MOD_SOFTADD:
 142                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
 143                         /* Avoid problems in index_add_mods()
 144                          * We need to add index if necessary.
 145                          */
 146                         mod->sm_op = LDAP_MOD_ADD;
 147
 148                         err = modify_add_values( e, mod, get_permissiveModify(op),
 149                                 text, textbuf, textlen );
 150
 151                         mod->sm_op = SLAP_MOD_SOFTADD;
 152
 153                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
 154                                 err = LDAP_SUCCESS;
 155                         }
 156
 157                         if( err != LDAP_SUCCESS ) {
 158                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 159                                         err, *text, 0);
 160                         }
 161                         break;
 162
 163                 default:
 164                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
 165                                 mod->sm_op, 0, 0);
 166                         *text = "Invalid modify operation";
 167                         err = LDAP_OTHER;
 168                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 169                                 err, *text, 0);
 170                 }
 171
 172                 if ( err != LDAP_SUCCESS ) {
 173                         attrs_free( e->e_attrs );
 174                         e->e_attrs = save_attrs;
 175                         /* unlock entry, delete from cache */
 176                         return err;
 177                 }
 178
 179                 /* If objectClass was modified, reset the flags */
 180                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
 181                         e->e_ocflags = 0;
 182                 }
 183
 184                 if ( glue_attr_delete ) {
 185                         e->e_ocflags = 0;
 186                 }
 187
 188                 /* check if modified attribute was indexed
 189                  * but not in case of NOOP... */
 190                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
 191                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
 192                         ap = attr_find( save_attrs, mod->sm_desc );
 193                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
 194
 195                         ap = attr_find( e->e_attrs, mod->sm_desc );
 196                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
 197                 }
 198         }
 199
 200         /* check that the entry still obeys the schema */
 201         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
 202         if ( rc != LDAP_SUCCESS || op->o_noop ) {
 203                 attrs_free( e->e_attrs );
 204                 /* clear the indexing flags */
 205                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 206                         ap->a_flags = 0;
 207                 }
 208                 e->e_attrs = save_attrs;
 209
 210                 if ( rc != LDAP_SUCCESS ) {
 211                         Debug( LDAP_DEBUG_ANY,
 212                                 "entry failed schema check: %s\n",
 213                                 *text, 0, 0 );
 214                 }
 215
 216                 /* if NOOP then silently revert to saved attrs */
 217                 return rc;
 218         }
 219
 220         /* update the indices of the modified attributes */
 221
 222         /* start with deleting the old index entries */
 223         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 224                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
 225                         rc = bdb_index_values( op, tid, ap->a_desc,
 226                                 ap->a_nvals,
 227                                 e->e_id, SLAP_INDEX_DELETE_OP );
 228                         if ( rc != LDAP_SUCCESS ) {
 229                                 attrs_free( e->e_attrs );
 230                                 e->e_attrs = save_attrs;
 231                                 Debug( LDAP_DEBUG_ANY,
 232                                        "Attribute index delete failure",
 233                                        0, 0, 0 );
 234                                 return rc;
 235                         }
 236                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
 237                 }
 238         }
 239
 240         /* add the new index entries */
 241         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
 242                 if (ap->a_flags & SLAP_ATTR_IXADD) {
 243                         rc = bdb_index_values( op, tid, ap->a_desc,
 244                                 ap->a_nvals,
 245                                 e->e_id, SLAP_INDEX_ADD_OP );
 246                         if ( rc != LDAP_SUCCESS ) {
 247                                 attrs_free( e->e_attrs );
 248                                 e->e_attrs = save_attrs;
 249                                 Debug( LDAP_DEBUG_ANY,
 250                                        "Attribute index add failure",
 251                                        0, 0, 0 );
 252                                 return rc;
 253                         }
 254                         ap->a_flags &= ~SLAP_ATTR_IXADD;
 255                 }
 256         }
 257
 258         return rc;
 259 }
 260
 261
 262 int
 263 bdb_modify( Operation *op, SlapReply *rs )
 264 {
 265         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
 266         Entry           *e = NULL;
 267         EntryInfo       *ei = NULL;
 268         int             manageDSAit = get_manageDSAit( op );
 269         char textbuf[SLAP_TEXT_BUFLEN];
 270         size_t textlen = sizeof textbuf;
 271         DB_TXN  *ltid = NULL, *lt2;
 272         struct bdb_op_info opinfo;
 273         Entry           dummy = {0};
 274
 275         u_int32_t       locker = 0;
 276         DB_LOCK         lock;
 277
 278         int             num_retries = 0;
 279
 280         LDAPControl **preread_ctrl = NULL;
 281         LDAPControl **postread_ctrl = NULL;
 282         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
 283         int num_ctrls = 0;
 284
 285         Operation* ps_list;
 286         struct psid_entry *pm_list, *pm_prev;
 287         int rc;
 288         EntryInfo       *suffix_ei;
 289         Entry           *ctxcsn_e;
 290         int                     ctxcsn_added = 0;
 291
 292         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n",
 293                 op->o_req_dn.bv_val, 0, 0 );
 294
 295         ctrls[num_ctrls] = NULL;
 296
 297         if( 0 ) {
 298 retry:  /* transaction retry */
 299                 if ( dummy.e_attrs ) {
 300                         attrs_free( dummy.e_attrs );
 301                         dummy.e_attrs = NULL;
 302                 }
 303                 if( e != NULL ) {
 304                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
 305                         e = NULL;
 306                 }
 307                 Debug(LDAP_DEBUG_TRACE,
 308                         "bdb_modify: retrying...\n", 0, 0, 0);
 309
 310                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
 311                 while ( pm_list != NULL ) {
 312                         LDAP_LIST_REMOVE ( pm_list, ps_link );
 313                         pm_prev = pm_list;
 314                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
 315                         ch_free( pm_prev );
 316                 }
 317
 318                 rs->sr_err = TXN_ABORT( ltid );
 319                 ltid = NULL;
 320                 op->o_private = NULL;
 321                 op->o_do_not_cache = opinfo.boi_acl_cache;
 322                 if( rs->sr_err != 0 ) {
 323                         rs->sr_err = LDAP_OTHER;
 324                         rs->sr_text = "internal error";
 325                         goto return_results;
 326                 }
 327                 ldap_pvt_thread_yield();
 328                 bdb_trans_backoff( ++num_retries );
 329         }
 330
 331         /* begin transaction */
 332         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid,
 333                 bdb->bi_db_opflags );
 334         rs->sr_text = NULL;
 335         if( rs->sr_err != 0 ) {
 336                 Debug( LDAP_DEBUG_TRACE,
 337                         "bdb_modify: txn_begin failed: %s (%d)\n",
 338                         db_strerror(rs->sr_err), rs->sr_err, 0 );
 339                 rs->sr_err = LDAP_OTHER;
 340                 rs->sr_text = "internal error";
 341                 goto return_results;
 342         }
 343
 344         locker = TXN_ID ( ltid );
 345
 346         opinfo.boi_bdb = op->o_bd;
 347         opinfo.boi_txn = ltid;
 348         opinfo.boi_locker = locker;
 349         opinfo.boi_err = 0;
 350         opinfo.boi_acl_cache = op->o_do_not_cache;
 351         op->o_private = &opinfo;
 352
 353         /* get entry or ancestor */
 354         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
 355                 locker, &lock );
 356
 357         if ( rs->sr_err != 0 ) {
 358                 Debug( LDAP_DEBUG_TRACE,
 359                         "bdb_modify: dn2entry failed (%d)\n",
 360                         rs->sr_err, 0, 0 );
 361                 switch( rs->sr_err ) {
 362                 case DB_LOCK_DEADLOCK:
 363                 case DB_LOCK_NOTGRANTED:
 364                         goto retry;
 365                 case DB_NOTFOUND:
 366                         break;
 367                 case LDAP_BUSY:
 368                         rs->sr_text = "ldap server busy";
 369                         goto return_results;
 370                 default:
 371                         rs->sr_err = LDAP_OTHER;
 372                         rs->sr_text = "internal error";
 373                         goto return_results;
 374                 }
 375         }
 376
 377         e = ei->bei_e;
 378         /* acquire and lock entry */
 379         /* FIXME: dn2entry() should return non-glue entry */
 380         if (( rs->sr_err == DB_NOTFOUND ) ||
 381                 ( !manageDSAit && e && is_entry_glue( e )))
 382         {
 383                 BerVarray deref = NULL;
 384                 if ( e != NULL ) {
 385                         rs->sr_matched = ch_strdup( e->e_dn );
 386                         rs->sr_ref = is_entry_referral( e )
 387                                 ? get_entry_referrals( op, e )
 388                                 : NULL;
 389                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
 390                         e = NULL;
 391
 392                 } else {
 393                         if ( !LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
 394                                 syncinfo_t *si;
 395                                 LDAP_STAILQ_FOREACH( si, &op->o_bd->be_syncinfo, si_next ) {
 396                                         struct berval tmpbv;
 397                                         ber_dupbv( &tmpbv, &si->si_provideruri_bv[0] );
 398                                         ber_bvarray_add( &deref, &tmpbv );
 399                 }
 400                         } else {
 401                                 deref = default_referral;
 402                         }
 403                         rs->sr_ref = referral_rewrite( deref, NULL, &op->o_req_dn,
 404                                         LDAP_SCOPE_DEFAULT );
 405                 }
 406
 407                 rs->sr_err = LDAP_REFERRAL;
 408                 send_ldap_result( op, rs );
 409
 410                 if ( rs->sr_ref != default_referral ) {
 411                         ber_bvarray_free( rs->sr_ref );
 412                 }
 413                 if ( deref != default_referral ) {
 414                         ber_bvarray_free( deref );
 415                 }
 416                 free( (char *)rs->sr_matched );
 417                 rs->sr_ref = NULL;
 418                 rs->sr_matched = NULL;
 419
 420                 goto done;
 421         }
 422
 423         if ( !manageDSAit && is_entry_referral( e ) ) {
 424                 /* entry is a referral, don't allow modify */
 425                 rs->sr_ref = get_entry_referrals( op, e );
 426
 427                 Debug( LDAP_DEBUG_TRACE,
 428                         "bdb_modify: entry is referral\n",
 429                         0, 0, 0 );
 430
 431                 rs->sr_err = LDAP_REFERRAL;
 432                 rs->sr_matched = e->e_name.bv_val;
 433                 send_ldap_result( op, rs );
 434
 435                 ber_bvarray_free( rs->sr_ref );
 436                 rs->sr_ref = NULL;
 437                 rs->sr_matched = NULL;
 438                 goto done;
 439         }
 440
 441         if ( get_assert( op ) &&
 442                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
 443         {
 444                 rs->sr_err = LDAP_ASSERTION_FAILED;
 445                 goto return_results;
 446         }
 447
 448         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop && !op->o_no_psearch ) {
 449                 ldap_pvt_thread_rdwr_wlock( &bdb->bi_pslist_rwlock );
 450                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
 451                         rc = bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
 452                         if ( rc == LDAP_BUSY && op->o_ps_send_wait ) {
 453                                 ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
 454                                 goto retry;
 455                         } else if ( rc ) {
 456                                 Debug( LDAP_DEBUG_TRACE,
 457                                         "bdb_modify: persistent search failed (%d,%d)\n",
 458                                         rc, rs->sr_err, 0 );
 459                         }
 460                 }
 461                 ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
 462         }
 463
 464         if( op->o_preread ) {
 465                 if( preread_ctrl == NULL ) {
 466                         preread_ctrl = &ctrls[num_ctrls++];
 467                         ctrls[num_ctrls] = NULL;
 468                 }
 469                 if ( slap_read_controls( op, rs, e,
 470                         &slap_pre_read_bv, preread_ctrl ) )
 471                 {
 472                         Debug( LDAP_DEBUG_TRACE,
 473                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
 474                         goto return_results;
 475                 }
 476         }
 477
 478         /* nested transaction */
 479         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2,
 480                 bdb->bi_db_opflags );
 481         rs->sr_text = NULL;
 482         if( rs->sr_err != 0 ) {
 483                 Debug( LDAP_DEBUG_TRACE,
 484                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
 485                         db_strerror(rs->sr_err), rs->sr_err, 0 );
 486                 rs->sr_err = LDAP_OTHER;
 487                 rs->sr_text = "internal error";
 488                 goto return_results;
 489         }
 490         /* Modify the entry */
 491         dummy = *e;
 492         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
 493                 &dummy, &rs->sr_text, textbuf, textlen );
 494
 495         if( rs->sr_err != LDAP_SUCCESS ) {
 496                 Debug( LDAP_DEBUG_TRACE,
 497                         "bdb_modify: modify failed (%d)\n",
 498                         rs->sr_err, 0, 0 );
 499                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
 500                         rs->sr_err = opinfo.boi_err;
 501                 }
 502                 /* Only free attrs if they were dup'd.  */
 503                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
 504                 switch( rs->sr_err ) {
 505                 case DB_LOCK_DEADLOCK:
 506                 case DB_LOCK_NOTGRANTED:
 507                         goto retry;
 508                 }
 509                 goto return_results;
 510         }
 511
 512         /* change the entry itself */
 513         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
 514         if ( rs->sr_err != 0 ) {
 515                 Debug( LDAP_DEBUG_TRACE,
 516                         "bdb_modify: id2entry update failed (%d)\n",
 517                         rs->sr_err, 0, 0 );
 518                 switch( rs->sr_err ) {
 519                 case DB_LOCK_DEADLOCK:
 520                 case DB_LOCK_NOTGRANTED:
 521                         goto retry;
 522                 }
 523                 rs->sr_text = "entry update failed";
 524                 goto return_results;
 525         }
 526
 527         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
 528                 rs->sr_err = LDAP_OTHER;
 529                 rs->sr_text = "txn_commit(2) failed";
 530                 goto return_results;
 531         }
 532
 533         if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
 534                 rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
 535                         &ctxcsn_e, &ctxcsn_added, locker );
 536                 switch ( rc ) {
 537                 case BDB_CSN_ABORT :
 538                         goto return_results;
 539                 case BDB_CSN_RETRY :
 540                         goto retry;
 541                 }
 542         }
 543
 544         if( op->o_postread ) {
 545                 if( postread_ctrl == NULL ) {
 546                         postread_ctrl = &ctrls[num_ctrls++];
 547                         ctrls[num_ctrls] = NULL;
 548                 }
 549                 if( slap_read_controls( op, rs, &dummy,
 550                         &slap_post_read_bv, postread_ctrl ) )
 551                 {
 552                         Debug( LDAP_DEBUG_TRACE,
 553                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
 554                         goto return_results;
 555                 }
 556         }
 557
 558         if( op->o_noop ) {
 559                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
 560                         rs->sr_text = "txn_abort (no-op) failed";
 561                 } else {
 562                         rs->sr_err = LDAP_NO_OPERATION;
 563                         goto return_results;
 564                 }
 565         } else {
 566                 rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
 567                 switch( rc ) {
 568                 case DB_LOCK_DEADLOCK:
 569                 case DB_LOCK_NOTGRANTED:
 570                         goto retry;
 571                 }
 572                 dummy.e_attrs = NULL;
 573
 574                 if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
 575                         if ( ctxcsn_added ) {
 576                                 bdb_cache_add( bdb, suffix_ei, ctxcsn_e,
 577                                         (struct berval *)&slap_ldapsync_cn_bv, locker );
 578                         }
 579                 }
 580
 581                 if ( rs->sr_err == LDAP_SUCCESS ) {
 582                         /* Loop through in-scope entries for each psearch spec */
 583                         ldap_pvt_thread_rdwr_wlock( &bdb->bi_pslist_rwlock );
 584                         LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
 585                                 rc = bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
 586                                 if ( rc ) {
 587                                         Debug( LDAP_DEBUG_TRACE,
 588                                                 "bdb_modify: persistent search failed (%d,%d)\n",
 589                                                 rc, rs->sr_err, 0 );
 590                                 }
 591                         }
 592                         pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
 593                         while ( pm_list != NULL ) {
 594                                 rc = bdb_psearch(op, rs, pm_list->ps_op,
 595                                                         e, LDAP_PSEARCH_BY_SCOPEOUT);
 596                                 if ( rc ) {
 597                                         Debug( LDAP_DEBUG_TRACE,
 598                                                 "bdb_modify: persistent search failed (%d,%d)\n",
 599                                                 rc, rs->sr_err, 0 );
 600                                 }
 601                                 LDAP_LIST_REMOVE ( pm_list, ps_link );
 602                                 pm_prev = pm_list;
 603                                 pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
 604                                 ch_free( pm_prev );
 605                         }
 606                         ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
 607                 }
 608
 609                 rs->sr_err = TXN_COMMIT( ltid, 0 );
 610         }
 611         ltid = NULL;
 612         op->o_private = NULL;
 613
 614         if( rs->sr_err != 0 ) {
 615                 Debug( LDAP_DEBUG_TRACE,
 616                         "bdb_modify: txn_%s failed: %s (%d)\n",
 617                         op->o_noop ? "abort (no-op)" : "commit",
 618                         db_strerror(rs->sr_err), rs->sr_err );
 619                 rs->sr_err = LDAP_OTHER;
 620                 rs->sr_text = "commit failed";
 621
 622                 goto return_results;
 623         }
 624
 625         Debug( LDAP_DEBUG_TRACE,
 626                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
 627                 op->o_noop ? " (no-op)" : "",
 628                 dummy.e_id, op->o_req_dn.bv_val );
 629
 630         rs->sr_err = LDAP_SUCCESS;
 631         rs->sr_text = NULL;
 632         if( num_ctrls ) rs->sr_ctrls = ctrls;
 633
 634 return_results:
 635         if( dummy.e_attrs ) {
 636                 attrs_free( dummy.e_attrs );
 637         }
 638         send_ldap_result( op, rs );
 639
 640         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
 641                 ldap_pvt_thread_yield();
 642                 TXN_CHECKPOINT( bdb->bi_dbenv,
 643                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
 644         }
 645
 646 done:
 647         if( ltid != NULL ) {
 648                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
 649                 while ( pm_list != NULL ) {
 650                         LDAP_LIST_REMOVE ( pm_list, ps_link );
 651                         pm_prev = pm_list;
 652                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
 653                         ch_free( pm_prev );
 654                 }
 655                 TXN_ABORT( ltid );
 656                 op->o_private = NULL;
 657         }
 658
 659         if( e != NULL ) {
 660                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
 661         }
 662
 663         if( preread_ctrl != NULL ) {
 664                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
 665                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
 666         }
 667         if( postread_ctrl != NULL ) {
 668                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
 669                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
 670         }
 671         return rs->sr_err;
 672 }