]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
fix for concurrent persistent searches
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2003 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-bdb.h"
24 #include "external.h"
25
26 int bdb_modify_internal(
27         Operation *op,
28         DB_TXN *tid,
29         Modifications *modlist,
30         Entry *e,
31         const char **text,
32         char *textbuf,
33         size_t textlen )
34 {
35         int rc, err;
36         Modification    *mod;
37         Modifications   *ml;
38         Attribute       *save_attrs;
39         Attribute       *ap;
40
41 #ifdef NEW_LOGGING
42         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify_internal: 0x%08lx: %s\n", 
43                 e->e_id, e->e_dn, 0 );
44 #else
45         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
46                 e->e_id, e->e_dn, 0);
47 #endif
48
49         if ( !acl_check_modlist( op, e, modlist )) {
50                 return LDAP_INSUFFICIENT_ACCESS;
51         }
52
53         /* save_attrs will be disposed of by bdb_cache_modify */
54         save_attrs = e->e_attrs;
55         e->e_attrs = attrs_dup( e->e_attrs );
56
57         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
58                 mod = &ml->sml_mod;
59
60                 switch ( mod->sm_op ) {
61                 case LDAP_MOD_ADD:
62 #ifdef NEW_LOGGING
63                         LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify_internal: add\n", 0,0,0);
64 #else
65                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
66 #endif
67                         err = modify_add_values( e, mod, get_permissiveModify(op),
68                                 text, textbuf, textlen );
69                         if( err != LDAP_SUCCESS ) {
70 #ifdef NEW_LOGGING
71                                 LDAP_LOG ( OPERATION, ERR, 
72                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
73 #else
74                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
75                                         err, *text, 0);
76 #endif
77                         }
78                         break;
79
80                 case LDAP_MOD_DELETE:
81 #ifdef NEW_LOGGING
82                         LDAP_LOG ( OPERATION, DETAIL1, 
83                                 "bdb_modify_internal: delete\n", 0, 0, 0 );
84 #else
85                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
86 #endif
87                         err = modify_delete_values( e, mod, get_permissiveModify(op),
88                                 text, textbuf, textlen );
89                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
90                         if( err != LDAP_SUCCESS ) {
91 #ifdef NEW_LOGGING
92                                 LDAP_LOG ( OPERATION, ERR, 
93                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
94 #else
95                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
96                                         err, *text, 0);
97 #endif
98                         }
99                         break;
100
101                 case LDAP_MOD_REPLACE:
102 #ifdef NEW_LOGGING
103                         LDAP_LOG ( OPERATION, DETAIL1, 
104                                 "bdb_modify_internal: replace\n", 0, 0, 0 );
105 #else
106                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
107 #endif
108                         err = modify_replace_values( e, mod, get_permissiveModify(op),
109                                 text, textbuf, textlen );
110                         if( err != LDAP_SUCCESS ) {
111 #ifdef NEW_LOGGING
112                                 LDAP_LOG ( OPERATION, ERR, 
113                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
114 #else
115                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
116                                         err, *text, 0);
117 #endif
118                         }
119                         break;
120
121                 case LDAP_MOD_INCREMENT:
122 #ifdef NEW_LOGGING
123                         LDAP_LOG ( OPERATION, DETAIL1, 
124                                 "bdb_modify_internal: increment\n", 0, 0, 0 );
125 #else
126                         Debug(LDAP_DEBUG_ARGS,
127                                 "bdb_modify_internal: increment\n", 0, 0, 0);
128 #endif
129                         err = modify_increment_values( e, mod, get_permissiveModify(op),
130                                 text, textbuf, textlen );
131                         if( err != LDAP_SUCCESS ) {
132 #ifdef NEW_LOGGING
133                                 LDAP_LOG ( OPERATION, ERR, 
134                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
135 #else
136                                 Debug(LDAP_DEBUG_ARGS,
137                                         "bdb_modify_internal: %d %s\n",
138                                         err, *text, 0);
139 #endif
140                         }
141                         break;
142
143                 case SLAP_MOD_SOFTADD:
144 #ifdef NEW_LOGGING
145                         LDAP_LOG ( OPERATION, DETAIL1, 
146                                 "bdb_modify_internal: softadd\n",0,0,0 );
147 #else
148                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
149 #endif
150                         /* Avoid problems in index_add_mods()
151                          * We need to add index if necessary.
152                          */
153                         mod->sm_op = LDAP_MOD_ADD;
154
155                         err = modify_add_values( e, mod, get_permissiveModify(op),
156                                 text, textbuf, textlen );
157
158                         mod->sm_op = SLAP_MOD_SOFTADD;
159
160                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
161                                 err = LDAP_SUCCESS;
162                         }
163
164                         if( err != LDAP_SUCCESS ) {
165 #ifdef NEW_LOGGING
166                                 LDAP_LOG ( OPERATION, ERR, 
167                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
168 #else
169                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
170                                         err, *text, 0);
171 #endif
172                         }
173                         break;
174
175                 default:
176 #ifdef NEW_LOGGING
177                                 LDAP_LOG ( OPERATION, ERR, 
178                                         "bdb_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
179 #else
180                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
181                                 mod->sm_op, 0, 0);
182 #endif
183                         *text = "Invalid modify operation";
184                         err = LDAP_OTHER;
185 #ifdef NEW_LOGGING
186                                 LDAP_LOG ( OPERATION, ERR, 
187                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
188 #else
189                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
190                                 err, *text, 0);
191 #endif
192                 }
193
194                 if ( err != LDAP_SUCCESS ) {
195                         attrs_free( e->e_attrs );
196                         e->e_attrs = save_attrs;
197                         /* unlock entry, delete from cache */
198                         return err; 
199                 }
200
201                 /* If objectClass was modified, reset the flags */
202                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
203                         e->e_ocflags = 0;
204                 }
205
206                 /* check if modified attribute was indexed
207                  * but not in case of NOOP... */
208                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
209                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
210                         ap = attr_find( save_attrs, mod->sm_desc );
211                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
212
213                         ap = attr_find( e->e_attrs, mod->sm_desc );
214                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
215                 }
216         }
217
218         /* check that the entry still obeys the schema */
219         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
220         if ( rc != LDAP_SUCCESS || op->o_noop ) {
221                 attrs_free( e->e_attrs );
222                 e->e_attrs = save_attrs;
223
224                 if ( rc != LDAP_SUCCESS ) {
225 #ifdef NEW_LOGGING
226                         LDAP_LOG ( OPERATION, ERR, "bdb_modify_internal: "
227                                 "entry failed schema check %s\n", 
228                                 *text, 0, 0 );
229 #else
230                         Debug( LDAP_DEBUG_ANY,
231                                 "entry failed schema check: %s\n",
232                                 *text, 0, 0 );
233 #endif
234                 }
235
236                 /* if NOOP then silently revert to saved attrs */
237                 return rc;
238         }
239
240         /* update the indices of the modified attributes */
241
242         /* start with deleting the old index entries */
243         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
244                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
245                         rc = bdb_index_values( op, tid, ap->a_desc,
246                                 ap->a_nvals,
247                                 e->e_id, SLAP_INDEX_DELETE_OP );
248                         if ( rc != LDAP_SUCCESS ) {
249                                 attrs_free( e->e_attrs );
250                                 e->e_attrs = save_attrs;
251 #ifdef NEW_LOGGING
252                                 LDAP_LOG ( OPERATION, ERR, 
253                                         "bdb_modify_internal: attribute index delete failure\n",
254                                         0, 0, 0 );
255 #else
256                                 Debug( LDAP_DEBUG_ANY,
257                                        "Attribute index delete failure",
258                                        0, 0, 0 );
259 #endif
260                                 return rc;
261                         }
262                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
263                 }
264         }
265
266         /* add the new index entries */
267         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
268                 if (ap->a_flags & SLAP_ATTR_IXADD) {
269                         rc = bdb_index_values( op, tid, ap->a_desc,
270                                 ap->a_nvals,
271                                 e->e_id, SLAP_INDEX_ADD_OP );
272                         if ( rc != LDAP_SUCCESS ) {
273                                 attrs_free( e->e_attrs );
274                                 e->e_attrs = save_attrs;
275 #ifdef NEW_LOGGING
276                                 LDAP_LOG ( OPERATION, ERR, 
277                                         "bdb_modify_internal: attribute index add failure\n", 
278                                         0, 0, 0 );
279 #else
280                                 Debug( LDAP_DEBUG_ANY,
281                                        "Attribute index add failure",
282                                        0, 0, 0 );
283 #endif
284                                 return rc;
285                         }
286                         ap->a_flags &= ~SLAP_ATTR_IXADD;
287                 }
288         }
289
290         return rc;
291 }
292
293
294 int
295 bdb_modify( Operation *op, SlapReply *rs )
296 {
297         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
298         Entry           *e = NULL;
299         EntryInfo       *ei = NULL;
300         int             manageDSAit = get_manageDSAit( op );
301         char textbuf[SLAP_TEXT_BUFLEN];
302         size_t textlen = sizeof textbuf;
303         DB_TXN  *ltid = NULL, *lt2;
304         struct bdb_op_info opinfo;
305         Entry           dummy;
306
307         u_int32_t       locker = 0;
308         DB_LOCK         lock;
309
310         int             noop = 0;
311
312         int             num_retries = 0;
313
314         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
315         int num_ctrls = 0;
316
317         Operation* ps_list;
318         struct psid_entry *pm_list, *pm_prev;
319         int rc;
320         EntryInfo       *suffix_ei;
321         Entry           *ctxcsn_e;
322         int                     ctxcsn_added = 0;
323
324 #ifdef NEW_LOGGING
325         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
326 #else
327         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
328 #endif
329
330         if( 0 ) {
331 retry:  /* transaction retry */
332                 if( e != NULL ) {
333                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
334                         e = NULL;
335                 }
336 #ifdef NEW_LOGGING
337                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: retrying...\n", 0, 0, 0 );
338 #else
339                 Debug(LDAP_DEBUG_TRACE,
340                         "bdb_modify: retrying...\n", 0, 0, 0);
341 #endif
342
343                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
344                 while ( pm_list != NULL ) {
345                         LDAP_LIST_REMOVE ( pm_list, ps_link );
346                         pm_prev = pm_list;
347                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
348                         ch_free( pm_prev );
349                 }
350
351                 rs->sr_err = TXN_ABORT( ltid );
352                 ltid = NULL;
353                 op->o_private = NULL;
354                 op->o_do_not_cache = opinfo.boi_acl_cache;
355                 if( rs->sr_err != 0 ) {
356                         rs->sr_err = LDAP_OTHER;
357                         rs->sr_text = "internal error";
358                         goto return_results;
359                 }
360                 ldap_pvt_thread_yield();
361                 bdb_trans_backoff( ++num_retries );
362         }
363
364         /* begin transaction */
365         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
366                 bdb->bi_db_opflags );
367         rs->sr_text = NULL;
368         if( rs->sr_err != 0 ) {
369 #ifdef NEW_LOGGING
370                 LDAP_LOG ( OPERATION, DETAIL1, 
371                         "bdb_modify: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
372 #else
373                 Debug( LDAP_DEBUG_TRACE,
374                         "bdb_modify: txn_begin failed: %s (%d)\n",
375                         db_strerror(rs->sr_err), rs->sr_err, 0 );
376 #endif
377                 rs->sr_err = LDAP_OTHER;
378                 rs->sr_text = "internal error";
379                 goto return_results;
380         }
381
382         locker = TXN_ID ( ltid );
383
384         opinfo.boi_bdb = op->o_bd;
385         opinfo.boi_txn = ltid;
386         opinfo.boi_locker = locker;
387         opinfo.boi_err = 0;
388         opinfo.boi_acl_cache = op->o_do_not_cache;
389         op->o_private = &opinfo;
390
391         /* get entry or ancestor */
392         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
393                 locker, &lock );
394
395         if ( rs->sr_err != 0 ) {
396 #ifdef NEW_LOGGING
397                 LDAP_LOG ( OPERATION, DETAIL1, 
398                         "bdb_modify: dn2entry failed: (%d)\n", rs->sr_err, 0, 0 );
399 #else
400                 Debug( LDAP_DEBUG_TRACE,
401                         "bdb_modify: dn2entry failed (%d)\n",
402                         rs->sr_err, 0, 0 );
403 #endif
404                 switch( rs->sr_err ) {
405                 case DB_LOCK_DEADLOCK:
406                 case DB_LOCK_NOTGRANTED:
407                         goto retry;
408                 case DB_NOTFOUND:
409                         break;
410                 case LDAP_BUSY:
411                         rs->sr_text = "ldap server busy";
412                         goto return_results;
413                 default:
414                         rs->sr_err = LDAP_OTHER;
415                         rs->sr_text = "internal error";
416                         goto return_results;
417                 }
418         }
419
420         e = ei->bei_e;
421         /* acquire and lock entry */
422         /* FIXME: dn2entry() should return non-glue entry */
423         if (( rs->sr_err == DB_NOTFOUND ) || ( !manageDSAit && e && is_entry_glue( e ))) {
424                 if ( e != NULL ) {
425                         rs->sr_matched = ch_strdup( e->e_dn );
426                         rs->sr_ref = is_entry_referral( e )
427                                 ? get_entry_referrals( op, e )
428                                 : NULL;
429                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
430                         e = NULL;
431
432                 } else {
433                         BerVarray deref = NULL;
434                         if ( !LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
435                                 syncinfo_t *si;
436                                 LDAP_STAILQ_FOREACH( si, &op->o_bd->be_syncinfo, si_next ) {
437                                         struct berval tmpbv;
438                                         ber_dupbv( &tmpbv, &si->si_provideruri_bv[0] );
439                                         ber_bvarray_add( &deref, &tmpbv );
440                 }
441                         } else {
442                                 deref = default_referral;
443                         }
444                         rs->sr_ref = referral_rewrite( deref, NULL, &op->o_req_dn,
445                                 LDAP_SCOPE_DEFAULT );
446                 }
447
448                 rs->sr_err = LDAP_REFERRAL;
449                 send_ldap_result( op, rs );
450
451                 if ( rs->sr_ref != default_referral ) {
452                         ber_bvarray_free( rs->sr_ref );
453                 }
454                 free( (char *)rs->sr_matched );
455                 rs->sr_ref = NULL;
456                 rs->sr_matched = NULL;
457
458                 goto done;
459         }
460
461         if ( !manageDSAit && is_entry_referral( e ) ) {
462                 /* entry is a referral, don't allow modify */
463                 rs->sr_ref = get_entry_referrals( op, e );
464
465 #ifdef NEW_LOGGING
466                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: entry is referral\n", 0, 0, 0 );
467 #else
468                 Debug( LDAP_DEBUG_TRACE,
469                         "bdb_modify: entry is referral\n",
470                         0, 0, 0 );
471 #endif
472
473                 rs->sr_err = LDAP_REFERRAL;
474                 rs->sr_matched = e->e_name.bv_val;
475                 send_ldap_result( op, rs );
476
477                 ber_bvarray_free( rs->sr_ref );
478                 rs->sr_ref = NULL;
479                 rs->sr_matched = NULL;
480                 goto done;
481         }
482
483         if ( get_assert( op ) &&
484                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
485         {
486                 rs->sr_err = LDAP_ASSERTION_FAILED;
487                 goto return_results;
488         }
489
490         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop && !op->o_no_psearch ) {
491                 ldap_pvt_thread_rdwr_rlock( &bdb->bi_pslist_rwlock );
492                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
493                         bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
494                 }
495                 ldap_pvt_thread_rdwr_runlock( &bdb->bi_pslist_rwlock );
496         }
497
498         if( op->o_preread ) {
499                 if ( slap_read_controls( op, rs, e,
500                         &slap_pre_read_bv, &ctrls[num_ctrls] ) )
501                 {
502 #ifdef NEW_LOGGING
503                         LDAP_LOG ( OPERATION, DETAIL1,
504                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
505 #else
506                         Debug( LDAP_DEBUG_TRACE,
507                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
508 #endif
509                         goto return_results;
510                 }
511                 ctrls[++num_ctrls] = NULL;
512                 op->o_preread = 0; /* prevent redo on retry */
513         }
514
515         /* nested transaction */
516         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
517                 bdb->bi_db_opflags );
518         rs->sr_text = NULL;
519         if( rs->sr_err != 0 ) {
520 #ifdef NEW_LOGGING
521                 LDAP_LOG ( OPERATION, ERR, 
522                         "bdb_modify: txn_begin(2) failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
523 #else
524                 Debug( LDAP_DEBUG_TRACE,
525                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
526                         db_strerror(rs->sr_err), rs->sr_err, 0 );
527 #endif
528                 rs->sr_err = LDAP_OTHER;
529                 rs->sr_text = "internal error";
530                 goto return_results;
531         }
532         /* Modify the entry */
533         dummy = *e;
534         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
535                 &dummy, &rs->sr_text, textbuf, textlen );
536
537         if( rs->sr_err != LDAP_SUCCESS ) {
538 #ifdef NEW_LOGGING
539                 LDAP_LOG ( OPERATION, ERR, 
540                         "bdb_modify: modify failed (%d)\n", rs->sr_err, 0, 0 );
541 #else
542                 Debug( LDAP_DEBUG_TRACE,
543                         "bdb_modify: modify failed (%d)\n",
544                         rs->sr_err, 0, 0 );
545 #endif
546                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
547                         rs->sr_err = opinfo.boi_err;
548                 }
549                 switch( rs->sr_err ) {
550                 case DB_LOCK_DEADLOCK:
551                 case DB_LOCK_NOTGRANTED:
552                         goto retry;
553                 }
554                 goto return_results;
555         }
556
557         if( op->o_postread ) {
558                 if( slap_read_controls( op, rs, e,
559                         &slap_post_read_bv, &ctrls[num_ctrls] ) )
560                 {
561 #ifdef NEW_LOGGING
562                         LDAP_LOG ( OPERATION, DETAIL1,
563                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
564 #else
565                         Debug( LDAP_DEBUG_TRACE,
566                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
567 #endif
568                         goto return_results;
569                 }
570                 ctrls[++num_ctrls] = NULL;
571                 op->o_postread = 0;  /* prevent redo on retry */
572                 /* FIXME: should read entry on the last retry */
573         }
574
575         /* change the entry itself */
576         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
577         if ( rs->sr_err != 0 ) {
578 #ifdef NEW_LOGGING
579                 LDAP_LOG ( OPERATION, ERR, 
580                         "bdb_modify: id2entry update failed (%d)\n", rs->sr_err, 0, 0 );
581 #else
582                 Debug( LDAP_DEBUG_TRACE,
583                         "bdb_modify: id2entry update failed (%d)\n",
584                         rs->sr_err, 0, 0 );
585 #endif
586                 switch( rs->sr_err ) {
587                 case DB_LOCK_DEADLOCK:
588                 case DB_LOCK_NOTGRANTED:
589                         goto retry;
590                 }
591                 rs->sr_text = "entry update failed";
592                 goto return_results;
593         }
594
595         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
596                 rs->sr_err = LDAP_OTHER;
597                 rs->sr_text = "txn_commit(2) failed";
598                 goto return_results;
599         }
600
601         if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
602                 rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
603                         &ctxcsn_e, &ctxcsn_added, locker );
604                 switch ( rc ) {
605                 case BDB_CSN_ABORT :
606                         goto return_results;
607                 case BDB_CSN_RETRY :
608                         goto retry;
609                 }
610         }
611
612         if( op->o_noop ) {
613                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
614                         rs->sr_text = "txn_abort (no-op) failed";
615                 } else {
616                         noop = 1;
617                         rs->sr_err = LDAP_SUCCESS;
618                 }
619         } else {
620                 EntryInfo *ctx_ei;
621
622                 bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
623
624                 if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
625                         if ( ctxcsn_added ) {
626                                 bdb_cache_add( bdb, suffix_ei, ctxcsn_e,
627                                         (struct berval *)&slap_ldapsync_cn_bv, locker );
628                         }
629                 }
630
631                 if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
632                         /* Loop through in-scope entries for each psearch spec */
633                         ldap_pvt_thread_rdwr_rlock( &bdb->bi_pslist_rwlock );
634                         LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
635                                 bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
636                         }
637                         ldap_pvt_thread_rdwr_runlock( &bdb->bi_pslist_rwlock );
638                         pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
639                         while ( pm_list != NULL ) {
640                                 bdb_psearch(op, rs, pm_list->ps_op,
641                                                         e, LDAP_PSEARCH_BY_SCOPEOUT);
642                                 LDAP_LIST_REMOVE ( pm_list, ps_link );
643                                 pm_prev = pm_list;
644                                 pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
645                                 ch_free( pm_prev );
646                         }
647                 }
648
649                 rs->sr_err = TXN_COMMIT( ltid, 0 );
650         }
651         ltid = NULL;
652         op->o_private = NULL;
653
654         if( rs->sr_err != 0 ) {
655 #ifdef NEW_LOGGING
656                 LDAP_LOG ( OPERATION, ERR, 
657                         "bdb_modify: txn_%s failed %s (%d)\n", 
658                         op->o_noop ? "abort (no_op)" : "commit",
659                         db_strerror(rs->sr_err), rs->sr_err );
660 #else
661                 Debug( LDAP_DEBUG_TRACE,
662                         "bdb_modify: txn_%s failed: %s (%d)\n",
663                         op->o_noop ? "abort (no-op)" : "commit",
664                         db_strerror(rs->sr_err), rs->sr_err );
665 #endif
666                 rs->sr_err = LDAP_OTHER;
667                 rs->sr_text = "commit failed";
668
669                 goto return_results;
670         }
671
672 #ifdef NEW_LOGGING
673         LDAP_LOG ( OPERATION, DETAIL1, 
674                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n", 
675                 op->o_noop ? " (no_op)" : "", e->e_id, e->e_dn );
676 #else
677         Debug( LDAP_DEBUG_TRACE,
678                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
679                 op->o_noop ? " (no-op)" : "",
680                 e->e_id, e->e_dn );
681 #endif
682
683         rs->sr_err = LDAP_SUCCESS;
684         rs->sr_text = NULL;
685         if( num_ctrls ) rs->sr_ctrls = ctrls;
686
687 return_results:
688         send_ldap_result( op, rs );
689
690         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
691                 ldap_pvt_thread_yield();
692                 TXN_CHECKPOINT( bdb->bi_dbenv,
693                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
694         }
695
696 done:
697         if( ltid != NULL ) {
698                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
699                 while ( pm_list != NULL ) {
700                         LDAP_LIST_REMOVE ( pm_list, ps_link );
701                         pm_prev = pm_list;
702                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
703                         ch_free( pm_prev );
704                 }
705                 TXN_ABORT( ltid );
706                 op->o_private = NULL;
707         }
708
709         if( e != NULL ) {
710                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
711         }
712         return ( ( rs->sr_err == LDAP_SUCCESS ) ? noop : rs->sr_err );
713 }