git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c

   1 /* modify.c - bdb backend modify routine */
   2 /* $OpenLDAP$ */
   3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
   4  *
   5  * Copyright 2000-2004 The OpenLDAP Foundation.
   6  * All rights reserved.
   7  *
   8  * Redistribution and use in source and binary forms, with or without
   9  * modification, are permitted only as authorized by the OpenLDAP
  10  * Public License.
  11  *
  12  * A copy of this license is available in the file LICENSE in the
  13  * top-level directory of the distribution or, alternatively, at
  14  * <http://www.OpenLDAP.org/license.html>.
  15  */
  16
  17 #include "portable.h"
  18
  19 #include <stdio.h>
  20 #include <ac/string.h>
  21 #include <ac/time.h>
  22
  23 #include "back-bdb.h"
  24 #include "external.h"
  25
  26 static struct berval scbva[] = {
  27         BER_BVC("glue"),
  28         BER_BVNULL
  29 };
  30
  31 int bdb_modify_internal(
  32         Operation *op,
  33         DB_TXN *tid,
  34         Modifications *modlist,
  35         Entry *e,
  36         const char **text,
  37         char *textbuf,
  38         size_t textlen )
  39 {
  40         int rc, err;
  41         Modification    *mod;
  42         Modifications   *ml;
  43         Attribute       *save_attrs;
  44         Attribute       *ap;
  45         int                     glue_attr_delete = 0;
  46
  47         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
  48                 e->e_id, e->e_dn, 0);
  49
  50         if ( !acl_check_modlist( op, e, modlist )) {
  51                 return LDAP_INSUFFICIENT_ACCESS;
  52         }
  53
  54         /* save_attrs will be disposed of by bdb_cache_modify */
  55         save_attrs = e->e_attrs;
  56         e->e_attrs = attrs_dup( e->e_attrs );
  57
  58         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  59                 int match;
  60                 mod = &ml->sml_mod;
  61                 switch( mod->sm_op ) {
  62                 case LDAP_MOD_ADD:
  63                 case LDAP_MOD_REPLACE:
  64                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
  65                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
  66                                 slap_schema.si_ad_structuralObjectClass->ad_type->sat_equality,
  67                                 SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
  68                                 &mod->sm_values[0], &scbva[0], text );
  69                                 if ( !match )
  70                                         glue_attr_delete = 1;
  71                         }
  72                 }
  73                 if ( glue_attr_delete )
  74                         break;
  75         }
  76
  77         if ( glue_attr_delete ) {
  78                 Attribute       **app = &e->e_attrs;
  79                 while ( *app != NULL ) {
  80                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
  81                                 Attribute *save = *app;
  82                                 *app = (*app)->a_next;
  83                                 attr_free( save );
  84                                 continue;
  85                         }
  86                         app = &(*app)->a_next;
  87                 }
  88         }
  89
  90         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
  91                 mod = &ml->sml_mod;
  92
  93                 switch ( mod->sm_op ) {
  94                 case LDAP_MOD_ADD:
  95                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
  96                         err = modify_add_values( e, mod, get_permissiveModify(op),
  97                                 text, textbuf, textlen );
  98                         if( err != LDAP_SUCCESS ) {
  99                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 100                                         err, *text, 0);
 101                         }
 102                         break;
 103
 104                 case LDAP_MOD_DELETE:
 105                         if ( glue_attr_delete ) {
 106                                 err = LDAP_SUCCESS;
 107                                 break;
 108                         }
 109
 110                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
 111                         err = modify_delete_values( e, mod, get_permissiveModify(op),
 112                                 text, textbuf, textlen );
 113                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
 114                         if( err != LDAP_SUCCESS ) {
 115                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 116                                         err, *text, 0);
 117                         }
 118                         break;
 119
 120                 case LDAP_MOD_REPLACE:
 121                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
 122                         err = modify_replace_values( e, mod, get_permissiveModify(op),
 123                                 text, textbuf, textlen );
 124                         if( err != LDAP_SUCCESS ) {
 125                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 126                                         err, *text, 0);
 127                         }
 128                         break;
 129
 130                 case LDAP_MOD_INCREMENT:
 131                         Debug(LDAP_DEBUG_ARGS,
 132                                 "bdb_modify_internal: increment\n", 0, 0, 0);
 133                         err = modify_increment_values( e, mod, get_permissiveModify(op),
 134                                 text, textbuf, textlen );
 135                         if( err != LDAP_SUCCESS ) {
 136                                 Debug(LDAP_DEBUG_ARGS,
 137                                         "bdb_modify_internal: %d %s\n",
 138                                         err, *text, 0);
 139                         }
 140                         break;
 141
 142                 case SLAP_MOD_SOFTADD:
 143                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
 144                         /* Avoid problems in index_add_mods()
 145                          * We need to add index if necessary.
 146                          */
 147                         mod->sm_op = LDAP_MOD_ADD;
 148
 149                         err = modify_add_values( e, mod, get_permissiveModify(op),
 150                                 text, textbuf, textlen );
 151
 152                         mod->sm_op = SLAP_MOD_SOFTADD;
 153
 154                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
 155                                 err = LDAP_SUCCESS;
 156                         }
 157
 158                         if( err != LDAP_SUCCESS ) {
 159                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 160                                         err, *text, 0);
 161                         }
 162                         break;
 163
 164                 default:
 165                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
 166                                 mod->sm_op, 0, 0);
 167                         *text = "Invalid modify operation";
 168                         err = LDAP_OTHER;
 169                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
 170                                 err, *text, 0);
 171                 }
 172
 173                 if ( err != LDAP_SUCCESS ) {
 174                         attrs_free( e->e_attrs );
 175                         e->e_attrs = save_attrs;
 176                         /* unlock entry, delete from cache */
 177                         return err;
 178                 }
 179
 180                 /* If objectClass was modified, reset the flags */
 181                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
 182                         e->e_ocflags = 0;
 183                 }
 184
 185                 if ( glue_attr_delete ) {
 186                         e->e_ocflags = 0;
 187                 }
 188
 189                 /* check if modified attribute was indexed
 190                  * but not in case of NOOP... */
 191                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
 192                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
 193                         ap = attr_find( save_attrs, mod->sm_desc );
 194                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
 195
 196                         ap = attr_find( e->e_attrs, mod->sm_desc );
 197                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
 198                 }
 199         }
 200
 201         /* check that the entry still obeys the schema */
 202         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
 203         if ( rc != LDAP_SUCCESS || op->o_noop ) {
 204                 attrs_free( e->e_attrs );
 205                 /* clear the indexing flags */
 206                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 207                         ap->a_flags = 0;
 208                 }
 209                 e->e_attrs = save_attrs;
 210
 211                 if ( rc != LDAP_SUCCESS ) {
 212                         Debug( LDAP_DEBUG_ANY,
 213                                 "entry failed schema check: %s\n",
 214                                 *text, 0, 0 );
 215                 }
 216
 217                 /* if NOOP then silently revert to saved attrs */
 218                 return rc;
 219         }
 220
 221         /* update the indices of the modified attributes */
 222
 223         /* start with deleting the old index entries */
 224         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
 225                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
 226                         rc = bdb_index_values( op, tid, ap->a_desc,
 227                                 ap->a_nvals,
 228                                 e->e_id, SLAP_INDEX_DELETE_OP );
 229                         if ( rc != LDAP_SUCCESS ) {
 230                                 attrs_free( e->e_attrs );
 231                                 e->e_attrs = save_attrs;
 232                                 Debug( LDAP_DEBUG_ANY,
 233                                        "Attribute index delete failure",
 234                                        0, 0, 0 );
 235                                 return rc;
 236                         }
 237                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
 238                 }
 239         }
 240
 241         /* add the new index entries */
 242         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
 243                 if (ap->a_flags & SLAP_ATTR_IXADD) {
 244                         rc = bdb_index_values( op, tid, ap->a_desc,
 245                                 ap->a_nvals,
 246                                 e->e_id, SLAP_INDEX_ADD_OP );
 247                         if ( rc != LDAP_SUCCESS ) {
 248                                 attrs_free( e->e_attrs );
 249                                 e->e_attrs = save_attrs;
 250                                 Debug( LDAP_DEBUG_ANY,
 251                                        "Attribute index add failure",
 252                                        0, 0, 0 );
 253                                 return rc;
 254                         }
 255                         ap->a_flags &= ~SLAP_ATTR_IXADD;
 256                 }
 257         }
 258
 259         return rc;
 260 }
 261
 262
 263 int
 264 bdb_modify( Operation *op, SlapReply *rs )
 265 {
 266         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
 267         Entry           *e = NULL;
 268         EntryInfo       *ei = NULL;
 269         int             manageDSAit = get_manageDSAit( op );
 270         char textbuf[SLAP_TEXT_BUFLEN];
 271         size_t textlen = sizeof textbuf;
 272         DB_TXN  *ltid = NULL, *lt2;
 273         struct bdb_op_info opinfo;
 274         Entry           dummy = {0};
 275
 276         u_int32_t       locker = 0;
 277         DB_LOCK         lock;
 278
 279         int             num_retries = 0;
 280
 281         LDAPControl **preread_ctrl = NULL;
 282         LDAPControl **postread_ctrl = NULL;
 283         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
 284         int num_ctrls = 0;
 285
 286         Operation* ps_list;
 287         struct psid_entry *pm_list, *pm_prev;
 288         int rc;
 289         EntryInfo       *suffix_ei;
 290         Entry           *ctxcsn_e;
 291         int                     ctxcsn_added = 0;
 292
 293         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n",
 294                 op->o_req_dn.bv_val, 0, 0 );
 295
 296         ctrls[num_ctrls] = NULL;
 297
 298         if( 0 ) {
 299 retry:  /* transaction retry */
 300                 if ( dummy.e_attrs ) {
 301                         attrs_free( dummy.e_attrs );
 302                         dummy.e_attrs = NULL;
 303                 }
 304                 if( e != NULL ) {
 305                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
 306                         e = NULL;
 307                 }
 308                 Debug(LDAP_DEBUG_TRACE,
 309                         "bdb_modify: retrying...\n", 0, 0, 0);
 310
 311                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
 312                 while ( pm_list != NULL ) {
 313                         LDAP_LIST_REMOVE ( pm_list, ps_link );
 314                         pm_prev = pm_list;
 315                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
 316                         ch_free( pm_prev );
 317                 }
 318
 319                 rs->sr_err = TXN_ABORT( ltid );
 320                 ltid = NULL;
 321                 op->o_private = NULL;
 322                 op->o_do_not_cache = opinfo.boi_acl_cache;
 323                 if( rs->sr_err != 0 ) {
 324                         rs->sr_err = LDAP_OTHER;
 325                         rs->sr_text = "internal error";
 326                         goto return_results;
 327                 }
 328                 ldap_pvt_thread_yield();
 329                 bdb_trans_backoff( ++num_retries );
 330         }
 331
 332         /* begin transaction */
 333         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid,
 334                 bdb->bi_db_opflags );
 335         rs->sr_text = NULL;
 336         if( rs->sr_err != 0 ) {
 337                 Debug( LDAP_DEBUG_TRACE,
 338                         "bdb_modify: txn_begin failed: %s (%d)\n",
 339                         db_strerror(rs->sr_err), rs->sr_err, 0 );
 340                 rs->sr_err = LDAP_OTHER;
 341                 rs->sr_text = "internal error";
 342                 goto return_results;
 343         }
 344
 345         locker = TXN_ID ( ltid );
 346
 347         opinfo.boi_bdb = op->o_bd;
 348         opinfo.boi_txn = ltid;
 349         opinfo.boi_locker = locker;
 350         opinfo.boi_err = 0;
 351         opinfo.boi_acl_cache = op->o_do_not_cache;
 352         op->o_private = &opinfo;
 353
 354         /* get entry or ancestor */
 355         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
 356                 locker, &lock );
 357
 358         if ( rs->sr_err != 0 ) {
 359                 Debug( LDAP_DEBUG_TRACE,
 360                         "bdb_modify: dn2entry failed (%d)\n",
 361                         rs->sr_err, 0, 0 );
 362                 switch( rs->sr_err ) {
 363                 case DB_LOCK_DEADLOCK:
 364                 case DB_LOCK_NOTGRANTED:
 365                         goto retry;
 366                 case DB_NOTFOUND:
 367                         break;
 368                 case LDAP_BUSY:
 369                         rs->sr_text = "ldap server busy";
 370                         goto return_results;
 371                 default:
 372                         rs->sr_err = LDAP_OTHER;
 373                         rs->sr_text = "internal error";
 374                         goto return_results;
 375                 }
 376         }
 377
 378         e = ei->bei_e;
 379         /* acquire and lock entry */
 380         /* FIXME: dn2entry() should return non-glue entry */
 381         if (( rs->sr_err == DB_NOTFOUND ) ||
 382                 ( !manageDSAit && e && is_entry_glue( e )))
 383         {
 384                 BerVarray deref = NULL;
 385                 if ( e != NULL ) {
 386                         rs->sr_matched = ch_strdup( e->e_dn );
 387                         rs->sr_ref = is_entry_referral( e )
 388                                 ? get_entry_referrals( op, e )
 389                                 : NULL;
 390                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
 391                         e = NULL;
 392
 393                 } else {
 394                         if ( !LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
 395                                 syncinfo_t *si;
 396                                 LDAP_STAILQ_FOREACH( si, &op->o_bd->be_syncinfo, si_next ) {
 397                                         struct berval tmpbv;
 398                                         ber_dupbv( &tmpbv, &si->si_provideruri_bv[0] );
 399                                         ber_bvarray_add( &deref, &tmpbv );
 400                 }
 401                         } else {
 402                                 deref = SLAPD_GLOBAL(default_referral);
 403                         }
 404                         rs->sr_ref = referral_rewrite( deref, NULL, &op->o_req_dn,
 405                                         LDAP_SCOPE_DEFAULT );
 406                 }
 407
 408                 rs->sr_err = LDAP_REFERRAL;
 409                 send_ldap_result( op, rs );
 410
 411                 if ( rs->sr_ref != SLAPD_GLOBAL(default_referral) ) {
 412                         ber_bvarray_free( rs->sr_ref );
 413                 }
 414                 if ( deref != SLAPD_GLOBAL(default_referral) ) {
 415                         ber_bvarray_free( deref );
 416                 }
 417                 free( (char *)rs->sr_matched );
 418                 rs->sr_ref = NULL;
 419                 rs->sr_matched = NULL;
 420
 421                 goto done;
 422         }
 423
 424         if ( !manageDSAit && is_entry_referral( e ) ) {
 425                 /* entry is a referral, don't allow modify */
 426                 rs->sr_ref = get_entry_referrals( op, e );
 427
 428                 Debug( LDAP_DEBUG_TRACE,
 429                         "bdb_modify: entry is referral\n",
 430                         0, 0, 0 );
 431
 432                 rs->sr_err = LDAP_REFERRAL;
 433                 rs->sr_matched = e->e_name.bv_val;
 434                 send_ldap_result( op, rs );
 435
 436                 ber_bvarray_free( rs->sr_ref );
 437                 rs->sr_ref = NULL;
 438                 rs->sr_matched = NULL;
 439                 goto done;
 440         }
 441
 442         if ( get_assert( op ) &&
 443                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
 444         {
 445                 rs->sr_err = LDAP_ASSERTION_FAILED;
 446                 goto return_results;
 447         }
 448
 449         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop && !op->o_no_psearch ) {
 450                 ldap_pvt_thread_rdwr_wlock( &bdb->bi_pslist_rwlock );
 451                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
 452                         rc = bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
 453                         if ( rc ) {
 454                                 Debug( LDAP_DEBUG_TRACE,
 455                                         "bdb_modify: persistent search failed (%d,%d)\n",
 456                                         rc, rs->sr_err, 0 );
 457                         }
 458                 }
 459                 ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
 460         }
 461
 462         if( op->o_preread ) {
 463                 if( preread_ctrl == NULL ) {
 464                         preread_ctrl = &ctrls[num_ctrls++];
 465                         ctrls[num_ctrls] = NULL;
 466                 }
 467                 if ( slap_read_controls( op, rs, e,
 468                         &slap_pre_read_bv, preread_ctrl ) )
 469                 {
 470                         Debug( LDAP_DEBUG_TRACE,
 471                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
 472                         goto return_results;
 473                 }
 474         }
 475
 476         /* nested transaction */
 477         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2,
 478                 bdb->bi_db_opflags );
 479         rs->sr_text = NULL;
 480         if( rs->sr_err != 0 ) {
 481                 Debug( LDAP_DEBUG_TRACE,
 482                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
 483                         db_strerror(rs->sr_err), rs->sr_err, 0 );
 484                 rs->sr_err = LDAP_OTHER;
 485                 rs->sr_text = "internal error";
 486                 goto return_results;
 487         }
 488         /* Modify the entry */
 489         dummy = *e;
 490         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
 491                 &dummy, &rs->sr_text, textbuf, textlen );
 492
 493         if( rs->sr_err != LDAP_SUCCESS ) {
 494                 Debug( LDAP_DEBUG_TRACE,
 495                         "bdb_modify: modify failed (%d)\n",
 496                         rs->sr_err, 0, 0 );
 497                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
 498                         rs->sr_err = opinfo.boi_err;
 499                 }
 500                 /* Only free attrs if they were dup'd.  */
 501                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
 502                 switch( rs->sr_err ) {
 503                 case DB_LOCK_DEADLOCK:
 504                 case DB_LOCK_NOTGRANTED:
 505                         goto retry;
 506                 }
 507                 goto return_results;
 508         }
 509
 510         /* change the entry itself */
 511         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
 512         if ( rs->sr_err != 0 ) {
 513                 Debug( LDAP_DEBUG_TRACE,
 514                         "bdb_modify: id2entry update failed (%d)\n",
 515                         rs->sr_err, 0, 0 );
 516                 switch( rs->sr_err ) {
 517                 case DB_LOCK_DEADLOCK:
 518                 case DB_LOCK_NOTGRANTED:
 519                         goto retry;
 520                 }
 521                 rs->sr_text = "entry update failed";
 522                 goto return_results;
 523         }
 524
 525         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
 526                 rs->sr_err = LDAP_OTHER;
 527                 rs->sr_text = "txn_commit(2) failed";
 528                 goto return_results;
 529         }
 530
 531         if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
 532                 rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
 533                         &ctxcsn_e, &ctxcsn_added, locker );
 534                 switch ( rc ) {
 535                 case BDB_CSN_ABORT :
 536                         goto return_results;
 537                 case BDB_CSN_RETRY :
 538                         goto retry;
 539                 }
 540         }
 541
 542         if( op->o_postread ) {
 543                 if( postread_ctrl == NULL ) {
 544                         postread_ctrl = &ctrls[num_ctrls++];
 545                         ctrls[num_ctrls] = NULL;
 546                 }
 547                 if( slap_read_controls( op, rs, &dummy,
 548                         &slap_post_read_bv, postread_ctrl ) )
 549                 {
 550                         Debug( LDAP_DEBUG_TRACE,
 551                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
 552                         goto return_results;
 553                 }
 554         }
 555
 556         if( op->o_noop ) {
 557                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
 558                         rs->sr_text = "txn_abort (no-op) failed";
 559                 } else {
 560                         rs->sr_err = LDAP_NO_OPERATION;
 561                         goto return_results;
 562                 }
 563         } else {
 564                 rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
 565                 switch( rc ) {
 566                 case DB_LOCK_DEADLOCK:
 567                 case DB_LOCK_NOTGRANTED:
 568                         goto retry;
 569                 }
 570                 dummy.e_attrs = NULL;
 571
 572                 if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
 573                         if ( ctxcsn_added ) {
 574                                 bdb_cache_add( bdb, suffix_ei, ctxcsn_e,
 575                                         (struct berval *)&slap_ldapsync_cn_bv, locker );
 576                         }
 577                 }
 578
 579                 if ( rs->sr_err == LDAP_SUCCESS ) {
 580                         /* Loop through in-scope entries for each psearch spec */
 581                         ldap_pvt_thread_rdwr_wlock( &bdb->bi_pslist_rwlock );
 582                         LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
 583                                 rc = bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
 584                                 if ( rc ) {
 585                                         Debug( LDAP_DEBUG_TRACE,
 586                                                 "bdb_modify: persistent search failed (%d,%d)\n",
 587                                                 rc, rs->sr_err, 0 );
 588                                 }
 589                         }
 590                         pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
 591                         while ( pm_list != NULL ) {
 592                                 rc = bdb_psearch(op, rs, pm_list->ps_op,
 593                                                         e, LDAP_PSEARCH_BY_SCOPEOUT);
 594                                 if ( rc ) {
 595                                         Debug( LDAP_DEBUG_TRACE,
 596                                                 "bdb_modify: persistent search failed (%d,%d)\n",
 597                                                 rc, rs->sr_err, 0 );
 598                                 }
 599                                 LDAP_LIST_REMOVE ( pm_list, ps_link );
 600                                 pm_prev = pm_list;
 601                                 pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
 602                                 ch_free( pm_prev );
 603                         }
 604                         ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
 605                 }
 606
 607                 rs->sr_err = TXN_COMMIT( ltid, 0 );
 608         }
 609         ltid = NULL;
 610         op->o_private = NULL;
 611
 612         if( rs->sr_err != 0 ) {
 613                 Debug( LDAP_DEBUG_TRACE,
 614                         "bdb_modify: txn_%s failed: %s (%d)\n",
 615                         op->o_noop ? "abort (no-op)" : "commit",
 616                         db_strerror(rs->sr_err), rs->sr_err );
 617                 rs->sr_err = LDAP_OTHER;
 618                 rs->sr_text = "commit failed";
 619
 620                 goto return_results;
 621         }
 622
 623         Debug( LDAP_DEBUG_TRACE,
 624                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
 625                 op->o_noop ? " (no-op)" : "",
 626                 e->e_id, e->e_dn );
 627
 628         rs->sr_err = LDAP_SUCCESS;
 629         rs->sr_text = NULL;
 630         if( num_ctrls ) rs->sr_ctrls = ctrls;
 631
 632 return_results:
 633         if( dummy.e_attrs ) {
 634                 attrs_free( dummy.e_attrs );
 635         }
 636         send_ldap_result( op, rs );
 637
 638         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
 639                 ldap_pvt_thread_yield();
 640                 TXN_CHECKPOINT( bdb->bi_dbenv,
 641                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
 642         }
 643
 644 done:
 645         if( ltid != NULL ) {
 646                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
 647                 while ( pm_list != NULL ) {
 648                         LDAP_LIST_REMOVE ( pm_list, ps_link );
 649                         pm_prev = pm_list;
 650                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
 651                         ch_free( pm_prev );
 652                 }
 653                 TXN_ABORT( ltid );
 654                 op->o_private = NULL;
 655         }
 656
 657         if( e != NULL ) {
 658                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
 659         }
 660
 661         if( preread_ctrl != NULL ) {
 662                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, &op->o_tmpmemctx );
 663                 slap_sl_free( *preread_ctrl, &op->o_tmpmemctx );
 664         }
 665         if( postread_ctrl != NULL ) {
 666                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, &op->o_tmpmemctx );
 667                 slap_sl_free( *postread_ctrl, &op->o_tmpmemctx );
 668         }
 669         return rs->sr_err;
 670 }