]> git.sur5r.net Git - openldap/blob - servers/slapd/back-bdb/modify.c
Revert broken index optimizations
[openldap] / servers / slapd / back-bdb / modify.c
1 /* modify.c - bdb backend modify routine */
2 /* $OpenLDAP$ */
3 /*
4  * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
5  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
6  */
7
8 #include "portable.h"
9
10 #include <stdio.h>
11 #include <ac/string.h>
12 #include <ac/time.h>
13
14 #include "back-bdb.h"
15 #include "external.h"
16
17 int bdb_modify_internal(
18         Operation *op,
19         DB_TXN *tid,
20         Modifications *modlist,
21         Entry *e,
22         const char **text,
23         char *textbuf,
24         size_t textlen )
25 {
26         int rc, err;
27         Modification    *mod;
28         Modifications   *ml;
29         Attribute       *save_attrs;
30         Attribute       *ap;
31
32 #ifdef NEW_LOGGING
33         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify_internal: 0x%08lx: %s\n", 
34                 e->e_id, e->e_dn, 0 );
35 #else
36         Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
37                 e->e_id, e->e_dn, 0);
38 #endif
39
40         if ( !acl_check_modlist( op, e, modlist )) {
41                 return LDAP_INSUFFICIENT_ACCESS;
42         }
43
44         /* save_attrs will be disposed of by bdb_cache_modify */
45         save_attrs = e->e_attrs;
46         e->e_attrs = attrs_dup( e->e_attrs );
47
48         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
49                 mod = &ml->sml_mod;
50
51                 switch ( mod->sm_op ) {
52                 case LDAP_MOD_ADD:
53 #ifdef NEW_LOGGING
54                         LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify_internal: add\n", 0,0,0);
55 #else
56                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
57 #endif
58                         err = modify_add_values( e, mod, get_permissiveModify(op),
59                                 text, textbuf, textlen );
60                         if( err != LDAP_SUCCESS ) {
61 #ifdef NEW_LOGGING
62                                 LDAP_LOG ( OPERATION, ERR, 
63                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
64 #else
65                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
66                                         err, *text, 0);
67 #endif
68                         }
69                         break;
70
71                 case LDAP_MOD_DELETE:
72 #ifdef NEW_LOGGING
73                         LDAP_LOG ( OPERATION, DETAIL1, 
74                                 "bdb_modify_internal: delete\n", 0, 0, 0 );
75 #else
76                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
77 #endif
78                         err = modify_delete_values( e, mod, get_permissiveModify(op),
79                                 text, textbuf, textlen );
80                         assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
81                         if( err != LDAP_SUCCESS ) {
82 #ifdef NEW_LOGGING
83                                 LDAP_LOG ( OPERATION, ERR, 
84                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
85 #else
86                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
87                                         err, *text, 0);
88 #endif
89                         }
90                         break;
91
92                 case LDAP_MOD_REPLACE:
93 #ifdef NEW_LOGGING
94                         LDAP_LOG ( OPERATION, DETAIL1, 
95                                 "bdb_modify_internal: replace\n", 0, 0, 0 );
96 #else
97                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
98 #endif
99                         err = modify_replace_values( e, mod, get_permissiveModify(op),
100                                 text, textbuf, textlen );
101                         if( err != LDAP_SUCCESS ) {
102 #ifdef NEW_LOGGING
103                                 LDAP_LOG ( OPERATION, ERR, 
104                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
105 #else
106                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
107                                         err, *text, 0);
108 #endif
109                         }
110                         break;
111
112                 case LDAP_MOD_INCREMENT:
113 #ifdef NEW_LOGGING
114                         LDAP_LOG ( OPERATION, DETAIL1, 
115                                 "bdb_modify_internal: increment\n", 0, 0, 0 );
116 #else
117                         Debug(LDAP_DEBUG_ARGS,
118                                 "bdb_modify_internal: increment\n", 0, 0, 0);
119 #endif
120                         err = modify_increment_values( e, mod, get_permissiveModify(op),
121                                 text, textbuf, textlen );
122                         if( err != LDAP_SUCCESS ) {
123 #ifdef NEW_LOGGING
124                                 LDAP_LOG ( OPERATION, ERR, 
125                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
126 #else
127                                 Debug(LDAP_DEBUG_ARGS,
128                                         "bdb_modify_internal: %d %s\n",
129                                         err, *text, 0);
130 #endif
131                         }
132                         break;
133
134                 case SLAP_MOD_SOFTADD:
135 #ifdef NEW_LOGGING
136                         LDAP_LOG ( OPERATION, DETAIL1, 
137                                 "bdb_modify_internal: softadd\n",0,0,0 );
138 #else
139                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
140 #endif
141                         /* Avoid problems in index_add_mods()
142                          * We need to add index if necessary.
143                          */
144                         mod->sm_op = LDAP_MOD_ADD;
145
146                         err = modify_add_values( e, mod, get_permissiveModify(op),
147                                 text, textbuf, textlen );
148
149                         mod->sm_op = SLAP_MOD_SOFTADD;
150
151                         if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
152                                 err = LDAP_SUCCESS;
153                         }
154
155                         if( err != LDAP_SUCCESS ) {
156 #ifdef NEW_LOGGING
157                                 LDAP_LOG ( OPERATION, ERR, 
158                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
159 #else
160                                 Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
161                                         err, *text, 0);
162 #endif
163                         }
164                         break;
165
166                 default:
167 #ifdef NEW_LOGGING
168                                 LDAP_LOG ( OPERATION, ERR, 
169                                         "bdb_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
170 #else
171                         Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
172                                 mod->sm_op, 0, 0);
173 #endif
174                         *text = "Invalid modify operation";
175                         err = LDAP_OTHER;
176 #ifdef NEW_LOGGING
177                                 LDAP_LOG ( OPERATION, ERR, 
178                                         "bdb_modify_internal: %d %s\n", err, *text, 0 );
179 #else
180                         Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
181                                 err, *text, 0);
182 #endif
183                 }
184
185                 if ( err != LDAP_SUCCESS ) {
186                         attrs_free( e->e_attrs );
187                         e->e_attrs = save_attrs;
188                         /* unlock entry, delete from cache */
189                         return err; 
190                 }
191
192                 /* If objectClass was modified, reset the flags */
193                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
194                         e->e_ocflags = 0;
195                 }
196
197                 /* check if modified attribute was indexed
198                  * but not in case of NOOP... */
199                 err = bdb_index_is_indexed( op->o_bd, mod->sm_desc );
200                 if ( err == LDAP_SUCCESS && !op->o_noop ) {
201                         ap = attr_find( save_attrs, mod->sm_desc );
202                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
203
204                         ap = attr_find( e->e_attrs, mod->sm_desc );
205                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
206                 }
207         }
208
209         /* check that the entry still obeys the schema */
210         rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
211         if ( rc != LDAP_SUCCESS || op->o_noop ) {
212                 attrs_free( e->e_attrs );
213                 e->e_attrs = save_attrs;
214
215                 if ( rc != LDAP_SUCCESS ) {
216 #ifdef NEW_LOGGING
217                         LDAP_LOG ( OPERATION, ERR, "bdb_modify_internal: "
218                                 "entry failed schema check %s\n", 
219                                 *text, 0, 0 );
220 #else
221                         Debug( LDAP_DEBUG_ANY,
222                                 "entry failed schema check: %s\n",
223                                 *text, 0, 0 );
224 #endif
225                 }
226
227                 /* if NOOP then silently revert to saved attrs */
228                 return rc;
229         }
230
231         /* update the indices of the modified attributes */
232
233         /* start with deleting the old index entries */
234         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
235                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
236                         rc = bdb_index_values( op, tid, ap->a_desc,
237                                 ap->a_nvals,
238                                 e->e_id, SLAP_INDEX_DELETE_OP );
239                         if ( rc != LDAP_SUCCESS ) {
240                                 attrs_free( e->e_attrs );
241                                 e->e_attrs = save_attrs;
242 #ifdef NEW_LOGGING
243                                 LDAP_LOG ( OPERATION, ERR, 
244                                         "bdb_modify_internal: attribute index delete failure\n",
245                                         0, 0, 0 );
246 #else
247                                 Debug( LDAP_DEBUG_ANY,
248                                        "Attribute index delete failure",
249                                        0, 0, 0 );
250 #endif
251                                 return rc;
252                         }
253                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
254                 }
255         }
256
257         /* add the new index entries */
258         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
259                 if (ap->a_flags & SLAP_ATTR_IXADD) {
260                         rc = bdb_index_values( op, tid, ap->a_desc,
261                                 ap->a_nvals,
262                                 e->e_id, SLAP_INDEX_ADD_OP );
263                         if ( rc != LDAP_SUCCESS ) {
264                                 attrs_free( e->e_attrs );
265                                 e->e_attrs = save_attrs;
266 #ifdef NEW_LOGGING
267                                 LDAP_LOG ( OPERATION, ERR, 
268                                         "bdb_modify_internal: attribute index add failure\n", 
269                                         0, 0, 0 );
270 #else
271                                 Debug( LDAP_DEBUG_ANY,
272                                        "Attribute index add failure",
273                                        0, 0, 0 );
274 #endif
275                                 return rc;
276                         }
277                         ap->a_flags &= ~SLAP_ATTR_IXADD;
278                 }
279         }
280
281         return rc;
282 }
283
284
285 int
286 bdb_modify( Operation *op, SlapReply *rs )
287 {
288         struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
289         Entry           *e = NULL;
290         EntryInfo       *ei = NULL;
291         int             manageDSAit = get_manageDSAit( op );
292         char textbuf[SLAP_TEXT_BUFLEN];
293         size_t textlen = sizeof textbuf;
294         DB_TXN  *ltid = NULL, *lt2;
295         struct bdb_op_info opinfo;
296         Entry           dummy;
297
298         u_int32_t       locker = 0;
299         DB_LOCK         lock;
300
301         int             noop = 0;
302
303         int             num_retries = 0;
304
305         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
306         int num_ctrls = 0;
307
308         Operation* ps_list;
309         struct psid_entry *pm_list, *pm_prev;
310         int rc;
311         EntryInfo       *suffix_ei;
312         Entry           *ctxcsn_e;
313         int                     ctxcsn_added = 0;
314
315 #ifdef NEW_LOGGING
316         LDAP_LOG ( OPERATION, ENTRY, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
317 #else
318         Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n", op->o_req_dn.bv_val, 0, 0 );
319 #endif
320
321         if( 0 ) {
322 retry:  /* transaction retry */
323                 if( e != NULL ) {
324                         bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
325                         e = NULL;
326                 }
327 #ifdef NEW_LOGGING
328                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: retrying...\n", 0, 0, 0 );
329 #else
330                 Debug(LDAP_DEBUG_TRACE,
331                         "bdb_modify: retrying...\n", 0, 0, 0);
332 #endif
333
334                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
335                 while ( pm_list != NULL ) {
336                         LDAP_LIST_REMOVE ( pm_list, ps_link );
337                         pm_prev = pm_list;
338                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
339                         ch_free( pm_prev );
340                 }
341
342                 rs->sr_err = TXN_ABORT( ltid );
343                 ltid = NULL;
344                 op->o_private = NULL;
345                 op->o_do_not_cache = opinfo.boi_acl_cache;
346                 if( rs->sr_err != 0 ) {
347                         rs->sr_err = LDAP_OTHER;
348                         rs->sr_text = "internal error";
349                         goto return_results;
350                 }
351                 bdb_trans_backoff( ++num_retries );
352                 ldap_pvt_thread_yield();
353         }
354
355         /* begin transaction */
356         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
357                 bdb->bi_db_opflags );
358         rs->sr_text = NULL;
359         if( rs->sr_err != 0 ) {
360 #ifdef NEW_LOGGING
361                 LDAP_LOG ( OPERATION, DETAIL1, 
362                         "bdb_modify: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
363 #else
364                 Debug( LDAP_DEBUG_TRACE,
365                         "bdb_modify: txn_begin failed: %s (%d)\n",
366                         db_strerror(rs->sr_err), rs->sr_err, 0 );
367 #endif
368                 rs->sr_err = LDAP_OTHER;
369                 rs->sr_text = "internal error";
370                 goto return_results;
371         }
372
373         locker = TXN_ID ( ltid );
374
375         opinfo.boi_bdb = op->o_bd;
376         opinfo.boi_txn = ltid;
377         opinfo.boi_locker = locker;
378         opinfo.boi_err = 0;
379         opinfo.boi_acl_cache = op->o_do_not_cache;
380         op->o_private = &opinfo;
381
382         /* get entry or ancestor */
383         rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
384                 locker, &lock );
385
386         if ( rs->sr_err != 0 ) {
387 #ifdef NEW_LOGGING
388                 LDAP_LOG ( OPERATION, DETAIL1, 
389                         "bdb_modify: dn2entry failed: (%d)\n", rs->sr_err, 0, 0 );
390 #else
391                 Debug( LDAP_DEBUG_TRACE,
392                         "bdb_modify: dn2entry failed (%d)\n",
393                         rs->sr_err, 0, 0 );
394 #endif
395                 switch( rs->sr_err ) {
396                 case DB_LOCK_DEADLOCK:
397                 case DB_LOCK_NOTGRANTED:
398                         goto retry;
399                 case DB_NOTFOUND:
400                         break;
401                 case LDAP_BUSY:
402                         rs->sr_text = "ldap server busy";
403                         goto return_results;
404                 default:
405                         rs->sr_err = LDAP_OTHER;
406                         rs->sr_text = "internal error";
407                         goto return_results;
408                 }
409         }
410
411         e = ei->bei_e;
412         /* acquire and lock entry */
413         /* FIXME: dn2entry() should return non-glue entry */
414         if (( rs->sr_err == DB_NOTFOUND ) || ( !manageDSAit && e && is_entry_glue( e ))) {
415                 if ( e != NULL ) {
416                         rs->sr_matched = ch_strdup( e->e_dn );
417                         rs->sr_ref = is_entry_referral( e )
418                                 ? get_entry_referrals( op, e )
419                                 : NULL;
420                         bdb_unlocked_cache_return_entry_r (&bdb->bi_cache, e);
421                         e = NULL;
422
423                 } else {
424                         BerVarray deref = op->o_bd->syncinfo ?
425                                                           op->o_bd->syncinfo->provideruri_bv : default_referral;
426                         rs->sr_ref = referral_rewrite( deref, NULL, &op->o_req_dn, LDAP_SCOPE_DEFAULT );
427                 }
428
429                 rs->sr_err = LDAP_REFERRAL;
430                 send_ldap_result( op, rs );
431
432                 ber_bvarray_free( rs->sr_ref );
433                 free( (char *)rs->sr_matched );
434                 rs->sr_ref = NULL;
435                 rs->sr_matched = NULL;
436
437                 goto done;
438         }
439
440         if ( !manageDSAit && is_entry_referral( e ) ) {
441                 /* entry is a referral, don't allow modify */
442                 rs->sr_ref = get_entry_referrals( op, e );
443
444 #ifdef NEW_LOGGING
445                 LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: entry is referral\n", 0, 0, 0 );
446 #else
447                 Debug( LDAP_DEBUG_TRACE,
448                         "bdb_modify: entry is referral\n",
449                         0, 0, 0 );
450 #endif
451
452                 rs->sr_err = LDAP_REFERRAL;
453                 rs->sr_matched = e->e_name.bv_val;
454                 send_ldap_result( op, rs );
455
456                 ber_bvarray_free( rs->sr_ref );
457                 rs->sr_ref = NULL;
458                 rs->sr_matched = NULL;
459                 goto done;
460         }
461
462         if ( get_assert( op ) &&
463                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
464         {
465                 rs->sr_err = LDAP_ASSERTION_FAILED;
466                 goto return_results;
467         }
468
469         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
470                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
471                         bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
472                 }
473         }
474
475         if( op->o_preread ) {
476                 if ( slap_read_controls( op, rs, e,
477                         &slap_pre_read_bv, &ctrls[num_ctrls] ) )
478                 {
479 #ifdef NEW_LOGGING
480                         LDAP_LOG ( OPERATION, DETAIL1,
481                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
482 #else
483                         Debug( LDAP_DEBUG_TRACE,
484                                 "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
485 #endif
486                         goto return_results;
487                 }
488                 ctrls[++num_ctrls] = NULL;
489                 op->o_preread = 0; /* prevent redo on retry */
490         }
491
492         /* nested transaction */
493         rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
494                 bdb->bi_db_opflags );
495         rs->sr_text = NULL;
496         if( rs->sr_err != 0 ) {
497 #ifdef NEW_LOGGING
498                 LDAP_LOG ( OPERATION, ERR, 
499                         "bdb_modify: txn_begin(2) failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
500 #else
501                 Debug( LDAP_DEBUG_TRACE,
502                         "bdb_modify: txn_begin(2) failed: %s (%d)\n",
503                         db_strerror(rs->sr_err), rs->sr_err, 0 );
504 #endif
505                 rs->sr_err = LDAP_OTHER;
506                 rs->sr_text = "internal error";
507                 goto return_results;
508         }
509         /* Modify the entry */
510         dummy = *e;
511         rs->sr_err = bdb_modify_internal( op, lt2, op->oq_modify.rs_modlist,
512                 &dummy, &rs->sr_text, textbuf, textlen );
513
514         if( rs->sr_err != LDAP_SUCCESS ) {
515 #ifdef NEW_LOGGING
516                 LDAP_LOG ( OPERATION, ERR, 
517                         "bdb_modify: modify failed (%d)\n", rs->sr_err, 0, 0 );
518 #else
519                 Debug( LDAP_DEBUG_TRACE,
520                         "bdb_modify: modify failed (%d)\n",
521                         rs->sr_err, 0, 0 );
522 #endif
523                 if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
524                         rs->sr_err = opinfo.boi_err;
525                 }
526                 switch( rs->sr_err ) {
527                 case DB_LOCK_DEADLOCK:
528                 case DB_LOCK_NOTGRANTED:
529                         goto retry;
530                 }
531                 goto return_results;
532         }
533
534         if( op->o_postread ) {
535                 if( slap_read_controls( op, rs, e,
536                         &slap_post_read_bv, &ctrls[num_ctrls] ) )
537                 {
538 #ifdef NEW_LOGGING
539                         LDAP_LOG ( OPERATION, DETAIL1,
540                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
541 #else
542                         Debug( LDAP_DEBUG_TRACE,
543                                 "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
544 #endif
545                         goto return_results;
546                 }
547                 ctrls[++num_ctrls] = NULL;
548                 op->o_postread = 0;  /* prevent redo on retry */
549                 /* FIXME: should read entry on the last retry */
550         }
551
552         /* change the entry itself */
553         rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
554         if ( rs->sr_err != 0 ) {
555 #ifdef NEW_LOGGING
556                 LDAP_LOG ( OPERATION, ERR, 
557                         "bdb_modify: id2entry update failed (%d)\n", rs->sr_err, 0, 0 );
558 #else
559                 Debug( LDAP_DEBUG_TRACE,
560                         "bdb_modify: id2entry update failed (%d)\n",
561                         rs->sr_err, 0, 0 );
562 #endif
563                 switch( rs->sr_err ) {
564                 case DB_LOCK_DEADLOCK:
565                 case DB_LOCK_NOTGRANTED:
566                         goto retry;
567                 }
568                 rs->sr_text = "entry update failed";
569                 goto return_results;
570         }
571
572         if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
573                 rs->sr_err = LDAP_OTHER;
574                 rs->sr_text = "txn_commit(2) failed";
575                 goto return_results;
576         }
577
578         if ( !op->o_bd->syncinfo ) {
579                 rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
580                         &ctxcsn_e, &ctxcsn_added, locker );
581                 switch ( rc ) {
582                 case BDB_CSN_ABORT :
583                         goto return_results;
584                 case BDB_CSN_RETRY :
585                         goto retry;
586                 }
587         }
588
589         if( op->o_noop ) {
590                 if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
591                         rs->sr_text = "txn_abort (no-op) failed";
592                 } else {
593                         noop = 1;
594                         rs->sr_err = LDAP_SUCCESS;
595                 }
596         } else {
597                 EntryInfo *ctx_ei;
598
599                 bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
600
601                 if ( !op->o_bd->syncinfo ) {
602                         if ( ctxcsn_added ) {
603                                 bdb_cache_add( bdb, suffix_ei, ctxcsn_e, (struct berval *)&slap_ldapsync_cn_bv, locker );
604                         }
605                 }
606
607                 rs->sr_err = TXN_COMMIT( ltid, 0 );
608         }
609         ltid = NULL;
610         op->o_private = NULL;
611
612         if( rs->sr_err != 0 ) {
613 #ifdef NEW_LOGGING
614                 LDAP_LOG ( OPERATION, ERR, 
615                         "bdb_modify: txn_%s failed %s (%d)\n", 
616                         op->o_noop ? "abort (no_op)" : "commit",
617                         db_strerror(rs->sr_err), rs->sr_err );
618 #else
619                 Debug( LDAP_DEBUG_TRACE,
620                         "bdb_modify: txn_%s failed: %s (%d)\n",
621                         op->o_noop ? "abort (no-op)" : "commit",
622                         db_strerror(rs->sr_err), rs->sr_err );
623 #endif
624                 rs->sr_err = LDAP_OTHER;
625                 rs->sr_text = "commit failed";
626
627                 goto return_results;
628         }
629
630 #ifdef NEW_LOGGING
631         LDAP_LOG ( OPERATION, DETAIL1, 
632                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n", 
633                 op->o_noop ? " (no_op)" : "", e->e_id, e->e_dn );
634 #else
635         Debug( LDAP_DEBUG_TRACE,
636                 "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
637                 op->o_noop ? " (no-op)" : "",
638                 e->e_id, e->e_dn );
639 #endif
640
641         rs->sr_err = LDAP_SUCCESS;
642         rs->sr_text = NULL;
643         if( num_ctrls ) rs->sr_ctrls = ctrls;
644
645 return_results:
646         send_ldap_result( op, rs );
647
648         if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop ) {
649                 /* Loop through in-scope entries for each psearch spec */
650                 LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
651                         bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
652                 }
653                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
654                 while ( pm_list != NULL ) {
655                         bdb_psearch(op, rs, pm_list->ps_op,
656                                                 e, LDAP_PSEARCH_BY_SCOPEOUT);
657                         LDAP_LIST_REMOVE ( pm_list, ps_link );
658                         pm_prev = pm_list;
659                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
660                         ch_free( pm_prev );
661                 }
662         }
663
664         if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
665                 ldap_pvt_thread_yield();
666                 TXN_CHECKPOINT( bdb->bi_dbenv,
667                         bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
668         }
669
670 done:
671         if( ltid != NULL ) {
672                 pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
673                 while ( pm_list != NULL ) {
674                         LDAP_LIST_REMOVE ( pm_list, ps_link );
675                         pm_prev = pm_list;
676                         pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
677                         ch_free( pm_prev );
678                 }
679                 TXN_ABORT( ltid );
680                 op->o_private = NULL;
681         }
682
683         if( e != NULL ) {
684                 bdb_unlocked_cache_return_entry_w (&bdb->bi_cache, e);
685         }
686         return ( ( rs->sr_err == LDAP_SUCCESS ) ? noop : rs->sr_err );
687 }