]> git.sur5r.net Git - openldap/blob - servers/slapd/back-mdb/modify.c
Merge remote-tracking branch 'origin/mdb.RE/0.9'
[openldap] / servers / slapd / back-mdb / modify.c
1 /* modify.c - mdb backend modify routine */
2 /* $OpenLDAP$ */
3 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
4  *
5  * Copyright 2000-2016 The OpenLDAP Foundation.
6  * All rights reserved.
7  *
8  * Redistribution and use in source and binary forms, with or without
9  * modification, are permitted only as authorized by the OpenLDAP
10  * Public License.
11  *
12  * A copy of this license is available in the file LICENSE in the
13  * top-level directory of the distribution or, alternatively, at
14  * <http://www.OpenLDAP.org/license.html>.
15  */
16
17 #include "portable.h"
18
19 #include <stdio.h>
20 #include <ac/string.h>
21 #include <ac/time.h>
22
23 #include "back-mdb.h"
24
25 static struct berval scbva[] = {
26         BER_BVC("glue"),
27         BER_BVNULL
28 };
29
30 static void
31 mdb_modify_idxflags(
32         Operation *op,
33         AttributeDescription *desc,
34         int got_delete,
35         Attribute *newattrs,
36         Attribute *oldattrs )
37 {
38         struct berval   ix_at;
39         AttrInfo        *ai;
40
41         /* check if modified attribute was indexed
42          * but not in case of NOOP... */
43         ai = mdb_index_mask( op->o_bd, desc, &ix_at );
44         if ( ai ) {
45                 if ( got_delete ) {
46                         Attribute       *ap;
47                         struct berval   ix2;
48
49                         ap = attr_find( oldattrs, desc );
50                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXDEL;
51
52                         /* Find all other attrs that index to same slot */
53                         for ( ap = newattrs; ap; ap = ap->a_next ) {
54                                 ai = mdb_index_mask( op->o_bd, ap->a_desc, &ix2 );
55                                 if ( ai && ix2.bv_val == ix_at.bv_val )
56                                         ap->a_flags |= SLAP_ATTR_IXADD;
57                         }
58
59                 } else {
60                         Attribute       *ap;
61
62                         ap = attr_find( newattrs, desc );
63                         if ( ap ) ap->a_flags |= SLAP_ATTR_IXADD;
64                 }
65         }
66 }
67
68 int mdb_modify_internal(
69         Operation *op,
70         MDB_txn *tid,
71         Modifications *modlist,
72         Entry *e,
73         const char **text,
74         char *textbuf,
75         size_t textlen )
76 {
77         struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
78         int rc, err;
79         Modification    *mod;
80         Modifications   *ml;
81         Attribute       *save_attrs;
82         Attribute       *ap, *aold, *anew;
83         int                     glue_attr_delete = 0;
84         int                     softop, chkpresent;
85         int                     got_delete;
86         int                     a_flags;
87         MDB_cursor      *mvc = NULL;
88
89         Debug( LDAP_DEBUG_TRACE, "mdb_modify_internal: 0x%08lx: %s\n",
90                 e->e_id, e->e_dn, 0);
91
92         if ( !acl_check_modlist( op, e, modlist )) {
93                 return LDAP_INSUFFICIENT_ACCESS;
94         }
95
96         /* save_attrs will be disposed of by caller */
97         save_attrs = e->e_attrs;
98         e->e_attrs = attrs_dup( e->e_attrs );
99
100         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
101                 int match;
102                 mod = &ml->sml_mod;
103                 switch( mod->sm_op ) {
104                 case LDAP_MOD_ADD:
105                 case LDAP_MOD_REPLACE:
106                         if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
107                                 value_match( &match, slap_schema.si_ad_structuralObjectClass,
108                                         slap_schema.si_ad_structuralObjectClass->
109                                                 ad_type->sat_equality,
110                                         SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
111                                         &mod->sm_values[0], &scbva[0], text );
112                                 if ( !match ) glue_attr_delete = 1;
113                         }
114                 }
115                 if ( glue_attr_delete )
116                         break;
117         }
118
119         if ( glue_attr_delete ) {
120                 Attribute       **app = &e->e_attrs;
121                 while ( *app != NULL ) {
122                         if ( !is_at_operational( (*app)->a_desc->ad_type )) {
123                                 Attribute *save = *app;
124                                 *app = (*app)->a_next;
125                                 attr_free( save );
126                                 continue;
127                         }
128                         app = &(*app)->a_next;
129                 }
130         }
131
132         for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
133                 mod = &ml->sml_mod;
134                 got_delete = 0;
135
136                 aold = attr_find( e->e_attrs, mod->sm_desc );
137                 if (aold)
138                         a_flags = aold->a_flags;
139                 else
140                         a_flags = 0;
141
142                 switch ( mod->sm_op ) {
143                 case LDAP_MOD_ADD:
144                         softop = 0;
145                         chkpresent = 0;
146                         Debug(LDAP_DEBUG_ARGS,
147                                 "mdb_modify_internal: add %s\n",
148                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
149
150 do_add:
151                         err = modify_add_values( e, mod, get_permissiveModify(op),
152                                 text, textbuf, textlen );
153
154                         if( softop ) {
155                                 mod->sm_op = SLAP_MOD_SOFTADD;
156                                 if ( err == LDAP_TYPE_OR_VALUE_EXISTS )
157                                         err = LDAP_SUCCESS;
158                         }
159                         if( chkpresent ) {
160                                 mod->sm_op = SLAP_MOD_ADD_IF_NOT_PRESENT;
161                         }
162
163                         if( err != LDAP_SUCCESS ) {
164                                 Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
165                                         err, *text, 0);
166                         } else {
167                                 if (!aold)
168                                         anew = attr_find( e->e_attrs, mod->sm_desc );
169                                 else
170                                         anew = aold;
171                                 /* check for big multivalued attrs */
172                                 if ( anew->a_numvals > mdb->mi_multi_hi )
173                                         anew->a_flags |= SLAP_ATTR_BIG_MULTI;
174                                 if ( anew->a_flags & SLAP_ATTR_BIG_MULTI ) {
175                                         if (!mvc) {
176                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
177                                                 if (err)
178                                                         break;
179                                         }
180                                         /* if prev was set, just add new values */
181                                         if (a_flags & SLAP_ATTR_BIG_MULTI ) {
182                                                 anew = (Attribute *)mod;
183                                                 /* Tweak nvals */
184                                                 if (!anew->a_nvals)
185                                                         anew->a_nvals = anew->a_vals;
186                                         }
187                                         err = mdb_mval_put(op, mvc, e->e_id, anew);
188                                         if (a_flags & SLAP_ATTR_BIG_MULTI ) {
189                                                 /* Undo nvals tweak */
190                                                 if (anew->a_nvals == anew->a_vals)
191                                                         anew->a_nvals = NULL;
192                                         }
193                                 }
194                         }
195                         break;
196
197                 case LDAP_MOD_DELETE:
198                         if ( glue_attr_delete ) {
199                                 err = LDAP_SUCCESS;
200                                 break;
201                         }
202
203                         softop = 0;
204                         Debug(LDAP_DEBUG_ARGS,
205                                 "mdb_modify_internal: delete %s\n",
206                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
207 do_del:
208                         err = modify_delete_values( e, mod, get_permissiveModify(op),
209                                 text, textbuf, textlen );
210
211                         if (softop) {
212                                 mod->sm_op = SLAP_MOD_SOFTDEL;
213                                 if ( err == LDAP_NO_SUCH_ATTRIBUTE ) {
214                                         err = LDAP_SUCCESS;
215                                         softop = 2;
216                                 }
217                         }
218
219                         if( err != LDAP_SUCCESS ) {
220                                 Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
221                                         err, *text, 0);
222                         } else {
223                                 if (softop != 2)
224                                         got_delete = 1;
225                                 /* check for big multivalued attrs */
226                                 if (a_flags & SLAP_ATTR_BIG_MULTI) {
227                                         Attribute a_dummy;
228                                         if (!mvc) {
229                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
230                                                 if (err)
231                                                         break;
232                                         }
233                                         if ( mod->sm_numvals ) {
234                                                 anew = attr_find( e->e_attrs, mod->sm_desc );
235                                                 if ( anew->a_numvals < mdb->mi_multi_lo ) {
236                                                         anew->a_flags ^= SLAP_ATTR_BIG_MULTI;
237                                                         anew = NULL;
238                                                 } else {
239                                                         anew = (Attribute *)mod;
240                                                 }
241                                         } else {
242                                                 anew = NULL;
243                                         }
244                                         if (!anew) {
245                                         /* delete all values */
246                                                 anew = &a_dummy;
247                                                 anew->a_desc = mod->sm_desc;
248                                                 anew->a_numvals = 0;
249                                         }
250                                         err = mdb_mval_del( op, mvc, e->e_id, anew );
251                                 }
252                         }
253                         break;
254
255                 case LDAP_MOD_REPLACE:
256                         Debug(LDAP_DEBUG_ARGS,
257                                 "mdb_modify_internal: replace %s\n",
258                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
259                         err = modify_replace_values( e, mod, get_permissiveModify(op),
260                                 text, textbuf, textlen );
261                         if( err != LDAP_SUCCESS ) {
262                                 Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
263                                         err, *text, 0);
264                         } else {
265                                 got_delete = 1;
266                                 if (a_flags & SLAP_ATTR_BIG_MULTI) {
267                                         Attribute a_dummy;
268                                         if (!mvc) {
269                                                 err = mdb_cursor_open( tid, mdb->mi_dbis[MDB_ID2VAL], &mvc );
270                                                 if (err)
271                                                         break;
272                                         }
273                                         /* delete all values */
274                                         anew = &a_dummy;
275                                         anew->a_desc = mod->sm_desc;
276                                         anew->a_numvals = 0;
277                                         err = mdb_mval_del( op, mvc, e->e_id, anew );
278                                         if (err)
279                                                 break;
280                                         anew = attr_find( e->e_attrs, mod->sm_desc );
281                                         if (mod->sm_numvals >= mdb->mi_multi_lo) {
282                                                 anew->a_flags |= SLAP_ATTR_BIG_MULTI;
283                                                 err = mdb_mval_put(op, mvc, e->e_id, anew);
284                                         } else if (anew) {
285                                                 /* revert back to normal attr */
286                                                 anew->a_flags &= ~SLAP_ATTR_BIG_MULTI;
287                                         }
288                                 }
289                         }
290                         break;
291
292                 case LDAP_MOD_INCREMENT:
293                         Debug(LDAP_DEBUG_ARGS,
294                                 "mdb_modify_internal: increment %s\n",
295                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
296                         err = modify_increment_values( e, mod, get_permissiveModify(op),
297                                 text, textbuf, textlen );
298                         if( err != LDAP_SUCCESS ) {
299                                 Debug(LDAP_DEBUG_ARGS,
300                                         "mdb_modify_internal: %d %s\n",
301                                         err, *text, 0);
302                         } else {
303                                 got_delete = 1;
304                         }
305                         break;
306
307                 case SLAP_MOD_SOFTADD:
308                         Debug(LDAP_DEBUG_ARGS,
309                                 "mdb_modify_internal: softadd %s\n",
310                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
311                         /* Avoid problems in index_add_mods()
312                          * We need to add index if necessary.
313                          */
314                         mod->sm_op = LDAP_MOD_ADD;
315                         softop = 1;
316                         goto do_add;
317
318                 case SLAP_MOD_SOFTDEL:
319                         Debug(LDAP_DEBUG_ARGS,
320                                 "mdb_modify_internal: softdel %s\n",
321                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
322                         /* Avoid problems in index_delete_mods()
323                          * We need to add index if necessary.
324                          */
325                         mod->sm_op = LDAP_MOD_DELETE;
326                         softop = 1;
327                         goto do_del;
328
329                 case SLAP_MOD_ADD_IF_NOT_PRESENT:
330                         if ( attr_find( e->e_attrs, mod->sm_desc ) != NULL ) {
331                                 /* skip */
332                                 err = LDAP_SUCCESS;
333                                 break;
334                         }
335
336                         Debug(LDAP_DEBUG_ARGS,
337                                 "mdb_modify_internal: add_if_not_present %s\n",
338                                 mod->sm_desc->ad_cname.bv_val, 0, 0);
339                         /* Avoid problems in index_add_mods()
340                          * We need to add index if necessary.
341                          */
342                         mod->sm_op = LDAP_MOD_ADD;
343                         chkpresent = 1;
344                         goto do_add;
345
346                 default:
347                         Debug(LDAP_DEBUG_ANY, "mdb_modify_internal: invalid op %d\n",
348                                 mod->sm_op, 0, 0);
349                         *text = "Invalid modify operation";
350                         err = LDAP_OTHER;
351                         Debug(LDAP_DEBUG_ARGS, "mdb_modify_internal: %d %s\n",
352                                 err, *text, 0);
353                 }
354
355                 if ( err != LDAP_SUCCESS ) {
356                         attrs_free( e->e_attrs );
357                         e->e_attrs = save_attrs;
358                         /* unlock entry, delete from cache */
359                         return err; 
360                 }
361
362                 /* If objectClass was modified, reset the flags */
363                 if ( mod->sm_desc == slap_schema.si_ad_objectClass ) {
364                         e->e_ocflags = 0;
365                 }
366
367                 if ( glue_attr_delete ) e->e_ocflags = 0;
368
369
370                 /* check if modified attribute was indexed
371                  * but not in case of NOOP... */
372                 if ( !op->o_noop ) {
373                         mdb_modify_idxflags( op, mod->sm_desc, got_delete, e->e_attrs, save_attrs );
374                 }
375         }
376
377         /* check that the entry still obeys the schema */
378         ap = NULL;
379         rc = entry_schema_check( op, e, save_attrs, get_relax(op), 0, &ap,
380                 text, textbuf, textlen );
381         if ( rc != LDAP_SUCCESS || op->o_noop ) {
382                 attrs_free( e->e_attrs );
383                 /* clear the indexing flags */
384                 for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
385                         ap->a_flags &= ~(SLAP_ATTR_IXADD|SLAP_ATTR_IXDEL);
386                 }
387                 e->e_attrs = save_attrs;
388
389                 if ( rc != LDAP_SUCCESS ) {
390                         Debug( LDAP_DEBUG_ANY,
391                                 "entry failed schema check: %s\n",
392                                 *text, 0, 0 );
393                 }
394
395                 /* if NOOP then silently revert to saved attrs */
396                 return rc;
397         }
398
399         /* structuralObjectClass modified! */
400         if ( ap ) {
401                 assert( ap->a_desc == slap_schema.si_ad_structuralObjectClass );
402                 if ( !op->o_noop ) {
403                         mdb_modify_idxflags( op, slap_schema.si_ad_structuralObjectClass,
404                                 1, e->e_attrs, save_attrs );
405                 }
406         }
407
408         /* update the indices of the modified attributes */
409
410         /* start with deleting the old index entries */
411         for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
412                 if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
413                         struct berval *vals;
414                         Attribute *a2;
415                         ap->a_flags &= ~SLAP_ATTR_IXDEL;
416                         a2 = attr_find( e->e_attrs, ap->a_desc );
417                         if ( a2 ) {
418                                 /* need to detect which values were deleted */
419                                 int i, j;
420                                 /* let add know there were deletes */
421                                 if ( a2->a_flags & SLAP_ATTR_IXADD )
422                                         a2->a_flags |= SLAP_ATTR_IXDEL;
423                                 vals = op->o_tmpalloc( (ap->a_numvals + 1) *
424                                         sizeof(struct berval), op->o_tmpmemctx );
425                                 j = 0;
426                                 for ( i=0; i < ap->a_numvals; i++ ) {
427                                         rc = attr_valfind( a2, SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
428                                                 &ap->a_nvals[i], NULL, op->o_tmpmemctx );
429                                         /* Save deleted values */
430                                         if ( rc == LDAP_NO_SUCH_ATTRIBUTE )
431                                                 vals[j++] = ap->a_nvals[i];
432                                 }
433                                 BER_BVZERO(vals+j);
434                         } else {
435                                 /* attribute was completely deleted */
436                                 vals = ap->a_nvals;
437                         }
438                         rc = 0;
439                         if ( !BER_BVISNULL( vals )) {
440                                 rc = mdb_index_values( op, tid, ap->a_desc,
441                                         vals, e->e_id, SLAP_INDEX_DELETE_OP );
442                                 if ( rc != LDAP_SUCCESS ) {
443                                         Debug( LDAP_DEBUG_ANY,
444                                                 "%s: attribute \"%s\" index delete failure\n",
445                                                 op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
446                                         attrs_free( e->e_attrs );
447                                         e->e_attrs = save_attrs;
448                                 }
449                         }
450                         if ( vals != ap->a_nvals )
451                                 op->o_tmpfree( vals, op->o_tmpmemctx );
452                         if ( rc ) return rc;
453                 }
454         }
455
456         /* add the new index entries */
457         for ( ap = e->e_attrs; ap != NULL; ap = ap->a_next ) {
458                 if (ap->a_flags & SLAP_ATTR_IXADD) {
459                         ap->a_flags &= ~SLAP_ATTR_IXADD;
460                         if ( ap->a_flags & SLAP_ATTR_IXDEL ) {
461                                 /* if any values were deleted, we must readd index
462                                  * for all remaining values.
463                                  */
464                                 ap->a_flags &= ~SLAP_ATTR_IXDEL;
465                                 rc = mdb_index_values( op, tid, ap->a_desc,
466                                         ap->a_nvals,
467                                         e->e_id, SLAP_INDEX_ADD_OP );
468                         } else {
469                                 int found = 0;
470                                 /* if this was only an add, we only need to index
471                                  * the added values.
472                                  */
473                                 for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
474                                         struct berval *vals;
475                                         if ( ml->sml_desc != ap->a_desc || !ml->sml_numvals )
476                                                 continue;
477                                         found = 1;
478                                         switch( ml->sml_op ) {
479                                         case LDAP_MOD_ADD:
480                                         case LDAP_MOD_REPLACE:
481                                         case LDAP_MOD_INCREMENT:
482                                         case SLAP_MOD_SOFTADD:
483                                         case SLAP_MOD_ADD_IF_NOT_PRESENT:
484                                                 if ( ml->sml_op == LDAP_MOD_INCREMENT )
485                                                         vals = ap->a_nvals;
486                                                 else if ( ml->sml_nvalues )
487                                                         vals = ml->sml_nvalues;
488                                                 else
489                                                         vals = ml->sml_values;
490                                                 rc = mdb_index_values( op, tid, ap->a_desc,
491                                                         vals, e->e_id, SLAP_INDEX_ADD_OP );
492                                                 break;
493                                         }
494                                         if ( rc )
495                                                 break;
496                                 }
497                                 /* This attr was affected by a modify of a subtype, so
498                                  * there was no direct match in the modlist. Just readd
499                                  * all of its values.
500                                  */
501                                 if ( !found ) {
502                                         rc = mdb_index_values( op, tid, ap->a_desc,
503                                                 ap->a_nvals,
504                                                 e->e_id, SLAP_INDEX_ADD_OP );
505                                 }
506                         }
507                         if ( rc != LDAP_SUCCESS ) {
508                                 Debug( LDAP_DEBUG_ANY,
509                                        "%s: attribute \"%s\" index add failure\n",
510                                         op->o_log_prefix, ap->a_desc->ad_cname.bv_val, 0 );
511                                 attrs_free( e->e_attrs );
512                                 e->e_attrs = save_attrs;
513                                 return rc;
514                         }
515                 }
516         }
517
518         return rc;
519 }
520
521
522 int
523 mdb_modify( Operation *op, SlapReply *rs )
524 {
525         struct mdb_info *mdb = (struct mdb_info *) op->o_bd->be_private;
526         Entry           *e = NULL;
527         int             manageDSAit = get_manageDSAit( op );
528         char textbuf[SLAP_TEXT_BUFLEN];
529         size_t textlen = sizeof textbuf;
530         MDB_txn *txn = NULL;
531         mdb_op_info opinfo = {{{ 0 }}}, *moi = &opinfo;
532         Entry           dummy = {0};
533
534         LDAPControl **preread_ctrl = NULL;
535         LDAPControl **postread_ctrl = NULL;
536         LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
537         int num_ctrls = 0;
538         int numads = mdb->mi_numads;
539
540         Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(mdb_modify) ": %s\n",
541                 op->o_req_dn.bv_val, 0, 0 );
542
543 #ifdef LDAP_X_TXN
544         if( op->o_txnSpec && txn_preop( op, rs ))
545                 return rs->sr_err;
546 #endif
547
548         ctrls[num_ctrls] = NULL;
549
550         /* begin transaction */
551         rs->sr_err = mdb_opinfo_get( op, mdb, 0, &moi );
552         rs->sr_text = NULL;
553         if( rs->sr_err != 0 ) {
554                 Debug( LDAP_DEBUG_TRACE,
555                         LDAP_XSTRING(mdb_modify) ": txn_begin failed: "
556                         "%s (%d)\n", mdb_strerror(rs->sr_err), rs->sr_err, 0 );
557                 rs->sr_err = LDAP_OTHER;
558                 rs->sr_text = "internal error";
559                 goto return_results;
560         }
561         txn = moi->moi_txn;
562
563         /* Don't touch the opattrs, if this is a contextCSN update
564          * initiated from updatedn */
565         if ( !be_isupdate(op) || !op->orm_modlist || op->orm_modlist->sml_next ||
566                  op->orm_modlist->sml_desc != slap_schema.si_ad_contextCSN ) {
567
568                 slap_mods_opattrs( op, &op->orm_modlist, 1 );
569         }
570
571         /* get entry or ancestor */
572         rs->sr_err = mdb_dn2entry( op, txn, NULL, &op->o_req_ndn, &e, NULL, 1 );
573
574         if ( rs->sr_err != 0 ) {
575                 Debug( LDAP_DEBUG_TRACE,
576                         LDAP_XSTRING(mdb_modify) ": dn2entry failed (%d)\n",
577                         rs->sr_err, 0, 0 );
578                 switch( rs->sr_err ) {
579                 case MDB_NOTFOUND:
580                         break;
581                 case LDAP_BUSY:
582                         rs->sr_text = "ldap server busy";
583                         goto return_results;
584                 default:
585                         rs->sr_err = LDAP_OTHER;
586                         rs->sr_text = "internal error";
587                         goto return_results;
588                 }
589         }
590
591         /* acquire and lock entry */
592         /* FIXME: dn2entry() should return non-glue entry */
593         if (( rs->sr_err == MDB_NOTFOUND ) ||
594                 ( !manageDSAit && e && is_entry_glue( e )))
595         {
596                 if ( e != NULL ) {
597                         rs->sr_matched = ch_strdup( e->e_dn );
598                         if ( is_entry_referral( e )) {
599                                 BerVarray ref = get_entry_referrals( op, e );
600                                 rs->sr_ref = referral_rewrite( ref, &e->e_name,
601                                         &op->o_req_dn, LDAP_SCOPE_DEFAULT );
602                                 ber_bvarray_free( ref );
603                         } else {
604                                 rs->sr_ref = NULL;
605                         }
606                         mdb_entry_return( op, e );
607                         e = NULL;
608
609                 } else {
610                         rs->sr_ref = referral_rewrite( default_referral, NULL,
611                                 &op->o_req_dn, LDAP_SCOPE_DEFAULT );
612                 }
613
614                 rs->sr_flags = REP_MATCHED_MUSTBEFREED | REP_REF_MUSTBEFREED;
615                 rs->sr_err = LDAP_REFERRAL;
616                 send_ldap_result( op, rs );
617                 goto done;
618         }
619
620         if ( !manageDSAit && is_entry_referral( e ) ) {
621                 /* entry is a referral, don't allow modify */
622                 rs->sr_ref = get_entry_referrals( op, e );
623
624                 Debug( LDAP_DEBUG_TRACE,
625                         LDAP_XSTRING(mdb_modify) ": entry is referral\n",
626                         0, 0, 0 );
627
628                 rs->sr_err = LDAP_REFERRAL;
629                 rs->sr_matched = e->e_name.bv_val;
630                 rs->sr_flags = REP_REF_MUSTBEFREED;
631                 send_ldap_result( op, rs );
632                 rs->sr_matched = NULL;
633                 goto done;
634         }
635
636         if ( get_assert( op ) &&
637                 ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
638         {
639                 rs->sr_err = LDAP_ASSERTION_FAILED;
640                 goto return_results;
641         }
642
643         if( op->o_preread ) {
644                 if( preread_ctrl == NULL ) {
645                         preread_ctrl = &ctrls[num_ctrls++];
646                         ctrls[num_ctrls] = NULL;
647                 }
648                 if ( slap_read_controls( op, rs, e,
649                         &slap_pre_read_bv, preread_ctrl ) )
650                 {
651                         Debug( LDAP_DEBUG_TRACE,
652                                 "<=- " LDAP_XSTRING(mdb_modify) ": pre-read "
653                                 "failed!\n", 0, 0, 0 );
654                         if ( op->o_preread & SLAP_CONTROL_CRITICAL ) {
655                                 /* FIXME: is it correct to abort
656                                  * operation if control fails? */
657                                 goto return_results;
658                         }
659                 }
660         }
661
662         /* Modify the entry */
663         dummy = *e;
664         rs->sr_err = mdb_modify_internal( op, txn, op->orm_modlist,
665                 &dummy, &rs->sr_text, textbuf, textlen );
666
667         if( rs->sr_err != LDAP_SUCCESS ) {
668                 Debug( LDAP_DEBUG_TRACE,
669                         LDAP_XSTRING(mdb_modify) ": modify failed (%d)\n",
670                         rs->sr_err, 0, 0 );
671                 /* Only free attrs if they were dup'd.  */
672                 if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
673                 goto return_results;
674         }
675
676         /* change the entry itself */
677         rs->sr_err = mdb_id2entry_update( op, txn, NULL, &dummy );
678         if ( rs->sr_err != 0 ) {
679                 Debug( LDAP_DEBUG_TRACE,
680                         LDAP_XSTRING(mdb_modify) ": id2entry update failed " "(%d)\n",
681                         rs->sr_err, 0, 0 );
682                 if ( rs->sr_err == LDAP_ADMINLIMIT_EXCEEDED ) {
683                         rs->sr_text = "entry too big";
684                 } else {
685                         rs->sr_err = LDAP_OTHER;
686                         rs->sr_text = "entry update failed";
687                 }
688                 goto return_results;
689         }
690
691         if( op->o_postread ) {
692                 if( postread_ctrl == NULL ) {
693                         postread_ctrl = &ctrls[num_ctrls++];
694                         ctrls[num_ctrls] = NULL;
695                 }
696                 if( slap_read_controls( op, rs, &dummy,
697                         &slap_post_read_bv, postread_ctrl ) )
698                 {
699                         Debug( LDAP_DEBUG_TRACE,
700                                 "<=- " LDAP_XSTRING(mdb_modify)
701                                 ": post-read failed!\n", 0, 0, 0 );
702                         if ( op->o_postread & SLAP_CONTROL_CRITICAL ) {
703                                 /* FIXME: is it correct to abort
704                                  * operation if control fails? */
705                                 goto return_results;
706                         }
707                 }
708         }
709
710         /* Only free attrs if they were dup'd.  */
711         if ( dummy.e_attrs == e->e_attrs ) dummy.e_attrs = NULL;
712         if( moi == &opinfo ) {
713                 LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.moi_oe, OpExtra, oe_next );
714                 opinfo.moi_oe.oe_key = NULL;
715                 if( op->o_noop ) {
716                         mdb->mi_numads = numads;
717                         mdb_txn_abort( txn );
718                         rs->sr_err = LDAP_X_NO_OPERATION;
719                         txn = NULL;
720                         goto return_results;
721                 } else {
722                         rs->sr_err = mdb_txn_commit( txn );
723                         if ( rs->sr_err )
724                                 mdb->mi_numads = numads;
725                         txn = NULL;
726                 }
727         }
728
729         if( rs->sr_err != 0 ) {
730                 Debug( LDAP_DEBUG_ANY,
731                         LDAP_XSTRING(mdb_modify) ": txn_%s failed: %s (%d)\n",
732                         op->o_noop ? "abort (no-op)" : "commit",
733                         mdb_strerror(rs->sr_err), rs->sr_err );
734                 rs->sr_err = LDAP_OTHER;
735                 rs->sr_text = "commit failed";
736
737                 goto return_results;
738         }
739
740         Debug( LDAP_DEBUG_TRACE,
741                 LDAP_XSTRING(mdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
742                 op->o_noop ? " (no-op)" : "",
743                 dummy.e_id, op->o_req_dn.bv_val );
744
745         rs->sr_err = LDAP_SUCCESS;
746         rs->sr_text = NULL;
747         if( num_ctrls ) rs->sr_ctrls = ctrls;
748
749 return_results:
750         if( dummy.e_attrs ) {
751                 attrs_free( dummy.e_attrs );
752         }
753         send_ldap_result( op, rs );
754
755 #if 0
756         if( rs->sr_err == LDAP_SUCCESS && mdb->bi_txn_cp_kbyte ) {
757                 TXN_CHECKPOINT( mdb->bi_dbenv,
758                         mdb->bi_txn_cp_kbyte, mdb->bi_txn_cp_min, 0 );
759         }
760 #endif
761
762 done:
763         slap_graduate_commit_csn( op );
764
765         if( moi == &opinfo ) {
766                 if( txn != NULL ) {
767                         mdb->mi_numads = numads;
768                         mdb_txn_abort( txn );
769                 }
770                 if ( opinfo.moi_oe.oe_key ) {
771                         LDAP_SLIST_REMOVE( &op->o_extra, &opinfo.moi_oe, OpExtra, oe_next );
772                 }
773         } else {
774                 moi->moi_ref--;
775         }
776
777         if( e != NULL ) {
778                 mdb_entry_return( op, e );
779         }
780
781         if( preread_ctrl != NULL && (*preread_ctrl) != NULL ) {
782                 slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
783                 slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
784         }
785         if( postread_ctrl != NULL && (*postread_ctrl) != NULL ) {
786                 slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
787                 slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
788         }
789
790         rs->sr_text = NULL;
791
792         return rs->sr_err;
793 }