+ /* find out the desired position of this dock window */
+ if (cwindow->reserved.top > 0 && cwindow->reserved.bottom == 0) {
+ DLOG("Top dock client\n");
+ cwindow->dock = W_DOCK_TOP;
+ } else if (cwindow->reserved.top == 0 && cwindow->reserved.bottom > 0) {
+ DLOG("Bottom dock client\n");
+ cwindow->dock = W_DOCK_BOTTOM;
+ } else {
+ DLOG("Ignoring invalid reserved edges (_NET_WM_STRUT_PARTIAL), using position as fallback:\n");
+ if (geom->y < (search_at->rect.height / 2)) {
+ DLOG("geom->y = %d < rect.height / 2 = %d, it is a top dock client\n",
+ geom->y, (search_at->rect.height / 2));
+ cwindow->dock = W_DOCK_TOP;
+ } else {
+ DLOG("geom->y = %d >= rect.height / 2 = %d, it is a bottom dock client\n",
+ geom->y, (search_at->rect.height / 2));
+ cwindow->dock = W_DOCK_BOTTOM;
+ }
+ }
+ }
+
+ DLOG("Initial geometry: (%d, %d, %d, %d)\n", geom->x, geom->y, geom->width, geom->height);
+
+ Con *nc = NULL;
+ Match *match;
+
+ /* check assignments first */
+ if ((match = match_by_assignment(cwindow))) {
+ DLOG("Assignment matches (%p)\n", match);
+ if (match->insert_where == M_ASSIGN_WS) {
+ nc = con_descend_focused(workspace_get(match->target_ws, NULL));
+ DLOG("focused on ws %s: %p / %s\n", match->target_ws, nc, nc->name);
+ if (nc->type == CT_WORKSPACE)
+ nc = tree_open_con(nc);
+ else nc = tree_open_con(nc->parent);
+ }
+ } else {
+ /* TODO: two matches for one container */
+
+ /* See if any container swallows this new window */
+ nc = con_for_window(search_at, cwindow, &match);
+ if (nc == NULL) {
+ if (focused->type == CT_CON && con_accepts_window(focused)) {
+ LOG("using current container, focused = %p, focused->name = %s\n",
+ focused, focused->name);
+ nc = focused;
+ } else nc = tree_open_con(NULL);
+ } else {
+ /* M_BELOW inserts the new window as a child of the one which was
+ * matched (e.g. dock areas) */
+ if (match != NULL && match->insert_where == M_BELOW) {
+ nc = tree_open_con(nc);
+ }
+ }
+ }
+
+ DLOG("new container = %p\n", nc);
+ nc->window = cwindow;
+ x_reinit(nc);
+
+ nc->border_width = geom->border_width;
+
+ char *name;
+ asprintf(&name, "[i3 con] container around %p", cwindow);
+ x_set_name(nc, name);
+ free(name);
+
+ Con *ws = con_get_workspace(nc);
+ Con *fs = (ws ? con_get_fullscreen_con(ws) : NULL);
+
+ if (fs == NULL) {
+ DLOG("Not in fullscreen mode, focusing\n");
+ if (!cwindow->dock)
+ con_focus(nc);
+ else DLOG("dock, not focusing\n");
+ } else {
+ DLOG("fs = %p, ws = %p, not focusing\n", fs, ws);
+ /* Insert the new container in focus stack *after* the currently
+ * focused (fullscreen) con. This way, the new container will be
+ * focused after we return from fullscreen mode */
+ Con *first = TAILQ_FIRST(&(nc->parent->focus_head));
+ TAILQ_REMOVE(&(nc->parent->focus_head), nc, focused);
+ TAILQ_INSERT_AFTER(&(nc->parent->focus_head), first, nc, focused);
+ }
+
+ /* set floating if necessary */
+ bool want_floating = false;
+ if (xcb_reply_contains_atom(reply, A__NET_WM_WINDOW_TYPE_DIALOG) ||
+ xcb_reply_contains_atom(reply, A__NET_WM_WINDOW_TYPE_UTILITY) ||
+ xcb_reply_contains_atom(reply, A__NET_WM_WINDOW_TYPE_TOOLBAR) ||
+ xcb_reply_contains_atom(reply, A__NET_WM_WINDOW_TYPE_SPLASH)) {
+ LOG("This window is a dialog window, setting floating\n");
+ want_floating = true;
+ }
+
+ if (cwindow->transient_for != XCB_NONE ||
+ (cwindow->leader != XCB_NONE &&
+ cwindow->leader != cwindow->id &&
+ con_by_window_id(cwindow->leader) != NULL)) {
+ LOG("This window is transiert for another window, setting floating\n");
+ want_floating = true;
+
+ if (config.popup_during_fullscreen == PDF_LEAVE_FULLSCREEN &&
+ fs != NULL) {
+ LOG("There is a fullscreen window, leaving fullscreen mode\n");
+ con_toggle_fullscreen(fs);
+ }
+ }
+
+ /* dock clients cannot be floating, that makes no sense */
+ if (cwindow->dock)
+ want_floating = false;
+
+ /* Store the requested geometry. The width/height gets raised to at least
+ * 75x50 when entering floating mode, which is the minimum size for a
+ * window to be useful (smaller windows are usually overlays/toolbars/…
+ * which are not managed by the wm anyways). We store the original geometry
+ * here because it’s used for dock clients. */
+ nc->geometry = (Rect){ geom->x, geom->y, geom->width, geom->height };
+
+ if (want_floating) {
+ DLOG("geometry = %d x %d\n", nc->geometry.width, nc->geometry.height);
+ floating_enable(nc, false);
+ }
+
+ /* to avoid getting an UnmapNotify event due to reparenting, we temporarily
+ * declare no interest in any state change event of this window */
+ values[0] = XCB_NONE;
+ xcb_change_window_attributes(conn, window, XCB_CW_EVENT_MASK, values);
+
+ xcb_void_cookie_t rcookie = xcb_reparent_window_checked(conn, window, nc->frame, 0, 0);
+ if (xcb_request_check(conn, rcookie) != NULL) {
+ LOG("Could not reparent the window, aborting\n");
+ goto out;
+ }
+
+ mask = XCB_CW_EVENT_MASK;
+ values[0] = CHILD_EVENT_MASK;
+ xcb_change_window_attributes(conn, window, mask, values);
+
+ reply = xcb_get_property_reply(conn, state_cookie, NULL);
+ if (xcb_reply_contains_atom(reply, A__NET_WM_STATE_FULLSCREEN))
+ con_toggle_fullscreen(nc);
+
+ /* Put the client inside the save set. Upon termination (whether killed or
+ * normal exit does not matter) of the window manager, these clients will
+ * be correctly reparented to their most closest living ancestor (=
+ * cleanup) */
+ xcb_change_save_set(conn, XCB_SET_MODE_INSERT, window);
+
+ tree_render();
+
+ free(geom);
+out:
+ free(attr);
+ return;
+}
+
+#if 0
+void reparent_window(xcb_connection_t *conn, xcb_window_t child,
+ xcb_visualid_t visual, xcb_window_t root, uint8_t depth,
+ int16_t x, int16_t y, uint16_t width, uint16_t height,
+ uint32_t border_width) {
+
+ /* Minimum useful size for managed windows is 75x50 (primarily affects floating) */
+ width = max(width, 75);
+ height = max(height, 50);
+
+ if (config.default_border != NULL)
+ client_init_border(conn, new, config.default_border[1]);