/*\r
- * FreeRTOS+UDP V1.0.3 (C) 2014 Real Time Engineers ltd.\r
+ * FreeRTOS+UDP V1.0.4 (C) 2014 Real Time Engineers ltd.\r
* All rights reserved\r
*\r
* This file is part of the FreeRTOS+UDP distribution. The FreeRTOS+UDP license\r
/* The queue used to communicate Ethernet events to the IP task. */\r
extern xQueueHandle xNetworkEventQueue;\r
\r
-/* The semaphore used to wake the deferred interrupt handler task when an Rx\r
-interrupt is received. */\r
-static xSemaphoreHandle xGMACRxEventSemaphore = NULL;\r
-\r
/* The GMAC driver instance. */\r
static gmac_device_t xGMACStruct;\r
\r
+/* Handle of the task used to process MAC events. */\r
+static TaskHandle_t xMACEventHandlingTask = NULL;\r
+\r
/*-----------------------------------------------------------*/\r
\r
BaseType_t xNetworkInterfaceInitialise( void )\r
vTaskDelay( xPHYDelay_400ms * 2UL );\r
if( ethernet_phy_set_link( GMAC, BOARD_GMAC_PHY_ADDR, 1 ) == GMAC_OK )\r
{\r
- /* Create the event semaphore if it has not already been\r
- created. */\r
- if( xGMACRxEventSemaphore == NULL )\r
- {\r
- xGMACRxEventSemaphore = xSemaphoreCreateCounting( ULONG_MAX, 0 );\r
- #if ipconfigINCLUDE_EXAMPLE_FREERTOS_PLUS_TRACE_CALLS == 1\r
- {\r
- /* If the trace recorder code is included name the semaphore for\r
- viewing in FreeRTOS+Trace. */\r
- vTraceSetQueueName( xGMACRxEventSemaphore, "MAC_RX" );\r
- }\r
- #endif /* ipconfigINCLUDE_EXAMPLE_FREERTOS_PLUS_TRACE_CALLS == 1 */\r
- }\r
-\r
/* Register the callbacks. */\r
gmac_dev_set_rx_callback( &xGMACStruct, prvGMACRxCallback );\r
\r
configMINIMAL_STACK_SIZE, /* Stack allocated to the task (defined in words, not bytes). */\r
NULL, /* The task parameter is not used. */\r
configMAX_PRIORITIES - 1, /* The priority assigned to the task. */\r
- NULL ); /* The handle is not required, so NULL is passed. */\r
+ &xMACEventHandlingTask ); /* The handle is stored so the ISR knows which task to notify. */\r
\r
/* Enable the interrupt and set its priority as configured.\r
THIS DRIVER REQUIRES configMAC_INTERRUPT_PRIORITY TO BE DEFINED,\r
{\r
BaseType_t xHigherPriorityTaskWoken = pdFALSE;\r
\r
+ configASSERT( xMACEventHandlingTask );\r
+\r
/* Unblock the deferred interrupt handler task if the event was an Rx. */\r
- if( ulStatus == GMAC_RSR_REC )\r
+ if( ( ulStatus & GMAC_RSR_REC ) != 0 )\r
{\r
- xSemaphoreGiveFromISR( xGMACRxEventSemaphore, &xHigherPriorityTaskWoken );\r
+ vTaskNotifyGiveFromISR( xMACEventHandlingTask, &xHigherPriorityTaskWoken );\r
}\r
\r
portEND_SWITCHING_ISR( xHigherPriorityTaskWoken );\r
\r
static void prvGMACDeferredInterruptHandlerTask( void *pvParameters )\r
{\r
-xNetworkBufferDescriptor_t *pxNetworkBuffer;\r
+xNetworkBufferDescriptor_t *pxNetworkBuffer = NULL;\r
xIPStackEvent_t xRxEvent = { eEthernetRxEvent, NULL };\r
static const TickType_t xBufferWaitDelay = 1500UL / portTICK_RATE_MS;\r
uint32_t ulReturned;\r
\r
+ /* This is a very simply but also inefficient implementation. */\r
+\r
( void ) pvParameters;\r
- configASSERT( xGMACRxEventSemaphore );\r
\r
for( ;; )\r
{\r
/* Wait for the GMAC interrupt to indicate that another packet has been\r
- received. The while() loop is only needed if INCLUDE_vTaskSuspend is\r
- set to 0 in FreeRTOSConfig.h. If INCLUDE_vTaskSuspend is set to 1\r
- then portMAX_DELAY would be an indefinite block time and\r
- xSemaphoreTake() would only return when the semaphore was actually\r
- obtained. */\r
- while( xSemaphoreTake( xGMACRxEventSemaphore, portMAX_DELAY ) == pdFALSE );\r
+ received. A while loop is used to process all received frames each time\r
+ this task is notified, so it is ok to clear the notification count on the\r
+ take (hence the first parameter is pdTRUE ). */\r
+ ulTaskNotifyTake( pdTRUE, xBufferWaitDelay );\r
\r
- /* Allocate a buffer to hold the data. */\r
- pxNetworkBuffer = pxNetworkBufferGet( ipTOTAL_ETHERNET_FRAME_SIZE, xBufferWaitDelay );\r
-\r
- if( pxNetworkBuffer != NULL )\r
+ ulReturned = GMAC_OK;\r
+ while( ulReturned == GMAC_OK )\r
{\r
- /* At least one packet has been received. */\r
- ulReturned = gmac_dev_read( &xGMACStruct, pxNetworkBuffer->pucEthernetBuffer, ipTOTAL_ETHERNET_FRAME_SIZE, ( uint32_t * ) &( pxNetworkBuffer->xDataLength ) );\r
- if( ulReturned == GMAC_OK )\r
+ /* Allocate a buffer to hold the data if one is not already held. */\r
+ if( pxNetworkBuffer == NULL )\r
{\r
- #if ipconfigETHERNET_DRIVER_FILTERS_FRAME_TYPES == 1\r
+ pxNetworkBuffer = pxNetworkBufferGet( ipTOTAL_ETHERNET_FRAME_SIZE, xBufferWaitDelay );\r
+ }\r
+\r
+ if( pxNetworkBuffer != NULL )\r
+ {\r
+ /* Attempt to read data. */\r
+ ulReturned = gmac_dev_read( &xGMACStruct, pxNetworkBuffer->pucEthernetBuffer, ipTOTAL_ETHERNET_FRAME_SIZE, ( uint32_t * ) &( pxNetworkBuffer->xDataLength ) );\r
+\r
+ if( ulReturned == GMAC_OK )\r
{\r
- if( pxNetworkBuffer->xDataLength > 0 )\r
+ #if ipconfigETHERNET_DRIVER_FILTERS_FRAME_TYPES == 1\r
{\r
- /* If the frame would not be processed by the IP stack then\r
- don't even bother sending it to the IP stack. */\r
- if( eConsiderFrameForProcessing( pxNetworkBuffer->pucEthernetBuffer ) != eProcessBuffer )\r
+ if( pxNetworkBuffer->xDataLength > 0 )\r
{\r
- pxNetworkBuffer->xDataLength = 0;\r
+ /* If the frame would not be processed by the IP\r
+ stack then don't even bother sending it to the IP\r
+ stack. */\r
+ if( eConsiderFrameForProcessing( pxNetworkBuffer->pucEthernetBuffer ) != eProcessBuffer )\r
+ {\r
+ pxNetworkBuffer->xDataLength = 0;\r
+ }\r
}\r
}\r
- }\r
- #endif\r
+ #endif\r
\r
- if( pxNetworkBuffer->xDataLength > 0 )\r
- {\r
- /* Store a pointer to the network buffer structure in the\r
- padding space that was left in front of the Ethernet frame.\r
- The pointer is needed to ensure the network buffer structure\r
- can be located when it is time for it to be freed if the\r
- Ethernet frame gets used as a zero copy buffer. */\r
- *( ( xNetworkBufferDescriptor_t ** ) ( ( pxNetworkBuffer->pucEthernetBuffer - ipBUFFER_PADDING ) ) ) = pxNetworkBuffer;\r
-\r
- /* Data was received and stored. Send it to the IP task\r
- for processing. */\r
- xRxEvent.pvData = ( void * ) pxNetworkBuffer;\r
- if( xQueueSendToBack( xNetworkEventQueue, &xRxEvent, ( TickType_t ) 0 ) == pdFALSE )\r
+ if( pxNetworkBuffer->xDataLength > 0 )\r
{\r
- /* The buffer could not be sent to the IP task so the\r
- buffer must be released. */\r
- vNetworkBufferRelease( pxNetworkBuffer );\r
- iptraceETHERNET_RX_EVENT_LOST();\r
+ /* Store a pointer to the network buffer structure in\r
+ the padding space that was left in front of the Ethernet\r
+ frame. The pointer is needed to ensure the network\r
+ buffer structure can be located when it is time for it\r
+ to be freed if the Ethernet frame gets used as a zero\r
+ copy buffer. */\r
+ *( ( xNetworkBufferDescriptor_t ** ) ( ( pxNetworkBuffer->pucEthernetBuffer - ipBUFFER_PADDING ) ) ) = pxNetworkBuffer;\r
+\r
+ /* Data was received and stored. Send it to the IP task\r
+ for processing. */\r
+ xRxEvent.pvData = ( void * ) pxNetworkBuffer;\r
+ if( xQueueSendToBack( xNetworkEventQueue, &xRxEvent, ( TickType_t ) 0 ) == pdFALSE )\r
+ {\r
+ /* The buffer could not be sent to the IP task. The\r
+ frame will be dropped and the buffer reused. */\r
+ iptraceETHERNET_RX_EVENT_LOST();\r
+ }\r
+ else\r
+ {\r
+ iptraceNETWORK_INTERFACE_RECEIVE();\r
+\r
+ /* The buffer is not owned by the IP task - a new\r
+ buffer is needed the next time around. */\r
+ pxNetworkBuffer = NULL;\r
+ }\r
}\r
else\r
{\r
- iptraceNETWORK_INTERFACE_RECEIVE();\r
+ /* The buffer does not contain any data so there is no\r
+ point sending it to the IP task. Re-use the buffer on\r
+ the next loop. */\r
+ iptraceETHERNET_RX_EVENT_LOST();\r
}\r
}\r
else\r
{\r
- /* The buffer does not contain any data so there is no\r
- point sending it to the IP task. Just release it. */\r
- vNetworkBufferRelease( pxNetworkBuffer );\r
- iptraceETHERNET_RX_EVENT_LOST();\r
+ /* No data was received, keep the buffer for re-use. The\r
+ loop will exit as ulReturn is not GMAC_OK. */\r
}\r
}\r
else\r
{\r
- vNetworkBufferRelease( pxNetworkBuffer );\r
- iptraceETHERNET_RX_EVENT_LOST();\r
+ /* Left a frame in the driver as a buffer was not available.\r
+ Break out of loop. */\r
+ ulReturned = GMAC_INVALID;\r
}\r
}\r
- else\r
- {\r
- /* Left a frame in the driver as a buffer was not available. */\r
- gmac_dev_reset( &xGMACStruct );\r
- }\r
}\r
}\r
/*-----------------------------------------------------------*/\r