]> git.sur5r.net Git - i3/i3/blobdiff - i3bar/src/xcb.c
i3bar: add binding indicator width to workspace buttons width
[i3/i3] / i3bar / src / xcb.c
index b263e3923a23ee46a6a9606322fc1475c690cbcd..79ac211d39d717827d33b3c33221a9fbc00cf38f 100644 (file)
@@ -8,6 +8,7 @@
  *
  */
 #include <xcb/xcb.h>
+#include <xcb/xkb.h>
 #include <xcb/xproto.h>
 #include <xcb/xcb_aux.h>
 
 
 /* We save the Atoms in an easy to access array, indexed by an enum */
 enum {
-    #define ATOM_DO(name) name,
-    #include "xcb_atoms.def"
+#define ATOM_DO(name) name,
+#include "xcb_atoms.def"
     NUM_ATOMS
 };
 
 xcb_intern_atom_cookie_t atom_cookies[NUM_ATOMS];
-xcb_atom_t               atoms[NUM_ATOMS];
+xcb_atom_t atoms[NUM_ATOMS];
 
 /* Variables, that are the same for all functions at all times */
 xcb_connection_t *xcb_connection;
-int              screen;
-xcb_screen_t     *root_screen;
-xcb_window_t     xcb_root;
+int screen;
+xcb_screen_t *root_screen;
+xcb_window_t xcb_root;
 
 /* selection window for tray support */
 static xcb_window_t selwin = XCB_NONE;
@@ -63,22 +64,21 @@ static i3Font font;
 int bar_height;
 
 /* These are only relevant for XKB, which we only need for grabbing modifiers */
-Display          *xkb_dpy;
-int              xkb_event_base;
-int              mod_pressed = 0;
+int xkb_base;
+int mod_pressed = 0;
 
 /* Because the statusline is the same on all outputs, we have
  * global buffer to render it on */
-xcb_gcontext_t   statusline_ctx;
-xcb_gcontext_t   statusline_clear;
-xcb_pixmap_t     statusline_pm;
-uint32_t         statusline_width;
+xcb_gcontext_t statusline_ctx;
+xcb_gcontext_t statusline_clear;
+xcb_pixmap_t statusline_pm;
+uint32_t statusline_width;
 
 /* Event-Watchers, to interact with the user */
 ev_prepare *xcb_prep;
-ev_check   *xcb_chk;
-ev_io      *xcb_io;
-ev_io      *xkb_io;
+ev_check *xcb_chk;
+ev_io *xcb_io;
+ev_io *xkb_io;
 
 /* The name of current binding mode */
 static mode binding;
@@ -117,6 +117,12 @@ int _xcb_request_failed(xcb_void_cookie_t cookie, char *err_msg, int line) {
     return 0;
 }
 
+uint32_t get_sep_offset(struct status_block *block) {
+    if (!block->no_separator && block->sep_block_width > 0)
+        return block->sep_block_width / 2 + block->sep_block_width % 2;
+    return 0;
+}
+
 /*
  * Redraws the statusline to the buffer
  *
@@ -148,15 +154,15 @@ void refresh_statusline(void) {
                     block->x_offset = padding_width;
                     break;
                 case ALIGN_CENTER:
-                    block->x_offset = padding_width / logical_px(2);
-                    block->x_append = padding_width / logical_px(2) + padding_width % logical_px(2);
+                    block->x_offset = padding_width / 2;
+                    block->x_append = padding_width / 2 + padding_width % 2;
                     break;
             }
         }
 
         /* If this is not the last block, add some pixels for a separator. */
         if (TAILQ_NEXT(block, blocks) != NULL)
-            block->width += block->sep_block_width;
+            statusline_width += block->sep_block_width;
 
         statusline_width += block->width + block->x_offset + block->x_append;
     }
@@ -168,7 +174,7 @@ void refresh_statusline(void) {
         realloc_sl_buffer();
 
     /* Clear the statusline pixmap. */
-    xcb_rectangle_t rect = { 0, 0, root_screen->width_in_pixels, font.height + logical_px(5) };
+    xcb_rectangle_t rect = {0, 0, MAX(root_screen->width_in_pixels, statusline_width), bar_height};
     xcb_poly_fill_rectangle(xcb_connection, statusline_pm, statusline_clear, 1, &rect);
 
     /* Draw the text of each block. */
@@ -176,22 +182,41 @@ void refresh_statusline(void) {
     TAILQ_FOREACH(block, &statusline_head, blocks) {
         if (i3string_get_num_bytes(block->full_text) == 0)
             continue;
+        uint32_t fg_color;
+
+        /* If this block is urgent, draw it with the defined color and border. */
+        if (block->urgent) {
+            fg_color = colors.urgent_ws_fg;
+
+            uint32_t mask = XCB_GC_FOREGROUND | XCB_GC_BACKGROUND;
 
-        uint32_t colorpixel = (block->color ? get_colorpixel(block->color) : colors.bar_fg);
-        set_font_colors(statusline_ctx, colorpixel, colors.bar_bg);
-        draw_text(block->full_text, statusline_pm, statusline_ctx, x + block->x_offset, 1, block->width);
-        x += block->width + block->x_offset + block->x_append;
+            /* Draw the background */
+            uint32_t bg_color = colors.urgent_ws_bg;
+            uint32_t bg_values[] = {bg_color, bg_color};
+            xcb_change_gc(xcb_connection, statusline_ctx, mask, bg_values);
+
+            /* The urgent background “overshoots” by 2 px so that the text that
+             * is printed onto it will not be look so cut off. */
+            xcb_rectangle_t bg_rect = {x - logical_px(2), logical_px(1), block->width + logical_px(4), bar_height - logical_px(2)};
+            xcb_poly_fill_rectangle(xcb_connection, statusline_pm, statusline_ctx, 1, &bg_rect);
+        } else {
+            fg_color = (block->color ? get_colorpixel(block->color) : colors.bar_fg);
+        }
+
+        set_font_colors(statusline_ctx, fg_color, colors.bar_bg);
+        draw_text(block->full_text, statusline_pm, statusline_ctx, x + block->x_offset, 3, block->width);
+        x += block->width + block->sep_block_width + block->x_offset + block->x_append;
 
-        if (TAILQ_NEXT(block, blocks) != NULL && !block->no_separator && block->sep_block_width > 0) {
+        uint32_t sep_offset = get_sep_offset(block);
+        if (TAILQ_NEXT(block, blocks) != NULL && sep_offset > 0) {
             /* This is not the last block, draw a separator. */
-            uint32_t sep_offset = block->sep_block_width/2 + block->sep_block_width % 2;
             uint32_t mask = XCB_GC_FOREGROUND | XCB_GC_BACKGROUND | XCB_GC_LINE_WIDTH;
-            uint32_t values[] = { colors.sep_fg, colors.bar_bg, logical_px(1) };
+            uint32_t values[] = {colors.sep_fg, colors.bar_bg, logical_px(1)};
             xcb_change_gc(xcb_connection, statusline_ctx, mask, values);
             xcb_poly_line(xcb_connection, XCB_COORD_MODE_ORIGIN, statusline_pm,
                           statusline_ctx, 2,
-                          (xcb_point_t[]){ { x - sep_offset, 2 },
-                                           { x - sep_offset, font.height - 2 } });
+                          (xcb_point_t[]){{x - sep_offset, logical_px(4)},
+                                          {x - sep_offset, bar_height - logical_px(4)}});
         }
     }
 }
@@ -224,10 +249,10 @@ void unhide_bars(void) {
         return;
     }
 
-    i3_output           *walk;
-    xcb_void_cookie_t   cookie;
-    uint32_t            mask;
-    uint32_t            values[5];
+    i3_output *walk;
+    xcb_void_cookie_t cookie;
+    uint32_t mask;
+    uint32_t values[5];
 
     cont_child();
 
@@ -243,7 +268,8 @@ void unhide_bars(void) {
         values[0] = walk->rect.x;
         if (config.position == POS_TOP)
             values[1] = walk->rect.y;
-        else values[1] = walk->rect.y + walk->rect.h - bar_height;
+        else
+            values[1] = walk->rect.y + walk->rect.h - bar_height;
         values[2] = walk->rect.w;
         values[3] = bar_height;
         values[4] = XCB_STACK_MODE_ABOVE;
@@ -265,10 +291,10 @@ void unhide_bars(void) {
  *
  */
 void init_colors(const struct xcb_color_strings_t *new_colors) {
-#define PARSE_COLOR(name, def) \
-    do { \
+#define PARSE_COLOR(name, def)                                                   \
+    do {                                                                         \
         colors.name = get_colorpixel(new_colors->name ? new_colors->name : def); \
-    } while  (0)
+    } while (0)
     PARSE_COLOR(bar_fg, "#FFFFFF");
     PARSE_COLOR(bar_bg, "#000000");
     PARSE_COLOR(sep_fg, "#666666");
@@ -313,18 +339,6 @@ void handle_button(xcb_button_press_event_t *event) {
         return;
     }
 
-    /* TODO: Move this to extern get_ws_for_output() */
-    TAILQ_FOREACH(cur_ws, walk->workspaces, tailq) {
-        if (cur_ws->visible) {
-            break;
-        }
-    }
-
-    if (cur_ws == NULL) {
-        DLOG("No Workspace active?\n");
-        return;
-    }
-
     int32_t x = event->event_x >= 0 ? event->event_x : 0;
     int32_t original_x = x;
 
@@ -340,35 +354,63 @@ void handle_button(xcb_button_press_event_t *event) {
         TAILQ_FOREACH_REVERSE(trayclient, walk->trayclients, tc_head, tailq) {
             if (!trayclient->mapped)
                 continue;
-            tray_width += (font.height + 2);
+            tray_width += (font.height + logical_px(2));
         }
+        if (tray_width > 0)
+            tray_width += logical_px(2);
 
         int block_x = 0, last_block_x;
-        int offset = (walk->rect.w - (statusline_width + tray_width)) - 10;
+        int offset = walk->rect.w - statusline_width - tray_width - logical_px(4);
 
         x = original_x - offset;
         if (x >= 0) {
             struct status_block *block;
+            int sep_offset_remainder = 0;
 
             TAILQ_FOREACH(block, &statusline_head, blocks) {
+                if (i3string_get_num_bytes(block->full_text) == 0)
+                    continue;
+
                 last_block_x = block_x;
-                block_x += block->width + block->x_offset + block->x_append;
+                block_x += block->width + block->x_offset + block->x_append + get_sep_offset(block) + sep_offset_remainder;
 
                 if (x <= block_x && x >= last_block_x) {
                     send_block_clicked(event->detail, block->name, block->instance, event->root_x, event->root_y);
                     return;
                 }
+
+                sep_offset_remainder = block->sep_block_width - get_sep_offset(block);
             }
         }
         x = original_x;
     }
 
+    /* TODO: Move this to extern get_ws_for_output() */
+    TAILQ_FOREACH(cur_ws, walk->workspaces, tailq) {
+        if (cur_ws->visible) {
+            break;
+        }
+    }
+
+    if (cur_ws == NULL) {
+        DLOG("No Workspace active?\n");
+        return;
+    }
+
     switch (event->detail) {
         case 4:
             /* Mouse wheel up. We select the previous ws, if any.
              * If there is no more workspace, don’t even send the workspace
              * command, otherwise (with workspace auto_back_and_forth) we’d end
              * up on the wrong workspace. */
+
+            /* If `wheel_up_cmd [COMMAND]` was specified, it should override
+             * the default behavior */
+            if (config.wheel_up_cmd) {
+                i3_send_msg(I3_IPC_MESSAGE_TYPE_COMMAND, config.wheel_up_cmd);
+                return;
+            }
+
             if (cur_ws == TAILQ_FIRST(walk->workspaces))
                 return;
 
@@ -379,6 +421,14 @@ void handle_button(xcb_button_press_event_t *event) {
              * If there is no more workspace, don’t even send the workspace
              * command, otherwise (with workspace auto_back_and_forth) we’d end
              * up on the wrong workspace. */
+
+            /* if `wheel_down_cmd [COMMAND]` was specified, it should override
+             * the default behavior */
+            if (config.wheel_down_cmd) {
+                i3_send_msg(I3_IPC_MESSAGE_TYPE_COMMAND, config.wheel_down_cmd);
+                return;
+            }
+
             if (cur_ws == TAILQ_LAST(walk->workspaces, ws_head))
                 return;
 
@@ -388,13 +438,25 @@ void handle_button(xcb_button_press_event_t *event) {
             /* Check if this event regards a workspace button */
             TAILQ_FOREACH(cur_ws, walk->workspaces, tailq) {
                 DLOG("x = %d\n", x);
-                if (x >= 0 && x < cur_ws->name_width + 10) {
+                if (x >= 0 && x < cur_ws->name_width + logical_px(10)) {
                     break;
                 }
-                x -= cur_ws->name_width + 11;
+                x -= cur_ws->name_width + logical_px(11);
             }
+
+            /* Otherwise, focus our currently visible workspace if it is not
+             * already focused */
+            if (cur_ws == NULL) {
+                TAILQ_FOREACH(cur_ws, walk->workspaces, tailq) {
+                    if (cur_ws->visible && !cur_ws->focused)
+                        break;
+                }
+            }
+
+            /* if there is nothing to focus, we are done */
             if (cur_ws == NULL)
                 return;
+
             break;
         default:
             return;
@@ -406,7 +468,7 @@ void handle_button(xcb_button_press_event_t *event) {
      * buffer, then we copy character by character. */
     int num_quotes = 0;
     size_t namelen = 0;
-    const char *utf8_name = i3string_as_utf8(cur_ws->name);
+    const char *utf8_name = cur_ws->canonical_name;
     for (const char *walk = utf8_name; *walk != '\0'; walk++) {
         if (*walk == '"')
             num_quotes++;
@@ -416,7 +478,7 @@ void handle_button(xcb_button_press_event_t *event) {
     }
 
     const size_t len = namelen + strlen("workspace \"\"") + 1;
-    char *buffer = scalloc(len+num_quotes);
+    char *buffer = scalloc(len + num_quotes);
     strncpy(buffer, "workspace \"", strlen("workspace \""));
     size_t inpos, outpos;
     for (inpos = 0, outpos = strlen("workspace \"");
@@ -433,6 +495,39 @@ void handle_button(xcb_button_press_event_t *event) {
     free(buffer);
 }
 
+/*
+ * Handle visibility notifications: when none of the bars are visible, e.g.
+ * if windows are in full-screen on each output, suspend the child process.
+ *
+ */
+static void handle_visibility_notify(xcb_visibility_notify_event_t *event) {
+    bool visible = (event->state != XCB_VISIBILITY_FULLY_OBSCURED);
+    int num_visible = 0;
+    i3_output *output;
+
+    SLIST_FOREACH(output, outputs, slist) {
+        if (!output->active) {
+            continue;
+        }
+        if (output->bar == event->window) {
+            if (output->visible == visible) {
+                return;
+            }
+            output->visible = visible;
+        }
+        num_visible += output->visible;
+    }
+
+    if (num_visible == 0) {
+        stop_child();
+    } else if (num_visible == visible) {
+        /* Wake the child only when transitioning from 0 to 1 visible bar.
+         * We cannot transition from 0 to 2 or more visible bars at once since
+         * visibility events are delivered to each window separately */
+        cont_child();
+    }
+}
+
 /*
  * Adjusts the size of the tray window and alignment of the tray clients by
  * configuring their respective x coordinates. To be called when mapping or
@@ -453,8 +548,8 @@ static void configure_trayclients(void) {
             clients++;
 
             DLOG("Configuring tray window %08x to x=%d\n",
-                 trayclient->win, output->rect.w - (clients * (font.height + 2)));
-            uint32_t x = output->rect.w - (clients * (font.height + 2));
+                 trayclient->win, output->rect.w - (clients * (font.height + logical_px(2))));
+            uint32_t x = output->rect.w - (clients * (font.height + logical_px(2)));
             xcb_configure_window(xcb_connection,
                                  trayclient->win,
                                  XCB_CONFIG_WINDOW_X,
@@ -470,7 +565,7 @@ static void configure_trayclients(void) {
  * supported client messages currently are _NET_SYSTEM_TRAY_OPCODE.
  *
  */
-static void handle_client_message(xcb_client_message_event_tevent) {
+static void handle_client_message(xcb_client_message_event_t *event) {
     if (event->type == atoms[_NET_SYSTEM_TRAY_OPCODE] &&
         event->format == 32) {
         DLOG("_NET_SYSTEM_TRAY_OPCODE received\n");
@@ -594,7 +689,7 @@ static void handle_client_message(xcb_client_message_event_t* event) {
                            0,
                            client,
                            XCB_EVENT_MASK_NO_EVENT,
-                           (char*)ev);
+                           (char *)ev);
             free(event);
 
             /* Put the client inside the save set. Upon termination (whether
@@ -633,7 +728,7 @@ static void handle_client_message(xcb_client_message_event_t* event) {
  * See: http://standards.freedesktop.org/xembed-spec/xembed-spec-latest.html
  *
  */
-static void handle_destroy_notify(xcb_destroy_notify_event_tevent) {
+static void handle_destroy_notify(xcb_destroy_notify_event_t *event) {
     DLOG("DestroyNotify for window = %08x, event = %08x\n", event->window, event->event);
 
     i3_output *walk;
@@ -662,7 +757,7 @@ static void handle_destroy_notify(xcb_destroy_notify_event_t* event) {
  * window. We respond by realigning the tray clients.
  *
  */
-static void handle_map_notify(xcb_map_notify_event_tevent) {
+static void handle_map_notify(xcb_map_notify_event_t *event) {
     DLOG("MapNotify for window = %08x, event = %08x\n", event->window, event->event);
 
     i3_output *walk;
@@ -690,7 +785,7 @@ static void handle_map_notify(xcb_map_notify_event_t* event) {
  * window. We respond by realigning the tray clients.
  *
  */
-static void handle_unmap_notify(xcb_unmap_notify_event_tevent) {
+static void handle_unmap_notify(xcb_unmap_notify_event_t *event) {
     DLOG("UnmapNotify for window = %08x, event = %08x\n", event->window, event->event);
 
     i3_output *walk;
@@ -841,38 +936,97 @@ void xcb_chk_cb(struct ev_loop *loop, ev_check *watcher, int revents) {
     }
 
     while ((event = xcb_poll_for_event(xcb_connection)) != NULL) {
-        switch (event->response_type & ~0x80) {
+        int type = (event->response_type & ~0x80);
+
+        if (type == xkb_base && xkb_base > -1) {
+            DLOG("received an xkb event\n");
+
+            xcb_xkb_state_notify_event_t *state = (xcb_xkb_state_notify_event_t *)event;
+            if (state->xkbType == XCB_XKB_STATE_NOTIFY) {
+                int modstate = state->mods & config.modifier;
+
+#define DLOGMOD(modmask, status)                        \
+    do {                                                \
+        switch (modmask) {                              \
+            case ShiftMask:                             \
+                DLOG("ShiftMask got " #status "!\n");   \
+                break;                                  \
+            case ControlMask:                           \
+                DLOG("ControlMask got " #status "!\n"); \
+                break;                                  \
+            case Mod1Mask:                              \
+                DLOG("Mod1Mask got " #status "!\n");    \
+                break;                                  \
+            case Mod2Mask:                              \
+                DLOG("Mod2Mask got " #status "!\n");    \
+                break;                                  \
+            case Mod3Mask:                              \
+                DLOG("Mod3Mask got " #status "!\n");    \
+                break;                                  \
+            case Mod4Mask:                              \
+                DLOG("Mod4Mask got " #status "!\n");    \
+                break;                                  \
+            case Mod5Mask:                              \
+                DLOG("Mod5Mask got " #status "!\n");    \
+                break;                                  \
+        }                                               \
+    } while (0)
+
+                if (modstate != mod_pressed) {
+                    if (modstate == 0) {
+                        DLOGMOD(config.modifier, released);
+                        if (!activated_mode)
+                            hide_bars();
+                    } else {
+                        DLOGMOD(config.modifier, pressed);
+                        activated_mode = false;
+                        unhide_bars();
+                    }
+                    mod_pressed = modstate;
+                }
+#undef DLOGMOD
+            }
+
+            free(event);
+            continue;
+        }
+
+        switch (type) {
+            case XCB_VISIBILITY_NOTIFY:
+                /* Visibility change: a bar is [un]obscured by other window */
+                handle_visibility_notify((xcb_visibility_notify_event_t *)event);
+                break;
             case XCB_EXPOSE:
                 /* Expose-events happen, when the window needs to be redrawn */
                 redraw_bars();
                 break;
             case XCB_BUTTON_PRESS:
                 /* Button-press-events are mouse-buttons clicked on one of our bars */
-                handle_button((xcb_button_press_event_t*) event);
+                handle_button((xcb_button_press_event_t *)event);
                 break;
             case XCB_CLIENT_MESSAGE:
                 /* Client messages are used for client-to-client communication, for
                  * example system tray widgets talk to us directly via client messages. */
-                handle_client_message((xcb_client_message_event_t*) event);
+                handle_client_message((xcb_client_message_event_t *)event);
                 break;
             case XCB_DESTROY_NOTIFY:
                 /* DestroyNotify signifies the end of the XEmbed protocol */
-                handle_destroy_notify((xcb_destroy_notify_event_t*) event);
+                handle_destroy_notify((xcb_destroy_notify_event_t *)event);
                 break;
             case XCB_UNMAP_NOTIFY:
                 /* UnmapNotify is received when a tray client hides its window. */
-                handle_unmap_notify((xcb_unmap_notify_event_t*) event);
+                handle_unmap_notify((xcb_unmap_notify_event_t *)event);
                 break;
             case XCB_MAP_NOTIFY:
-                handle_map_notify((xcb_map_notify_event_t*) event);
+                handle_map_notify((xcb_map_notify_event_t *)event);
                 break;
             case XCB_PROPERTY_NOTIFY:
                 /* PropertyNotify */
-                handle_property_notify((xcb_property_notify_event_t*) event);
+                handle_property_notify((xcb_property_notify_event_t *)event);
                 break;
             case XCB_CONFIGURE_REQUEST:
                 /* ConfigureRequest, sent by a tray child */
-                handle_configure_request((xcb_configure_request_event_t*) event);
+                handle_configure_request((xcb_configure_request_event_t *)event);
                 break;
         }
         free(event);
@@ -887,76 +1041,6 @@ void xcb_chk_cb(struct ev_loop *loop, ev_check *watcher, int revents) {
 void xcb_io_cb(struct ev_loop *loop, ev_io *watcher, int revents) {
 }
 
-/*
- * We need to bind to the modifier per XKB. Sadly, XCB does not implement this
- *
- */
-void xkb_io_cb(struct ev_loop *loop, ev_io *watcher, int revents) {
-    XkbEvent ev;
-    int modstate = 0;
-
-    DLOG("Got XKB-Event!\n");
-
-    while (XPending(xkb_dpy)) {
-        XNextEvent(xkb_dpy, (XEvent*)&ev);
-
-        if (ev.type != xkb_event_base) {
-            ELOG("No Xkb-Event!\n");
-            continue;
-        }
-
-        if (ev.any.xkb_type != XkbStateNotify) {
-            ELOG("No State Notify!\n");
-            continue;
-        }
-
-        unsigned int mods = ev.state.mods;
-        modstate = mods & config.modifier;
-    }
-
-#define DLOGMOD(modmask, status) \
-    do { \
-        switch (modmask) { \
-            case ShiftMask: \
-                DLOG("ShiftMask got " #status "!\n"); \
-                break; \
-            case ControlMask: \
-                DLOG("ControlMask got " #status "!\n"); \
-                break; \
-            case Mod1Mask: \
-                DLOG("Mod1Mask got " #status "!\n"); \
-                break; \
-            case Mod2Mask: \
-                DLOG("Mod2Mask got " #status "!\n"); \
-                break; \
-            case Mod3Mask: \
-                DLOG("Mod3Mask got " #status "!\n"); \
-                break; \
-            case Mod4Mask: \
-                DLOG("Mod4Mask got " #status "!\n"); \
-                break; \
-            case Mod5Mask: \
-                DLOG("Mod5Mask got " #status "!\n"); \
-                break; \
-        } \
-    } while (0)
-
-    if (modstate != mod_pressed) {
-        if (modstate == 0) {
-            DLOGMOD(config.modifier, released);
-            if (!activated_mode)
-                hide_bars();
-        } else {
-            DLOGMOD(config.modifier, pressed);
-            activated_mode = false;
-            unhide_bars();
-        }
-        mod_pressed = modstate;
-    }
-
-#undef DLOGMOD
-}
-
 /*
  * Early initialization of the connection to X11: Everything which does not
  * depend on 'config'.
@@ -972,9 +1056,9 @@ char *init_xcb_early() {
     conn = xcb_connection;
     DLOG("Connected to xcb\n");
 
-    /* We have to request the atoms we need */
-    #define ATOM_DO(name) atom_cookies[name] = xcb_intern_atom(xcb_connection, 0, strlen(#name), #name);
-    #include "xcb_atoms.def"
+/* We have to request the atoms we need */
+#define ATOM_DO(name) atom_cookies[name] = xcb_intern_atom(xcb_connection, 0, strlen(#name), #name);
+#include "xcb_atoms.def"
 
     root_screen = xcb_aux_get_screen(xcb_connection, screen);
     xcb_root = root_screen->root;
@@ -982,7 +1066,7 @@ char *init_xcb_early() {
     /* We draw the statusline to a seperate pixmap, because it looks the same on all bars and
      * this way, we can choose to crop it */
     uint32_t mask = XCB_GC_FOREGROUND;
-    uint32_t vals[] = { colors.bar_bg, colors.bar_bg };
+    uint32_t vals[] = {colors.bar_bg, colors.bar_bg};
 
     statusline_clear = xcb_generate_id(xcb_connection);
     xcb_void_cookie_t clear_ctx_cookie = xcb_create_gc_checked(xcb_connection,
@@ -1006,7 +1090,6 @@ char *init_xcb_early() {
                                                                root_screen->width_in_pixels,
                                                                root_screen->height_in_pixels);
 
-
     /* The various Watchers to communicate with xcb */
     xcb_io = smalloc(sizeof(ev_io));
     xcb_prep = smalloc(sizeof(ev_prepare));
@@ -1041,44 +1124,23 @@ char *init_xcb_early() {
  *
  */
 void register_xkb_keyevents() {
-    if (xkb_dpy == NULL) {
-        int xkb_major, xkb_minor, xkb_errbase, xkb_err;
-        xkb_major = XkbMajorVersion;
-        xkb_minor = XkbMinorVersion;
-
-        xkb_dpy = XkbOpenDisplay(NULL,
-                                 &xkb_event_base,
-                                 &xkb_errbase,
-                                 &xkb_major,
-                                 &xkb_minor,
-                                 &xkb_err);
-
-        if (xkb_dpy == NULL) {
-            ELOG("No XKB!\n");
-            exit(EXIT_FAILURE);
-        }
-
-        if (fcntl(ConnectionNumber(xkb_dpy), F_SETFD, FD_CLOEXEC) == -1) {
-            ELOG("Could not set FD_CLOEXEC on xkbdpy: %s\n", strerror(errno));
-            exit(EXIT_FAILURE);
-        }
-
-        int i1;
-        if (!XkbQueryExtension(xkb_dpy, &i1, &xkb_event_base, &xkb_errbase, &xkb_major, &xkb_minor)) {
-            ELOG("XKB not supported by X-server!\n");
-            exit(EXIT_FAILURE);
-        }
-
-        if (!XkbSelectEvents(xkb_dpy, XkbUseCoreKbd, XkbStateNotifyMask, XkbStateNotifyMask)) {
-            ELOG("Could not grab Key!\n");
-            exit(EXIT_FAILURE);
-        }
-
-        xkb_io = smalloc(sizeof(ev_io));
-        ev_io_init(xkb_io, &xkb_io_cb, ConnectionNumber(xkb_dpy), EV_READ);
-        ev_io_start(main_loop, xkb_io);
-        XFlush(xkb_dpy);
+    const xcb_query_extension_reply_t *extreply;
+    extreply = xcb_get_extension_data(conn, &xcb_xkb_id);
+    if (!extreply->present) {
+        ELOG("xkb is not present on this server\n");
+        exit(EXIT_FAILURE);
     }
+    DLOG("initializing xcb-xkb\n");
+    xcb_xkb_use_extension(conn, XCB_XKB_MAJOR_VERSION, XCB_XKB_MINOR_VERSION);
+    xcb_xkb_select_events(conn,
+                          XCB_XKB_ID_USE_CORE_KBD,
+                          XCB_XKB_EVENT_TYPE_STATE_NOTIFY,
+                          0,
+                          XCB_XKB_EVENT_TYPE_STATE_NOTIFY,
+                          0xff,
+                          0xff,
+                          NULL);
+    xkb_base = extreply->first_event;
 }
 
 /*
@@ -1086,13 +1148,14 @@ void register_xkb_keyevents() {
  *
  */
 void deregister_xkb_keyevents() {
-    if (xkb_dpy != NULL) {
-        ev_io_stop (main_loop, xkb_io);
-        XCloseDisplay(xkb_dpy);
-        close(xkb_io->fd);
-        FREE(xkb_io);
-        xkb_dpy = NULL;
-    }
+    xcb_xkb_select_events(conn,
+                          XCB_XKB_ID_USE_CORE_KBD,
+                          0,
+                          0,
+                          0,
+                          0xff,
+                          0xff,
+                          NULL);
 }
 
 /*
@@ -1122,8 +1185,8 @@ void init_xcb_late(char *fontname) {
  *
  */
 static void send_tray_clientmessage(void) {
-    uint8_t buffer[32] = { 0 };
-    xcb_client_message_event_t *ev = (xcb_client_message_event_t*)buffer;
+    uint8_t buffer[32] = {0};
+    xcb_client_message_event_t *ev = (xcb_client_message_event_t *)buffer;
 
     ev->response_type = XCB_CLIENT_MESSAGE;
     ev->window = xcb_root;
@@ -1137,10 +1200,9 @@ static void send_tray_clientmessage(void) {
                    0,
                    xcb_root,
                    0xFFFFFF,
-                   (char*)buffer);
+                   (char *)buffer);
 }
 
-
 /*
  * Initializes tray support by requesting the appropriate _NET_SYSTEM_TRAY atom
  * for the X11 display we are running on, then acquiring the selection for this
@@ -1159,7 +1221,7 @@ void init_tray(void) {
     /* tray support: we need a window to own the selection */
     selwin = xcb_generate_id(xcb_connection);
     uint32_t selmask = XCB_CW_OVERRIDE_REDIRECT;
-    uint32_t selval[] = { 1 };
+    uint32_t selval[] = {1};
     xcb_create_window(xcb_connection,
                       root_screen->root_depth,
                       selwin,
@@ -1208,8 +1270,9 @@ void init_tray(void) {
     }
 
     if (selreply->owner != selwin) {
-        ELOG("Could not set the %s selection. " \
-             "Maybe another tray is already running?\n", atomname);
+        ELOG("Could not set the %s selection. "
+             "Maybe another tray is already running?\n",
+             atomname);
         /* NOTE that this error is not fatal. We just can’t provide tray
          * functionality */
         free(selreply);
@@ -1278,6 +1341,7 @@ void clean_xcb(void) {
     FREE(outputs);
 
     xcb_flush(xcb_connection);
+    xcb_aux_sync(xcb_connection);
     xcb_disconnect(xcb_connection);
 
     ev_check_stop(main_loop, xcb_chk);
@@ -1295,15 +1359,16 @@ void clean_xcb(void) {
  */
 void get_atoms(void) {
     xcb_intern_atom_reply_t *reply;
-    #define ATOM_DO(name) reply = xcb_intern_atom_reply(xcb_connection, atom_cookies[name], NULL); \
-        if (reply == NULL) { \
-            ELOG("Could not get atom %s\n", #name); \
-            exit(EXIT_FAILURE); \
-        } \
-        atoms[name] = reply->atom; \
-        free(reply);
-
-    #include "xcb_atoms.def"
+#define ATOM_DO(name)                                                        \
+    reply = xcb_intern_atom_reply(xcb_connection, atom_cookies[name], NULL); \
+    if (reply == NULL) {                                                     \
+        ELOG("Could not get atom %s\n", #name);                              \
+        exit(EXIT_FAILURE);                                                  \
+    }                                                                        \
+    atoms[name] = reply->atom;                                               \
+    free(reply);
+
+#include "xcb_atoms.def"
     DLOG("Got Atoms\n");
 }
 
@@ -1339,14 +1404,14 @@ void kick_tray_clients(i3_output *output) {
     /* Fake a DestroyNotify so that Qt re-adds tray icons.
      * We cannot actually destroy the window because then Qt will not restore
      * its event mask on the new window. */
-    uint8_t buffer[32] = { 0 };
-    xcb_destroy_notify_event_t *event = (xcb_destroy_notify_event_t*)buffer;
+    uint8_t buffer[32] = {0};
+    xcb_destroy_notify_event_t *event = (xcb_destroy_notify_event_t *)buffer;
 
     event->response_type = XCB_DESTROY_NOTIFY;
     event->event = selwin;
     event->window = selwin;
 
-    xcb_send_event(conn, false, selwin, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (char*)event);
+    xcb_send_event(conn, false, selwin, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (char *)event);
 
     send_tray_clientmessage();
 }
@@ -1385,7 +1450,7 @@ void realloc_sl_buffer(void) {
                                                                bar_height);
 
     uint32_t mask = XCB_GC_FOREGROUND;
-    uint32_t vals[2] = { colors.bar_bg, colors.bar_bg };
+    uint32_t vals[2] = {colors.bar_bg, colors.bar_bg};
     xcb_free_gc(xcb_connection, statusline_clear);
     statusline_clear = xcb_generate_id(xcb_connection);
     xcb_void_cookie_t clear_ctx_cookie = xcb_create_gc_checked(xcb_connection,
@@ -1409,7 +1474,6 @@ void realloc_sl_buffer(void) {
         xcb_request_failed(sl_ctx_cookie, "Could not allocate statusline-buffer-context")) {
         exit(EXIT_FAILURE);
     }
-
 }
 
 /*
@@ -1447,9 +1511,13 @@ void reconfig_windows(bool redraw_bars) {
              * BUTTON_PRESS, to handle clicks on the workspace buttons
              * */
             values[2] = XCB_EVENT_MASK_EXPOSURE |
-                        XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT;
-            if (!config.disable_ws) {
-                values[2] |= XCB_EVENT_MASK_BUTTON_PRESS;
+                        XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT |
+                        XCB_EVENT_MASK_BUTTON_PRESS;
+            if (config.hide_on_modifier == M_DOCK) {
+                /* If the bar is normally visible, catch visibility change events to suspend
+                 * the status process when the bar is obscured by full-screened windows.  */
+                values[2] |= XCB_EVENT_MASK_VISIBILITY_CHANGE;
+                walk->visible = true;
             }
             xcb_void_cookie_t win_cookie = xcb_create_window_checked(xcb_connection,
                                                                      root_screen->root_depth,
@@ -1505,7 +1573,7 @@ void reconfig_windows(bool redraw_bars) {
                                                                 XCB_ATOM_ATOM,
                                                                 32,
                                                                 1,
-                                                                (unsigned char*) &atoms[_NET_WM_WINDOW_TYPE_DOCK]);
+                                                                (unsigned char *)&atoms[_NET_WM_WINDOW_TYPE_DOCK]);
 
             /* We need to tell i3, where to reserve space for i3bar */
             /* left, right, top, bottom, left_start_y, left_end_y,
@@ -1566,13 +1634,13 @@ void reconfig_windows(bool redraw_bars) {
                 map_cookie = xcb_map_window_checked(xcb_connection, walk->bar);
             }
 
-            if (xcb_request_failed(win_cookie,   "Could not create window") ||
-                xcb_request_failed(pm_cookie,    "Could not create pixmap") ||
-                xcb_request_failed(dock_cookie,  "Could not set dock mode") ||
-                xcb_request_failed(class_cookie, "Could not set WM_CLASS")  ||
-                xcb_request_failed(name_cookie,  "Could not set WM_NAME")   ||
-                xcb_request_failed(strut_cookie, "Could not set strut")     ||
-                xcb_request_failed(gc_cookie,    "Could not create graphical context") ||
+            if (xcb_request_failed(win_cookie, "Could not create window") ||
+                xcb_request_failed(pm_cookie, "Could not create pixmap") ||
+                xcb_request_failed(dock_cookie, "Could not set dock mode") ||
+                xcb_request_failed(class_cookie, "Could not set WM_CLASS") ||
+                xcb_request_failed(name_cookie, "Could not set WM_NAME") ||
+                xcb_request_failed(strut_cookie, "Could not set strut") ||
+                xcb_request_failed(gc_cookie, "Could not create graphical context") ||
                 ((config.hide_on_modifier == M_DOCK) && xcb_request_failed(map_cookie, "Could not map window"))) {
                 exit(EXIT_FAILURE);
             }
@@ -1586,7 +1654,7 @@ void reconfig_windows(bool redraw_bars) {
                 i3_output *output;
                 SLIST_FOREACH(output, outputs, slist) {
                     if (strcasecmp(output->name, tray_output) == 0 ||
-                            (strcasecmp(tray_output, "primary") == 0 && output->primary)) {
+                        (strcasecmp(tray_output, "primary") == 0 && output->primary)) {
                         init_tray();
                         break;
                     }
@@ -1653,9 +1721,9 @@ void reconfig_windows(bool redraw_bars) {
 
             if (xcb_request_failed(cfg_cookie, "Could not reconfigure window") ||
                 xcb_request_failed(chg_cookie, "Could not change window") ||
-                xcb_request_failed(pm_cookie,  "Could not create pixmap") ||
-                (redraw_bars && (xcb_request_failed(umap_cookie,  "Could not unmap window") ||
-                (config.hide_on_modifier == M_DOCK && xcb_request_failed(map_cookie, "Could not map window"))))) {
+                xcb_request_failed(pm_cookie, "Could not create pixmap") ||
+                (redraw_bars && (xcb_request_failed(umap_cookie, "Could not unmap window") ||
+                                 (config.hide_on_modifier == M_DOCK && xcb_request_failed(map_cookie, "Could not map window"))))) {
                 exit(EXIT_FAILURE);
             }
         }
@@ -1688,41 +1756,13 @@ void draw_bars(bool unhide) {
                       outputs_walk->bargc,
                       XCB_GC_FOREGROUND,
                       &color);
-        xcb_rectangle_t rect = { 0, 0, outputs_walk->rect.w, bar_height };
+        xcb_rectangle_t rect = {0, 0, outputs_walk->rect.w, bar_height};
         xcb_poly_fill_rectangle(xcb_connection,
                                 outputs_walk->buffer,
                                 outputs_walk->bargc,
                                 1,
                                 &rect);
 
-        if (!TAILQ_EMPTY(&statusline_head)) {
-            DLOG("Printing statusline!\n");
-
-            /* Luckily we already prepared a seperate pixmap containing the rendered
-             * statusline, we just have to copy the relevant parts to the relevant
-             * position */
-            trayclient *trayclient;
-            int traypx = 0;
-            TAILQ_FOREACH(trayclient, outputs_walk->trayclients, tailq) {
-                if (!trayclient->mapped)
-                    continue;
-                /* We assume the tray icons are quadratic (we use the font
-                 * *height* as *width* of the icons) because we configured them
-                 * like this. */
-                traypx += font.height + 2;
-            }
-            /* Add 2px of padding if there are any tray icons */
-            if (traypx > 0)
-                traypx += 2;
-            xcb_copy_area(xcb_connection,
-                          statusline_pm,
-                          outputs_walk->buffer,
-                          outputs_walk->bargc,
-                          MAX(0, (int16_t)(statusline_width - outputs_walk->rect.w + 4)), 0,
-                          MAX(0, (int16_t)(outputs_walk->rect.w - statusline_width - traypx - 4)), 3,
-                          MIN(outputs_walk->rect.w - traypx - 4, (int)statusline_width), font.height + 2);
-        }
-
         if (!config.disable_ws) {
             i3_ws *ws_walk;
             TAILQ_FOREACH(ws_walk, outputs_walk->workspaces, tailq) {
@@ -1750,29 +1790,29 @@ void draw_bars(bool unhide) {
                     unhide = true;
                 }
                 uint32_t mask = XCB_GC_FOREGROUND | XCB_GC_BACKGROUND;
-                uint32_t vals_border[] = { border_color, border_color };
+                uint32_t vals_border[] = {border_color, border_color};
                 xcb_change_gc(xcb_connection,
                               outputs_walk->bargc,
                               mask,
                               vals_border);
-                xcb_rectangle_t rect_border = { i,
-                                                logical_px(1),
-                                                ws_walk->name_width + logical_px(10),
-                                                font.height + logical_px(4) };
+                xcb_rectangle_t rect_border = {i,
+                                               logical_px(1),
+                                               ws_walk->name_width + logical_px(10),
+                                               font.height + logical_px(4)};
                 xcb_poly_fill_rectangle(xcb_connection,
                                         outputs_walk->buffer,
                                         outputs_walk->bargc,
                                         1,
                                         &rect_border);
-                uint32_t vals[] = { bg_color, bg_color };
+                uint32_t vals[] = {bg_color, bg_color};
                 xcb_change_gc(xcb_connection,
                               outputs_walk->bargc,
                               mask,
                               vals);
-                xcb_rectangle_t rect = { i + logical_px(1),
-                                         2 * logical_px(1),
-                                         ws_walk->name_width + logical_px(8),
-                                         font.height + logical_px(2) };
+                xcb_rectangle_t rect = {i + logical_px(1),
+                                        2 * logical_px(1),
+                                        ws_walk->name_width + logical_px(8),
+                                        font.height + logical_px(2)};
                 xcb_poly_fill_rectangle(xcb_connection,
                                         outputs_walk->buffer,
                                         outputs_walk->bargc,
@@ -1782,7 +1822,6 @@ void draw_bars(bool unhide) {
                 draw_text(ws_walk->name, outputs_walk->buffer, outputs_walk->bargc,
                           i + logical_px(5), 3 * logical_px(1), ws_walk->name_width);
                 i += logical_px(10) + ws_walk->name_width + logical_px(1);
-
             }
         }
 
@@ -1791,24 +1830,24 @@ void draw_bars(bool unhide) {
             uint32_t bg_color = colors.urgent_ws_bg;
             uint32_t mask = XCB_GC_FOREGROUND | XCB_GC_BACKGROUND;
 
-            uint32_t vals_border[] = { colors.urgent_ws_border, colors.urgent_ws_border };
+            uint32_t vals_border[] = {colors.urgent_ws_border, colors.urgent_ws_border};
             xcb_change_gc(xcb_connection,
                           outputs_walk->bargc,
                           mask,
                           vals_border);
-            xcb_rectangle_t rect_border = { i, 1, binding.width + 10, font.height + 4 };
+            xcb_rectangle_t rect_border = {i, 1, binding.width + 10, font.height + 4};
             xcb_poly_fill_rectangle(xcb_connection,
                                     outputs_walk->buffer,
                                     outputs_walk->bargc,
                                     1,
                                     &rect_border);
 
-            uint32_t vals[] = { bg_color, bg_color };
+            uint32_t vals[] = {bg_color, bg_color};
             xcb_change_gc(xcb_connection,
                           outputs_walk->bargc,
                           mask,
                           vals);
-            xcb_rectangle_t rect = { i + 1, 2, binding.width + 8, font.height + 2 };
+            xcb_rectangle_t rect = {i + 1, 2, binding.width + 8, font.height + 2};
             xcb_poly_fill_rectangle(xcb_connection,
                                     outputs_walk->buffer,
                                     outputs_walk->bargc,
@@ -1819,6 +1858,39 @@ void draw_bars(bool unhide) {
             draw_text(binding.name, outputs_walk->buffer, outputs_walk->bargc, i + 5, 3, binding.width);
 
             unhide = true;
+            i += logical_px(10) + binding.width + logical_px(1);
+        }
+
+        if (!TAILQ_EMPTY(&statusline_head)) {
+            DLOG("Printing statusline!\n");
+
+            /* Luckily we already prepared a seperate pixmap containing the rendered
+             * statusline, we just have to copy the relevant parts to the relevant
+             * position */
+            trayclient *trayclient;
+            int traypx = 0;
+            TAILQ_FOREACH(trayclient, outputs_walk->trayclients, tailq) {
+                if (!trayclient->mapped)
+                    continue;
+                /* We assume the tray icons are quadratic (we use the font
+                 * *height* as *width* of the icons) because we configured them
+                 * like this. */
+                traypx += font.height + logical_px(2);
+            }
+            /* Add 2px of padding if there are any tray icons */
+            if (traypx > 0)
+                traypx += logical_px(2);
+
+            int edge_offset = logical_px(4);
+            int visible_statusline_width = MIN(statusline_width, outputs_walk->rect.w - i - traypx - 2*edge_offset);
+
+            xcb_copy_area(xcb_connection,
+                          statusline_pm,
+                          outputs_walk->buffer,
+                          outputs_walk->bargc,
+                          (int16_t)(statusline_width - visible_statusline_width), 0,
+                          (int16_t)(outputs_walk->rect.w - traypx - edge_offset - visible_statusline_width), 0,
+                          (int16_t)visible_statusline_width, (int16_t)bar_height);
         }
 
         i = 0;
@@ -1826,8 +1898,8 @@ void draw_bars(bool unhide) {
 
     /* Assure the bar is hidden/unhidden according to the specified hidden_state and mode */
     if (mod_pressed ||
-            config.hidden_state == S_SHOW ||
-            unhide) {
+        config.hidden_state == S_SHOW ||
+        unhide) {
         unhide_bars();
     } else if (config.hide_on_modifier == M_HIDE) {
         hide_bars();