]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/cyrus.c
don't leak in case of attribute not found
[openldap] / libraries / libldap / cyrus.c
index 19a7a078862c1b4d89cf6ca8db5a2d9406ece8c7..18c493688c262d9eafc5f5d99a03a18abe223dfe 100644 (file)
@@ -1,7 +1,16 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1999-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2005 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
 #include <ac/time.h>
 #include <ac/errno.h>
 #include <ac/ctype.h>
+#include <ac/unistd.h>
+
+#ifdef HAVE_LIMITS_H
+#include <limits.h>
+#endif
 
 #include "ldap-int.h"
 
 #ifdef HAVE_CYRUS_SASL
 
+#ifdef HAVE_LIMITS_H
+#include <limits.h>
+#endif
+
+#ifndef INT_MAX
+#define        INT_MAX 2147483647      /* 32 bit signed max */
+#endif
+
 #ifdef LDAP_R_COMPILE
 ldap_pvt_thread_mutex_t ldap_int_sasl_mutex;
 #endif
@@ -39,23 +61,23 @@ ldap_pvt_thread_mutex_t ldap_int_sasl_mutex;
 * Various Cyrus SASL related stuff.
 */
 
+static const sasl_callback_t client_callbacks[] = {
+#ifdef SASL_CB_GETREALM
+       { SASL_CB_GETREALM, NULL, NULL },
+#endif
+       { SASL_CB_USER, NULL, NULL },
+       { SASL_CB_AUTHNAME, NULL, NULL },
+       { SASL_CB_PASS, NULL, NULL },
+       { SASL_CB_ECHOPROMPT, NULL, NULL },
+       { SASL_CB_NOECHOPROMPT, NULL, NULL },
+       { SASL_CB_LIST_END, NULL, NULL }
+};
+
 int ldap_int_sasl_init( void )
 {
        /* XXX not threadsafe */
        static int sasl_initialized = 0;
 
-       static sasl_callback_t client_callbacks[] = {
-#ifdef SASL_CB_GETREALM
-               { SASL_CB_GETREALM, NULL, NULL },
-#endif
-               { SASL_CB_USER, NULL, NULL },
-               { SASL_CB_AUTHNAME, NULL, NULL },
-               { SASL_CB_PASS, NULL, NULL },
-               { SASL_CB_ECHOPROMPT, NULL, NULL },
-               { SASL_CB_NOECHOPROMPT, NULL, NULL },
-               { SASL_CB_LIST_END, NULL, NULL }
-       };
-
 #ifdef HAVE_SASL_VERSION
        /* stringify the version number, sasl.h doesn't do it for us */
 #define VSTR0(maj, min, pat)   #maj "." #min "." #pat
@@ -67,20 +89,13 @@ int ldap_int_sasl_init( void )
        if ( ((rc >> 16) != ((SASL_VERSION_MAJOR << 8)|SASL_VERSION_MINOR)) ||
                (rc & 0xffff) < SASL_VERSION_STEP) {
                char version[sizeof("xxx.xxx.xxxxx")];
-               sprintf( version, "%d.%d.%d", rc >> 24, rc >> 16 * 0xff,
+               sprintf( version, "%u.%d.%d", (unsigned)rc >> 24, (rc >> 16) & 0xff,
                        rc & 0xffff );
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( TRANSPORT, INFO,
-               "ldap_int_sasl_init: SASL library version mismatch:"
-               " expected " SASL_VERSION_STRING ","
-               " got %s\n", version, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                "ldap_int_sasl_init: SASL library version mismatch:"
                " expected " SASL_VERSION_STRING ","
                " got %s\n", version, 0, 0 );
-#endif
                return -1;
        }
        }
@@ -104,11 +119,9 @@ int ldap_int_sasl_init( void )
                ldap_pvt_sasl_mutex_lock,
                ldap_pvt_sasl_mutex_unlock,    
                ldap_pvt_sasl_mutex_dispose );    
-
-       ldap_pvt_thread_mutex_init( &ldap_int_sasl_mutex );
 #endif
 
-       if ( sasl_client_init( client_callbacks ) == SASL_OK ) {
+       if ( sasl_client_init( NULL ) == SASL_OK ) {
                sasl_initialized = 1;
                return 0;
        }
@@ -153,7 +166,7 @@ sb_sasl_setup( Sockbuf_IO_Desc *sbiod, void *arg )
        }
        sasl_getprop( p->sasl_context, SASL_MAXOUTBUF,
                (SASL_CONST void **) &p->sasl_maxbuf );
-
+           
        sbiod->sbiod_pvt = p;
 
        return 0;
@@ -184,7 +197,7 @@ sb_sasl_remove( Sockbuf_IO_Desc *sbiod )
 }
 
 static ber_len_t
-sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
+sb_sasl_pkt_length( const unsigned char *buf, int debuglevel )
 {
        ber_len_t               size;
 
@@ -194,7 +207,7 @@ sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
                | buf[1] << 16
                | buf[2] << 8
                | buf[3];
-   
+
        if ( size > SASL_MAX_BUFF_SIZE ) {
                /* somebody is trying to mess me up. */
                ber_log_printf( LDAP_DEBUG_ANY, debuglevel,
@@ -208,7 +221,7 @@ sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
 
 /* Drop a processed packet from the input buffer */
 static void
-sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, unsigned max, int debuglevel )
+sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, int debuglevel )
 {
        ber_slen_t                      len;
 
@@ -219,7 +232,7 @@ sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, unsigned max, int debuglevel )
    
        if ( len >= 4 ) {
                sec_buf_in->buf_end = sb_sasl_pkt_length(
-                       (unsigned char *) sec_buf_in->buf_base, max, debuglevel);
+                       (unsigned char *) sec_buf_in->buf_base, debuglevel);
        }
        else {
                sec_buf_in->buf_end = 0;
@@ -254,7 +267,8 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
 
        /* Read the length of the packet */
        while ( p->sec_buf_in.buf_ptr < 4 ) {
-               ret = LBER_SBIOD_READ_NEXT( sbiod, p->sec_buf_in.buf_base,
+               ret = LBER_SBIOD_READ_NEXT( sbiod, p->sec_buf_in.buf_base +
+                       p->sec_buf_in.buf_ptr,
                        4 - p->sec_buf_in.buf_ptr );
 #ifdef EINTR
                if ( ( ret < 0 ) && ( errno == EINTR ) )
@@ -268,7 +282,7 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
 
        /* The new packet always starts at p->sec_buf_in.buf_base */
        ret = sb_sasl_pkt_length( (unsigned char *) p->sec_buf_in.buf_base,
-               *p->sasl_maxbuf, sbiod->sbiod_sb->sb_debug );
+               sbiod->sbiod_sb->sb_debug );
 
        /* Grow the packet buffer if neccessary */
        if ( ( p->sec_buf_in.buf_size < (ber_len_t) ret ) && 
@@ -297,14 +311,17 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
        }
 
        /* Decode the packet */
-       ret = sasl_decode( p->sasl_context, p->sec_buf_in.buf_base,
-               p->sec_buf_in.buf_end,
-               (SASL_CONST char **)&p->buf_in.buf_base,
-               (unsigned *)&p->buf_in.buf_end );
+       {
+               unsigned tmpsize = p->buf_in.buf_end;
+               ret = sasl_decode( p->sasl_context, p->sec_buf_in.buf_base,
+                       p->sec_buf_in.buf_end,
+                       (SASL_CONST char **)&p->buf_in.buf_base,
+                       (unsigned *)&tmpsize );
+               p->buf_in.buf_end = tmpsize;
+       }
 
        /* Drop the packet from the input buffer */
-       sb_sasl_drop_packet( &p->sec_buf_in,
-                       *p->sasl_maxbuf, sbiod->sbiod_sb->sb_debug );
+       sb_sasl_drop_packet( &p->sec_buf_in, sbiod->sbiod_sb->sb_debug );
 
        if ( ret != SASL_OK ) {
                ber_log_printf( LDAP_DEBUG_ANY, sbiod->sbiod_sb->sb_debug,
@@ -335,40 +352,47 @@ sb_sasl_write( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
        /* Are there anything left in the buffer? */
        if ( p->buf_out.buf_ptr != p->buf_out.buf_end ) {
                ret = ber_pvt_sb_do_write( sbiod, &p->buf_out );
-               if ( ret < 0 )
-                       return ret;
+               if ( ret < 0 ) return ret;
+
                /* Still have something left?? */
                if ( p->buf_out.buf_ptr != p->buf_out.buf_end ) {
                        errno = EAGAIN;
-                       return 0;
+                       return -1;
                }
        }
 
        /* now encode the next packet. */
 #if SASL_VERSION_MAJOR >= 2
        ber_pvt_sb_buf_init( &p->buf_out );
-       /* sasl v2 makes sure this number is correct */
-       if ( len > *p->sasl_maxbuf )
-               len = *p->sasl_maxbuf;
 #else
        ber_pvt_sb_buf_destroy( &p->buf_out );
-       if ( len > *p->sasl_maxbuf - 100 )
-               len = *p->sasl_maxbuf - 100;    /* For safety margin */
 #endif
-       ret = sasl_encode( p->sasl_context, buf, len,
-               (SASL_CONST char **)&p->buf_out.buf_base,
-               (unsigned *)&p->buf_out.buf_size );
+       if ( len > *p->sasl_maxbuf - 100 ) {
+               len = *p->sasl_maxbuf - 100;    /* For safety margin */
+       }
+
+       {
+               unsigned tmpsize = p->buf_out.buf_size;
+               ret = sasl_encode( p->sasl_context, buf, len,
+                       (SASL_CONST char **)&p->buf_out.buf_base,
+                       &tmpsize );
+               p->buf_out.buf_size = tmpsize;
+       }
+
        if ( ret != SASL_OK ) {
                ber_log_printf( LDAP_DEBUG_ANY, sbiod->sbiod_sb->sb_debug,
                        "sb_sasl_write: failed to encode packet: %s\n",
                        sasl_errstring( ret, NULL, NULL ) );
+               errno = EIO;
                return -1;
        }
        p->buf_out.buf_end = p->buf_out.buf_size;
 
        ret = ber_pvt_sb_do_write( sbiod, &p->buf_out );
-       if ( ret <= 0 )
-               return ret;
+
+       /* return number of bytes encoded, not written, to ensure
+        * no byte is encoded twice (even if only sent once).
+        */
        return len;
 }
 
@@ -380,8 +404,7 @@ sb_sasl_ctrl( Sockbuf_IO_Desc *sbiod, int opt, void *arg )
        p = (struct sb_sasl_data *)sbiod->sbiod_pvt;
 
        if ( opt == LBER_SB_OPT_DATA_READY ) {
-               if ( p->buf_in.buf_ptr != p->buf_in.buf_end )
-                       return 1;
+               if ( p->buf_in.buf_ptr != p->buf_in.buf_end ) return 1;
        }
        
        return LBER_SBIOD_CTRL_NEXT( sbiod, opt, arg );
@@ -398,12 +421,8 @@ Sockbuf_IO ldap_pvt_sockbuf_io_sasl = {
 
 int ldap_pvt_sasl_install( Sockbuf *sb, void *ctx_arg )
 {
-#ifdef NEW_LOGGING
-       LDAP_LOG ( TRANSPORT, ENTRY, "ldap_pvt_sasl_install\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_pvt_sasl_install\n",
                0, 0, 0 );
-#endif
 
        /* don't install the stuff unless security has been negotiated */
 
@@ -490,11 +509,16 @@ ldap_int_sasl_open(
                return ld->ld_errno;
        }
 
+       if ( ldap_int_sasl_init() ) {
+               ld->ld_errno = LDAP_LOCAL_ERROR;
+               return ld->ld_errno;
+       }
+
 #if SASL_VERSION_MAJOR >= 2
        rc = sasl_client_new( "ldap", host, NULL, NULL,
-               NULL, 0, &ctx );
+               client_callbacks, 0, &ctx );
 #else
-       rc = sasl_client_new( "ldap", host, NULL,
+       rc = sasl_client_new( "ldap", host, client_callbacks,
                SASL_SECURITY_LAYER, &ctx );
 #endif
 
@@ -503,13 +527,8 @@ ldap_int_sasl_open(
                return ld->ld_errno;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( TRANSPORT, DETAIL1, "ldap_int_sasl_open: host=%s\n", 
-               host, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_open: host=%s\n",
                host, 0, 0 );
-#endif
 
        lc->lconn_sasl_authctx = ctx;
 
@@ -557,13 +576,8 @@ ldap_int_sasl_bind(
        ber_socket_t            sd;
        void    *ssl;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( TRANSPORT, ARGS, "ldap_int_sasl_bind: %s\n", 
-               mechs ? mechs : "<null>", 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_bind: %s\n",
                mechs ? mechs : "<null>", 0, 0 );
-#endif
 
        /* do a quick !LDAPv3 check... ldap_sasl_bind will do the rest. */
        if (ld->ld_version < LDAP_VERSION3) {
@@ -580,7 +594,7 @@ ldap_int_sasl_bind(
                rc = ldap_open_defconn( ld );
                if( rc < 0 ) return ld->ld_errno;
 
-               ber_sockbuf_ctrl( ld->ld_sb, LBER_SB_OPT_GET_FD, &sd );
+               ber_sockbuf_ctrl( ld->ld_defconn->lconn_sb, LBER_SB_OPT_GET_FD, &sd );
 
                if( sd == AC_SOCKET_INVALID ) {
                        ld->ld_errno = LDAP_LOCAL_ERROR;
@@ -598,18 +612,19 @@ ldap_int_sasl_bind(
                ld->ld_defconn->lconn_sasl_authctx = NULL;
        }
 
-       rc = ldap_int_sasl_open( ld, ld->ld_defconn,
-               ld->ld_defconn->lconn_server->lud_host ?
-               ld->ld_defconn->lconn_server->lud_host : "localhost" );
+       { char *saslhost = ldap_host_connected_to( ld->ld_defconn->lconn_sb, "localhost" );
+       rc = ldap_int_sasl_open( ld, ld->ld_defconn, saslhost );
+       LDAP_FREE( saslhost );
+       }
 
        if ( rc != LDAP_SUCCESS ) return rc;
 
        ctx = ld->ld_defconn->lconn_sasl_authctx;
 
        /* Check for TLS */
-       ssl = ldap_pvt_tls_sb_ctx( ld->ld_sb );
+       ssl = ldap_pvt_tls_sb_ctx( ld->ld_defconn->lconn_sb );
        if ( ssl ) {
-               struct berval authid = { 0, NULL };
+               struct berval authid = BER_BVNULL;
                ber_len_t fac;
 
                fac = ldap_pvt_tls_get_strength( ssl );
@@ -620,6 +635,7 @@ ldap_int_sasl_bind(
                LDAP_FREE( authid.bv_val );
        }
 
+#if !defined(_WIN32)
        /* Check for local */
        if ( ldap_pvt_url_scheme2proto( ld->ld_defconn->lconn_server->lud_scheme ) == LDAP_PROTO_IPC ) {
                char authid[sizeof("uidNumber=4294967295+gidNumber=4294967295,"
@@ -629,6 +645,7 @@ ldap_int_sasl_bind(
                        (int) geteuid(), (int) getegid() );
                (void) ldap_int_sasl_external( ld, ld->ld_defconn, authid, LDAP_PVT_SASL_LOCAL_SSF );
        }
+#endif
 
        /* (re)set security properties */
        sasl_setprop( ctx, SASL_SEC_PROPS,
@@ -695,15 +712,9 @@ ldap_int_sasl_bind(
                if ( rc != LDAP_SUCCESS && rc != LDAP_SASL_BIND_IN_PROGRESS ) {
                        if( scred && scred->bv_len ) {
                                /* and server provided us with data? */
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( TRANSPORT, DETAIL1, 
-                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
-                                       rc, saslrc, scred->bv_len );
-#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
                                        rc, saslrc, scred->bv_len );
-#endif
                                ber_bvfree( scred );
                        }
                        rc = ld->ld_errno;
@@ -714,15 +725,9 @@ ldap_int_sasl_bind(
                        /* we're done, no need to step */
                        if( scred && scred->bv_len ) {
                                /* but server provided us with data! */
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( TRANSPORT, DETAIL1, 
-                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
-                                       rc, saslrc, scred->bv_len );
-#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
                                        rc, saslrc, scred->bv_len );
-#endif
                                ber_bvfree( scred );
                                rc = ld->ld_errno = LDAP_LOCAL_ERROR;
                                goto done;
@@ -738,13 +743,8 @@ ldap_int_sasl_bind(
                                (SASL_CONST char **)&ccred.bv_val,
                                &credlen );
 
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( TRANSPORT, DETAIL1, 
-                                       "ldap_int_sasl_bind: sasl_client_step: %d\n", saslrc,0,0 );
-#else
                        Debug( LDAP_DEBUG_TRACE, "sasl_client_step: %d\n",
                                saslrc, 0, 0 );
-#endif
 
                        if( saslrc == SASL_INTERACT ) {
                                int res;
@@ -805,9 +805,9 @@ ldap_int_sasl_bind(
                        if ( ld->ld_defconn->lconn_sasl_sockctx ) {
                                oldctx = ld->ld_defconn->lconn_sasl_sockctx;
                                sasl_dispose( &oldctx );
-                               ldap_pvt_sasl_remove( ld->ld_sb );
+                               ldap_pvt_sasl_remove( ld->ld_defconn->lconn_sb );
                        }
-                       ldap_pvt_sasl_install( ld->ld_conns->lconn_sb, ctx );
+                       ldap_pvt_sasl_install( ld->ld_defconn->lconn_sb, ctx );
                        ld->ld_defconn->lconn_sasl_sockctx = ctx;
                }
        }
@@ -857,11 +857,110 @@ ldap_int_sasl_external(
 }
 
 
+#define GOT_MINSSF     1
+#define        GOT_MAXSSF      2
+#define        GOT_MAXBUF      4
+
+static struct {
+       struct berval key;
+       int sflag;
+       int ival;
+       int idef;
+} sprops[] = {
+       { BER_BVC("none"), 0, 0, 0 },
+       { BER_BVC("nodict"), SASL_SEC_NODICTIONARY, 0, 0 },
+       { BER_BVC("noplain"), SASL_SEC_NOPLAINTEXT, 0, 0 },
+       { BER_BVC("noactive"), SASL_SEC_NOACTIVE, 0, 0 },
+       { BER_BVC("passcred"), SASL_SEC_PASS_CREDENTIALS, 0, 0 },
+       { BER_BVC("forwardsec"), SASL_SEC_FORWARD_SECRECY, 0, 0 },
+       { BER_BVC("noanonymous"), SASL_SEC_NOANONYMOUS, 0, 0 },
+       { BER_BVC("minssf="), 0, GOT_MINSSF, 0 },
+       { BER_BVC("maxssf="), 0, GOT_MAXSSF, INT_MAX },
+       { BER_BVC("maxbufsize="), 0, GOT_MAXBUF, 65536 },
+       { BER_BVNULL, 0, 0, 0 }
+};
+
+void ldap_pvt_sasl_secprops_unparse(
+       sasl_security_properties_t *secprops,
+       struct berval *out )
+{
+       int i, l = 0;
+       int comma;
+       char *ptr;
+
+       if ( secprops == NULL || out == NULL ) {
+               return;
+       }
+
+       comma = 0;
+       for ( i=0; !BER_BVISNULL( &sprops[i].key ); i++ ) {
+               if ( sprops[i].ival ) {
+                       int v = 0;
+
+                       switch( sprops[i].ival ) {
+                       case GOT_MINSSF: v = secprops->min_ssf; break;
+                       case GOT_MAXSSF: v = secprops->max_ssf; break;
+                       case GOT_MAXBUF: v = secprops->maxbufsize; break;
+                       }
+                       /* It is the default, ignore it */
+                       if ( v == sprops[i].idef ) continue;
+
+                       l += sprops[i].key.bv_len + 24;
+               } else if ( sprops[i].sflag ) {
+                       if ( sprops[i].sflag & secprops->security_flags ) {
+                               l += sprops[i].key.bv_len;
+                       }
+               } else if ( secprops->security_flags == 0 ) {
+                       l += sprops[i].key.bv_len;
+               }
+               if ( comma ) l++;
+               comma = 1;
+       }
+       l++;
+
+       out->bv_val = LDAP_MALLOC( l );
+       if ( out->bv_val == NULL ) {
+               out->bv_len = 0;
+               return;
+       }
+
+       ptr = out->bv_val;
+       comma = 0;
+       for ( i=0; !BER_BVISNULL( &sprops[i].key ); i++ ) {
+               if ( sprops[i].ival ) {
+                       int v = 0;
+
+                       switch( sprops[i].ival ) {
+                       case GOT_MINSSF: v = secprops->min_ssf; break;
+                       case GOT_MAXSSF: v = secprops->max_ssf; break;
+                       case GOT_MAXBUF: v = secprops->maxbufsize; break;
+                       }
+                       /* It is the default, ignore it */
+                       if ( v == sprops[i].idef ) continue;
+
+                       if ( comma ) *ptr++ = ',';
+                       ptr += sprintf(ptr, "%s%d", sprops[i].key.bv_val, v );
+                       comma = 1;
+               } else if ( sprops[i].sflag ) {
+                       if ( sprops[i].sflag & secprops->security_flags ) {
+                               if ( comma ) *ptr++ = ',';
+                               ptr += sprintf(ptr, "%s", sprops[i].key.bv_val );
+                               comma = 1;
+                       }
+               } else if ( secprops->security_flags == 0 ) {
+                       if ( comma ) *ptr++ = ',';
+                       ptr += sprintf(ptr, "%s", sprops[i].key.bv_val );
+                       comma = 1;
+               }
+       }
+       out->bv_len = ptr - out->bv_val;
+}
+
 int ldap_pvt_sasl_secprops(
        const char *in,
        sasl_security_properties_t *secprops )
 {
-       int i;
+       int i, j, l;
        char **props = ldap_str2charray( in, "," );
        unsigned sflags = 0;
        int got_sflags = 0;
@@ -877,71 +976,35 @@ int ldap_pvt_sasl_secprops(
        }
 
        for( i=0; props[i]; i++ ) {
-               if( !strcasecmp(props[i], "none") ) {
-                       got_sflags++;
-
-               } else if( !strcasecmp(props[i], "noplain") ) {
-                       got_sflags++;
-                       sflags |= SASL_SEC_NOPLAINTEXT;
-
-               } else if( !strcasecmp(props[i], "noactive") ) {
-                       got_sflags++;
-                       sflags |= SASL_SEC_NOACTIVE;
-
-               } else if( !strcasecmp(props[i], "nodict") ) {
-                       got_sflags++;
-                       sflags |= SASL_SEC_NODICTIONARY;
-
-               } else if( !strcasecmp(props[i], "forwardsec") ) {
-                       got_sflags++;
-                       sflags |= SASL_SEC_FORWARD_SECRECY;
-
-               } else if( !strcasecmp(props[i], "noanonymous")) {
-                       got_sflags++;
-                       sflags |= SASL_SEC_NOANONYMOUS;
-
-               } else if( !strcasecmp(props[i], "passcred") ) {
-                       got_sflags++;
-                       sflags |= SASL_SEC_PASS_CREDENTIALS;
-
-               } else if( !strncasecmp(props[i],
-                       "minssf=", sizeof("minssf")) )
-               {
-                       if( isdigit( (unsigned char) props[i][sizeof("minssf")] ) ) {
-                               got_min_ssf++;
-                               min_ssf = atoi( &props[i][sizeof("minssf")] );
+               l = strlen( props[i] );
+               for ( j=0; !BER_BVISNULL( &sprops[j].key ); j++ ) {
+                       if ( l < sprops[j].key.bv_len ) continue;
+                       if ( strncasecmp( props[i], sprops[j].key.bv_val,
+                               sprops[j].key.bv_len )) continue;
+                       if ( sprops[j].ival ) {
+                               int v;
+                               if ( props[i][sprops[j].key.bv_len] != '=' ) continue;
+                               if ( !isdigit( props[i][sprops[j].key.bv_len+1] )) continue;
+                               v = atoi( props[i]+sprops[j].key.bv_len+1 );
+                               switch( sprops[j].ival ) {
+                               case GOT_MINSSF:
+                                       min_ssf = v; got_min_ssf++; break;
+                               case GOT_MAXSSF:
+                                       max_ssf = v; got_max_ssf++; break;
+                               case GOT_MAXBUF:
+                                       maxbufsize = v; got_maxbufsize++; break;
+                               }
                        } else {
-                               return LDAP_NOT_SUPPORTED;
+                               if ( props[i][sprops[j].key.bv_len] ) continue;
+                               if ( sprops[j].sflag )
+                                       sflags |= sprops[j].sflag;
+                               else
+                                       sflags = 0;
+                               got_sflags++;
                        }
-
-               } else if( !strncasecmp(props[i],
-                       "maxssf=", sizeof("maxssf")) )
-               {
-                       if( isdigit( (unsigned char) props[i][sizeof("maxssf")] ) ) {
-                               got_max_ssf++;
-                               max_ssf = atoi( &props[i][sizeof("maxssf")] );
-                       } else {
-                               return LDAP_NOT_SUPPORTED;
-                       }
-
-               } else if( !strncasecmp(props[i],
-                       "maxbufsize=", sizeof("maxbufsize")) )
-               {
-                       if( isdigit( (unsigned char) props[i][sizeof("maxbufsize")] ) ) {
-                               got_maxbufsize++;
-                               maxbufsize = atoi( &props[i][sizeof("maxbufsize")] );
-                       } else {
-                               return LDAP_NOT_SUPPORTED;
-                       }
-
-                       if( maxbufsize && (( maxbufsize < SASL_MIN_BUFF_SIZE )
-                               || (maxbufsize > SASL_MAX_BUFF_SIZE )))
-                       {
-                               /* bad maxbufsize */
-                               return LDAP_PARAM_ERROR;
-                       }
-
-               } else {
+                       break;
+               }
+               if ( BER_BVISNULL( &sprops[j].key )) {
                        return LDAP_NOT_SUPPORTED;
                }
        }
@@ -1143,7 +1206,7 @@ int ldap_pvt_sasl_mutex_lock(void *mutex)
                return SASL_OK;
        }
 #else /* !LDAP_DEBUG_R_SASL */
-       assert( mutex );
+       assert( mutex != NULL );
 #endif /* !LDAP_DEBUG_R_SASL */
        return ldap_pvt_thread_mutex_lock( (ldap_pvt_thread_mutex_t *)mutex )
                ? SASL_FAIL : SASL_OK;
@@ -1156,7 +1219,7 @@ int ldap_pvt_sasl_mutex_unlock(void *mutex)
                return SASL_OK;
        }
 #else /* !LDAP_DEBUG_R_SASL */
-       assert( mutex );
+       assert( mutex != NULL );
 #endif /* !LDAP_DEBUG_R_SASL */
        return ldap_pvt_thread_mutex_unlock( (ldap_pvt_thread_mutex_t *)mutex )
                ? SASL_FAIL : SASL_OK;
@@ -1169,7 +1232,7 @@ void ldap_pvt_sasl_mutex_dispose(void *mutex)
                return;
        }
 #else /* !LDAP_DEBUG_R_SASL */
-       assert( mutex );
+       assert( mutex != NULL );
 #endif /* !LDAP_DEBUG_R_SASL */
        (void) ldap_pvt_thread_mutex_destroy( (ldap_pvt_thread_mutex_t *)mutex );
        LDAP_FREE( mutex );