]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/cyrus.c
ITS#4048 from HEAD
[openldap] / libraries / libldap / cyrus.c
index 1e6e9f42cf31f5d322753bd82766dc7f09b196d9..bbc4dfd0762a030813e032618d63af445f4f0582 100644 (file)
@@ -1,7 +1,16 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1999-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2005 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
@@ -14,6 +23,7 @@
 #include <ac/time.h>
 #include <ac/errno.h>
 #include <ac/ctype.h>
+#include <ac/unistd.h>
 
 #include "ldap-int.h"
 
@@ -39,40 +49,47 @@ ldap_pvt_thread_mutex_t ldap_int_sasl_mutex;
 * Various Cyrus SASL related stuff.
 */
 
+static const sasl_callback_t client_callbacks[] = {
+#ifdef SASL_CB_GETREALM
+       { SASL_CB_GETREALM, NULL, NULL },
+#endif
+       { SASL_CB_USER, NULL, NULL },
+       { SASL_CB_AUTHNAME, NULL, NULL },
+       { SASL_CB_PASS, NULL, NULL },
+       { SASL_CB_ECHOPROMPT, NULL, NULL },
+       { SASL_CB_NOECHOPROMPT, NULL, NULL },
+       { SASL_CB_LIST_END, NULL, NULL }
+};
+
 int ldap_int_sasl_init( void )
 {
        /* XXX not threadsafe */
        static int sasl_initialized = 0;
 
-       static sasl_callback_t client_callbacks[] = {
-#ifdef SASL_CB_GETREALM
-               { SASL_CB_GETREALM, NULL, NULL },
-#endif
-               { SASL_CB_USER, NULL, NULL },
-               { SASL_CB_AUTHNAME, NULL, NULL },
-               { SASL_CB_PASS, NULL, NULL },
-               { SASL_CB_ECHOPROMPT, NULL, NULL },
-               { SASL_CB_NOECHOPROMPT, NULL, NULL },
-               { SASL_CB_LIST_END, NULL, NULL }
-       };
-
 #ifdef HAVE_SASL_VERSION
-#define SASL_BUILD_VERSION ((SASL_VERSION_MAJOR << 24) |\
-       (SASL_VERSION_MINOR << 16) | SASL_VERSION_STEP)
-
+       /* stringify the version number, sasl.h doesn't do it for us */
+#define VSTR0(maj, min, pat)   #maj "." #min "." #pat
+#define VSTR(maj, min, pat)    VSTR0(maj, min, pat)
+#define SASL_VERSION_STRING    VSTR(SASL_VERSION_MAJOR, SASL_VERSION_MINOR, \
+                               SASL_VERSION_STEP)
        { int rc;
        sasl_version( NULL, &rc );
        if ( ((rc >> 16) != ((SASL_VERSION_MAJOR << 8)|SASL_VERSION_MINOR)) ||
                (rc & 0xffff) < SASL_VERSION_STEP) {
+               char version[sizeof("xxx.xxx.xxxxx")];
+               sprintf( version, "%u.%d.%d", (unsigned)rc >> 24, (rc >> 16) & 0xff,
+                       rc & 0xffff );
 
 #ifdef NEW_LOGGING
                LDAP_LOG( TRANSPORT, INFO,
-               "ldap_int_sasl_init: SASL version mismatch, got %x, wanted %x.\n",
-                       rc, SASL_BUILD_VERSION, 0 );
+               "ldap_int_sasl_init: SASL library version mismatch:"
+               " expected " SASL_VERSION_STRING ","
+               " got %s\n", version, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
-               "ldap_int_sasl_init: SASL version mismatch, got %x, wanted %x.\n",
-                       rc, SASL_BUILD_VERSION, 0 );
+               "ldap_int_sasl_init: SASL library version mismatch:"
+               " expected " SASL_VERSION_STRING ","
+               " got %s\n", version, 0, 0 );
 #endif
                return -1;
        }
@@ -82,7 +99,8 @@ int ldap_int_sasl_init( void )
                return 0;
        }
 
-#ifndef CSRIMALLOC
+/* SASL 2 takes care of its own memory completely internally */
+#if SASL_VERSION_MAJOR < 2 && !defined(CSRIMALLOC)
        sasl_set_alloc(
                ber_memalloc,
                ber_memcalloc,
@@ -96,11 +114,9 @@ int ldap_int_sasl_init( void )
                ldap_pvt_sasl_mutex_lock,
                ldap_pvt_sasl_mutex_unlock,    
                ldap_pvt_sasl_mutex_dispose );    
-
-       ldap_pvt_thread_mutex_init( &ldap_int_sasl_mutex );
 #endif
 
-       if ( sasl_client_init( client_callbacks ) == SASL_OK ) {
+       if ( sasl_client_init( NULL ) == SASL_OK ) {
                sasl_initialized = 1;
                return 0;
        }
@@ -145,7 +161,7 @@ sb_sasl_setup( Sockbuf_IO_Desc *sbiod, void *arg )
        }
        sasl_getprop( p->sasl_context, SASL_MAXOUTBUF,
                (SASL_CONST void **) &p->sasl_maxbuf );
-
+           
        sbiod->sbiod_pvt = p;
 
        return 0;
@@ -176,7 +192,7 @@ sb_sasl_remove( Sockbuf_IO_Desc *sbiod )
 }
 
 static ber_len_t
-sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
+sb_sasl_pkt_length( const unsigned char *buf, int debuglevel )
 {
        ber_len_t               size;
 
@@ -193,10 +209,6 @@ sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
                        "sb_sasl_pkt_length: received illegal packet length "
                        "of %lu bytes\n", (unsigned long)size );      
                size = 16; /* this should lead to an error. */
-       } else if ( size > max ) {
-               ber_log_printf( LDAP_DEBUG_ANY, debuglevel,
-                       "sb_sasl_pkt_length: received packet length "
-                       "of %lu exceeds negotiated max of %lu bytes\n", (unsigned long)size, (unsigned long)max );
        }
 
        return size + 4; /* include the size !!! */
@@ -204,7 +216,7 @@ sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
 
 /* Drop a processed packet from the input buffer */
 static void
-sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, unsigned max, int debuglevel )
+sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, int debuglevel )
 {
        ber_slen_t                      len;
 
@@ -214,8 +226,8 @@ sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, unsigned max, int debuglevel )
                        sec_buf_in->buf_end, len );
    
        if ( len >= 4 ) {
-               sec_buf_in->buf_end = sb_sasl_pkt_length( sec_buf_in->buf_base,
-                       max, debuglevel);
+               sec_buf_in->buf_end = sb_sasl_pkt_length(
+                       (unsigned char *) sec_buf_in->buf_base, debuglevel);
        }
        else {
                sec_buf_in->buf_end = 0;
@@ -250,21 +262,22 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
 
        /* Read the length of the packet */
        while ( p->sec_buf_in.buf_ptr < 4 ) {
-               ret = LBER_SBIOD_READ_NEXT( sbiod, p->sec_buf_in.buf_base,
+               ret = LBER_SBIOD_READ_NEXT( sbiod, p->sec_buf_in.buf_base +
+                       p->sec_buf_in.buf_ptr,
                        4 - p->sec_buf_in.buf_ptr );
 #ifdef EINTR
                if ( ( ret < 0 ) && ( errno == EINTR ) )
                        continue;
 #endif
                if ( ret <= 0 )
-                       return ret;
+                       return bufptr ? bufptr : ret;
 
                p->sec_buf_in.buf_ptr += ret;
        }
 
        /* The new packet always starts at p->sec_buf_in.buf_base */
-       ret = sb_sasl_pkt_length( p->sec_buf_in.buf_base,
-               *p->sasl_maxbuf, sbiod->sbiod_sb->sb_debug );
+       ret = sb_sasl_pkt_length( (unsigned char *) p->sec_buf_in.buf_base,
+               sbiod->sbiod_sb->sb_debug );
 
        /* Grow the packet buffer if neccessary */
        if ( ( p->sec_buf_in.buf_size < (ber_len_t) ret ) && 
@@ -287,20 +300,23 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
                        continue;
 #endif
                if ( ret <= 0 )
-                       return ret;
+                       return bufptr ? bufptr : ret;
 
                p->sec_buf_in.buf_ptr += ret;
        }
 
        /* Decode the packet */
-       ret = sasl_decode( p->sasl_context, p->sec_buf_in.buf_base,
-               p->sec_buf_in.buf_end,
-               (SASL_CONST char **)&p->buf_in.buf_base,
-               (unsigned *)&p->buf_in.buf_end );
+       {
+               unsigned tmpsize = p->buf_in.buf_end;
+               ret = sasl_decode( p->sasl_context, p->sec_buf_in.buf_base,
+                       p->sec_buf_in.buf_end,
+                       (SASL_CONST char **)&p->buf_in.buf_base,
+                       (unsigned *)&tmpsize );
+               p->buf_in.buf_end = tmpsize;
+       }
 
        /* Drop the packet from the input buffer */
-       sb_sasl_drop_packet( &p->sec_buf_in,
-                       *p->sasl_maxbuf, sbiod->sbiod_sb->sb_debug );
+       sb_sasl_drop_packet( &p->sec_buf_in, sbiod->sbiod_sb->sb_debug );
 
        if ( ret != SASL_OK ) {
                ber_log_printf( LDAP_DEBUG_ANY, sbiod->sbiod_sb->sb_debug,
@@ -331,8 +347,13 @@ sb_sasl_write( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
        /* Are there anything left in the buffer? */
        if ( p->buf_out.buf_ptr != p->buf_out.buf_end ) {
                ret = ber_pvt_sb_do_write( sbiod, &p->buf_out );
-               if ( ret <= 0 )
-                       return ret;
+               if ( ret < 0 ) return ret;
+
+               /* Still have something left?? */
+               if ( p->buf_out.buf_ptr != p->buf_out.buf_end ) {
+                       errno = EAGAIN;
+                       return -1;
+               }
        }
 
        /* now encode the next packet. */
@@ -341,22 +362,32 @@ sb_sasl_write( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
 #else
        ber_pvt_sb_buf_destroy( &p->buf_out );
 #endif
-       if ( len > *p->sasl_maxbuf - 100 )
+       if ( len > *p->sasl_maxbuf - 100 ) {
                len = *p->sasl_maxbuf - 100;    /* For safety margin */
-       ret = sasl_encode( p->sasl_context, buf, len,
-               (SASL_CONST char **)&p->buf_out.buf_base,
-               (unsigned *)&p->buf_out.buf_size );
+       }
+
+       {
+               unsigned tmpsize = p->buf_out.buf_size;
+               ret = sasl_encode( p->sasl_context, buf, len,
+                       (SASL_CONST char **)&p->buf_out.buf_base,
+                       &tmpsize );
+               p->buf_out.buf_size = tmpsize;
+       }
+
        if ( ret != SASL_OK ) {
                ber_log_printf( LDAP_DEBUG_ANY, sbiod->sbiod_sb->sb_debug,
                        "sb_sasl_write: failed to encode packet: %s\n",
                        sasl_errstring( ret, NULL, NULL ) );
+               errno = EIO;
                return -1;
        }
        p->buf_out.buf_end = p->buf_out.buf_size;
 
        ret = ber_pvt_sb_do_write( sbiod, &p->buf_out );
-       if ( ret <= 0 )
-               return ret;
+
+       /* return number of bytes encoded, not written, to ensure
+        * no byte is encoded twice (even if only sent once).
+        */
        return len;
 }
 
@@ -368,8 +399,7 @@ sb_sasl_ctrl( Sockbuf_IO_Desc *sbiod, int opt, void *arg )
        p = (struct sb_sasl_data *)sbiod->sbiod_pvt;
 
        if ( opt == LBER_SB_OPT_DATA_READY ) {
-               if ( p->buf_in.buf_ptr != p->buf_in.buf_end )
-                       return 1;
+               if ( p->buf_in.buf_ptr != p->buf_in.buf_end ) return 1;
        }
        
        return LBER_SBIOD_CTRL_NEXT( sbiod, opt, arg );
@@ -409,6 +439,16 @@ int ldap_pvt_sasl_install( Sockbuf *sb, void *ctx_arg )
        return LDAP_SUCCESS;
 }
 
+void ldap_pvt_sasl_remove( Sockbuf *sb )
+{
+       ber_sockbuf_remove_io( sb, &ldap_pvt_sockbuf_io_sasl,
+               LBER_SBIOD_LEVEL_APPLICATION );
+#ifdef LDAP_DEBUG
+       ber_sockbuf_remove_io( sb, &ber_sockbuf_io_debug,
+               LBER_SBIOD_LEVEL_APPLICATION );
+#endif
+}
+
 static int
 sasl_err2ldap( int saslerr )
 {
@@ -456,24 +496,28 @@ int
 ldap_int_sasl_open(
        LDAP *ld, 
        LDAPConn *lc,
-       const char * host,
-       ber_len_t ssf )
+       const char * host )
 {
        int rc;
        sasl_conn_t *ctx;
 
-       assert( lc->lconn_sasl_ctx == NULL );
+       assert( lc->lconn_sasl_authctx == NULL );
 
        if ( host == NULL ) {
                ld->ld_errno = LDAP_LOCAL_ERROR;
                return ld->ld_errno;
        }
 
+       if ( ldap_int_sasl_init() ) {
+               ld->ld_errno = LDAP_LOCAL_ERROR;
+               return ld->ld_errno;
+       }
+
 #if SASL_VERSION_MAJOR >= 2
        rc = sasl_client_new( "ldap", host, NULL, NULL,
-               NULL, 0, &ctx );
+               client_callbacks, 0, &ctx );
 #else
-       rc = sasl_client_new( "ldap", host, NULL,
+       rc = sasl_client_new( "ldap", host, client_callbacks,
                SASL_SECURITY_LAYER, &ctx );
 #endif
 
@@ -490,39 +534,24 @@ ldap_int_sasl_open(
                host, 0, 0 );
 #endif
 
-       lc->lconn_sasl_ctx = ctx;
-
-       if( ssf ) {
-#if SASL_VERSION_MAJOR >= 2
-               (void) sasl_setprop( ctx, SASL_SSF_EXTERNAL,
-                       (void *) &ssf );
-#else
-               sasl_external_properties_t extprops;
-               memset(&extprops, 0L, sizeof(extprops));
-               extprops.ssf = ssf;
-
-               (void) sasl_setprop( ctx, SASL_SSF_EXTERNAL,
-                       (void *) &extprops );
-#endif
-#ifdef NEW_LOGGING
-               LDAP_LOG ( TRANSPORT, DETAIL1, 
-                       "ldap_int_sasl_open: ssf=%ld\n", (long) ssf, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_open: ssf=%ld\n",
-                       (long) ssf, 0, 0 );
-#endif
-       }
+       lc->lconn_sasl_authctx = ctx;
 
        return LDAP_SUCCESS;
 }
 
 int ldap_int_sasl_close( LDAP *ld, LDAPConn *lc )
 {
-       sasl_conn_t *ctx = lc->lconn_sasl_ctx;
+       sasl_conn_t *ctx = lc->lconn_sasl_authctx;
 
        if( ctx != NULL ) {
                sasl_dispose( &ctx );
-               lc->lconn_sasl_ctx = NULL;
+               if ( lc->lconn_sasl_sockctx &&
+                       lc->lconn_sasl_authctx != lc->lconn_sasl_sockctx ) {
+                       ctx = lc->lconn_sasl_sockctx;
+                       sasl_dispose( &ctx );
+               }
+               lc->lconn_sasl_sockctx = NULL;
+               lc->lconn_sasl_authctx = NULL;
        }
 
        return LDAP_SUCCESS;
@@ -544,11 +573,12 @@ ldap_int_sasl_bind(
        const char *pmech = NULL;
        int                     saslrc, rc;
        sasl_ssf_t              *ssf = NULL;
-       sasl_conn_t     *ctx;
+       sasl_conn_t     *ctx, *oldctx = NULL;
        sasl_interact_t *prompts = NULL;
        unsigned credlen;
        struct berval ccred;
        ber_socket_t            sd;
+       void    *ssl;
 
 #ifdef NEW_LOGGING
        LDAP_LOG ( TRANSPORT, ARGS, "ldap_int_sasl_bind: %s\n", 
@@ -573,7 +603,7 @@ ldap_int_sasl_bind(
                rc = ldap_open_defconn( ld );
                if( rc < 0 ) return ld->ld_errno;
 
-               ber_sockbuf_ctrl( ld->ld_sb, LBER_SB_OPT_GET_FD, &sd );
+               ber_sockbuf_ctrl( ld->ld_defconn->lconn_sb, LBER_SB_OPT_GET_FD, &sd );
 
                if( sd == AC_SOCKET_INVALID ) {
                        ld->ld_errno = LDAP_LOCAL_ERROR;
@@ -581,13 +611,51 @@ ldap_int_sasl_bind(
                }
        }   
 
-       ctx = ld->ld_defconn->lconn_sasl_ctx;
+       oldctx = ld->ld_defconn->lconn_sasl_authctx;
 
-       if( ctx == NULL ) {
-               ld->ld_errno = LDAP_LOCAL_ERROR;
-               return ld->ld_errno;
+       /* If we already have an authentication context, clear it out */
+       if( oldctx ) {
+               if ( oldctx != ld->ld_defconn->lconn_sasl_sockctx ) {
+                       sasl_dispose( &oldctx );
+               }
+               ld->ld_defconn->lconn_sasl_authctx = NULL;
+       }
+
+       { char *saslhost = ldap_host_connected_to( ld->ld_defconn->lconn_sb, "localhost" );
+       rc = ldap_int_sasl_open( ld, ld->ld_defconn, saslhost );
+       LDAP_FREE( saslhost );
        }
 
+       if ( rc != LDAP_SUCCESS ) return rc;
+
+       ctx = ld->ld_defconn->lconn_sasl_authctx;
+
+       /* Check for TLS */
+       ssl = ldap_pvt_tls_sb_ctx( ld->ld_defconn->lconn_sb );
+       if ( ssl ) {
+               struct berval authid = BER_BVNULL;
+               ber_len_t fac;
+
+               fac = ldap_pvt_tls_get_strength( ssl );
+               /* failure is OK, we just can't use SASL EXTERNAL */
+               (void) ldap_pvt_tls_get_my_dn( ssl, &authid, NULL, 0 );
+
+               (void) ldap_int_sasl_external( ld, ld->ld_defconn, authid.bv_val, fac );
+               LDAP_FREE( authid.bv_val );
+       }
+
+#if !defined(_WIN32)
+       /* Check for local */
+       if ( ldap_pvt_url_scheme2proto( ld->ld_defconn->lconn_server->lud_scheme ) == LDAP_PROTO_IPC ) {
+               char authid[sizeof("uidNumber=4294967295+gidNumber=4294967295,"
+                       "cn=peercred,cn=external,cn=auth")];
+               sprintf( authid, "uidNumber=%d+gidNumber=%d,"
+                       "cn=peercred,cn=external,cn=auth",
+                       (int) geteuid(), (int) getegid() );
+               (void) ldap_int_sasl_external( ld, ld->ld_defconn, authid, LDAP_PVT_SASL_LOCAL_SSF );
+       }
+#endif
+
        /* (re)set security properties */
        sasl_setprop( ctx, SASL_SEC_PROPS,
                &ld->ld_options.ldo_sasl_secprops );
@@ -616,32 +684,23 @@ ldap_int_sasl_bind(
                        }
                }
 
-#if SASL_VERSION_MAJOR >= 2
-               /* XXX the application should free interact results. */
-               if ( prompts != NULL && prompts->result != NULL ) {
-                       LDAP_FREE( (void *)prompts->result );
-                       prompts->result = NULL;
-               }
-#endif
-
                if( saslrc == SASL_INTERACT ) {
                        int res;
                        if( !interact ) break;
                        res = (interact)( ld, flags, defaults, prompts );
-                       if( res != LDAP_SUCCESS ) {
-                               break;
-                       }
+
+                       if( res != LDAP_SUCCESS ) break;
                }
        } while ( saslrc == SASL_INTERACT );
 
        ccred.bv_len = credlen;
 
        if ( (saslrc != SASL_OK) && (saslrc != SASL_CONTINUE) ) {
-               ld->ld_errno = sasl_err2ldap( saslrc );
+               rc = ld->ld_errno = sasl_err2ldap( saslrc );
 #if SASL_VERSION_MAJOR >= 2
-               ld->ld_error = (char *)sasl_errdetail( ctx );
+               ld->ld_error = LDAP_STRDUP( sasl_errdetail( ctx ) );
 #endif
-               return ld->ld_errno;
+               goto done;
        }
 
        do {
@@ -660,37 +719,43 @@ ldap_int_sasl_bind(
                }
 
                if ( rc != LDAP_SUCCESS && rc != LDAP_SASL_BIND_IN_PROGRESS ) {
-                       if( scred && scred->bv_len ) {
-                               /* and server provided us with data? */
+                       if( scred ) {
+                               if ( scred->bv_len ) {
+                                       /* and server provided us with data? */
 #ifdef NEW_LOGGING
-                               LDAP_LOG ( TRANSPORT, DETAIL1, 
-                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
-                                       rc, saslrc, scred->bv_len );
+                                       LDAP_LOG ( TRANSPORT, DETAIL1, 
+                                               "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
+                                               rc, saslrc, scred->bv_len );
 #else
-                               Debug( LDAP_DEBUG_TRACE,
-                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
-                                       rc, saslrc, scred->bv_len );
+                                       Debug( LDAP_DEBUG_TRACE,
+                                               "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
+                                               rc, saslrc, scred->bv_len );
 #endif
+                               }
                                ber_bvfree( scred );
                        }
-                       return ld->ld_errno;
+                       rc = ld->ld_errno;
+                       goto done;
                }
 
                if( rc == LDAP_SUCCESS && saslrc == SASL_OK ) {
                        /* we're done, no need to step */
-                       if( scred && scred->bv_len ) {
+                       if( scred ) {
+                               if ( scred->bv_len ) {
                                /* but server provided us with data! */
 #ifdef NEW_LOGGING
-                               LDAP_LOG ( TRANSPORT, DETAIL1, 
-                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
-                                       rc, saslrc, scred->bv_len );
+                                       LDAP_LOG ( TRANSPORT, DETAIL1, 
+                                               "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
+                                               rc, saslrc, scred->bv_len );
 #else
-                               Debug( LDAP_DEBUG_TRACE,
-                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
-                                       rc, saslrc, scred->bv_len );
+                                       Debug( LDAP_DEBUG_TRACE,
+                                               "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
+                                               rc, saslrc, scred->bv_len );
 #endif
+                               }
                                ber_bvfree( scred );
-                               return ld->ld_errno = LDAP_LOCAL_ERROR;
+                               rc = ld->ld_errno = LDAP_LOCAL_ERROR;
+                               goto done;
                        }
                        break;
                }
@@ -711,21 +776,11 @@ ldap_int_sasl_bind(
                                saslrc, 0, 0 );
 #endif
 
-#if SASL_VERSION_MAJOR >= 2
-                       /* XXX the application should free interact results. */
-                       if ( prompts != NULL && prompts->result != NULL ) {
-                               LDAP_FREE( (void *)prompts->result );
-                               prompts->result = NULL;
-                       }
-#endif
-
                        if( saslrc == SASL_INTERACT ) {
                                int res;
                                if( !interact ) break;
                                res = (interact)( ld, flags, defaults, prompts );
-                               if( res != LDAP_SUCCESS ) {
-                                       break;
-                               }
+                               if( res != LDAP_SUCCESS ) break;
                        }
                } while ( saslrc == SASL_INTERACT );
 
@@ -735,21 +790,21 @@ ldap_int_sasl_bind(
                if ( (saslrc != SASL_OK) && (saslrc != SASL_CONTINUE) ) {
                        ld->ld_errno = sasl_err2ldap( saslrc );
 #if SASL_VERSION_MAJOR >= 2
-                       ld->ld_error = (char *)sasl_errdetail( ctx );
+                       ld->ld_error = LDAP_STRDUP( sasl_errdetail( ctx ) );
 #endif
-                       return ld->ld_errno;
+                       rc = ld->ld_errno;
+                       goto done;
                }
        } while ( rc == LDAP_SASL_BIND_IN_PROGRESS );
 
-       if ( rc != LDAP_SUCCESS ) {
-               return rc;
-       }
+       if ( rc != LDAP_SUCCESS ) goto done;
 
        if ( saslrc != SASL_OK ) {
 #if SASL_VERSION_MAJOR >= 2
-               ld->ld_error = (char *)sasl_errdetail( ctx );
+               ld->ld_error = LDAP_STRDUP( sasl_errdetail( ctx ) );
 #endif
-               return ld->ld_errno = sasl_err2ldap( saslrc );
+               rc = ld->ld_errno = sasl_err2ldap( saslrc );
+               goto done;
        }
 
        if( flags != LDAP_SASL_QUIET ) {
@@ -758,14 +813,12 @@ ldap_int_sasl_bind(
                        fprintf( stderr, "SASL username: %s\n", data );
                }
 
-#if SASL_VERSION_MAJOR >= 2
-               saslrc = sasl_getprop( ctx, SASL_DEFUSERREALM, (SASL_CONST void **) &data );
-#else
+#if SASL_VERSION_MAJOR < 2
                saslrc = sasl_getprop( ctx, SASL_REALM, (SASL_CONST void **) &data );
-#endif
                if( saslrc == SASL_OK && data && *data ) {
                        fprintf( stderr, "SASL realm: %s\n", data );
                }
+#endif
        }
 
        saslrc = sasl_getprop( ctx, SASL_SSF, (SASL_CONST void **) &ssf );
@@ -779,10 +832,18 @@ ldap_int_sasl_bind(
                        if( flags != LDAP_SASL_QUIET ) {
                                fprintf( stderr, "SASL installing layers\n" );
                        }
-                       ldap_pvt_sasl_install( ld->ld_conns->lconn_sb, ctx );
+                       if ( ld->ld_defconn->lconn_sasl_sockctx ) {
+                               oldctx = ld->ld_defconn->lconn_sasl_sockctx;
+                               sasl_dispose( &oldctx );
+                               ldap_pvt_sasl_remove( ld->ld_defconn->lconn_sb );
+                       }
+                       ldap_pvt_sasl_install( ld->ld_defconn->lconn_sb, ctx );
+                       ld->ld_defconn->lconn_sasl_sockctx = ctx;
                }
        }
+       ld->ld_defconn->lconn_sasl_authctx = ctx;
 
+done:
        return rc;
 }
 
@@ -799,7 +860,7 @@ ldap_int_sasl_external(
        sasl_external_properties_t extprops;
 #endif
 
-       ctx = conn->lconn_sasl_ctx;
+       ctx = conn->lconn_sasl_authctx;
 
        if ( ctx == NULL ) {
                return LDAP_LOCAL_ERROR;
@@ -979,7 +1040,7 @@ ldap_int_sasl_get_option( LDAP *ld, int option, void *arg )
                                return -1;
                        }
 
-                       ctx = ld->ld_defconn->lconn_sasl_ctx;
+                       ctx = ld->ld_defconn->lconn_sasl_sockctx;
 
                        if ( ctx == NULL ) {
                                return -1;
@@ -1041,7 +1102,7 @@ ldap_int_sasl_set_option( LDAP *ld, int option, void *arg )
                        return -1;
                }
 
-               ctx = ld->ld_defconn->lconn_sasl_ctx;
+               ctx = ld->ld_defconn->lconn_sasl_authctx;
 
                if ( ctx == NULL ) {
                        return -1;
@@ -1088,6 +1149,7 @@ ldap_int_sasl_set_option( LDAP *ld, int option, void *arg )
 }
 
 #ifdef LDAP_R_COMPILE
+#define LDAP_DEBUG_R_SASL
 void *ldap_pvt_sasl_mutex_new(void)
 {
        ldap_pvt_thread_mutex_t *mutex;
@@ -1098,23 +1160,47 @@ void *ldap_pvt_sasl_mutex_new(void)
        if ( ldap_pvt_thread_mutex_init( mutex ) == 0 ) {
                return mutex;
        }
+#ifndef LDAP_DEBUG_R_SASL
+       assert( 0 );
+#endif /* !LDAP_DEBUG_R_SASL */
        return NULL;
 }
 
 int ldap_pvt_sasl_mutex_lock(void *mutex)
 {
+#ifdef LDAP_DEBUG_R_SASL
+       if ( mutex == NULL ) {
+               return SASL_OK;
+       }
+#else /* !LDAP_DEBUG_R_SASL */
+       assert( mutex );
+#endif /* !LDAP_DEBUG_R_SASL */
        return ldap_pvt_thread_mutex_lock( (ldap_pvt_thread_mutex_t *)mutex )
                ? SASL_FAIL : SASL_OK;
 }
 
 int ldap_pvt_sasl_mutex_unlock(void *mutex)
 {
+#ifdef LDAP_DEBUG_R_SASL
+       if ( mutex == NULL ) {
+               return SASL_OK;
+       }
+#else /* !LDAP_DEBUG_R_SASL */
+       assert( mutex );
+#endif /* !LDAP_DEBUG_R_SASL */
        return ldap_pvt_thread_mutex_unlock( (ldap_pvt_thread_mutex_t *)mutex )
                ? SASL_FAIL : SASL_OK;
 }
 
 void ldap_pvt_sasl_mutex_dispose(void *mutex)
 {
+#ifdef LDAP_DEBUG_R_SASL
+       if ( mutex == NULL ) {
+               return;
+       }
+#else /* !LDAP_DEBUG_R_SASL */
+       assert( mutex );
+#endif /* !LDAP_DEBUG_R_SASL */
        (void) ldap_pvt_thread_mutex_destroy( (ldap_pvt_thread_mutex_t *)mutex );
        LDAP_FREE( mutex );
 }