]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/cyrus.c
Added check for Cyrus SASL sasl_version()
[openldap] / libraries / libldap / cyrus.c
index 856c2896e4cf1955a6ce7138805733ddd4394617..db6b80805b0049f583aa09e2ad6f1b2579da619d 100644 (file)
@@ -1,27 +1,39 @@
 /* $OpenLDAP$ */
 /*
- * Copyright 1999-2000 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1999-2002 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
 #include "portable.h"
 
-#include <stdlib.h>
 #include <stdio.h>
 
 #include <ac/socket.h>
+#include <ac/stdlib.h>
 #include <ac/string.h>
 #include <ac/time.h>
 #include <ac/errno.h>
 #include <ac/ctype.h>
 
 #include "ldap-int.h"
+
+#ifdef HAVE_CYRUS_SASL
+
 #ifdef LDAP_R_COMPILE
-#include "ldap_pvt_thread.h"
+ldap_pvt_thread_mutex_t ldap_int_sasl_mutex;
 #endif
 
-#ifdef HAVE_CYRUS_SASL
+#ifdef HAVE_SASL_SASL_H
+#include <sasl/sasl.h>
+#else
 #include <sasl.h>
+#endif
+
+#if SASL_VERSION_MAJOR >= 2
+#define SASL_CONST const
+#else
+#define SASL_CONST
+#endif
 
 /*
 * Various Cyrus SASL related stuff.
@@ -44,6 +56,28 @@ int ldap_int_sasl_init( void )
                { SASL_CB_LIST_END, NULL, NULL }
        };
 
+#ifdef HAVE_SASL_VERSION
+#define SASL_BUILD_VERSION ((SASL_VERSION_MAJOR << 24) |\
+       (SASL_VERSION_MINOR << 16) | SASL_VERSION_STEP)
+
+       { int rc;
+       sasl_version( NULL, &rc );
+       if ( ((rc >> 16) != ((SASL_VERSION_MAJOR << 8)|SASL_VERSION_MINOR)) ||
+               (rc & 0xffff) < SASL_VERSION_STEP) {
+
+#ifdef NEW_LOGGING
+               LDAP_LOG( TRANSPORT, INFO,
+               "ldap_int_sasl_init: SASL version mismatch, got %x, wanted %x.\n",
+                       rc, SASL_BUILD_VERSION, 0 );
+#else
+               Debug( LDAP_DEBUG_ANY,
+               "ldap_int_sasl_init: SASL version mismatch, got %x, wanted %x.\n",
+                       rc, SASL_BUILD_VERSION, 0 );
+#endif
+               return -1;
+       }
+       }
+#endif
        if ( sasl_initialized ) {
                return 0;
        }
@@ -62,6 +96,8 @@ int ldap_int_sasl_init( void )
                ldap_pvt_sasl_mutex_lock,
                ldap_pvt_sasl_mutex_unlock,    
                ldap_pvt_sasl_mutex_dispose );    
+
+       ldap_pvt_thread_mutex_init( &ldap_int_sasl_mutex );
 #endif
 
        if ( sasl_client_init( client_callbacks ) == SASL_OK ) {
@@ -78,6 +114,7 @@ int ldap_int_sasl_init( void )
 
 struct sb_sasl_data {
        sasl_conn_t             *sasl_context;
+       unsigned                *sasl_maxbuf;
        Sockbuf_Buf             sec_buf_in;
        Sockbuf_Buf             buf_in;
        Sockbuf_Buf             buf_out;
@@ -98,9 +135,12 @@ sb_sasl_setup( Sockbuf_IO_Desc *sbiod, void *arg )
        ber_pvt_sb_buf_init( &p->buf_in );
        ber_pvt_sb_buf_init( &p->buf_out );
        if ( ber_pvt_sb_grow_buffer( &p->sec_buf_in, SASL_MIN_BUFF_SIZE ) < 0 ) {
+               LBER_FREE( p );
                errno = ENOMEM;
                return -1;
        }
+       sasl_getprop( p->sasl_context, SASL_MAXOUTBUF,
+               (SASL_CONST void **) &p->sasl_maxbuf );
 
        sbiod->sbiod_pvt = p;
 
@@ -115,6 +155,14 @@ sb_sasl_remove( Sockbuf_IO_Desc *sbiod )
        assert( sbiod != NULL );
        
        p = (struct sb_sasl_data *)sbiod->sbiod_pvt;
+#if SASL_VERSION_MAJOR >= 2
+       /*
+        * SASLv2 encode/decode buffers are managed by
+        * libsasl2. Ensure they are not freed by liblber.
+        */
+       p->buf_in.buf_base = NULL;
+       p->buf_out.buf_base = NULL;
+#endif
        ber_pvt_sb_buf_destroy( &p->sec_buf_in );
        ber_pvt_sb_buf_destroy( &p->buf_in );
        ber_pvt_sb_buf_destroy( &p->buf_out );
@@ -124,7 +172,7 @@ sb_sasl_remove( Sockbuf_IO_Desc *sbiod )
 }
 
 static ber_len_t
-sb_sasl_pkt_length( const unsigned char *buf, int debuglevel )
+sb_sasl_pkt_length( const unsigned char *buf, unsigned max, int debuglevel )
 {
        ber_len_t               size;
 
@@ -135,15 +183,16 @@ sb_sasl_pkt_length( const unsigned char *buf, int debuglevel )
                | buf[2] << 8
                | buf[3];
    
-       /* we really should check against actual buffer size set
-        * in the secopts.
-        */
        if ( size > SASL_MAX_BUFF_SIZE ) {
                /* somebody is trying to mess me up. */
                ber_log_printf( LDAP_DEBUG_ANY, debuglevel,
                        "sb_sasl_pkt_length: received illegal packet length "
                        "of %lu bytes\n", (unsigned long)size );      
                size = 16; /* this should lead to an error. */
+       } else if ( size > max ) {
+               ber_log_printf( LDAP_DEBUG_ANY, debuglevel,
+                       "sb_sasl_pkt_length: received packet length "
+                       "of %lu exceeds negotiated max of %lu bytes\n", (unsigned long)size, (unsigned long)max );
        }
 
        return size + 4; /* include the size !!! */
@@ -151,18 +200,18 @@ sb_sasl_pkt_length( const unsigned char *buf, int debuglevel )
 
 /* Drop a processed packet from the input buffer */
 static void
-sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, int debuglevel )
+sb_sasl_drop_packet ( Sockbuf_Buf *sec_buf_in, unsigned max, int debuglevel )
 {
        ber_slen_t                      len;
 
        len = sec_buf_in->buf_ptr - sec_buf_in->buf_end;
        if ( len > 0 )
-               memmove( sec_buf_in->buf_base, sec_buf_in->buf_base +
+               AC_MEMCPY( sec_buf_in->buf_base, sec_buf_in->buf_base +
                        sec_buf_in->buf_end, len );
    
        if ( len >= 4 ) {
                sec_buf_in->buf_end = sb_sasl_pkt_length( sec_buf_in->buf_base,
-                       debuglevel);
+                       max, debuglevel);
        }
        else {
                sec_buf_in->buf_end = 0;
@@ -189,7 +238,11 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
        if ( len == 0 )
                return bufptr;
 
+#if SASL_VERSION_MAJOR >= 2
+       ber_pvt_sb_buf_init( &p->buf_in );
+#else
        ber_pvt_sb_buf_destroy( &p->buf_in );
+#endif
 
        /* Read the length of the packet */
        while ( p->sec_buf_in.buf_ptr < 4 ) {
@@ -207,10 +260,10 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
 
        /* The new packet always starts at p->sec_buf_in.buf_base */
        ret = sb_sasl_pkt_length( p->sec_buf_in.buf_base,
-               sbiod->sbiod_sb->sb_debug );
+               *p->sasl_maxbuf, sbiod->sbiod_sb->sb_debug );
 
        /* Grow the packet buffer if neccessary */
-       if ( ( p->sec_buf_in.buf_size < ret ) && 
+       if ( ( p->sec_buf_in.buf_size < (ber_len_t) ret ) && 
                ber_pvt_sb_grow_buffer( &p->sec_buf_in, ret ) < 0 )
        {
                errno = ENOMEM;
@@ -237,21 +290,22 @@ sb_sasl_read( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
 
        /* Decode the packet */
        ret = sasl_decode( p->sasl_context, p->sec_buf_in.buf_base,
-               p->sec_buf_in.buf_end, &p->buf_in.buf_base,
+               p->sec_buf_in.buf_end,
+               (SASL_CONST char **)&p->buf_in.buf_base,
                (unsigned *)&p->buf_in.buf_end );
+
+       /* Drop the packet from the input buffer */
+       sb_sasl_drop_packet( &p->sec_buf_in,
+                       *p->sasl_maxbuf, sbiod->sbiod_sb->sb_debug );
+
        if ( ret != SASL_OK ) {
                ber_log_printf( LDAP_DEBUG_ANY, sbiod->sbiod_sb->sb_debug,
                        "sb_sasl_read: failed to decode packet: %s\n",
                        sasl_errstring( ret, NULL, NULL ) );
-               sb_sasl_drop_packet( &p->sec_buf_in,
-                       sbiod->sbiod_sb->sb_debug );
                errno = EIO;
                return -1;
        }
        
-       /* Drop the packet from the input buffer */
-       sb_sasl_drop_packet( &p->sec_buf_in, sbiod->sbiod_sb->sb_debug );
-
        p->buf_in.buf_size = p->buf_in.buf_end;
 
        bufptr += ber_pvt_sb_copy_out( &p->buf_in, (char*) buf + bufptr, len );
@@ -278,8 +332,15 @@ sb_sasl_write( Sockbuf_IO_Desc *sbiod, void *buf, ber_len_t len)
        }
 
        /* now encode the next packet. */
+#if SASL_VERSION_MAJOR >= 2
+       ber_pvt_sb_buf_init( &p->buf_out );
+#else
        ber_pvt_sb_buf_destroy( &p->buf_out );
-       ret = sasl_encode( p->sasl_context, buf, len, &p->buf_out.buf_base,
+#endif
+       if ( len > *p->sasl_maxbuf - 100 )
+               len = *p->sasl_maxbuf - 100;    /* For safety margin */
+       ret = sasl_encode( p->sasl_context, buf, len,
+               (SASL_CONST char **)&p->buf_out.buf_base,
                (unsigned *)&p->buf_out.buf_size );
        if ( ret != SASL_OK ) {
                ber_log_printf( LDAP_DEBUG_ANY, sbiod->sbiod_sb->sb_debug,
@@ -321,8 +382,12 @@ Sockbuf_IO ldap_pvt_sockbuf_io_sasl = {
 
 int ldap_pvt_sasl_install( Sockbuf *sb, void *ctx_arg )
 {
+#ifdef NEW_LOGGING
+       LDAP_LOG ( TRANSPORT, ENTRY, "ldap_pvt_sasl_install\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_pvt_sasl_install\n",
                0, 0, 0 );
+#endif
 
        /* don't install the stuff unless security has been negotiated */
 
@@ -393,19 +458,6 @@ ldap_int_sasl_open(
        int rc;
        sasl_conn_t *ctx;
 
-       sasl_callback_t *session_callbacks =
-               ber_memcalloc( 2, sizeof( sasl_callback_t ) );
-
-       if( session_callbacks == NULL ) return LDAP_NO_MEMORY;
-
-       session_callbacks[0].id = SASL_CB_USER;
-       session_callbacks[0].proc = NULL;
-       session_callbacks[0].context = ld;
-
-       session_callbacks[1].id = SASL_CB_LIST_END;
-       session_callbacks[1].proc = NULL;
-       session_callbacks[1].context = NULL;
-
        assert( lc->lconn_sasl_ctx == NULL );
 
        if ( host == NULL ) {
@@ -413,29 +465,48 @@ ldap_int_sasl_open(
                return ld->ld_errno;
        }
 
-       rc = sasl_client_new( "ldap", host, session_callbacks,
+#if SASL_VERSION_MAJOR >= 2
+       rc = sasl_client_new( "ldap", host, NULL, NULL,
+               NULL, 0, &ctx );
+#else
+       rc = sasl_client_new( "ldap", host, NULL,
                SASL_SECURITY_LAYER, &ctx );
+#endif
 
        if ( rc != SASL_OK ) {
                ld->ld_errno = sasl_err2ldap( rc );
                return ld->ld_errno;
        }
 
-       Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_open: %s\n",
+#ifdef NEW_LOGGING
+       LDAP_LOG ( TRANSPORT, DETAIL1, "ldap_int_sasl_open: host=%s\n", 
                host, 0, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_open: host=%s\n",
+               host, 0, 0 );
+#endif
 
        lc->lconn_sasl_ctx = ctx;
 
        if( ssf ) {
+#if SASL_VERSION_MAJOR >= 2
+               (void) sasl_setprop( ctx, SASL_SSF_EXTERNAL,
+                       (void *) &ssf );
+#else
                sasl_external_properties_t extprops;
                memset(&extprops, 0L, sizeof(extprops));
                extprops.ssf = ssf;
 
                (void) sasl_setprop( ctx, SASL_SSF_EXTERNAL,
                        (void *) &extprops );
-
+#endif
+#ifdef NEW_LOGGING
+               LDAP_LOG ( TRANSPORT, DETAIL1, 
+                       "ldap_int_sasl_open: ssf=%ld\n", (long) ssf, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_open: ssf=%ld\n",
                        (long) ssf, 0, 0 );
+#endif
        }
 
        return LDAP_SUCCESS;
@@ -475,8 +546,13 @@ ldap_int_sasl_bind(
        struct berval ccred;
        ber_socket_t            sd;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( TRANSPORT, ARGS, "ldap_int_sasl_bind: %s\n", 
+               mechs ? mechs : "<null>", 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_int_sasl_bind: %s\n",
                mechs ? mechs : "<null>", 0, 0 );
+#endif
 
        /* do a quick !LDAPv3 check... ldap_sasl_bind will do the rest. */
        if (ld->ld_version < LDAP_VERSION3) {
@@ -518,9 +594,11 @@ ldap_int_sasl_bind(
        do {
                saslrc = sasl_client_start( ctx,
                        mechs,
+#if SASL_VERSION_MAJOR < 2
                        NULL,
+#endif
                        &prompts,
-                       &ccred.bv_val,
+                       (SASL_CONST char **)&ccred.bv_val,
                        &credlen,
                        &mech );
 
@@ -534,6 +612,14 @@ ldap_int_sasl_bind(
                        }
                }
 
+#if SASL_VERSION_MAJOR >= 2
+               /* XXX the application should free interact results. */
+               if ( prompts != NULL && prompts->result != NULL ) {
+                       LDAP_FREE( (void *)prompts->result );
+                       prompts->result = NULL;
+               }
+#endif
+
                if( saslrc == SASL_INTERACT ) {
                        int res;
                        if( !interact ) break;
@@ -548,6 +634,9 @@ ldap_int_sasl_bind(
 
        if ( (saslrc != SASL_OK) && (saslrc != SASL_CONTINUE) ) {
                ld->ld_errno = sasl_err2ldap( saslrc );
+#if SASL_VERSION_MAJOR >= 2
+               ld->ld_error = (char *)sasl_errdetail( ctx );
+#endif
                return ld->ld_errno;
        }
 
@@ -560,16 +649,24 @@ ldap_int_sasl_bind(
                rc = ldap_sasl_bind_s( ld, dn, mech, &ccred, sctrls, cctrls, &scred );
 
                if ( ccred.bv_val != NULL ) {
+#if SASL_VERSION_MAJOR < 2
                        LDAP_FREE( ccred.bv_val );
+#endif
                        ccred.bv_val = NULL;
                }
 
                if ( rc != LDAP_SUCCESS && rc != LDAP_SASL_BIND_IN_PROGRESS ) {
                        if( scred && scred->bv_len ) {
                                /* and server provided us with data? */
+#ifdef NEW_LOGGING
+                               LDAP_LOG ( TRANSPORT, DETAIL1, 
+                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
+                                       rc, saslrc, scred->bv_len );
+#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
                                        rc, saslrc, scred->bv_len );
+#endif
                                ber_bvfree( scred );
                        }
                        return ld->ld_errno;
@@ -579,9 +676,15 @@ ldap_int_sasl_bind(
                        /* we're done, no need to step */
                        if( scred && scred->bv_len ) {
                                /* but server provided us with data! */
+#ifdef NEW_LOGGING
+                               LDAP_LOG ( TRANSPORT, DETAIL1, 
+                                       "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n", 
+                                       rc, saslrc, scred->bv_len );
+#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "ldap_int_sasl_bind: rc=%d sasl=%d len=%ld\n",
                                        rc, saslrc, scred->bv_len );
+#endif
                                ber_bvfree( scred );
                                return ld->ld_errno = LDAP_LOCAL_ERROR;
                        }
@@ -593,11 +696,24 @@ ldap_int_sasl_bind(
                                (scred == NULL) ? NULL : scred->bv_val,
                                (scred == NULL) ? 0 : scred->bv_len,
                                &prompts,
-                               &ccred.bv_val,
+                               (SASL_CONST char **)&ccred.bv_val,
                                &credlen );
 
-                       Debug( LDAP_DEBUG_TRACE, "sasl_client_start: %d\n",
+#ifdef NEW_LOGGING
+                               LDAP_LOG ( TRANSPORT, DETAIL1, 
+                                       "ldap_int_sasl_bind: sasl_client_step: %d\n", saslrc,0,0 );
+#else
+                       Debug( LDAP_DEBUG_TRACE, "sasl_client_step: %d\n",
                                saslrc, 0, 0 );
+#endif
+
+#if SASL_VERSION_MAJOR >= 2
+                       /* XXX the application should free interact results. */
+                       if ( prompts != NULL && prompts->result != NULL ) {
+                               LDAP_FREE( (void *)prompts->result );
+                               prompts->result = NULL;
+                       }
+#endif
 
                        if( saslrc == SASL_INTERACT ) {
                                int res;
@@ -614,6 +730,9 @@ ldap_int_sasl_bind(
 
                if ( (saslrc != SASL_OK) && (saslrc != SASL_CONTINUE) ) {
                        ld->ld_errno = sasl_err2ldap( saslrc );
+#if SASL_VERSION_MAJOR >= 2
+                       ld->ld_error = (char *)sasl_errdetail( ctx );
+#endif
                        return ld->ld_errno;
                }
        } while ( rc == LDAP_SASL_BIND_IN_PROGRESS );
@@ -623,22 +742,29 @@ ldap_int_sasl_bind(
        }
 
        if ( saslrc != SASL_OK ) {
+#if SASL_VERSION_MAJOR >= 2
+               ld->ld_error = (char *)sasl_errdetail( ctx );
+#endif
                return ld->ld_errno = sasl_err2ldap( saslrc );
        }
 
        if( flags != LDAP_SASL_QUIET ) {
-               saslrc = sasl_getprop( ctx, SASL_USERNAME, (void **) &data );
+               saslrc = sasl_getprop( ctx, SASL_USERNAME, (SASL_CONST void **) &data );
                if( saslrc == SASL_OK && data && *data ) {
                        fprintf( stderr, "SASL username: %s\n", data );
                }
 
-               saslrc = sasl_getprop( ctx, SASL_REALM, (void **) &data );
+#if SASL_VERSION_MAJOR >= 2
+               saslrc = sasl_getprop( ctx, SASL_DEFUSERREALM, (SASL_CONST void **) &data );
+#else
+               saslrc = sasl_getprop( ctx, SASL_REALM, (SASL_CONST void **) &data );
+#endif
                if( saslrc == SASL_OK && data && *data ) {
                        fprintf( stderr, "SASL realm: %s\n", data );
                }
        }
 
-       saslrc = sasl_getprop( ctx, SASL_SSF, (void **) &ssf );
+       saslrc = sasl_getprop( ctx, SASL_SSF, (SASL_CONST void **) &ssf );
        if( saslrc == SASL_OK ) {
                if( flags != LDAP_SASL_QUIET ) {
                        fprintf( stderr, "SASL SSF: %lu\n",
@@ -649,7 +775,7 @@ ldap_int_sasl_bind(
                        if( flags != LDAP_SASL_QUIET ) {
                                fprintf( stderr, "SASL installing layers\n" );
                        }
-                       ldap_pvt_sasl_install( ld->ld_sb, ctx );
+                       ldap_pvt_sasl_install( ld->ld_conns->lconn_sb, ctx );
                }
        }
 
@@ -659,30 +785,35 @@ ldap_int_sasl_bind(
 int
 ldap_int_sasl_external(
        LDAP *ld,
+       LDAPConn *conn,
        const char * authid,
        ber_len_t ssf )
 {
        int sc;
        sasl_conn_t *ctx;
+#if SASL_VERSION_MAJOR < 2
        sasl_external_properties_t extprops;
+#endif
 
-       if( ld->ld_defconn == NULL ) {
-               return LDAP_LOCAL_ERROR;
-       }
-
-       ctx = ld->ld_defconn->lconn_sasl_ctx;
+       ctx = conn->lconn_sasl_ctx;
 
        if ( ctx == NULL ) {
                return LDAP_LOCAL_ERROR;
        }
-    
+   
+#if SASL_VERSION_MAJOR >= 2
+       sc = sasl_setprop( ctx, SASL_SSF_EXTERNAL, &ssf );
+       if ( sc == SASL_OK )
+               sc = sasl_setprop( ctx, SASL_AUTH_EXTERNAL, authid );
+#else
        memset( &extprops, '\0', sizeof(extprops) );
        extprops.ssf = ssf;
        extprops.auth_id = (char *) authid;
-    
+
        sc = sasl_setprop( ctx, SASL_SSF_EXTERNAL,
                (void *) &extprops );
-    
+#endif
+
        if ( sc != SASL_OK ) {
                return LDAP_LOCAL_ERROR;
        }
@@ -741,7 +872,7 @@ int ldap_pvt_sasl_secprops(
                } else if( !strncasecmp(props[i],
                        "minssf=", sizeof("minssf")) )
                {
-                       if( isdigit( props[i][sizeof("minssf")] ) ) {
+                       if( isdigit( (unsigned char) props[i][sizeof("minssf")] ) ) {
                                got_min_ssf++;
                                min_ssf = atoi( &props[i][sizeof("minssf")] );
                        } else {
@@ -751,7 +882,7 @@ int ldap_pvt_sasl_secprops(
                } else if( !strncasecmp(props[i],
                        "maxssf=", sizeof("maxssf")) )
                {
-                       if( isdigit( props[i][sizeof("maxssf")] ) ) {
+                       if( isdigit( (unsigned char) props[i][sizeof("maxssf")] ) ) {
                                got_max_ssf++;
                                max_ssf = atoi( &props[i][sizeof("maxssf")] );
                        } else {
@@ -761,7 +892,7 @@ int ldap_pvt_sasl_secprops(
                } else if( !strncasecmp(props[i],
                        "maxbufsize=", sizeof("maxbufsize")) )
                {
-                       if( isdigit( props[i][sizeof("maxbufsize")] ) ) {
+                       if( isdigit( (unsigned char) props[i][sizeof("maxbufsize")] ) ) {
                                got_maxbufsize++;
                                maxbufsize = atoi( &props[i][sizeof("maxbufsize")] );
                        } else {
@@ -851,7 +982,7 @@ ldap_int_sasl_get_option( LDAP *ld, int option, void *arg )
                        }
 
                        sc = sasl_getprop( ctx, SASL_SSF,
-                               (void **) &ssf );
+                               (SASL_CONST void **) &ssf );
 
                        if ( sc != SASL_OK ) {
                                return -1;
@@ -897,7 +1028,9 @@ ldap_int_sasl_set_option( LDAP *ld, int option, void *arg )
 
        case LDAP_OPT_X_SASL_SSF_EXTERNAL: {
                int sc;
+#if SASL_VERSION_MAJOR < 2
                sasl_external_properties_t extprops;
+#endif
                sasl_conn_t *ctx;
 
                if( ld->ld_defconn == NULL ) {
@@ -910,12 +1043,16 @@ ldap_int_sasl_set_option( LDAP *ld, int option, void *arg )
                        return -1;
                }
 
+#if SASL_VERSION_MAJOR >= 2
+               sc = sasl_setprop( ctx, SASL_SSF_EXTERNAL, arg);
+#else
                memset(&extprops, 0L, sizeof(extprops));
 
                extprops.ssf = * (ber_len_t *) arg;
 
                sc = sasl_setprop( ctx, SASL_SSF_EXTERNAL,
                        (void *) &extprops );
+#endif
 
                if ( sc != SASL_OK ) {
                        return -1;
@@ -1001,6 +1138,7 @@ ldap_int_sasl_bind(
 int
 ldap_int_sasl_external(
        LDAP *ld,
+       LDAPConn *conn,
        const char * authid,
        ber_len_t ssf )
 { return LDAP_SUCCESS; }