For ITS#2424, move all SASL session management to ldap_int_sasl_bind.

[openldap] / libraries / libldap / getattr.c

diff --git a/libraries/libldap/getattr.c b/libraries/libldap/getattr.c
index 2c78f230b31f7c1baa4f7515b099cbc2b7df7872..6e67e71c681434bf499c012023e3d0288727252e 100644 (file)
--- a/libraries/libldap/getattr.c
+++ b/libraries/libldap/getattr.c
@@ -1,6 +1,6 @@
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 /*  Portions
@@ -24,15 +24,17 @@
 char *
 ldap_first_attribute( LDAP *ld, LDAPMessage *entry, BerElement **berout )
 {
-#if LBER_SEQORSET_AVOID_OVERRUN
        int rc;
-#endif
        ber_tag_t tag;
-       ber_len_t len;
+       ber_len_t len = 0;
        char *attr;
        BerElement *ber;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_first_attribute\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_first_attribute\n", 0, 0, 0 );
+#endif
 
        assert( ld != NULL );
        assert( LDAP_VALID( ld ) );
@@ -53,20 +55,13 @@ ldap_first_attribute( LDAP *ld, LDAPMessage *entry, BerElement **berout )
         * us at the first attribute.
         */
 
-       tag = ber_scanf( ber, "{xl{" /*}}*/, &attr, &len );
+       tag = ber_scanf( ber, "{xl{" /*}}*/, &len );
        if( tag == LBER_ERROR ) {
                ld->ld_errno = LDAP_DECODING_ERROR;
                ber_free( ber, 0 );
-               return  NULL;
-       }
-
-#if LDAP_SEQORSET_BAILOUT
-       if( len == 0 ) {
                return NULL;
        }
-#endif
-       
-#if LBER_SEQORSET_AVOID_OVERRUN
+
        /* set the length to avoid overrun */
        rc = ber_set_option( ber, LBER_OPT_REMAINING_BYTES, &len );
        if( rc != LBER_OPT_SUCCESS ) {
@@ -74,7 +69,13 @@ ldap_first_attribute( LDAP *ld, LDAPMessage *entry, BerElement **berout )
                ber_free( ber, 0 );
                return NULL;
        }
-#endif
+
+       if ( ber_pvt_ber_remaining( ber ) == 0 ) {
+               assert( len == 0 );
+               ber_free( ber, 0 );
+               return NULL;
+       }
+       assert( len != 0 );
 
        /* snatch the first attribute */
        tag = ber_scanf( ber, "{ax}", &attr );
@@ -95,18 +96,20 @@ ldap_next_attribute( LDAP *ld, LDAPMessage *entry, BerElement *ber )
        ber_tag_t tag;
        char *attr;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_next_attribute\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_next_attribute\n", 0, 0, 0 );
+#endif
 
        assert( ld != NULL );
        assert( LDAP_VALID( ld ) );
        assert( entry != NULL );
        assert( ber != NULL );
 
-#if LDAP_SEQORSET_BAILOUT
        if ( ber_pvt_ber_remaining( ber ) == 0 ) {
                return NULL;
        }
-#endif
 
        /* skip sequence, snarf attribute type, skip values */
        tag = ber_scanf( ber, "{ax}", &attr ); 
@@ -117,3 +120,38 @@ ldap_next_attribute( LDAP *ld, LDAPMessage *entry, BerElement *ber )
 
        return attr;
 }
+
+/* Fetch attribute type and optionally fetch values */
+/* ARGSUSED */
+int
+ldap_get_attribute_ber( LDAP *ld, LDAPMessage *entry, BerElement *ber,
+       BerValue *attr, BerVarray *vals )
+{
+       ber_tag_t tag;
+       int rc = LDAP_SUCCESS;
+
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_get_attribute_ber\n", 0, 0, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, "ldap_get_attribute_ber\n", 0, 0, 0 );
+#endif
+
+       assert( ld != NULL );
+       assert( LDAP_VALID( ld ) );
+       assert( entry != NULL );
+       assert( ber != NULL );
+       assert( attr != NULL );
+
+       attr->bv_val = NULL;
+       attr->bv_len = 0;
+
+       if ( ber_pvt_ber_remaining( ber ) ) {
+               /* skip sequence, snarf attribute type */
+               tag = ber_scanf( ber, vals ? "{mW}" : "{mx}", attr, vals ); 
+               if( tag == LBER_ERROR ) {
+                       rc = ld->ld_errno = LDAP_DECODING_ERROR;
+               }
+       }
+
+       return rc;
+}