]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/os-ip.c
ITS#6689
[openldap] / libraries / libldap / os-ip.c
index 31b1049b925b53bc9db7f5800c92bd84b0c173ec..424ef02e669af66483dbc639d73c76364848214a 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2004 The OpenLDAP Foundation.
+ * Copyright 1998-2010 The OpenLDAP Foundation.
  * Portions Copyright 1999 Lars Uffmann.
  * All rights reserved.
  *
@@ -36,6 +36,9 @@
 #ifdef HAVE_IO_H
 #include <io.h>
 #endif /* HAVE_IO_H */
+#ifdef HAVE_FCNTL_H
+#include <fcntl.h>
+#endif
 
 #include "ldap-int.h"
 
@@ -63,7 +66,7 @@ do { \
 static void
 ldap_pvt_set_errno(int err)
 {
-       errno = err;
+       sock_errset(err);
 }
 
 int
@@ -110,6 +113,9 @@ ldap_int_socket(LDAP *ld, int family, int type )
 {
        ber_socket_t s = socket(family, type, 0);
        osip_debug(ld, "ldap_new_socket: %d\n",s,0,0);
+#ifdef FD_CLOEXEC
+       fcntl(s, F_SETFD, FD_CLOEXEC);
+#endif
        return ( s );
 }
 
@@ -123,20 +129,82 @@ ldap_pvt_close_socket(LDAP *ld, int s)
 static int
 ldap_int_prepare_socket(LDAP *ld, int s, int proto )
 {
-       osip_debug(ld, "ldap_prepare_socket: %d\n", s,0,0);
+       osip_debug( ld, "ldap_prepare_socket: %d\n", s, 0, 0 );
 
-#ifdef TCP_NODELAY
-       if( proto == LDAP_PROTO_TCP ) {
+#if defined( SO_KEEPALIVE ) || defined( TCP_NODELAY )
+       if ( proto == LDAP_PROTO_TCP ) {
                int dummy = 1;
+#ifdef SO_KEEPALIVE
+               if ( setsockopt( s, SOL_SOCKET, SO_KEEPALIVE,
+                       (char*) &dummy, sizeof(dummy) ) == AC_SOCKET_ERROR )
+               {
+                       osip_debug( ld, "ldap_prepare_socket: "
+                               "setsockopt(%d, SO_KEEPALIVE) failed (ignored).\n",
+                               s, 0, 0 );
+               }
+               if ( ld->ld_options.ldo_keepalive_idle > 0 )
+               {
+#ifdef TCP_KEEPIDLE
+                       if ( setsockopt( s, IPPROTO_TCP, TCP_KEEPIDLE,
+                                       (void*) &ld->ld_options.ldo_keepalive_idle,
+                                       sizeof(ld->ld_options.ldo_keepalive_idle) ) == AC_SOCKET_ERROR )
+                       {
+                               osip_debug( ld, "ldap_prepare_socket: "
+                                       "setsockopt(%d, TCP_KEEPIDLE) failed (ignored).\n",
+                                       s, 0, 0 );
+                       }
+#else
+                       osip_debug( ld, "ldap_prepare_socket: "
+                                       "sockopt TCP_KEEPIDLE not supported on this system.\n", 
+                                       0, 0, 0 );
+#endif /* TCP_KEEPIDLE */
+               }
+               if ( ld->ld_options.ldo_keepalive_probes > 0 )
+               {
+#ifdef TCP_KEEPCNT
+                       if ( setsockopt( s, IPPROTO_TCP, TCP_KEEPCNT,
+                                       (void*) &ld->ld_options.ldo_keepalive_probes,
+                                       sizeof(ld->ld_options.ldo_keepalive_probes) ) == AC_SOCKET_ERROR )
+                       {
+                               osip_debug( ld, "ldap_prepare_socket: "
+                                       "setsockopt(%d, TCP_KEEPCNT) failed (ignored).\n",
+                                       s, 0, 0 );
+                       }
+#else
+                       osip_debug( ld, "ldap_prepare_socket: "
+                                       "sockopt TCP_KEEPCNT not supported on this system.\n", 
+                                       0, 0, 0 );
+#endif /* TCP_KEEPCNT */
+               }
+               if ( ld->ld_options.ldo_keepalive_interval > 0 )
+               {
+#ifdef TCP_KEEPINTVL
+                       if ( setsockopt( s, IPPROTO_TCP, TCP_KEEPINTVL,
+                                       (void*) &ld->ld_options.ldo_keepalive_interval,
+                                       sizeof(ld->ld_options.ldo_keepalive_interval) ) == AC_SOCKET_ERROR )
+                       {
+                               osip_debug( ld, "ldap_prepare_socket: "
+                                       "setsockopt(%d, TCP_KEEPINTVL) failed (ignored).\n",
+                                       s, 0, 0 );
+                       } 
+#else
+                       osip_debug( ld, "ldap_prepare_socket: "
+                                       "sockopt TCP_KEEPINTVL not supported on this system.\n", 
+                                       0, 0, 0 );
+#endif /* TCP_KEEPINTVL */
+               }
+#endif /* SO_KEEPALIVE */
+#ifdef TCP_NODELAY
                if ( setsockopt( s, IPPROTO_TCP, TCP_NODELAY,
                        (char*) &dummy, sizeof(dummy) ) == AC_SOCKET_ERROR )
                {
-                       osip_debug(ld, "ldap_prepare_socket: "
+                       osip_debug( ld, "ldap_prepare_socket: "
                                "setsockopt(%d, TCP_NODELAY) failed (ignored).\n",
-                               s, 0, 0);
+                               s, 0, 0 );
                }
+#endif /* TCP_NODELAY */
        }
-#endif
+#endif /* SO_KEEPALIVE || TCP_NODELAY */
 
        return 0;
 }
@@ -163,7 +231,7 @@ ldap_pvt_is_socket_ready(LDAP *ld, int s)
 #if defined( notyet ) /* && defined( SO_ERROR ) */
 {
        int so_errno;
-       socklen_t dummy = sizeof(so_errno);
+       ber_socklen_t dummy = sizeof(so_errno);
        if ( getsockopt( s, SOL_SOCKET, SO_ERROR, &so_errno, &dummy )
                == AC_SOCKET_ERROR )
        {
@@ -185,12 +253,12 @@ ldap_pvt_is_socket_ready(LDAP *ld, int s)
        struct sockaddr_in sin;
 #endif
        char ch;
-       socklen_t dummy = sizeof(sin);
+       ber_socklen_t dummy = sizeof(sin);
        if ( getpeername( s, (struct sockaddr *) &sin, &dummy )
                == AC_SOCKET_ERROR )
        {
                /* XXX: needs to be replace with ber_stream_read() */
-               read(s, &ch, 1);
+               (void)read(s, &ch, 1);
                TRACE;
                return -1;
        }
@@ -203,161 +271,270 @@ ldap_pvt_is_socket_ready(LDAP *ld, int s)
 
 #endif /* HAVE_WINSOCK */
 
-static int
-ldap_pvt_connect(LDAP *ld, ber_socket_t s,
-       struct sockaddr *sin, socklen_t addrlen,
-       int async)
+/* NOTE: this is identical to analogous code in os-local.c */
+int
+ldap_int_poll(
+       LDAP *ld,
+       ber_socket_t s,
+       struct timeval *tvp )
 {
-       int rc;
-       struct timeval  tv, *opt_tv=NULL;
+       int             rc;
+               
 
-#ifdef LDAP_CONNECTIONLESS
-       /* We could do a connect() but that would interfere with
-        * attempts to poll a broadcast address
-        */
-       if (LDAP_IS_UDP(ld)) {
-               if (ld->ld_options.ldo_peer)
-                       ldap_memfree(ld->ld_options.ldo_peer);
-               ld->ld_options.ldo_peer=ldap_memalloc(sizeof(struct sockaddr));
-               AC_MEMCPY(ld->ld_options.ldo_peer,sin,sizeof(struct sockaddr));
-               return ( 0 );
-       }
-#endif
-       if ( (opt_tv = ld->ld_options.ldo_tm_net) != NULL ) {
-               tv.tv_usec = opt_tv->tv_usec;
-               tv.tv_sec = opt_tv->tv_sec;
-       }
-
-       osip_debug(ld, "ldap_connect_timeout: fd: %d tm: %ld async: %d\n",
-                       s, opt_tv ? tv.tv_sec : -1L, async);
-
-       if ( ldap_pvt_ndelay_on(ld, s) == -1 )
-               return ( -1 );
-
-       if ( connect(s, sin, addrlen) != AC_SOCKET_ERROR ) {
-               if ( ldap_pvt_ndelay_off(ld, s) == -1 )
-                       return ( -1 );
-               return ( 0 );
-       }
-
-#ifdef HAVE_WINSOCK
-       ldap_pvt_set_errno( WSAGetLastError() );
-#endif
-
-       if ( errno != EINPROGRESS && errno != EWOULDBLOCK ) {
-               return ( -1 );
-       }
-       
-#ifdef notyet
-       if ( async ) return ( -2 );
-#endif
+       osip_debug(ld, "ldap_int_poll: fd: %d tm: %ld\n",
+               s, tvp ? tvp->tv_sec : -1L, 0);
 
 #ifdef HAVE_POLL
        {
                struct pollfd fd;
                int timeout = INFTIM;
 
-               if( opt_tv != NULL ) timeout = TV2MILLISEC( &tv );
-
                fd.fd = s;
-               fd.events = POLLOUT;
+               fd.events = POLL_WRITE;
 
+               if ( tvp != NULL ) {
+                       timeout = TV2MILLISEC( tvp );
+               }
                do {
                        fd.revents = 0;
                        rc = poll( &fd, 1, timeout );
-               } while( rc == AC_SOCKET_ERROR && errno == EINTR &&
-                       LDAP_BOOL_GET(&ld->ld_options, LDAP_BOOL_RESTART ));
+               
+               } while ( rc == AC_SOCKET_ERROR && errno == EINTR &&
+                       LDAP_BOOL_GET( &ld->ld_options, LDAP_BOOL_RESTART ) );
 
-               if( rc == AC_SOCKET_ERROR ) return rc;
+               if ( rc == AC_SOCKET_ERROR ) {
+                       return rc;
+               }
+
+               if ( timeout == 0 && rc == 0 ) {
+                       return -2;
+               }
+
+               if ( fd.revents & POLL_WRITE ) {
+                       if ( ldap_pvt_is_socket_ready( ld, s ) == -1 ) {
+                               return -1;
+                       }
 
-               if( fd.revents & POLLOUT ) {
-                       if ( ldap_pvt_is_socket_ready(ld, s) == -1 ) return -1;
-                       if ( ldap_pvt_ndelay_off(ld, s) == -1 ) return -1;
-                       return ( 0 );
+                       if ( ldap_pvt_ndelay_off( ld, s ) == -1 ) {
+                               return -1;
+                       }
+                       return 0;
                }
        }
 #else
        {
-               fd_set          wfds, *z=NULL;
+               fd_set          wfds, *z = NULL;
 #ifdef HAVE_WINSOCK
                fd_set          efds;
 #endif
-               FD_ZERO(&wfds);
-               FD_SET(s, &wfds );
+               struct timeval  tv = { 0 };
+
+#if defined( FD_SETSIZE ) && !defined( HAVE_WINSOCK )
+               if ( s >= FD_SETSIZE ) {
+                       rc = AC_SOCKET_ERROR;
+                       tcp_close( s );
+                       ldap_pvt_set_errno( EMFILE );
+                       return rc;
+               }
+#endif
+
+               if ( tvp != NULL ) {
+                       tv = *tvp;
+               }
+
+               do {
+                       FD_ZERO(&wfds);
+                       FD_SET(s, &wfds );
 
 #ifdef HAVE_WINSOCK
-               FD_ZERO(&efds);
-               FD_SET(s, &efds );
+                       FD_ZERO(&efds);
+                       FD_SET(s, &efds );
 #endif
 
-               do {
-                       rc = select(ldap_int_tblsize, z, &wfds,
+                       rc = select( ldap_int_tblsize, z, &wfds,
 #ifdef HAVE_WINSOCK
                                &efds,
 #else
                                z,
 #endif
-                               opt_tv ? &tv : NULL);
-               } while( rc == AC_SOCKET_ERROR && errno == EINTR &&
-                       LDAP_BOOL_GET(&ld->ld_options, LDAP_BOOL_RESTART ));
+                               tvp ? &tv : NULL );
+               } while ( rc == AC_SOCKET_ERROR && errno == EINTR &&
+                       LDAP_BOOL_GET( &ld->ld_options, LDAP_BOOL_RESTART ) );
+
+               if ( rc == AC_SOCKET_ERROR ) {
+                       return rc;
+               }
 
-               if( rc == AC_SOCKET_ERROR ) return rc;
+               if ( rc == 0 && tvp && tvp->tv_sec == 0 && tvp->tv_usec == 0 ) {
+                       return -2;
+               }
 
 #ifdef HAVE_WINSOCK
                /* This means the connection failed */
                if ( FD_ISSET(s, &efds) ) {
-                   int so_errno;
-                   int dummy = sizeof(so_errno);
-                   if ( getsockopt( s, SOL_SOCKET, SO_ERROR,
+                       int so_errno;
+                       ber_socklen_t dummy = sizeof(so_errno);
+                       if ( getsockopt( s, SOL_SOCKET, SO_ERROR,
                                (char *) &so_errno, &dummy ) == AC_SOCKET_ERROR || !so_errno )
-                   {
-                       /* impossible */
-                       so_errno = WSAGetLastError();
-                   }
-                   ldap_pvt_set_errno(so_errno);
-                   osip_debug(ld, "ldap_pvt_connect: error on socket %d: "
-                              "errno: %d (%s)\n", s, errno, sock_errstr(errno));
-                   return -1;
+                       {
+                               /* impossible */
+                               so_errno = WSAGetLastError();
+                       }
+                       ldap_pvt_set_errno( so_errno );
+                       osip_debug(ld, "ldap_int_poll: error on socket %d: "
+                              "errno: %d (%s)\n", s, errno, sock_errstr( errno ));
+                       return -1;
                }
 #endif
                if ( FD_ISSET(s, &wfds) ) {
 #ifndef HAVE_WINSOCK
-                       if ( ldap_pvt_is_socket_ready(ld, s) == -1 ) return -1;
+                       if ( ldap_pvt_is_socket_ready( ld, s ) == -1 ) {
+                               return -1;
+                       }
 #endif
-                       if ( ldap_pvt_ndelay_off(ld, s) == -1 ) return -1;
+                       if ( ldap_pvt_ndelay_off(ld, s) == -1 ) {
+                               return -1;
+                       }
                        return 0;
                }
        }
 #endif
 
-       osip_debug(ld, "ldap_connect_timeout: timed out\n",0,0,0);
+       osip_debug(ld, "ldap_int_poll: timed out\n",0,0,0);
        ldap_pvt_set_errno( ETIMEDOUT );
        return -1;
 }
 
+static int
+ldap_pvt_connect(LDAP *ld, ber_socket_t s,
+       struct sockaddr *sin, ber_socklen_t addrlen,
+       int async)
+{
+       int rc, err;
+       struct timeval  tv, *opt_tv = NULL;
+
+#ifdef LDAP_CONNECTIONLESS
+       /* We could do a connect() but that would interfere with
+        * attempts to poll a broadcast address
+        */
+       if (LDAP_IS_UDP(ld)) {
+               if (ld->ld_options.ldo_peer)
+                       ldap_memfree(ld->ld_options.ldo_peer);
+               ld->ld_options.ldo_peer=ldap_memalloc(sizeof(struct sockaddr));
+               AC_MEMCPY(ld->ld_options.ldo_peer,sin,sizeof(struct sockaddr));
+               return ( 0 );
+       }
+#endif
+       if ( ld->ld_options.ldo_tm_net.tv_sec >= 0 ) {
+               tv = ld->ld_options.ldo_tm_net;
+               opt_tv = &tv;
+       }
+
+       osip_debug(ld, "ldap_pvt_connect: fd: %d tm: %ld async: %d\n",
+                       s, opt_tv ? tv.tv_sec : -1L, async);
+
+       if ( opt_tv && ldap_pvt_ndelay_on(ld, s) == -1 )
+               return ( -1 );
+
+       if ( connect(s, sin, addrlen) != AC_SOCKET_ERROR ) {
+               if ( opt_tv && ldap_pvt_ndelay_off(ld, s) == -1 )
+                       return ( -1 );
+               return ( 0 );
+       }
+
+       err = sock_errno();
+       if ( err != EINPROGRESS && err != EWOULDBLOCK ) {
+               return ( -1 );
+       }
+       
+       if ( async ) {
+               /* caller will call ldap_int_poll() as appropriate? */
+               return ( -2 );
+       }
+
+       rc = ldap_int_poll( ld, s, opt_tv );
+
+       osip_debug(ld, "ldap_pvt_connect: %d\n", rc, 0, 0);
+
+       return rc;
+}
+
 #ifndef HAVE_INET_ATON
 int
 ldap_pvt_inet_aton( const char *host, struct in_addr *in)
 {
        unsigned long u = inet_addr( host );
-       if ( u != 0xffffffff || u != (unsigned long) -1 ) {
-               in->s_addr = u;
-               return 1;
-       }
-       return 0;
+
+#ifdef INADDR_NONE
+       if ( u == INADDR_NONE ) return 0;
+#endif
+       if ( u == 0xffffffffUL || u == (unsigned long) -1L ) return 0;
+
+       in->s_addr = u;
+       return 1;
 }
 #endif
 
+int
+ldap_int_connect_cbs(LDAP *ld, Sockbuf *sb, ber_socket_t *s, LDAPURLDesc *srv, struct sockaddr *addr)
+{
+       struct ldapoptions *lo;
+       ldaplist *ll;
+       ldap_conncb *cb;
+       int rc;
+
+       ber_sockbuf_ctrl( sb, LBER_SB_OPT_SET_FD, s );
+
+       /* Invoke all handle-specific callbacks first */
+       lo = &ld->ld_options;
+       for (ll = lo->ldo_conn_cbs; ll; ll = ll->ll_next) {
+               cb = ll->ll_data;
+               rc = cb->lc_add( ld, sb, srv, addr, cb );
+               /* on any failure, call the teardown functions for anything
+                * that previously succeeded
+                */
+               if ( rc ) {
+                       ldaplist *l2;
+                       for (l2 = lo->ldo_conn_cbs; l2 != ll; l2 = l2->ll_next) {
+                               cb = l2->ll_data;
+                               cb->lc_del( ld, sb, cb );
+                       }
+                       /* a failure might have implicitly closed the fd */
+                       ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, s );
+                       return rc;
+               }
+       }
+       lo = LDAP_INT_GLOBAL_OPT();
+       for (ll = lo->ldo_conn_cbs; ll; ll = ll->ll_next) {
+               cb = ll->ll_data;
+               rc = cb->lc_add( ld, sb, srv, addr, cb );
+               if ( rc ) {
+                       ldaplist *l2;
+                       for (l2 = lo->ldo_conn_cbs; l2 != ll; l2 = l2->ll_next) {
+                               cb = l2->ll_data;
+                               cb->lc_del( ld, sb, cb );
+                       }
+                       lo = &ld->ld_options;
+                       for (l2 = lo->ldo_conn_cbs; l2; l2 = l2->ll_next) {
+                               cb = l2->ll_data;
+                               cb->lc_del( ld, sb, cb );
+                       }
+                       ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, s );
+                       return rc;
+               }
+       }
+       return 0;
+}
 
 int
 ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
-       int proto,
-       const char *host, int port,
+       int proto, LDAPURLDesc *srv,
        int async )
 {
        int     rc;
-       int     socktype;
+       int     socktype, port;
        ber_socket_t            s = AC_SOCKET_INVALID;
+       char *host;
 
 #if defined( HAVE_GETADDRINFO ) && defined( HAVE_INET_NTOP )
        char serv[7];
@@ -372,8 +549,22 @@ ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
        char *ha_buf=NULL;
 #endif
 
-       if( host == NULL ) host = "localhost";
-       
+       if ( srv->lud_host == NULL || *srv->lud_host == 0 ) {
+               host = "localhost";
+       } else {
+               host = srv->lud_host;
+       }
+
+       port = srv->lud_port;
+
+       if( !port ) {
+               if( strcmp(srv->lud_scheme, "ldaps") == 0 ) {
+                       port = LDAPS_PORT;
+               } else {
+                       port = LDAP_PORT;
+               }
+       }
+
        switch(proto) {
        case LDAP_PROTO_TCP: socktype = SOCK_STREAM;
                osip_debug( ld,
@@ -393,6 +584,10 @@ ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
 
 #if defined( HAVE_GETADDRINFO ) && defined( HAVE_INET_NTOP )
        memset( &hints, '\0', sizeof(hints) );
+#ifdef USE_AI_ADDRCONFIG /* FIXME: configure test needed */
+       /* Use AI_ADDRCONFIG only on systems where its known to be needed. */
+       hints.ai_flags = AI_ADDRCONFIG;
+#endif
        hints.ai_family = ldap_int_inet4or6;
        hints.ai_socktype = socktype;
        snprintf(serv, sizeof serv, "%d", port );
@@ -456,9 +651,12 @@ ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
 
                rc = ldap_pvt_connect( ld, s,
                        sai->ai_addr, sai->ai_addrlen, async );
-               if ( (rc == 0) || (rc == -2) ) {
-                       ber_sockbuf_ctrl( sb, LBER_SB_OPT_SET_FD, &s );
-                       break;
+               if ( rc == 0 || rc == -2 ) {
+                       err = ldap_int_connect_cbs( ld, sb, &s, srv, sai->ai_addr );
+                       if ( err )
+                               rc = err;
+                       else
+                               break;
                }
                ldap_pvt_close_socket(ld, s);
        }
@@ -501,7 +699,7 @@ ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
 
                (void)memset((char *)&sin, '\0', sizeof sin);
                sin.sin_family = AF_INET;
-               sin.sin_port = htons((short) port);
+               sin.sin_port = htons((unsigned short) port);
 
                if( use_hp ) {
                        AC_MEMCPY( &sin.sin_addr, hp->h_addr_list[i],
@@ -511,16 +709,29 @@ ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
                                sizeof(sin.sin_addr) );
                }
 
+#ifdef HAVE_INET_NTOA_B
+               {
+                       /* for VxWorks */
+                       char address[INET_ADDR_LEN];
+                       inet_ntoa_b(sin.sin_address, address);
+                       osip_debug(ld, "ldap_connect_to_host: Trying %s:%d\n", 
+                               address, port, 0);
+               }
+#else
                osip_debug(ld, "ldap_connect_to_host: Trying %s:%d\n", 
                        inet_ntoa(sin.sin_addr), port, 0);
+#endif
 
                rc = ldap_pvt_connect(ld, s,
                        (struct sockaddr *)&sin, sizeof(sin),
                        async);
    
                if ( (rc == 0) || (rc == -2) ) {
-                       ber_sockbuf_ctrl( sb, LBER_SB_OPT_SET_FD, &s );
-                       break;
+                       i = ldap_int_connect_cbs( ld, sb, &s, srv, (struct sockaddr *)&sin );
+                       if ( i )
+                               rc = i;
+                       else
+                               break;
                }
 
                ldap_pvt_close_socket(ld, s);
@@ -533,12 +744,11 @@ ldap_connect_to_host(LDAP *ld, Sockbuf *sb,
        return rc;
 }
 
-#if defined( LDAP_API_FEATURE_X_OPENLDAP_V2_KBIND ) || \
-       defined( HAVE_CYRUS_SASL )
+#if defined( HAVE_CYRUS_SASL )
 char *
 ldap_host_connected_to( Sockbuf *sb, const char *host )
 {
-       socklen_t               len;
+       ber_socklen_t   len;
 #ifdef LDAP_PF_INET6
        struct sockaddr_storage sabuf;
 #else
@@ -610,7 +820,7 @@ ldap_host_connected_to( Sockbuf *sb, const char *host )
                char *herr;
 #ifdef NI_MAXHOST
                char hbuf[NI_MAXHOST];
-#elif defined( MAXHOSTNAMELEN
+#elif defined( MAXHOSTNAMELEN )
                char hbuf[MAXHOSTNAMELEN];
 #else
                char hbuf[256];
@@ -629,18 +839,19 @@ ldap_host_connected_to( Sockbuf *sb, const char *host )
 #endif
 
 
+struct selectinfo {
 #ifdef HAVE_POLL
-/* for UNIX poll(2) */
-       /* ??? */
+       /* for UNIX poll(2) */
+       int si_maxfd;
+       struct pollfd si_fds[FD_SETSIZE];
 #else
-/* for UNIX select(2) */
-struct selectinfo {
+       /* for UNIX select(2) */
        fd_set  si_readfds;
        fd_set  si_writefds;
        fd_set  si_use_readfds;
        fd_set  si_use_writefds;
-};
 #endif
+};
 
 void
 ldap_mark_select_write( LDAP *ld, Sockbuf *sb )
@@ -651,9 +862,39 @@ ldap_mark_select_write( LDAP *ld, Sockbuf *sb )
        sip = (struct selectinfo *)ld->ld_selectinfo;
        
        ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, &sd );
+
+#ifdef HAVE_POLL
+       /* for UNIX poll(2) */
+       {
+               int empty=-1;
+               int i;
+               for(i=0; i < sip->si_maxfd; i++) {
+                       if( sip->si_fds[i].fd == sd ) {
+                               sip->si_fds[i].events |= POLL_WRITE;
+                               return;
+                       }
+                       if( empty==-1 && sip->si_fds[i].fd == -1 ) {
+                               empty=i;
+                       }
+               }
+
+               if( empty == -1 ) {
+                       if( sip->si_maxfd >= FD_SETSIZE ) {
+                               /* FIXME */
+                               return;
+                       }
+                       empty = sip->si_maxfd++;
+               }
+
+               sip->si_fds[empty].fd = sd;
+               sip->si_fds[empty].events = POLL_WRITE;
+       }
+#else
+       /* for UNIX select(2) */
        if ( !FD_ISSET( sd, &sip->si_writefds )) {
                FD_SET( sd, &sip->si_writefds );
        }
+#endif
 }
 
 
@@ -666,9 +907,39 @@ ldap_mark_select_read( LDAP *ld, Sockbuf *sb )
        sip = (struct selectinfo *)ld->ld_selectinfo;
 
        ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, &sd );
+
+#ifdef HAVE_POLL
+       /* for UNIX poll(2) */
+       {
+               int empty=-1;
+               int i;
+               for(i=0; i < sip->si_maxfd; i++) {
+                       if( sip->si_fds[i].fd == sd ) {
+                               sip->si_fds[i].events |= POLL_READ;
+                               return;
+                       }
+                       if( empty==-1 && sip->si_fds[i].fd == -1 ) {
+                               empty=i;
+                       }
+               }
+
+               if( empty == -1 ) {
+                       if( sip->si_maxfd >= FD_SETSIZE ) {
+                               /* FIXME */
+                               return;
+                       }
+                       empty = sip->si_maxfd++;
+               }
+
+               sip->si_fds[empty].fd = sd;
+               sip->si_fds[empty].events = POLL_READ;
+       }
+#else
+       /* for UNIX select(2) */
        if ( !FD_ISSET( sd, &sip->si_readfds )) {
                FD_SET( sd, &sip->si_readfds );
        }
+#endif
 }
 
 
@@ -681,8 +952,22 @@ ldap_mark_select_clear( LDAP *ld, Sockbuf *sb )
        sip = (struct selectinfo *)ld->ld_selectinfo;
 
        ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, &sd );
+
+#ifdef HAVE_POLL
+       /* for UNIX poll(2) */
+       {
+               int i;
+               for(i=0; i < sip->si_maxfd; i++) {
+                       if( sip->si_fds[i].fd == sd ) {
+                               sip->si_fds[i].fd = -1;
+                       }
+               }
+       }
+#else
+       /* for UNIX select(2) */
        FD_CLR( sd, &sip->si_writefds );
        FD_CLR( sd, &sip->si_readfds );
+#endif
 }
 
 
@@ -695,7 +980,23 @@ ldap_is_write_ready( LDAP *ld, Sockbuf *sb )
        sip = (struct selectinfo *)ld->ld_selectinfo;
 
        ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, &sd );
+
+#ifdef HAVE_POLL
+       /* for UNIX poll(2) */
+       {
+               int i;
+               for(i=0; i < sip->si_maxfd; i++) {
+                       if( sip->si_fds[i].fd == sd ) {
+                               return sip->si_fds[i].revents & POLL_WRITE;
+                       }
+               }
+
+               return 0;
+       }
+#else
+       /* for UNIX select(2) */
        return( FD_ISSET( sd, &sip->si_use_writefds ));
+#endif
 }
 
 
@@ -707,8 +1008,27 @@ ldap_is_read_ready( LDAP *ld, Sockbuf *sb )
 
        sip = (struct selectinfo *)ld->ld_selectinfo;
 
+       if (ber_sockbuf_ctrl( sb, LBER_SB_OPT_DATA_READY, NULL ))
+               return 1;
+
        ber_sockbuf_ctrl( sb, LBER_SB_OPT_GET_FD, &sd );
+
+#ifdef HAVE_POLL
+       /* for UNIX poll(2) */
+       {
+               int i;
+               for(i=0; i < sip->si_maxfd; i++) {
+                       if( sip->si_fds[i].fd == sd ) {
+                               return sip->si_fds[i].revents & POLL_READ;
+                       }
+               }
+
+               return 0;
+       }
+#else
+       /* for UNIX select(2) */
        return( FD_ISSET( sd, &sip->si_use_readfds ));
+#endif
 }
 
 
@@ -717,11 +1037,18 @@ ldap_new_select_info( void )
 {
        struct selectinfo       *sip;
 
-       if (( sip = (struct selectinfo *)LDAP_CALLOC( 1,
-           sizeof( struct selectinfo ))) != NULL ) {
-               FD_ZERO( &sip->si_readfds );
-               FD_ZERO( &sip->si_writefds );
-       }
+       sip = (struct selectinfo *)LDAP_CALLOC( 1, sizeof( struct selectinfo ));
+
+       if ( sip == NULL ) return NULL;
+
+#ifdef HAVE_POLL
+       /* for UNIX poll(2) */
+       /* sip->si_maxfd=0 */
+#else
+       /* for UNIX select(2) */
+       FD_ZERO( &sip->si_readfds );
+       FD_ZERO( &sip->si_writefds );
+#endif
 
        return( (void *)sip );
 }
@@ -740,19 +1067,19 @@ int ldap_int_tblsize = 0;
 void
 ldap_int_ip_init( void )
 {
-       int tblsize;
-
 #if defined( HAVE_SYSCONF )
-       tblsize = sysconf( _SC_OPEN_MAX );
+       long tblsize = sysconf( _SC_OPEN_MAX );
+       if( tblsize > INT_MAX ) tblsize = INT_MAX;
+
 #elif defined( HAVE_GETDTABLESIZE )
-       tblsize = getdtablesize();
+       int tblsize = getdtablesize();
 #else
-       tblsize = FD_SETSIZE;
+       int tblsize = FD_SETSIZE;
 #endif /* !USE_SYSCONF */
 
 #ifdef FD_SETSIZE
        if( tblsize > FD_SETSIZE ) tblsize = FD_SETSIZE;
-#endif /* FD_SETSIZE*/
+#endif /* FD_SETSIZE */
 
        ldap_int_tblsize = tblsize;
 }
@@ -762,28 +1089,31 @@ ldap_int_ip_init( void )
 int
 ldap_int_select( LDAP *ld, struct timeval *timeout )
 {
+       int rc;
        struct selectinfo       *sip;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( CONNECTION, ENTRY, "ldap_int_select\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_int_select\n", 0, 0, 0 );
-#endif
 
 #ifndef HAVE_POLL
        if ( ldap_int_tblsize == 0 ) ldap_int_ip_init();
 #endif
 
        sip = (struct selectinfo *)ld->ld_selectinfo;
+       assert( sip != NULL );
+
+#ifdef HAVE_POLL
+       {
+               int to = timeout ? TV2MILLISEC( timeout ) : INFTIM;
+               rc = poll( sip->si_fds, sip->si_maxfd, to );
+       }
+#else
        sip->si_use_readfds = sip->si_readfds;
        sip->si_use_writefds = sip->si_writefds;
        
-#ifdef HAVE_POLL
-       assert(0);
-       return -1;
-#else
-       return( select( ldap_int_tblsize,
+       rc = select( ldap_int_tblsize,
                &sip->si_use_readfds, &sip->si_use_writefds,
-               NULL, timeout ));
+               NULL, timeout );
 #endif
+
+       return rc;
 }