]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/request.c
cleanup
[openldap] / libraries / libldap / request.c
index 6e4985751452703c727fcd9fd8d472c4dbe22b8f..0297a3788f081728e566650a58030cffe4abd2c9 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2003 The OpenLDAP Foundation.
+ * Copyright 1998-2005 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -55,6 +55,7 @@
 
 static LDAPConn *find_connection LDAP_P(( LDAP *ld, LDAPURLDesc *srv, int any ));
 static void use_connection LDAP_P(( LDAP *ld, LDAPConn *lc ));
+static void ldap_free_request_int LDAP_P(( LDAP *ld, LDAPRequest *lr ));
 
 static BerElement *
 re_encode_request( LDAP *ld,
@@ -95,11 +96,7 @@ ldap_send_initial_request(
        LDAPURLDesc     *servers;
        int rc;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_initial_request\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_initial_request\n", 0, 0, 0 );
-#endif
 
        if ( ber_sockbuf_ctrl( ld->ld_sb, LBER_SB_OPT_GET_FD, NULL ) == -1 ) {
                /* not connected yet */
@@ -110,15 +107,9 @@ ldap_send_initial_request(
                        return( -1 );
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_send_initial_request: ldap_open_defconn: successful\n" , 
-                       0, 0, 0);
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "ldap_open_defconn: successful\n",
                        0, 0, 0 );
-#endif
        }
 
        {
@@ -145,7 +136,7 @@ ldap_send_initial_request(
        ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
 #endif
        rc = ldap_send_server_request( ld, ber, msgid, NULL,
-                                                                       servers, NULL, NULL );
+               servers, NULL, NULL );
 #ifdef LDAP_R_COMPILE
        ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
 #endif
@@ -158,8 +149,7 @@ ldap_send_initial_request(
 int
 ldap_int_flush_request(
        LDAP *ld,
-       LDAPRequest *lr
-)
+       LDAPRequest *lr )
 {
        LDAPConn *lc = lr->lr_conn;
 
@@ -202,11 +192,7 @@ ldap_send_server_request(
        LDAPRequest     *lr;
        int incparent, rc;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_server_request\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_server_request\n", 0, 0, 0 );
-#endif
 
        incparent = 0;
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
@@ -215,8 +201,8 @@ ldap_send_server_request(
                if ( srvlist == NULL ) {
                        lc = ld->ld_defconn;
                } else {
-                       if (( lc = find_connection( ld, srvlist, 1 )) ==
-                           NULL ) {
+                       lc = find_connection( ld, srvlist, 1 );
+                       if ( lc == NULL ) {
                                if ( (bind != NULL) && (parentreq != NULL) ) {
                                        /* Remember the bind in the parent */
                                        incparent = 1;
@@ -249,13 +235,14 @@ ldap_send_server_request(
        rc = 0;
        if ( ld->ld_requests &&
                ld->ld_requests->lr_status == LDAP_REQST_WRITING &&
-               ldap_int_flush_request( ld, ld->ld_requests ) < 0 ) {
+               ldap_int_flush_request( ld, ld->ld_requests ) < 0 )
+       {
                rc = -1;
        }
        if ( rc ) return rc;
 
-       if (( lr = (LDAPRequest *)LDAP_CALLOC( 1, sizeof( LDAPRequest ))) ==
-           NULL ) {
+       lr = (LDAPRequest *)LDAP_CALLOC( 1, sizeof( LDAPRequest ));
+       if ( lr == NULL ) {
                ld->ld_errno = LDAP_NO_MEMORY;
                ldap_free_connection( ld, lc, 0, 0 );
                ber_free( ber, 1 );
@@ -276,7 +263,7 @@ ldap_send_server_request(
                        ++parentreq->lr_outrefcnt;
                }
                lr->lr_origid = parentreq->lr_origid;
-               lr->lr_parentcnt = parentreq->lr_parentcnt + 1;
+               lr->lr_parentcnt = ++parentreq->lr_parentcnt;
                lr->lr_parent = parentreq;
                lr->lr_refnext = parentreq->lr_child;
                parentreq->lr_child = lr;
@@ -284,11 +271,11 @@ ldap_send_server_request(
                lr->lr_origid = lr->lr_msgid;
        }
 
+       lr->lr_prev = NULL;
        if (( lr->lr_next = ld->ld_requests ) != NULL ) {
                lr->lr_next->lr_prev = lr;
        }
        ld->ld_requests = lr;
-       lr->lr_prev = NULL;
 
        ld->ld_errno = LDAP_SUCCESS;
        if ( ldap_int_flush_request( ld, lr ) == -1 ) {
@@ -304,31 +291,36 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
 {
        LDAPConn        *lc;
        LDAPURLDesc     *srv;
-       Sockbuf         *sb = NULL;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_new_connection\n", 0, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_TRACE, "ldap_new_connection\n", 0, 0, 0 );
-#endif
+       Debug( LDAP_DEBUG_TRACE, "ldap_new_connection %d %d %d\n",
+               use_ldsb, connect, (bind != NULL) );
        /*
         * make a new LDAP server connection
         * XXX open connection synchronously for now
         */
-       if (( lc = (LDAPConn *)LDAP_CALLOC( 1, sizeof( LDAPConn ))) == NULL ||
-           ( !use_ldsb && ( (sb = ber_sockbuf_alloc()) == NULL ))) {
-               if ( lc != NULL ) {
-                       LDAP_FREE( (char *)lc );
-               }
+       lc = (LDAPConn *)LDAP_CALLOC( 1, sizeof( LDAPConn ) );
+       if ( lc == NULL ) {
                ld->ld_errno = LDAP_NO_MEMORY;
                return( NULL );
        }
+       
+       if ( use_ldsb ) {
+               assert( ld->ld_sb != NULL );
+               lc->lconn_sb = ld->ld_sb;
 
-       lc->lconn_sb = ( use_ldsb ) ? ld->ld_sb : sb;
+       } else {
+               lc->lconn_sb = ber_sockbuf_alloc();
+               if ( lc->lconn_sb == NULL ) {
+                       LDAP_FREE( (char *)lc );
+                       ld->ld_errno = LDAP_NO_MEMORY;
+                       return( NULL );
+               }
+       }
 
        if ( connect ) {
                for ( srv = srvlist; srv != NULL; srv = srv->lud_next ) {
-                       if ( ldap_int_open_connection( ld, lc, srv, 0 ) != -1 ) {
+                       if ( ldap_int_open_connection( ld, lc, srv, 0 ) != -1 )
+                       {
                                break;
                        }
                }
@@ -337,12 +329,12 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                        if ( !use_ldsb ) {
                                ber_sockbuf_free( lc->lconn_sb );
                        }
-                   LDAP_FREE( (char *)lc );
-                   ld->ld_errno = LDAP_SERVER_DOWN;
-                   return( NULL );
+                       LDAP_FREE( (char *)lc );
+                       ld->ld_errno = LDAP_SERVER_DOWN;
+                       return( NULL );
                }
 
-               lc->lconn_server = ldap_url_dup(srv);
+               lc->lconn_server = ldap_url_dup( srv );
        }
 
        lc->lconn_status = LDAP_CONNST_CONNECTED;
@@ -357,14 +349,17 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                int             err = 0;
                LDAPConn        *savedefconn;
 
-               /* Set flag to prevent additional referrals from being processed on this
+               /* Set flag to prevent additional referrals
+                * from being processed on this
                 * connection until the bind has completed
                 */
                lc->lconn_rebind_inprogress = 1;
                /* V3 rebind function */
                if ( ld->ld_rebind_proc != NULL) {
                        LDAPURLDesc     *srvfunc;
-                       if( ( srvfunc = ldap_url_dup( srvlist)) == NULL) {
+
+                       srvfunc = ldap_url_dup( srvlist );
+                       if ( srvfunc == NULL ) {
                                ld->ld_errno = LDAP_NO_MEMORY;
                                err = -1;
                        } else {
@@ -372,47 +367,35 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                                ++lc->lconn_refcnt;     /* avoid premature free */
                                ld->ld_defconn = lc;
 
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, DETAIL1, 
-                                       "ldap_new_connection: Call application rebind_proc\n", 
-                                       0, 0, 0 );
-#else
                                Debug( LDAP_DEBUG_TRACE, "Call application rebind_proc\n", 0, 0, 0);
-#endif
 #ifdef LDAP_R_COMPILE
-               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
-               ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
+                               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+                               ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
 #endif
                                err = (*ld->ld_rebind_proc)( ld,
                                        bind->ri_url, bind->ri_request, bind->ri_msgid,
                                        ld->ld_rebind_params );
 #ifdef LDAP_R_COMPILE
-               ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
-               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+                               ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
+                               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
 #endif
 
                                ld->ld_defconn = savedefconn;
                                --lc->lconn_refcnt;
 
-                               if( err != 0) {
-                               err = -1;
+                               if ( err != 0 ) {
+                                       err = -1;
                                        ldap_free_connection( ld, lc, 1, 0 );
                                        lc = NULL;
+                               }
+                               ldap_free_urldesc( srvfunc );
                        }
-                               ldap_free_urldesc( srvfunc);
-               }
                } else {
                        savedefconn = ld->ld_defconn;
                        ++lc->lconn_refcnt;     /* avoid premature free */
                        ld->ld_defconn = lc;
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "ldap_new_connection: anonymous rebind via ldap_bind_s\n", 
-                               0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE, "anonymous rebind via ldap_bind_s\n", 0, 0, 0);
-#endif
 #ifdef LDAP_R_COMPILE
                        ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
                        ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
@@ -427,12 +410,12 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                        ld->ld_defconn = savedefconn;
                        --lc->lconn_refcnt;
 
-               if ( err != 0 ) {
-                       ldap_free_connection( ld, lc, 1, 0 );
-                       lc = NULL;
+                       if ( err != 0 ) {
+                               ldap_free_connection( ld, lc, 1, 0 );
+                               lc = NULL;
+                       }
                }
-       }
-               if( lc != NULL)
+               if ( lc != NULL )
                        lc->lconn_rebind_inprogress = 0;
        }
 
@@ -448,20 +431,28 @@ find_connection( LDAP *ld, LDAPURLDesc *srv, int any )
  */
 {
        LDAPConn        *lc;
-       LDAPURLDesc     *ls;
+       LDAPURLDesc     *lcu, *lsu;
+       int lcu_port, lsu_port;
 
        for ( lc = ld->ld_conns; lc != NULL; lc = lc->lconn_next ) {
-               for ( ls = srv; ls != NULL; ls = ls->lud_next ) {
-                       if ( lc->lconn_server->lud_host != NULL &&
-                               *lc->lconn_server->lud_host != '\0' &&
-                           ls->lud_host != NULL && *ls->lud_host != '\0' &&
-                               strcasecmp( ls->lud_host, lc->lconn_server->lud_host ) == 0
-                           && ls->lud_port == lc->lconn_server->lud_port ) {
+               lcu = lc->lconn_server;
+               lcu_port = ldap_pvt_url_scheme_port( lcu->lud_scheme,
+                       lcu->lud_port );
+
+               for ( lsu = srv; lsu != NULL; lsu = lsu->lud_next ) {
+                       lsu_port = ldap_pvt_url_scheme_port( lsu->lud_scheme,
+                               lsu->lud_port );
+
+                       if ( strcmp( lcu->lud_scheme, lsu->lud_scheme ) == 0
+                               && lcu->lud_host != NULL && *lcu->lud_host != '\0'
+                           && lsu->lud_host != NULL && *lsu->lud_host != '\0'
+                               && strcasecmp( lsu->lud_host, lcu->lud_host ) == 0
+                           && lsu_port == lcu_port )
+                       {
                                return lc;
                        }
-                       if ( !any ) {
-                               break;
-                       }
+
+                       if ( !any ) break;
                }
        }
 
@@ -483,11 +474,9 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
 {
        LDAPConn        *tmplc, *prevlc;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_free_connection\n", 0, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_TRACE, "ldap_free_connection\n", 0, 0, 0 );
-#endif
+       Debug( LDAP_DEBUG_TRACE,
+               "ldap_free_connection %d %d\n",
+               force, unbind, 0 );
 
        if ( force || --lc->lconn_refcnt <= 0 ) {
                if ( lc->lconn_status == LDAP_CONNST_CONNECTED ) {
@@ -497,15 +486,17 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
                        }
                }
 
-               if( lc->lconn_ber != NULL ) {
+               if ( lc->lconn_ber != NULL ) {
                        ber_free( lc->lconn_ber, 1 );
                }
 
                ldap_int_sasl_close( ld, lc );
 
                prevlc = NULL;
-               for ( tmplc = ld->ld_conns; tmplc != NULL;
-                   tmplc = tmplc->lconn_next ) {
+               for ( tmplc = ld->ld_conns;
+                       tmplc != NULL;
+                       tmplc = tmplc->lconn_next )
+               {
                        if ( tmplc == lc ) {
                                if ( prevlc == NULL ) {
                                    ld->ld_conns = tmplc->lconn_next;
@@ -522,33 +513,39 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
                        LDAP_FREE( lc->lconn_krbinstance );
                }
 #endif
+
+               /* FIXME: is this at all possible? */
+               if ( force ) {
+                       LDAPRequest     *lr;
+
+                       for ( lr = ld->ld_requests; lr; ) {
+                               LDAPRequest     *lr_next = lr->lr_next;
+
+                               if ( lr->lr_conn == lc ) {
+                                       ldap_free_request_int( ld, lr );
+                               }
+
+                               lr = lr_next;
+                       }
+               }
                if ( lc->lconn_sb != ld->ld_sb ) {
                        ber_sockbuf_free( lc->lconn_sb );
                }
-               if( lc->lconn_rebind_queue != NULL) {
+               if ( lc->lconn_rebind_queue != NULL) {
                        int i;
-                       for( i = 0; lc->lconn_rebind_queue[i] != NULL; i++) {
-                               LDAP_VFREE(lc->lconn_rebind_queue[i]);
+                       for( i = 0; lc->lconn_rebind_queue[i] != NULL; i++ ) {
+                               LDAP_VFREE( lc->lconn_rebind_queue[i] );
                        }
-                       LDAP_FREE( lc->lconn_rebind_queue);
+                       LDAP_FREE( lc->lconn_rebind_queue );
                }
                LDAP_FREE( lc );
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, RESULTS, 
-                       "ldap_free_connection: actually freed\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "ldap_free_connection: actually freed\n",
-                   0, 0, 0 );
-#endif
+               Debug( LDAP_DEBUG_TRACE,
+                       "ldap_free_connection: actually freed\n",
+                       0, 0, 0 );
        } else {
                lc->lconn_lastused = time( NULL );
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, RESULTS, "ldap_free_connection: refcnt %d\n", 
-                       lc->lconn_refcnt, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE, "ldap_free_connection: refcnt %d\n",
-                   lc->lconn_refcnt, 0, 0 );
-#endif
+                               lc->lconn_refcnt, 0, 0 );
        }
 }
 
@@ -645,11 +642,14 @@ ldap_dump_requests_and_responses( LDAP *ld )
 }
 #endif /* LDAP_DEBUG */
 
-void
+static void
 ldap_free_request_int( LDAP *ld, LDAPRequest *lr )
 {
        if ( lr->lr_prev == NULL ) {
+               /* free'ing the first request? */
+               assert( ld->ld_requests == lr );
                ld->ld_requests = lr->lr_next;
+
        } else {
                lr->lr_prev->lr_next = lr->lr_next;
        }
@@ -678,13 +678,8 @@ ldap_free_request( LDAP *ld, LDAPRequest *lr )
 {
        LDAPRequest     **ttmplr;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ARGS, "ldap_free_request (origid %d, msgid %d)\n",
-               lr->lr_origid, lr->lr_msgid, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_free_request (origid %d, msgid %d)\n",
                lr->lr_origid, lr->lr_msgid, 0 );
-#endif
 
        /* free all referrals (child requests) */
        while ( lr->lr_child )
@@ -699,6 +694,36 @@ ldap_free_request( LDAP *ld, LDAPRequest *lr )
        ldap_free_request_int( ld, lr );
 }
 
+/*
+ * call first time with *cntp = -1
+ * when returns *cntp == -1, no referrals are left
+ *
+ * NOTE: may replace *refsp, or shuffle the contents
+ * of the original array.
+ */
+static int ldap_int_nextref(
+       LDAP                    *ld,
+       char                    ***refsp,
+       int                     *cntp,
+       void                    *params )
+{
+       assert( refsp != NULL );
+       assert( *refsp != NULL );
+       assert( cntp != NULL );
+
+       if ( *cntp < -1 ) {
+               *cntp = -1;
+               return -1;
+       }
+
+       (*cntp)++;
+
+       if ( (*refsp)[ *cntp ] == NULL ) {
+               *cntp = -1;
+       }
+
+       return 0;
+}
 
 /*
  * Chase v3 referrals
@@ -718,7 +743,7 @@ int
 ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char **errstrp, int *hadrefp )
 {
        char            *unfollowed;
-       int                      unfollowedcnt = 0;
+       int              unfollowedcnt = 0;
        LDAPRequest     *origreq;
        LDAPURLDesc     *srv = NULL;
        BerElement      *ber;
@@ -730,11 +755,7 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
        *hadrefp = 0;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_chase_v3referrals\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_chase_v3referrals\n", 0, 0, 0 );
-#endif
 
        unfollowed = NULL;
        rc = count = 0;
@@ -747,14 +768,8 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
 
        /* Check for hop limit exceeded */
        if ( lr->lr_parentcnt >= ld->ld_refhoplimit ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_chase_v3referrals: more than %d referral hops (dropping)\n",
-                       ld->ld_refhoplimit, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                    "more than %d referral hops (dropping)\n", ld->ld_refhoplimit, 0, 0 );
-#endif
                ld->ld_errno = LDAP_REFERRAL_LIMIT_EXCEEDED;
            rc = -1;
                goto done;
@@ -770,8 +785,18 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
 
        refarray = refs;
        refs = NULL;
+
+       if ( ld->ld_nextref_proc == NULL ) {
+               ld->ld_nextref_proc = ldap_int_nextref;
+       }
+
        /* parse out & follow referrals */
-       for( i=0; refarray[i] != NULL; i++) {
+       i = -1;
+       for ( ld->ld_nextref_proc( ld, &refarray, &i, ld->ld_nextref_params );
+                       i != -1;
+                       ld->ld_nextref_proc( ld, &refarray, &i, ld->ld_nextref_params ) )
+       {
+
                /* Parse the referral URL */
                if (( rc = ldap_url_parse_ext( refarray[i], &srv)) != LDAP_SUCCESS) {
                        ld->ld_errno = rc;
@@ -802,15 +827,9 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                                 * if two search references come in one behind the other
                                 * for the same server with different contexts.
                                 */
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, DETAIL1, 
-                                       "ldap_chase_v3referrals: queue referral \"%s\"\n",
-                                       refarray[i], 0, 0 );
-#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "ldap_chase_v3referrals: queue referral \"%s\"\n",
                                        refarray[i], 0, 0);
-#endif
                                if( lc->lconn_rebind_queue == NULL ) {
                                        /* Create a referral list */
                                        lc->lconn_rebind_queue =
@@ -873,15 +892,9 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                        goto done;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_chase_v3referrals: msgid %d, url \"%s\"\n",
-                       lr->lr_msgid, refarray[i], 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "ldap_chase_v3referral: msgid %d, url \"%s\"\n",
                        lr->lr_msgid, refarray[i], 0);
-#endif
 
                /* Send the new request to the server - may require a bind */
                rinfo.ri_msgid = origreq->lr_origid;
@@ -896,14 +909,8 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
 #endif
                if ( rc < 0 ) {
                        /* Failure, try next referral in the list */
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                       "ldap_chase_v3referrals: Unable to chase referral \"%s\" (%s)\n",
-                       refarray[i], ldap_err2string( ld->ld_errno ), 0 );
-#else
                        Debug( LDAP_DEBUG_ANY, "Unable to chase referral \"%s\" (%s)\n", 
                                refarray[i], ldap_err2string( ld->ld_errno ), 0);
-#endif
                        unfollowedcnt += ldap_append_referral( ld, &unfollowed, refarray[i]);
                        ldap_free_urllist(srv);
                        srv = NULL;
@@ -948,11 +955,11 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                }
        } /* end for loop */
 done:
-       LDAP_VFREE(refarray);
-       ldap_free_urllist(srv);
+       LDAP_VFREE( refarray );
+       ldap_free_urllist( srv );
        LDAP_FREE( *errstrp );
        
-       if( rc == 0) {
+       if( rc == 0 ) {
                *errstrp = NULL;
                LDAP_FREE( unfollowed );
                return count;
@@ -981,11 +988,7 @@ ldap_chase_referrals( LDAP *ld,
        BerElement      *ber;
        LDAPreqinfo  rinfo;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_chase_referrals\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_chase_referrals\n", 0, 0, 0 );
-#endif
 
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
        *hadrefp = 0;
@@ -1008,15 +1011,9 @@ ldap_chase_referrals( LDAP *ld,
        }
 
        if ( lr->lr_parentcnt >= ld->ld_refhoplimit ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ENTRY, 
-                       "ldap_chase_referrals: more than %d referral hops (dropping)\n",
-                       ld->ld_refhoplimit, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                    "more than %d referral hops (dropping)\n",
                    ld->ld_refhoplimit, 0, 0 );
-#endif
                    /* XXX report as error in ld->ld_errno? */
                    return( 0 );
        }
@@ -1041,14 +1038,8 @@ ldap_chase_referrals( LDAP *ld,
                rc = ldap_url_parse_ext( ref, &srv );
 
                if ( rc != LDAP_URL_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "ldap_chase_referrals: ignoring unknown referral <%s>\n",
-                               ref, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                            "ignoring unknown referral <%s>\n", ref, 0, 0 );
-#endif
                        rc = ldap_append_referral( ld, &unfollowed, ref );
                        *hadrefp = 1;
                        continue;
@@ -1059,13 +1050,8 @@ ldap_chase_referrals( LDAP *ld,
                        srv->lud_dn = NULL;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_chase_referrals: chasing LDAP referral <%s>\n", ref, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                    "chasing LDAP referral: <%s>\n", ref, 0, 0 );
-#endif
 
                *hadrefp = 1;
 
@@ -1083,12 +1069,12 @@ ldap_chase_referrals( LDAP *ld,
                rinfo.ri_msgid = origreq->lr_origid;
 
 #ifdef LDAP_R_COMPILE
-       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
 #endif
                rc = ldap_send_server_request( ld, ber, id,
-                   lr, srv, NULL, &rinfo );
+                       lr, srv, NULL, &rinfo );
 #ifdef LDAP_R_COMPILE
-       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
 #endif
 
                LDAP_FREE( rinfo.ri_url );
@@ -1096,15 +1082,9 @@ ldap_chase_referrals( LDAP *ld,
                if( rc >= 0 ) {
                        ++count;
                } else {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                               "ldap_chase_referrals: Unable to chase referral <%s>\n", 
-                               ldap_err2string( ld->ld_errno), 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY,
                            "Unable to chase referral (%s)\n", 
                            ldap_err2string( ld->ld_errno ), 0, 0 );
-#endif
                        rc = ldap_append_referral( ld, &unfollowed, ref );
                }
 
@@ -1171,17 +1151,10 @@ re_encode_request( LDAP *ld,
        char            *orig_dn;
        char            *dn;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ARGS, 
-               "re_encode_request: new msgid %ld, new dn <%s>\n",
-               (long) msgid, 
-               ( srv == NULL || srv->lud_dn == NULL ) ? "NONE" : srv->lud_dn, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE,
            "re_encode_request: new msgid %ld, new dn <%s>\n",
            (long) msgid,
                ( srv == NULL || srv->lud_dn == NULL) ? "NONE" : srv->lud_dn, 0 );
-#endif
 
        tmpber = *origber;
 
@@ -1229,7 +1202,7 @@ re_encode_request( LDAP *ld,
                                scope = LDAP_SCOPE_BASE;
                                break;
                        case LDAP_SCOPE_SUBTREE:
-#ifdef LDAP_FEATURE_SUBORDINATE_SCOPE
+#ifdef LDAP_SCOPE_SUBORDINATE
                        case LDAP_SCOPE_SUBORDINATE:
 #endif
                                scope = LDAP_SCOPE_SUBTREE;
@@ -1286,13 +1259,8 @@ re_encode_request( LDAP *ld,
 
 #ifdef LDAP_DEBUG
        if ( ldap_debug & LDAP_DEBUG_PACKETS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "re_encode_request: new request is:\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "re_encode_request new request is:\n",
                    0, 0, 0 );
-#endif
                ber_log_dump( LDAP_DEBUG_BER, ldap_debug, ber, 0 );
        }
 #endif /* LDAP_DEBUG */