]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/request.c
cleanup
[openldap] / libraries / libldap / request.c
index ed80127306a5653950f99cd1420d7ca0081fa8bc..0297a3788f081728e566650a58030cffe4abd2c9 100644 (file)
@@ -1,14 +1,21 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2005 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
-/*  Portions
- *  Copyright (c) 1995 Regents of the University of Michigan.
- *  All rights reserved.
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
  */
-/*---
- * This notice applies to changes, created by or for Novell, Inc.,
+/* This notice applies to changes, created by or for Novell, Inc.,
  * to preexisting works for which notices appear elsewhere in this file.
  *
  * Copyright (C) 1999, 2000 Novell, Inc. All Rights Reserved.
  * Modification to OpenLDAP source by Novell, Inc.
  * April 2000 sfs  Added code to chase V3 referrals
  *  request.c - sending of ldap requests; handling of referrals
+ *---
+ * Note: A verbatim copy of version 2.0.1 of the OpenLDAP Public License 
+ * can be found in the file "build/LICENSE-2.0.1" in this distribution
+ * of OpenLDAP Software.
  */
 
 #include "portable.h"
@@ -44,6 +55,7 @@
 
 static LDAPConn *find_connection LDAP_P(( LDAP *ld, LDAPURLDesc *srv, int any ));
 static void use_connection LDAP_P(( LDAP *ld, LDAPConn *lc ));
+static void ldap_free_request_int LDAP_P(( LDAP *ld, LDAPRequest *lr ));
 
 static BerElement *
 re_encode_request( LDAP *ld,
@@ -78,16 +90,13 @@ ldap_send_initial_request(
        LDAP *ld,
        ber_tag_t msgtype,
        const char *dn,
-       BerElement *ber )
+       BerElement *ber,
+       ber_int_t msgid)
 {
        LDAPURLDesc     *servers;
        int rc;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_initial_request\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_initial_request\n", 0, 0, 0 );
-#endif
 
        if ( ber_sockbuf_ctrl( ld->ld_sb, LBER_SB_OPT_GET_FD, NULL ) == -1 ) {
                /* not connected yet */
@@ -98,15 +107,9 @@ ldap_send_initial_request(
                        return( -1 );
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_send_initial_request: ldap_open_defconn: successful\n" , 
-                       0, 0, 0);
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "ldap_open_defconn: successful\n",
                        0, 0, 0 );
-#endif
        }
 
        {
@@ -129,8 +132,14 @@ ldap_send_initial_request(
                        return LDAP_PARAM_ERROR;
        }
 #endif
-       rc = ldap_send_server_request( ld, ber, ld->ld_msgid, NULL,
-                                                                       servers, NULL, NULL );
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+       rc = ldap_send_server_request( ld, ber, msgid, NULL,
+               servers, NULL, NULL );
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
        if (servers)
                ldap_free_urllist(servers);
        return(rc);
@@ -140,8 +149,7 @@ ldap_send_initial_request(
 int
 ldap_int_flush_request(
        LDAP *ld,
-       LDAPRequest *lr
-)
+       LDAPRequest *lr )
 {
        LDAPConn *lc = lr->lr_conn;
 
@@ -182,13 +190,9 @@ ldap_send_server_request(
        LDAPreqinfo *bind )
 {
        LDAPRequest     *lr;
-       int incparent;
+       int incparent, rc;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_server_request\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_server_request\n", 0, 0, 0 );
-#endif
 
        incparent = 0;
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
@@ -197,8 +201,8 @@ ldap_send_server_request(
                if ( srvlist == NULL ) {
                        lc = ld->ld_defconn;
                } else {
-                       if (( lc = find_connection( ld, srvlist, 1 )) ==
-                           NULL ) {
+                       lc = find_connection( ld, srvlist, 1 );
+                       if ( lc == NULL ) {
                                if ( (bind != NULL) && (parentreq != NULL) ) {
                                        /* Remember the bind in the parent */
                                        incparent = 1;
@@ -228,14 +232,17 @@ ldap_send_server_request(
         * LDAP_BUSY and let the caller retry later. We only allow a single
         * request to be in WRITING state.
         */
+       rc = 0;
        if ( ld->ld_requests &&
                ld->ld_requests->lr_status == LDAP_REQST_WRITING &&
-               ldap_int_flush_request( ld, ld->ld_requests ) < 0 ) {
-               return -1;
+               ldap_int_flush_request( ld, ld->ld_requests ) < 0 )
+       {
+               rc = -1;
        }
+       if ( rc ) return rc;
 
-       if (( lr = (LDAPRequest *)LDAP_CALLOC( 1, sizeof( LDAPRequest ))) ==
-           NULL ) {
+       lr = (LDAPRequest *)LDAP_CALLOC( 1, sizeof( LDAPRequest ));
+       if ( lr == NULL ) {
                ld->ld_errno = LDAP_NO_MEMORY;
                ldap_free_connection( ld, lc, 0, 0 );
                ber_free( ber, 1 );
@@ -256,7 +263,7 @@ ldap_send_server_request(
                        ++parentreq->lr_outrefcnt;
                }
                lr->lr_origid = parentreq->lr_origid;
-               lr->lr_parentcnt = parentreq->lr_parentcnt + 1;
+               lr->lr_parentcnt = ++parentreq->lr_parentcnt;
                lr->lr_parent = parentreq;
                lr->lr_refnext = parentreq->lr_child;
                parentreq->lr_child = lr;
@@ -264,17 +271,17 @@ ldap_send_server_request(
                lr->lr_origid = lr->lr_msgid;
        }
 
+       lr->lr_prev = NULL;
        if (( lr->lr_next = ld->ld_requests ) != NULL ) {
                lr->lr_next->lr_prev = lr;
        }
        ld->ld_requests = lr;
-       lr->lr_prev = NULL;
 
+       ld->ld_errno = LDAP_SUCCESS;
        if ( ldap_int_flush_request( ld, lr ) == -1 ) {
-               return -1;
+               msgid = -1;
        }
 
-       ld->ld_errno = LDAP_SUCCESS;
        return( msgid );
 }
 
@@ -284,31 +291,36 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
 {
        LDAPConn        *lc;
        LDAPURLDesc     *srv;
-       Sockbuf         *sb = NULL;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_new_connection\n", 0, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_TRACE, "ldap_new_connection\n", 0, 0, 0 );
-#endif
+       Debug( LDAP_DEBUG_TRACE, "ldap_new_connection %d %d %d\n",
+               use_ldsb, connect, (bind != NULL) );
        /*
         * make a new LDAP server connection
         * XXX open connection synchronously for now
         */
-       if (( lc = (LDAPConn *)LDAP_CALLOC( 1, sizeof( LDAPConn ))) == NULL ||
-           ( !use_ldsb && ( (sb = ber_sockbuf_alloc()) == NULL ))) {
-               if ( lc != NULL ) {
-                       LDAP_FREE( (char *)lc );
-               }
+       lc = (LDAPConn *)LDAP_CALLOC( 1, sizeof( LDAPConn ) );
+       if ( lc == NULL ) {
                ld->ld_errno = LDAP_NO_MEMORY;
                return( NULL );
        }
+       
+       if ( use_ldsb ) {
+               assert( ld->ld_sb != NULL );
+               lc->lconn_sb = ld->ld_sb;
 
-       lc->lconn_sb = ( use_ldsb ) ? ld->ld_sb : sb;
+       } else {
+               lc->lconn_sb = ber_sockbuf_alloc();
+               if ( lc->lconn_sb == NULL ) {
+                       LDAP_FREE( (char *)lc );
+                       ld->ld_errno = LDAP_NO_MEMORY;
+                       return( NULL );
+               }
+       }
 
        if ( connect ) {
                for ( srv = srvlist; srv != NULL; srv = srv->lud_next ) {
-                       if ( ldap_int_open_connection( ld, lc, srv, 0 ) != -1 ) {
+                       if ( ldap_int_open_connection( ld, lc, srv, 0 ) != -1 )
+                       {
                                break;
                        }
                }
@@ -317,12 +329,12 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                        if ( !use_ldsb ) {
                                ber_sockbuf_free( lc->lconn_sb );
                        }
-                   LDAP_FREE( (char *)lc );
-                   ld->ld_errno = LDAP_SERVER_DOWN;
-                   return( NULL );
+                       LDAP_FREE( (char *)lc );
+                       ld->ld_errno = LDAP_SERVER_DOWN;
+                       return( NULL );
                }
 
-               lc->lconn_server = ldap_url_dup(srv);
+               lc->lconn_server = ldap_url_dup( srv );
        }
 
        lc->lconn_status = LDAP_CONNST_CONNECTED;
@@ -337,14 +349,17 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                int             err = 0;
                LDAPConn        *savedefconn;
 
-               /* Set flag to prevent additional referrals from being processed on this
+               /* Set flag to prevent additional referrals
+                * from being processed on this
                 * connection until the bind has completed
                 */
                lc->lconn_rebind_inprogress = 1;
                /* V3 rebind function */
                if ( ld->ld_rebind_proc != NULL) {
                        LDAPURLDesc     *srvfunc;
-                       if( ( srvfunc = ldap_url_dup( srvlist)) == NULL) {
+
+                       srvfunc = ldap_url_dup( srvlist );
+                       if ( srvfunc == NULL ) {
                                ld->ld_errno = LDAP_NO_MEMORY;
                                err = -1;
                        } else {
@@ -352,51 +367,55 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                                ++lc->lconn_refcnt;     /* avoid premature free */
                                ld->ld_defconn = lc;
 
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, DETAIL1, 
-                                       "ldap_new_connection: Call application rebind_proc\n", 
-                                       0, 0, 0 );
-#else
                                Debug( LDAP_DEBUG_TRACE, "Call application rebind_proc\n", 0, 0, 0);
+#ifdef LDAP_R_COMPILE
+                               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+                               ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
 #endif
                                err = (*ld->ld_rebind_proc)( ld,
                                        bind->ri_url, bind->ri_request, bind->ri_msgid,
                                        ld->ld_rebind_params );
+#ifdef LDAP_R_COMPILE
+                               ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
+                               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
 
                                ld->ld_defconn = savedefconn;
                                --lc->lconn_refcnt;
 
-                               if( err != 0) {
-                               err = -1;
+                               if ( err != 0 ) {
+                                       err = -1;
                                        ldap_free_connection( ld, lc, 1, 0 );
                                        lc = NULL;
+                               }
+                               ldap_free_urldesc( srvfunc );
                        }
-                               ldap_free_urldesc( srvfunc);
-               }
                } else {
                        savedefconn = ld->ld_defconn;
                        ++lc->lconn_refcnt;     /* avoid premature free */
                        ld->ld_defconn = lc;
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "ldap_new_connection: anonymous rebind via ldap_bind_s\n", 
-                               0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE, "anonymous rebind via ldap_bind_s\n", 0, 0, 0);
+#ifdef LDAP_R_COMPILE
+                       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+                       ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
 #endif
                        if ( ldap_bind_s( ld, "", "", LDAP_AUTH_SIMPLE ) != LDAP_SUCCESS ) {
                                err = -1;
                        }
+#ifdef LDAP_R_COMPILE
+                       ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
+                       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
                        ld->ld_defconn = savedefconn;
                        --lc->lconn_refcnt;
 
-               if ( err != 0 ) {
-                       ldap_free_connection( ld, lc, 1, 0 );
-                       lc = NULL;
+                       if ( err != 0 ) {
+                               ldap_free_connection( ld, lc, 1, 0 );
+                               lc = NULL;
+                       }
                }
-       }
-               if( lc != NULL)
+               if ( lc != NULL )
                        lc->lconn_rebind_inprogress = 0;
        }
 
@@ -412,20 +431,28 @@ find_connection( LDAP *ld, LDAPURLDesc *srv, int any )
  */
 {
        LDAPConn        *lc;
-       LDAPURLDesc     *ls;
+       LDAPURLDesc     *lcu, *lsu;
+       int lcu_port, lsu_port;
 
        for ( lc = ld->ld_conns; lc != NULL; lc = lc->lconn_next ) {
-               for ( ls = srv; ls != NULL; ls = ls->lud_next ) {
-                       if ( lc->lconn_server->lud_host != NULL &&
-                               *lc->lconn_server->lud_host != '\0' &&
-                           ls->lud_host != NULL && *ls->lud_host != '\0' &&
-                               strcasecmp( ls->lud_host, lc->lconn_server->lud_host ) == 0
-                           && ls->lud_port == lc->lconn_server->lud_port ) {
+               lcu = lc->lconn_server;
+               lcu_port = ldap_pvt_url_scheme_port( lcu->lud_scheme,
+                       lcu->lud_port );
+
+               for ( lsu = srv; lsu != NULL; lsu = lsu->lud_next ) {
+                       lsu_port = ldap_pvt_url_scheme_port( lsu->lud_scheme,
+                               lsu->lud_port );
+
+                       if ( strcmp( lcu->lud_scheme, lsu->lud_scheme ) == 0
+                               && lcu->lud_host != NULL && *lcu->lud_host != '\0'
+                           && lsu->lud_host != NULL && *lsu->lud_host != '\0'
+                               && strcasecmp( lsu->lud_host, lcu->lud_host ) == 0
+                           && lsu_port == lcu_port )
+                       {
                                return lc;
                        }
-                       if ( !any ) {
-                               break;
-                       }
+
+                       if ( !any ) break;
                }
        }
 
@@ -447,11 +474,9 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
 {
        LDAPConn        *tmplc, *prevlc;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_free_connection\n", 0, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_TRACE, "ldap_free_connection\n", 0, 0, 0 );
-#endif
+       Debug( LDAP_DEBUG_TRACE,
+               "ldap_free_connection %d %d\n",
+               force, unbind, 0 );
 
        if ( force || --lc->lconn_refcnt <= 0 ) {
                if ( lc->lconn_status == LDAP_CONNST_CONNECTED ) {
@@ -461,15 +486,17 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
                        }
                }
 
-               if( lc->lconn_ber != NULL ) {
+               if ( lc->lconn_ber != NULL ) {
                        ber_free( lc->lconn_ber, 1 );
                }
 
                ldap_int_sasl_close( ld, lc );
 
                prevlc = NULL;
-               for ( tmplc = ld->ld_conns; tmplc != NULL;
-                   tmplc = tmplc->lconn_next ) {
+               for ( tmplc = ld->ld_conns;
+                       tmplc != NULL;
+                       tmplc = tmplc->lconn_next )
+               {
                        if ( tmplc == lc ) {
                                if ( prevlc == NULL ) {
                                    ld->ld_conns = tmplc->lconn_next;
@@ -486,33 +513,39 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
                        LDAP_FREE( lc->lconn_krbinstance );
                }
 #endif
+
+               /* FIXME: is this at all possible? */
+               if ( force ) {
+                       LDAPRequest     *lr;
+
+                       for ( lr = ld->ld_requests; lr; ) {
+                               LDAPRequest     *lr_next = lr->lr_next;
+
+                               if ( lr->lr_conn == lc ) {
+                                       ldap_free_request_int( ld, lr );
+                               }
+
+                               lr = lr_next;
+                       }
+               }
                if ( lc->lconn_sb != ld->ld_sb ) {
                        ber_sockbuf_free( lc->lconn_sb );
                }
-               if( lc->lconn_rebind_queue != NULL) {
+               if ( lc->lconn_rebind_queue != NULL) {
                        int i;
-                       for( i = 0; lc->lconn_rebind_queue[i] != NULL; i++) {
-                               LDAP_VFREE(lc->lconn_rebind_queue[i]);
+                       for( i = 0; lc->lconn_rebind_queue[i] != NULL; i++ ) {
+                               LDAP_VFREE( lc->lconn_rebind_queue[i] );
                        }
-                       LDAP_FREE( lc->lconn_rebind_queue);
+                       LDAP_FREE( lc->lconn_rebind_queue );
                }
                LDAP_FREE( lc );
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, RESULTS, 
-                       "ldap_free_connection: actually freed\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "ldap_free_connection: actually freed\n",
-                   0, 0, 0 );
-#endif
+               Debug( LDAP_DEBUG_TRACE,
+                       "ldap_free_connection: actually freed\n",
+                       0, 0, 0 );
        } else {
                lc->lconn_lastused = time( NULL );
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, RESULTS, "ldap_free_connection: refcnt %d\n", 
-                       lc->lconn_refcnt, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE, "ldap_free_connection: refcnt %d\n",
-                   lc->lconn_refcnt, 0, 0 );
-#endif
+                               lc->lconn_refcnt, 0, 0 );
        }
 }
 
@@ -568,6 +601,9 @@ ldap_dump_requests_and_responses( LDAP *ld )
        LDAPRequest     *lr;
        LDAPMessage     *lm, *l;
 
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
        fprintf( stderr, "** Outstanding Requests:\n" );
        if (( lr = ld->ld_requests ) == NULL ) {
                fprintf( stderr, "   Empty\n" );
@@ -583,7 +619,9 @@ ldap_dump_requests_and_responses( LDAP *ld )
            fprintf( stderr, "   outstanding referrals %d, parent count %d\n",
                    lr->lr_outrefcnt, lr->lr_parentcnt );
        }
-
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
        fprintf( stderr, "** Response Queue:\n" );
        if (( lm = ld->ld_responses ) == NULL ) {
                fprintf( stderr, "   Empty\n" );
@@ -604,11 +642,14 @@ ldap_dump_requests_and_responses( LDAP *ld )
 }
 #endif /* LDAP_DEBUG */
 
-void
+static void
 ldap_free_request_int( LDAP *ld, LDAPRequest *lr )
 {
        if ( lr->lr_prev == NULL ) {
+               /* free'ing the first request? */
+               assert( ld->ld_requests == lr );
                ld->ld_requests = lr->lr_next;
+
        } else {
                lr->lr_prev->lr_next = lr->lr_next;
        }
@@ -637,27 +678,52 @@ ldap_free_request( LDAP *ld, LDAPRequest *lr )
 {
        LDAPRequest     **ttmplr;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ARGS, "ldap_free_request (origid %d, msgid %d)\n",
-               lr->lr_origid, lr->lr_msgid, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_free_request (origid %d, msgid %d)\n",
                lr->lr_origid, lr->lr_msgid, 0 );
-#endif
+
+       /* free all referrals (child requests) */
+       while ( lr->lr_child )
+               ldap_free_request( ld, lr->lr_child );
 
        if ( lr->lr_parent != NULL ) {
                --lr->lr_parent->lr_outrefcnt;
                for ( ttmplr = &lr->lr_parent->lr_child; *ttmplr && *ttmplr != lr; ttmplr = &(*ttmplr)->lr_refnext ); 
                if ( *ttmplr == lr )  
                        *ttmplr = lr->lr_refnext;
-       } else {
-               /* free all referrals (child requests) */
-               while ( lr->lr_child )
-                       ldap_free_request( ld, lr->lr_child );
        }
        ldap_free_request_int( ld, lr );
 }
 
+/*
+ * call first time with *cntp = -1
+ * when returns *cntp == -1, no referrals are left
+ *
+ * NOTE: may replace *refsp, or shuffle the contents
+ * of the original array.
+ */
+static int ldap_int_nextref(
+       LDAP                    *ld,
+       char                    ***refsp,
+       int                     *cntp,
+       void                    *params )
+{
+       assert( refsp != NULL );
+       assert( *refsp != NULL );
+       assert( cntp != NULL );
+
+       if ( *cntp < -1 ) {
+               *cntp = -1;
+               return -1;
+       }
+
+       (*cntp)++;
+
+       if ( (*refsp)[ *cntp ] == NULL ) {
+               *cntp = -1;
+       }
+
+       return 0;
+}
 
 /*
  * Chase v3 referrals
@@ -677,23 +743,19 @@ int
 ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char **errstrp, int *hadrefp )
 {
        char            *unfollowed;
-       int                      unfollowedcnt = 0;
+       int              unfollowedcnt = 0;
        LDAPRequest     *origreq;
        LDAPURLDesc     *srv = NULL;
        BerElement      *ber;
        char            **refarray = NULL;
        LDAPConn        *lc;
-       int                      rc, count, i, j;
+       int                      rc, count, i, j, id;
        LDAPreqinfo  rinfo;
 
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
        *hadrefp = 0;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_chase_v3referrals\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_chase_v3referrals\n", 0, 0, 0 );
-#endif
 
        unfollowed = NULL;
        rc = count = 0;
@@ -706,14 +768,8 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
 
        /* Check for hop limit exceeded */
        if ( lr->lr_parentcnt >= ld->ld_refhoplimit ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_chase_v3referrals: more than %d referral hops (dropping)\n",
-                       ld->ld_refhoplimit, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                    "more than %d referral hops (dropping)\n", ld->ld_refhoplimit, 0, 0 );
-#endif
                ld->ld_errno = LDAP_REFERRAL_LIMIT_EXCEEDED;
            rc = -1;
                goto done;
@@ -729,8 +785,18 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
 
        refarray = refs;
        refs = NULL;
+
+       if ( ld->ld_nextref_proc == NULL ) {
+               ld->ld_nextref_proc = ldap_int_nextref;
+       }
+
        /* parse out & follow referrals */
-       for( i=0; refarray[i] != NULL; i++) {
+       i = -1;
+       for ( ld->ld_nextref_proc( ld, &refarray, &i, ld->ld_nextref_params );
+                       i != -1;
+                       ld->ld_nextref_proc( ld, &refarray, &i, ld->ld_nextref_params ) )
+       {
+
                /* Parse the referral URL */
                if (( rc = ldap_url_parse_ext( refarray[i], &srv)) != LDAP_SUCCESS) {
                        ld->ld_errno = rc;
@@ -761,15 +827,9 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                                 * if two search references come in one behind the other
                                 * for the same server with different contexts.
                                 */
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, DETAIL1, 
-                                       "ldap_chase_v3referrals: queue referral \"%s\"\n",
-                                       refarray[i], 0, 0 );
-#else
                                Debug( LDAP_DEBUG_TRACE,
                                        "ldap_chase_v3referrals: queue referral \"%s\"\n",
                                        refarray[i], 0, 0);
-#endif
                                if( lc->lconn_rebind_queue == NULL ) {
                                        /* Create a referral list */
                                        lc->lconn_rebind_queue =
@@ -822,7 +882,8 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                        srv->lud_dn = LDAP_STRDUP( "" );
                }
 
-               ber = re_encode_request( ld, origreq->lr_ber, ++ld->ld_msgid,
+               LDAP_NEXT_MSGID( ld, id );
+               ber = re_encode_request( ld, origreq->lr_ber, id,
                        sref, srv, &rinfo.ri_request );
 
                if( ber == NULL ) {
@@ -831,30 +892,25 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                        goto done;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_chase_v3referrals: msgid %d, url \"%s\"\n",
-                       lr->lr_msgid, refarray[i], 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                        "ldap_chase_v3referral: msgid %d, url \"%s\"\n",
                        lr->lr_msgid, refarray[i], 0);
-#endif
 
                /* Send the new request to the server - may require a bind */
                rinfo.ri_msgid = origreq->lr_origid;
                rinfo.ri_url = refarray[i];
-               if ( (rc = ldap_send_server_request( ld, ber, ld->ld_msgid,
-                       origreq, srv, NULL, &rinfo )) < 0 ) {
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+               rc = ldap_send_server_request( ld, ber, id,
+                       origreq, srv, NULL, &rinfo );
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
+               if ( rc < 0 ) {
                        /* Failure, try next referral in the list */
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                       "ldap_chase_v3referrals: Unable to chase referral \"%s\" (%s)\n",
-                       refarray[i], ldap_err2string( ld->ld_errno ), 0 );
-#else
                        Debug( LDAP_DEBUG_ANY, "Unable to chase referral \"%s\" (%s)\n", 
                                refarray[i], ldap_err2string( ld->ld_errno ), 0);
-#endif
                        unfollowedcnt += ldap_append_referral( ld, &unfollowed, refarray[i]);
                        ldap_free_urllist(srv);
                        srv = NULL;
@@ -899,11 +955,11 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                }
        } /* end for loop */
 done:
-       LDAP_VFREE(refarray);
-       ldap_free_urllist(srv);
+       LDAP_VFREE( refarray );
+       ldap_free_urllist( srv );
        LDAP_FREE( *errstrp );
        
-       if( rc == 0) {
+       if( rc == 0 ) {
                *errstrp = NULL;
                LDAP_FREE( unfollowed );
                return count;
@@ -924,7 +980,7 @@ ldap_chase_referrals( LDAP *ld,
        int sref,
        int *hadrefp )
 {
-       int             rc, count;
+       int             rc, count, id;
        unsigned        len;
        char            *p, *ref, *unfollowed;
        LDAPRequest     *origreq;
@@ -932,11 +988,7 @@ ldap_chase_referrals( LDAP *ld,
        BerElement      *ber;
        LDAPreqinfo  rinfo;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "ldap_chase_referrals\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "ldap_chase_referrals\n", 0, 0, 0 );
-#endif
 
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
        *hadrefp = 0;
@@ -959,15 +1011,9 @@ ldap_chase_referrals( LDAP *ld,
        }
 
        if ( lr->lr_parentcnt >= ld->ld_refhoplimit ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ENTRY, 
-                       "ldap_chase_referrals: more than %d referral hops (dropping)\n",
-                       ld->ld_refhoplimit, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY,
                    "more than %d referral hops (dropping)\n",
                    ld->ld_refhoplimit, 0, 0 );
-#endif
                    /* XXX report as error in ld->ld_errno? */
                    return( 0 );
        }
@@ -992,14 +1038,8 @@ ldap_chase_referrals( LDAP *ld,
                rc = ldap_url_parse_ext( ref, &srv );
 
                if ( rc != LDAP_URL_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "ldap_chase_referrals: ignoring unknown referral <%s>\n",
-                               ref, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
                            "ignoring unknown referral <%s>\n", ref, 0, 0 );
-#endif
                        rc = ldap_append_referral( ld, &unfollowed, ref );
                        *hadrefp = 1;
                        continue;
@@ -1010,18 +1050,14 @@ ldap_chase_referrals( LDAP *ld,
                        srv->lud_dn = NULL;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "ldap_chase_referrals: chasing LDAP referral <%s>\n", ref, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
                    "chasing LDAP referral: <%s>\n", ref, 0, 0 );
-#endif
 
                *hadrefp = 1;
 
+               LDAP_NEXT_MSGID( ld, id );
                ber = re_encode_request( ld, origreq->lr_ber,
-                   ++ld->ld_msgid, sref, srv, &rinfo.ri_request );
+                   id, sref, srv, &rinfo.ri_request );
 
                if( ber == NULL ) {
                        return -1 ;
@@ -1032,23 +1068,23 @@ ldap_chase_referrals( LDAP *ld,
 
                rinfo.ri_msgid = origreq->lr_origid;
 
-               rc = ldap_send_server_request( ld, ber, ld->ld_msgid,
-                   lr, srv, NULL, &rinfo );
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+               rc = ldap_send_server_request( ld, ber, id,
+                       lr, srv, NULL, &rinfo );
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
 
                LDAP_FREE( rinfo.ri_url );
 
                if( rc >= 0 ) {
                        ++count;
                } else {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                               "ldap_chase_referrals: Unable to chase referral <%s>\n", 
-                               ldap_err2string( ld->ld_errno), 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY,
                            "Unable to chase referral (%s)\n", 
                            ldap_err2string( ld->ld_errno ), 0, 0 );
-#endif
                        rc = ldap_append_referral( ld, &unfollowed, ref );
                }
 
@@ -1115,17 +1151,10 @@ re_encode_request( LDAP *ld,
        char            *orig_dn;
        char            *dn;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ARGS, 
-               "re_encode_request: new msgid %ld, new dn <%s>\n",
-               (long) msgid, 
-               ( srv == NULL || srv->lud_dn == NULL ) ? "NONE" : srv->lud_dn, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE,
            "re_encode_request: new msgid %ld, new dn <%s>\n",
            (long) msgid,
                ( srv == NULL || srv->lud_dn == NULL) ? "NONE" : srv->lud_dn, 0 );
-#endif
 
        tmpber = *origber;
 
@@ -1159,12 +1188,26 @@ re_encode_request( LDAP *ld,
                        /* use the scope provided in reference */
                        scope = srv->lud_scope;
 
-               } else if ( sref && scope != LDAP_SCOPE_SUBTREE ) {
-                       /* use scope implied by previous operation */
-                       /*   base -> base */
-                       /*   one -> base */
-                       /*   subtree -> subtree */
-                       scope = LDAP_SCOPE_BASE;
+               } else if ( sref ) {
+                       /* use scope implied by previous operation
+                        *   base -> base
+                        *   one -> base
+                        *   subtree -> subtree
+                        *   subordinate -> subtree
+                        */
+                       switch( scope ) {
+                       default:
+                       case LDAP_SCOPE_BASE:
+                       case LDAP_SCOPE_ONELEVEL:
+                               scope = LDAP_SCOPE_BASE;
+                               break;
+                       case LDAP_SCOPE_SUBTREE:
+#ifdef LDAP_SCOPE_SUBORDINATE
+                       case LDAP_SCOPE_SUBORDINATE:
+#endif
+                               scope = LDAP_SCOPE_SUBTREE;
+                               break;
+                       }
                }
 
        } else {
@@ -1216,13 +1259,8 @@ re_encode_request( LDAP *ld,
 
 #ifdef LDAP_DEBUG
        if ( ldap_debug & LDAP_DEBUG_PACKETS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "re_encode_request: new request is:\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_ANY, "re_encode_request new request is:\n",
                    0, 0, 0 );
-#endif
                ber_log_dump( LDAP_DEBUG_BER, ldap_debug, ber, 0 );
        }
 #endif /* LDAP_DEBUG */
@@ -1237,6 +1275,9 @@ ldap_find_request_by_msgid( LDAP *ld, ber_int_t msgid )
 {
        LDAPRequest     *lr;
 
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
        for ( lr = ld->ld_requests; lr != NULL; lr = lr->lr_next ) {
                if( lr->lr_status == LDAP_REQST_COMPLETED ) {
                        continue;       /* Skip completed requests */
@@ -1245,6 +1286,9 @@ ldap_find_request_by_msgid( LDAP *ld, ber_int_t msgid )
                        break;
                }
        }
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
 
        return( lr );
 }