]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/request.c
Don't use default binddn when password is empty
[openldap] / libraries / libldap / request.c
index 880b0015bce11c8479e49c0d36645bf388ed1a22..711572c6929cdaaaafd3a26d2e9d37cc7165634f 100644 (file)
@@ -1,6 +1,6 @@
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 /*  Portions
  * April 2000 sfs  Added code to chase V3 referrals
  *  request.c - sending of ldap requests; handling of referrals
  */
+/* Note: A verbatim copy of version 2.0.1 of the OpenLDAP Public License 
+ * can be found in the file "build/LICENSE-2.0.1" in this distribution
+ * of OpenLDAP Software.
+ */
 
 #include "portable.h"
 
@@ -49,6 +53,7 @@ static BerElement *
 re_encode_request( LDAP *ld,
        BerElement *origber,
        ber_int_t msgid,
+       int sref,
        LDAPURLDesc *srv,
        int *type );
 
@@ -77,12 +82,17 @@ ldap_send_initial_request(
        LDAP *ld,
        ber_tag_t msgtype,
        const char *dn,
-       BerElement *ber )
+       BerElement *ber,
+       ber_int_t msgid)
 {
        LDAPURLDesc     *servers;
        int rc;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_initial_request\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_initial_request\n", 0, 0, 0 );
+#endif
 
        if ( ber_sockbuf_ctrl( ld->ld_sb, LBER_SB_OPT_GET_FD, NULL ) == -1 ) {
                /* not connected yet */
@@ -93,9 +103,15 @@ ldap_send_initial_request(
                        return( -1 );
                }
 
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, DETAIL1, 
+                       "ldap_send_initial_request: ldap_open_defconn: successful\n" , 
+                       0, 0, 0);
+#else
                Debug( LDAP_DEBUG_TRACE,
-                       "ldap_delayed_open successful, ld_host is %s\n",
-                       ( ld->ld_host == NULL ) ? "(null)" : ld->ld_host, 0, 0 );
+                       "ldap_open_defconn: successful\n",
+                       0, 0, 0 );
+#endif
        }
 
        {
@@ -106,14 +122,65 @@ ldap_send_initial_request(
                servers = NULL;
        }       
 
-       rc = ldap_send_server_request( ld, ber, ld->ld_msgid, NULL,
+#ifdef LDAP_CONNECTIONLESS
+       if (LDAP_IS_UDP(ld)) {
+               if (msgtype == LDAP_REQ_BIND) {
+                       if (ld->ld_options.ldo_cldapdn)
+                               ldap_memfree(ld->ld_options.ldo_cldapdn);
+                       ld->ld_options.ldo_cldapdn = ldap_strdup(dn);
+                       return 0;
+               }
+               if (msgtype != LDAP_REQ_ABANDON && msgtype != LDAP_REQ_SEARCH)
+                       return LDAP_PARAM_ERROR;
+       }
+#endif
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+       rc = ldap_send_server_request( ld, ber, msgid, NULL,
                                                                        servers, NULL, NULL );
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
        if (servers)
                ldap_free_urllist(servers);
        return(rc);
 }
 
 
+int
+ldap_int_flush_request(
+       LDAP *ld,
+       LDAPRequest *lr
+)
+{
+       LDAPConn *lc = lr->lr_conn;
+
+       if ( ber_flush( lc->lconn_sb, lr->lr_ber, 0 ) != 0 ) {
+               if ( errno == EAGAIN ) {
+                       /* need to continue write later */
+                       lr->lr_status = LDAP_REQST_WRITING;
+                       ldap_mark_select_write( ld, lc->lconn_sb );
+                       ld->ld_errno = LDAP_BUSY;
+                       return -2;
+               } else {
+                       ld->ld_errno = LDAP_SERVER_DOWN;
+                       ldap_free_request( ld, lr );
+                       ldap_free_connection( ld, lc, 0, 0 );
+                       return( -1 );
+               }
+       } else {
+               if ( lr->lr_parent == NULL ) {
+                       lr->lr_ber->ber_end = lr->lr_ber->ber_ptr;
+                       lr->lr_ber->ber_ptr = lr->lr_ber->ber_buf;
+               }
+               lr->lr_status = LDAP_REQST_INPROGRESS;
+
+               /* sent -- waiting for a response */
+               ldap_mark_select_read( ld, lc->lconn_sb );
+       }
+       return 0;
+}
 
 int
 ldap_send_server_request(
@@ -126,9 +193,13 @@ ldap_send_server_request(
        LDAPreqinfo *bind )
 {
        LDAPRequest     *lr;
-       int incparent;
+       int incparent, rc;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_server_request\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_server_request\n", 0, 0, 0 );
+#endif
 
        incparent = 0;
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
@@ -162,6 +233,20 @@ ldap_send_server_request(
        }
 
        use_connection( ld, lc );
+
+       /* If we still have an incomplete write, try to finish it before
+        * dealing with the new request. If we don't finish here, return
+        * LDAP_BUSY and let the caller retry later. We only allow a single
+        * request to be in WRITING state.
+        */
+       rc = 0;
+       if ( ld->ld_requests &&
+               ld->ld_requests->lr_status == LDAP_REQST_WRITING &&
+               ldap_int_flush_request( ld, ld->ld_requests ) < 0 ) {
+               rc = -1;
+       }
+       if ( rc ) return rc;
+
        if (( lr = (LDAPRequest *)LDAP_CALLOC( 1, sizeof( LDAPRequest ))) ==
            NULL ) {
                ld->ld_errno = LDAP_NO_MEMORY;
@@ -186,8 +271,8 @@ ldap_send_server_request(
                lr->lr_origid = parentreq->lr_origid;
                lr->lr_parentcnt = parentreq->lr_parentcnt + 1;
                lr->lr_parent = parentreq;
-               lr->lr_refnext = parentreq->lr_refnext;
-               parentreq->lr_refnext = lr;
+               lr->lr_refnext = parentreq->lr_child;
+               parentreq->lr_child = lr;
        } else {                        /* original request */
                lr->lr_origid = lr->lr_msgid;
        }
@@ -198,33 +283,11 @@ ldap_send_server_request(
        ld->ld_requests = lr;
        lr->lr_prev = NULL;
 
-       if ( ber_flush( lc->lconn_sb, ber, 0 ) != 0 ) {
-#ifdef notyet
-               if ( errno == EWOULDBLOCK ) {
-                       /* need to continue write later */
-                       lr->lr_status = LDAP_REQST_WRITING;
-                       ldap_mark_select_write( ld, lc->lconn_sb );
-               } else {
-#else /* notyet */
-                       ld->ld_errno = LDAP_SERVER_DOWN;
-                       ldap_free_request( ld, lr );
-                       ldap_free_connection( ld, lc, 0, 0 );
-                       return( -1 );
-#endif /* notyet */
-#ifdef notyet
-               }
-#endif /* notyet */
-       } else {
-               if ( parentreq == NULL ) {
-                       ber->ber_end = ber->ber_ptr;
-                       ber->ber_ptr = ber->ber_buf;
-               }
-
-               /* sent -- waiting for a response */
-               ldap_mark_select_read( ld, lc->lconn_sb );
+       ld->ld_errno = LDAP_SUCCESS;
+       if ( ldap_int_flush_request( ld, lr ) == -1 ) {
+               msgid = -1;
        }
 
-       ld->ld_errno = LDAP_SUCCESS;
        return( msgid );
 }
 
@@ -236,7 +299,11 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
        LDAPURLDesc     *srv;
        Sockbuf         *sb = NULL;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_new_connection\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_new_connection\n", 0, 0, 0 );
+#endif
        /*
         * make a new LDAP server connection
         * XXX open connection synchronously for now
@@ -288,7 +355,7 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                 */
                lc->lconn_rebind_inprogress = 1;
                /* V3 rebind function */
-               if ( ld->ld_rebindproc != NULL) {
+               if ( ld->ld_rebind_proc != NULL) {
                        LDAPURLDesc     *srvfunc;
                        if( ( srvfunc = ldap_url_dup( srvlist)) == NULL) {
                                ld->ld_errno = LDAP_NO_MEMORY;
@@ -298,8 +365,24 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                                ++lc->lconn_refcnt;     /* avoid premature free */
                                ld->ld_defconn = lc;
 
-                               Debug( LDAP_DEBUG_TRACE, "Call application rebindproc\n", 0, 0, 0);
-                               err = (*ld->ld_rebindproc)( ld, bind->ri_url, bind->ri_request, bind->ri_msgid);
+#ifdef NEW_LOGGING
+                               LDAP_LOG ( OPERATION, DETAIL1, 
+                                       "ldap_new_connection: Call application rebind_proc\n", 
+                                       0, 0, 0 );
+#else
+                               Debug( LDAP_DEBUG_TRACE, "Call application rebind_proc\n", 0, 0, 0);
+#endif
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+               ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
+#endif
+                               err = (*ld->ld_rebind_proc)( ld,
+                                       bind->ri_url, bind->ri_request, bind->ri_msgid,
+                                       ld->ld_rebind_params );
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
+               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
 
                                ld->ld_defconn = savedefconn;
                                --lc->lconn_refcnt;
@@ -316,10 +399,24 @@ ldap_new_connection( LDAP *ld, LDAPURLDesc *srvlist, int use_ldsb,
                        ++lc->lconn_refcnt;     /* avoid premature free */
                        ld->ld_defconn = lc;
 
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "ldap_new_connection: anonymous rebind via ldap_bind_s\n", 
+                               0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE, "anonymous rebind via ldap_bind_s\n", 0, 0, 0);
+#endif
+#ifdef LDAP_R_COMPILE
+                       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+                       ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
+#endif
                        if ( ldap_bind_s( ld, "", "", LDAP_AUTH_SIMPLE ) != LDAP_SUCCESS ) {
                                err = -1;
                        }
+#ifdef LDAP_R_COMPILE
+                       ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
+                       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
                        ld->ld_defconn = savedefconn;
                        --lc->lconn_refcnt;
 
@@ -379,7 +476,11 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
 {
        LDAPConn        *tmplc, *prevlc;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_free_connection\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_free_connection\n", 0, 0, 0 );
+#endif
 
        if ( force || --lc->lconn_refcnt <= 0 ) {
                if ( lc->lconn_status == LDAP_CONNST_CONNECTED ) {
@@ -425,12 +526,22 @@ ldap_free_connection( LDAP *ld, LDAPConn *lc, int force, int unbind )
                        LDAP_FREE( lc->lconn_rebind_queue);
                }
                LDAP_FREE( lc );
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, RESULTS, 
+                       "ldap_free_connection: actually freed\n", 0, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE, "ldap_free_connection: actually freed\n",
                    0, 0, 0 );
+#endif
        } else {
                lc->lconn_lastused = time( NULL );
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, RESULTS, "ldap_free_connection: refcnt %d\n", 
+                       lc->lconn_refcnt, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE, "ldap_free_connection: refcnt %d\n",
                    lc->lconn_refcnt, 0, 0 );
+#endif
        }
 }
 
@@ -486,6 +597,9 @@ ldap_dump_requests_and_responses( LDAP *ld )
        LDAPRequest     *lr;
        LDAPMessage     *lm, *l;
 
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
        fprintf( stderr, "** Outstanding Requests:\n" );
        if (( lr = ld->ld_requests ) == NULL ) {
                fprintf( stderr, "   Empty\n" );
@@ -501,7 +615,9 @@ ldap_dump_requests_and_responses( LDAP *ld )
            fprintf( stderr, "   outstanding referrals %d, parent count %d\n",
                    lr->lr_outrefcnt, lr->lr_parentcnt );
        }
-
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
        fprintf( stderr, "** Response Queue:\n" );
        if (( lm = ld->ld_responses ) == NULL ) {
                fprintf( stderr, "   Empty\n" );
@@ -522,25 +638,9 @@ ldap_dump_requests_and_responses( LDAP *ld )
 }
 #endif /* LDAP_DEBUG */
 
-
 void
-ldap_free_request( LDAP *ld, LDAPRequest *lr )
+ldap_free_request_int( LDAP *ld, LDAPRequest *lr )
 {
-       LDAPRequest     *tmplr, *nextlr;
-
-       Debug( LDAP_DEBUG_TRACE, "ldap_free_request (origid %d, msgid %d)\n",
-               lr->lr_origid, lr->lr_msgid, 0 );
-
-       if ( lr->lr_parent != NULL ) {
-               --lr->lr_parent->lr_outrefcnt;
-       } else {
-               /* free all referrals (child requests) */
-               for ( tmplr = lr->lr_refnext; tmplr != NULL; tmplr = nextlr ) {
-                       nextlr = tmplr->lr_refnext;
-                       ldap_free_request( ld, tmplr );
-               }
-       }
-
        if ( lr->lr_prev == NULL ) {
                ld->ld_requests = lr->lr_next;
        } else {
@@ -566,6 +666,33 @@ ldap_free_request( LDAP *ld, LDAPRequest *lr )
        LDAP_FREE( lr );
 }
 
+void
+ldap_free_request( LDAP *ld, LDAPRequest *lr )
+{
+       LDAPRequest     **ttmplr;
+
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ARGS, "ldap_free_request (origid %d, msgid %d)\n",
+               lr->lr_origid, lr->lr_msgid, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, "ldap_free_request (origid %d, msgid %d)\n",
+               lr->lr_origid, lr->lr_msgid, 0 );
+#endif
+
+       /* free all referrals (child requests) */
+       while ( lr->lr_child )
+               ldap_free_request( ld, lr->lr_child );
+
+       if ( lr->lr_parent != NULL ) {
+               --lr->lr_parent->lr_outrefcnt;
+               for ( ttmplr = &lr->lr_parent->lr_child; *ttmplr && *ttmplr != lr; ttmplr = &(*ttmplr)->lr_refnext ); 
+               if ( *ttmplr == lr )  
+                       *ttmplr = lr->lr_refnext;
+       }
+       ldap_free_request_int( ld, lr );
+}
+
+
 /*
  * Chase v3 referrals
  *
@@ -590,13 +717,17 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
        BerElement      *ber;
        char            **refarray = NULL;
        LDAPConn        *lc;
-       int                      rc, count, i, j;
+       int                      rc, count, i, j, id;
        LDAPreqinfo  rinfo;
 
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
        *hadrefp = 0;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_chase_v3referrals\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_chase_v3referrals\n", 0, 0, 0 );
+#endif
 
        unfollowed = NULL;
        rc = count = 0;
@@ -609,16 +740,25 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
 
        /* Check for hop limit exceeded */
        if ( lr->lr_parentcnt >= ld->ld_refhoplimit ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, DETAIL1, 
+                       "ldap_chase_v3referrals: more than %d referral hops (dropping)\n",
+                       ld->ld_refhoplimit, 0, 0 );
+#else
                Debug( LDAP_DEBUG_ANY,
                    "more than %d referral hops (dropping)\n", ld->ld_refhoplimit, 0, 0 );
+#endif
                ld->ld_errno = LDAP_REFERRAL_LIMIT_EXCEEDED;
            rc = -1;
                goto done;
        }
 
        /* find original request */
-       for ( origreq = lr; origreq->lr_parent != NULL; origreq = origreq->lr_parent ) {
-               ;
+       for ( origreq = lr;
+               origreq->lr_parent != NULL;
+               origreq = origreq->lr_parent )
+       {
+               /* empty */ ;
        }
 
        refarray = refs;
@@ -626,7 +766,7 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
        /* parse out & follow referrals */
        for( i=0; refarray[i] != NULL; i++) {
                /* Parse the referral URL */
-               if (( rc = ldap_url_parse( refarray[i], &srv)) != LDAP_SUCCESS) {
+               if (( rc = ldap_url_parse_ext( refarray[i], &srv)) != LDAP_SUCCESS) {
                        ld->ld_errno = rc;
                        rc = -1;
                        goto done;
@@ -655,26 +795,41 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                                 * if two search references come in one behind the other
                                 * for the same server with different contexts.
                                 */
-                               Debug( LDAP_DEBUG_TRACE, "ldap_chase_v3referrals: queue referral \"%s\"\n",
+#ifdef NEW_LOGGING
+                               LDAP_LOG ( OPERATION, DETAIL1, 
+                                       "ldap_chase_v3referrals: queue referral \"%s\"\n",
+                                       refarray[i], 0, 0 );
+#else
+                               Debug( LDAP_DEBUG_TRACE,
+                                       "ldap_chase_v3referrals: queue referral \"%s\"\n",
                                        refarray[i], 0, 0);
+#endif
                                if( lc->lconn_rebind_queue == NULL ) {
                                        /* Create a referral list */
-                                       if( (lc->lconn_rebind_queue = (char ***)LDAP_MALLOC( sizeof(void *) * 2)) == NULL) {
+                                       lc->lconn_rebind_queue =
+                                               (char ***) LDAP_MALLOC( sizeof(void *) * 2);
+
+                                       if( lc->lconn_rebind_queue == NULL) {
                                                ld->ld_errno = LDAP_NO_MEMORY;
                                                rc = -1;
                                                goto done;
                                        }
+
                                        lc->lconn_rebind_queue[0] = refarray;
                                        lc->lconn_rebind_queue[1] = NULL;
                                        refarray = NULL;
+
                                } else {
                                        /* Count how many referral arrays we already have */
                                        for( j = 0; lc->lconn_rebind_queue[j] != NULL; j++) {
-                                               ;
+                                               /* empty */;
                                        }
+
                                        /* Add the new referral to the list */
-                                       if( (lc->lconn_rebind_queue = (char ***)LDAP_REALLOC(
-                                                       lc->lconn_rebind_queue, sizeof(void *) * (j + 2))) == NULL) {
+                                       lc->lconn_rebind_queue = (char ***) LDAP_REALLOC(
+                                               lc->lconn_rebind_queue, sizeof(void *) * (j + 2));
+
+                                       if( lc->lconn_rebind_queue == NULL ) {
                                                ld->ld_errno = LDAP_NO_MEMORY;
                                                rc = -1;
                                                goto done;
@@ -683,6 +838,7 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                                        lc->lconn_rebind_queue[j+1] = NULL;
                                        refarray = NULL;
                                }
+
                                /* We have queued the referral/reference, now just return */
                                rc = 0;
                                *hadrefp = 1;
@@ -700,24 +856,47 @@ ldap_chase_v3referrals( LDAP *ld, LDAPRequest *lr, char **refs, int sref, char *
                        srv->lud_dn = LDAP_STRDUP( "" );
                }
 
-               if (( ber = re_encode_request( ld, origreq->lr_ber,
-                           ++ld->ld_msgid, srv, &rinfo.ri_request )) == NULL ) {
+               LDAP_NEXT_MSGID( ld, id );
+               ber = re_encode_request( ld, origreq->lr_ber, id,
+                       sref, srv, &rinfo.ri_request );
+
+               if( ber == NULL ) {
                        ld->ld_errno = LDAP_ENCODING_ERROR;
                        rc = -1;
                        goto done;
                }
 
-               Debug( LDAP_DEBUG_TRACE, "ldap_chase_v3referral: msgid %d, url \"%s\"\n",
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, DETAIL1, 
+                       "ldap_chase_v3referrals: msgid %d, url \"%s\"\n",
+                       lr->lr_msgid, refarray[i], 0 );
+#else
+               Debug( LDAP_DEBUG_TRACE,
+                       "ldap_chase_v3referral: msgid %d, url \"%s\"\n",
                        lr->lr_msgid, refarray[i], 0);
+#endif
 
                /* Send the new request to the server - may require a bind */
                rinfo.ri_msgid = origreq->lr_origid;
                rinfo.ri_url = refarray[i];
-               if ( (rc = ldap_send_server_request( ld, ber, ld->ld_msgid,
-                       origreq, srv, NULL, &rinfo )) < 0 ) {
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+               rc = ldap_send_server_request( ld, ber, id,
+                       origreq, srv, NULL, &rinfo );
+#ifdef LDAP_R_COMPILE
+               ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
+               if ( rc < 0 ) {
                        /* Failure, try next referral in the list */
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, ERR, 
+                       "ldap_chase_v3referrals: Unable to chase referral \"%s\" (%s)\n",
+                       refarray[i], ldap_err2string( ld->ld_errno ), 0 );
+#else
                        Debug( LDAP_DEBUG_ANY, "Unable to chase referral \"%s\" (%s)\n", 
                                refarray[i], ldap_err2string( ld->ld_errno ), 0);
+#endif
                        unfollowedcnt += ldap_append_referral( ld, &unfollowed, refarray[i]);
                        ldap_free_urllist(srv);
                        srv = NULL;
@@ -781,16 +960,25 @@ done:
  * XXX merging of errors in this routine needs to be improved
  */
 int
-ldap_chase_referrals( LDAP *ld, LDAPRequest *lr, char **errstrp, int *hadrefp )
+ldap_chase_referrals( LDAP *ld,
+       LDAPRequest *lr,
+       char **errstrp,
+       int sref,
+       int *hadrefp )
 {
-       int             rc, count, len;
+       int             rc, count, id;
+       unsigned        len;
        char            *p, *ref, *unfollowed;
        LDAPRequest     *origreq;
        LDAPURLDesc     *srv;
        BerElement      *ber;
        LDAPreqinfo  rinfo;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_chase_referrals\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_chase_referrals\n", 0, 0, 0 );
+#endif
 
        ld->ld_errno = LDAP_SUCCESS;    /* optimistic */
        *hadrefp = 0;
@@ -813,9 +1001,15 @@ ldap_chase_referrals( LDAP *ld, LDAPRequest *lr, char **errstrp, int *hadrefp )
        }
 
        if ( lr->lr_parentcnt >= ld->ld_refhoplimit ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ENTRY, 
+                       "ldap_chase_referrals: more than %d referral hops (dropping)\n",
+                       ld->ld_refhoplimit, 0, 0 );
+#else
                Debug( LDAP_DEBUG_ANY,
                    "more than %d referral hops (dropping)\n",
                    ld->ld_refhoplimit, 0, 0 );
+#endif
                    /* XXX report as error in ld->ld_errno? */
                    return( 0 );
        }
@@ -840,8 +1034,14 @@ ldap_chase_referrals( LDAP *ld, LDAPRequest *lr, char **errstrp, int *hadrefp )
                rc = ldap_url_parse_ext( ref, &srv );
 
                if ( rc != LDAP_URL_SUCCESS ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "ldap_chase_referrals: ignoring unknown referral <%s>\n",
+                               ref, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE,
                            "ignoring unknown referral <%s>\n", ref, 0, 0 );
+#endif
                        rc = ldap_append_referral( ld, &unfollowed, ref );
                        *hadrefp = 1;
                        continue;
@@ -852,13 +1052,19 @@ ldap_chase_referrals( LDAP *ld, LDAPRequest *lr, char **errstrp, int *hadrefp )
                        srv->lud_dn = NULL;
                }
 
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, DETAIL1, 
+                       "ldap_chase_referrals: chasing LDAP referral <%s>\n", ref, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE,
                    "chasing LDAP referral: <%s>\n", ref, 0, 0 );
+#endif
 
                *hadrefp = 1;
 
+               LDAP_NEXT_MSGID( ld, id );
                ber = re_encode_request( ld, origreq->lr_ber,
-                   ++ld->ld_msgid, srv, &rinfo.ri_request );
+                   id, sref, srv, &rinfo.ri_request );
 
                if( ber == NULL ) {
                        return -1 ;
@@ -869,17 +1075,29 @@ ldap_chase_referrals( LDAP *ld, LDAPRequest *lr, char **errstrp, int *hadrefp )
 
                rinfo.ri_msgid = origreq->lr_origid;
 
-               rc = ldap_send_server_request( ld, ber, ld->ld_msgid,
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+               rc = ldap_send_server_request( ld, ber, id,
                    lr, srv, NULL, &rinfo );
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
 
                LDAP_FREE( rinfo.ri_url );
 
                if( rc >= 0 ) {
                        ++count;
                } else {
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, ERR, 
+                               "ldap_chase_referrals: Unable to chase referral <%s>\n", 
+                               ldap_err2string( ld->ld_errno), 0, 0 );
+#else
                        Debug( LDAP_DEBUG_ANY,
                            "Unable to chase referral (%s)\n", 
                            ldap_err2string( ld->ld_errno ), 0, 0 );
+#endif
                        rc = ldap_append_referral( ld, &unfollowed, ref );
                }
 
@@ -929,6 +1147,7 @@ static BerElement *
 re_encode_request( LDAP *ld,
        BerElement *origber,
        ber_int_t msgid,
+       int sref,
        LDAPURLDesc *srv,
        int *type )
 {
@@ -937,6 +1156,7 @@ re_encode_request( LDAP *ld,
         */
        ber_int_t       along;
        ber_tag_t       tag;
+       ber_tag_t       rtag;
        ber_int_t       ver;
        ber_int_t       scope;
        int             rc;
@@ -944,10 +1164,17 @@ re_encode_request( LDAP *ld,
        char            *orig_dn;
        char            *dn;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ARGS, 
+               "re_encode_request: new msgid %ld, new dn <%s>\n",
+               (long) msgid, 
+               ( srv == NULL || srv->lud_dn == NULL ) ? "NONE" : srv->lud_dn, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE,
            "re_encode_request: new msgid %ld, new dn <%s>\n",
            (long) msgid,
                ( srv == NULL || srv->lud_dn == NULL) ? "NONE" : srv->lud_dn, 0 );
+#endif
 
        tmpber = *origber;
 
@@ -957,9 +1184,9 @@ re_encode_request( LDAP *ld,
         * tagged with the operation code.  For delete, the provided DN
         * is not wrapped by a sequence.
         */
-       rc = ber_scanf( &tmpber, "{it", /*}*/ &along, &tag );
+       rtag = ber_scanf( &tmpber, "{it", /*}*/ &along, &tag );
 
-       if ( rc == LBER_ERROR ) {
+       if ( rtag == LBER_ERROR ) {
                ld->ld_errno = LDAP_DECODING_ERROR;
                return( NULL );
        }
@@ -967,21 +1194,21 @@ re_encode_request( LDAP *ld,
        assert( tag != 0);
        if ( tag == LDAP_REQ_BIND ) {
                /* bind requests have a version number before the DN & other stuff */
-               rc = ber_scanf( &tmpber, "{ia" /*}*/, &ver, &orig_dn );
+               rtag = ber_scanf( &tmpber, "{ia" /*}*/, &ver, &orig_dn );
 
        } else if ( tag == LDAP_REQ_DELETE ) {
                /* delete requests don't have a DN wrapping sequence */
-               rc = ber_scanf( &tmpber, "a", &orig_dn );
+               rtag = ber_scanf( &tmpber, "a", &orig_dn );
 
        } else if ( tag == LDAP_REQ_SEARCH ) {
                /* search requests need to be re-scope-ed */
-               rc = ber_scanf( &tmpber, "{ae" /*"}"*/, &orig_dn, &scope );
+               rtag = ber_scanf( &tmpber, "{ae" /*"}"*/, &orig_dn, &scope );
 
                if( srv->lud_scope != LDAP_SCOPE_DEFAULT ) {
                        /* use the scope provided in reference */
                        scope = srv->lud_scope;
 
-               } else if ( scope != LDAP_SCOPE_SUBTREE ) {
+               } else if ( sref && scope != LDAP_SCOPE_SUBTREE ) {
                        /* use scope implied by previous operation */
                        /*   base -> base */
                        /*   one -> base */
@@ -990,10 +1217,10 @@ re_encode_request( LDAP *ld,
                }
 
        } else {
-               rc = ber_scanf( &tmpber, "{a" /*}*/, &orig_dn );
+               rtag = ber_scanf( &tmpber, "{a" /*}*/, &orig_dn );
        }
 
-       if( rc == LBER_ERROR ) {
+       if( rtag == LBER_ERROR ) {
                ld->ld_errno = LDAP_DECODING_ERROR;
                return NULL;
        }
@@ -1038,8 +1265,13 @@ re_encode_request( LDAP *ld,
 
 #ifdef LDAP_DEBUG
        if ( ldap_debug & LDAP_DEBUG_PACKETS ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, DETAIL1, 
+                       "re_encode_request: new request is:\n", 0, 0, 0 );
+#else
                Debug( LDAP_DEBUG_ANY, "re_encode_request new request is:\n",
                    0, 0, 0 );
+#endif
                ber_log_dump( LDAP_DEBUG_BER, ldap_debug, ber, 0 );
        }
 #endif /* LDAP_DEBUG */
@@ -1054,6 +1286,9 @@ ldap_find_request_by_msgid( LDAP *ld, ber_int_t msgid )
 {
        LDAPRequest     *lr;
 
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
        for ( lr = ld->ld_requests; lr != NULL; lr = lr->lr_next ) {
                if( lr->lr_status == LDAP_REQST_COMPLETED ) {
                        continue;       /* Skip completed requests */
@@ -1062,6 +1297,9 @@ ldap_find_request_by_msgid( LDAP *ld, ber_int_t msgid )
                        break;
                }
        }
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
 
        return( lr );
 }