]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/unbind.c
ITS#4052,4053 plug mem leaks
[openldap] / libraries / libldap / unbind.c
index 0d5f3fe46ac3204488e8d7443cc2514fbb3e6a83..8966df8a4938ab5dd942a30fd411660a5dcb968c 100644 (file)
@@ -1,13 +1,22 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
- */
-/*  Portions
- *  Copyright (c) 1990 Regents of the University of Michigan.
- *  All rights reserved.
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2005 The OpenLDAP Foundation.
+ * All rights reserved.
  *
- *  unbind.c
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1990 Regents of the University of Michigan.
+ * All rights reserved.
+ */
+/* Portions Copyright (C) The Internet Society (1997)
+ * ASN.1 fragments are from RFC 2251; see RFC for full legal notices.
  */
 
 /* An Unbind Request looks like this:
@@ -36,6 +45,9 @@ ldap_unbind_ext(
 {
        int rc;
 
+       assert( ld != NULL );
+       assert( LDAP_VALID( ld ) );
+
        /* check client controls */
        rc = ldap_int_client_controls( ld, cctrls );
        if( rc != LDAP_SUCCESS ) return rc;
@@ -55,7 +67,11 @@ ldap_unbind_ext_s(
 int
 ldap_unbind( LDAP *ld )
 {
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_unbind\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_unbind\n", 0, 0, 0 );
+#endif
 
        return( ldap_unbind_ext( ld, NULL, NULL ) );
 }
@@ -70,30 +86,33 @@ ldap_ld_free(
 {
        LDAPMessage     *lm, *next;
        int             err = LDAP_SUCCESS;
-       LDAPRequest     *lr, *nextlr;
 
-               /* free LDAP structure and outstanding requests/responses */
-               for ( lr = ld->ld_requests; lr != NULL; lr = nextlr ) {
-                       nextlr = lr->lr_next;
-                       ldap_free_request( ld, lr );
-               }
+       /* free LDAP structure and outstanding requests/responses */
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+       while ( ld->ld_requests != NULL ) {
+               ldap_free_request( ld, ld->ld_requests );
+       }
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
 
-               /* free and unbind from all open connections */
-               while ( ld->ld_conns != NULL ) {
-                       ldap_free_connection( ld, ld->ld_conns, 1, close );
-               }
+       /* free and unbind from all open connections */
+       while ( ld->ld_conns != NULL ) {
+               ldap_free_connection( ld, ld->ld_conns, 1, close );
+       }
 
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_res_mutex );
+#endif
        for ( lm = ld->ld_responses; lm != NULL; lm = next ) {
                next = lm->lm_next;
                ldap_msgfree( lm );
        }
-
-#ifndef LDAP_NOCACHE
-       if ( ld->ld_cache != NULL ) {
-               ldap_destroy_cache( ld );
-               ld->ld_cache = NULL;
-       }
-#endif /* !LDAP_NOCACHE */
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_res_mutex );
+#endif
 
        if ( ld->ld_error != NULL ) {
                LDAP_FREE( ld->ld_error );
@@ -105,6 +124,11 @@ ldap_ld_free(
                ld->ld_matched = NULL;
        }
 
+       if( ld->ld_referrals != NULL) {
+               LDAP_VFREE(ld->ld_referrals);
+               ld->ld_referrals = NULL;
+       }  
+    
        if ( ld->ld_abandoned != NULL ) {
                LDAP_FREE( ld->ld_abandoned );
                ld->ld_abandoned = NULL;
@@ -120,6 +144,13 @@ ldap_ld_free(
                ld->ld_options.ldo_defludp = NULL;
        }
 
+#ifdef LDAP_CONNECTIONLESS
+       if ( ld->ld_options.ldo_peer != NULL ) {
+               LDAP_FREE( ld->ld_options.ldo_peer );
+               ld->ld_options.ldo_peer = NULL;
+       }
+#endif
+
        if ( ld->ld_options.ldo_tm_api != NULL ) {
                LDAP_FREE( ld->ld_options.ldo_tm_api );
                ld->ld_options.ldo_tm_api = NULL;
@@ -130,12 +161,46 @@ ldap_ld_free(
                ld->ld_options.ldo_tm_net = NULL;
        }
 
+#ifdef HAVE_CYRUS_SASL
+       if ( ld->ld_options.ldo_def_sasl_mech != NULL ) {
+               LDAP_FREE( ld->ld_options.ldo_def_sasl_mech );
+               ld->ld_options.ldo_def_sasl_mech = NULL;
+       }
+
+       if ( ld->ld_options.ldo_def_sasl_realm != NULL ) {
+               LDAP_FREE( ld->ld_options.ldo_def_sasl_realm );
+               ld->ld_options.ldo_def_sasl_realm = NULL;
+       }
+
+       if ( ld->ld_options.ldo_def_sasl_authcid != NULL ) {
+               LDAP_FREE( ld->ld_options.ldo_def_sasl_authcid );
+               ld->ld_options.ldo_def_sasl_authcid = NULL;
+       }
+
+       if ( ld->ld_options.ldo_def_sasl_authzid != NULL ) {
+               LDAP_FREE( ld->ld_options.ldo_def_sasl_authzid );
+               ld->ld_options.ldo_def_sasl_authzid = NULL;
+       }
+#endif
+
+       if ( ld->ld_options.ldo_sctrls != NULL ) {
+               ldap_controls_free( ld->ld_options.ldo_sctrls );
+               ld->ld_options.ldo_sctrls = NULL;
+       }
+
+       if ( ld->ld_options.ldo_cctrls != NULL ) {
+               ldap_controls_free( ld->ld_options.ldo_cctrls );
+               ld->ld_options.ldo_cctrls = NULL;
+       }
+
        ber_sockbuf_free( ld->ld_sb );   
    
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_destroy( &ld->ld_req_mutex );
+       ldap_pvt_thread_mutex_destroy( &ld->ld_res_mutex );
+#endif
        LDAP_FREE( (char *) ld );
    
-       WSACleanup();
-
        return( err );
 }
 
@@ -154,16 +219,26 @@ ldap_send_unbind(
        LDAPControl **cctrls )
 {
        BerElement      *ber;
+       ber_int_t       id;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY, "ldap_send_unbind\n", 0, 0, 0 );
+#else
        Debug( LDAP_DEBUG_TRACE, "ldap_send_unbind\n", 0, 0, 0 );
+#endif
 
+#ifdef LDAP_CONNECTIONLESS
+       if (LDAP_IS_UDP(ld))
+               return LDAP_SUCCESS;
+#endif
        /* create a message to send */
        if ( (ber = ldap_alloc_ber_with_options( ld )) == NULL ) {
                return( ld->ld_errno );
        }
 
+       LDAP_NEXT_MSGID( ld, id );
        /* fill it in */
-       if ( ber_printf( ber, "{itn" /*}*/, ++ld->ld_msgid,
+       if ( ber_printf( ber, "{itn" /*}*/, id,
            LDAP_REQ_UNBIND ) == -1 ) {
                ld->ld_errno = LDAP_ENCODING_ERROR;
                ber_free( ber, 1 );
@@ -182,12 +257,18 @@ ldap_send_unbind(
                return( ld->ld_errno );
        }
 
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_lock( &ld->ld_req_mutex );
+#endif
+       ld->ld_errno = LDAP_SUCCESS;
        /* send the message */
        if ( ber_flush( sb, ber, 1 ) == -1 ) {
                ld->ld_errno = LDAP_SERVER_DOWN;
                ber_free( ber, 1 );
-               return( ld->ld_errno );
        }
+#ifdef LDAP_R_COMPILE
+       ldap_pvt_thread_mutex_unlock( &ld->ld_req_mutex );
+#endif
 
-       return( LDAP_SUCCESS );
+       return( ld->ld_errno );
 }