]> git.sur5r.net Git - openldap/blobdiff - libraries/libldap/url.c
ITS#7428 Use non-blocking IO during SSL Handshake
[openldap] / libraries / libldap / url.c
index d72dbcb5b2fc4a6f244a553b943028f148ccd30c..88f19c742efe2a457fe77d7e7ab3b4a6a6c93f1d 100644 (file)
@@ -1,23 +1,33 @@
+/* LIBLDAP url.c -- LDAP URL (RFC 4516) related routines */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
- */
-/*  Portions
- *  Copyright (c) 1996 Regents of the University of Michigan.
- *  All rights reserved.
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- *  LIBLDAP url.c -- LDAP URL (RFC 2255) related routines
+ * Copyright 1998-2012 The OpenLDAP Foundation.
+ * All rights reserved.
  *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
+/* Portions Copyright (c) 1996 Regents of the University of Michigan.
+ * All rights reserved.
+ */
+
+
+/*
  *  LDAP URLs look like this:
- *    ldap[is]://host:port[/[dn[?[attributes][?[scope][?[filter][?exts]]]]]]
+ *    ldap[is]://host[:port][/[dn[?[attributes][?[scope][?[filter][?exts]]]]]]
  *
  *  where:
  *   attributes is a comma separated list
  *   scope is one of these three strings:  base one sub (default=base)
- *   filter is an string-represented filter as in RFC 2254
+ *   filter is an string-represented filter as in RFC 4515
  *
- *  e.g.,  ldap://host:port/dc=com?o,cn?base?o=openldap?extension
+ *  e.g.,  ldap://host:port/dc=com?o,cn?base?(o=openldap)?extension
  *
  *  We also tolerate URLs that look like: <ldapurl> and <URL:ldapurl>
  */
 #include <stdio.h>
 
 #include <ac/stdlib.h>
-
 #include <ac/ctype.h>
+
 #include <ac/socket.h>
 #include <ac/string.h>
 #include <ac/time.h>
 
 #include "ldap-int.h"
 
-
 /* local functions */
 static const char* skip_url_prefix LDAP_P((
        const char *url,
@@ -44,7 +53,7 @@ static const char* skip_url_prefix LDAP_P((
 
 int ldap_pvt_url_scheme2proto( const char *scheme )
 {
-       assert( scheme );
+       assert( scheme != NULL );
 
        if( scheme == NULL ) {
                return -1;
@@ -61,13 +70,47 @@ int ldap_pvt_url_scheme2proto( const char *scheme )
        if( strcmp("ldaps", scheme) == 0 ) {
                return LDAP_PROTO_TCP;
        }
+#ifdef LDAP_CONNECTIONLESS
+       if( strcmp("cldap", scheme) == 0 ) {
+               return LDAP_PROTO_UDP;
+       }
+#endif
 
        return -1;
 }
 
-int ldap_pvt_url_scheme2tls( const char *scheme )
+int ldap_pvt_url_scheme_port( const char *scheme, int port )
 {
-       assert( scheme );
+       assert( scheme != NULL );
+
+       if( port ) return port;
+       if( scheme == NULL ) return port;
+
+       if( strcmp("ldap", scheme) == 0 ) {
+               return LDAP_PORT;
+       }
+
+       if( strcmp("ldapi", scheme) == 0 ) {
+               return -1;
+       }
+
+       if( strcmp("ldaps", scheme) == 0 ) {
+               return LDAPS_PORT;
+       }
+
+#ifdef LDAP_CONNECTIONLESS
+       if( strcmp("cldap", scheme) == 0 ) {
+               return LDAP_PORT;
+       }
+#endif
+
+       return -1;
+}
+
+int
+ldap_pvt_url_scheme2tls( const char *scheme )
+{
+       assert( scheme != NULL );
 
        if( scheme == NULL ) {
                return -1;
@@ -127,16 +170,35 @@ ldap_is_ldapi_url( LDAP_CONST char *url )
        return strcmp(scheme, "ldapi") == 0;
 }
 
+#ifdef LDAP_CONNECTIONLESS
+int
+ldap_is_ldapc_url( LDAP_CONST char *url )
+{
+       int     enclosed;
+       const char * scheme;
+
+       if( url == NULL ) {
+               return 0;
+       }
+
+       if( skip_url_prefix( url, &enclosed, &scheme ) == NULL ) {
+               return 0;
+       }
+
+       return strcmp(scheme, "cldap") == 0;
+}
+#endif
+
 static const char*
 skip_url_prefix(
        const char *url,
        int *enclosedp,
        const char **scheme )
 {
-/*
- * return non-zero if this looks like a LDAP URL; zero if not
- * if non-zero returned, *urlp will be moved past "ldap://" part of URL
- */
+       /*
       * return non-zero if this looks like a LDAP URL; zero if not
       * if non-zero returned, *urlp will be moved past "ldap://" part of URL
       */
        const char *p;
 
        if ( url == NULL ) {
@@ -154,8 +216,7 @@ skip_url_prefix(
        }
 
        /* skip leading "URL:" (if any) */
-       if ( strncasecmp( p, LDAP_URL_URLCOLON, LDAP_URL_URLCOLON_LEN ) == 0 )
-       {
+       if ( strncasecmp( p, LDAP_URL_URLCOLON, LDAP_URL_URLCOLON_LEN ) == 0 ) {
                p += LDAP_URL_URLCOLON_LEN;
        }
 
@@ -183,51 +244,578 @@ skip_url_prefix(
                return( p );
        }
 
+#ifdef LDAP_CONNECTIONLESS
+       /* check for "cldap://" prefix */
+       if ( strncasecmp( p, LDAPC_URL_PREFIX, LDAPC_URL_PREFIX_LEN ) == 0 ) {
+               /* skip over "cldap://" prefix and return success */
+               p += LDAPC_URL_PREFIX_LEN;
+               *scheme = "cldap";
+               return( p );
+       }
+#endif
+
        return( NULL );
 }
 
-
-static int str2scope( const char *p )
+int
+ldap_pvt_scope2bv( int scope, struct berval *bv )
 {
-       if ( strcasecmp( p, "one" ) == 0 ) {
-               return LDAP_SCOPE_ONELEVEL;
+       switch ( scope ) {
+       case LDAP_SCOPE_BASE:
+               BER_BVSTR( bv, "base" );
+               break;
+
+       case LDAP_SCOPE_ONELEVEL:
+               BER_BVSTR( bv, "one" );
+               break;
+
+       case LDAP_SCOPE_SUBTREE:
+               BER_BVSTR( bv, "sub" );
+               break;
+
+       case LDAP_SCOPE_SUBORDINATE:
+               BER_BVSTR( bv, "subordinate" );
+               break;
 
-       } else if ( strcasecmp( p, "onetree" ) == 0 ) {
-               return LDAP_SCOPE_ONELEVEL;
+       default:
+               return LDAP_OTHER;
+       }
+
+       return LDAP_SUCCESS;
+}
+
+const char *
+ldap_pvt_scope2str( int scope )
+{
+       struct berval   bv;
 
-       } else if ( strcasecmp( p, "base" ) == 0 ) {
-               return LDAP_SCOPE_BASE;
+       if ( ldap_pvt_scope2bv( scope, &bv ) == LDAP_SUCCESS ) {
+               return bv.bv_val;
+       }
 
-       } else if ( strcasecmp( p, "sub" ) == 0 ) {
-               return LDAP_SCOPE_SUBTREE;
+       return NULL;
+}
 
-       } else if ( strcasecmp( p, "subtree" ) == 0 ) {
-               return LDAP_SCOPE_SUBTREE;
+int
+ldap_pvt_bv2scope( struct berval *bv )
+{
+       static struct {
+               struct berval   bv;
+               int             scope;
+       }       v[] = {
+               { BER_BVC( "one" ),             LDAP_SCOPE_ONELEVEL },
+               { BER_BVC( "onelevel" ),        LDAP_SCOPE_ONELEVEL },
+               { BER_BVC( "base" ),            LDAP_SCOPE_BASE },
+               { BER_BVC( "sub" ),             LDAP_SCOPE_SUBTREE },
+               { BER_BVC( "subtree" ),         LDAP_SCOPE_SUBTREE },
+               { BER_BVC( "subord" ),          LDAP_SCOPE_SUBORDINATE },
+               { BER_BVC( "subordinate" ),     LDAP_SCOPE_SUBORDINATE },
+               { BER_BVC( "children" ),        LDAP_SCOPE_SUBORDINATE },
+               { BER_BVNULL,                   -1 }
+       };
+       int     i;
+
+       for ( i = 0; v[ i ].scope != -1; i++ ) {
+               if ( ber_bvstrcasecmp( bv, &v[ i ].bv ) == 0 ) {
+                       return v[ i ].scope;
+               }
        }
 
        return( -1 );
 }
 
+int
+ldap_pvt_str2scope( const char *p )
+{
+       struct berval   bv;
+
+       ber_str2bv( p, 0, 0, &bv );
+
+       return ldap_pvt_bv2scope( &bv );
+}
+
+static const char      hex[] = "0123456789ABCDEF";
+
+#define URLESC_NONE    0x0000U
+#define URLESC_COMMA   0x0001U
+#define URLESC_SLASH   0x0002U
+
+static int
+hex_escape_len( const char *s, unsigned list )
+{
+       int     len;
+
+       if ( s == NULL ) {
+               return 0;
+       }
+
+       for ( len = 0; s[0]; s++ ) {
+               switch ( s[0] ) {
+               /* RFC 2396: reserved */
+               case '?':
+                       len += 3;
+                       break;
+
+               case ',':
+                       if ( list & URLESC_COMMA ) {
+                               len += 3;
+                       } else {
+                               len++;
+                       }
+                       break;
+
+               case '/':
+                       if ( list & URLESC_SLASH ) {
+                               len += 3;
+                       } else {
+                               len++;
+                       }
+                       break;
+
+               case ';':
+               case ':':
+               case '@':
+               case '&':
+               case '=':
+               case '+':
+               case '$':
+
+               /* RFC 2396: unreserved mark */
+               case '-':
+               case '_':
+               case '.':
+               case '!':
+               case '~':
+               case '*':
+               case '\'':
+               case '(':
+               case ')':
+                       len++;
+                       break;
+                       
+               /* RFC 2396: unreserved alphanum */
+               default:
+                       if ( !isalnum( (unsigned char) s[0] ) ) {
+                               len += 3;
+                       } else {
+                               len++;
+                       }
+                       break;
+               }
+       }
+
+       return len;
+}
+
+static int
+hex_escape( char *buf, int len, const char *s, unsigned list )
+{
+       int     i;
+       int     pos;
+
+       if ( s == NULL ) {
+               return 0;
+       }
+
+       for ( pos = 0, i = 0; s[i] && pos < len; i++ ) {
+               int     escape = 0;
+
+               switch ( s[i] ) {
+               /* RFC 2396: reserved */
+               case '?':
+                       escape = 1;
+                       break;
+
+               case ',':
+                       if ( list & URLESC_COMMA ) {
+                               escape = 1;
+                       }
+                       break;
+
+               case '/':
+                       if ( list & URLESC_SLASH ) {
+                               escape = 1;
+                       }
+                       break;
+
+               case ';':
+               case ':':
+               case '@':
+               case '&':
+               case '=':
+               case '+':
+               case '$':
+
+               /* RFC 2396: unreserved mark */
+               case '-':
+               case '_':
+               case '.':
+               case '!':
+               case '~':
+               case '*':
+               case '\'':
+               case '(':
+               case ')':
+                       break;
+                       
+               /* RFC 2396: unreserved alphanum */
+               default:
+                       if ( !isalnum( (unsigned char) s[i] ) ) {
+                               escape = 1;
+                       }
+                       break;
+               }
+
+               if ( escape ) {
+                       buf[pos++] = '%';
+                       buf[pos++] = hex[ (s[i] >> 4) & 0x0f ];
+                       buf[pos++] = hex[ s[i] & 0x0f ];
+
+               } else {
+                       buf[pos++] = s[i];
+               }
+       }
+
+       buf[pos] = '\0';
+
+       return pos;
+}
+
+static int
+hex_escape_len_list( char **s, unsigned flags )
+{
+       int     len;
+       int     i;
+
+       if ( s == NULL ) {
+               return 0;
+       }
+
+       len = 0;
+       for ( i = 0; s[i] != NULL; i++ ) {
+               if ( len ) {
+                       len++;
+               }
+               len += hex_escape_len( s[i], flags );
+       }
+
+       return len;
+}
+
+static int
+hex_escape_list( char *buf, int len, char **s, unsigned flags )
+{
+       int     pos;
+       int     i;
+
+       if ( s == NULL ) {
+               return 0;
+       }
+
+       pos = 0;
+       for ( i = 0; s[i] != NULL; i++ ) {
+               int     curlen;
+
+               if ( pos ) {
+                       buf[pos++] = ',';
+                       len--;
+               }
+               curlen = hex_escape( &buf[pos], len, s[i], flags );
+               len -= curlen;
+               pos += curlen;
+       }
+
+       return pos;
+}
+
+static int
+desc2str_len( LDAPURLDesc *u )
+{
+       int             sep = 0;
+       int             len = 0;
+       int             is_ipc = 0;
+       struct berval   scope;
+
+       if ( u == NULL || u->lud_scheme == NULL ) {
+               return -1;
+       }
+
+       if ( !strcmp( "ldapi", u->lud_scheme )) {
+               is_ipc = 1;
+       }
+
+       if ( u->lud_exts ) {
+               len += hex_escape_len_list( u->lud_exts, URLESC_COMMA );
+               if ( !sep ) {
+                       sep = 5;
+               }
+       }
+
+       if ( u->lud_filter ) {
+               len += hex_escape_len( u->lud_filter, URLESC_NONE );
+               if ( !sep ) {
+                       sep = 4;
+               }
+       }
+
+       if ( ldap_pvt_scope2bv( u->lud_scope, &scope ) == LDAP_SUCCESS ) {
+               len += scope.bv_len;
+               if ( !sep ) {
+                       sep = 3;
+               }
+       }
+
+       if ( u->lud_attrs ) {
+               len += hex_escape_len_list( u->lud_attrs, URLESC_NONE );
+               if ( !sep ) {
+                       sep = 2;
+               }
+       }
+
+       if ( u->lud_dn && u->lud_dn[0] ) {
+               len += hex_escape_len( u->lud_dn, URLESC_NONE );
+               if ( !sep ) {
+                       sep = 1;
+               }
+       };
+
+       len += sep;
+
+       if ( u->lud_port ) {
+               unsigned p = u->lud_port;
+               if ( p > 65535 )
+                       return -1;
+
+               len += (p > 999 ? 5 + (p > 9999) : p > 99 ? 4 : 2 + (p > 9));
+       }
+
+       if ( u->lud_host && u->lud_host[0] ) {
+               char *ptr;
+               len += hex_escape_len( u->lud_host, URLESC_SLASH );
+               if ( !is_ipc && ( ptr = strchr( u->lud_host, ':' ))) {
+                       if ( strchr( ptr+1, ':' ))
+                               len += 2;       /* IPv6, [] */
+               }
+       }
+
+       len += strlen( u->lud_scheme ) + STRLENOF( "://" );
+
+       return len;
+}
+
+static int
+desc2str( LDAPURLDesc *u, char *s, int len )
+{
+       int             i;
+       int             sep = 0;
+       int             sofar = 0;
+       int             is_v6 = 0;
+       int             is_ipc = 0;
+       struct berval   scope = BER_BVNULL;
+       char            *ptr;
+
+       if ( u == NULL ) {
+               return -1;
+       }
+
+       if ( s == NULL ) {
+               return -1;
+       }
+
+       if ( u->lud_scheme && !strcmp( "ldapi", u->lud_scheme )) {
+               is_ipc = 1;
+       }
+
+       ldap_pvt_scope2bv( u->lud_scope, &scope );
+
+       if ( u->lud_exts ) {
+               sep = 5;
+       } else if ( u->lud_filter ) {
+               sep = 4;
+       } else if ( !BER_BVISEMPTY( &scope ) ) {
+               sep = 3;
+       } else if ( u->lud_attrs ) {
+               sep = 2;
+       } else if ( u->lud_dn && u->lud_dn[0] ) {
+               sep = 1;
+       }
+
+       if ( !is_ipc && u->lud_host && ( ptr = strchr( u->lud_host, ':' ))) {
+               if ( strchr( ptr+1, ':' ))
+                       is_v6 = 1;
+       }
+
+       if ( u->lud_port ) {
+               sofar = sprintf( s, "%s://%s%s%s:%d", u->lud_scheme,
+                               is_v6 ? "[" : "",
+                               u->lud_host ? u->lud_host : "",
+                               is_v6 ? "]" : "",
+                               u->lud_port );
+               len -= sofar;
+
+       } else {
+               sofar = sprintf( s, "%s://", u->lud_scheme );
+               len -= sofar;
+               if ( u->lud_host && u->lud_host[0] ) {
+                       if ( is_v6 ) {
+                               s[sofar++] = '[';
+                               len--;
+                       }
+                       i = hex_escape( &s[sofar], len, u->lud_host, URLESC_SLASH );
+                       sofar += i;
+                       len -= i;
+                       if ( is_v6 ) {
+                               s[sofar++] = ']';
+                               len--;
+                       }
+               }
+       }
+
+       assert( len >= 0 );
+
+       if ( sep < 1 ) {
+               goto done;
+       }
+
+       s[sofar++] = '/';
+       len--;
+
+       assert( len >= 0 );
+
+       if ( u->lud_dn && u->lud_dn[0] ) {
+               i = hex_escape( &s[sofar], len, u->lud_dn, URLESC_NONE );
+               sofar += i;
+               len -= i;
+
+               assert( len >= 0 );
+       }
+
+       if ( sep < 2 ) {
+               goto done;
+       }
+       s[sofar++] = '?';
+       len--;
+
+       assert( len >= 0 );
+
+       i = hex_escape_list( &s[sofar], len, u->lud_attrs, URLESC_NONE );
+       sofar += i;
+       len -= i;
+
+       assert( len >= 0 );
+
+       if ( sep < 3 ) {
+               goto done;
+       }
+       s[sofar++] = '?';
+       len--;
+
+       assert( len >= 0 );
+
+       if ( !BER_BVISNULL( &scope ) ) {
+               strcpy( &s[sofar], scope.bv_val );
+               sofar += scope.bv_len;
+               len -= scope.bv_len;
+       }
+
+       assert( len >= 0 );
+
+       if ( sep < 4 ) {
+               goto done;
+       }
+       s[sofar++] = '?';
+       len--;
+
+       assert( len >= 0 );
+
+       i = hex_escape( &s[sofar], len, u->lud_filter, URLESC_NONE );
+       sofar += i;
+       len -= i;
+
+       assert( len >= 0 );
+
+       if ( sep < 5 ) {
+               goto done;
+       }
+       s[sofar++] = '?';
+       len--;
+
+       assert( len >= 0 );
+
+       i = hex_escape_list( &s[sofar], len, u->lud_exts, URLESC_COMMA );
+       sofar += i;
+       len -= i;
+
+       assert( len >= 0 );
+
+done:
+       if ( len < 0 ) {
+               return -1;
+       }
+
+       return sofar;
+}
+
+char *
+ldap_url_desc2str( LDAPURLDesc *u )
+{
+       int     len;
+       char    *s;
+
+       if ( u == NULL ) {
+               return NULL;
+       }
+
+       len = desc2str_len( u );
+       if ( len < 0 ) {
+               return NULL;
+       }
+       
+       /* allocate enough to hex escape everything -- overkill */
+       s = LDAP_MALLOC( len + 1 );
+
+       if ( s == NULL ) {
+               return NULL;
+       }
+
+       if ( desc2str( u, s, len ) != len ) {
+               LDAP_FREE( s );
+               return NULL;
+       }
+
+       s[len] = '\0';
+
+       return s;
+}
 
 int
-ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
+ldap_url_parse_ext( LDAP_CONST char *url_in, LDAPURLDesc **ludpp, unsigned flags )
 {
 /*
  *  Pick apart the pieces of an LDAP URL.
  */
 
        LDAPURLDesc     *ludp;
-       char    *p, *q;
-       int             i, enclosed;
+       char    *p, *q, *r;
+       int             i, enclosed, proto, is_v6 = 0;
        const char *scheme = NULL;
        const char *url_tmp;
        char *url;
 
-       if( url_in == NULL && ludpp == NULL ) {
+       int     check_dn = 1;
+
+       if( url_in == NULL || ludpp == NULL ) {
                return LDAP_URL_ERR_PARAM;
        }
 
-       Debug( LDAP_DEBUG_TRACE, "ldap_url_parse(%s)\n", url_in, 0, 0 );
+#ifndef LDAP_INT_IN_KERNEL
+       /* Global options may not be created yet
+        * We can't test if the global options are initialized
+        * because a call to LDAP_INT_GLOBAL_OPT() will try to allocate
+        * the options and cause infinite recursion
+        */
+       Debug( LDAP_DEBUG_TRACE, "ldap_url_parse_ext(%s)\n", url_in, 0, 0 );
+#endif
 
        *ludpp = NULL;  /* pessimistic */
 
@@ -237,11 +825,17 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
                return LDAP_URL_ERR_BADSCHEME;
        }
 
-       assert( scheme );
+       assert( scheme != NULL );
+
+       proto = ldap_pvt_url_scheme2proto( scheme );
+       if ( proto == -1 ) {
+               return LDAP_URL_ERR_BADSCHEME;
+       }
 
        /* make working copy of the remainder of the URL */
-       if (( url = LDAP_STRDUP( url_tmp )) == NULL ) {
-               return( LDAP_URL_ERR_MEM );
+       url = LDAP_STRDUP( url_tmp );
+       if ( url == NULL ) {
+               return LDAP_URL_ERR_MEM;
        }
 
        if ( enclosed ) {
@@ -268,9 +862,9 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
        ludp->lud_port = 0;
        ludp->lud_dn = NULL;
        ludp->lud_attrs = NULL;
+       ludp->lud_scope = ( flags & LDAP_PVT_URL_PARSE_NODEF_SCOPE ) ? LDAP_SCOPE_BASE : LDAP_SCOPE_DEFAULT;
        ludp->lud_filter = NULL;
-       ludp->lud_scope = LDAP_SCOPE_BASE;
-       ludp->lud_filter = NULL;
+       ludp->lud_exts = NULL;
 
        ludp->lud_scheme = LDAP_STRDUP( scheme );
 
@@ -282,27 +876,83 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
 
        /* scan forward for '/' that marks end of hostport and begin. of dn */
        p = strchr( url, '/' );
+       q = NULL;
 
        if( p != NULL ) {
                /* terminate hostport; point to start of dn */
                *p++ = '\0';
+       } else {
+               /* check for Novell kludge, see below */
+               p = strchr( url, '?' );
+               if ( p ) {
+                       *p++ = '\0';
+                       q = p;
+                       p = NULL;
+               }
        }
 
-       if (( q = strchr( url, ':' )) != NULL ) {
-               *q++ = '\0';
-               ldap_pvt_hex_unescape( q );
+       if ( proto != LDAP_PROTO_IPC ) {
+               /* IPv6 syntax with [ip address]:port */
+               if ( *url == '[' ) {
+                       r = strchr( url, ']' );
+                       if ( r == NULL ) {
+                               LDAP_FREE( url );
+                               ldap_free_urldesc( ludp );
+                               return LDAP_URL_ERR_BADURL;
+                       }
+                       *r++ = '\0';
+                       q = strchr( r, ':' );
+                       if ( q && q != r ) {
+                               LDAP_FREE( url );
+                               ldap_free_urldesc( ludp );
+                               return LDAP_URL_ERR_BADURL;
+                       }
+                       is_v6 = 1;
+               } else {
+                       q = strchr( url, ':' );
+               }
 
-               if( *q == '\0' ) {
-                       LDAP_FREE( url );
-                       ldap_free_urldesc( ludp );
-                       return LDAP_URL_ERR_BADURL;
+               if ( q != NULL ) {
+                       char    *next;
+
+                       *q++ = '\0';
+                       ldap_pvt_hex_unescape( q );
+
+                       if( *q == '\0' ) {
+                               LDAP_FREE( url );
+                               ldap_free_urldesc( ludp );
+                               return LDAP_URL_ERR_BADURL;
+                       }
+
+                       ludp->lud_port = strtol( q, &next, 10 );
+                       if ( next == q || next[0] != '\0' ) {
+                               LDAP_FREE( url );
+                               ldap_free_urldesc( ludp );
+                               return LDAP_URL_ERR_BADURL;
+                       }
+                       /* check for Novell kludge */
+                       if ( !p ) {
+                               if ( *next != '\0' ) {
+                                       q = &next[1];
+                               } else {
+                                       q = NULL;
+                               }
+                       }
                }
 
-               ludp->lud_port = atoi( q );
+               if ( ( flags & LDAP_PVT_URL_PARSE_DEF_PORT ) && ludp->lud_port == 0 ) {
+                       if ( strcmp( ludp->lud_scheme, "ldaps" ) == 0 ) {
+                               ludp->lud_port = LDAPS_PORT;
+                       } else {
+                               ludp->lud_port = LDAP_PORT;
+                       }
+               }
        }
 
        ldap_pvt_hex_unescape( url );
-       ludp->lud_host = LDAP_STRDUP( url );
+
+       /* If [ip address]:port syntax, url is [ip and we skip the [ */
+       ludp->lud_host = LDAP_STRDUP( url + is_v6 );
 
        if( ludp->lud_host == NULL ) {
                LDAP_FREE( url );
@@ -310,6 +960,14 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
                return LDAP_URL_ERR_MEM;
        }
 
+       if ( ( flags & LDAP_PVT_URL_PARSE_NOEMPTY_HOST )
+               && ludp->lud_host != NULL
+               && *ludp->lud_host == '\0' )
+       {
+               LDAP_FREE( ludp->lud_host );
+               ludp->lud_host = NULL;
+       }
+
        /*
         * Kludge.  ldap://111.222.333.444:389??cn=abc,o=company
         *
@@ -319,24 +977,25 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
         * but we need to account for it. Fortunately it can't be confused with
         * anything real.
         */
-       if( (p == NULL) && ((q = strchr( q, '?')) != NULL)) {
-               q++;            
+       if( (p == NULL) && (q != NULL) && (*q == '?') ) {
                /* ? immediately followed by question */
-               if( *q == '?') {
-                       q++;
-                       if( *q != '\0' ) {
-                               /* parse dn part */
-                               ldap_pvt_hex_unescape( q );
-                               ludp->lud_dn = LDAP_STRDUP( q );
-                       } else {
-                               ludp->lud_dn = LDAP_STRDUP( "" );
-                       }
+               q++;
+               if( *q != '\0' ) {
+                       /* parse dn part */
+                       ldap_pvt_hex_unescape( q );
+                       ludp->lud_dn = LDAP_STRDUP( q );
 
-                       if( ludp->lud_dn == NULL ) {
-                               LDAP_FREE( url );
-                               ldap_free_urldesc( ludp );
-                               return LDAP_URL_ERR_MEM;
-                       }
+               } else if ( !( flags & LDAP_PVT_URL_PARSE_NOEMPTY_DN ) ) {
+                       ludp->lud_dn = LDAP_STRDUP( "" );
+
+               } else {
+                       check_dn = 0;
+               }
+
+               if ( check_dn && ludp->lud_dn == NULL ) {
+                       LDAP_FREE( url );
+                       ldap_free_urldesc( ludp );
+                       return LDAP_URL_ERR_MEM;
                }
        }
 
@@ -358,11 +1017,15 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
                /* parse dn part */
                ldap_pvt_hex_unescape( p );
                ludp->lud_dn = LDAP_STRDUP( p );
-       } else {
+
+       } else if ( !( flags & LDAP_PVT_URL_PARSE_NOEMPTY_DN ) ) {
                ludp->lud_dn = LDAP_STRDUP( "" );
+
+       } else {
+               check_dn = 0;
        }
 
-       if( ludp->lud_dn == NULL ) {
+       if( check_dn && ludp->lud_dn == NULL ) {
                LDAP_FREE( url );
                ldap_free_urldesc( ludp );
                return LDAP_URL_ERR_MEM;
@@ -415,7 +1078,7 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
        if( *p != '\0' ) {
                /* parse the scope */
                ldap_pvt_hex_unescape( p );
-               ludp->lud_scope = str2scope( p );
+               ludp->lud_scope = ldap_pvt_str2scope( p );
 
                if( ludp->lud_scope == -1 ) {
                        LDAP_FREE( url );
@@ -451,7 +1114,6 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
                        return LDAP_URL_ERR_BADFILTER;
                }
 
-               LDAP_FREE( ludp->lud_filter );
                ludp->lud_filter = LDAP_STRDUP( p );
 
                if( ludp->lud_filter == NULL ) {
@@ -490,11 +1152,15 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
 
        for( i=0; ludp->lud_exts[i] != NULL; i++ ) {
                ldap_pvt_hex_unescape( ludp->lud_exts[i] );
+
+               if( *ludp->lud_exts[i] == '!' ) {
+                       /* count the number of critical extensions */
+                       ludp->lud_crit_exts++;
+               }
        }
 
        if( i == 0 ) {
                /* must have 1 or more */
-               ldap_charray_free( ludp->lud_exts );
                LDAP_FREE( url );
                ldap_free_urldesc( ludp );
                return LDAP_URL_ERR_BADEXTS;
@@ -506,6 +1172,12 @@ ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
        return LDAP_URL_SUCCESS;
 }
 
+int
+ldap_url_parse( LDAP_CONST char *url_in, LDAPURLDesc **ludpp )
+{
+       return ldap_url_parse_ext( url_in, ludpp, LDAP_PVT_URL_PARSE_HISTORIC );
+}
+
 LDAPURLDesc *
 ldap_url_dup ( LDAPURLDesc *ludp )
 {
@@ -601,53 +1273,73 @@ ldap_url_duplist (LDAPURLDesc *ludlist)
        return dest;
 }
 
-int
-ldap_url_parselist (LDAPURLDesc **ludlist, const char *url )
+static int
+ldap_url_parselist_int (LDAPURLDesc **ludlist, const char *url, const char *sep, unsigned flags )
+       
 {
        int i, rc;
        LDAPURLDesc *ludp;
        char **urls;
 
+       assert( ludlist != NULL );
+       assert( url != NULL );
+
        *ludlist = NULL;
 
-       if (url == NULL)
-               return LDAP_PARAM_ERROR;
+       if ( sep == NULL ) {
+               sep = ", ";
+       }
 
-       urls = ldap_str2charray((char *)url, ", ");
+       urls = ldap_str2charray( url, sep );
        if (urls == NULL)
-               return LDAP_NO_MEMORY;
+               return LDAP_URL_ERR_MEM;
 
        /* count the URLs... */
        for (i = 0; urls[i] != NULL; i++) ;
        /* ...and put them in the "stack" backward */
        while (--i >= 0) {
-               rc = ldap_url_parse( urls[i], &ludp );
+               rc = ldap_url_parse_ext( urls[i], &ludp, flags );
                if ( rc != 0 ) {
-                       ldap_charray_free(urls);
-                       ldap_free_urllist(*ludlist);
+                       ldap_charray_free( urls );
+                       ldap_free_urllist( *ludlist );
                        *ludlist = NULL;
                        return rc;
                }
                ludp->lud_next = *ludlist;
                *ludlist = ludp;
        }
-       ldap_charray_free(urls);
-       return LDAP_SUCCESS;
+       ldap_charray_free( urls );
+       return LDAP_URL_SUCCESS;
+}
+
+int
+ldap_url_parselist (LDAPURLDesc **ludlist, const char *url )
+{
+       return ldap_url_parselist_int( ludlist, url, ", ", LDAP_PVT_URL_PARSE_HISTORIC );
 }
 
 int
-ldap_url_parsehosts (LDAPURLDesc **ludlist, const char *hosts )
+ldap_url_parselist_ext (LDAPURLDesc **ludlist, const char *url, const char *sep, unsigned flags )
+{
+       return ldap_url_parselist_int( ludlist, url, sep, flags );
+}
+
+int
+ldap_url_parsehosts(
+       LDAPURLDesc **ludlist,
+       const char *hosts,
+       int port )
 {
        int i;
        LDAPURLDesc *ludp;
        char **specs, *p;
 
-       *ludlist = NULL;
+       assert( ludlist != NULL );
+       assert( hosts != NULL );
 
-       if (hosts == NULL)
-               return LDAP_PARAM_ERROR;
+       *ludlist = NULL;
 
-       specs = ldap_str2charray((char *)hosts, ", ");
+       specs = ldap_str2charray(hosts, ", ");
        if (specs == NULL)
                return LDAP_NO_MEMORY;
 
@@ -663,13 +1355,50 @@ ldap_url_parsehosts (LDAPURLDesc **ludlist, const char *hosts )
                        *ludlist = NULL;
                        return LDAP_NO_MEMORY;
                }
+               ludp->lud_port = port;
                ludp->lud_host = specs[i];
                specs[i] = NULL;
                p = strchr(ludp->lud_host, ':');
                if (p != NULL) {
-                       *p++ = 0;
-                       ldap_pvt_hex_unescape(p);
-                       ludp->lud_port = atoi(p);
+                       /* more than one :, IPv6 address */
+                       if ( strchr(p+1, ':') != NULL ) {
+                               /* allow [address] and [address]:port */
+                               if ( *ludp->lud_host == '[' ) {
+                                       p = LDAP_STRDUP(ludp->lud_host+1);
+                                       /* copied, make sure we free source later */
+                                       specs[i] = ludp->lud_host;
+                                       ludp->lud_host = p;
+                                       p = strchr( ludp->lud_host, ']' );
+                                       if ( p == NULL ) {
+                                               LDAP_FREE(ludp);
+                                               ldap_charray_free(specs);
+                                               return LDAP_PARAM_ERROR;
+                                       }
+                                       *p++ = '\0';
+                                       if ( *p != ':' ) {
+                                               if ( *p != '\0' ) {
+                                                       LDAP_FREE(ludp);
+                                                       ldap_charray_free(specs);
+                                                       return LDAP_PARAM_ERROR;
+                                               }
+                                               p = NULL;
+                                       }
+                               } else {
+                                       p = NULL;
+                               }
+                       }
+                       if (p != NULL) {
+                               char    *next;
+
+                               *p++ = 0;
+                               ldap_pvt_hex_unescape(p);
+                               ludp->lud_port = strtol( p, &next, 10 );
+                               if ( next == p || next[0] != '\0' ) {
+                                       LDAP_FREE(ludp);
+                                       ldap_charray_free(specs);
+                                       return LDAP_PARAM_ERROR;
+                               }
+                       }
                }
                ldap_pvt_hex_unescape(ludp->lud_host);
                ludp->lud_scheme = LDAP_STRDUP("ldap");
@@ -678,6 +1407,7 @@ ldap_url_parsehosts (LDAPURLDesc **ludlist, const char *hosts )
        }
 
        /* this should be an array of NULLs now */
+       /* except entries starting with [ */
        ldap_charray_free(specs);
        return LDAP_SUCCESS;
 }
@@ -695,7 +1425,10 @@ ldap_url_list2hosts (LDAPURLDesc *ludlist)
        /* figure out how big the string is */
        size = 1;       /* nul-term */
        for (ludp = ludlist; ludp != NULL; ludp = ludp->lud_next) {
+               if ( ludp->lud_host == NULL ) continue;
                size += strlen(ludp->lud_host) + 1;             /* host and space */
+               if (strchr(ludp->lud_host, ':'))        /* will add [ ] below */
+                       size += 2;
                if (ludp->lud_port != 0)
                        size += sprintf(buf, ":%d", ludp->lud_port);
        }
@@ -705,15 +1438,20 @@ ldap_url_list2hosts (LDAPURLDesc *ludlist)
 
        p = s;
        for (ludp = ludlist; ludp != NULL; ludp = ludp->lud_next) {
-               strcpy(p, ludp->lud_host);
-               p += strlen(ludp->lud_host);
+               if ( ludp->lud_host == NULL ) continue;
+               if (strchr(ludp->lud_host, ':')) {
+                       p += sprintf(p, "[%s]", ludp->lud_host);
+               } else {
+                       strcpy(p, ludp->lud_host);
+                       p += strlen(ludp->lud_host);
+               }
                if (ludp->lud_port != 0)
                        p += sprintf(p, ":%d", ludp->lud_port);
                *p++ = ' ';
        }
        if (p != s)
                p--;    /* nuke that extra space */
-       *p = 0;
+       *p = '\0';
        return s;
 }
 
@@ -721,40 +1459,50 @@ char *
 ldap_url_list2urls(
        LDAPURLDesc *ludlist )
 {
-       LDAPURLDesc *ludp;
-       int size;
-       char *s, *p, buf[32];   /* big enough to hold a long decimal # (overkill) */
+       LDAPURLDesc     *ludp;
+       int             size, sofar;
+       char            *s;
 
-       if (ludlist == NULL)
+       if ( ludlist == NULL ) {
                return NULL;
+       }
 
        /* figure out how big the string is */
-       size = 1;       /* nul-term */
-       for (ludp = ludlist; ludp != NULL; ludp = ludp->lud_next) {
-               size += strlen(ludp->lud_scheme) + strlen(ludp->lud_host);
-               size += sizeof(":/// ");
-
-               if (ludp->lud_port != 0) {
-                       size += sprintf(buf, ":%d", ludp->lud_port);
+       for ( size = 0, ludp = ludlist; ludp != NULL; ludp = ludp->lud_next ) {
+               int     len = desc2str_len( ludp );
+               if ( len < 0 ) {
+                       return NULL;
                }
+               size += len + 1;
        }
+       
+       s = LDAP_MALLOC( size );
 
-       s = LDAP_MALLOC(size);
-       if (s == NULL) {
+       if ( s == NULL ) {
                return NULL;
        }
 
-       p = s;
-       for (ludp = ludlist; ludp != NULL; ludp = ludp->lud_next) {
-               p += sprintf(p, "%s://%s", ludp->lud_scheme, ludp->lud_host);
-               if (ludp->lud_port != 0)
-                       p += sprintf(p, ":%d", ludp->lud_port);
-               *p++ = '/';
-               *p++ = ' ';
+       for ( sofar = 0, ludp = ludlist; ludp != NULL; ludp = ludp->lud_next ) {
+               int     len;
+
+               len = desc2str( ludp, &s[sofar], size );
+               
+               if ( len < 0 ) {
+                       LDAP_FREE( s );
+                       return NULL;
+               }
+
+               sofar += len;
+               size -= len;
+
+               s[sofar++] = ' ';
+               size--;
+
+               assert( size >= 0 );
        }
-       if (p != s)
-               p--;    /* nuke that extra space */
-       *p = 0;
+
+       s[sofar - 1] = '\0';
+
        return s;
 }
 
@@ -803,102 +1551,67 @@ ldap_free_urldesc( LDAPURLDesc *ludp )
        LDAP_FREE( ludp );
 }
 
-
-
-int
-ldap_url_search( LDAP *ld, LDAP_CONST char *url, int attrsonly )
+static int
+ldap_int_is_hexpair( char *s )
 {
-       int             err;
-       LDAPURLDesc     *ludp;
-       BerElement      *ber;
-       LDAPreqinfo  bind;
+       int     i;
 
-       if ( ldap_url_parse( url, &ludp ) != 0 ) {
-               ld->ld_errno = LDAP_PARAM_ERROR;
-               return( -1 );
-       }
-
-       ber = ldap_build_search_req( ld, ludp->lud_dn, ludp->lud_scope,
-           ludp->lud_filter, ludp->lud_attrs, attrsonly, NULL, NULL,
-               -1, -1 );
-
-       if ( ber == NULL ) {
-               err = -1;
-       } else {
-               bind.ri_request = LDAP_REQ_SEARCH;
-               bind.ri_msgid = ld->ld_msgid;
-               bind.ri_url = (char *)url;
-               err = ldap_send_server_request(
-                                       ld, ber, ld->ld_msgid, NULL,
-                                       (ludp->lud_host != NULL || ludp->lud_port != 0)
-                                               ? ludp : NULL,
-                                       NULL, &bind );
-       }
-
-       ldap_free_urldesc( ludp );
-       return( err );
-}
-
-
-int
-ldap_url_search_st( LDAP *ld, LDAP_CONST char *url, int attrsonly,
-       struct timeval *timeout, LDAPMessage **res )
-{
-       int     msgid;
+       for ( i = 0; i < 2; i++ ) {
+               if ( s[i] >= '0' && s[i] <= '9' ) {
+                       continue;
+               }
 
-       if (( msgid = ldap_url_search( ld, url, attrsonly )) == -1 ) {
-               return( ld->ld_errno );
-       }
+               if ( s[i] >= 'A' && s[i] <= 'F' ) {
+                       continue;
+               }
 
-       if ( ldap_result( ld, msgid, 1, timeout, res ) == -1 ) {
-               return( ld->ld_errno );
-       }
+               if ( s[i] >= 'a' && s[i] <= 'f' ) {
+                       continue;
+               }
 
-       if ( ld->ld_errno == LDAP_TIMEOUT ) {
-               (void) ldap_abandon( ld, msgid );
-               ld->ld_errno = LDAP_TIMEOUT;
-               return( ld->ld_errno );
+               return 0;
        }
-
-       return( ldap_result2error( ld, *res, 0 ));
+       
+       return 1;       
 }
-
-
-int
-ldap_url_search_s(
-       LDAP *ld, LDAP_CONST char *url, int attrsonly, LDAPMessage **res )
+       
+static int
+ldap_int_unhex( int c )
 {
-       int     msgid;
-
-       if (( msgid = ldap_url_search( ld, url, attrsonly )) == -1 ) {
-               return( ld->ld_errno );
-       }
-
-       if ( ldap_result( ld, msgid, 1, (struct timeval *)NULL, res ) == -1 ) {
-               return( ld->ld_errno );
-       }
-
-       return( ldap_result2error( ld, *res, 0 ));
+       return( c >= '0' && c <= '9' ? c - '0'
+           : c >= 'A' && c <= 'F' ? c - 'A' + 10
+           : c - 'a' + 10 );
 }
 
-
 void
 ldap_pvt_hex_unescape( char *s )
 {
-/*
-* Remove URL hex escapes from s... done in place.  The basic concept for
-* this routine is borrowed from the WWW library HTUnEscape() routine.
-*/
-       char    *p;
+       /*
+        * Remove URL hex escapes from s... done in place.  The basic concept for
+        * this routine is borrowed from the WWW library HTUnEscape() routine.
+        */
+       char    *p,
+               *save_s = s;
 
        for ( p = s; *s != '\0'; ++s ) {
                if ( *s == '%' ) {
-                       if ( *++s != '\0' ) {
-                               *p = ldap_pvt_unhex( *s ) << 4;
+                       /*
+                        * FIXME: what if '%' is followed
+                        * by non-hexpair chars?
+                        */
+                       if ( !ldap_int_is_hexpair( s + 1 ) ) {
+                               p = save_s;
+                               break;
                        }
-                       if ( *++s != '\0' ) {
-                               *p++ += ldap_pvt_unhex( *s );
+
+                       if ( *++s == '\0' ) {
+                               break;
+                       }
+                       *p = ldap_int_unhex( *s ) << 4;
+                       if ( *++s == '\0' ) {
+                               break;
                        }
+                       *p++ += ldap_int_unhex( *s );
                } else {
                        *p++ = *s;
                }
@@ -907,11 +1620,3 @@ ldap_pvt_hex_unescape( char *s )
        *p = '\0';
 }
 
-
-int
-ldap_pvt_unhex( int c )
-{
-       return( c >= '0' && c <= '9' ? c - '0'
-           : c >= 'A' && c <= 'F' ? c - 'A' + 10
-           : c - 'a' + 10 );
-}