]> git.sur5r.net Git - openldap/blobdiff - libraries/liblmdb/mdb.c
MDB_VL32 mdb_page_get(): Set MDB_TXN_ERROR on failure.
[openldap] / libraries / liblmdb / mdb.c
index 17f5a861cf4cb50cff04b54a0a816f9f93b141c2..4a79ae13f05328870f0558063355beddfbce3665 100644 (file)
@@ -1352,6 +1352,21 @@ typedef struct MDB_xcursor {
        unsigned char mx_dbflag;
 } MDB_xcursor;
 
+       /** Check if there is an inited xcursor, so #XCURSOR_REFRESH() is proper */
+#define XCURSOR_INITED(mc) \
+       ((mc)->mc_xcursor && ((mc)->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED))
+
+       /** Update sub-page pointer, if any, in \b mc->mc_xcursor.  Needed
+        *      when the node which contains the sub-page may have moved.  Called
+        *      with \b mp = mc->mc_pg[mc->mc_top], \b ki = mc->mc_ki[mc->mc_top].
+        */
+#define XCURSOR_REFRESH(mc, mp, ki) do { \
+       MDB_page *xr_pg = (mp); \
+       MDB_node *xr_node = NODEPTR(xr_pg, ki); \
+       if ((xr_node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA) \
+               (mc)->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(xr_node); \
+} while (0)
+
        /** State of FreeDB old pages, stored in the MDB_env */
 typedef struct MDB_pgstate {
        pgno_t          *mf_pghead;     /**< Reclaimed freeDB pages, or NULL before use */
@@ -1799,7 +1814,7 @@ mdb_cursor_chk(MDB_cursor *mc)
        }
        if (mc->mc_ki[i] >= NUMKEYS(mc->mc_pg[i]))
                printf("ack!\n");
-       if (mc->mc_xcursor && (mc->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED)) {
+       if (XCURSOR_INITED(mc)) {
                node = NODEPTR(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
                if (((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA) &&
                        mc->mc_xcursor->mx_cursor.mc_pg[0] != NODEDATA(node)) {
@@ -2679,14 +2694,8 @@ done:
                        if (m2 == mc) continue;
                        if (m2->mc_pg[mc->mc_top] == mp) {
                                m2->mc_pg[mc->mc_top] = np;
-                               if ((mc->mc_db->md_flags & MDB_DUPSORT) &&
-                                       IS_LEAF(np) &&
-                                       (m2->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED))
-                               {
-                                       MDB_node *leaf = NODEPTR(np, m2->mc_ki[mc->mc_top]);
-                                       if ((leaf->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA)
-                                               m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
-                               }
+                               if (XCURSOR_INITED(m2) && IS_LEAF(np))
+                                       XCURSOR_REFRESH(m2, np, m2->mc_ki[mc->mc_top]);
                        }
                }
        }
@@ -5236,13 +5245,6 @@ mdb_env_setup_locks(MDB_env *env, MDB_name *fname, int mode, int *excl)
        env->me_wmutex->semnum = 1;
        env->me_rmutex->locked = &env->me_txns->mti_rlocked;
        env->me_wmutex->locked = &env->me_txns->mti_wlocked;
-#endif
-#ifdef MDB_VL32
-#ifdef _WIN32
-       env->me_rpmutex = CreateMutex(NULL, FALSE, NULL);
-#else
-       pthread_mutex_init(&env->me_rpmutex, NULL);
-#endif
 #endif
 
        return MDB_SUCCESS;
@@ -5290,6 +5292,21 @@ mdb_env_open(MDB_env *env, const char *path, unsigned int flags, mdb_mode_t mode
        if (rc)
                return rc;
 
+#ifdef MDB_VL32
+#ifdef _WIN32
+       env->me_rpmutex = CreateMutex(NULL, FALSE, NULL);
+       if (!env->me_rpmutex) {
+               rc = ErrCode();
+               goto leave;
+       }
+#else
+       rc = pthread_mutex_init(&env->me_rpmutex, NULL);
+       if (rc)
+               goto leave;
+#endif
+#endif
+       flags |= MDB_ENV_ACTIVE;        /* tell mdb_env_close0() to clean up */
+
        if (flags & MDB_RDONLY) {
                /* silently ignore WRITEMAP when we're only getting read access */
                flags &= ~MDB_WRITEMAP;
@@ -5298,8 +5315,13 @@ mdb_env_open(MDB_env *env, const char *path, unsigned int flags, mdb_mode_t mode
                          (env->me_dirty_list = calloc(MDB_IDL_UM_SIZE, sizeof(MDB_ID2)))))
                        rc = ENOMEM;
        }
+
+       env->me_flags = flags;
+       if (rc)
+               goto leave;
+
 #ifdef MDB_VL32
-       if (!rc) {
+       {
                env->me_rpages = malloc(MDB_ERPAGE_SIZE * sizeof(MDB_ID3));
                if (!env->me_rpages) {
                        rc = ENOMEM;
@@ -5309,9 +5331,6 @@ mdb_env_open(MDB_env *env, const char *path, unsigned int flags, mdb_mode_t mode
                env->me_rpcheck = MDB_ERPAGE_SIZE/2;
        }
 #endif
-       env->me_flags = flags |= MDB_ENV_ACTIVE;
-       if (rc)
-               goto leave;
 
        env->me_path = strdup(path);
        env->me_dbxs = calloc(env->me_maxdbs, sizeof(MDB_dbx));
@@ -5420,11 +5439,13 @@ mdb_env_close0(MDB_env *env, int excl)
 #ifdef MDB_VL32
        if (env->me_txn0 && env->me_txn0->mt_rpages)
                free(env->me_txn0->mt_rpages);
-       { unsigned int x;
-               for (x=1; x<=env->me_rpages[0].mid; x++)
-               munmap(env->me_rpages[x].mptr, env->me_rpages[x].mcnt * env->me_psize);
+       if (env->me_rpages) {
+               MDB_ID3L el = env->me_rpages;
+               unsigned int x;
+               for (x=1; x<=el[0].mid; x++)
+                       munmap(el[x].mptr, el[x].mcnt * env->me_psize);
+               free(el);
        }
-       free(env->me_rpages);
 #endif
        free(env->me_txn0);
        mdb_midl_free(env->me_free_pgs);
@@ -6129,8 +6150,10 @@ mapped:
        {
 #ifdef MDB_VL32
                int rc = mdb_rpage_get(txn, pgno, &p);
-               if (rc)
+               if (rc) {
+                       txn->mt_flags |= MDB_TXN_ERROR;
                        return rc;
+               }
 #else
                MDB_env *env = txn->mt_env;
                p = (MDB_page *)(env->me_map + env->me_psize * pgno);
@@ -7654,11 +7677,8 @@ new_sub:
                                if (m3->mc_ki[i] >= mc->mc_ki[i] && insert_key) {
                                        m3->mc_ki[i]++;
                                }
-                               if (m3->mc_xcursor && (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED)) {
-                                       MDB_node *n2 = NODEPTR(mp, m3->mc_ki[i]);
-                                       if ((n2->mn_flags & (F_SUBDATA|F_DUPDATA)) == F_DUPDATA)
-                                               m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(n2);
-                               }
+                               if (XCURSOR_INITED(m3))
+                                       XCURSOR_REFRESH(m3, mp, m3->mc_ki[i]);
                        }
                }
        }
@@ -7709,9 +7729,7 @@ put_sub:
                                                if (m2->mc_ki[i] == mc->mc_ki[i]) {
                                                        mdb_xcursor_init2(m2, mx, new_dupdata);
                                                } else if (!insert_key && m2->mc_ki[i] < nkeys) {
-                                                       MDB_node *n2 = NODEPTR(mp, m2->mc_ki[i]);
-                                                       if ((n2->mn_flags & (F_SUBDATA|F_DUPDATA)) == F_DUPDATA)
-                                                               m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(n2);
+                                                       XCURSOR_REFRESH(m2, mp, m2->mc_ki[i]);
                                                }
                                        }
                                }
@@ -7816,13 +7834,12 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
                                                if (m2 == mc || m2->mc_snum < mc->mc_snum) continue;
                                                if (!(m2->mc_flags & C_INITIALIZED)) continue;
                                                if (m2->mc_pg[mc->mc_top] == mp) {
-                                                       if (m2->mc_ki[mc->mc_top] == mc->mc_ki[mc->mc_top]) {
-                                                               m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
-                                                       } else {
-                                                               MDB_node *n2 = NODEPTR(mp, m2->mc_ki[mc->mc_top]);
-                                                               if (!(n2->mn_flags & F_SUBDATA))
-                                                                       m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(n2);
+                                                       MDB_node *n2 = leaf;
+                                                       if (m2->mc_ki[mc->mc_top] != mc->mc_ki[mc->mc_top]) {
+                                                               n2 = NODEPTR(mp, m2->mc_ki[mc->mc_top]);
+                                                               if (n2->mn_flags & F_SUBDATA) continue;
                                                        }
+                                                       m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(n2);
                                                }
                                        }
                                }
@@ -8662,12 +8679,8 @@ mdb_node_move(MDB_cursor *csrc, MDB_cursor *cdst, int fromleft)
                                        m3->mc_ki[csrc->mc_top] = cdst->mc_ki[cdst->mc_top];
                                        m3->mc_ki[csrc->mc_top-1]++;
                                }
-                               if (m3->mc_xcursor && (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED) &&
-                                       IS_LEAF(mps)) {
-                                       MDB_node *node = NODEPTR(m3->mc_pg[csrc->mc_top], m3->mc_ki[csrc->mc_top]);
-                                       if ((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA)
-                                               m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(node);
-                               }
+                               if (XCURSOR_INITED(m3) && IS_LEAF(mps))
+                                       XCURSOR_REFRESH(m3, m3->mc_pg[csrc->mc_top], m3->mc_ki[csrc->mc_top]);
                        }
                } else
                /* Adding on the right, bump others down */
@@ -8688,12 +8701,8 @@ mdb_node_move(MDB_cursor *csrc, MDB_cursor *cdst, int fromleft)
                                        } else {
                                                m3->mc_ki[csrc->mc_top]--;
                                        }
-                                       if (m3->mc_xcursor && (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED) &&
-                                               IS_LEAF(mps)) {
-                                               MDB_node *node = NODEPTR(m3->mc_pg[csrc->mc_top], m3->mc_ki[csrc->mc_top]);
-                                               if ((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA)
-                                                       m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(node);
-                                       }
+                                       if (XCURSOR_INITED(m3) && IS_LEAF(mps))
+                                               XCURSOR_REFRESH(m3, m3->mc_pg[csrc->mc_top], m3->mc_ki[csrc->mc_top]);
                                }
                        }
                }
@@ -8894,12 +8903,8 @@ mdb_page_merge(MDB_cursor *csrc, MDB_cursor *cdst)
                                m3->mc_ki[top-1] > csrc->mc_ki[top-1]) {
                                m3->mc_ki[top-1]--;
                        }
-                       if (m3->mc_xcursor && (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED) &&
-                               IS_LEAF(psrc)) {
-                               MDB_node *node = NODEPTR(m3->mc_pg[top], m3->mc_ki[top]);
-                               if ((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA)
-                                       m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(node);
-                       }
+                       if (XCURSOR_INITED(m3) && IS_LEAF(psrc))
+                               XCURSOR_REFRESH(m3, m3->mc_pg[top], m3->mc_ki[top]);
                }
        }
        {
@@ -9154,14 +9159,16 @@ mdb_cursor_del0(MDB_cursor *mc)
                        if (m3->mc_pg[mc->mc_top] == mp) {
                                if (m3->mc_ki[mc->mc_top] == ki) {
                                        m3->mc_flags |= C_DEL;
+                                       if (mc->mc_db->md_flags & MDB_DUPSORT) {
+                                               /* Sub-cursor referred into dataset which is gone */
+                                               m3->mc_xcursor->mx_cursor.mc_flags &= ~(C_INITIALIZED|C_EOF);
+                                       }
+                                       continue;
                                } else if (m3->mc_ki[mc->mc_top] > ki) {
                                        m3->mc_ki[mc->mc_top]--;
                                }
-                               if (m3->mc_xcursor && (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED)) {
-                                       MDB_node *node = NODEPTR(m3->mc_pg[mc->mc_top], m3->mc_ki[mc->mc_top]);
-                                       if ((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA)
-                                               m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(node);
-                               }
+                               if (XCURSOR_INITED(m3))
+                                       XCURSOR_REFRESH(m3, m3->mc_pg[mc->mc_top], m3->mc_ki[mc->mc_top]);
                        }
                }
        }
@@ -9198,9 +9205,15 @@ mdb_cursor_del0(MDB_cursor *mc)
                                        }
                                        if (mc->mc_db->md_flags & MDB_DUPSORT) {
                                                MDB_node *node = NODEPTR(m3->mc_pg[m3->mc_top], m3->mc_ki[m3->mc_top]);
-                                               if (node->mn_flags & F_DUPDATA) {
-                                                       mdb_xcursor_init1(m3, node);
-                                                       m3->mc_xcursor->mx_cursor.mc_flags |= C_DEL;
+                                               /* If this node is a fake page, it needs to be reinited
+                                                * because its data has moved. But just reset mc_pg[0]
+                                                * if the xcursor is already live.
+                                                */
+                                               if ((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA) {
+                                                       if (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED)
+                                                               m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(node);
+                                                       else
+                                                               mdb_xcursor_init1(m3, node);
                                                }
                                        }
                                }
@@ -9685,12 +9698,8 @@ mdb_page_split(MDB_cursor *mc, MDB_val *newkey, MDB_val *newdata, pgno_t newpgno
                                m3->mc_ki[ptop] >= mc->mc_ki[ptop]) {
                                m3->mc_ki[ptop]++;
                        }
-                       if (m3->mc_xcursor && (m3->mc_xcursor->mx_cursor.mc_flags & C_INITIALIZED) &&
-                               IS_LEAF(mp)) {
-                               MDB_node *node = NODEPTR(m3->mc_pg[mc->mc_top], m3->mc_ki[mc->mc_top]);
-                               if ((node->mn_flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA)
-                                       m3->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(node);
-                       }
+                       if (XCURSOR_INITED(m3) && IS_LEAF(mp))
+                               XCURSOR_REFRESH(m3, m3->mc_pg[mc->mc_top], m3->mc_ki[mc->mc_top]);
                }
        }
        DPRINTF(("mp left: %d, rp left: %d", SIZELEFT(mp), SIZELEFT(rp)));