]> git.sur5r.net Git - openldap/blobdiff - libraries/liblmdb/mdb.c
Support dynamic max MDB keysize.
[openldap] / libraries / liblmdb / mdb.c
index d1cd8643fc61eafdd1545ec9e71d14fe3f462536..ab7736004217377143f704f4f7e5c28c64b1308e 100644 (file)
 #endif
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <sys/param.h>
 #ifdef _WIN32
 #include <windows.h>
+/** getpid() returns int; MinGW defines pid_t but MinGW64 typedefs it
+ *  as int64 which is wrong. MSVC doesn't define it at all, so just
+ *  don't use it.
+ */
+#define MDB_PID_T      int
+#ifdef __GNUC__
+# include <sys/param.h>
 #else
+# define LITTLE_ENDIAN 1234
+# define BIG_ENDIAN    4321
+# define BYTE_ORDER    LITTLE_ENDIAN
+# ifndef SSIZE_MAX
+#  define SSIZE_MAX    INT_MAX
+# endif
+#endif
+#else
+#define MDB_PID_T      pid_t
+#include <sys/param.h>
 #include <sys/uio.h>
 #include <sys/mman.h>
 #ifdef HAVE_SYS_FILE_H
@@ -75,6 +91,7 @@
 #ifndef _WIN32
 #include <pthread.h>
 #ifdef MDB_USE_POSIX_SEM
+# define MDB_USE_HASH          1
 #include <semaphore.h>
 #endif
 #endif
  *     @{
  */
 #ifdef _WIN32
+#define MDB_USE_HASH   1
 #define MDB_PIDLOCK    0
 #define pthread_t      DWORD
 #define pthread_mutex_t        HANDLE
@@ -322,10 +340,13 @@ static txnid_t mdb_debug_start;
        (((mc)->mc_flags & C_SUB) ? -(int)(mc)->mc_dbi : (int)(mc)->mc_dbi)
 /** @} */
 
-       /** A default memory page size.
-        *      The actual size is platform-dependent, but we use this for
-        *      boot-strapping. We probably should not be using this any more.
-        *      The #GET_PAGESIZE() macro is used to get the actual size.
+       /**     @brief The maximum size of a database page.
+        *
+        *      This is 32k, since it must fit in #MDB_page.#mp_upper.
+        *
+        *      LMDB will use database pages < OS pages if needed.
+        *      That causes more I/O in write transactions: The OS must
+        *      know (read) the whole page before writing a partial page.
         *
         *      Note that we don't currently support Huge pages. On Linux,
         *      regular data files cannot use Huge pages, and in general
@@ -334,7 +355,7 @@ static txnid_t mdb_debug_start;
         *      pressure from other processes is high. So until OSs have
         *      actual paging support for Huge pages, they're not viable.
         */
-#define MDB_PAGESIZE    4096
+#define MAX_PAGESIZE    0x8000
 
        /** The minimum number of keys required in a database page.
         *      Setting this to a larger value will place a smaller bound on the
@@ -361,20 +382,25 @@ static txnid_t mdb_debug_start;
        /**     The version number for a database's lockfile format. */
 #define MDB_LOCK_VERSION        1
 
-       /**     @brief The maximum size of a key in the database.
-        *
-        *      The library rejects bigger keys, and cannot deal with records
-        *      with bigger keys stored by a library with bigger max keysize.
+       /**     @brief The max size of a key we can write, or 0 for dynamic max.
         *
-        *      We require that keys all fit onto a regular page. This limit
-        *      could be raised a bit further if needed; to something just
-        *      under #MDB_PAGESIZE / #MDB_MINKEYS.
+        *      Define this as 0 to compute the max from the page size.  511
+        *      is default for backwards compat: liblmdb <= 0.9.10 can break
+        *      when modifying a DB with keys/dupsort data bigger than its max.
         *
-        *      Note that data items in an #MDB_DUPSORT database are actually keys
-        *      of a subDB, so they're also limited to this size.
+        *      Data items in an #MDB_DUPSORT database are also limited to
+        *      this size, since they're actually keys of a sub-DB.  Keys and
+        *      #MDB_DUPSORT data items must fit on a node in a regular page.
         */
 #ifndef MDB_MAXKEYSIZE
 #define MDB_MAXKEYSIZE  511
+#endif
+
+       /**     The maximum size of a key we can write to the environment. */
+#if MDB_MAXKEYSIZE
+#define ENV_MAXKEY(env)        (MDB_MAXKEYSIZE)
+#else
+#define ENV_MAXKEY(env)        ((env)->me_maxkey)
 #endif
 
        /**     @brief The maximum size of a data item.
@@ -384,11 +410,15 @@ static txnid_t mdb_debug_start;
 #define MAXDATASIZE    0xffffffffUL
 
 #if MDB_DEBUG
+       /**     Key size which fits in a #DKBUF.
+        *      @ingroup debug
+        */
+#define DKBUF_MAXKEYSIZE ((MDB_MAXKEYSIZE) > 0 ? (MDB_MAXKEYSIZE) : 511)
        /**     A key buffer.
         *      @ingroup debug
         *      This is used for printing a hex dump of a key's contents.
         */
-#define DKBUF  char kbuf[(MDB_MAXKEYSIZE*2+1)]
+#define DKBUF  char kbuf[DKBUF_MAXKEYSIZE*2+1]
        /**     Display a key in hex.
         *      @ingroup debug
         *      Invoke a function to display a key in hex.
@@ -407,6 +437,9 @@ static txnid_t mdb_debug_start;
        /** Test if the flags \b f are set in a flag word \b w. */
 #define F_ISSET(w, f)   (((w) & (f)) == (f))
 
+       /** Round \b n up to an even number. */
+#define EVEN(n)                (((n) + 1U) & -2) /* sign-extending -2 to match n+1U */
+
        /**     Used for offsets within a single page.
         *      Since memory pages are typically 4 or 8KB in size, 12-13 bits,
         *      this is plenty.
@@ -492,7 +525,7 @@ typedef struct MDB_rxbody {
         */
        txnid_t         mrb_txnid;
        /** The process ID of the process owning this reader txn. */
-       pid_t           mrb_pid;
+       MDB_PID_T       mrb_pid;
        /** The thread ID of the thread owning this txn. */
        pthread_t       mrb_tid;
 } MDB_rxbody;
@@ -811,19 +844,18 @@ typedef struct MDB_meta {
        txnid_t         mm_txnid;                       /**< txnid that committed this page */
 } MDB_meta;
 
-       /** Buffer for a stack-allocated dirty page.
+       /** Buffer for a stack-allocated meta page.
         *      The members define size and alignment, and silence type
         *      aliasing warnings.  They are not used directly; that could
         *      mean incorrectly using several union members in parallel.
         */
-typedef union MDB_pagebuf {
-       char            mb_raw[MDB_PAGESIZE];
+typedef union MDB_metabuf {
        MDB_page        mb_page;
        struct {
                char            mm_pad[PAGEHDRSZ];
                MDB_meta        mm_meta;
        } mb_metabuf;
-} MDB_pagebuf;
+} MDB_metabuf;
 
        /** Auxiliary DB info.
         *      The information here is mostly static/read-only. There is
@@ -992,16 +1024,18 @@ struct MDB_env {
        /** Have liveness lock in reader table */
 #define        MDB_LIVE_READER 0x08000000U
        uint32_t        me_flags;               /**< @ref mdb_env */
-       unsigned int    me_psize;       /**< size of a page, from #GET_PAGESIZE */
+       unsigned int    me_psize;       /**< DB page size, inited from me_os_psize */
+       unsigned int    me_os_psize;    /**< OS page size, from #GET_PAGESIZE */
        unsigned int    me_maxreaders;  /**< size of the reader table */
        unsigned int    me_numreaders;  /**< max numreaders set by this env */
        MDB_dbi         me_numdbs;              /**< number of DBs opened */
        MDB_dbi         me_maxdbs;              /**< size of the DB table */
-       pid_t           me_pid;         /**< process ID of this env */
+       MDB_PID_T       me_pid;         /**< process ID of this env */
        char            *me_path;               /**< path to the DB files */
        char            *me_map;                /**< the memory map of the data file */
        MDB_txninfo     *me_txns;               /**< the memory map of the lock file or NULL */
        MDB_meta        *me_metas[2];   /**< pointers to the two meta pages */
+       void            *me_pbuf;               /**< scratch area for DUPSORT put() */
        MDB_txn         *me_txn;                /**< current write transaction */
        size_t          me_mapsize;             /**< size of the data memory map */
        off_t           me_size;                /**< current file size */
@@ -1021,6 +1055,9 @@ struct MDB_env {
        int                     me_maxfree_1pg;
        /** Max size of a node on a page */
        unsigned int    me_nodemax;
+#if !(MDB_MAXKEYSIZE)
+       unsigned int    me_maxkey;      /**< max size of a key */
+#endif
 #ifdef _WIN32
        int             me_pidquery;            /**< Used in OpenProcess */
        HANDLE          me_rmutex;              /* Windows mutexes don't reside in shared mem */
@@ -1180,7 +1217,7 @@ mdb_dkey(MDB_val *key, char *buf)
        if (!key)
                return "";
 
-       if (key->mv_size > MDB_MAXKEYSIZE)
+       if (key->mv_size > DKBUF_MAXKEYSIZE)
                return "MDB_MAXKEYSIZE";
        /* may want to make this a dynamic check: if the key is mostly
         * printable characters, print it as-is instead of converting to hex.
@@ -1200,7 +1237,7 @@ void
 mdb_page_list(MDB_page *mp)
 {
        MDB_node *node;
-       unsigned int i, nkeys, nsize;
+       unsigned int i, nkeys, nsize, total = 0;
        MDB_val key;
        DKBUF;
 
@@ -1210,18 +1247,23 @@ mdb_page_list(MDB_page *mp)
                node = NODEPTR(mp, i);
                key.mv_size = node->mn_ksize;
                key.mv_data = node->mn_data;
-               nsize = NODESIZE + NODEKSZ(node) + sizeof(indx_t);
+               nsize = NODESIZE + key.mv_size;
                if (IS_BRANCH(mp)) {
                        fprintf(stderr, "key %d: page %"Z"u, %s\n", i, NODEPGNO(node),
                                DKEY(&key));
+                       total += nsize;
                } else {
                        if (F_ISSET(node->mn_flags, F_BIGDATA))
                                nsize += sizeof(pgno_t);
                        else
                                nsize += NODEDSZ(node);
+                       total += nsize;
+                       nsize += sizeof(indx_t);
                        fprintf(stderr, "key %d: nsize %d, %s\n", i, nsize, DKEY(&key));
                }
+               total = EVEN(total);
        }
+       fprintf(stderr, "Total: %d\n", total);
 }
 
 void
@@ -1316,7 +1358,12 @@ mdb_page_malloc(MDB_txn *txn, unsigned num)
 {
        MDB_env *env = txn->mt_env;
        MDB_page *ret = env->me_dpages;
-       size_t sz = env->me_psize;
+       size_t psize = env->me_psize, sz = psize, off;
+       /* For ! #MDB_NOMEMINIT, psize counts how much to init.
+        * For a single page alloc, we init everything after the page header.
+        * For multi-page, we init the final page; if the caller needed that
+        * many pages they will be filling in at least up to the last page.
+        */
        if (num == 1) {
                if (ret) {
                        VGMEMP_ALLOC(env, ret, sz);
@@ -1324,10 +1371,16 @@ mdb_page_malloc(MDB_txn *txn, unsigned num)
                        env->me_dpages = ret->mp_next;
                        return ret;
                }
+               psize -= off = PAGEHDRSZ;
        } else {
                sz *= num;
+               off = sz - psize;
        }
        if ((ret = malloc(sz)) != NULL) {
+               if (!(env->me_flags & MDB_NOMEMINIT)) {
+                       memset((char *)ret + off, 0, psize);
+                       ret->mp_pad = 0;
+               }
                VGMEMP_ALLOC(env, ret, sz);
        }
        return ret;
@@ -1636,11 +1689,11 @@ mdb_page_alloc(MDB_cursor *mc, int num, MDB_page **mp)
 #else
        enum { Paranoid = 0, Max_retries = INT_MAX /*infinite*/ };
 #endif
-       int rc, n2 = num-1, retry = Max_retries;
+       int rc, retry = Max_retries;
        MDB_txn *txn = mc->mc_txn;
        MDB_env *env = txn->mt_env;
        pgno_t pgno, *mop = env->me_pghead;
-       unsigned i, j, k, mop_len = mop ? mop[0] : 0;
+       unsigned i, j, k, mop_len = mop ? mop[0] : 0, n2 = num-1;
        MDB_page *np;
        txnid_t oldest = 0, last;
        MDB_cursor_op op;
@@ -1660,13 +1713,13 @@ mdb_page_alloc(MDB_cursor *mc, int num, MDB_page **mp)
                /* Seek a big enough contiguous page range. Prefer
                 * pages at the tail, just truncating the list.
                 */
-               if (mop_len >= (unsigned)num) {
+               if (mop_len > n2) {
                        i = mop_len;
                        do {
                                pgno = mop[i];
                                if (mop[i-n2] == pgno+n2)
                                        goto search_done;
-                       } while (--i >= (unsigned)num);
+                       } while (--i > n2);
                        if (Max_retries < INT_MAX && --retry < 0)
                                break;
                }
@@ -2076,7 +2129,7 @@ enum Pidlock_op {
  * lock on the lockfile, set at an offset equal to the pid.
  */
 static int
-mdb_reader_pid(MDB_env *env, enum Pidlock_op op, pid_t pid)
+mdb_reader_pid(MDB_env *env, enum Pidlock_op op, MDB_PID_T pid)
 {
 #if !(MDB_PIDLOCK)             /* Currently the same as defined(_WIN32) */
        int ret = 0;
@@ -2141,7 +2194,7 @@ mdb_txn_renew0(MDB_txn *txn)
                                if (r->mr_pid != env->me_pid || r->mr_txnid != (txnid_t)-1)
                                        return MDB_BAD_RSLOT;
                        } else {
-                               pid_t pid = env->me_pid;
+                               MDB_PID_T pid = env->me_pid;
                                pthread_t tid = pthread_self();
 
                                if (!(env->me_flags & MDB_LIVE_READER)) {
@@ -2480,7 +2533,7 @@ mdb_freelist_save(MDB_txn *txn)
        int rc, maxfree_1pg = env->me_maxfree_1pg, more = 1;
        txnid_t pglast = 0, head_id = 0;
        pgno_t  freecnt = 0, *free_pgs, *mop;
-       ssize_t head_room = 0, total_room = 0, mop_len;
+       ssize_t head_room = 0, total_room = 0, mop_len, clean_limit;
 
        mdb_cursor_init(&mc, txn, FREE_DBI, NULL);
 
@@ -2491,9 +2544,15 @@ mdb_freelist_save(MDB_txn *txn)
                        return rc;
        }
 
+       /* MDB_RESERVE cancels meminit in ovpage malloc (when no WRITEMAP) */
+       clean_limit = (env->me_flags & (MDB_NOMEMINIT|MDB_WRITEMAP))
+               ? SSIZE_MAX : maxfree_1pg;
+
        for (;;) {
                /* Come back here after each Put() in case freelist changed */
                MDB_val key, data;
+               pgno_t *pgs;
+               ssize_t j;
 
                /* If using records from freeDB which we have not yet
                 * deleted, delete them and any we reserved for me_pghead.
@@ -2577,7 +2636,12 @@ mdb_freelist_save(MDB_txn *txn)
                rc = mdb_cursor_put(&mc, &key, &data, MDB_RESERVE);
                if (rc)
                        return rc;
-               *(MDB_ID *)data.mv_data = 0; /* IDL is initially empty */
+               /* IDL is initially empty, zero out at least the length */
+               pgs = (pgno_t *)data.mv_data;
+               j = head_room > clean_limit ? head_room : 0;
+               do {
+                       pgs[j] = 0;
+               } while (--j >= 0);
                total_room += head_room;
        }
 
@@ -2968,10 +3032,11 @@ fail:
 static int
 mdb_env_read_header(MDB_env *env, MDB_meta *meta)
 {
-       MDB_pagebuf     pbuf;
+       MDB_metabuf     pbuf;
        MDB_page        *p;
        MDB_meta        *m;
        int                     i, rc, off;
+       enum { Size = sizeof(pbuf) };
 
        /* We don't know the page size yet, so use a minimum value.
         * Read both meta pages so we can use the latest one.
@@ -2983,13 +3048,13 @@ mdb_env_read_header(MDB_env *env, MDB_meta *meta)
                OVERLAPPED ov;
                memset(&ov, 0, sizeof(ov));
                ov.Offset = off;
-               rc = ReadFile(env->me_fd,&pbuf,MDB_PAGESIZE,&len,&ov) ? (int)len : -1;
+               rc = ReadFile(env->me_fd, &pbuf, Size, &len, &ov) ? (int)len : -1;
                if (rc == -1 && ErrCode() == ERROR_HANDLE_EOF)
                        rc = 0;
 #else
-               rc = pread(env->me_fd, &pbuf, MDB_PAGESIZE, off);
+               rc = pread(env->me_fd, &pbuf, Size, off);
 #endif
-               if (rc != MDB_PAGESIZE) {
+               if (rc != Size) {
                        if (rc == 0 && off == 0)
                                return ENOENT;
                        rc = rc < 0 ? (int) ErrCode() : MDB_INVALID;
@@ -3120,11 +3185,18 @@ mdb_env_write_meta(MDB_txn *txn)
                mp->mm_last_pg = txn->mt_next_pgno - 1;
                mp->mm_txnid = txn->mt_txnid;
                if (!(env->me_flags & (MDB_NOMETASYNC|MDB_NOSYNC))) {
+                       unsigned meta_size = env->me_psize;
                        rc = (env->me_flags & MDB_MAPASYNC) ? MS_ASYNC : MS_SYNC;
                        ptr = env->me_map;
-                       if (toggle)
-                               ptr += env->me_psize;
-                       if (MDB_MSYNC(ptr, env->me_psize, rc)) {
+                       if (toggle) {
+#ifndef _WIN32 /* POSIX msync() requires ptr = start of OS page */
+                               if (meta_size < env->me_os_psize)
+                                       meta_size += meta_size;
+                               else
+#endif
+                                       ptr += meta_size;
+                       }
+                       if (MDB_MSYNC(ptr, meta_size, rc)) {
                                rc = ErrCode();
                                goto fail;
                        }
@@ -3230,6 +3302,7 @@ mdb_env_create(MDB_env **env)
        e->me_wmutex = SEM_FAILED;
 #endif
        e->me_pid = getpid();
+       GET_PAGESIZE(e->me_os_psize);
        VGMEMP_CREATE(e,0,0);
        *env = e;
        return MDB_SUCCESS;
@@ -3272,7 +3345,7 @@ mdb_env_map(MDB_env *env, void *addr, int newsize)
        int prot = PROT_READ;
        if (flags & MDB_WRITEMAP) {
                prot |= PROT_WRITE;
-               if (newsize && ftruncate(env->me_fd, env->me_mapsize) < 0)
+               if (ftruncate(env->me_fd, env->me_mapsize) < 0)
                        return ErrCode();
        }
        env->me_map = mmap(addr, env->me_mapsize, prot, MAP_SHARED,
@@ -3281,14 +3354,17 @@ mdb_env_map(MDB_env *env, void *addr, int newsize)
                env->me_map = NULL;
                return ErrCode();
        }
-       /* Turn off readahead. It's harmful when the DB is larger than RAM. */
+
+       if (flags & MDB_NORDAHEAD) {
+               /* Turn off readahead. It's harmful when the DB is larger than RAM. */
 #ifdef MADV_RANDOM
-       madvise(env->me_map, env->me_mapsize, MADV_RANDOM);
+               madvise(env->me_map, env->me_mapsize, MADV_RANDOM);
 #else
 #ifdef POSIX_MADV_RANDOM
-       posix_madvise(env->me_map, env->me_mapsize, POSIX_MADV_RANDOM);
+               posix_madvise(env->me_map, env->me_mapsize, POSIX_MADV_RANDOM);
 #endif /* POSIX_MADV_RANDOM */
 #endif /* MADV_RANDOM */
+       }
 #endif /* _WIN32 */
 
        /* Can happen because the address argument to mmap() is just a
@@ -3319,6 +3395,14 @@ mdb_env_set_mapsize(MDB_env *env, size_t size)
                        return EINVAL;
                if (!size)
                        size = env->me_metas[mdb_env_pick_meta(env)]->mm_mapsize;
+               else if (size < env->me_mapsize) {
+                       /* If the configured size is smaller, make sure it's
+                        * still big enough. Silently round up to minimum if not.
+                        */
+                       size_t minsize = (env->me_metas[mdb_env_pick_meta(env)]->mm_last_pg + 1) * env->me_psize;
+                       if (size < minsize)
+                               size = minsize;
+               }
                munmap(env->me_map, env->me_mapsize);
                env->me_mapsize = size;
                old = (env->me_flags & MDB_FIXEDMAP) ? env->me_map : NULL;
@@ -3384,7 +3468,9 @@ mdb_env_open2(MDB_env *env)
                        return i;
                DPUTS("new mdbenv");
                newenv = 1;
-               GET_PAGESIZE(env->me_psize);
+               env->me_psize = env->me_os_psize;
+               if (env->me_psize > MAX_PAGESIZE)
+                       env->me_psize = MAX_PAGESIZE;
        } else {
                env->me_psize = meta.mm_psize;
        }
@@ -3416,10 +3502,15 @@ mdb_env_open2(MDB_env *env)
                        return i;
                }
        }
-       env->me_maxfree_1pg = (env->me_psize - PAGEHDRSZ) / sizeof(pgno_t) - 1;
-       env->me_nodemax = (env->me_psize - PAGEHDRSZ) / MDB_MINKEYS;
 
+       env->me_maxfree_1pg = (env->me_psize - PAGEHDRSZ) / sizeof(pgno_t) - 1;
+       env->me_nodemax = (((env->me_psize - PAGEHDRSZ) / MDB_MINKEYS) & -2)
+               - sizeof(indx_t);
+#if !(MDB_MAXKEYSIZE)
+       env->me_maxkey = env->me_nodemax - (NODESIZE + sizeof(MDB_db));
+#endif
        env->me_maxpg = env->me_mapsize / env->me_psize;
+
 #if MDB_DEBUG
        {
                int toggle = mdb_env_pick_meta(env);
@@ -3495,7 +3586,7 @@ PIMAGE_TLS_CALLBACK mdb_tls_cbp __attribute__((section (".CRT$XLB"))) = mdb_tls_
 #pragma comment(linker, "/INCLUDE:_tls_used")
 #pragma comment(linker, "/INCLUDE:mdb_tls_cbp")
 #pragma const_seg(".CRT$XLB")
-extern const PIMAGE_TLS_CALLBACK mdb_tls_callback;
+extern const PIMAGE_TLS_CALLBACK mdb_tls_cbp;
 const PIMAGE_TLS_CALLBACK mdb_tls_cbp = mdb_tls_callback;
 #pragma const_seg()
 #else  /* WIN32 */
@@ -3593,7 +3684,7 @@ mdb_env_excl_lock(MDB_env *env, int *excl)
        return rc;
 }
 
-#if defined(_WIN32) || defined(MDB_USE_POSIX_SEM)
+#ifdef MDB_USE_HASH
 /*
  * hash_64 - 64 bit Fowler/Noll/Vo-0 FNV-1a hash code
  *
@@ -3759,7 +3850,7 @@ mdb_env_setup_locks(MDB_env *env, char *lpath, int mode, int *excl)
        rsize = (env->me_maxreaders-1) * sizeof(MDB_reader) + sizeof(MDB_txninfo);
        if (size < rsize && *excl > 0) {
 #ifdef _WIN32
-               if (SetFilePointer(env->me_lfd, rsize, NULL, FILE_BEGIN) != rsize
+               if (SetFilePointer(env->me_lfd, rsize, NULL, FILE_BEGIN) != (DWORD)rsize
                        || !SetEndOfFile(env->me_lfd))
                        goto fail_errno;
 #else
@@ -3915,8 +4006,9 @@ fail:
         *      at runtime. Changing other flags requires closing the
         *      environment and re-opening it with the new flags.
         */
-#define        CHANGEABLE      (MDB_NOSYNC|MDB_NOMETASYNC|MDB_MAPASYNC)
-#define        CHANGELESS      (MDB_FIXEDMAP|MDB_NOSUBDIR|MDB_RDONLY|MDB_WRITEMAP|MDB_NOTLS|MDB_NOLOCK)
+#define        CHANGEABLE      (MDB_NOSYNC|MDB_NOMETASYNC|MDB_MAPASYNC|MDB_NOMEMINIT)
+#define        CHANGELESS      (MDB_FIXEDMAP|MDB_NOSUBDIR|MDB_RDONLY|MDB_WRITEMAP| \
+       MDB_NOTLS|MDB_NOLOCK|MDB_NORDAHEAD)
 
 int
 mdb_env_open(MDB_env *env, const char *path, unsigned int flags, mdb_mode_t mode)
@@ -4029,7 +4121,12 @@ mdb_env_open(MDB_env *env, const char *path, unsigned int flags, mdb_mode_t mode
                DPRINTF(("opened dbenv %p", (void *) env));
                if (excl > 0) {
                        rc = mdb_env_share_locks(env, &excl);
+                       if (rc)
+                               goto leave;
                }
+               if (!((flags & MDB_RDONLY) ||
+                         (env->me_pbuf = calloc(1, env->me_psize))))
+                       rc = ENOMEM;
        }
 
 leave:
@@ -4053,6 +4150,7 @@ mdb_env_close0(MDB_env *env, int excl)
        for (i = env->me_maxdbs; --i > MAIN_DBI; )
                free(env->me_dbxs[i].md_name.mv_data);
 
+       free(env->me_pbuf);
        free(env->me_dbflags);
        free(env->me_dbxs);
        free(env->me_path);
@@ -4080,7 +4178,7 @@ mdb_env_close0(MDB_env *env, int excl)
        if (env->me_fd != INVALID_HANDLE_VALUE)
                (void) close(env->me_fd);
        if (env->me_txns) {
-               pid_t pid = env->me_pid;
+               MDB_PID_T pid = env->me_pid;
                /* Clearing readers is done in this function because
                 * me_txkey with its destructor must be disabled first.
                 */
@@ -4890,10 +4988,6 @@ mdb_get(MDB_txn *txn, MDB_dbi dbi,
        if (txn->mt_flags & MDB_TXN_ERROR)
                return MDB_BAD_TXN;
 
-       if (key->mv_size > MDB_MAXKEYSIZE) {
-               return MDB_BAD_VALSIZE;
-       }
-
        mdb_cursor_init(&mc, txn, dbi, &mx);
        return mdb_cursor_set(&mc, key, data, MDB_SET, &exact);
 }
@@ -5280,6 +5374,7 @@ set1:
                                if (op == MDB_GET_BOTH || rc > 0)
                                        return MDB_NOTFOUND;
                                rc = 0;
+                               *data = d2;
                        }
 
                } else {
@@ -5407,8 +5502,9 @@ mdb_cursor_get(MDB_cursor *mc, MDB_val *key, MDB_val *data,
                        rc = EINVAL;
                } else {
                        MDB_page *mp = mc->mc_pg[mc->mc_top];
-                       if (!NUMKEYS(mp)) {
-                               mc->mc_ki[mc->mc_top] = 0;
+                       int nkeys = NUMKEYS(mp);
+                       if (!nkeys || mc->mc_ki[mc->mc_top] >= nkeys) {
+                               mc->mc_ki[mc->mc_top] = nkeys;
                                rc = MDB_NOTFOUND;
                                break;
                        }
@@ -5447,12 +5543,10 @@ mdb_cursor_get(MDB_cursor *mc, MDB_val *key, MDB_val *data,
        case MDB_SET_RANGE:
                if (key == NULL) {
                        rc = EINVAL;
-               } else if (key->mv_size > MDB_MAXKEYSIZE) {
-                       rc = MDB_BAD_VALSIZE;
-               } else if (op == MDB_SET_RANGE)
-                       rc = mdb_cursor_set(mc, key, data, op, NULL);
-               else
-                       rc = mdb_cursor_set(mc, key, data, op, &exact);
+               } else {
+                       rc = mdb_cursor_set(mc, key, data, op,
+                               op == MDB_SET_RANGE ? NULL : &exact);
+               }
                break;
        case MDB_GET_MULTIPLE:
                if (data == NULL || !(mc->mc_flags & C_INITIALIZED)) {
@@ -5589,16 +5683,16 @@ mdb_cursor_put(MDB_cursor *mc, MDB_val *key, MDB_val *data,
     unsigned int flags)
 {
        enum { MDB_NO_ROOT = MDB_LAST_ERRCODE+10 }; /* internal code */
+       MDB_env         *env = mc->mc_txn->mt_env;
        MDB_node        *leaf = NULL;
-       MDB_val xdata, *rdata, dkey;
-       MDB_page        *fp;
+       MDB_page        *fp, *mp;
+       uint16_t        fp_flags;
+       MDB_val         xdata, *rdata, dkey, olddata;
        MDB_db dummy;
-       int do_sub = 0, insert = 0;
+       int do_sub = 0, insert;
        unsigned int mcount = 0, dcount = 0, nospill;
        size_t nsize;
        int rc, rc2;
-       MDB_pagebuf pbuf;
-       char dbuf[MDB_MAXKEYSIZE+1];
        unsigned int nflags;
        DKBUF;
 
@@ -5618,14 +5712,14 @@ mdb_cursor_put(MDB_cursor *mc, MDB_val *key, MDB_val *data,
        if (mc->mc_txn->mt_flags & (MDB_TXN_RDONLY|MDB_TXN_ERROR))
                return (mc->mc_txn->mt_flags & MDB_TXN_RDONLY) ? EACCES : MDB_BAD_TXN;
 
-       if (flags != MDB_CURRENT && (key->mv_size == 0 || key->mv_size > MDB_MAXKEYSIZE))
-               return MDB_BAD_VALSIZE;
-
-       if (F_ISSET(mc->mc_db->md_flags, MDB_DUPSORT) && data->mv_size > MDB_MAXKEYSIZE)
+       if (flags != MDB_CURRENT && key->mv_size-1 >= ENV_MAXKEY(env))
                return MDB_BAD_VALSIZE;
 
 #if SIZE_MAX > MAXDATASIZE
-       if (data->mv_size > MAXDATASIZE)
+       if (data->mv_size > ((mc->mc_db->md_flags & MDB_DUPSORT) ? ENV_MAXKEY(env) : MAXDATASIZE))
+               return MDB_BAD_VALSIZE;
+#else
+       if ((mc->mc_db->md_flags & MDB_DUPSORT) && data->mv_size > ENV_MAXKEY(env))
                return MDB_BAD_VALSIZE;
 #endif
 
@@ -5709,8 +5803,21 @@ mdb_cursor_put(MDB_cursor *mc, MDB_val *key, MDB_val *data,
                        return rc2;
        }
 
-       /* The key already exists */
-       if (rc == MDB_SUCCESS) {
+       insert = rc;
+       if (insert) {
+               /* The key does not exist */
+               DPRINTF(("inserting key at index %i", mc->mc_ki[mc->mc_top]));
+               if ((mc->mc_db->md_flags & MDB_DUPSORT) &&
+                       LEAFSIZE(key, data) > env->me_nodemax)
+               {
+                       /* Too big for a node, insert in sub-DB */
+                       fp_flags = P_LEAF|P_DIRTY;
+                       fp = env->me_pbuf;
+                       fp->mp_pad = data->mv_size; /* used if MDB_DUPFIXED */
+                       fp->mp_lower = fp->mp_upper = olddata.mv_size = PAGEHDRSZ;
+                       goto prep_subDB;
+               }
+       } else {
                /* there's only a key anyway, so this is a no-op */
                if (IS_LEAF2(mc->mc_pg[mc->mc_top])) {
                        unsigned int ksize = mc->mc_db->md_pad;
@@ -5723,21 +5830,30 @@ mdb_cursor_put(MDB_cursor *mc, MDB_val *key, MDB_val *data,
                        return MDB_SUCCESS;
                }
 
+more:
                leaf = NODEPTR(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
+               olddata.mv_size = NODEDSZ(leaf);
+               olddata.mv_data = NODEDATA(leaf);
 
                /* DB has dups? */
                if (F_ISSET(mc->mc_db->md_flags, MDB_DUPSORT)) {
+                       /* Prepare (sub-)page/sub-DB to accept the new item,
+                        * if needed.  fp: old sub-page or a header faking
+                        * it.  mp: new (sub-)page.  offset: growth in page
+                        * size.  xdata: node data with new page or DB.
+                        */
+                       unsigned        i, offset = 0;
+                       mp = fp = xdata.mv_data = env->me_pbuf;
+                       mp->mp_pgno = mc->mc_pg[mc->mc_top]->mp_pgno;
+
                        /* Was a single item before, must convert now */
-more:
                        if (!F_ISSET(leaf->mn_flags, F_DUPDATA)) {
                                /* Just overwrite the current item */
                                if (flags == MDB_CURRENT)
                                        goto current;
 
-                               dkey.mv_size = NODEDSZ(leaf);
-                               dkey.mv_data = NODEDATA(leaf);
 #if UINT_MAX < SIZE_MAX
-                               if (mc->mc_dbx->md_dcmp == mdb_cmp_int && dkey.mv_size == sizeof(size_t))
+                               if (mc->mc_dbx->md_dcmp == mdb_cmp_int && olddata.mv_size == sizeof(size_t))
 #ifdef MISALIGNED_OK
                                        mc->mc_dbx->md_dcmp = mdb_cmp_long;
 #else
@@ -5745,7 +5861,7 @@ more:
 #endif
 #endif
                                /* if data matches, skip it */
-                               if (!mc->mc_dbx->md_dcmp(data, &dkey)) {
+                               if (!mc->mc_dbx->md_dcmp(data, &olddata)) {
                                        if (flags & MDB_NODUPDATA)
                                                rc = MDB_KEYEXIST;
                                        else if (flags & MDB_MULTIPLE)
@@ -5755,118 +5871,111 @@ more:
                                        return rc;
                                }
 
-                               /* create a fake page for the dup items */
-                               memcpy(dbuf, dkey.mv_data, dkey.mv_size);
-                               dkey.mv_data = dbuf;
-                               fp = (MDB_page *)&pbuf;
-                               fp->mp_pgno = mc->mc_pg[mc->mc_top]->mp_pgno;
+                               /* Back up original data item */
+                               dkey.mv_size = olddata.mv_size;
+                               dkey.mv_data = memcpy(fp+1, olddata.mv_data, olddata.mv_size);
+
+                               /* Make sub-page header for the dup items, with dummy body */
                                fp->mp_flags = P_LEAF|P_DIRTY|P_SUBP;
                                fp->mp_lower = PAGEHDRSZ;
-                               fp->mp_upper = PAGEHDRSZ + dkey.mv_size + data->mv_size;
+                               xdata.mv_size = PAGEHDRSZ + dkey.mv_size + data->mv_size;
                                if (mc->mc_db->md_flags & MDB_DUPFIXED) {
                                        fp->mp_flags |= P_LEAF2;
                                        fp->mp_pad = data->mv_size;
-                                       fp->mp_upper += 2 * data->mv_size;      /* leave space for 2 more */
+                                       xdata.mv_size += 2 * data->mv_size;     /* leave space for 2 more */
                                } else {
-                                       fp->mp_upper += 2 * sizeof(indx_t) + 2 * NODESIZE +
+                                       xdata.mv_size += 2 * (sizeof(indx_t) + NODESIZE) +
                                                (dkey.mv_size & 1) + (data->mv_size & 1);
                                }
-                               mdb_node_del(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top], 0);
-                               do_sub = 1;
-                               rdata = &xdata;
-                               xdata.mv_size = fp->mp_upper;
-                               xdata.mv_data = fp;
-                               flags |= F_DUPDATA;
-                               goto new_sub;
-                       }
-                       if (!F_ISSET(leaf->mn_flags, F_SUBDATA)) {
-                               /* See if we need to convert from fake page to subDB */
-                               MDB_page *mp;
-                               unsigned int offset;
-                               unsigned int i;
-                               uint16_t fp_flags;
-
-                               fp = NODEDATA(leaf);
-                               if (flags == MDB_CURRENT) {
-reuse:
+                               fp->mp_upper = xdata.mv_size;
+                               olddata.mv_size = fp->mp_upper; /* pretend olddata is fp */
+                       } else if (leaf->mn_flags & F_SUBDATA) {
+                               /* Data is on sub-DB, just store it */
+                               flags |= F_DUPDATA|F_SUBDATA;
+                               goto put_sub;
+                       } else {
+                               /* Data is on sub-page */
+                               fp = olddata.mv_data;
+                               switch (flags) {
+                               default:
+                                       if (!(mc->mc_db->md_flags & MDB_DUPFIXED)) {
+                                               offset = EVEN(NODESIZE + sizeof(indx_t) +
+                                                       data->mv_size);
+                                               break;
+                                       }
+                                       offset = fp->mp_pad;
+                                       if (SIZELEFT(fp) < offset) {
+                                               offset *= 4; /* space for 4 more */
+                                               break;
+                                       }
+                                       /* FALLTHRU: Big enough MDB_DUPFIXED sub-page */
+                               case MDB_CURRENT:
                                        fp->mp_flags |= P_DIRTY;
-                                       COPY_PGNO(fp->mp_pgno, mc->mc_pg[mc->mc_top]->mp_pgno);
+                                       COPY_PGNO(fp->mp_pgno, mp->mp_pgno);
                                        mc->mc_xcursor->mx_cursor.mc_pg[0] = fp;
                                        flags |= F_DUPDATA;
                                        goto put_sub;
                                }
-                               if (mc->mc_db->md_flags & MDB_DUPFIXED) {
-                                       offset = fp->mp_pad;
-                                       if (SIZELEFT(fp) >= offset)
-                                               goto reuse;
-                                       offset *= 4;    /* space for 4 more */
-                               } else {
-                                       offset = NODESIZE + sizeof(indx_t) + data->mv_size;
-                               }
-                               offset += offset & 1;
-                               fp_flags = fp->mp_flags;
-                               if (NODESIZE + sizeof(indx_t) + NODEKSZ(leaf) + NODEDSZ(leaf) +
-                                       offset >= mc->mc_txn->mt_env->me_nodemax) {
-                                       /* yes, convert it */
-                                       dummy.md_flags = 0;
+                               xdata.mv_size = olddata.mv_size + offset;
+                       }
+
+                       fp_flags = fp->mp_flags;
+                       if (NODESIZE + NODEKSZ(leaf) + xdata.mv_size > env->me_nodemax) {
+                                       /* Too big for a sub-page, convert to sub-DB */
+                                       fp_flags &= ~P_SUBP;
+prep_subDB:
                                        if (mc->mc_db->md_flags & MDB_DUPFIXED) {
+                                               fp_flags |= P_LEAF2;
                                                dummy.md_pad = fp->mp_pad;
                                                dummy.md_flags = MDB_DUPFIXED;
                                                if (mc->mc_db->md_flags & MDB_INTEGERDUP)
                                                        dummy.md_flags |= MDB_INTEGERKEY;
+                                       } else {
+                                               dummy.md_pad = 0;
+                                               dummy.md_flags = 0;
                                        }
                                        dummy.md_depth = 1;
                                        dummy.md_branch_pages = 0;
                                        dummy.md_leaf_pages = 1;
                                        dummy.md_overflow_pages = 0;
                                        dummy.md_entries = NUMKEYS(fp);
-                                       rdata = &xdata;
                                        xdata.mv_size = sizeof(MDB_db);
                                        xdata.mv_data = &dummy;
                                        if ((rc = mdb_page_alloc(mc, 1, &mp)))
                                                return rc;
-                                       offset = mc->mc_txn->mt_env->me_psize - NODEDSZ(leaf);
+                                       offset = env->me_psize - olddata.mv_size;
                                        flags |= F_DUPDATA|F_SUBDATA;
                                        dummy.md_root = mp->mp_pgno;
-                                       fp_flags &= ~P_SUBP;
-                               } else {
-                                       /* no, just grow it */
-                                       rdata = &xdata;
-                                       xdata.mv_size = NODEDSZ(leaf) + offset;
-                                       xdata.mv_data = &pbuf;
-                                       mp = (MDB_page *)&pbuf;
-                                       mp->mp_pgno = mc->mc_pg[mc->mc_top]->mp_pgno;
-                                       flags |= F_DUPDATA;
-                               }
+                       }
+                       if (mp != fp) {
                                mp->mp_flags = fp_flags | P_DIRTY;
                                mp->mp_pad   = fp->mp_pad;
                                mp->mp_lower = fp->mp_lower;
                                mp->mp_upper = fp->mp_upper + offset;
-                               if (IS_LEAF2(fp)) {
+                               if (fp_flags & P_LEAF2) {
                                        memcpy(METADATA(mp), METADATA(fp), NUMKEYS(fp) * fp->mp_pad);
                                } else {
-                                       nsize = NODEDSZ(leaf) - fp->mp_upper;
-                                       memcpy((char *)mp + mp->mp_upper, (char *)fp + fp->mp_upper, nsize);
+                                       memcpy((char *)mp + mp->mp_upper, (char *)fp + fp->mp_upper,
+                                               olddata.mv_size - fp->mp_upper);
                                        for (i=0; i<NUMKEYS(fp); i++)
                                                mp->mp_ptrs[i] = fp->mp_ptrs[i] + offset;
                                }
-                               mdb_node_del(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top], 0);
-                               do_sub = 1;
-                               goto new_sub;
                        }
-                       /* data is on sub-DB, just store it */
-                       flags |= F_DUPDATA|F_SUBDATA;
-                       goto put_sub;
+
+                       rdata = &xdata;
+                       flags |= F_DUPDATA;
+                       do_sub = 1;
+                       mdb_node_del(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top], 0);
+                       goto new_sub;
                }
 current:
                /* overflow page overwrites need special handling */
                if (F_ISSET(leaf->mn_flags, F_BIGDATA)) {
                        MDB_page *omp;
                        pgno_t pg;
-                       unsigned psize = mc->mc_txn->mt_env->me_psize;
-                       int level, ovpages, dpages = OVPAGES(data->mv_size, psize);
+                       int level, ovpages, dpages = OVPAGES(data->mv_size, env->me_psize);
 
-                       memcpy(&pg, NODEDATA(leaf), sizeof(pg));
+                       memcpy(&pg, olddata.mv_data, sizeof(pg));
                        if ((rc2 = mdb_page_get(mc->mc_txn, pg, &omp, &level)) != 0)
                                return rc2;
                        ovpages = omp->mp_pages;
@@ -5874,7 +5983,7 @@ current:
                        /* Is the ov page large enough? */
                        if (ovpages >= dpages) {
                          if (!(omp->mp_flags & P_DIRTY) &&
-                                 (level || (mc->mc_txn->mt_env->me_flags & MDB_WRITEMAP)))
+                                 (level || (env->me_flags & MDB_WRITEMAP)))
                          {
                                rc = mdb_page_unspill(mc->mc_txn, omp, &omp);
                                if (rc)
@@ -5889,7 +5998,7 @@ current:
                                 */
                                if (level > 1) {
                                        /* It is writable only in a parent txn */
-                                       size_t sz = (size_t) psize * ovpages, off;
+                                       size_t sz = (size_t) env->me_psize * ovpages, off;
                                        MDB_page *np = mdb_page_malloc(mc->mc_txn, ovpages);
                                        MDB_ID2 id2;
                                        if (!np)
@@ -5919,31 +6028,28 @@ current:
                        }
                        if ((rc2 = mdb_ovpage_free(mc, omp)) != MDB_SUCCESS)
                                return rc2;
-               } else if (NODEDSZ(leaf) == data->mv_size) {
+               } else if (data->mv_size == olddata.mv_size) {
                        /* same size, just replace it. Note that we could
                         * also reuse this node if the new data is smaller,
                         * but instead we opt to shrink the node in that case.
                         */
                        if (F_ISSET(flags, MDB_RESERVE))
-                               data->mv_data = NODEDATA(leaf);
+                               data->mv_data = olddata.mv_data;
                        else if (data->mv_size)
-                               memcpy(NODEDATA(leaf), data->mv_data, data->mv_size);
+                               memcpy(olddata.mv_data, data->mv_data, data->mv_size);
                        else
                                memcpy(NODEKEY(leaf), key->mv_data, key->mv_size);
                        goto done;
                }
                mdb_node_del(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top], 0);
                mc->mc_db->md_entries--;
-       } else {
-               DPRINTF(("inserting key at index %i", mc->mc_ki[mc->mc_top]));
-               insert = 1;
        }
 
        rdata = data;
 
 new_sub:
        nflags = flags & NODE_ADD_FLAGS;
-       nsize = IS_LEAF2(mc->mc_pg[mc->mc_top]) ? key->mv_size : mdb_leaf_size(mc->mc_txn->mt_env, key, rdata);
+       nsize = IS_LEAF2(mc->mc_pg[mc->mc_top]) ? key->mv_size : mdb_leaf_size(env, key, rdata);
        if (SIZELEFT(mc->mc_pg[mc->mc_top]) < nsize) {
                if (( flags & (F_DUPDATA|F_SUBDATA)) == F_DUPDATA )
                        nflags &= ~MDB_APPEND;
@@ -6037,7 +6143,6 @@ next_mult:
                                data[1].mv_size = mcount;
                                if (mcount < dcount) {
                                        data[0].mv_data = (char *)data[0].mv_data + data[0].mv_size;
-                                       leaf = NODEPTR(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
                                        goto more;
                                }
                        }
@@ -6056,6 +6161,7 @@ int
 mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
 {
        MDB_node        *leaf;
+       MDB_page        *mp;
        int rc;
 
        if (mc->mc_txn->mt_flags & (MDB_TXN_RDONLY|MDB_TXN_ERROR))
@@ -6064,6 +6170,9 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
        if (!(mc->mc_flags & C_INITIALIZED))
                return EINVAL;
 
+       if (mc->mc_ki[mc->mc_top] >= NUMKEYS(mc->mc_pg[mc->mc_top]))
+               return MDB_NOTFOUND;
+
        if (!(flags & MDB_NOSPILL) && (rc = mdb_page_spill(mc, NULL, NULL)))
                return rc;
 
@@ -6071,9 +6180,10 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
        if (rc)
                return rc;
 
-       leaf = NODEPTR(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
+       mp = mc->mc_pg[mc->mc_top];
+       leaf = NODEPTR(mp, mc->mc_ki[mc->mc_top]);
 
-       if (!IS_LEAF2(mc->mc_pg[mc->mc_top]) && F_ISSET(leaf->mn_flags, F_DUPDATA)) {
+       if (!IS_LEAF2(mp) && F_ISSET(leaf->mn_flags, F_DUPDATA)) {
                if (!(flags & MDB_NODUPDATA)) {
                        if (!F_ISSET(leaf->mn_flags, F_SUBDATA)) {
                                mc->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
@@ -6088,13 +6198,13 @@ mdb_cursor_del(MDB_cursor *mc, unsigned int flags)
                                } else {
                                        MDB_cursor *m2;
                                        /* shrink fake page */
-                                       mdb_node_shrink(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
-                                       leaf = NODEPTR(mc->mc_pg[mc->mc_top], mc->mc_ki[mc->mc_top]);
+                                       mdb_node_shrink(mp, mc->mc_ki[mc->mc_top]);
+                                       leaf = NODEPTR(mp, mc->mc_ki[mc->mc_top]);
                                        mc->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
                                        /* fix other sub-DB cursors pointed at this fake page */
                                        for (m2 = mc->mc_txn->mt_cursors[mc->mc_dbi]; m2; m2=m2->mc_next) {
                                                if (m2 == mc || m2->mc_snum < mc->mc_snum) continue;
-                                               if (m2->mc_pg[mc->mc_top] == mc->mc_pg[mc->mc_top] &&
+                                               if (m2->mc_pg[mc->mc_top] == mp &&
                                                        m2->mc_ki[mc->mc_top] == mc->mc_ki[mc->mc_top])
                                                        m2->mc_xcursor->mx_cursor.mc_pg[0] = NODEDATA(leaf);
                                        }
@@ -6171,13 +6281,12 @@ mdb_leaf_size(MDB_env *env, MDB_val *key, MDB_val *data)
        size_t           sz;
 
        sz = LEAFSIZE(key, data);
-       if (sz >= env->me_nodemax) {
+       if (sz > env->me_nodemax) {
                /* put on overflow page */
                sz -= data->mv_size - sizeof(pgno_t);
        }
-       sz += sz & 1;
 
-       return sz + sizeof(indx_t);
+       return EVEN(sz + sizeof(indx_t));
 }
 
 /** Calculate the size of a branch node.
@@ -6196,7 +6305,7 @@ mdb_branch_size(MDB_env *env, MDB_val *key)
        size_t           sz;
 
        sz = INDXSIZE(key);
-       if (sz >= env->me_nodemax) {
+       if (sz > env->me_nodemax) {
                /* put on overflow page */
                /* not implemented */
                /* sz -= key->size - sizeof(pgno_t); */
@@ -6265,13 +6374,13 @@ mdb_node_add(MDB_cursor *mc, indx_t indx,
                if (F_ISSET(flags, F_BIGDATA)) {
                        /* Data already on overflow page. */
                        node_size += sizeof(pgno_t);
-               } else if (node_size + data->mv_size >= mc->mc_txn->mt_env->me_nodemax) {
+               } else if (node_size + data->mv_size > mc->mc_txn->mt_env->me_nodemax) {
                        int ovpages = OVPAGES(data->mv_size, mc->mc_txn->mt_env->me_psize);
                        int rc;
                        /* Put data on overflow page. */
                        DPRINTF(("data size is %"Z"u, node would be %"Z"u, put data on overflow page",
                            data->mv_size, node_size+data->mv_size));
-                       node_size += sizeof(pgno_t) + (node_size & 1);
+                       node_size = EVEN(node_size + sizeof(pgno_t));
                        if ((ssize_t)node_size > room)
                                goto full;
                        if ((rc = mdb_page_new(mc, P_OVERFLOW, ovpages, &ofp)))
@@ -6283,7 +6392,7 @@ mdb_node_add(MDB_cursor *mc, indx_t indx,
                        node_size += data->mv_size;
                }
        }
-       node_size += node_size & 1;
+       node_size = EVEN(node_size);
        if ((ssize_t)node_size > room)
                goto full;
 
@@ -6384,7 +6493,7 @@ mdb_node_del(MDB_page *mp, indx_t indx, int ksize)
                else
                        sz += NODEDSZ(node);
        }
-       sz += sz & 1;
+       sz = EVEN(sz);
 
        ptr = mp->mp_ptrs[indx];
        numkeys = NUMKEYS(mp);
@@ -6414,25 +6523,22 @@ mdb_node_shrink(MDB_page *mp, indx_t indx)
        MDB_node *node;
        MDB_page *sp, *xp;
        char *base;
-       int osize, nsize;
-       int delta;
+       int nsize, delta;
        indx_t           i, numkeys, ptr;
 
        node = NODEPTR(mp, indx);
        sp = (MDB_page *)NODEDATA(node);
-       osize = NODEDSZ(node);
-
-       delta = sp->mp_upper - sp->mp_lower;
-       SETDSZ(node, osize - delta);
+       delta = SIZELEFT(sp);
        xp = (MDB_page *)((char *)sp + delta);
 
        /* shift subpage upward */
        if (IS_LEAF2(sp)) {
                nsize = NUMKEYS(sp) * sp->mp_pad;
+               if (nsize & 1)
+                       return;         /* do not make the node uneven-sized */
                memmove(METADATA(xp), METADATA(sp), nsize);
        } else {
                int i;
-               nsize = osize - sp->mp_upper;
                numkeys = NUMKEYS(sp);
                for (i=numkeys-1; i>=0; i--)
                        xp->mp_ptrs[i] = sp->mp_ptrs[i] - delta;
@@ -6443,6 +6549,9 @@ mdb_node_shrink(MDB_page *mp, indx_t indx)
        xp->mp_pad = sp->mp_pad;
        COPY_PGNO(xp->mp_pgno, mp->mp_pgno);
 
+       nsize = NODEDSZ(node) - delta;
+       SETDSZ(node, nsize);
+
        /* shift lower nodes upward */
        ptr = mp->mp_ptrs[indx];
        numkeys = NUMKEYS(mp);
@@ -6678,7 +6787,7 @@ mdb_update_key(MDB_cursor *mc, MDB_val *key)
        MDB_node                *node;
        char                    *base;
        size_t                   len;
-       int                      delta, delta0;
+       int                              delta, ksize, oksize;
        indx_t                   ptr, i, numkeys, indx;
        DKBUF;
 
@@ -6689,7 +6798,7 @@ mdb_update_key(MDB_cursor *mc, MDB_val *key)
 #if MDB_DEBUG
        {
                MDB_val k2;
-               char kbuf2[(MDB_MAXKEYSIZE*2+1)];
+               char kbuf2[DKBUF_MAXKEYSIZE*2+1];
                k2.mv_data = NODEKEY(node);
                k2.mv_size = node->mn_ksize;
                DPRINTF(("update key %u (ofs %u) [%s] to [%s] on page %"Z"u",
@@ -6700,12 +6809,12 @@ mdb_update_key(MDB_cursor *mc, MDB_val *key)
        }
 #endif
 
-       delta0 = delta = key->mv_size - node->mn_ksize;
+       /* Sizes must be 2-byte aligned. */
+       ksize = EVEN(key->mv_size);
+       oksize = EVEN(node->mn_ksize);
+       delta = ksize - oksize;
 
-       /* Must be 2-byte aligned. If new key is
-        * shorter by 1, the shift will be skipped.
-        */
-       delta += (delta & 1);
+       /* Shift node contents if EVEN(key length) changed. */
        if (delta) {
                if (delta > 0 && SIZELEFT(mp) < delta) {
                        pgno_t pgno;
@@ -6731,7 +6840,7 @@ mdb_update_key(MDB_cursor *mc, MDB_val *key)
        }
 
        /* But even if no shift was needed, update ksize */
-       if (delta0)
+       if (node->mn_ksize != key->mv_size)
                node->mn_ksize = key->mv_size;
 
        if (key->mv_size)
@@ -6763,7 +6872,6 @@ mdb_node_move(MDB_cursor *csrc, MDB_cursor *cdst)
                return rc;
 
        if (IS_LEAF2(csrc->mc_pg[csrc->mc_top])) {
-               srcnode = NODEPTR(csrc->mc_pg[csrc->mc_top], 0);        /* fake */
                key.mv_size = csrc->mc_db->md_pad;
                key.mv_data = LEAF2KEY(csrc->mc_pg[csrc->mc_top], csrc->mc_ki[csrc->mc_top], key.mv_size);
                data.mv_size = 0;
@@ -6772,7 +6880,7 @@ mdb_node_move(MDB_cursor *csrc, MDB_cursor *cdst)
                flags = 0;
        } else {
                srcnode = NODEPTR(csrc->mc_pg[csrc->mc_top], csrc->mc_ki[csrc->mc_top]);
-               assert(!((long)srcnode&1));
+               assert(!((size_t)srcnode&1));
                srcpg = NODEPGNO(srcnode);
                flags = srcnode->mn_flags;
                if (csrc->mc_ki[csrc->mc_top] == 0 && IS_BRANCH(csrc->mc_pg[csrc->mc_top])) {
@@ -7111,6 +7219,7 @@ mdb_rebalance(MDB_cursor *mc)
                        /* Adjust cursors pointing to mp */
                        mc->mc_snum = 0;
                        mc->mc_top = 0;
+                       mc->mc_flags &= ~C_INITIALIZED;
                        {
                                MDB_cursor *m2, *m3;
                                MDB_dbi dbi = mc->mc_dbi;
@@ -7124,6 +7233,7 @@ mdb_rebalance(MDB_cursor *mc)
                                        if (m3->mc_pg[0] == mp) {
                                                m3->mc_snum = 0;
                                                m3->mc_top = 0;
+                                               m3->mc_flags &= ~C_INITIALIZED;
                                        }
                                }
                        }
@@ -7151,10 +7261,13 @@ mdb_rebalance(MDB_cursor *mc)
                                                m3 = m2;
                                        if (m3 == mc || m3->mc_snum < mc->mc_snum) continue;
                                        if (m3->mc_pg[0] == mp) {
-                                               m3->mc_pg[0] = mc->mc_pg[0];
-                                               m3->mc_snum = 1;
-                                               m3->mc_top = 0;
-                                               m3->mc_ki[0] = m3->mc_ki[1];
+                                               int i;
+                                               m3->mc_snum--;
+                                               m3->mc_top--;
+                                               for (i=0; i<m3->mc_snum; i++) {
+                                                       m3->mc_pg[i] = m3->mc_pg[i+1];
+                                                       m3->mc_ki[i] = m3->mc_ki[i+1];
+                                               }
                                        }
                                }
                        }
@@ -7267,7 +7380,7 @@ mdb_cursor_del0(MDB_cursor *mc, MDB_node *leaf)
 
                /* Adjust other cursors pointing to mp */
                for (m2 = mc->mc_txn->mt_cursors[dbi]; m2; m2=m2->mc_next) {
-                       if (m2 == mc)
+                       if (m2 == mc || m2->mc_snum < mc->mc_snum)
                                continue;
                        if (!(m2->mc_flags & C_INITIALIZED))
                                continue;
@@ -7308,10 +7421,6 @@ mdb_del(MDB_txn *txn, MDB_dbi dbi,
        if (txn->mt_flags & (MDB_TXN_RDONLY|MDB_TXN_ERROR))
                return (txn->mt_flags & MDB_TXN_RDONLY) ? EACCES : MDB_BAD_TXN;
 
-       if (key->mv_size > MDB_MAXKEYSIZE) {
-               return MDB_BAD_VALSIZE;
-       }
-
        mdb_cursor_init(&mc, txn, dbi, &mx);
 
        exact = 0;
@@ -7361,24 +7470,26 @@ mdb_page_split(MDB_cursor *mc, MDB_val *newkey, MDB_val *newdata, pgno_t newpgno
        unsigned int nflags)
 {
        unsigned int flags;
-       int              rc = MDB_SUCCESS, ins_new = 0, new_root = 0, newpos = 1, did_split = 0;
+       int              rc = MDB_SUCCESS, new_root = 0, did_split = 0;
        indx_t           newindx;
        pgno_t           pgno = 0;
-       unsigned int     i, j, split_indx, nkeys, pmax;
+       int      i, j, split_indx, nkeys, pmax;
+       MDB_env         *env = mc->mc_txn->mt_env;
        MDB_node        *node;
        MDB_val  sepkey, rkey, xdata, *rdata = &xdata;
-       MDB_page        *copy;
+       MDB_page        *copy = NULL;
        MDB_page        *mp, *rp, *pp;
-       unsigned int ptop;
+       int ptop;
        MDB_cursor      mn;
        DKBUF;
 
        mp = mc->mc_pg[mc->mc_top];
        newindx = mc->mc_ki[mc->mc_top];
+       nkeys = NUMKEYS(mp);
 
-       DPRINTF(("-----> splitting %s page %"Z"u and adding [%s] at index %i",
+       DPRINTF(("-----> splitting %s page %"Z"u and adding [%s] at index %i/%i",
            IS_LEAF(mp) ? "leaf" : "branch", mp->mp_pgno,
-           DKEY(newkey), mc->mc_ki[mc->mc_top]));
+           DKEY(newkey), mc->mc_ki[mc->mc_top], nkeys));
 
        /* Create a right sibling. */
        if ((rc = mdb_page_new(mc, mp->mp_flags, 1, &rp)))
@@ -7425,141 +7536,139 @@ mdb_page_split(MDB_cursor *mc, MDB_val *newkey, MDB_val *newdata, pgno_t newpgno
                sepkey = *newkey;
                split_indx = newindx;
                nkeys = 0;
-               goto newsep;
-       }
+       } else {
 
-       nkeys = NUMKEYS(mp);
-       split_indx = nkeys / 2;
-       if (newindx < split_indx)
-               newpos = 0;
-
-       if (IS_LEAF2(rp)) {
-               char *split, *ins;
-               int x;
-               unsigned int lsize, rsize, ksize;
-               /* Move half of the keys to the right sibling */
-               copy = NULL;
-               x = mc->mc_ki[mc->mc_top] - split_indx;
-               ksize = mc->mc_db->md_pad;
-               split = LEAF2KEY(mp, split_indx, ksize);
-               rsize = (nkeys - split_indx) * ksize;
-               lsize = (nkeys - split_indx) * sizeof(indx_t);
-               mp->mp_lower -= lsize;
-               rp->mp_lower += lsize;
-               mp->mp_upper += rsize - lsize;
-               rp->mp_upper -= rsize - lsize;
-               sepkey.mv_size = ksize;
-               if (newindx == split_indx) {
-                       sepkey.mv_data = newkey->mv_data;
-               } else {
-                       sepkey.mv_data = split;
-               }
-               if (x<0) {
-                       ins = LEAF2KEY(mp, mc->mc_ki[mc->mc_top], ksize);
-                       memcpy(rp->mp_ptrs, split, rsize);
-                       sepkey.mv_data = rp->mp_ptrs;
-                       memmove(ins+ksize, ins, (split_indx - mc->mc_ki[mc->mc_top]) * ksize);
-                       memcpy(ins, newkey->mv_data, ksize);
-                       mp->mp_lower += sizeof(indx_t);
-                       mp->mp_upper -= ksize - sizeof(indx_t);
+               split_indx = (nkeys+1) / 2;
+
+               if (IS_LEAF2(rp)) {
+                       char *split, *ins;
+                       int x;
+                       unsigned int lsize, rsize, ksize;
+                       /* Move half of the keys to the right sibling */
+                       copy = NULL;
+                       x = mc->mc_ki[mc->mc_top] - split_indx;
+                       ksize = mc->mc_db->md_pad;
+                       split = LEAF2KEY(mp, split_indx, ksize);
+                       rsize = (nkeys - split_indx) * ksize;
+                       lsize = (nkeys - split_indx) * sizeof(indx_t);
+                       mp->mp_lower -= lsize;
+                       rp->mp_lower += lsize;
+                       mp->mp_upper += rsize - lsize;
+                       rp->mp_upper -= rsize - lsize;
+                       sepkey.mv_size = ksize;
+                       if (newindx == split_indx) {
+                               sepkey.mv_data = newkey->mv_data;
+                       } else {
+                               sepkey.mv_data = split;
+                       }
+                       if (x<0) {
+                               ins = LEAF2KEY(mp, mc->mc_ki[mc->mc_top], ksize);
+                               memcpy(rp->mp_ptrs, split, rsize);
+                               sepkey.mv_data = rp->mp_ptrs;
+                               memmove(ins+ksize, ins, (split_indx - mc->mc_ki[mc->mc_top]) * ksize);
+                               memcpy(ins, newkey->mv_data, ksize);
+                               mp->mp_lower += sizeof(indx_t);
+                               mp->mp_upper -= ksize - sizeof(indx_t);
+                       } else {
+                               if (x)
+                                       memcpy(rp->mp_ptrs, split, x * ksize);
+                               ins = LEAF2KEY(rp, x, ksize);
+                               memcpy(ins, newkey->mv_data, ksize);
+                               memcpy(ins+ksize, split + x * ksize, rsize - x * ksize);
+                               rp->mp_lower += sizeof(indx_t);
+                               rp->mp_upper -= ksize - sizeof(indx_t);
+                               mc->mc_ki[mc->mc_top] = x;
+                               mc->mc_pg[mc->mc_top] = rp;
+                       }
                } else {
-                       if (x)
-                               memcpy(rp->mp_ptrs, split, x * ksize);
-                       ins = LEAF2KEY(rp, x, ksize);
-                       memcpy(ins, newkey->mv_data, ksize);
-                       memcpy(ins+ksize, split + x * ksize, rsize - x * ksize);
-                       rp->mp_lower += sizeof(indx_t);
-                       rp->mp_upper -= ksize - sizeof(indx_t);
-                       mc->mc_ki[mc->mc_top] = x;
-                       mc->mc_pg[mc->mc_top] = rp;
-               }
-               goto newsep;
-       }
+                       int psize, nsize, k;
+                       /* Maximum free space in an empty page */
+                       pmax = env->me_psize - PAGEHDRSZ;
+                       if (IS_LEAF(mp))
+                               nsize = mdb_leaf_size(env, newkey, newdata);
+                       else
+                               nsize = mdb_branch_size(env, newkey);
+                       nsize = EVEN(nsize);
 
-       /* For leaf pages, check the split point based on what
-        * fits where, since otherwise mdb_node_add can fail.
-        *
-        * This check is only needed when the data items are
-        * relatively large, such that being off by one will
-        * make the difference between success or failure.
-        *
-        * It's also relevant if a page happens to be laid out
-        * such that one half of its nodes are all "small" and
-        * the other half of its nodes are "large." If the new
-        * item is also "large" and falls on the half with
-        * "large" nodes, it also may not fit.
-        */
-       if (IS_LEAF(mp)) {
-               unsigned int psize, nsize;
-               /* Maximum free space in an empty page */
-               pmax = mc->mc_txn->mt_env->me_psize - PAGEHDRSZ;
-               nsize = mdb_leaf_size(mc->mc_txn->mt_env, newkey, newdata);
-               if ((nkeys < 20) || (nsize > pmax/16)) {
-                       if (newindx <= split_indx) {
-                               psize = nsize;
-                               newpos = 0;
-                               for (i=0; i<split_indx; i++) {
-                                       node = NODEPTR(mp, i);
-                                       psize += NODESIZE + NODEKSZ(node) + sizeof(indx_t);
-                                       if (F_ISSET(node->mn_flags, F_BIGDATA))
-                                               psize += sizeof(pgno_t);
-                                       else
-                                               psize += NODEDSZ(node);
-                                       psize += psize & 1;
-                                       if (psize > pmax) {
-                                               if (i <= newindx) {
-                                                       split_indx = newindx;
-                                                       if (i < newindx)
-                                                               newpos = 1;
+                       /* grab a page to hold a temporary copy */
+                       copy = mdb_page_malloc(mc->mc_txn, 1);
+                       if (copy == NULL)
+                               return ENOMEM;
+                       copy->mp_pgno  = mp->mp_pgno;
+                       copy->mp_flags = mp->mp_flags;
+                       copy->mp_lower = PAGEHDRSZ;
+                       copy->mp_upper = env->me_psize;
+
+                       /* prepare to insert */
+                       for (i=0, j=0; i<nkeys; i++) {
+                               if (i == newindx) {
+                                       copy->mp_ptrs[j++] = 0;
+                               }
+                               copy->mp_ptrs[j++] = mp->mp_ptrs[i];
+                       }
+
+                       /* When items are relatively large the split point needs
+                        * to be checked, because being off-by-one will make the
+                        * difference between success or failure in mdb_node_add.
+                        *
+                        * It's also relevant if a page happens to be laid out
+                        * such that one half of its nodes are all "small" and
+                        * the other half of its nodes are "large." If the new
+                        * item is also "large" and falls on the half with
+                        * "large" nodes, it also may not fit.
+                        *
+                        * As a final tweak, if the new item goes on the last
+                        * spot on the page (and thus, onto the new page), bias
+                        * the split so the new page is emptier than the old page.
+                        * This yields better packing during sequential inserts.
+                        */
+                       if (nkeys < 20 || nsize > pmax/16 || newindx >= nkeys) {
+                               /* Find split point */
+                               psize = 0;
+                               if (newindx <= split_indx || newindx >= nkeys) {
+                                       i = 0; j = 1;
+                                       k = newindx >= nkeys ? nkeys : split_indx+2;
+                               } else {
+                                       i = nkeys; j = -1;
+                                       k = split_indx-1;
+                               }
+                               for (; i!=k; i+=j) {
+                                       if (i == newindx) {
+                                               psize += nsize;
+                                               node = NULL;
+                                       } else {
+                                               node = (MDB_node *)((char *)mp + copy->mp_ptrs[i]);
+                                               psize += NODESIZE + NODEKSZ(node) + sizeof(indx_t);
+                                               if (IS_LEAF(mp)) {
+                                                       if (F_ISSET(node->mn_flags, F_BIGDATA))
+                                                               psize += sizeof(pgno_t);
+                                                       else
+                                                               psize += NODEDSZ(node);
                                                }
-                                               else
-                                                       split_indx = i;
-                                               break;
+                                               psize = EVEN(psize);
                                        }
-                               }
-                       } else {
-                               psize = nsize;
-                               for (i=nkeys-1; i>=split_indx; i--) {
-                                       node = NODEPTR(mp, i);
-                                       psize += NODESIZE + NODEKSZ(node) + sizeof(indx_t);
-                                       if (F_ISSET(node->mn_flags, F_BIGDATA))
-                                               psize += sizeof(pgno_t);
-                                       else
-                                               psize += NODEDSZ(node);
-                                       psize += psize & 1;
-                                       if (psize > pmax) {
-                                               if (i >= newindx) {
-                                                       split_indx = newindx;
-                                                       newpos = 0;
-                                               } else
-                                                       split_indx = i+1;
+                                       if (psize > pmax || i == k-j) {
+                                               split_indx = i + (j<0);
                                                break;
                                        }
                                }
                        }
+                       if (split_indx == newindx) {
+                               sepkey.mv_size = newkey->mv_size;
+                               sepkey.mv_data = newkey->mv_data;
+                       } else {
+                               node = (MDB_node *)((char *)mp + copy->mp_ptrs[split_indx]);
+                               sepkey.mv_size = node->mn_ksize;
+                               sepkey.mv_data = NODEKEY(node);
+                       }
                }
        }
 
-       /* First find the separating key between the split pages.
-        * The case where newindx == split_indx is ambiguous; the
-        * new item could go to the new page or stay on the original
-        * page. If newpos == 1 it goes to the new page.
-        */
-       if (newindx == split_indx && newpos) {
-               sepkey.mv_size = newkey->mv_size;
-               sepkey.mv_data = newkey->mv_data;
-       } else {
-               node = NODEPTR(mp, split_indx);
-               sepkey.mv_size = node->mn_ksize;
-               sepkey.mv_data = NODEKEY(node);
-       }
-
-newsep:
-       DPRINTF(("separator is [%s]", DKEY(&sepkey)));
+       DPRINTF(("separator is %d [%s]", split_indx, DKEY(&sepkey)));
 
        /* Copy separator key to the parent.
         */
-       if (SIZELEFT(mn.mc_pg[ptop]) < mdb_branch_size(mc->mc_txn->mt_env, &sepkey)) {
+       if (SIZELEFT(mn.mc_pg[ptop]) < mdb_branch_size(env, &sepkey)) {
                mn.mc_snum--;
                mn.mc_top--;
                did_split = 1;
@@ -7604,108 +7713,91 @@ newsep:
                        return rc;
                for (i=0; i<mc->mc_top; i++)
                        mc->mc_ki[i] = mn.mc_ki[i];
-               goto done;
-       }
-       if (IS_LEAF2(rp)) {
-               goto done;
-       }
-
-       /* Move half of the keys to the right sibling. */
+       } else if (!IS_LEAF2(mp)) {
+               /* Move nodes */
+               mc->mc_pg[mc->mc_top] = rp;
+               i = split_indx;
+               j = 0;
+               do {
+                       if (i == newindx) {
+                               rkey.mv_data = newkey->mv_data;
+                               rkey.mv_size = newkey->mv_size;
+                               if (IS_LEAF(mp)) {
+                                       rdata = newdata;
+                               } else
+                                       pgno = newpgno;
+                               flags = nflags;
+                               /* Update index for the new key. */
+                               mc->mc_ki[mc->mc_top] = j;
+                       } else {
+                               node = (MDB_node *)((char *)mp + copy->mp_ptrs[i]);
+                               rkey.mv_data = NODEKEY(node);
+                               rkey.mv_size = node->mn_ksize;
+                               if (IS_LEAF(mp)) {
+                                       xdata.mv_data = NODEDATA(node);
+                                       xdata.mv_size = NODEDSZ(node);
+                                       rdata = &xdata;
+                               } else
+                                       pgno = NODEPGNO(node);
+                               flags = node->mn_flags;
+                       }
 
-       /* grab a page to hold a temporary copy */
-       copy = mdb_page_malloc(mc->mc_txn, 1);
-       if (copy == NULL)
-               return ENOMEM;
+                       if (!IS_LEAF(mp) && j == 0) {
+                               /* First branch index doesn't need key data. */
+                               rkey.mv_size = 0;
+                       }
 
-       copy->mp_pgno  = mp->mp_pgno;
-       copy->mp_flags = mp->mp_flags;
-       copy->mp_lower = PAGEHDRSZ;
-       copy->mp_upper = mc->mc_txn->mt_env->me_psize;
-       mc->mc_pg[mc->mc_top] = copy;
-       for (i = j = 0; i <= nkeys; j++) {
-               if (i == split_indx) {
-               /* Insert in right sibling. */
-               /* Reset insert index for right sibling. */
-                       if (i != newindx || (newpos ^ ins_new)) {
+                       rc = mdb_node_add(mc, j, &rkey, rdata, pgno, flags);
+                       if (rc) {
+                               /* return tmp page to freelist */
+                               mdb_page_free(env, copy);
+                               return rc;
+                       }
+                       if (i == nkeys) {
+                               i = 0;
                                j = 0;
-                               mc->mc_pg[mc->mc_top] = rp;
+                               mc->mc_pg[mc->mc_top] = copy;
+                       } else {
+                               i++;
+                               j++;
+                       }
+               } while (i != split_indx);
+
+               nkeys = NUMKEYS(copy);
+               for (i=0; i<nkeys; i++)
+                       mp->mp_ptrs[i] = copy->mp_ptrs[i];
+               mp->mp_lower = copy->mp_lower;
+               mp->mp_upper = copy->mp_upper;
+               memcpy(NODEPTR(mp, nkeys-1), NODEPTR(copy, nkeys-1),
+                       env->me_psize - copy->mp_upper);
+
+               /* reset back to original page */
+               if (newindx < split_indx) {
+                       mc->mc_pg[mc->mc_top] = mp;
+                       if (nflags & MDB_RESERVE) {
+                               node = NODEPTR(mp, mc->mc_ki[mc->mc_top]);
+                               if (!(node->mn_flags & F_BIGDATA))
+                                       newdata->mv_data = NODEDATA(node);
                        }
-               }
-
-               if (i == newindx && !ins_new) {
-                       /* Insert the original entry that caused the split. */
-                       rkey.mv_data = newkey->mv_data;
-                       rkey.mv_size = newkey->mv_size;
-                       if (IS_LEAF(mp)) {
-                               rdata = newdata;
-                       } else
-                               pgno = newpgno;
-                       flags = nflags;
-
-                       ins_new = 1;
-
-                       /* Update index for the new key. */
-                       mc->mc_ki[mc->mc_top] = j;
-               } else if (i == nkeys) {
-                       break;
                } else {
-                       node = NODEPTR(mp, i);
-                       rkey.mv_data = NODEKEY(node);
-                       rkey.mv_size = node->mn_ksize;
-                       if (IS_LEAF(mp)) {
-                               xdata.mv_data = NODEDATA(node);
-                               xdata.mv_size = NODEDSZ(node);
-                               rdata = &xdata;
-                       } else
-                               pgno = NODEPGNO(node);
-                       flags = node->mn_flags;
-
-                       i++;
-               }
-
-               if (!IS_LEAF(mp) && j == 0) {
-                       /* First branch index doesn't need key data. */
-                       rkey.mv_size = 0;
-               }
-
-               rc = mdb_node_add(mc, j, &rkey, rdata, pgno, flags);
-               if (rc) break;
-       }
-
-       nkeys = NUMKEYS(copy);
-       for (i=0; i<nkeys; i++)
-               mp->mp_ptrs[i] = copy->mp_ptrs[i];
-       mp->mp_lower = copy->mp_lower;
-       mp->mp_upper = copy->mp_upper;
-       memcpy(NODEPTR(mp, nkeys-1), NODEPTR(copy, nkeys-1),
-               mc->mc_txn->mt_env->me_psize - copy->mp_upper);
-
-       /* reset back to original page */
-       if (newindx < split_indx || (!newpos && newindx == split_indx)) {
-               mc->mc_pg[mc->mc_top] = mp;
-               if (nflags & MDB_RESERVE) {
-                       node = NODEPTR(mp, mc->mc_ki[mc->mc_top]);
-                       if (!(node->mn_flags & F_BIGDATA))
-                               newdata->mv_data = NODEDATA(node);
-               }
-       } else {
-               mc->mc_ki[ptop]++;
-               /* Make sure mc_ki is still valid.
-                */
-               if (mn.mc_pg[ptop] != mc->mc_pg[ptop] &&
-                   mc->mc_ki[ptop] >= NUMKEYS(mc->mc_pg[ptop])) {
-                       for (i=0; i<ptop; i++) {
-                               mc->mc_pg[i] = mn.mc_pg[i];
-                               mc->mc_ki[i] = mn.mc_ki[i];
+                       mc->mc_pg[mc->mc_top] = rp;
+                       mc->mc_ki[ptop]++;
+                       /* Make sure mc_ki is still valid.
+                        */
+                       if (mn.mc_pg[ptop] != mc->mc_pg[ptop] &&
+                               mc->mc_ki[ptop] >= NUMKEYS(mc->mc_pg[ptop])) {
+                               for (i=0; i<ptop; i++) {
+                                       mc->mc_pg[i] = mn.mc_pg[i];
+                                       mc->mc_ki[i] = mn.mc_ki[i];
+                               }
+                               mc->mc_pg[ptop] = mn.mc_pg[ptop];
+                               mc->mc_ki[ptop] = mn.mc_ki[ptop] - 1;
                        }
-                       mc->mc_pg[ptop] = mn.mc_pg[ptop];
-                       mc->mc_ki[ptop] = mn.mc_ki[ptop] - 1;
                }
+               /* return tmp page to freelist */
+               mdb_page_free(env, copy);
        }
 
-       /* return tmp page to freelist */
-       mdb_page_free(mc->mc_txn->mt_env, copy);
-done:
        {
                /* Adjust other cursors pointing to mp */
                MDB_cursor *m2, *m3;
@@ -7753,6 +7845,7 @@ done:
                        }
                }
        }
+       DPRINTF(("mp left: %d, rp left: %d", SIZELEFT(mp), SIZELEFT(rp)));
        return rc;
 }
 
@@ -7808,6 +7901,16 @@ mdb_env_get_path(MDB_env *env, const char **arg)
        return MDB_SUCCESS;
 }
 
+int
+mdb_env_get_fd(MDB_env *env, mdb_filehandle_t *arg)
+{
+       if (!env || !arg)
+               return EINVAL;
+
+       *arg = env->me_fd;
+       return MDB_SUCCESS;
+}
+
 /** Common code for #mdb_stat() and #mdb_env_stat().
  * @param[in] env the environment to operate in.
  * @param[in] db the #MDB_db record containing the stats to return.
@@ -8188,7 +8291,7 @@ int mdb_set_relctx(MDB_txn *txn, MDB_dbi dbi, void *ctx)
 
 int mdb_env_get_maxkeysize(MDB_env *env)
 {
-       return MDB_MAXKEYSIZE;
+       return ENV_MAXKEY(env);
 }
 
 int mdb_reader_list(MDB_env *env, MDB_msg_func *func, void *ctx)
@@ -8233,7 +8336,7 @@ int mdb_reader_list(MDB_env *env, MDB_msg_func *func, void *ctx)
 /** Insert pid into list if not already present.
  * return -1 if already present.
  */
-static int mdb_pid_insert(pid_t *ids, pid_t pid)
+static int mdb_pid_insert(MDB_PID_T *ids, MDB_PID_T pid)
 {
        /* binary search of pid in list */
        unsigned base = 0;
@@ -8273,7 +8376,7 @@ int mdb_reader_check(MDB_env *env, int *dead)
 {
        unsigned int i, j, rdrs;
        MDB_reader *mr;
-       pid_t *pids, pid;
+       MDB_PID_T *pids, pid;
        int count = 0;
 
        if (!env)
@@ -8283,12 +8386,11 @@ int mdb_reader_check(MDB_env *env, int *dead)
        if (!env->me_txns)
                return MDB_SUCCESS;
        rdrs = env->me_txns->mti_numreaders;
-       pids = malloc((rdrs+1) * sizeof(pid_t));
+       pids = malloc((rdrs+1) * sizeof(MDB_PID_T));
        if (!pids)
                return ENOMEM;
        pids[0] = 0;
        mr = env->me_txns->mti_readers;
-       j = 0;
        for (i=0; i<rdrs; i++) {
                if (mr[i].mr_pid && mr[i].mr_pid != env->me_pid) {
                        pid = mr[i].mr_pid;