]> git.sur5r.net Git - groeck-nct6775/blobdiff - nct6775.c
Check for invalid temperature source
[groeck-nct6775] / nct6775.c
index 376caf6216151a516911ca7a470e774eb7806732..6e21ffbd34d5372538d07acbde5971b84fa572cd 100644 (file)
--- a/nct6775.c
+++ b/nct6775.c
@@ -54,6 +54,8 @@
 #include <linux/io.h>
 #include "lm75.h"
 
+#define TESTING
+
 enum kinds { nct6775, nct6776, nct6779 };
 
 /* used to set data->name = nct6775_device_names[data->sio_kind] */
@@ -179,10 +181,38 @@ static const u16 NCT6779_REG_IN[] = {
 static const u16 NCT6775_REG_ALARM[6] = { 0x459, 0x45A, 0x45B };
 static const u16 NCT6779_REG_ALARM[6] = { 0x459, 0x45A, 0x45B, 0x568 };
 
-#define NCT6775_REG_CASEOPEN           0x42
-
-static const u8 NCT6775_CASEOPEN_MASK[] = { 0x10, 0x00 };
-static const u8 NCT6776_CASEOPEN_MASK[] = { 0x10, 0x40 };
+/* 0..15 voltages, 16..23 fans, 24..31 temperatures */
+
+static const s8 NCT6775_ALARM_BITS[]
+       = { 0, 1, 2, 3, 8, 21, 20, 16,          /* in0.. in7 */
+           17, -1, -1, -1, -1, -1, -1,         /* in8..in14 */
+           -1,                                 /* unused */
+           6, 7, 11, 10, 23,                   /* fan1..fan5 */
+           -1, -1, -1,                         /* unused */
+           4, 5, 13, -1, -1, -1,               /* temp1..temp6 */
+           12, -1 };                           /* intrusion0, intrusion1 */
+
+static const s8 NCT6776_ALARM_BITS[]
+       = { 0, 1, 2, 3, 8, 21, 20, 16,          /* in0.. in7 */
+           17, -1, -1, -1, -1, -1, -1,         /* in8..in14 */
+           -1,                                 /* unused */
+           6, 7, 11, 10, 23,                   /* fan1..fan5 */
+           -1, -1, -1,                         /* unused */
+           4, 5, 13, -1, -1, -1,               /* temp1..temp6 */
+           12, 9 };                            /* intrusion0, intrusion1 */
+
+static const s8 NCT6779_ALARM_BITS[]
+       = { 0, 1, 2, 3, 8, 21, 20, 16,          /* in0.. in7 */
+           17, 24, 25, 26, 27, 28, 29,         /* in8..in14 */
+           -1,                                 /* unused */
+           6, 7, 11, 10, 23,                   /* fan1..fan5 */
+           -1, -1, -1,                         /* unused */
+           4, 5, 13, -1, -1, -1,               /* temp1..temp6 */
+           12, 9 };                            /* intrusion0, intrusion1 */
+
+#define FAN_ALARM_BASE         16
+#define TEMP_ALARM_BASE                24
+#define INTRUSION_ALARM_BASE   30
 
 static const u8 NCT6775_REG_CR_CASEOPEN_CLR[] = { 0xe6, 0xee };
 static const u8 NCT6775_CR_CASEOPEN_CLR_MASK[] = { 0x20, 0x01 };
@@ -196,6 +226,11 @@ static const u8 NCT6776_PWM_MODE_MASK[] = { 0x01, 0, 0 };
 
 /* Advanced Fan control, some values are common for all fans */
 
+static const u16 NCT6775_REG_FAN_PULSES[] = { 0x641, 0x642, 0x643, 0x644, 0 };
+static const u16 NCT6776_REG_FAN_PULSES[] = { 0x644, 0x645, 0x646, 0, 0 };
+static const u16 NCT6779_REG_FAN_PULSES[]
+       = { 0x644, 0x645, 0x646, 0x647, 0x648 };
+
 static const u16 NCT6775_REG_TARGET[] = { 0x101, 0x201, 0x301, 0x801, 0x901 };
 static const u16 NCT6775_REG_FAN_MODE[] = { 0x102, 0x202, 0x302, 0x802, 0x902 };
 static const u16 NCT6775_REG_FAN_STEP_DOWN_TIME[] = {
@@ -206,6 +241,9 @@ static const u16 NCT6775_REG_FAN_STOP_OUTPUT[] = {
        0x105, 0x205, 0x305, 0x805, 0x905 };
 static const u16 NCT6775_REG_FAN_START_OUTPUT[]
        = { 0x106, 0x206, 0x306, 0x806, 0x906 };
+static const u16 NCT6775_REG_FAN_MAX_OUTPUT[] = { 0x10a, 0x20a, 0x30a };
+static const u16 NCT6775_REG_FAN_STEP_OUTPUT[] = { 0x10b, 0x20b, 0x30b };
+
 static const u16 NCT6775_REG_FAN_STOP_TIME[]
        = { 0x107, 0x207, 0x307, 0x807, 0x907 };
 static const u16 NCT6775_REG_PWM[] = { 0x109, 0x209, 0x309, 0x809, 0x909 };
@@ -216,15 +254,13 @@ static const u16 NCT6775_REG_FAN[] = { 0x630, 0x632, 0x634, 0x636, 0x638 };
 static const u16 NCT6776_REG_FAN_MIN[] = { 0x63a, 0x63c, 0x63e, 0x640, 0x642};
 
 static const u16 NCT6779_REG_TOLERANCE_H[]
-       = { 0x10c, 0x20c, 0x30c, 0x40c, 0x50c };
+       = { 0x10c, 0x20c, 0x30c, 0x80c, 0x90c };
 
 static const u16 NCT6779_REG_FAN[] = { 0x4c0, 0x4c2, 0x4c4, 0x4c6, 0x4c8 };
 
 static const u16 NCT6775_REG_TEMP[]
        = { 0x27, 0x150, 0x250, 0x62b, 0x62c, 0x62d };
 static const u16 NCT6779_REG_TEMP[] = { 0x27, 0x150 };
-static const u16 NCT6779_REG_TEMP_FIXED[]
-       = { 0x490, 0x491, 0x492, 0x493, 0x494, 0x495};
 
 static const u16 NCT6775_REG_TEMP_CONFIG[]
        = { 0, 0x152, 0x252, 0x628, 0x629, 0x62A };
@@ -363,6 +399,17 @@ static const char *const nct6779_temp_label[] = {
        "BYTE_TEMP"
 };
 
+static const u16 NCT6775_REG_TEMP_ALTERNATE[ARRAY_SIZE(nct6775_temp_label)]
+       = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x661, 0x662, 0x664 };
+
+static const u16 NCT6776_REG_TEMP_ALTERNATE[ARRAY_SIZE(nct6776_temp_label)]
+       = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x401, 0x402, 0x404 };
+
+static const u16 NCT6779_REG_TEMP_ALTERNATE[ARRAY_SIZE(nct6779_temp_label)]
+       = { 0x490, 0x491, 0x492, 0x493, 0x494, 0x495, 0, 0,
+           0, 0, 0, 0, 0, 0, 0, 0,
+           0, 0, 0x401, 0x402, 0x404 };
+
 #define NUM_TEMP       10      /* Max number of temp attribute sets w/ limits*/
 #define NUM_TEMP_FIXED 6       /* Max number of fixed temp attribute sets */
 
@@ -372,20 +419,14 @@ static inline int reg_to_pwm_enable(int pwm, int mode)
 {
        if (mode == 0 && pwm == 255)
                return 0;       /* off  */
-       if (mode == 3)          /* SmartFan III */
-               return 2;       /* convert to thermal cruise */
-       if (mode < 3)
-               return mode + 1;
-       return 4;               /* SmartFan IV */
+       return mode + 1;
 }
 
 static inline int pwm_enable_to_reg(int mode)
 {
        if (mode == 0)
                return 0;
-       if (mode < 4)
-               return mode - 1;
-       return 4;
+       return mode - 1;
 }
 
 /*
@@ -478,11 +519,14 @@ struct nct6775_data {
        u8 temp_src[NUM_TEMP];
        u16 reg_temp_config[NUM_TEMP];
        const char * const *temp_label;
+       int temp_label_num;
 
        u16 REG_CONFIG;
        u16 REG_VBAT;
        u16 REG_DIODE;
 
+       const s8 *ALARM_BITS;
+
        const u16 *REG_VIN;
        const u16 *REG_IN_MINMAX[2];
 
@@ -495,10 +539,13 @@ struct nct6775_data {
        const u8 *REG_PWM_MODE;
        const u8 *PWM_MODE_MASK;
 
-       const u16 *REG_PWM[3];
+       const u16 *REG_PWM[7];  /* [0]=pwm, [1]=start_output, [2]=stop_output,
+                                * [3]=max_output, [4]=step_output,
+                                * [5]=weight_duty_step, [6]=weight_duty_base
+                                */
        const u16 *REG_PWM_READ;
 
-       const u16 *REG_TEMP_FIXED;
+       const u16 *REG_TEMP_ALTERNATE;
        const u16 *REG_TEMP_MON;
        const u16 *REG_AUTO_TEMP;
        const u16 *REG_AUTO_PWM;
@@ -510,15 +557,11 @@ struct nct6775_data {
        const u16 *REG_TEMP_SEL[2];     /* pwm temp, 0=base, 1=weight */
 
        const u16 *REG_WEIGHT_TEMP[3];  /* 0=base, 1=hyst, 2=step */
-       const u16 *REG_WEIGHT_DUTY[2];  /* 0=step, 1=base */
 
        const u16 *REG_TEMP_OFFSET;
 
        const u16 *REG_ALARM;
 
-       u8 REG_CASEOPEN;
-       const u8 *CASEOPEN_MASK;
-
        unsigned int (*fan_from_reg)(u16 reg, unsigned int divreg);
        unsigned int (*fan_from_reg_min)(u16 reg, unsigned int divreg);
 
@@ -543,7 +586,6 @@ struct nct6775_data {
        s8 temp_offset[NUM_TEMP_FIXED];
        s16 temp[3][NUM_TEMP]; /* 0=temp, 1=temp_over, 2=temp_hyst */
        u64 alarms;
-       u8 caseopen;
 
        u8 pwm_num;     /* number of pwm */
 
@@ -552,10 +594,13 @@ struct nct6775_data {
                           * 1->manual
                           * 2->thermal cruise mode (also called SmartFan I)
                           * 3->fan speed cruise mode
-                          * 4->enhanced variable thermal cruise (also called
-                          *    SmartFan IV)
+                          * 4->SmartFan III
+                          * 5->enhanced variable thermal cruise (SmartFan IV)
                           */
-       u8 pwm[3][5];   /* [0]=pwm, [1]=fan_start_output, [2]=fan_stop_output */
+       u8 pwm[7][5];   /* [0]=pwm, [1]=start_output, [2]=stop_output,
+                        * [3]=max_output, [4]=step_output,
+                        * [5]=weight_duty_step, [6]=weight_duty_base
+                        */
        u8 target_temp[5];
        s16 pwm_temp[5];
        u8 tolerance[5][2];
@@ -575,7 +620,6 @@ struct nct6775_data {
        u8 weight_temp[3][5];   /* 0->temp_step, 1->temp_step_tol,
                                 * 2->temp_base
                                 */
-       u8 weight_duty[2][5];   /* 0->duty_step, 1->duty_base */
 
        u8 vid;
        u8 vrm;
@@ -594,6 +638,16 @@ static bool is_word_sized(struct nct6775_data *data, u16 reg)
 {
        switch (data->kind) {
        case nct6775:
+               return (((reg & 0xff00) == 0x100 ||
+                   (reg & 0xff00) == 0x200) &&
+                  ((reg & 0x00ff) == 0x50 ||
+                   (reg & 0x00ff) == 0x53 ||
+                   (reg & 0x00ff) == 0x55)) ||
+                 (reg & 0xfff0) == 0x630 ||
+                 reg == 0x640 || reg == 0x642 ||
+                 reg == 0x662 ||
+                 ((reg & 0xfff0) == 0x650 && (reg & 0x000f) >= 0x06) ||
+                 reg == 0x73 || reg == 0x75 || reg == 0x77;
        case nct6776:
                return (((reg & 0xff00) == 0x100 ||
                    (reg & 0xff00) == 0x200) &&
@@ -601,12 +655,14 @@ static bool is_word_sized(struct nct6775_data *data, u16 reg)
                    (reg & 0x00ff) == 0x53 ||
                    (reg & 0x00ff) == 0x55)) ||
                  (reg & 0xfff0) == 0x630 ||
+                 reg == 0x402 ||
                  reg == 0x640 || reg == 0x642 ||
                  ((reg & 0xfff0) == 0x650 && (reg & 0x000f) >= 0x06) ||
                  reg == 0x73 || reg == 0x75 || reg == 0x77;
        case nct6779:
                return reg == 0x150 || reg == 0x153 || reg == 0x155 ||
                  ((reg & 0xfff0) == 0x4c0 && (reg & 0x000f) < 0x09) ||
+                 reg == 0x402 ||
                  reg == 0x63a || reg == 0x63c || reg == 0x63e ||
                  reg == 0x640 || reg == 0x642 ||
                  reg == 0x73 || reg == 0x75 || reg == 0x77 || reg == 0x79 ||
@@ -760,9 +816,13 @@ static void nct6775_update_pwm(struct device *dev)
                data->pwm_mode[i] = duty_is_dc;
 
                fanmodecfg = nct6775_read_value(data, data->REG_FAN_MODE[i]);
-               for (j = 0; j < 3; j++)
-                       data->pwm[j][i]
-                         = nct6775_read_value(data, data->REG_PWM[j][i]);
+               for (j = 0; j < ARRAY_SIZE(data->REG_PWM); j++) {
+                       if (data->REG_PWM[j] && data->REG_PWM[j][i]) {
+                               data->pwm[j][i]
+                                 = nct6775_read_value(data,
+                                                      data->REG_PWM[j][i]);
+                       }
+               }
 
                data->pwm_enable[i] = reg_to_pwm_enable(data->pwm[0][i],
                                                        (fanmodecfg >> 4) & 7);
@@ -796,14 +856,6 @@ static void nct6775_update_pwm(struct device *dev)
                          = nct6775_read_value(data,
                                               data->REG_WEIGHT_TEMP[j][i]);
                }
-               /* Weight duty (pwm) data */
-               for (j = 0; j < 2; j++) {
-                       if (!data->REG_WEIGHT_DUTY[j])
-                               continue;
-                       data->weight_duty[j][i]
-                         = nct6775_read_value(data,
-                                              data->REG_WEIGHT_DUTY[j][i]);
-               }
        }
 }
 
@@ -914,8 +966,8 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
                            && (reg >= 0xff || (data->kind == nct6775
                                                && reg == 0x00))
                            && data->fan_div[i] < 0x07) {
-                               dev_dbg(dev, "Increasing fan%d "
-                                       "clock divider from %u to %u\n",
+                               dev_dbg(dev,
+                                       "Increasing fan%d clock divider from %u to %u\n",
                                        i + 1, div_from_reg(data->fan_div[i]),
                                        div_from_reg(data->fan_div[i] + 1));
                                data->fan_div[i]++;
@@ -955,11 +1007,9 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
                        if (!data->REG_ALARM[i])
                                continue;
                        alarm = nct6775_read_value(data, data->REG_ALARM[i]);
-                       data->alarms |= (((u64)alarm) << (i << 3));
+                       data->alarms |= ((u64)alarm) << (i << 3);
                }
 
-               data->caseopen = nct6775_read_value(data, data->REG_CASEOPEN);
-
                data->last_updated = jiffies;
                data->valid = 1;
        }
@@ -1006,7 +1056,7 @@ show_alarm(struct device *dev, struct device_attribute *attr, char *buf)
 {
        struct nct6775_data *data = nct6775_update_device(dev);
        struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);
-       int nr = sattr->index;
+       int nr = data->ALARM_BITS[sattr->index];
        return sprintf(buf, "%u\n",
                       (unsigned int)((data->alarms >> nr) & 0x01));
 }
@@ -1031,17 +1081,17 @@ static SENSOR_DEVICE_ATTR(in0_alarm, S_IRUGO, show_alarm, NULL, 0);
 static SENSOR_DEVICE_ATTR(in1_alarm, S_IRUGO, show_alarm, NULL, 1);
 static SENSOR_DEVICE_ATTR(in2_alarm, S_IRUGO, show_alarm, NULL, 2);
 static SENSOR_DEVICE_ATTR(in3_alarm, S_IRUGO, show_alarm, NULL, 3);
-static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 8);
-static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 21);
-static SENSOR_DEVICE_ATTR(in6_alarm, S_IRUGO, show_alarm, NULL, 20);
-static SENSOR_DEVICE_ATTR(in7_alarm, S_IRUGO, show_alarm, NULL, 16);
-static SENSOR_DEVICE_ATTR(in8_alarm, S_IRUGO, show_alarm, NULL, 17);
-static SENSOR_DEVICE_ATTR(in9_alarm, S_IRUGO, show_alarm, NULL, 24);
-static SENSOR_DEVICE_ATTR(in10_alarm, S_IRUGO, show_alarm, NULL, 25);
-static SENSOR_DEVICE_ATTR(in11_alarm, S_IRUGO, show_alarm, NULL, 26);
-static SENSOR_DEVICE_ATTR(in12_alarm, S_IRUGO, show_alarm, NULL, 27);
-static SENSOR_DEVICE_ATTR(in13_alarm, S_IRUGO, show_alarm, NULL, 28);
-static SENSOR_DEVICE_ATTR(in14_alarm, S_IRUGO, show_alarm, NULL, 29);
+static SENSOR_DEVICE_ATTR(in4_alarm, S_IRUGO, show_alarm, NULL, 4);
+static SENSOR_DEVICE_ATTR(in5_alarm, S_IRUGO, show_alarm, NULL, 5);
+static SENSOR_DEVICE_ATTR(in6_alarm, S_IRUGO, show_alarm, NULL, 6);
+static SENSOR_DEVICE_ATTR(in7_alarm, S_IRUGO, show_alarm, NULL, 7);
+static SENSOR_DEVICE_ATTR(in8_alarm, S_IRUGO, show_alarm, NULL, 8);
+static SENSOR_DEVICE_ATTR(in9_alarm, S_IRUGO, show_alarm, NULL, 9);
+static SENSOR_DEVICE_ATTR(in10_alarm, S_IRUGO, show_alarm, NULL, 10);
+static SENSOR_DEVICE_ATTR(in11_alarm, S_IRUGO, show_alarm, NULL, 11);
+static SENSOR_DEVICE_ATTR(in12_alarm, S_IRUGO, show_alarm, NULL, 12);
+static SENSOR_DEVICE_ATTR(in13_alarm, S_IRUGO, show_alarm, NULL, 13);
+static SENSOR_DEVICE_ATTR(in14_alarm, S_IRUGO, show_alarm, NULL, 14);
 
 static SENSOR_DEVICE_ATTR_2(in0_min, S_IWUSR | S_IRUGO, show_in_reg,
                            store_in_reg, 0, 1);
@@ -1308,9 +1358,9 @@ store_fan_min(struct device *dev, struct device_attribute *attr,
                 */
                data->fan_min[nr] = 254;
                new_div = 7; /* 128 == (1 << 7) */
-               dev_warn(dev, "fan%u low limit %lu below minimum %u, set to "
-                        "minimum\n", nr + 1, val,
-                        data->fan_from_reg_min(254, 7));
+               dev_warn(dev,
+                        "fan%u low limit %lu below minimum %u, set to minimum\n",
+                        nr + 1, val, data->fan_from_reg_min(254, 7));
        } else if (!reg) {
                /*
                 * Speed above this value cannot possibly be represented,
@@ -1318,9 +1368,9 @@ store_fan_min(struct device *dev, struct device_attribute *attr,
                 */
                data->fan_min[nr] = 1;
                new_div = 0; /* 1 == (1 << 0) */
-               dev_warn(dev, "fan%u low limit %lu above maximum %u, set to "
-                        "maximum\n", nr + 1, val,
-                        data->fan_from_reg_min(1, 0));
+               dev_warn(dev,
+                        "fan%u low limit %lu above maximum %u, set to maximum\n",
+                        nr + 1, val, data->fan_from_reg_min(1, 0));
        } else {
                /*
                 * Automatically pick the best divider, i.e. the one such
@@ -1367,11 +1417,11 @@ static struct sensor_device_attribute sda_fan_input[] = {
 };
 
 static struct sensor_device_attribute sda_fan_alarm[] = {
-       SENSOR_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, 6),
-       SENSOR_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, 7),
-       SENSOR_ATTR(fan3_alarm, S_IRUGO, show_alarm, NULL, 11),
-       SENSOR_ATTR(fan4_alarm, S_IRUGO, show_alarm, NULL, 10),
-       SENSOR_ATTR(fan5_alarm, S_IRUGO, show_alarm, NULL, 23),
+       SENSOR_ATTR(fan1_alarm, S_IRUGO, show_alarm, NULL, FAN_ALARM_BASE),
+       SENSOR_ATTR(fan2_alarm, S_IRUGO, show_alarm, NULL, FAN_ALARM_BASE + 1),
+       SENSOR_ATTR(fan3_alarm, S_IRUGO, show_alarm, NULL, FAN_ALARM_BASE + 2),
+       SENSOR_ATTR(fan4_alarm, S_IRUGO, show_alarm, NULL, FAN_ALARM_BASE + 3),
+       SENSOR_ATTR(fan5_alarm, S_IRUGO, show_alarm, NULL, FAN_ALARM_BASE + 4),
 };
 
 static struct sensor_device_attribute sda_fan_min[] = {
@@ -1504,7 +1554,7 @@ store_temp_type(struct device *dev, struct device_attribute *attr,
        vbat = nct6775_read_value(data, data->REG_VBAT) & ~(0x02 << nr);
        diode = nct6775_read_value(data, data->REG_DIODE) & ~(0x02 << nr);
        bit = 0x02 << nr;
-       switch(val) {
+       switch (val) {
        case 1: /* CPU diode (diode, current mode) */
                vbat |= bit;
                diode |= bit;
@@ -1590,7 +1640,7 @@ static struct sensor_device_attribute_2 sda_temp_max_hyst[] = {
                      7, 2),
        SENSOR_ATTR_2(temp9_max_hyst, S_IRUGO | S_IWUSR, show_temp, store_temp,
                      8, 2),
-       SENSOR_ATTR_2(temp9_max_hyst, S_IRUGO | S_IWUSR, show_temp, store_temp,
+       SENSOR_ATTR_2(temp10_max_hyst, S_IRUGO | S_IWUSR, show_temp, store_temp,
                      9, 2),
 };
 
@@ -1625,9 +1675,18 @@ static struct sensor_device_attribute sda_temp_type[] = {
 };
 
 static struct sensor_device_attribute sda_temp_alarm[] = {
-       SENSOR_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL, 4),
-       SENSOR_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL, 5),
-       SENSOR_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL, 13),
+       SENSOR_ATTR(temp1_alarm, S_IRUGO, show_alarm, NULL,
+                   TEMP_ALARM_BASE),
+       SENSOR_ATTR(temp2_alarm, S_IRUGO, show_alarm, NULL,
+                   TEMP_ALARM_BASE + 1),
+       SENSOR_ATTR(temp3_alarm, S_IRUGO, show_alarm, NULL,
+                   TEMP_ALARM_BASE + 2),
+       SENSOR_ATTR(temp4_alarm, S_IRUGO, show_alarm, NULL,
+                   TEMP_ALARM_BASE + 3),
+       SENSOR_ATTR(temp5_alarm, S_IRUGO, show_alarm, NULL,
+                   TEMP_ALARM_BASE + 4),
+       SENSOR_ATTR(temp6_alarm, S_IRUGO, show_alarm, NULL,
+                   TEMP_ALARM_BASE + 5),
 };
 
 #define NUM_TEMP_ALARM ARRAY_SIZE(sda_temp_alarm)
@@ -1716,13 +1775,15 @@ store_pwm(struct device *dev, struct device_attribute *attr, const char *buf,
        int nr = sattr->nr;
        int index = sattr->index;
        unsigned long val;
+       int minval[7] = { 0, 1, 1, data->pwm[2][nr], 0, 0, 0 };
+       int maxval[7]
+         = { 255, 255, data->pwm[3][nr] ? : 255, 255, 255, 255, 255 };
        int err;
 
        err = kstrtoul(buf, 10, &val);
        if (err < 0)
                return err;
-       if (val > 255 || (index && val == 0))
-               return -EINVAL;
+       val = SENSORS_LIMIT(val, minval[index], maxval[index]);
 
        mutex_lock(&data->update_lock);
        data->pwm[index][nr] = val;
@@ -1770,10 +1831,13 @@ store_pwm_enable(struct device *dev, struct device_attribute *attr,
        if (err < 0)
                return err;
 
-       if (val > 4)
+       if (val > 5)
                return -EINVAL;
 
-       if (val == 4 && check_trip_points(data, nr)) {
+       if (val == 4 && data->kind != nct6775)
+               return -EINVAL;
+
+       if (val == 5 && check_trip_points(data, nr)) {
                dev_err(dev, "Inconsistent trip points, not switching to SmartFan IV mode\n");
                dev_err(dev, "Adjust trip points and try again\n");
                return -EINVAL;
@@ -1790,7 +1854,7 @@ store_pwm_enable(struct device *dev, struct device_attribute *attr,
        }
        reg = nct6775_read_value(data, data->REG_FAN_MODE[nr]);
        reg &= 0x0f;
-       reg |= (pwm_enable_to_reg(val) << 4);
+       reg |= pwm_enable_to_reg(val) << 4;
        nct6775_write_value(data, data->REG_FAN_MODE[nr], reg);
        mutex_unlock(&data->update_lock);
        return count;
@@ -1827,11 +1891,6 @@ store_pwm_temp_sel(struct device *dev, struct device_attribute *attr,
        unsigned long val;
        int err;
        int reg;
-       static const int max_src[] = {
-           ARRAY_SIZE(nct6775_temp_label),
-           ARRAY_SIZE(nct6776_temp_label),
-           ARRAY_SIZE(nct6779_temp_label)
-       };
 
        err = kstrtoul(buf, 10, &val);
        if (err < 0)
@@ -1839,7 +1898,7 @@ store_pwm_temp_sel(struct device *dev, struct device_attribute *attr,
        if (val == 0 || val > 0x1f)
                return -EINVAL;
 
-       val = SENSORS_LIMIT(val, 1, max_src[data->kind]);
+       val = SENSORS_LIMIT(val, 1, data->temp_label_num - 1);
 
        if (!strlen(data->temp_label[val]))
                return -EINVAL;
@@ -2085,41 +2144,6 @@ store_weight_temp(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-static ssize_t
-show_weight_duty(struct device *dev, struct device_attribute *attr, char *buf)
-{
-       struct nct6775_data *data = nct6775_update_device(dev);
-       struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-       int nr = sattr->nr;
-       int index = sattr->index;
-
-       return sprintf(buf, "%d\n", data->weight_duty[index][nr]);
-}
-
-static ssize_t
-store_weight_duty(struct device *dev, struct device_attribute *attr,
-                 const char *buf, size_t count)
-{
-       struct nct6775_data *data = dev_get_drvdata(dev);
-       struct sensor_device_attribute_2 *sattr = to_sensor_dev_attr_2(attr);
-       int nr = sattr->nr;
-       int index = sattr->index;
-       unsigned long val;
-       int err;
-
-       err = kstrtoul(buf, 10, &val);
-       if (err < 0)
-               return err;
-
-       val = SENSORS_LIMIT(val, 0, 255);
-
-       mutex_lock(&data->update_lock);
-       data->weight_duty[index][nr] = val;
-       nct6775_write_value(data, data->REG_WEIGHT_DUTY[index][nr], val);
-       mutex_unlock(&data->update_lock);
-       return count;
-}
-
 static SENSOR_DEVICE_ATTR_2(pwm1_stop_output_enable, S_IWUSR | S_IRUGO,
                            show_pwm_sel_enable, store_pwm_sel_enable, 0, 0);
 static SENSOR_DEVICE_ATTR_2(pwm2_stop_output_enable, S_IWUSR | S_IRUGO,
@@ -2187,28 +2211,28 @@ static SENSOR_DEVICE_ATTR_2(pwm5_weight_temp_step_base, S_IWUSR | S_IRUGO,
                            show_weight_temp, store_weight_temp, 4, 2);
 
 static SENSOR_DEVICE_ATTR_2(pwm1_weight_duty_step, S_IWUSR | S_IRUGO,
-                           show_weight_duty, store_weight_duty, 0, 0);
+                           show_pwm, store_pwm, 0, 5);
 static SENSOR_DEVICE_ATTR_2(pwm2_weight_duty_step, S_IWUSR | S_IRUGO,
-                           show_weight_duty, store_weight_duty, 1, 0);
+                           show_pwm, store_pwm, 1, 5);
 static SENSOR_DEVICE_ATTR_2(pwm3_weight_duty_step, S_IWUSR | S_IRUGO,
-                           show_weight_duty, store_weight_duty, 2, 0);
+                           show_pwm, store_pwm, 2, 5);
 static SENSOR_DEVICE_ATTR_2(pwm4_weight_duty_step, S_IWUSR | S_IRUGO,
-                           show_weight_duty, store_weight_duty, 3, 0);
+                           show_pwm, store_pwm, 3, 5);
 static SENSOR_DEVICE_ATTR_2(pwm5_weight_duty_step, S_IWUSR | S_IRUGO,
-                           show_weight_duty, store_weight_duty, 4, 0);
+                           show_pwm, store_pwm, 4, 5);
 
 /* duty_base is not supported on all chips */
 static struct sensor_device_attribute_2 sda_weight_duty_base[] = {
        SENSOR_ATTR_2(pwm1_weight_duty_base, S_IWUSR | S_IRUGO,
-                     show_weight_duty, store_weight_duty, 0, 1),
+                     show_pwm, store_pwm, 0, 6),
        SENSOR_ATTR_2(pwm2_weight_duty_base, S_IWUSR | S_IRUGO,
-                     show_weight_duty, store_weight_duty, 1, 1),
+                     show_pwm, store_pwm, 1, 6),
        SENSOR_ATTR_2(pwm3_weight_duty_base, S_IWUSR | S_IRUGO,
-                     show_weight_duty, store_weight_duty, 2, 1),
+                     show_pwm, store_pwm, 2, 6),
        SENSOR_ATTR_2(pwm4_weight_duty_base, S_IWUSR | S_IRUGO,
-                     show_weight_duty, store_weight_duty, 3, 1),
+                     show_pwm, store_pwm, 3, 6),
        SENSOR_ATTR_2(pwm5_weight_duty_base, S_IWUSR | S_IRUGO,
-                     show_weight_duty, store_weight_duty, 4, 1),
+                     show_pwm, store_pwm, 4, 6),
 };
 
 static ssize_t
@@ -2312,6 +2336,34 @@ static SENSOR_DEVICE_ATTR_2(pwm4_stop_output, S_IWUSR | S_IRUGO, show_pwm,
 static SENSOR_DEVICE_ATTR_2(pwm5_stop_output, S_IWUSR | S_IRUGO, show_pwm,
                            store_pwm, 4, 2);
 
+/* max_output is not supported on all chips */
+static struct sensor_device_attribute_2 sda_max_output[] = {
+       SENSOR_ATTR_2(pwm1_max_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     0, 3),
+       SENSOR_ATTR_2(pwm2_max_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     1, 3),
+       SENSOR_ATTR_2(pwm3_max_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     2, 3),
+       SENSOR_ATTR_2(pwm4_max_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     3, 3),
+       SENSOR_ATTR_2(pwm5_max_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     4, 3),
+};
+
+/* step_output is not supported on all chips */
+static struct sensor_device_attribute_2 sda_step_output[] = {
+       SENSOR_ATTR_2(pwm1_step_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     0, 4),
+       SENSOR_ATTR_2(pwm2_step_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     1, 4),
+       SENSOR_ATTR_2(pwm3_step_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     2, 4),
+       SENSOR_ATTR_2(pwm4_step_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     3, 4),
+       SENSOR_ATTR_2(pwm5_step_output, S_IWUSR | S_IRUGO, show_pwm, store_pwm,
+                     4, 4),
+};
+
 static struct attribute *nct6775_attributes_pwm[5][20] = {
        {
                &sensor_dev_attr_temp11_input.dev_attr.attr,
@@ -2780,22 +2832,13 @@ static DEVICE_ATTR(cpu0_vid, S_IRUGO, show_vid, NULL);
 
 /* Case open detection */
 
-static ssize_t
-show_caseopen(struct device *dev, struct device_attribute *attr, char *buf)
-{
-       struct nct6775_data *data = nct6775_update_device(dev);
-
-       return sprintf(buf, "%d\n",
-               !!(data->caseopen & to_sensor_dev_attr_2(attr)->index));
-}
-
 static ssize_t
 clear_caseopen(struct device *dev, struct device_attribute *attr,
               const char *buf, size_t count)
 {
        struct nct6775_data *data = dev_get_drvdata(dev);
        struct nct6775_sio_data *sio_data = dev->platform_data;
-       int nr = to_sensor_dev_attr(attr)->index;
+       int nr = to_sensor_dev_attr(attr)->index - INTRUSION_ALARM_BASE;
        unsigned long val;
        u8 reg;
 
@@ -2814,6 +2857,8 @@ clear_caseopen(struct device *dev, struct device_attribute *attr,
        reg = superio_inb(sio_data->sioreg, NCT6775_REG_CR_CASEOPEN_CLR[nr]);
        reg |= NCT6775_CR_CASEOPEN_CLR_MASK[nr];
        superio_outb(sio_data->sioreg, NCT6775_REG_CR_CASEOPEN_CLR[nr], reg);
+       reg &= ~NCT6775_CR_CASEOPEN_CLR_MASK[nr];
+       superio_outb(sio_data->sioreg, NCT6775_REG_CR_CASEOPEN_CLR[nr], reg);
        superio_exit(sio_data->sioreg);
 
        data->valid = 0;        /* Force cache refresh */
@@ -2824,10 +2869,10 @@ clear_caseopen(struct device *dev, struct device_attribute *attr,
 }
 
 static struct sensor_device_attribute sda_caseopen[] = {
-       SENSOR_ATTR(intrusion0_alarm, S_IWUSR | S_IRUGO, show_caseopen,
-                   clear_caseopen, 0),
-       SENSOR_ATTR(intrusion1_alarm, S_IWUSR | S_IRUGO, show_caseopen,
-                   clear_caseopen, 1),
+       SENSOR_ATTR(intrusion0_alarm, S_IWUSR | S_IRUGO, show_alarm,
+                   clear_caseopen, INTRUSION_ALARM_BASE),
+       SENSOR_ATTR(intrusion1_alarm, S_IWUSR | S_IRUGO, show_alarm,
+                   clear_caseopen, INTRUSION_ALARM_BASE + 1),
 };
 
 /*
@@ -2846,6 +2891,12 @@ static void nct6775_device_remove_files(struct device *dev)
        for (i = 0; i < data->pwm_num; i++)
                sysfs_remove_group(&dev->kobj, &nct6775_group_pwm[i]);
 
+       for (i = 0; i < ARRAY_SIZE(sda_max_output); i++)
+               device_remove_file(dev, &sda_max_output[i].dev_attr);
+
+       for (i = 0; i < ARRAY_SIZE(sda_step_output); i++)
+               device_remove_file(dev, &sda_max_output[i].dev_attr);
+
        for (i = 0; i < ARRAY_SIZE(sda_weight_duty_base); i++)
                device_remove_file(dev, &sda_weight_duty_base[i].dev_attr);
 
@@ -2994,8 +3045,8 @@ nct6775_check_fan_inputs(const struct nct6775_sio_data *sio_data,
        superio_exit(sio_data->sioreg);
 
        data->has_fan = data->has_fan_min = 0x03; /* fan1 and fan2 */
-       data->has_fan |= (fan3pin << 2);
-       data->has_fan_min |= (fan3min << 2);
+       data->has_fan |= fan3pin << 2;
+       data->has_fan_min |= fan3min << 2;
 
        data->has_fan |= (fan4pin << 3) | (fan5pin << 4);
        data->has_fan_min |= (fan4min << 3) | (fan5pin << 4);
@@ -3010,7 +3061,7 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
        struct nct6775_data *data;
        struct resource *res;
        int i, s, err = 0;
-       int src, mask = 0;
+       int src, mask, available;
        const u16 *reg_temp, *reg_temp_over, *reg_temp_hyst, *reg_temp_config;
 
        res = platform_get_resource(pdev, IORESOURCE_IO, 0);
@@ -3039,15 +3090,19 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
        switch (data->kind) {
        case nct6775:
                data->in_num = 9;
-               data->have_in = 0x1ff;
                data->pwm_num = 3;
                data->auto_pwm_num = 6;
                data->has_fan_div = true;
                data->temp_fixed_num = 3;
 
+               data->ALARM_BITS = NCT6775_ALARM_BITS;
+
                data->fan_from_reg = fan_from_reg16;
                data->fan_from_reg_min = fan_from_reg8;
 
+               data->temp_label = nct6775_temp_label;
+               data->temp_label_num = ARRAY_SIZE(nct6775_temp_label);
+
                data->REG_CONFIG = NCT6775_REG_CONFIG;
                data->REG_VBAT = NCT6775_REG_VBAT;
                data->REG_DIODE = NCT6775_REG_DIODE;
@@ -3064,9 +3119,13 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                data->REG_PWM[0] = NCT6775_REG_PWM;
                data->REG_PWM[1] = NCT6775_REG_FAN_START_OUTPUT;
                data->REG_PWM[2] = NCT6775_REG_FAN_STOP_OUTPUT;
+               data->REG_PWM[3] = NCT6775_REG_FAN_MAX_OUTPUT;
+               data->REG_PWM[4] = NCT6775_REG_FAN_STEP_OUTPUT;
+               data->REG_PWM[5] = NCT6775_REG_WEIGHT_DUTY_STEP;
                data->REG_PWM_READ = NCT6775_REG_PWM_READ;
                data->REG_PWM_MODE = NCT6775_REG_PWM_MODE;
                data->PWM_MODE_MASK = NCT6775_PWM_MODE_MASK;
+               data->REG_TEMP_ALTERNATE = NCT6775_REG_TEMP_ALTERNATE;
                data->REG_TEMP_MON = NCT6775_REG_TEMP_MON;
                data->REG_AUTO_TEMP = NCT6775_REG_AUTO_TEMP;
                data->REG_AUTO_PWM = NCT6775_REG_AUTO_PWM;
@@ -3080,10 +3139,7 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                data->REG_WEIGHT_TEMP[0] = NCT6775_REG_WEIGHT_TEMP_STEP;
                data->REG_WEIGHT_TEMP[1] = NCT6775_REG_WEIGHT_TEMP_STEP_TOL;
                data->REG_WEIGHT_TEMP[2] = NCT6775_REG_WEIGHT_TEMP_BASE;
-               data->REG_WEIGHT_DUTY[0] = NCT6775_REG_WEIGHT_DUTY_STEP;
                data->REG_ALARM = NCT6775_REG_ALARM;
-               data->REG_CASEOPEN = NCT6775_REG_CASEOPEN;
-               data->CASEOPEN_MASK = NCT6775_CASEOPEN_MASK;
 
                reg_temp = NCT6775_REG_TEMP;
                reg_temp_over = NCT6775_REG_TEMP_OVER;
@@ -3093,15 +3149,19 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                break;
        case nct6776:
                data->in_num = 9;
-               data->have_in = 0x1ff;
                data->pwm_num = 3;
                data->auto_pwm_num = 4;
                data->has_fan_div = false;
                data->temp_fixed_num = 3;
 
+               data->ALARM_BITS = NCT6776_ALARM_BITS;
+
                data->fan_from_reg = fan_from_reg13;
                data->fan_from_reg_min = fan_from_reg13;
 
+               data->temp_label = nct6776_temp_label;
+               data->temp_label_num = ARRAY_SIZE(nct6776_temp_label);
+
                data->REG_CONFIG = NCT6775_REG_CONFIG;
                data->REG_VBAT = NCT6775_REG_VBAT;
                data->REG_DIODE = NCT6775_REG_DIODE;
@@ -3118,9 +3178,12 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                data->REG_PWM[0] = NCT6775_REG_PWM;
                data->REG_PWM[1] = NCT6775_REG_FAN_START_OUTPUT;
                data->REG_PWM[2] = NCT6775_REG_FAN_STOP_OUTPUT;
+               data->REG_PWM[5] = NCT6775_REG_WEIGHT_DUTY_STEP;
+               data->REG_PWM[6] = NCT6776_REG_WEIGHT_DUTY_BASE;
                data->REG_PWM_READ = NCT6775_REG_PWM_READ;
                data->REG_PWM_MODE = NCT6776_REG_PWM_MODE;
                data->PWM_MODE_MASK = NCT6776_PWM_MODE_MASK;
+               data->REG_TEMP_ALTERNATE = NCT6776_REG_TEMP_ALTERNATE;
                data->REG_TEMP_MON = NCT6775_REG_TEMP_MON;
                data->REG_AUTO_TEMP = NCT6775_REG_AUTO_TEMP;
                data->REG_AUTO_PWM = NCT6775_REG_AUTO_PWM;
@@ -3134,11 +3197,7 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                data->REG_WEIGHT_TEMP[0] = NCT6775_REG_WEIGHT_TEMP_STEP;
                data->REG_WEIGHT_TEMP[1] = NCT6775_REG_WEIGHT_TEMP_STEP_TOL;
                data->REG_WEIGHT_TEMP[2] = NCT6775_REG_WEIGHT_TEMP_BASE;
-               data->REG_WEIGHT_DUTY[0] = NCT6775_REG_WEIGHT_DUTY_STEP;
-               data->REG_WEIGHT_DUTY[1] = NCT6776_REG_WEIGHT_DUTY_BASE;
                data->REG_ALARM = NCT6775_REG_ALARM;
-               data->REG_CASEOPEN = NCT6775_REG_CASEOPEN;
-               data->CASEOPEN_MASK = NCT6776_CASEOPEN_MASK;
 
                reg_temp = NCT6775_REG_TEMP;
                reg_temp_over = NCT6775_REG_TEMP_OVER;
@@ -3148,15 +3207,19 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                break;
        case nct6779:
                data->in_num = 15;
-               data->have_in = 0x7fff;
                data->pwm_num = 5;
                data->auto_pwm_num = 4;
                data->has_fan_div = false;
                data->temp_fixed_num = 6;
 
+               data->ALARM_BITS = NCT6779_ALARM_BITS;
+
                data->fan_from_reg = fan_from_reg13;
                data->fan_from_reg_min = fan_from_reg13;
 
+               data->temp_label = nct6779_temp_label;
+               data->temp_label_num = ARRAY_SIZE(nct6779_temp_label);
+
                data->REG_CONFIG = NCT6775_REG_CONFIG;
                data->REG_VBAT = NCT6775_REG_VBAT;
                data->REG_DIODE = NCT6775_REG_DIODE;
@@ -3173,10 +3236,12 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                data->REG_PWM[0] = NCT6775_REG_PWM;
                data->REG_PWM[1] = NCT6775_REG_FAN_START_OUTPUT;
                data->REG_PWM[2] = NCT6775_REG_FAN_STOP_OUTPUT;
+               data->REG_PWM[5] = NCT6775_REG_WEIGHT_DUTY_STEP;
+               data->REG_PWM[6] = NCT6776_REG_WEIGHT_DUTY_BASE;
                data->REG_PWM_READ = NCT6775_REG_PWM_READ;
                data->REG_PWM_MODE = NCT6776_REG_PWM_MODE;
                data->PWM_MODE_MASK = NCT6776_PWM_MODE_MASK;
-               data->REG_TEMP_FIXED = NCT6779_REG_TEMP_FIXED;
+               data->REG_TEMP_ALTERNATE = NCT6779_REG_TEMP_ALTERNATE;
                data->REG_TEMP_MON = NCT6775_REG_TEMP_MON;
                data->REG_AUTO_TEMP = NCT6775_REG_AUTO_TEMP;
                data->REG_AUTO_PWM = NCT6775_REG_AUTO_PWM;
@@ -3190,11 +3255,7 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                data->REG_WEIGHT_TEMP[0] = NCT6775_REG_WEIGHT_TEMP_STEP;
                data->REG_WEIGHT_TEMP[1] = NCT6775_REG_WEIGHT_TEMP_STEP_TOL;
                data->REG_WEIGHT_TEMP[2] = NCT6775_REG_WEIGHT_TEMP_BASE;
-               data->REG_WEIGHT_DUTY[0] = NCT6775_REG_WEIGHT_DUTY_STEP;
-               data->REG_WEIGHT_DUTY[1] = NCT6776_REG_WEIGHT_DUTY_BASE;
                data->REG_ALARM = NCT6779_REG_ALARM;
-               data->REG_CASEOPEN = NCT6775_REG_CASEOPEN;
-               data->CASEOPEN_MASK = NCT6776_CASEOPEN_MASK;
 
                reg_temp = NCT6779_REG_TEMP;
                reg_temp_over = NCT6775_REG_TEMP_OVER;
@@ -3206,26 +3267,81 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                err = -ENODEV;
                goto exit_release;
        }
-
-       /* Default to no temperature inputs, code below will adjust as needed */
+       data->have_in = (1 << data->in_num) - 1;
        data->have_temp = 0;
 
-       s = NUM_TEMP_FIXED;     /* Index for first non-standard temperature */
+       /*
+        * On some boards, not all available temperature sources are monitored,
+        * even though some of the monitoring registers are unused.
+        * Get list of unused monitoring registers, then detect if any fan
+        * controls are configured to use unmonitored temperature sources.
+        * If so, assign the unmonitored temperature sources to available
+        * monitoring registers.
+        */
+       mask = 0;
+       available = 0;
        for (i = 0; i < NUM_REG_TEMP; i++) {
                if (reg_temp[i] == 0)
                        continue;
 
-               src = nct6775_read_value(data, data->REG_TEMP_SOURCE[i]);
-               src &= 0x1f;
+               src = nct6775_read_value(data, data->REG_TEMP_SOURCE[i]) & 0x1f;
+               if (!src || (mask & (1 << src)))
+                       available |= 1 << i;
+
+               mask |= 1 << src;
+       }
+
+       /*
+        * Now find unmonitored temperature registers and enable monitoring
+        * if additional monitoring registers are available.
+        */
+       for (i = 0; i < ARRAY_SIZE(data->REG_TEMP_SEL) && available; i++) {
+               int j;
+
+               if (!data->REG_TEMP_SEL[i])
+                       continue;
+               for (j = 0; j < data->pwm_num && available; j++) {
+                       int index;
+
+                       if (!data->REG_TEMP_SEL[i][j])
+                               continue;
+                       src = nct6775_read_value(data,
+                                                data->REG_TEMP_SEL[i][j]);
+                       src &= 0x1f;
+                       if (!src || (mask & (1 << src)))
+                               continue;
+
+                       index = __ffs(available);
+                       nct6775_write_value(data,
+                                           data->REG_TEMP_SOURCE[index],
+                                           src);
+                       available &= ~(1 << index);
+                       mask |= 1 << src;
+               }
+       }
+
+       mask = 0;
+       s = NUM_TEMP_FIXED;     /* First dynamic temperature attribute */
+       for (i = 0; i < NUM_REG_TEMP; i++) {
+               if (reg_temp[i] == 0)
+                       continue;
 
+               src = nct6775_read_value(data, data->REG_TEMP_SOURCE[i]) & 0x1f;
                if (!src || (mask & (1 << src)))
                        continue;
 
+               if (src >= data->temp_label_num ||
+                   !strlen(data->temp_label[src])) {
+                       dev_info(dev, "Invalid temperature source %d\n", src);
+                       continue;
+               }
+
+               mask |= 1 << src;
+
                /* Use fixed index for SYSTIN(1), CPUTIN(2), AUXTIN(3) */
                if (src <= data->temp_fixed_num) {
-                       data->have_temp |= (1 << (src - 1));
-                       data->have_temp_fixed |= (1 << (src - 1));
-                       mask |= 1 << src;
+                       data->have_temp |= 1 << (src - 1);
+                       data->have_temp_fixed |= 1 << (src - 1);
                        data->reg_temp[0][src - 1] = reg_temp[i];
                        data->reg_temp[1][src - 1] = reg_temp_over[i];
                        data->reg_temp[2][src - 1] = reg_temp_hyst[i];
@@ -3239,33 +3355,51 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
 
                /* Use dynamic index for other sources */
                data->have_temp |= 1 << s;
-               mask |= 1 << src;
-
                data->reg_temp[0][s] = reg_temp[i];
                data->reg_temp[1][s] = reg_temp_over[i];
                data->reg_temp[2][s] = reg_temp_hyst[i];
                data->reg_temp_config[s] = reg_temp_config[i];
 
-
                data->temp_src[s] = src;
                s++;
        }
 
-       if (data->REG_TEMP_FIXED) {
-               for (i = 0; i < NUM_TEMP_FIXED; i++) {
-                       if (data->have_temp & (1 << i))
+#ifdef TESTING
+       /*
+        * We may have alternate registers for some sensors.
+        * Go through the list and enable if possible.
+        * The temperature is already monitored if the respective bit in <mask>
+        * is set.
+        */
+       if (data->REG_TEMP_ALTERNATE) {
+               for (i = 0; i < data->temp_label_num; i++) {
+                       if (!data->REG_TEMP_ALTERNATE[i])
+                               continue;
+                       if (mask & (1 << (i + 1)))
                                continue;
-                       if (!data->REG_TEMP_FIXED[i])
+                       if (i < data->temp_fixed_num) {
+                               if (data->have_temp & (1 << i))
+                                       continue;
+                               data->have_temp |= 1 << i;
+                               data->reg_temp[0][i]
+                                 = data->REG_TEMP_ALTERNATE[i];
+                               data->temp_src[i] = i + 1;
                                continue;
-                       data->have_temp |= (1 << i);
-                       data->reg_temp[0][i] = data->REG_TEMP_FIXED[i];
-                       data->temp_src[i] = i + 1;
+                       }
+
+                       if (s >= NUM_TEMP)      /* Abort if no more space */
+                               break;
+
+                       data->have_temp |= 1 << s;
+                       data->reg_temp[0][s] = data->REG_TEMP_ALTERNATE[i];
+                       data->temp_src[s] = i + 1;
+                       s++;
                }
        }
+#endif /* TESTING */
 
        switch (data->kind) {
        case nct6775:
-               data->temp_label = nct6775_temp_label;
                break;
        case nct6776:
                /*
@@ -3285,7 +3419,6 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                        else
                                data->have_in &= ~(1 << 6);
                }
-               data->temp_label = nct6776_temp_label;
                break;
        case nct6779:
                /*
@@ -3309,7 +3442,6 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                        if (i == 5)                             /* AUXTIN3 */
                                data->have_in &= ~(1 << 14);    /* no VIN7 */
                }
-               data->temp_label = nct6779_temp_label;
                break;
        }
 
@@ -3345,7 +3477,8 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                }
                superio_outb(sio_data->sioreg, NCT6775_REG_CR_FAN_DEBOUNCE,
                             tmp);
-               pr_info("Enabled fan debounce for chip %s\n", data->name);
+               dev_info(&pdev->dev, "Enabled fan debounce for chip %s\n",
+                        data->name);
        }
 
        superio_exit(sio_data->sioreg);
@@ -3364,7 +3497,19 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                if (err)
                        goto exit_remove;
 
-               if (data->REG_WEIGHT_DUTY[1]) {
+               if (data->REG_PWM[3]) {
+                       err = device_create_file(dev,
+                                       &sda_max_output[i].dev_attr);
+                       if (err)
+                               goto exit_remove;
+               }
+               if (data->REG_PWM[4]) {
+                       err = device_create_file(dev,
+                                       &sda_step_output[i].dev_attr);
+                       if (err)
+                               goto exit_remove;
+               }
+               if (data->REG_PWM[6]) {
                        err = device_create_file(dev,
                                        &sda_weight_duty_base[i].dev_attr);
                        if (err)
@@ -3447,11 +3592,11 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
                err = device_create_file(dev, &sda_temp_type[i].dev_attr);
                if (err)
                        goto exit_remove;
-               err = device_create_file(dev,
-                                        &sda_temp_offset[i].dev_attr);
+               err = device_create_file(dev, &sda_temp_offset[i].dev_attr);
                if (err)
                        goto exit_remove;
-               if (i >= NUM_TEMP_ALARM)
+               if (i >= NUM_TEMP_ALARM ||
+                   data->ALARM_BITS[TEMP_ALARM_BASE + i] < 0)
                        continue;
                err = device_create_file(dev, &sda_temp_alarm[i].dev_attr);
                if (err)
@@ -3459,7 +3604,7 @@ static int __devinit nct6775_probe(struct platform_device *pdev)
        }
 
        for (i = 0; i < ARRAY_SIZE(sda_caseopen); i++) {
-               if (!data->CASEOPEN_MASK[i])
+               if (data->ALARM_BITS[INTRUSION_ALARM_BASE + i] < 0)
                        continue;
                err = device_create_file(dev, &sda_caseopen[i].dev_attr);
                if (err)
@@ -3558,8 +3703,7 @@ static int __init nct6775_find(int sioaddr, unsigned short *addr,
        /* Activate logical device if needed */
        val = superio_inb(sioaddr, SIO_REG_ENABLE);
        if (!(val & 0x01)) {
-               pr_warn("Forcibly enabling Super-I/O. "
-                       "Sensor is probably unusable.\n");
+               pr_warn("Forcibly enabling Super-I/O. Sensor is probably unusable.\n");
                superio_outb(sioaddr, SIO_REG_ENABLE, val | 0x01);
        }