]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/acl.c
Fix memory leak.
[openldap] / servers / slapd / acl.c
index fcd202b1506d2213c4b91d2779a2742960c5c5c3..31b1b80e9ca256c638bb4a4ab3809d6f7529609d 100644 (file)
@@ -1,7 +1,7 @@
 /* acl.c - routines to parse and check acl's */
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-1999 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
 static AccessControl * acl_get(
        AccessControl *ac, int *count,
        Backend *be, Operation *op,
-       Entry *e, char *attr,
+       Entry *e,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription *desc,
+#else
+       const char *desc,
+#endif
        int nmatches, regmatch_t *matches );
 
 static slap_control_t acl_mask(
        AccessControl *ac, slap_access_mask_t *mask,
        Backend *be, Connection *conn, Operation *op,
-       Entry *e, char *attr, struct berval *val,
+       Entry *e,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription *desc,
+#else
+       const char *desc,
+#endif
+       struct berval *val,
        regmatch_t *matches );
 
 #ifdef SLAPD_ACI_ENABLED
-static int aci_access_allowed(
+static int aci_mask(
        Backend *be,
        Operation *op,
-       Entry *e, char *attr, struct berval *aci,
-       regmatch_t *matches );
+       Entry *e,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription *desc,
+#else
+       const char *desc,
+#endif
+       struct berval *val,
+       struct berval *aci,
+       regmatch_t *matches,
+       slap_access_t *grant,
+       slap_access_t *deny );
 #endif
 
-static int     regex_matches(char *pat, char *str, char *buf, regmatch_t *matches);
-static void    string_expand(char *newbuf, int bufsiz, char *pattern,
-                             char *match, regmatch_t *matches);
+static int     regex_matches(
+       char *pat, char *str, char *buf, regmatch_t *matches);
+static void    string_expand(
+       char *newbuf, int bufsiz, char *pattern,
+       char *match, regmatch_t *matches);
 
 
 /*
@@ -61,16 +83,28 @@ access_allowed(
     Connection         *conn,
     Operation          *op,
     Entry              *e,
-    char               *attr,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription    *desc,
+#else
+    const char         *desc,
+#endif
     struct berval      *val,
-    slap_access_t      access
-)
+    slap_access_t      access )
 {
        int                             count;
        AccessControl   *a;
+#ifdef LDAP_DEBUG
+       char accessmaskbuf[ACCESSMASK_MAXLEN];
+#endif
        slap_access_mask_t mask;
        slap_control_t control;
 
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       const char *attr = desc ? desc->ad_cname->bv_val : NULL;
+#else
+    const char *attr = desc;
+#endif
+
        regmatch_t       matches[MAXREMATCHES];
 
        Debug( LDAP_DEBUG_ACL,
@@ -91,8 +125,17 @@ access_allowed(
                return 1;
        }
 
-       /* no user modify operational attributes are ignored by ACL checking */
-       if ( oc_check_no_usermod_attr( attr ) ) {
+       /*
+        * no-user-modification operational attributes are ignored
+        * by ACL_WRITE checking as any found here are not provided
+        * by the user
+        */
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       if ( access >= ACL_WRITE && is_at_no_user_mod( desc->ad_type ) )
+#else
+       if ( access >= ACL_WRITE && oc_check_op_no_usermod_attr( attr ) )
+#endif
+       {
                Debug( LDAP_DEBUG_ACL, "NoUserMod Operational attribute:"
                        " %s access granted\n",
                        attr, 0, 0 );
@@ -128,7 +171,7 @@ access_allowed(
        a = NULL;
        count = 0;
 
-       while( a = acl_get( a, &count, be, op, e, attr, MAXREMATCHES, matches ) )
+       while( a = acl_get( a, &count, be, op, e, desc, MAXREMATCHES, matches ) )
        {
                int i;
 
@@ -146,7 +189,7 @@ access_allowed(
                }
 
                control = acl_mask( a, &mask, be, conn, op,
-                       e, attr, val, matches );
+                       e, desc, val, matches );
 
                if ( control != ACL_BREAK ) {
                        break;
@@ -171,7 +214,7 @@ access_allowed(
                "=> access_allowed: %s access %s by %s\n",
                access2str( access ),
                ACL_GRANT(mask, access) ? "granted" : "denied",
-               accessmask2str( mask ) );
+               accessmask2str( mask, accessmaskbuf ) );
 
        return ACL_GRANT(mask, access);
 }
@@ -189,16 +232,24 @@ acl_get(
     Backend            *be,
     Operation  *op,
     Entry              *e,
-    char               *attr,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription *desc,
+#else
+    const char *desc,
+#endif
     int                        nmatch,
-    regmatch_t *matches
-)
+    regmatch_t *matches )
 {
-       AccessControl   *next;
-
+       const char *attr;
        assert( e != NULL );
        assert( count != NULL );
 
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       attr = desc ? desc->ad_cname->bv_val : NULL;
+#else
+       attr = desc;
+#endif
+
        if( a == NULL ) {
                if( be == NULL ) {
                        a = global_acl;
@@ -229,7 +280,8 @@ acl_get(
                }
 
                if ( a->acl_filter != NULL ) {
-                       if ( test_filter( NULL, NULL, NULL, e, a->acl_filter ) != 0 ) {
+                       ber_int_t rc = test_filter( NULL, NULL, NULL, e, a->acl_filter );
+                       if ( rc != LDAP_COMPARE_TRUE ) {
                                continue;
                        }
                }
@@ -238,7 +290,7 @@ acl_get(
                        *count, attr, 0);
 
                if ( attr == NULL || a->acl_attrs == NULL ||
-                       charray_inlist( a->acl_attrs, attr ) )
+                       ad_inlist( desc, a->acl_attrs ) )
                {
                        Debug( LDAP_DEBUG_ACL,
                                "<= acl_get: [%d] acl %s attr: %s\n",
@@ -270,13 +322,25 @@ acl_mask(
     Connection *conn,
     Operation  *op,
     Entry              *e,
-    char               *attr,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription *desc,
+#else
+    const char *desc,
+#endif
     struct berval      *val,
        regmatch_t      *matches
 )
 {
        int             i;
        Access  *b;
+#ifdef LDAP_DEBUG
+       char accessmaskbuf[ACCESSMASK_MAXLEN];
+#endif
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       const char *attr = desc ? desc->ad_cname->bv_val : NULL;
+#else
+       const char *attr = desc;
+#endif
 
        assert( a != NULL );
        assert( mask != NULL );
@@ -289,7 +353,7 @@ acl_mask(
                "=> acl_mask: to value \"%s\" by \"%s\", (%s) \n",
                val ? val->bv_val : "*",
                op->o_ndn ?  op->o_ndn : "",
-               accessmask2str( *mask ) );
+               accessmask2str( *mask, accessmaskbuf ) );
 
        for ( i = 1, b = a->acl_access; b != NULL; b = b->a_next, i++ ) {
                slap_access_mask_t oldmask, modmask;
@@ -305,12 +369,17 @@ acl_mask(
                         * user is bound as somebody in the same namespace as
                         * the entry, OR the given dn matches the dn pattern
                         */
-                       if ( strcasecmp( b->a_dn_pat, "anonymous" ) == 0 ) {
+                       if ( strcmp( b->a_dn_pat, "anonymous" ) == 0 ) {
                                if (op->o_ndn != NULL && op->o_ndn[0] != '\0' ) {
                                        continue;
                                }
 
-                       } else if ( strcasecmp( b->a_dn_pat, "self" ) == 0 ) {
+                       } else if ( strcmp( b->a_dn_pat, "users" ) == 0 ) {
+                               if (op->o_ndn == NULL || op->o_ndn[0] == '\0' ) {
+                                       continue;
+                               }
+
+                       } else if ( strcmp( b->a_dn_pat, "self" ) == 0 ) {
                                if( op->o_ndn == NULL || op->o_ndn[0] == '\0' ) {
                                        continue;
                                }
@@ -319,10 +388,13 @@ acl_mask(
                                        continue;
                                }
 
-                       } else if ( strcmp( b->a_dn_pat, ".*" ) != 0 &&
-                               !regex_matches( b->a_dn_pat, op->o_ndn, e->e_ndn, matches ) )
-                       {
-                               continue;
+                       } else if ( strcmp( b->a_dn_pat, "*" ) != 0 ) {
+                               int ret = regex_matches( b->a_dn_pat,
+                                       op->o_ndn, e->e_ndn, matches );
+
+                               if( ret == 0 ) {
+                                       continue;
+                               }
                        }
                }
 
@@ -330,7 +402,7 @@ acl_mask(
                        Debug( LDAP_DEBUG_ACL, "<= check a_sockurl_pat: %s\n",
                                b->a_sockurl_pat, 0, 0 );
 
-                       if ( strcmp( b->a_sockurl_pat, ".*" ) != 0 &&
+                       if ( strcmp( b->a_sockurl_pat, "*" ) != 0 &&
                                !regex_matches( b->a_sockurl_pat, conn->c_listener_url,
                                e->e_ndn, matches ) ) 
                        {
@@ -342,7 +414,7 @@ acl_mask(
                        Debug( LDAP_DEBUG_ACL, "<= check a_domain_pat: %s\n",
                                b->a_domain_pat, 0, 0 );
 
-                       if ( strcmp( b->a_domain_pat, ".*" ) != 0 &&
+                       if ( strcmp( b->a_domain_pat, "*" ) != 0 &&
                                !regex_matches( b->a_domain_pat, conn->c_peer_domain,
                                e->e_ndn, matches ) ) 
                        {
@@ -354,7 +426,7 @@ acl_mask(
                        Debug( LDAP_DEBUG_ACL, "<= check a_peername_path: %s\n",
                                b->a_peername_pat, 0, 0 );
 
-                       if ( strcmp( b->a_peername_pat, ".*" ) != 0 &&
+                       if ( strcmp( b->a_peername_pat, "*" ) != 0 &&
                                !regex_matches( b->a_peername_pat, conn->c_peer_name,
                                e->e_ndn, matches ) )
                        {
@@ -366,7 +438,7 @@ acl_mask(
                        Debug( LDAP_DEBUG_ACL, "<= check a_sockname_path: %s\n",
                                b->a_sockname_pat, 0, 0 );
 
-                       if ( strcmp( b->a_sockname_pat, ".*" ) != 0 &&
+                       if ( strcmp( b->a_sockname_pat, "*" ) != 0 &&
                                !regex_matches( b->a_sockname_pat, conn->c_sock_name,
                                e->e_ndn, matches ) )
                        {
@@ -377,6 +449,13 @@ acl_mask(
                if ( b->a_dn_at != NULL && op->o_ndn != NULL ) {
                        Attribute       *at;
                        struct berval   bv;
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+                       int match;
+                       const char *text;
+                       const char *desc = b->a_dn_at->ad_cname->bv_val;
+#else
+                       const char *desc = b->a_dn_at;
+#endif
 
                        Debug( LDAP_DEBUG_ACL, "<= check a_dn_at: %s\n",
                                b->a_dn_at, 0, 0);
@@ -384,22 +463,54 @@ acl_mask(
                        bv.bv_val = op->o_ndn;
                        bv.bv_len = strlen( bv.bv_val );
 
-                       /* see if asker is listed in dnattr */ 
+                       /* see if asker is listed in dnattr */
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+                       for( at = attrs_find( e->e_attrs, b->a_dn_at );
+                               at == NULL;
+                               at = attrs_find( e->e_attrs->a_next, b->a_dn_at ) )
+                       {
+                               if( value_find( b->a_dn_at, at->a_vals, &bv ) == 0 ) {
+                                       /* found it */
+                                       match = 1;
+                                       break;
+                               }
+                       }
+
+                       if( match ) {
+                               if ( b->a_dn_self && (val == NULL
+                                       || value_match( &match, b->a_dn_at,
+                                               b->a_dn_at->ad_type->sat_equality, val, &bv, &text ) )
+                                               != LDAP_SUCCESS
+                                       || match )
+                               {
+                                       continue;
+                               }
+                       } else if ( ! b->a_dn_self || val == NULL
+                               || value_match( &match, b->a_dn_at,
+                                       b->a_dn_at->ad_type->sat_equality, val, &bv, &text )
+                                       != LDAP_SUCCESS
+                               || match )
+                       {
+                               continue;
+                       }
+#else
+                       /* see if asker is listed in dnattr */
                        if ( (at = attr_find( e->e_attrs, b->a_dn_at )) != NULL &&
                                value_find( at->a_vals, &bv, at->a_syntax, 3 ) == 0 )
                        {
-                               if ( b->a_dn_self && 
-                                       (val == NULL || value_cmp( &bv, val, at->a_syntax, 2 )) )
+                               if ( b->a_dn_self && (val == NULL
+                                       || value_cmp( &bv, val, at->a_syntax, 2 ) ) )
                                {
                                        continue;
                                }
 
                        /* asker not listed in dnattr - check for self access */
-                       } else if ( ! b->a_dn_self || val == NULL ||
-                               value_cmp( &bv, val, at->a_syntax, 2 ) != 0 )
+                       } else if ( ! b->a_dn_self || val == NULL
+                               || value_cmp( &bv, val, at->a_syntax, 2 ) != 0 )
                        {
                                continue;
                        }
+#endif
                }
 
                if ( b->a_group_pat != NULL && op->o_ndn != NULL ) {
@@ -426,6 +537,7 @@ acl_mask(
 #ifdef SLAPD_ACI_ENABLED
                if ( b->a_aci_at != NULL ) {
                        Attribute       *at;
+                       slap_access_t grant, deny, tgrant, tdeny;
 
                        /* this case works different from the others above.
                         * since aci's themselves give permissions, we need
@@ -440,10 +552,10 @@ acl_mask(
                                continue;
                        }
 
-                       /* first check if the right being requested is
-                        * higher than allowed by the ACL clause.
+                       /* first check if the right being requested
+                        * is allowed by the ACL clause.
                         */
-                       if ( ! ACL_GRANT( b->a_mask, access ) ) {
+                       if ( ! ACL_GRANT( b->a_mask, *mask ) ) {
                                continue;
                        }
 
@@ -453,26 +565,51 @@ acl_mask(
                                continue;
                        }
 
+                       /* start out with nothing granted, nothing denied */
+                       ACL_INIT(tgrant);
+                       ACL_INIT(tdeny);
+
                        /* the aci is an multi-valued attribute.  The
                         * rights are determined by OR'ing the individual
                         * rights given by the acis.
                         */
                        for ( i = 0; at->a_vals[i] != NULL; i++ ) {
-                               if ( aci_access_allowed( be, op,
-                                       e, attr, at->a_vals[i],
-                                       matches ) )
+                               if (aci_mask( be, op,
+                                       e, desc, val, at->a_vals[i],
+                                       matches, &grant, &deny ) != 0)
                                {
-                                       Debug( LDAP_DEBUG_ACL,
-                                               "<= acl_mask: matched by clause #%d access granted\n",
-                                               i, 0, 0 );
-                                       break;
+                                       tgrant |= grant;
+                                       tdeny |= deny;
                                }
                        }
 
-                       if( ACL_IS_INVALID( modmask ) ) { 
+                       /* remove anything that the ACL clause does not allow */
+                       tgrant &= b->a_mask & ACL_PRIV_MASK;
+                       tdeny &= ACL_PRIV_MASK;
+
+                       /* see if we have anything to contribute */
+                       if( ACL_IS_INVALID(tgrant) && ACL_IS_INVALID(tdeny) ) { 
                                continue;
                        }
 
+                       /* this could be improved by changing acl_mask so that it can deal with
+                        * by clauses that return grant/deny pairs.  Right now, it does either
+                        * additive or subtractive rights, but not both at the same time.  So,
+                        * we need to combine the grant/deny pair into a single rights mask in
+                        * a smart way:  if either grant or deny is "empty", then we use the
+                        * opposite as is, otherwise we remove any denied rights from the grant
+                        * rights mask and construct an additive mask.
+                        */
+                       if (ACL_IS_INVALID(tdeny)) {
+                               modmask = tgrant | ACL_PRIV_ADDITIVE;
+
+                       } else if (ACL_IS_INVALID(tgrant)) {
+                               modmask = tdeny | ACL_PRIV_SUBSTRACTIVE;
+
+                       } else {
+                               modmask = (tgrant & ~tdeny) | ACL_PRIV_ADDITIVE;
+                       }
+
                } else
 #endif
                {
@@ -482,7 +619,7 @@ acl_mask(
 
                Debug( LDAP_DEBUG_ACL,
                        "<= acl_mask: [%d] applying %s (%s)\n",
-                       i, accessmask2str( modmask ), 
+                       i, accessmask2str( modmask, accessmaskbuf ), 
                        b->a_type == ACL_CONTINUE
                                ? "continue"
                                : b->a_type == ACL_BREAK
@@ -512,8 +649,8 @@ acl_mask(
                }
 
                Debug( LDAP_DEBUG_ACL,
-                       "<= acl_mask: [%d] old: %s new: %s\n",
-                       i, accessmask2str(oldmask), accessmask2str(*mask));
+                       "<= acl_mask: [%d] mask: %s\n",
+                       i, accessmask2str(*mask, accessmaskbuf), 0 );
 
                if( b->a_type == ACL_CONTINUE ) {
                        continue;
@@ -528,7 +665,7 @@ acl_mask(
 
        Debug( LDAP_DEBUG_ACL,
                "<= acl_mask: no more <who> clauses, returning %s (stop)\n",
-               accessmask2str(*mask), 0, 0 );
+               accessmask2str(*mask, accessmaskbuf), 0, 0 );
        return ACL_STOP;
 }
 
@@ -545,7 +682,7 @@ acl_check_modlist(
     Connection *conn,
     Operation  *op,
     Entry      *e,
-    LDAPModList        *mlist
+    Modifications      *mlist
 )
 {
        int             i;
@@ -582,26 +719,37 @@ acl_check_modlist(
 #endif
        }
 
-       for ( ; mlist != NULL; mlist = mlist->ml_next ) {
-               regmatch_t       matches[MAXREMATCHES];
-
-               /* the lastmod attributes are ignored by ACL checking */
-               if ( oc_check_no_usermod_attr( mlist->ml_type ) ) {
-                       Debug( LDAP_DEBUG_ACL, "Operational attribute: %s access allowed\n",
-                               mlist->ml_type, 0, 0 );
+       for ( ; mlist != NULL; mlist = mlist->sml_next ) {
+               /*
+                * no-user-modification operational attributes are ignored
+                * by ACL_WRITE checking as any found here are not provided
+                * by the user
+                */
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+               if ( is_at_no_user_mod( mlist->sml_desc->ad_type ) ) {
+                       Debug( LDAP_DEBUG_ACL, "acl: no-user-mod %s:"
+                               " modify access granted\n",
+                               mlist->sml_desc->ad_cname->bv_val, 0, 0 );
+                       continue;
+               }
+#else
+               if ( oc_check_op_no_usermod_attr( mlist->sml_type ) ) {
+                       Debug( LDAP_DEBUG_ACL, "acl: no-user-mod %s:"
+                               " modify access granted\n",
+                               mlist->sml_type, 0, 0 );
                        continue;
                }
+#endif
 
-               switch ( mlist->ml_op & ~LDAP_MOD_BVALUES ) {
+               switch ( mlist->sml_op ) {
                case LDAP_MOD_REPLACE:
                case LDAP_MOD_ADD:
-                       if ( mlist->ml_bvalues == NULL ) {
+                       if ( mlist->sml_bvalues == NULL ) {
                                break;
                        }
-                       for ( i = 0; mlist->ml_bvalues[i] != NULL; i++ ) {
+                       for ( i = 0; mlist->sml_bvalues[i] != NULL; i++ ) {
                                if ( ! access_allowed( be, conn, op, e,
-                                       mlist->ml_type, mlist->ml_bvalues[i],
-                                       ACL_WRITE ) )
+                                       mlist->sml_desc, mlist->sml_bvalues[i], ACL_WRITE ) )
                                {
                                        return( 0 );
                                }
@@ -609,19 +757,17 @@ acl_check_modlist(
                        break;
 
                case LDAP_MOD_DELETE:
-                       if ( mlist->ml_bvalues == NULL ) {
+                       if ( mlist->sml_bvalues == NULL ) {
                                if ( ! access_allowed( be, conn, op, e,
-                                       mlist->ml_type, NULL, 
-                                       ACL_WRITE ) )
+                                       mlist->sml_desc, NULL, ACL_WRITE ) )
                                {
                                        return( 0 );
                                }
                                break;
                        }
-                       for ( i = 0; mlist->ml_bvalues[i] != NULL; i++ ) {
+                       for ( i = 0; mlist->sml_bvalues[i] != NULL; i++ ) {
                                if ( ! access_allowed( be, conn, op, e,
-                                       mlist->ml_type, mlist->ml_bvalues[i],
-                                       ACL_WRITE ) )
+                                       mlist->sml_desc, mlist->sml_bvalues[i], ACL_WRITE ) )
                                {
                                        return( 0 );
                                }
@@ -635,7 +781,7 @@ acl_check_modlist(
 
 #ifdef SLAPD_ACI_ENABLED
 static char *
-aci_bvstrdup (struct berval *bv)
+aci_bvstrdup( struct berval *bv )
 {
        char *s;
 
@@ -648,7 +794,9 @@ aci_bvstrdup (struct berval *bv)
 }
 
 static int
-aci_strbvcmp (char *s, struct berval *bv)
+aci_strbvcmp(
+       const char *s,
+       struct berval *bv )
 {
        int res, len;
 
@@ -656,15 +804,19 @@ aci_strbvcmp (char *s, struct berval *bv)
        if (res)
                return(res);
        len = strlen(s);
-       if (len > bv->bv_len)
+       if (len > (int)bv->bv_len)
                return(1);
-       if (len < bv->bv_len)
+       if (len < (int)bv->bv_len)
                return(-1);
        return(0);
 }
 
 static int
-aci_get_part (struct berval *list, int ix, char sep, struct berval *bv)
+aci_get_part(
+       struct berval *list,
+       int ix,
+       char sep,
+       struct berval *bv )
 {
        int len;
        char *p;
@@ -699,21 +851,20 @@ aci_get_part (struct berval *list, int ix, char sep, struct berval *bv)
 }
 
 static int
-aci_list_has_right(
-       struct berval *list,
-       slap_access_t access,
-       int action)
+aci_list_map_rights(
+       struct berval *list )
 {
        struct berval bv;
+       slap_access_t mask;
        int i;
-       slap_access_t right;
 
+       ACL_INIT(mask);
        for (i = 0; aci_get_part(list, i, ',', &bv) >= 0; i++) {
                if (bv.bv_len <= 0)
                        continue;
                switch (*bv.bv_val) {
                case 'c':
-                       right = ACL_COMPARE;
+                       ACL_PRIV_SET(mask, ACL_PRIV_COMPARE);
                        break;
                case 's':
                        /* **** NOTE: draft-ietf-ldapext-aci-model-0.3.txt defines
@@ -721,125 +872,143 @@ aci_list_has_right(
                         * that the right 's' means "search".  The latter definition
                         * is used here.
                         */
-                       right = ACL_SEARCH;
+                       ACL_PRIV_SET(mask, ACL_PRIV_SEARCH);
                        break;
                case 'r':
-                       right = ACL_READ;
+                       ACL_PRIV_SET(mask, ACL_PRIV_READ);
                        break;
                case 'w':
-                       right = ACL_WRITE;
+                       ACL_PRIV_SET(mask, ACL_PRIV_WRITE);
                        break;
                case 'x':
                        /* **** NOTE: draft-ietf-ldapext-aci-model-0.3.txt does not 
                         * define any equivalent to the AUTH right, so I've just used
                         * 'x' for now.
                         */
-                       right = ACL_AUTH;
+                       ACL_PRIV_SET(mask, ACL_PRIV_AUTH);
                        break;
                default:
-                       right = 0;
                        break;
                }
 
-#ifdef SLAPD_ACI_DISCRETE_RIGHTS
-               if (right & access) {
-                       return(action);
-               }
-#else
-               if (action != 0) {
-                       /* check granted */
-                       if (ACL_GRANT(right, access))
-                               return(1);
-               } else {
-                       /* check denied */
-                       if (right <= access)
-                               return(1);
-               }
-#endif
        }
-
-#ifdef SLAPD_ACI_DISCRETE_RIGHTS
-       return(!action);
-#else
-       return(0);
-#endif
+       return(mask);
 }
 
 static int
-aci_list_has_attr (struct berval *list, char *attr)
+aci_list_has_attr(
+       struct berval *list,
+       const char *attr,
+       struct berval *val )
 {
-       struct berval bv;
+       struct berval bv, left, right;
        int i;
 
        for (i = 0; aci_get_part(list, i, ',', &bv) >= 0; i++) {
-               if (aci_strbvcmp(attr, &bv) == 0) {
-                       return(1);
+               if (aci_get_part(&bv, 0, '=', &left) < 0
+                       || aci_get_part(&bv, 1, '=', &right) < 0)
+               {
+                       if (aci_strbvcmp(attr, &bv) == 0)
+                               return(1);
+               } else if (val == NULL) {
+                       if (aci_strbvcmp(attr, &left) == 0)
+                               return(1);
+               } else {
+                       if (aci_strbvcmp(attr, &left) == 0) {
+                               /* this is experimental code that implements a
+                                * simple (prefix) match of the attribute value.
+                                * the ACI draft does not provide for aci's that
+                                * apply to specific values, but it would be
+                                * nice to have.  If the <attr> part of an aci's
+                                * rights list is of the form <attr>=<value>,
+                                * that means the aci applies only to attrs with
+                                * the given value.  Furthermore, if the attr is
+                                * of the form <attr>=<value>*, then <value> is
+                                * treated as a prefix, and the aci applies to 
+                                * any value with that prefix.
+                                *
+                                * Ideally, this would allow r.e. matches.
+                                */
+                               if (aci_get_part(&right, 0, '*', &left) < 0
+                                       || right.bv_len <= left.bv_len)
+                               {
+                                       if (aci_strbvcmp(val->bv_val, &right) == 0)
+                                               return(1);
+                               } else if (val->bv_len >= left.bv_len) {
+                                       if (strncasecmp( val->bv_val, left.bv_val, left.bv_len ) == 0)
+                                               return(1);
+                               }
+                       }
                }
        }
        return(0);
 }
 
-static int
-aci_list_has_attr_right (struct berval *list, char *attr, int access, int action)
+static slap_access_t
+aci_list_get_attr_rights(
+       struct berval *list,
+       const char *attr,
+       struct berval *val )
 {
     struct berval bv;
-    int i, found;
+    slap_access_t mask;
+    int i;
 
        /* loop through each rights/attr pair, skip first part (action) */
-       found = -1;
+       ACL_INIT(mask);
        for (i = 1; aci_get_part(list, i + 1, ';', &bv) >= 0; i += 2) {
-               if (aci_list_has_attr(&bv, attr) == 0)
+               if (aci_list_has_attr(&bv, attr, val) == 0)
                        continue;
-               found = 0;
                if (aci_get_part(list, i, ';', &bv) < 0)
                        continue;
-               if (aci_list_has_right(&bv, access, action) != 0)
-                       return(1);
+               mask |= aci_list_map_rights(&bv);
        }
-       return(found);
+       return(mask);
 }
 
 static int
-aci_list_has_permission(
+aci_list_get_rights(
        struct berval *list,
-       char *attr,
-       slap_access_t access)
+       const char *attr,
+       struct berval *val,
+       slap_access_t *grant,
+       slap_access_t *deny )
 {
     struct berval perm, actn;
-    int i, action, specific, general;
+    slap_access_t *mask;
+    int i, found;
 
        if (attr == NULL || *attr == 0 || strcasecmp(attr, "entry") == 0) {
                attr = "[entry]";
        }
 
+       found = 0;
+       ACL_INIT(*grant);
+       ACL_INIT(*deny);
        /* loop through each permissions clause */
        for (i = 0; aci_get_part(list, i, '$', &perm) >= 0; i++) {
                if (aci_get_part(&perm, 0, ';', &actn) < 0)
                        continue;
                if (aci_strbvcmp( "grant", &actn ) == 0) {
-                       action = 1;
+                       mask = grant;
                } else if (aci_strbvcmp( "deny", &actn ) == 0) {
-                       action = 0;
+                       mask = deny;
                } else {
                        continue;
                }
 
-               specific = aci_list_has_attr_right(&perm, attr, access, action);
-               if (specific >= 0)
-                       return(specific);
-
-               general = aci_list_has_attr_right(&perm, "[all]", access, action);
-               if (general >= 0)
-                       return(general);
+               found = 1;
+               *mask |= aci_list_get_attr_rights(&perm, attr, val);
+               *mask |= aci_list_get_attr_rights(&perm, "[all]", NULL);
        }
-       return(0);
+       return(found);
 }
 
 static int
 aci_group_member (
        struct berval *subj,
-       char *grpoc,
-       char *grpat,
+       const char *defgrpoc,
+       const char *defgrpat,
     Backend            *be,
     Entry              *e,
     Operation          *op,
@@ -847,71 +1016,100 @@ aci_group_member (
 )
 {
        struct berval bv;
-       char *subjdn, *grpdn;
-       int rc = 0;
+       char *subjdn, *grpdn = NULL;
+       char *grpoc;
+       char *grpat;
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       ObjectClass *grp_oc = NULL;
+       AttributeDescription *grp_ad = NULL;
+       char *text;
+#else
+       char *grp_oc;
+       char *grp_ad;
+#endif
+       int rc;
 
        /* format of string is "group/objectClassValue/groupAttrName" */
-       if (aci_get_part(subj, 0, '/', &bv) < 0)
+       if (aci_get_part(subj, 0, '/', &bv) < 0) {
                return(0);
+       }
+
        subjdn = aci_bvstrdup(&bv);
-       if (subjdn == NULL)
+       if (subjdn == NULL) {
                return(0);
+       }
 
-       if (aci_get_part(subj, 1, '/', &bv) < 0)
-               grpoc = ch_strdup(grpoc);
-       else
+       if (aci_get_part(subj, 1, '/', &bv) < 0) {
+               grpoc = ch_strdup( defgrpoc );
+       } else {
                grpoc = aci_bvstrdup(&bv);
+       }
 
-       if (aci_get_part(subj, 2, '/', &bv) < 0)
-               grpat = ch_strdup(grpat);
-       else
+       if (aci_get_part(subj, 2, '/', &bv) < 0) {
+               grpat = ch_strdup( defgrpat );
+       } else {
                grpat = aci_bvstrdup(&bv);
+       }
+
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       rc = slap_str2ad( grpat, &grp_ad, &text );
+       if( rc != LDAP_SUCCESS ) {
+               rc = 0;
+               goto done;
+       }
+#else
+       grp_ad = grpat;
+#endif
+       rc = 0;
 
        grpdn = (char *)ch_malloc(1024);
-       if (grpoc != NULL && grpat != NULL && grpdn != NULL) {
+
+       if (grp_oc != NULL && grp_ad != NULL && grpdn != NULL) {
                string_expand(grpdn, 1024, subjdn, e->e_ndn, matches);
                if ( dn_normalize(grpdn) != NULL ) {
-                       rc = (backend_group(be, e, grpdn, op->o_ndn, grpoc, grpat) == 0);
+                       rc = (backend_group(be, e, grpdn, op->o_ndn, grp_oc, grp_ad) == 0);
                }
-               ch_free(grpdn);
        }
-       if (grpat != NULL)
-               ch_free(grpat);
-       if (grpoc != NULL)
-               ch_free(grpoc);
+
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+done:
+       if( grp_ad != NULL ) ad_free( grp_ad, 1 );
+#endif
+       ch_free(grpdn);
+       ch_free(grpat);
+       ch_free(grpoc);
        ch_free(subjdn);
        return(rc);
 }
 
 static int
-aci_access_allowed (
-    struct berval      *aci,
-    char                       *attr,
+aci_mask(
     Backend                    *be,
-    Entry                      *e,
     Operation          *op,
-    slap_access_t      access,
-       regmatch_t              *matches
+    Entry                      *e,
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       AttributeDescription *desc,
+#else
+    const char         *attr,
+#endif
+    struct berval      *val,
+    struct berval      *aci,
+       regmatch_t              *matches,
+       slap_access_t   *grant,
+       slap_access_t   *deny
 )
 {
     struct berval bv, perms, sdn;
     char *subjdn;
-       int rc;
-
-       Debug( LDAP_DEBUG_ACL,
-               "=> aci_access_allowed: %s access to entry \"%s\"\n",
-               access2str( access ), e->e_dn, 0 );
-
-       Debug( LDAP_DEBUG_ACL,
-               "=> aci_access_allowed: %s access to attribute \"%s\" by \"%s\"\n",
-           access2str( access ),
-               attr,
-               op->o_ndn ? op->o_ndn : "" );
+       int rc, i;
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+       char *attr;
+#endif
 
        /* parse an aci of the form:
                oid#scope#action;rights;attr;rights;attr$action;rights;attr;rights;attr#dnType#subjectDN
 
-          See draft-ietf-ldapext-aci-model-0.3.txt section 9.1 for
+          See draft-ietf-ldapext-aci-model-04.txt section 9.1 for
           a full description of the format for this attribute.
 
           For now, this routine only supports scope=entry.
@@ -921,6 +1119,10 @@ aci_access_allowed (
        if (aci_get_part(aci, 4, '#', NULL) < 0)
                return(0);
 
+       /* check that the aci family is supported */
+       if (aci_get_part(aci, 0, '#', &bv) < 0)
+               return(0);
+
        /* check that the scope is "entry" */
        if (aci_get_part(aci, 1, '#', &bv) < 0
                || aci_strbvcmp( "entry", &bv ) != 0)
@@ -933,7 +1135,7 @@ aci_access_allowed (
                return(0);
 
        /* check if any permissions allow desired access */
-       if (aci_list_has_permission(&perms, attr, access) == 0)
+       if (aci_list_get_rights(&perms, attr, val, grant, deny) == 0)
                return(0);
 
        /* see if we have a DN match */
@@ -942,31 +1144,81 @@ aci_access_allowed (
 
        if (aci_get_part(aci, 4, '#', &sdn) < 0)
                return(0);
+
        if (aci_strbvcmp( "access-id", &bv ) == 0) {
                subjdn = aci_bvstrdup(&sdn);
                if (subjdn == NULL)
                        return(0);
-               rc = 0;
+               rc = 1;
                if ( dn_normalize(subjdn) != NULL )
-                       rc = (strcasecmp(op->o_ndn, subjdn) == 0);
+                       if (strcasecmp(op->o_ndn, subjdn) != 0)
+                               rc = 0;
                ch_free(subjdn);
                return(rc);
        }
 
        if (aci_strbvcmp( "self", &bv ) == 0) {
-               return(strcasecmp(op->o_ndn, e->e_ndn) == 0);
-       }
+               if (strcasecmp(op->o_ndn, e->e_ndn) == 0)
+                       return(1);
 
-       if (aci_strbvcmp( "group", &bv ) == 0) {
-               return(aci_group_member(&sdn, "groupOfNames", "member", be, e, op, matches));
-       }
+       } else if (aci_strbvcmp( "dnattr", &bv ) == 0) {
+               char *dnattr = aci_bvstrdup(&sdn);
+#ifdef SLAPD_SCHEMA_NOT_COMPAT
+               Attribute *at;
+               AttributeDescription *ad = NULL;
+               const char *text;
+
+               rc = slap_str2ad( dnattr, &ad, &text );
+               ch_free( dnattr );
+
+               if( rc != LDAP_SUCCESS ) {
+                       return 0;
+               }
+
+               rc = 0;
+
+               bv.bv_val = op->o_ndn;
+               bv.bv_len = strlen( bv.bv_val );
+
+               for(at = attrs_find( e->e_attrs, ad );
+                       at != NULL;
+                       at = attrs_find( at->a_next, ad ) )
+               {
+                       if (value_find( ad, at->a_vals, &bv) == 0 ) {
+                               rc = 1;
+                               break;
+                       }
+               }
+
+               ad_free( ad, 1 );
+               return rc;
 
-       if (aci_strbvcmp( "role", &bv ) == 0) {
-               return(aci_group_member(&sdn, "organizationalRole", "roleOccupant", be, e, op, matches));
+#else
+               Attribute *at;
+               at = attr_find( e->e_attrs, dnattr );
+               ch_free( dnattr );
+
+               if (at != NULL) {
+                       bv.bv_val = op->o_ndn;
+                       bv.bv_len = strlen( bv.bv_val );
+
+                       if (value_find( at->a_vals, &bv, at->a_syntax, 3 ) == 0 )
+                               return(1);
+               }
+#endif
+
+       } else if (aci_strbvcmp( "group", &bv ) == 0) {
+               if (aci_group_member(&sdn, SLAPD_GROUP_CLASS, SLAPD_GROUP_ATTR, be, e, op, matches))
+                       return(1);
+
+       } else if (aci_strbvcmp( "role", &bv ) == 0) {
+               if (aci_group_member(&sdn, SLAPD_ROLE_CLASS, SLAPD_ROLE_ATTR, be, e, op, matches))
+                       return(1);
        }
 
        return(0);
 }
+
 #endif /* SLAPD_ACI_ENABLED */
 
 static void
@@ -984,6 +1236,7 @@ string_expand(
 
        size = 0;
        newbuf[0] = '\0';
+       bufsiz--; /* leave space for lone $ */
 
        flag = 0;
        for ( dp = newbuf, sp = pat; size < bufsiz && *sp ; sp++) {
@@ -1017,6 +1270,13 @@ string_expand(
                        }
                }
        }
+
+       if (flag) {
+               /* must have ended with a single $ */
+               *dp++ = '$';
+               size++;
+       }
+
        *dp = '\0';
 
        Debug( LDAP_DEBUG_TRACE, "=> string_expand: pattern:  %s\n", pat, 0, 0 );