]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/acl.c
fix substring_comp_candidates logic if intersection of candidates
[openldap] / servers / slapd / acl.c
index 255cf8954586d524e3ce090cd5babfaf48773b73..6dcdcd50870b045a946c60aa459b3cee572dbfd4 100644 (file)
@@ -55,12 +55,8 @@ access_allowed(
                e->e_dn, attr, 0 );
 
        /* the lastmod attributes are ignored by ACL checking */
-       if ( strcasecmp( attr, "modifiersname" ) == 0 ||
-               strcasecmp( attr, "modifytimestamp" ) == 0 ||
-               strcasecmp( attr, "creatorsname" ) == 0 ||
-               strcasecmp( attr, "createtimestamp" ) == 0 )
-       {
-               Debug( LDAP_DEBUG_ACL, "LASTMOD attribute: %s access allowed\n",
+       if ( oc_check_no_usermod_attr( attr ) ) {
+               Debug( LDAP_DEBUG_ACL, "Operational attribute: %s access allowed\n",
                        attr, 0, 0 );
                return(1);
        }
@@ -107,7 +103,7 @@ acl_get_applicable(
     regmatch_t *matches
 )
 {
-       int             i, j;
+       int             i;
        struct acl      *a;
     char               *edn;
 
@@ -216,7 +212,6 @@ acl_access_allowed(
 )
 {
        int             i;
-       char            *odn;
        struct access   *b;
        Attribute       *at;
        struct berval   bv;
@@ -248,11 +243,9 @@ acl_access_allowed(
                return( default_access >= access );
        }
 
-       odn = op->o_ndn;
-
-       if ( odn != NULL ) {
-               bv.bv_val = odn;
-               bv.bv_len = strlen( odn );
+       if ( op->o_ndn != NULL ) {
+               bv.bv_val = op->o_ndn;
+               bv.bv_len = strlen( bv.bv_val );
        }
 
        for ( i = 1, b = a->acl_access; b != NULL; b = b->a_next, i++ ) {
@@ -264,49 +257,62 @@ acl_access_allowed(
                         * user is bound as somebody in the same namespace as
                         * the entry, OR the given dn matches the dn pattern
                         */
-                       if ( strcasecmp( b->a_dnpat, "self" ) == 0 && 
+                       if ( strcasecmp( b->a_dnpat, "anonymous" ) == 0 && 
+                               (op->o_ndn == NULL || *(op->o_ndn) == '\0' ) ) 
+                       {
+                               Debug( LDAP_DEBUG_ACL,
+                               "<= acl_access_allowed: matched by clause #%d access %s\n",
+                                   i, ACL_GRANT(b->a_access, access)
+                                               ? "granted" : "denied", 0 );
+
+                               return ACL_GRANT(b->a_access, access );
+
+                       } else if ( strcasecmp( b->a_dnpat, "self" ) == 0 && 
                                op->o_ndn != NULL && *(op->o_ndn) && e->e_dn != NULL ) 
                        {
                                if ( strcmp( edn, op->o_ndn ) == 0 ) {
                                        Debug( LDAP_DEBUG_ACL,
                                        "<= acl_access_allowed: matched by clause #%d access %s\n",
-                                           i, (b->a_access & ~ACL_SELF) >=
-                                           access ? "granted" : "denied", 0 );
+                                           i, ACL_GRANT(b->a_access, access)
+                                                       ? "granted" : "denied", 0 );
 
-                                       return( (b->a_access & ~ACL_SELF) >= access );
+                                       return ACL_GRANT(b->a_access, access );
                                }
                        } else {
-                               if ( regex_matches( b->a_dnpat, odn, edn, matches ) ) {
+                               if ( regex_matches( b->a_dnpat, op->o_ndn, edn, matches ) ) {
                                        Debug( LDAP_DEBUG_ACL,
                                    "<= acl_access_allowed: matched by clause #%d access %s\n",
-                                   i, (b->a_access & ~ACL_SELF) >= access ?
-                                           "granted" : "denied", 0 );
+                                   i, ACL_GRANT(b->a_access, access)
+                                               ? "granted" : "denied", 0 );
 
-                                       return( (b->a_access & ~ACL_SELF) >= access );
+                                       return ACL_GRANT(b->a_access, access );
                                }
                        }
                }
                if ( b->a_addrpat != NULL ) {
-                       if ( regex_matches( b->a_addrpat, conn->c_addr, edn, matches ) ) {
+                       if ( regex_matches( b->a_addrpat, conn->c_client_addr,
+                               edn, matches ) )
+                       {
                                Debug( LDAP_DEBUG_ACL,
                                    "<= acl_access_allowed: matched by clause #%d access %s\n",
-                                   i, (b->a_access & ~ACL_SELF) >= access ?
-                                   "granted" : "denied", 0 );
+                                   i, ACL_GRANT(b->a_access, access)
+                                               ? "granted" : "denied", 0 );
 
-                               return( (b->a_access & ~ACL_SELF) >= access );
+                               return ACL_GRANT(b->a_access, access );
                        }
                }
                if ( b->a_domainpat != NULL ) {
                        Debug( LDAP_DEBUG_ARGS, "<= check a_domainpath: %s\n",
                                b->a_domainpat, 0, 0 );
-                       if ( regex_matches( b->a_domainpat, conn->c_domain, edn, matches ) ) 
+                       if ( regex_matches( b->a_domainpat, conn->c_client_name,
+                               edn, matches ) ) 
                        {
                                Debug( LDAP_DEBUG_ACL,
                                    "<= acl_access_allowed: matched by clause #%d access %s\n",
-                                   i, (b->a_access & ~ACL_SELF) >= access ?
-                                   "granted" : "denied", 0 );
+                                   i, ACL_GRANT(b->a_access, access)
+                                               ? "granted" : "denied", 0 );
 
-                               return( (b->a_access & ~ACL_SELF) >= access );
+                               return ACL_GRANT(b->a_access, access );
                        }
                }
                if ( b->a_dnattr != NULL && op->o_ndn != NULL ) {
@@ -316,7 +322,7 @@ acl_access_allowed(
                        if ( (at = attr_find( e->e_attrs, b->a_dnattr )) != NULL && 
                                value_find( at->a_vals, &bv, at->a_syntax, 3 ) == 0 )
                        {
-                               if ( (b->a_access & ACL_SELF) && 
+                               if ( ACL_IS_SELF(b->a_access) && 
                                        (val == NULL || value_cmp( &bv, val, at->a_syntax, 2 )) )
                                {
                                        continue;
@@ -324,14 +330,14 @@ acl_access_allowed(
 
                                Debug( LDAP_DEBUG_ACL,
                                    "<= acl_acces_allowed: matched by clause #%d access %s\n",
-                                   i, (b->a_access & ~ACL_SELF) >= access ?
-                                   "granted" : "denied", 0 );
+                                   i, ACL_GRANT(b->a_access, access)
+                                               ? "granted" : "denied", 0 );
 
-                               return( (b->a_access & ~ACL_SELF) >= access );
+                               return ACL_GRANT(b->a_access, access );
                        }
 
                        /* asker not listed in dnattr - check for self access */
-                       if ( ! (b->a_access & ACL_SELF) || val == NULL ||
+                       if ( ! ACL_IS_SELF(b->a_access) || val == NULL ||
                                value_cmp( &bv, val, at->a_syntax, 2 ) != 0 )
                        {
                                continue;
@@ -339,12 +345,12 @@ acl_access_allowed(
 
                        Debug( LDAP_DEBUG_ACL,
                                "<= acl_access_allowed: matched by clause #%d (self) access %s\n",
-                           i, (b->a_access & ~ACL_SELF) >= access ? "granted"
-                           : "denied", 0 );
+                           i, ACL_GRANT(b->a_access, access)
+                                       ? "granted" : "denied", 0 );
 
-                       return( (b->a_access & ~ACL_SELF) >= access );
+                       return ACL_GRANT(b->a_access, access );
                }
-#ifdef SLAPD_ACLGROUPS
+
                if ( b->a_group != NULL && op->o_ndn != NULL ) {
                        char buf[1024];
 
@@ -356,16 +362,15 @@ acl_access_allowed(
                        string_expand(buf, sizeof(buf), b->a_group, edn, matches);
                        (void) dn_normalize_case(buf);
 
-                       if (be_group(be, e, buf, odn,
-                               b->a_objectclassvalue, b->a_groupattrname) == 0)
+                       if (backend_group(be, e, buf, op->o_ndn,
+                               b->a_group_oc, b->a_group_at) == 0)
                        {
                                Debug( LDAP_DEBUG_ACL,
                                        "<= acl_access_allowed: matched by clause #%d (group) access granted\n",
                                        i, 0, 0 );
-                               return( (b->a_access & ~ACL_SELF) >= access );
+                               return ACL_GRANT(b->a_access, access );
                        }
                }
-#endif /* SLAPD_ACLGROUPS */
        }
 
        Debug( LDAP_DEBUG_ACL,
@@ -400,12 +405,8 @@ acl_check_modlist(
                regmatch_t       matches[MAXREMATCHES];
 
                /* the lastmod attributes are ignored by ACL checking */
-               if ( strcasecmp( mlist->ml_type, "modifiersname" ) == 0 ||
-                       strcasecmp( mlist->ml_type, "modifytimestamp" ) == 0 ||
-                       strcasecmp( mlist->ml_type, "creatorsname" ) == 0 ||
-                       strcasecmp( mlist->ml_type, "createtimestamp" ) == 0 ) 
-               {
-                       Debug( LDAP_DEBUG_ACL, "LASTMOD attribute: %s access allowed\n",
+               if ( oc_check_no_usermod_attr( mlist->ml_type ) ) {
+                       Debug( LDAP_DEBUG_ACL, "Operational attribute: %s access allowed\n",
                                mlist->ml_type, 0, 0 );
                        continue;
                }
@@ -477,7 +478,6 @@ string_expand(
                        } else if (*sp >= '0' && *sp <= '9' ) {
                                int     n;
                                int     i;
-                               char   *ep;
                                int     l;
 
                                n = *sp - '0';
@@ -518,6 +518,8 @@ regex_matches(
        char newbuf[512];
        int     rc;
 
+       if(str == NULL) str = "";
+
        string_expand(newbuf, sizeof(newbuf), pat, buf, matches);
        if (( rc = regcomp(&re, newbuf, REG_EXTENDED|REG_ICASE))) {
                char error[512];