]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/acl.c
ITS#5052 from HEAD
[openldap] / servers / slapd / acl.c
index 5b84f9e3045225dffff4faf4f8a8c9fa63fdf41d..850fb24621e639ba1ff05c6b7a34abe67e6b29fc 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2005 The OpenLDAP Foundation.
+ * Copyright 1998-2007 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -310,9 +310,10 @@ fe_access_allowed(
         */
        be_orig = op->o_bd;
 
-       op->o_bd = select_backend( &op->o_req_ndn, 0, 0 );
        if ( op->o_bd == NULL ) {
-               op->o_bd = frontendDB;
+               op->o_bd = select_backend( &op->o_req_ndn, 0, 0 );
+               if ( op->o_bd == NULL )
+                       op->o_bd = frontendDB;
        }
        rc = slap_access_allowed( op, e, desc, val, access, state, maskp );
        op->o_bd = be_orig;
@@ -423,14 +424,10 @@ access_allowed_mask(
                                desc, val, access, state, &mask );
 
        } else {
-               BackendDB       *be_orig = op->o_bd;
-
                /* use default (but pass through frontend
                 * for global ACL overlays) */
-               op->o_bd = frontendDB;
                ret = frontendDB->bd_info->bi_access_allowed( op, e,
                                desc, val, access, state, &mask );
-               op->o_bd = be_orig;
        }
 
        if ( !ret ) {
@@ -888,7 +885,7 @@ slap_acl_get(
        
                                if ( a->acl_attrs[0].an_desc->ad_type->sat_syntax != slap_schema.si_syn_distinguishedName ) {
                                        if (value_match( &match, desc,
-                                               /* desc->ad_type->sat_equality */ a->acl_attrval_mr, 0,
+                                               a->acl_attrval_mr, 0,
                                                val, &a->acl_attrval, &text ) != LDAP_SUCCESS ||
                                                        match )
                                                continue;
@@ -928,7 +925,7 @@ slap_acl_get(
                                                        continue;
                                        }
        
-                                       if ( strcmp( a->acl_attrval.bv_val, val->bv_val + vdnlen - patlen ))
+                                       if ( strcmp( a->acl_attrval.bv_val, val->bv_val + vdnlen - patlen ) )
                                                continue;
                                }
                        }
@@ -950,14 +947,31 @@ slap_acl_get(
        return( NULL );
 }
 
+/*
+ * Record value-dependent access control state
+*/
+ #define ACL_RECORD_VALUE_STATE do { \
+                       if( state && !( state->as_recorded & ACL_STATE_RECORDED_VD )) { \
+                               state->as_recorded |= ACL_STATE_RECORDED_VD; \
+                               state->as_vd_acl = a; \
+                               AC_MEMCPY( state->as_vd_acl_matches, matches, \
+                                       sizeof( state->as_vd_acl_matches )) ; \
+                               state->as_vd_acl_count = count; \
+                               state->as_vd_access = b; \
+                               state->as_vd_access_count = i; \
+                       }\
+       } while( 0 )
+
 static int
 acl_mask_dn(
        Operation               *op,
        Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
        AccessControl           *a,
        int                     nmatch,
        regmatch_t              *matches,
-       slap_dn_access          *b,
+       slap_dn_access          *bdn,
        struct berval           *opndn )
 {
        /*
@@ -969,19 +983,20 @@ acl_mask_dn(
         * NOTE: styles "anonymous", "users" and "self" 
         * have been moved to enum slap_style_t, whose 
         * value is set in a_dn_style; however, the string
-        * is maintaned in a_dn_pat.
+        * is maintained in a_dn_pat.
         */
-       if ( b->a_style == ACL_STYLE_ANONYMOUS ) {
+
+       if ( bdn->a_style == ACL_STYLE_ANONYMOUS ) {
                if ( !BER_BVISEMPTY( opndn ) ) {
                        return 1;
                }
 
-       } else if ( b->a_style == ACL_STYLE_USERS ) {
+       } else if ( bdn->a_style == ACL_STYLE_USERS ) {
                if ( BER_BVISEMPTY( opndn ) ) {
                        return 1;
                }
 
-       } else if ( b->a_style == ACL_STYLE_SELF ) {
+       } else if ( bdn->a_style == ACL_STYLE_SELF ) {
                struct berval   ndn, selfndn;
                int             level;
 
@@ -989,7 +1004,7 @@ acl_mask_dn(
                        return 1;
                }
 
-               level = b->a_self_level;
+               level = bdn->a_self_level;
                if ( level < 0 ) {
                        selfndn = *opndn;
                        ndn = e->e_nname;
@@ -1012,8 +1027,8 @@ acl_mask_dn(
                        return 1;
                }
 
-       } else if ( b->a_style == ACL_STYLE_REGEX ) {
-               if ( !ber_bvccmp( &b->a_pat, '*' ) ) {
+       } else if ( bdn->a_style == ACL_STYLE_REGEX ) {
+               if ( !ber_bvccmp( &bdn->a_pat, '*' ) ) {
                        int             tmp_nmatch;
                        regmatch_t      tmp_matches[2],
                                        *tmp_matchesp = tmp_matches;
@@ -1055,7 +1070,7 @@ acl_mask_dn(
                                return 1;
                        }
 
-                       if ( !regex_matches( &b->a_pat, opndn->bv_val,
+                       if ( !regex_matches( &bdn->a_pat, opndn->bv_val,
                                e->e_ndn, tmp_nmatch, tmp_matchesp ) )
                        {
                                return 1;
@@ -1070,7 +1085,7 @@ acl_mask_dn(
                if ( e->e_dn == NULL )
                        return 1;
 
-               if ( b->a_expand ) {
+               if ( bdn->a_expand ) {
                        struct berval   bv;
                        char            buf[ACL_BUF_SIZE];
                        
@@ -1118,7 +1133,7 @@ acl_mask_dn(
                                return 1;
                        }
 
-                       if ( acl_string_expand( &bv, &b->a_pat, 
+                       if ( acl_string_expand( &bv, &bdn->a_pat, 
                                        e->e_nname.bv_val,
                                        tmp_nmatch, tmp_matchesp ) )
                        {
@@ -1134,7 +1149,7 @@ acl_mask_dn(
                        }
 
                } else {
-                       pat = b->a_pat;
+                       pat = bdn->a_pat;
                }
 
                patlen = pat.bv_len;
@@ -1144,13 +1159,13 @@ acl_mask_dn(
 
                }
 
-               if ( b->a_style == ACL_STYLE_BASE ) {
+               if ( bdn->a_style == ACL_STYLE_BASE ) {
                        /* base dn -- entire object DN must match */
                        if ( odnlen != patlen ) {
                                goto dn_match_cleanup;
                        }
 
-               } else if ( b->a_style == ACL_STYLE_ONE ) {
+               } else if ( bdn->a_style == ACL_STYLE_ONE ) {
                        ber_len_t       rdnlen = 0;
 
                        if ( odnlen <= patlen ) {
@@ -1166,12 +1181,12 @@ acl_mask_dn(
                                goto dn_match_cleanup;
                        }
 
-               } else if ( b->a_style == ACL_STYLE_SUBTREE ) {
+               } else if ( bdn->a_style == ACL_STYLE_SUBTREE ) {
                        if ( odnlen > patlen && !DN_SEPARATOR( opndn->bv_val[odnlen - patlen - 1] ) ) {
                                goto dn_match_cleanup;
                        }
 
-               } else if ( b->a_style == ACL_STYLE_CHILDREN ) {
+               } else if ( bdn->a_style == ACL_STYLE_CHILDREN ) {
                        if ( odnlen <= patlen ) {
                                goto dn_match_cleanup;
                        }
@@ -1180,8 +1195,8 @@ acl_mask_dn(
                                goto dn_match_cleanup;
                        }
 
-               } else if ( b->a_style == ACL_STYLE_LEVEL ) {
-                       int             level = b->a_level;
+               } else if ( bdn->a_style == ACL_STYLE_LEVEL ) {
+                       int             level = bdn->a_level;
                        struct berval   ndn;
 
                        if ( odnlen <= patlen ) {
@@ -1212,7 +1227,7 @@ acl_mask_dn(
                got_match = !strcmp( pat.bv_val, &opndn->bv_val[ odnlen - patlen ] );
 
 dn_match_cleanup:;
-               if ( pat.bv_val != b->a_pat.bv_val ) {
+               if ( pat.bv_val != bdn->a_pat.bv_val ) {
                        slap_sl_free( pat.bv_val, op->o_tmpmemctx );
                }
 
@@ -1224,21 +1239,6 @@ dn_match_cleanup:;
        return 0;
 }
 
-/*
- * Record value-dependent access control state
- */
-#define ACL_RECORD_VALUE_STATE do { \
-               if( state && !( state->as_recorded & ACL_STATE_RECORDED_VD )) { \
-                       state->as_recorded |= ACL_STATE_RECORDED_VD; \
-                       state->as_vd_acl = a; \
-                       AC_MEMCPY( state->as_vd_acl_matches, matches, \
-                               sizeof( state->as_vd_acl_matches )) ; \
-                       state->as_vd_acl_count = count; \
-                       state->as_vd_access = b; \
-                       state->as_vd_access_count = i; \
-               } \
-       } while( 0 )
-
 static int
 acl_mask_dnattr(
        Operation               *op,
@@ -1411,11 +1411,11 @@ slap_acl_mask(
                         * NOTE: styles "anonymous", "users" and "self" 
                         * have been moved to enum slap_style_t, whose 
                         * value is set in a_dn_style; however, the string
-                        * is maintaned in a_dn_pat.
+                        * is maintained in a_dn_pat.
                         */
 
-                       if ( acl_mask_dn( op, e, a, nmatch, matches,
-                               &b->a_dn, &op->o_ndn ) )
+                       if ( acl_mask_dn( op, e, desc, val, a, nmatch, matches,
+                                       &b->a_dn, &op->o_ndn ) )
                        {
                                continue;
                        }
@@ -1435,7 +1435,7 @@ slap_acl_mask(
                         * NOTE: styles "anonymous", "users" and "self" 
                         * have been moved to enum slap_style_t, whose 
                         * value is set in a_dn_style; however, the string
-                        * is maintaned in a_dn_pat.
+                        * is maintained in a_dn_pat.
                         */
 
                        if ( op->o_conn && !BER_BVISNULL( &op->o_conn->c_ndn ) )
@@ -1445,8 +1445,8 @@ slap_acl_mask(
                                ndn = op->o_ndn;
                        }
 
-                       if ( acl_mask_dn( op, e, a, nmatch, matches,
-                               &b->a_realdn, &ndn ) )
+                       if ( acl_mask_dn( op, e, desc, val, a, nmatch, matches,
+                                       &b->a_realdn, &ndn ) )
                        {
                                continue;
                        }
@@ -1603,12 +1603,9 @@ slap_acl_mask(
 
                                                port = strrchr( ip.bv_val, ':' );
                                                if ( port ) {
-                                                       char    *next;
-                                                       
                                                        ip.bv_len = port - ip.bv_val;
                                                        ++port;
-                                                       port_number = strtol( port, &next, 10 );
-                                                       if ( next[0] != '\0' )
+                                                       if ( lutil_atoi( &port_number, port ) != 0 )
                                                                continue;
                                                }
                                                
@@ -1924,6 +1921,35 @@ slap_acl_mask(
                        }
                }
 
+               /* check for the "self" modifier in the <access> field */
+               if ( b->a_dn.a_self ) {
+                       const char *dummy;
+                       int rc, match = 0;
+
+                       ACL_RECORD_VALUE_STATE;
+
+                       /* must have DN syntax */
+                       if ( desc->ad_type->sat_syntax != slap_schema.si_syn_distinguishedName &&
+                                       !is_at_syntax( desc->ad_type, SLAPD_NAMEUID_SYNTAX )) continue;
+
+                       /* check if the target is an attribute. */
+                       if ( val == NULL ) continue;
+
+                       /* a DN must be present */
+                       if ( BER_BVISEMPTY( &op->o_ndn ) ) {
+                               continue;
+                       }
+
+                       /* target is attribute, check if the attribute value
+                        * is the op dn.
+                        */
+                       rc = value_match( &match, desc,
+                                       desc->ad_type->sat_equality, 0,
+                                       val, &op->o_ndn, &dummy );
+                       /* on match error or no match, fail the ACL clause */
+                       if ( rc != LDAP_SUCCESS || match != 0 )
+                               continue;
+               }
 #ifdef SLAP_DYNACL
                if ( b->a_dynacl ) {
                        slap_dynacl_t   *da;
@@ -1944,15 +1970,15 @@ slap_acl_mask(
                        }
 
                        /* start out with nothing granted, nothing denied */
-                       ACL_INIT(tgrant);
-                       ACL_INIT(tdeny);
+                       ACL_INVALIDATE(tgrant);
+                       ACL_INVALIDATE(tdeny);
 
                        for ( da = b->a_dynacl; da; da = da->da_next ) {
                                slap_access_t   grant,
                                                deny;
 
-                               ACL_INIT(grant);
-                               ACL_INIT(deny);
+                               ACL_INVALIDATE(grant);
+                               ACL_INVALIDATE(deny);
 
                                Debug( LDAP_DEBUG_ACL, "    <= check a_dynacl: %s\n",
                                        da->da_name, 0, 0 );
@@ -2288,6 +2314,7 @@ acl_check_modlist(
 
                switch ( mlist->sml_op ) {
                case LDAP_MOD_REPLACE:
+               case LDAP_MOD_INCREMENT:
                        /*
                         * We must check both permission to delete the whole
                         * attribute and permission to add the specific attributes.
@@ -2449,7 +2476,7 @@ acl_set_cb_gather( Operation *op, SlapReply *rs )
                        }
                }
 
-               if ( bvals ) {
+               if ( bvalsp ) {
                        p->bvals = slap_set_join( p->cookie, p->bvals,
                                        ( '|' | SLAP_SET_RREF ), bvalsp );
                }
@@ -2652,7 +2679,7 @@ acl_match_set (
        } else {
                struct berval           subjdn, ndn = BER_BVNULL;
                struct berval           setat;
-               BerVarray               bvals;
+               BerVarray               bvals=NULL;
                const char              *text;
                AttributeDescription    *desc = NULL;