add logs; fix bug in group/dn selection logic

[openldap] / servers / slapd / acl.c

diff --git a/servers/slapd/acl.c b/servers/slapd/acl.c
index 5bd5897b0d95dbb503f82bfb6e2e9d671c4b2c28..c337b8fe78ee8e21c61085933a4dbdda32b2362a 100644 (file)
--- a/servers/slapd/acl.c
+++ b/servers/slapd/acl.c
@@ -157,7 +157,6 @@ access_allowed(
        const char *attr;
        regmatch_t matches[MAXREMATCHES];
        int        st_same_attr = 0;
-       int        st_initialized = 0;
        static AccessControlState state_init = ACL_STATE_INIT;
 
        assert( e != NULL );
@@ -174,21 +173,24 @@ access_allowed(
                access = ACL_AUTH;
        }
 
-       if( state && state->as_recorded && state->as_vd_ad==desc) { 
-               if( state->as_recorded & ACL_STATE_RECORDED_NV &&
-                       val == NULL )
-               {
-                       return state->as_result;
-
-               } else if ( state->as_recorded & ACL_STATE_RECORDED_VD &&
-                       val != NULL && state->as_vd_acl == NULL )
-               {
-                       return state->as_result;
+       if( state ) {
+               if ( state->as_vd_ad==desc) {
+                       if ( state->as_recorded ) {
+                               if( state->as_recorded & ACL_STATE_RECORDED_NV &&
+                                       val == NULL )
+                               {
+                                       return state->as_result;
+                               } else if ( state->as_recorded & ACL_STATE_RECORDED_VD &&
+                                       val != NULL && state->as_vd_acl == NULL )
+                               {
+                                       return state->as_result;
+                               }
+                       }
+                       st_same_attr = 1;
+               } else {
+                       *state = state_init;
                }
-               st_same_attr = 1;
-       }
 
-       if( state ) {
                state->as_vd_ad=desc;
        }
 
@@ -226,7 +228,7 @@ access_allowed(
 #endif /* LDAP_SLAPI */
 
        /* grant database root access */
-       if ( be != NULL && be_isroot( be, &op->o_ndn ) ) {
+       if ( be != NULL && be_isroot( op ) ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( ACL, INFO, 
                        "access_allowed: conn %lu root access granted\n", 
@@ -353,11 +355,8 @@ access_allowed(
                                Debug( LDAP_DEBUG_ACL, "access_allowed: result from state (%s)\n", attr, 0, 0 );
                                ret = state->as_result;
                                goto done;
-                       } else if (!st_initialized) {
+                       } else {
                                Debug( LDAP_DEBUG_ACL, "access_allowed: no res from state (%s)\n", attr, 0, 0);
-                           *state = state_init;
-                               state->as_vd_ad=desc;
-                               st_initialized=1;
                        }
                }
 
@@ -445,6 +444,7 @@ acl_get(
 {
        const char *attr;
        int dnlen, patlen;
+       AccessControl *prev;
 
        assert( e != NULL );
        assert( count != NULL );
@@ -460,10 +460,12 @@ acl_get(
                } else {
                        a = op->o_bd->be_acl;
                }
+               prev = NULL;
 
                assert( a != NULL );
 
        } else {
+               prev = a;
                a = a->acl_next;
        }
 
@@ -553,7 +555,7 @@ acl_get(
 
                        if( state && !( state->as_recorded & ACL_STATE_RECORDED_VD )) {
                                state->as_recorded |= ACL_STATE_RECORDED_VD;
-                               state->as_vd_acl = a;
+                               state->as_vd_acl = prev;
                                state->as_vd_acl_count = *count;
                                state->as_vd_access = a->acl_access;
                                state->as_vd_access_count = 1;
@@ -1205,7 +1207,7 @@ dn_match_cleanup:;
 
                if ( b->a_group_pat.bv_len ) {
                        struct berval bv;
-                       struct berval ndn = { 0, NULL };
+                       struct berval ndn = BER_BVNULL;
                        int rc;
 
                        if ( op->o_ndn.bv_len == 0 ) {
@@ -1566,7 +1568,7 @@ acl_check_modlist(
        assert( be != NULL );
 
        /* short circuit root database access */
-       if ( be_isroot( op->o_bd, &op->o_ndn ) ) {
+       if ( be_isroot( op ) ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( ACL, DETAIL1, 
                           "acl_check_modlist: conn %lu  access granted to root user\n",
@@ -1630,12 +1632,12 @@ acl_check_modlist(
                                goto done;
                        }
 
-                       if ( mlist->sml_bvalues == NULL ) break;
+                       if ( mlist->sml_values == NULL ) break;
 
                        /* fall thru to check value to add */
 
                case LDAP_MOD_ADD:
-                       assert( mlist->sml_bvalues != NULL );
+                       assert( mlist->sml_values != NULL );
 
                        for ( bv = mlist->sml_nvalues
                                        ? mlist->sml_nvalues : mlist->sml_values;
@@ -1651,7 +1653,7 @@ acl_check_modlist(
                        break;
 
                case LDAP_MOD_DELETE:
-                       if ( mlist->sml_bvalues == NULL ) {
+                       if ( mlist->sml_values == NULL ) {
                                if ( ! access_allowed( op, e,
                                        mlist->sml_desc, NULL, ACL_WRITE, NULL ) )
                                {
@@ -1761,14 +1763,14 @@ aci_match_set (
        int setref
 )
 {
-       struct berval set = { 0, NULL };
+       struct berval set = BER_BVNULL;
        int rc = 0;
        AciSetCookie cookie;
 
        if (setref == 0) {
                ber_dupbv_x( &set, subj, op->o_tmpmemctx );
        } else {
-               struct berval subjdn, ndn = { 0, NULL };
+               struct berval subjdn, ndn = BER_BVNULL;
                struct berval setat;
                BerVarray bvals;
                const char *text;