]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/acl.c
trim use of uninitialized data; please review
[openldap] / servers / slapd / acl.c
index 95492f54cf26cd944930c12020eb2a7cd0d40041..d1801f898dc96f698081bac709ae2f2fa75a8292 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2003 The OpenLDAP Foundation.
+ * Copyright 1998-2005 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 #include "slap.h"
 #include "sets.h"
 #include "lber_pvt.h"
-
-#ifdef LDAP_SLAPI
-#include "slapi/slapi.h"
-#endif /* LDAPI_SLAPI */
+#include "lutil.h"
 
 #define ACL_BUF_SIZE   1024    /* use most appropriate size */
 
 static struct berval 
        aci_bv_entry            = BER_BVC("entry"),
        aci_bv_children         = BER_BVC("children"),
+       aci_bv_onelevel         = BER_BVC("onelevel"),
+       aci_bv_subtree          = BER_BVC("subtree"),
        aci_bv_br_entry         = BER_BVC("[entry]"),
        aci_bv_br_all           = BER_BVC("[all]"),
        aci_bv_access_id        = BER_BVC("access-id"),
+#if 0
        aci_bv_anonymous        = BER_BVC("anonymous"),
+#endif
        aci_bv_public           = BER_BVC("public"),
        aci_bv_users            = BER_BVC("users"),
        aci_bv_self             = BER_BVC("self"),
@@ -62,25 +63,41 @@ static struct berval
        aci_bv_set_ref          = BER_BVC("set-ref"),
        aci_bv_grant            = BER_BVC("grant"),
        aci_bv_deny             = BER_BVC("deny"),
+
+       aci_bv_ip_eq            = BER_BVC("IP="),
+#ifdef LDAP_PF_LOCAL
+       aci_bv_path_eq          = BER_BVC("PATH="),
+#if 0
+       aci_bv_dirsep           = BER_BVC(LDAP_DIRSEP),
+#endif
+#endif /* LDAP_PF_LOCAL */
        
        aci_bv_group_class      = BER_BVC(SLAPD_GROUP_CLASS),
        aci_bv_group_attr       = BER_BVC(SLAPD_GROUP_ATTR),
        aci_bv_role_class       = BER_BVC(SLAPD_ROLE_CLASS),
-       aci_bv_role_attr        = BER_BVC(SLAPD_ROLE_ATTR);
+       aci_bv_role_attr        = BER_BVC(SLAPD_ROLE_ATTR),
+       aci_bv_set_attr         = BER_BVC(SLAPD_ACI_SET_ATTR);
 
+typedef enum slap_aci_scope_t {
+       SLAP_ACI_SCOPE_ENTRY            = 0x1,
+       SLAP_ACI_SCOPE_CHILDREN         = 0x2,
+       SLAP_ACI_SCOPE_SUBTREE          = ( SLAP_ACI_SCOPE_ENTRY | SLAP_ACI_SCOPE_CHILDREN )
+} slap_aci_scope_t;
 
-static AccessControl * acl_get(
+static AccessControl * slap_acl_get(
        AccessControl *ac, int *count,
        Operation *op, Entry *e,
        AttributeDescription *desc,
        struct berval *val,
-       int nmatches, regmatch_t *matches );
+       int nmatch, regmatch_t *matches,
+       AccessControlState *state );
 
-static slap_control_t acl_mask(
+static slap_control_t slap_acl_mask(
        AccessControl *ac, slap_mask_t *mask,
        Operation *op, Entry *e,
        AttributeDescription *desc,
        struct berval *val,
+       int nmatch,
        regmatch_t *matches,
        int count,
        AccessControlState *state );
@@ -91,17 +108,19 @@ static int aci_mask(
        AttributeDescription *desc,
        struct berval *val,
        struct berval *aci,
+       int nmatch,
        regmatch_t *matches,
        slap_access_t *grant,
        slap_access_t *deny,
-       struct berval *scope);
-#endif
+       slap_aci_scope_t scope);
+#endif /* SLAPD_ACI_ENABLED */
 
 static int     regex_matches(
-       struct berval *pat, char *str, char *buf, regmatch_t *matches);
-static void    string_expand(
+       struct berval *pat, char *str, char *buf,
+       int nmatch, regmatch_t *matches);
+static int     string_expand(
        struct berval *newbuf, struct berval *pattern,
-       char *match, regmatch_t *matches);
+       char *match, int nmatch, regmatch_t *matches);
 
 typedef        struct AciSetCookie {
        Operation *op;
@@ -109,6 +128,7 @@ typedef     struct AciSetCookie {
 } AciSetCookie;
 
 SLAP_SET_GATHER aci_set_gather;
+SLAP_SET_GATHER aci_set_gather2;
 static int aci_match_set ( struct berval *subj, Operation *op,
     Entry *e, int setref );
 
@@ -118,117 +138,478 @@ static int aci_match_set ( struct berval *subj, Operation *op,
  * the whole attribute is assumed (all values).
  *
  * This routine loops through all access controls and calls
- * acl_mask() on each applicable access control.
+ * slap_acl_mask() on each applicable access control.
  * The loop exits when a definitive answer is reached or
  * or no more controls remain.
  *
  * returns:
  *             0       access denied
  *             1       access granted
+ *
+ * Notes:
+ * - can be legally called with op == NULL
+ * - can be legally called with op->o_bd == NULL
  */
 
+#ifdef SLAP_OVERLAY_ACCESS
 int
-access_allowed(
+slap_access_always_allowed(
        Operation               *op,
-       Entry           *e,
+       Entry                   *e,
        AttributeDescription    *desc,
-       struct berval   *val,
-       slap_access_t   access,
-       AccessControlState *state )
+       struct berval           *val,
+       slap_access_t           access,
+       AccessControlState      *state,
+       slap_mask_t             *maskp )
+{
+       assert( maskp != NULL );
+
+       ACL_PRIV_SET( *maskp, ACL_ACCESS2PRIV( access ) );
+
+       return 1;
+}
+
+int
+slap_access_allowed(
+       Operation               *op,
+       Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
+       slap_access_t           access,
+       AccessControlState      *state,
+       slap_mask_t             *maskp )
 {
        int                             ret = 1;
        int                             count;
        AccessControl                   *a = NULL;
-       Backend *be;
-       int     be_null = 0;
 
 #ifdef LDAP_DEBUG
-       char accessmaskbuf[ACCESSMASK_MAXLEN];
+       char                            accessmaskbuf[ACCESSMASK_MAXLEN];
 #endif
-       slap_mask_t mask;
-       slap_control_t control;
-       const char *attr;
-       regmatch_t matches[MAXREMATCHES];
-       int        st_same_attr = 0;
-       int        st_initialized = 0;
-       static AccessControlState state_init = ACL_STATE_INIT;
+       slap_mask_t                     mask;
+       slap_control_t                  control;
+       slap_access_t                   access_level;
+       const char                      *attr;
+       regmatch_t                      matches[MAXREMATCHES];
+       int                             st_same_attr = 0;
+
+       assert( op != NULL );
+       assert( e != NULL );
+       assert( desc != NULL );
+       assert( maskp != NULL );
+
+       access_level = ACL_LEVEL( access );
+       attr = desc->ad_cname.bv_val;
+
+       assert( attr != NULL );
+
+       /* grant database root access */
+       if ( be_isroot( op ) ) {
+               Debug( LDAP_DEBUG_ACL, "<= root access granted\n", 0, 0, 0 );
+               mask = ACL_LVL_MANAGE;
+               goto done;
+       }
+
+       /*
+        * no-user-modification operational attributes are ignored
+        * by ACL_WRITE checking as any found here are not provided
+        * by the user
+        */
+       if ( access_level >= ACL_WRITE && is_at_no_user_mod( desc->ad_type )
+               && desc != slap_schema.si_ad_entry
+               && desc != slap_schema.si_ad_children )
+       {
+               Debug( LDAP_DEBUG_ACL, "NoUserMod Operational attribute:"
+                       " %s access granted\n",
+                       attr, 0, 0 );
+               goto done;
+       }
+
+       /* use backend default access if no backend acls */
+       if ( op->o_bd->be_acl == NULL ) {
+               int     i;
+
+               Debug( LDAP_DEBUG_ACL,
+                       "=> slap_access_allowed: backend default %s "
+                       "access %s to \"%s\"\n",
+                       access2str( access ),
+                       op->o_bd->be_dfltaccess >= access_level ? "granted" : "denied",
+                       op->o_dn.bv_val ? op->o_dn.bv_val : "(anonymous)" );
+               ret = op->o_bd->be_dfltaccess >= access_level;
+
+               mask = ACL_PRIV_LEVEL;
+               for ( i = ACL_NONE; i <= op->o_bd->be_dfltaccess; i++ ) {
+                       ACL_PRIV_SET( mask, ACL_ACCESS2PRIV( i ) );
+               }
+
+               goto done;
+       }
+
+       ret = 0;
+       control = ACL_BREAK;
+
+       if ( st_same_attr ) {
+               assert( state->as_vd_acl != NULL );
+
+               a = state->as_vd_acl;
+               count = state->as_vd_acl_count;
+               if ( !ACL_IS_INVALID( state->as_vd_acl_mask ) ) {
+                       mask = state->as_vd_acl_mask;
+                       AC_MEMCPY( matches, state->as_vd_acl_matches, sizeof(matches) );
+                       goto vd_access;
+               }
+
+       } else {
+               if ( state ) state->as_vi_acl = NULL;
+               a = NULL;
+               ACL_PRIV_ASSIGN( mask, *maskp );
+               count = 0;
+               memset( matches, '\0', sizeof( matches ) );
+       }
+
+       while ( ( a = slap_acl_get( a, &count, op, e, desc, val,
+               MAXREMATCHES, matches, state ) ) != NULL )
+       {
+               int i;
+
+               for ( i = 0; i < MAXREMATCHES && matches[i].rm_so > 0; i++ ) {
+                       Debug( LDAP_DEBUG_ACL, "=> match[%d]: %d %d ", i,
+                               (int)matches[i].rm_so, (int)matches[i].rm_eo );
+                       if ( matches[i].rm_so <= matches[0].rm_eo ) {
+                               int n;
+                               for ( n = matches[i].rm_so; n < matches[i].rm_eo; n++ ) {
+                                       Debug( LDAP_DEBUG_ACL, "%c", e->e_ndn[n], 0, 0 );
+                               }
+                       }
+                       Debug( LDAP_DEBUG_ARGS, "\n", 0, 0, 0 );
+               }
+
+               if ( state ) {
+                       if ( state->as_vi_acl == a &&
+                               ( state->as_recorded & ACL_STATE_RECORDED_NV ) )
+                       {
+                               Debug( LDAP_DEBUG_ACL,
+                                       "=> slap_access_allowed: result from state (%s)\n",
+                                       attr, 0, 0 );
+                               ret = state->as_result;
+                               goto done;
+                       } else {
+                               Debug( LDAP_DEBUG_ACL,
+                                       "=> slap_access_allowed: no res from state (%s)\n",
+                                       attr, 0, 0 );
+                       }
+               }
+
+vd_access:
+               control = slap_acl_mask( a, &mask, op,
+                       e, desc, val, MAXREMATCHES, matches, count, state );
+
+               if ( control != ACL_BREAK ) {
+                       break;
+               }
+
+               memset( matches, '\0', sizeof( matches ) );
+       }
+
+       if ( ACL_IS_INVALID( mask ) ) {
+               Debug( LDAP_DEBUG_ACL,
+                       "=> slap_access_allowed: \"%s\" (%s) invalid!\n",
+                       e->e_dn, attr, 0 );
+               ACL_PRIV_ASSIGN( mask, *maskp );
+
+       } else if ( control == ACL_BREAK ) {
+               Debug( LDAP_DEBUG_ACL,
+                       "=> slap_access_allowed: no more rules\n", 0, 0, 0 );
+
+               goto done;
+       }
+
+       ret = ACL_GRANT( mask, access );
+
+       Debug( LDAP_DEBUG_ACL,
+               "=> slap_access_allowed: %s access %s by %s\n",
+               access2str( access ), ret ? "granted" : "denied",
+               accessmask2str( mask, accessmaskbuf, 1 ) );
+
+done:
+       ACL_PRIV_ASSIGN( *maskp, mask );
+       return ret;
+}
+
+int
+fe_access_allowed(
+       Operation               *op,
+       Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
+       slap_access_t           access,
+       AccessControlState      *state,
+       slap_mask_t             *maskp )
+{
+       BackendDB               *be_orig;
+       int                     rc;
+
+       /*
+        * NOTE: control gets here if FIXME
+        * if an appropriate backend cannot be selected for the operation,
+        * we assume that the frontend should handle this
+        * FIXME: should select_backend() take care of this,
+        * and return frontendDB instead of NULL?  maybe for some value
+        * of the flags?
+        */
+       be_orig = op->o_bd;
+
+       op->o_bd = select_backend( &op->o_req_ndn, 0, 0 );
+       if ( op->o_bd == NULL ) {
+               op->o_bd = frontendDB;
+       }
+       rc = slap_access_allowed( op, e, desc, val, access, state, maskp );
+       op->o_bd = be_orig;
+
+       return rc;
+}
+
+int
+access_allowed_mask(
+       Operation               *op,
+       Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
+       slap_access_t           access,
+       AccessControlState      *state,
+       slap_mask_t             *maskp )
+{
+       int                             ret = 1;
+       AccessControl                   *a = NULL;
+       int                             be_null = 0;
+
+#ifdef LDAP_DEBUG
+       char                            accessmaskbuf[ACCESSMASK_MAXLEN];
+#endif
+       slap_mask_t                     mask;
+       slap_access_t                   access_level;
+       const char                      *attr;
+       int                             st_same_attr = 0;
+       static AccessControlState       state_init = ACL_STATE_INIT;
 
        assert( e != NULL );
        assert( desc != NULL );
-       assert( access > ACL_NONE );
+
+       access_level = ACL_LEVEL( access );
+
+       assert( access_level > ACL_NONE );
+
+       ACL_INIT( mask );
+       if ( maskp ) ACL_INVALIDATE( *maskp );
 
        attr = desc->ad_cname.bv_val;
 
        assert( attr != NULL );
 
-       if( op && op->o_is_auth_check &&
-               ( access == ACL_SEARCH || access == ACL_READ ))
+       if ( op && op->o_is_auth_check &&
+               ( access_level == ACL_SEARCH || access_level == ACL_READ ) )
        {
                access = ACL_AUTH;
        }
 
-       if( state && state->as_recorded && state->as_vd_ad==desc) { 
-               if( state->as_recorded & ACL_STATE_RECORDED_NV &&
-                       val == NULL )
-               {
-                       return state->as_result;
+       if ( state ) {
+               if ( state->as_vd_ad == desc ) {
+                       if ( state->as_recorded ) {
+                               if ( ( state->as_recorded & ACL_STATE_RECORDED_NV ) &&
+                                       val == NULL )
+                               {
+                                       return state->as_result;
 
-               } else if ( state->as_recorded & ACL_STATE_RECORDED_VD &&
-                       val != NULL && state->as_vd_acl == NULL )
-               {
-                       return state->as_result;
+                               } else if ( ( state->as_recorded & ACL_STATE_RECORDED_VD ) &&
+                                       val != NULL && state->as_vd_acl == NULL )
+                               {
+                                       return state->as_result;
+                               }
+                       }
+                       st_same_attr = 1;
+               } else {
+                       *state = state_init;
                }
-               st_same_attr = 1;
-       }
 
-       if( state ) {
-               state->as_vd_ad=desc;
+               state->as_vd_ad = desc;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, ENTRY, 
-               "access_allowed: %s access to \"%s\" \"%s\" requested\n",
-               access2str( access ), e->e_dn, attr );
-#else
        Debug( LDAP_DEBUG_ACL,
                "=> access_allowed: %s access to \"%s\" \"%s\" requested\n",
-           access2str( access ), e->e_dn, attr );
-#endif
+               access2str( access ), e->e_dn, attr );
 
        if ( op == NULL ) {
                /* no-op call */
                goto done;
        }
 
-#ifdef LDAP_SLAPI
-       if ( op->o_pb != NULL ) {
-               ret = slapi_int_access_allowed( op, e, desc, val, access, state );
-               if ( ret == 0 ) {
-                       /* ACL plugin denied access */
+       if ( op->o_bd == NULL ) {
+               op->o_bd = LDAP_STAILQ_FIRST( &backendDB );
+               be_null = 1;
+
+#ifdef LDAP_DEVEL
+               /*
+                * FIXME: experimental; use first backend rules
+                * iff there is no global_acl (ITS#3100) */
+               if ( frontendDB->be_acl != NULL ) {
+                       op->o_bd = frontendDB;
+               }
+#endif /* LDAP_DEVEL */
+       }
+       assert( op->o_bd != NULL );
+
+       /* this is enforced in backend_add() */
+       if ( op->o_bd->bd_info->bi_access_allowed ) {
+               /* delegate to backend */
+               ret = op->o_bd->bd_info->bi_access_allowed( op, e,
+                               desc, val, access, state, &mask );
+
+       } else {
+               BackendDB       *be_orig = op->o_bd;
+
+               /* use default (but pass through frontend
+                * for global ACL overlays) */
+               op->o_bd = frontendDB;
+               ret = frontendDB->bd_info->bi_access_allowed( op, e,
+                               desc, val, access, state, &mask );
+               op->o_bd = be_orig;
+       }
+
+       if ( !ret ) {
+               if ( ACL_IS_INVALID( mask ) ) {
+                       Debug( LDAP_DEBUG_ACL,
+                               "=> access_allowed: \"%s\" (%s) invalid!\n",
+                               e->e_dn, attr, 0 );
+                       ACL_INIT( mask );
+
+               } else {
+                       Debug( LDAP_DEBUG_ACL,
+                               "=> access_allowed: no more rules\n", 0, 0, 0 );
+
                        goto done;
                }
        }
-#endif /* LDAP_SLAPI */
+
+       Debug( LDAP_DEBUG_ACL,
+               "=> access_allowed: %s access %s by %s\n",
+               access2str( access ), ret ? "granted" : "denied",
+               accessmask2str( mask, accessmaskbuf, 1 ) );
+
+done:
+       if ( state != NULL ) {
+               /* If not value-dependent, save ACL in case of more attrs */
+               if ( !( state->as_recorded & ACL_STATE_RECORDED_VD ) ) {
+                       state->as_vi_acl = a;
+                       state->as_result = ret;
+               }
+               state->as_recorded |= ACL_STATE_RECORDED;
+       }
+       if ( be_null ) op->o_bd = NULL;
+       if ( maskp ) ACL_PRIV_ASSIGN( *maskp, mask );
+       return ret;
+}
+
+#else /* !SLAP_OVERLAY_ACCESS */
+
+int
+access_allowed_mask(
+       Operation               *op,
+       Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
+       slap_access_t           access,
+       AccessControlState      *state,
+       slap_mask_t             *maskp )
+{
+       int                             ret = 1;
+       int                             count;
+       AccessControl                   *a = NULL;
+       Backend                         *be;
+       int                             be_null = 0;
+
+#ifdef LDAP_DEBUG
+       char                            accessmaskbuf[ACCESSMASK_MAXLEN];
+#endif
+       slap_mask_t                     mask;
+       slap_control_t                  control;
+       slap_access_t                   access_level;
+       const char                      *attr;
+       regmatch_t                      matches[MAXREMATCHES];
+       int                             st_same_attr = 0;
+       static AccessControlState       state_init = ACL_STATE_INIT;
+
+       assert( e != NULL );
+       assert( desc != NULL );
+
+       access_level = ACL_LEVEL( access );
+
+       assert( access_level > ACL_NONE );
+       if ( maskp ) ACL_INVALIDATE( *maskp );
+
+       attr = desc->ad_cname.bv_val;
+
+       assert( attr != NULL );
+
+       if ( op && op->o_is_auth_check &&
+               ( access_level == ACL_SEARCH || access_level == ACL_READ ) )
+       {
+               access = ACL_AUTH;
+       }
+
+       if ( state ) {
+               if ( state->as_vd_ad == desc ) {
+                       if ( state->as_recorded ) {
+                               if ( ( state->as_recorded & ACL_STATE_RECORDED_NV ) &&
+                                       val == NULL )
+                               {
+                                       return state->as_result;
+
+                               } else if ( ( state->as_recorded & ACL_STATE_RECORDED_VD ) &&
+                                       val != NULL && state->as_vd_acl == NULL )
+                               {
+                                       return state->as_result;
+                               }
+                       }
+                       st_same_attr = 1;
+               } else {
+                       *state = state_init;
+               }
+
+               state->as_vd_ad=desc;
+       }
+
+       Debug( LDAP_DEBUG_ACL,
+               "=> access_allowed: %s access to \"%s\" \"%s\" requested\n",
+               access2str( access ), e->e_dn, attr );
+
+       if ( op == NULL ) {
+               /* no-op call */
+               goto done;
+       }
 
        be = op->o_bd;
        if ( be == NULL ) {
-               be = &backends[0];
+               be = LDAP_STAILQ_FIRST(&backendDB);
                be_null = 1;
-               op->o_bd = be;
+#ifdef LDAP_DEVEL
+               /*
+                * FIXME: experimental; use first backend rules
+                * iff there is no global_acl (ITS#3100) */
+               if ( frontendDB->be_acl == NULL ) 
+#endif
+               {
+                       op->o_bd = be;
+               }
        }
        assert( be != NULL );
 
        /* grant database root access */
-       if ( be != NULL && be_isroot( be, &op->o_ndn ) ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, INFO, 
-                       "access_allowed: conn %lu root access granted\n", 
-                       op->o_connid, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_ACL,
-                   "<= root access granted\n",
-                       0, 0, 0 );
-#endif
+       if ( be_isroot( op ) ) {
+               Debug( LDAP_DEBUG_ACL, "<= root access granted\n", 0, 0, 0 );
+               if ( maskp ) {
+                       mask = ACL_LVL_MANAGE;
+               }
+
                goto done;
        }
 
@@ -237,57 +618,57 @@ access_allowed(
         * by ACL_WRITE checking as any found here are not provided
         * by the user
         */
-       if ( access >= ACL_WRITE && is_at_no_user_mod( desc->ad_type )
+       if ( access_level >= ACL_WRITE && is_at_no_user_mod( desc->ad_type )
                && desc != slap_schema.si_ad_entry
                && desc != slap_schema.si_ad_children )
        {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "access_allowed: conn %lu NoUserMod Operational attribute: %s "
-                       "access granted\n", op->o_connid, attr , 0 );
-#else
                Debug( LDAP_DEBUG_ACL, "NoUserMod Operational attribute:"
                        " %s access granted\n",
                        attr, 0, 0 );
-#endif
                goto done;
        }
 
        /* use backend default access if no backend acls */
-       if( be != NULL && be->be_acl == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "access_allowed: backend default %s access %s to \"%s\"\n",
-                   access2str( access ),
-                   be->be_dfltaccess >= access ? "granted" : "denied", 
-                       op->o_dn.bv_val ? op->o_dn.bv_val : "(anonymous)" );
-#else
+       if ( be->be_acl == NULL ) {
                Debug( LDAP_DEBUG_ACL,
-                       "=> access_allowed: backend default %s access %s to \"%s\"\n",
+                       "=> access_allowed: backend default %s "
+                       "access %s to \"%s\"\n",
                        access2str( access ),
-                       be->be_dfltaccess >= access ? "granted" : "denied",
+                       be->be_dfltaccess >= access_level ? "granted" : "denied",
                        op->o_dn.bv_val ? op->o_dn.bv_val : "(anonymous)" );
-#endif
-               ret = be->be_dfltaccess >= access;
+               ret = be->be_dfltaccess >= access_level;
+
+               if ( maskp ) {
+                       int     i;
+
+                       mask = ACL_PRIV_LEVEL;
+                       for ( i = ACL_NONE; i <= be->be_dfltaccess; i++ ) {
+                               mask |= ACL_ACCESS2PRIV( i );
+                       }
+               }
+
                goto done;
 
 #ifdef notdef
        /* be is always non-NULL */
        /* use global default access if no global acls */
-       } else if ( be == NULL && global_acl == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "access_allowed: global default %s access %s to \"%s\"\n",
-                   access2str( access ),
-                   global_default_access >= access ? "granted" : "denied", 
-                       op->o_dn.bv_val );
-#else
+       } else if ( be == NULL && frontendDB->be_acl == NULL ) {
                Debug( LDAP_DEBUG_ACL,
                        "=> access_allowed: global default %s access %s to \"%s\"\n",
                        access2str( access ),
-                       global_default_access >= access ? "granted" : "denied", op->o_dn.bv_val );
-#endif
-               ret = global_default_access >= access;
+                       frontendDB->be_dfltaccess >= access_level ?
+                               "granted" : "denied", op->o_dn.bv_val );
+               ret = frontendDB->be_dfltaccess >= access_level;
+
+               if ( maskp ) {
+                       int     i;
+
+                       mask = ACL_PRIV_LEVEL;
+                       for ( i = ACL_NONE; i <= global_default_access; i++ ) {
+                               mask |= ACL_ACCESS2PRIV( i );
+                       }
+               }
+
                goto done;
 #endif
        }
@@ -295,134 +676,114 @@ access_allowed(
        ret = 0;
        control = ACL_BREAK;
 
-       if( st_same_attr ) {
+       if ( st_same_attr ) {
                assert( state->as_vd_acl != NULL );
 
                a = state->as_vd_acl;
-               mask = state->as_vd_acl_mask;
                count = state->as_vd_acl_count;
-               AC_MEMCPY( matches, state->as_vd_acl_matches, sizeof(matches) );
-               goto vd_access;
+               if ( !ACL_IS_INVALID( state->as_vd_acl_mask ) ) {
+                       mask = state->as_vd_acl_mask;
+                       AC_MEMCPY( matches, state->as_vd_acl_matches, sizeof(matches) );
+                       goto vd_access;
+               }
 
        } else {
                if ( state ) state->as_vi_acl = NULL;
                a = NULL;
                ACL_INIT(mask);
                count = 0;
-               memset(matches, '\0', sizeof(matches));
+               memset( matches, '\0', sizeof(matches) );
        }
 
-       while((a = acl_get( a, &count, op, e, desc, val,
-               MAXREMATCHES, matches )) != NULL)
+       while ( ( a = slap_acl_get( a, &count, op, e, desc, val,
+               MAXREMATCHES, matches, state ) ) != NULL )
        {
                int i;
 
-               for (i = 0; i < MAXREMATCHES && matches[i].rm_so > 0; i++) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "access_allowed: match[%d]:  %d %d ",
-                           i, (int)matches[i].rm_so, (int)matches[i].rm_eo );
-#else
+               for ( i = 0; i < MAXREMATCHES && matches[i].rm_so > 0; i++ ) {
                        Debug( LDAP_DEBUG_ACL, "=> match[%d]: %d %d ", i,
-                           (int)matches[i].rm_so, (int)matches[i].rm_eo );
-#endif
-                       if( matches[i].rm_so <= matches[0].rm_eo ) {
+                               (int)matches[i].rm_so, (int)matches[i].rm_eo );
+                       if ( matches[i].rm_so <= matches[0].rm_eo ) {
                                int n;
-                               for ( n = matches[i].rm_so; n < matches[i].rm_eo; n++) {
+                               for ( n = matches[i].rm_so; n < matches[i].rm_eo; n++ ) {
                                        Debug( LDAP_DEBUG_ACL, "%c", e->e_ndn[n], 0, 0 );
                                }
                        }
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, ARGS, "\n" , 0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ARGS, "\n", 0, 0, 0 );
-#endif
                }
 
-               if (state) {
-                       if (state->as_vi_acl == a && (state->as_recorded & ACL_STATE_RECORDED_NV)) {
-                               Debug( LDAP_DEBUG_ACL, "access_allowed: result from state (%s)\n", attr, 0, 0 );
+               if ( state ) {
+                       if ( state->as_vi_acl == a &&
+                               ( state->as_recorded & ACL_STATE_RECORDED_NV ) )
+                       {
+                               Debug( LDAP_DEBUG_ACL,
+                                       "access_allowed: result from state (%s)\n",
+                                       attr, 0, 0 );
                                ret = state->as_result;
                                goto done;
-                       } else if (!st_initialized) {
-                               Debug( LDAP_DEBUG_ACL, "access_allowed: no res from state (%s)\n", attr, 0, 0);
-                           *state = state_init;
-                               state->as_vd_ad=desc;
-                               st_initialized=1;
+                       } else {
+                               Debug( LDAP_DEBUG_ACL,
+                                       "access_allowed: no res from state (%s)\n",
+                                       attr, 0, 0 );
                        }
                }
 
 vd_access:
-               control = acl_mask( a, &mask, op,
-                       e, desc, val, matches, count, state );
+               control = slap_acl_mask( a, &mask, op,
+                       e, desc, val, MAXREMATCHES, matches, count, state );
 
                if ( control != ACL_BREAK ) {
                        break;
                }
 
-               memset(matches, '\0', sizeof(matches));
+               memset( matches, '\0', sizeof(matches) );
        }
 
        if ( ACL_IS_INVALID( mask ) ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "access_allowed: conn %lu \"%s\" (%s) invalid!\n",
-                   op->o_connid, e->e_dn, attr );
-#else
                Debug( LDAP_DEBUG_ACL,
                        "=> access_allowed: \"%s\" (%s) invalid!\n",
                        e->e_dn, attr, 0 );
-#endif
                ACL_INIT(mask);
 
        } else if ( control == ACL_BREAK ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "access_allowed: conn %lu        no more rules\n", op->o_connid, 0,0 );
-#else
                Debug( LDAP_DEBUG_ACL,
-                       "=> access_allowed: no more rules\n", 0, 0, 0);
-#endif
+                       "=> access_allowed: no more rules\n", 0, 0, 0 );
 
                goto done;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, ENTRY, 
-               "access_allowed: %s access %s by %s\n", 
-               access2str( access ), ACL_GRANT( mask, access ) ? "granted" : "denied",
-               accessmask2str( mask, accessmaskbuf ) );
-#else
        Debug( LDAP_DEBUG_ACL,
                "=> access_allowed: %s access %s by %s\n",
                access2str( access ),
                ACL_GRANT(mask, access) ? "granted" : "denied",
-               accessmask2str( mask, accessmaskbuf ) );
-#endif
+               accessmask2str( mask, accessmaskbuf, 1 ) );
 
        ret = ACL_GRANT(mask, access);
 
 done:
-       if( state != NULL ) {
+       if ( state != NULL ) {
                /* If not value-dependent, save ACL in case of more attrs */
-               if ( !(state->as_recorded & ACL_STATE_RECORDED_VD) ) {
+               if ( !( state->as_recorded & ACL_STATE_RECORDED_VD ) ) {
                        state->as_vi_acl = a;
                        state->as_result = ret;
                }
                state->as_recorded |= ACL_STATE_RECORDED;
        }
-       if (be_null) op->o_bd = NULL;
+       if ( be_null ) op->o_bd = NULL;
+       if ( maskp ) *maskp = mask;
        return ret;
 }
 
+#endif /* SLAP_OVERLAY_ACCESS */
+
 /*
- * acl_get - return the acl applicable to entry e, attribute
+ * slap_acl_get - return the acl applicable to entry e, attribute
  * attr.  the acl returned is suitable for use in subsequent calls to
  * acl_access_allowed().
  */
 
 static AccessControl *
-acl_get(
+slap_acl_get(
        AccessControl *a,
        int                     *count,
        Operation       *op,
@@ -430,10 +791,12 @@ acl_get(
        AttributeDescription *desc,
        struct berval   *val,
        int                     nmatch,
-       regmatch_t      *matches )
+       regmatch_t      *matches,
+       AccessControlState *state )
 {
        const char *attr;
        int dnlen, patlen;
+       AccessControl *prev;
 
        assert( e != NULL );
        assert( count != NULL );
@@ -445,14 +808,16 @@ acl_get(
 
        if( a == NULL ) {
                if( op->o_bd == NULL ) {
-                       a = global_acl;
+                       a = frontendDB->be_acl;
                } else {
                        a = op->o_bd->be_acl;
                }
+               prev = NULL;
 
                assert( a != NULL );
 
        } else {
+               prev = a;
                a = a->acl_next;
        }
 
@@ -463,26 +828,14 @@ acl_get(
 
                if ( a->acl_dn_pat.bv_len || ( a->acl_dn_style != ACL_STYLE_REGEX )) {
                        if ( a->acl_dn_style == ACL_STYLE_REGEX ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG( ACL, DETAIL1, 
-                                       "acl_get: dnpat [%d] %s nsub: %d\n",
-                                       *count, a->acl_dn_pat.bv_val, 
-                                       (int) a->acl_dn_re.re_nsub );
-#else
                                Debug( LDAP_DEBUG_ACL, "=> dnpat: [%d] %s nsub: %d\n", 
                                        *count, a->acl_dn_pat.bv_val, (int) a->acl_dn_re.re_nsub );
-#endif
                                if (regexec(&a->acl_dn_re, e->e_ndn, nmatch, matches, 0))
                                        continue;
 
                        } else {
-#ifdef NEW_LOGGING
-                               LDAP_LOG( ACL, DETAIL1, "acl_get: dn [%d] %s\n",
-                                          *count, a->acl_dn_pat.bv_val, 0 );
-#else
                                Debug( LDAP_DEBUG_ACL, "=> dn: [%d] %s\n", 
                                        *count, a->acl_dn_pat.bv_val, 0 );
-#endif
                                patlen = a->acl_dn_pat.bv_len;
                                if ( dnlen < patlen )
                                        continue;
@@ -493,16 +846,19 @@ acl_get(
                                                continue;
 
                                } else if ( a->acl_dn_style == ACL_STYLE_ONE ) {
-                                       int rdnlen = -1;
+                                       int     rdnlen = -1, sep = 0;
 
                                        if ( dnlen <= patlen )
                                                continue;
 
-                                       if ( !DN_SEPARATOR( e->e_ndn[dnlen - patlen - 1] ) )
-                                               continue;
+                                       if ( patlen > 0 ) {
+                                               if ( !DN_SEPARATOR( e->e_ndn[dnlen - patlen - 1] ) )
+                                                       continue;
+                                               sep = 1;
+                                       }
 
                                        rdnlen = dn_rdnlen( NULL, &e->e_nname );
-                                       if ( rdnlen != dnlen - patlen - 1 )
+                                       if ( rdnlen != dnlen - patlen - sep )
                                                continue;
 
                                } else if ( a->acl_dn_style == ACL_STYLE_SUBTREE ) {
@@ -520,13 +876,92 @@ acl_get(
                                        continue;
                        }
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_get: [%d] matched\n", *count, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ACL, "=> acl_get: [%d] matched\n",
                                *count, 0, 0 );
-#endif
+               }
+
+               if ( a->acl_attrs && !ad_inlist( desc, a->acl_attrs ) ) {
+                       matches[0].rm_so = matches[0].rm_eo = -1;
+                       continue;
+               }
+
+               /* Is this ACL only for a specific value? */
+               if ( a->acl_attrval.bv_len ) {
+                       if ( val == NULL ) {
+                               continue;
+                       }
+
+                       if( state && !( state->as_recorded & ACL_STATE_RECORDED_VD )) {
+                               state->as_recorded |= ACL_STATE_RECORDED_VD;
+                               state->as_vd_acl = a;
+                               state->as_vd_acl_count = *count;
+                               state->as_vd_access = a->acl_access;
+                               state->as_vd_access_count = 1;
+                               ACL_INVALIDATE( state->as_vd_acl_mask );
+                       }
+
+                       if ( a->acl_attrval_style == ACL_STYLE_REGEX ) {
+                               Debug( LDAP_DEBUG_ACL,
+                                       "acl_get: valpat %s\n",
+                                       a->acl_attrval.bv_val, 0, 0 );
+                               if ( regexec( &a->acl_attrval_re, val->bv_val, 0, NULL, 0 ) )
+                               {
+                                       continue;
+                               }
+
+                       } else {
+                               int match = 0;
+                               const char *text;
+                               Debug( LDAP_DEBUG_ACL,
+                                       "acl_get: val %s\n",
+                                       a->acl_attrval.bv_val, 0, 0 );
+       
+                               if ( a->acl_attrs[0].an_desc->ad_type->sat_syntax != slap_schema.si_syn_distinguishedName ) {
+                                       if (value_match( &match, desc,
+                                               /* desc->ad_type->sat_equality */ a->acl_attrval_mr, 0,
+                                               val, &a->acl_attrval, &text ) != LDAP_SUCCESS ||
+                                                       match )
+                                               continue;
+                                       
+                               } else {
+                                       int             patlen, vdnlen;
+       
+                                       patlen = a->acl_attrval.bv_len;
+                                       vdnlen = val->bv_len;
+       
+                                       if ( vdnlen < patlen )
+                                               continue;
+       
+                                       if ( a->acl_attrval_style == ACL_STYLE_BASE ) {
+                                               if ( vdnlen > patlen )
+                                                       continue;
+       
+                                       } else if ( a->acl_attrval_style == ACL_STYLE_ONE ) {
+                                               int rdnlen = -1;
+       
+                                               if ( !DN_SEPARATOR( val->bv_val[vdnlen - patlen - 1] ) )
+                                                       continue;
+       
+                                               rdnlen = dn_rdnlen( NULL, val );
+                                               if ( rdnlen != vdnlen - patlen - 1 )
+                                                       continue;
+       
+                                       } else if ( a->acl_attrval_style == ACL_STYLE_SUBTREE ) {
+                                               if ( vdnlen > patlen && !DN_SEPARATOR( val->bv_val[vdnlen - patlen - 1] ) )
+                                                       continue;
+       
+                                       } else if ( a->acl_attrval_style == ACL_STYLE_CHILDREN ) {
+                                               if ( vdnlen <= patlen )
+                                                       continue;
+       
+                                               if ( !DN_SEPARATOR( val->bv_val[vdnlen - patlen - 1] ) )
+                                                       continue;
+                                       }
+       
+                                       if ( strcmp( a->acl_attrval.bv_val, val->bv_val + vdnlen - patlen ))
+                                               continue;
+                               }
+                       }
                }
 
                if ( a->acl_filter != NULL ) {
@@ -536,37 +971,290 @@ acl_get(
                        }
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "acl_get: [%d] check attr %s\n", *count, attr ,0 );
-#else
-               Debug( LDAP_DEBUG_ACL, "=> acl_get: [%d] check attr %s\n",
+               Debug( LDAP_DEBUG_ACL, "=> acl_get: [%d] attr %s\n",
                       *count, attr, 0);
-#endif
-               if ( a->acl_attrs == NULL ||
-                       ad_inlist( desc, a->acl_attrs ) )
-               {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_get:  [%d] acl %s attr: %s\n", *count, e->e_dn, attr );
-#else
-                       Debug( LDAP_DEBUG_ACL,
-                               "<= acl_get: [%d] acl %s attr: %s\n",
-                               *count, e->e_dn, attr );
-#endif
-                       return a;
-               }
-               matches[0].rm_so = matches[0].rm_eo = -1;
+               return a;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, RESULTS, "acl_get: done.\n", 0, 0, 0 );
-#else
        Debug( LDAP_DEBUG_ACL, "<= acl_get: done.\n", 0, 0, 0 );
-#endif
        return( NULL );
 }
 
+static int
+acl_mask_dn(
+       Operation               *op,
+       Entry                   *e,
+       AccessControl           *a,
+       int                     nmatch,
+       regmatch_t              *matches,
+       slap_dn_access          *b,
+       struct berval           *opndn )
+{
+       /*
+        * if access applies to the entry itself, and the
+        * user is bound as somebody in the same namespace as
+        * the entry, OR the given dn matches the dn pattern
+        */
+       /*
+        * NOTE: styles "anonymous", "users" and "self" 
+        * have been moved to enum slap_style_t, whose 
+        * value is set in a_dn_style; however, the string
+        * is maintaned in a_dn_pat.
+        */
+       if ( b->a_style == ACL_STYLE_ANONYMOUS ) {
+               if ( !BER_BVISEMPTY( opndn ) ) {
+                       return 1;
+               }
+
+       } else if ( b->a_style == ACL_STYLE_USERS ) {
+               if ( BER_BVISEMPTY( opndn ) ) {
+                       return 1;
+               }
+
+       } else if ( b->a_style == ACL_STYLE_SELF ) {
+               struct berval   ndn, selfndn;
+               int             level;
+
+               if ( BER_BVISEMPTY( opndn ) || BER_BVISNULL( &e->e_nname ) ) {
+                       return 1;
+               }
+
+               level = b->a_self_level;
+               if ( level < 0 ) {
+                       selfndn = *opndn;
+                       ndn = e->e_nname;
+                       level = -level;
+
+               } else {
+                       ndn = *opndn;
+                       selfndn = e->e_nname;
+               }
+
+               for ( ; level > 0; level-- ) {
+                       if ( BER_BVISEMPTY( &ndn ) ) {
+                               break;
+                       }
+                       dnParent( &ndn, &ndn );
+               }
+                       
+               if ( BER_BVISEMPTY( &ndn ) || !dn_match( &ndn, &selfndn ) )
+               {
+                       return 1;
+               }
+
+       } else if ( b->a_style == ACL_STYLE_REGEX ) {
+               if ( !ber_bvccmp( &b->a_pat, '*' ) ) {
+                       int             tmp_nmatch;
+                       regmatch_t      tmp_matches[2],
+                                       *tmp_matchesp = tmp_matches;
+
+                       int             rc = 0;
+
+                       switch ( a->acl_dn_style ) {
+                       case ACL_STYLE_REGEX:
+                               if ( !BER_BVISNULL( &a->acl_dn_pat ) ) {
+                                       tmp_matchesp = matches;
+                                       tmp_nmatch = nmatch;
+                                       break;
+                               }
+                       /* FALLTHRU: applies also to ACL_STYLE_REGEX when pattern is "*" */
+
+                       case ACL_STYLE_BASE:
+                               tmp_matches[0].rm_so = 0;
+                               tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                               tmp_nmatch = 1;
+                               break;
+
+                       case ACL_STYLE_ONE:
+                       case ACL_STYLE_SUBTREE:
+                       case ACL_STYLE_CHILDREN:
+                               tmp_matches[0].rm_so = 0;
+                               tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                               tmp_matches[1].rm_so = e->e_nname.bv_len - a->acl_dn_pat.bv_len;
+                               tmp_matches[1].rm_eo = e->e_nname.bv_len;
+                               tmp_nmatch = 2;
+                               break;
+
+                       default:
+                               /* error */
+                               rc = 1;
+                               break;
+                       }
+
+                       if ( rc ) {
+                               return 1;
+                       }
+
+                       if ( !regex_matches( &b->a_pat, opndn->bv_val,
+                               e->e_ndn, tmp_nmatch, tmp_matchesp ) )
+                       {
+                               return 1;
+                       }
+               }
+
+       } else {
+               struct berval   pat;
+               ber_len_t       patlen, odnlen;
+               int             got_match = 0;
+
+               if ( e->e_dn == NULL )
+                       return 1;
+
+               if ( b->a_expand ) {
+                       struct berval   bv;
+                       char            buf[ACL_BUF_SIZE];
+                       
+                       int             tmp_nmatch;
+                       regmatch_t      tmp_matches[2],
+                                       *tmp_matchesp = tmp_matches;
+
+                       int             rc = 0;
+
+                       bv.bv_len = sizeof( buf ) - 1;
+                       bv.bv_val = buf;
+
+                       switch ( a->acl_dn_style ) {
+                       case ACL_STYLE_REGEX:
+                               if ( !BER_BVISNULL( &a->acl_dn_pat ) ) {
+                                       tmp_matchesp = matches;
+                                       tmp_nmatch = nmatch;
+                                       break;
+                               }
+                       /* FALLTHRU: applies also to ACL_STYLE_REGEX when pattern is "*" */
+
+                       case ACL_STYLE_BASE:
+                               tmp_matches[0].rm_so = 0;
+                               tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                               tmp_nmatch = 1;
+                               break;
+
+                       case ACL_STYLE_ONE:
+                       case ACL_STYLE_SUBTREE:
+                       case ACL_STYLE_CHILDREN:
+                               tmp_matches[0].rm_so = 0;
+                               tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                               tmp_matches[1].rm_so = e->e_nname.bv_len - a->acl_dn_pat.bv_len;
+                               tmp_matches[1].rm_eo = e->e_nname.bv_len;
+                               tmp_nmatch = 2;
+                               break;
+
+                       default:
+                               /* error */
+                               rc = 1;
+                               break;
+                       }
+
+                       if ( rc ) {
+                               return 1;
+                       }
+
+                       if ( string_expand( &bv, &b->a_pat, 
+                                       e->e_nname.bv_val,
+                                       tmp_nmatch, tmp_matchesp ) )
+                       {
+                               return 1;
+                       }
+                       
+                       if ( dnNormalize(0, NULL, NULL, &bv,
+                                       &pat, op->o_tmpmemctx )
+                                       != LDAP_SUCCESS )
+                       {
+                               /* did not expand to a valid dn */
+                               return 1;
+                       }
+
+               } else {
+                       pat = b->a_pat;
+               }
+
+               patlen = pat.bv_len;
+               odnlen = opndn->bv_len;
+               if ( odnlen < patlen ) {
+                       goto dn_match_cleanup;
+
+               }
+
+               if ( b->a_style == ACL_STYLE_BASE ) {
+                       /* base dn -- entire object DN must match */
+                       if ( odnlen != patlen ) {
+                               goto dn_match_cleanup;
+                       }
+
+               } else if ( b->a_style == ACL_STYLE_ONE ) {
+                       int rdnlen = -1;
+
+                       if ( odnlen <= patlen ) {
+                               goto dn_match_cleanup;
+                       }
+
+                       if ( !DN_SEPARATOR( opndn->bv_val[odnlen - patlen - 1] ) ) {
+                               goto dn_match_cleanup;
+                       }
+
+                       rdnlen = dn_rdnlen( NULL, opndn );
+                       if ( rdnlen != odnlen - patlen - 1 ) {
+                               goto dn_match_cleanup;
+                       }
+
+               } else if ( b->a_style == ACL_STYLE_SUBTREE ) {
+                       if ( odnlen > patlen && !DN_SEPARATOR( opndn->bv_val[odnlen - patlen - 1] ) ) {
+                               goto dn_match_cleanup;
+                       }
+
+               } else if ( b->a_style == ACL_STYLE_CHILDREN ) {
+                       if ( odnlen <= patlen ) {
+                               goto dn_match_cleanup;
+                       }
+
+                       if ( !DN_SEPARATOR( opndn->bv_val[odnlen - patlen - 1] ) ) {
+                               goto dn_match_cleanup;
+                       }
+
+               } else if ( b->a_style == ACL_STYLE_LEVEL ) {
+                       int level;
+                       struct berval ndn;
+
+                       if ( odnlen <= patlen ) {
+                               goto dn_match_cleanup;
+                       }
+
+                       if ( level > 0 && !DN_SEPARATOR( opndn->bv_val[odnlen - patlen - 1] ) )
+                       {
+                               goto dn_match_cleanup;
+                       }
+                       
+                       level = b->a_level;
+                       ndn = *opndn;
+                       for ( ; level > 0; level-- ) {
+                               if ( BER_BVISEMPTY( &ndn ) ) {
+                                       goto dn_match_cleanup;
+                               }
+                               dnParent( &ndn, &ndn );
+                               if ( ndn.bv_len < patlen ) {
+                                       goto dn_match_cleanup;
+                               }
+                       }
+                       
+                       if ( ndn.bv_len != patlen ) {
+                               goto dn_match_cleanup;
+                       }
+               }
+
+               got_match = !strcmp( pat.bv_val, &opndn->bv_val[ odnlen - patlen ] );
+
+dn_match_cleanup:;
+               if ( pat.bv_val != b->a_pat.bv_val ) {
+                       slap_sl_free( pat.bv_val, op->o_tmpmemctx );
+               }
+
+               if ( !got_match ) {
+                       return 1;
+               }
+       }
+
+       return 0;
+}
+
 /*
  * Record value-dependent access control state
  */
@@ -582,8 +1270,102 @@ acl_get(
                } \
        } while( 0 )
 
+static int
+acl_mask_dnattr(
+       Operation               *op,
+       Entry                   *e,
+       struct berval           *val,
+       AccessControl           *a,
+       Access                  *b,
+       int                     i,
+       regmatch_t              *matches,
+       int                     count,
+       AccessControlState      *state,
+       slap_dn_access          *bdn,
+       struct berval           *opndn )
+{
+       Attribute       *at;
+       struct berval   bv;
+       int             rc, match = 0;
+       const char      *text;
+       const char      *attr = bdn->a_at->ad_cname.bv_val;
+
+       assert( attr != NULL );
+
+       if ( BER_BVISEMPTY( opndn ) ) {
+               return 1;
+       }
+
+       Debug( LDAP_DEBUG_ACL, "<= check a_dn_at: %s\n", attr, 0, 0 );
+       bv = *opndn;
+
+       /* see if asker is listed in dnattr */
+       for ( at = attrs_find( e->e_attrs, bdn->a_at );
+               at != NULL;
+               at = attrs_find( at->a_next, bdn->a_at ) )
+       {
+               if ( value_find_ex( bdn->a_at,
+                       SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH |
+                               SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
+                       at->a_nvals,
+                       &bv, op->o_tmpmemctx ) == 0 )
+               {
+                       /* found it */
+                       match = 1;
+                       break;
+               }
+       }
+
+       if ( match ) {
+               /* have a dnattr match. if this is a self clause then
+                * the target must also match the op dn.
+                */
+               if ( bdn->a_self ) {
+                       /* check if the target is an attribute. */
+                       if ( val == NULL ) return 1;
+
+                       /* target is attribute, check if the attribute value
+                        * is the op dn.
+                        */
+                       rc = value_match( &match, bdn->a_at,
+                               bdn->a_at->ad_type->sat_equality, 0,
+                               val, &bv, &text );
+                       /* on match error or no match, fail the ACL clause */
+                       if ( rc != LDAP_SUCCESS || match != 0 )
+                               return 1;
+               }
+
+       } else {
+               /* no dnattr match, check if this is a self clause */
+               if ( ! bdn->a_self )
+                       return 1;
+
+               ACL_RECORD_VALUE_STATE;
+               
+               /* this is a self clause, check if the target is an
+                * attribute.
+                */
+               if ( val == NULL )
+                       return 1;
+
+               /* target is attribute, check if the attribute value
+                * is the op dn.
+                */
+               rc = value_match( &match, bdn->a_at,
+                       bdn->a_at->ad_type->sat_equality, 0,
+                       val, &bv, &text );
+
+               /* on match error or no match, fail the ACL clause */
+               if ( rc != LDAP_SUCCESS || match != 0 )
+                       return 1;
+       }
+
+       return 0;
+}
+
+
 /*
- * acl_mask - modifies mask based upon the given acl and the
+ * slap_acl_mask - modifies mask based upon the given acl and the
  * requested access to entry e, attribute attr, value val.  if val
  * is null, access to the whole attribute is assumed (all values).
  *
@@ -592,23 +1374,26 @@ acl_get(
  */
 
 static slap_control_t
-acl_mask(
-       AccessControl   *a,
-       slap_mask_t *mask,
-       Operation       *op,
-       Entry           *e,
-       AttributeDescription *desc,
-       struct berval   *val,
-       regmatch_t      *matches,
-       int     count,
-       AccessControlState *state )
+slap_acl_mask(
+       AccessControl           *a,
+       slap_mask_t             *mask,
+       Operation               *op,
+       Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
+       int                     nmatch,
+       regmatch_t              *matches,
+       int                     count,
+       AccessControlState      *state )
 {
-       int             i, odnlen, patlen;
+       int             i;
        Access  *b;
 #ifdef LDAP_DEBUG
        char accessmaskbuf[ACCESSMASK_MAXLEN];
+#if !defined( SLAP_DYNACL ) && defined( SLAPD_ACI_ENABLED )
        char accessmaskbuf1[ACCESSMASK_MAXLEN];
-#endif
+#endif /* !SLAP_DYNACL && SLAPD_ACI_ENABLED */
+#endif /* DEBUG */
        const char *attr;
 
        assert( a != NULL );
@@ -619,16 +1404,6 @@ acl_mask(
 
        assert( attr != NULL );
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, ENTRY, 
-               "acl_mask: conn %lu  access to entry \"%s\", attr \"%s\" requested\n",
-               op->o_connid, e->e_dn, attr );
-
-       LDAP_LOG( ACL, ARGS, 
-               " to %s by \"%s\", (%s) \n", val ? "value" : "all values",
-               op->o_ndn.bv_val ? op->o_ndn.bv_val : "",
-               accessmask2str( *mask, accessmaskbuf ) );
-#else
        Debug( LDAP_DEBUG_ACL,
                "=> acl_mask: access to entry \"%s\", attr \"%s\" requested\n",
                e->e_dn, attr, 0 );
@@ -637,109 +1412,8 @@ acl_mask(
                "=> acl_mask: to %s by \"%s\", (%s) \n",
                val ? "value" : "all values",
                op->o_ndn.bv_val ?  op->o_ndn.bv_val : "",
-               accessmask2str( *mask, accessmaskbuf ) );
-#endif
-
-       /* Is this ACL only for a specific value? */
-       if ( a->acl_attrval.bv_len ) {
-               if ( state && !state->as_vd_acl ) {
-                       state->as_vd_acl = a;
-                       state->as_vd_access = a->acl_access;
-                       state->as_vd_access_count = 1;
-               }
-               if ( val == NULL ) {
-                       return ACL_BREAK;
-               }
-               if ( a->acl_attrval_style == ACL_STYLE_REGEX ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_get: valpat %s\n",
-                               a->acl_attrval.bv_val, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_ACL,
-                               "acl_get: valpat %s\n",
-                               a->acl_attrval.bv_val, 0, 0 );
-#endif
-                       if (regexec(&a->acl_attrval_re, val->bv_val, 0, NULL, 0))
-                               return ACL_BREAK;
-               } else {
-                       int match = 0;
-                       const char *text;
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_get: val %s\n",
-                               a->acl_attrval.bv_val, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_ACL,
-                               "acl_get: val %s\n",
-                               a->acl_attrval.bv_val, 0, 0 );
-#endif
-
-                       if ( a->acl_attrs[0].an_desc->ad_type->sat_syntax != slap_schema.si_syn_distinguishedName ) {
-                               if (value_match( &match, desc,
-                                       desc->ad_type->sat_equality, 0,
-                                       val, &a->acl_attrval, &text ) != LDAP_SUCCESS ||
-                                               match )
-                                       return ACL_BREAK;
-                               
-                       } else {
-                               int             patlen, vdnlen, rc, got_match = 0;
-                               struct berval   vdn = { 0, NULL };
-
-                               /* it is a DN */
-                               assert( a->acl_attrs[0].an_desc->ad_type->sat_syntax == slap_schema.si_syn_distinguishedName );
-
-                               rc = dnNormalize( 0, NULL, NULL, val, &vdn,
-                                               op->o_tmpmemctx );
-                               if ( rc != LDAP_SUCCESS ) {
-                                       /* error */
-                                       return ACL_BREAK;
-                               }
-
-                               patlen = a->acl_attrval.bv_len;
-                               vdnlen = vdn.bv_len;
-
-                               if ( vdnlen < patlen )
-                                       goto attrval_cleanup;
-
-                               if ( a->acl_dn_style == ACL_STYLE_BASE ) {
-                                       if ( vdnlen > patlen )
-                                               goto attrval_cleanup;
-
-                               } else if ( a->acl_dn_style == ACL_STYLE_ONE ) {
-                                       int rdnlen = -1;
-
-                                       if ( !DN_SEPARATOR( vdn.bv_val[vdnlen - patlen - 1] ) )
-                                               goto attrval_cleanup;
-
-                                       rdnlen = dn_rdnlen( NULL, &vdn );
-                                       if ( rdnlen != vdnlen - patlen - 1 )
-                                               goto attrval_cleanup;
-
-                               } else if ( a->acl_dn_style == ACL_STYLE_SUBTREE ) {
-                                       if ( vdnlen > patlen && !DN_SEPARATOR( vdn.bv_val[vdnlen - patlen - 1] ) )
-                                               goto attrval_cleanup;
+               accessmask2str( *mask, accessmaskbuf, 1 ) );
 
-                               } else if ( a->acl_dn_style == ACL_STYLE_CHILDREN ) {
-                                       if ( vdnlen <= patlen )
-                                               goto attrval_cleanup;
-
-                                       if ( !DN_SEPARATOR( vdn.bv_val[vdnlen - patlen - 1] ) )
-                                               goto attrval_cleanup;
-                               }
-
-                               got_match = strcmp( a->acl_attrval.bv_val, vdn.bv_val + vdnlen - patlen );
-
-attrval_cleanup:;
-                               if ( vdn.bv_val )
-                                       free( vdn.bv_val );
-
-                               if ( !got_match )
-                                       return ACL_BREAK;
-                               
-                       }
-               }
-       }
 
        if( state && ( state->as_recorded & ACL_STATE_RECORDED_VD )
                && state->as_vd_acl == a )
@@ -758,173 +1432,110 @@ attrval_cleanup:;
                ACL_INVALIDATE( modmask );
 
                /* AND <who> clauses */
-               if ( b->a_dn_pat.bv_len != 0 ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_mask: conn %lu  check a_dn_pat: %s\n",
-                               op->o_connid, b->a_dn_pat.bv_val ,0 );
-#else
+               if ( !BER_BVISEMPTY( &b->a_dn_pat ) ) {
                        Debug( LDAP_DEBUG_ACL, "<= check a_dn_pat: %s\n",
                                b->a_dn_pat.bv_val, 0, 0);
-#endif
                        /*
                         * if access applies to the entry itself, and the
                         * user is bound as somebody in the same namespace as
                         * the entry, OR the given dn matches the dn pattern
                         */
-                       if ( bvmatch( &b->a_dn_pat, &aci_bv_anonymous ) ) {
-                               if ( op->o_ndn.bv_len != 0 ) {
-                                       continue;
-                               }
-
-                       } else if ( bvmatch( &b->a_dn_pat, &aci_bv_users ) ) {
-                               if ( op->o_ndn.bv_len == 0 ) {
-                                       continue;
-                               }
+                       /*
+                        * NOTE: styles "anonymous", "users" and "self" 
+                        * have been moved to enum slap_style_t, whose 
+                        * value is set in a_dn_style; however, the string
+                        * is maintaned in a_dn_pat.
+                        */
 
-                       } else if ( bvmatch( &b->a_dn_pat, &aci_bv_self ) ) {
-                               if ( op->o_ndn.bv_len == 0 ) {
-                                       continue;
-                               }
-                               
-                               if ( e->e_dn == NULL || !dn_match( &e->e_nname, &op->o_ndn ) ) {
-                                       continue;
-                               }
+                       if ( acl_mask_dn( op, e, a, nmatch, matches,
+                               &b->a_dn, &op->o_ndn ) )
+                       {
+                               continue;
+                       }
+               }
 
-                       } else if ( b->a_dn_style == ACL_STYLE_REGEX ) {
-                               if ( !ber_bvccmp( &b->a_dn_pat, '*' ) ) {
-                                       int ret = regex_matches( &b->a_dn_pat,
-                                               op->o_ndn.bv_val, e->e_ndn, matches );
+               if ( !BER_BVISEMPTY( &b->a_realdn_pat ) ) {
+                       struct berval   ndn;
 
-                                       if( ret == 0 ) {
-                                               continue;
-                                       }
-                               }
+                       Debug( LDAP_DEBUG_ACL, "<= check a_realdn_pat: %s\n",
+                               b->a_realdn_pat.bv_val, 0, 0);
+                       /*
+                        * if access applies to the entry itself, and the
+                        * user is bound as somebody in the same namespace as
+                        * the entry, OR the given dn matches the dn pattern
+                        */
+                       /*
+                        * NOTE: styles "anonymous", "users" and "self" 
+                        * have been moved to enum slap_style_t, whose 
+                        * value is set in a_dn_style; however, the string
+                        * is maintaned in a_dn_pat.
+                        */
 
+                       if ( op->o_conn && !BER_BVISNULL( &op->o_conn->c_ndn ) )
+                       {
+                               ndn = op->o_conn->c_ndn;
                        } else {
-                               struct berval pat;
-                               int got_match = 0;
-
-                               if ( e->e_dn == NULL )
-                                       continue;
-
-                               if ( b->a_dn_expand ) {
-                                       struct berval bv;
-                                       char buf[ACL_BUF_SIZE];
-
-                                       bv.bv_len = sizeof( buf ) - 1;
-                                       bv.bv_val = buf;
-
-                                       string_expand(&bv, &b->a_dn_pat, 
-                                                       e->e_ndn, matches);
-                                       if ( dnNormalize(0, NULL, NULL, &bv, &pat, op->o_tmpmemctx ) != LDAP_SUCCESS ) {
-                                               /* did not expand to a valid dn */
-                                               continue;
-                                       }
-                               } else {
-                                       pat = b->a_dn_pat;
-                               }
-
-                               patlen = pat.bv_len;
-                               odnlen = op->o_ndn.bv_len;
-                               if ( odnlen < patlen ) {
-                                       goto dn_match_cleanup;
-
-                               }
-
-                               if ( b->a_dn_style == ACL_STYLE_BASE ) {
-                                       /* base dn -- entire object DN must match */
-                                       if ( odnlen != patlen ) {
-                                               goto dn_match_cleanup;
-                                       }
-
-                               } else if ( b->a_dn_style == ACL_STYLE_ONE ) {
-                                       int rdnlen = -1;
-
-                                       if ( odnlen <= patlen ) {
-                                               goto dn_match_cleanup;
-                                       }
-
-                                       if ( !DN_SEPARATOR( op->o_ndn.bv_val[odnlen - patlen - 1] ) ) {
-                                               goto dn_match_cleanup;
-                                       }
-
-                                       rdnlen = dn_rdnlen( NULL, &op->o_ndn );
-                                       if ( rdnlen != odnlen - patlen - 1 ) {
-                                               goto dn_match_cleanup;
-                                       }
-
-                               } else if ( b->a_dn_style == ACL_STYLE_SUBTREE ) {
-                                       if ( odnlen > patlen && !DN_SEPARATOR( op->o_ndn.bv_val[odnlen - patlen - 1] ) ) {
-                                               goto dn_match_cleanup;
-                                       }
-
-                               } else if ( b->a_dn_style == ACL_STYLE_CHILDREN ) {
-                                       if ( odnlen <= patlen ) {
-                                               goto dn_match_cleanup;
-                                       }
-
-                                       if ( !DN_SEPARATOR( op->o_ndn.bv_val[odnlen - patlen - 1] ) ) {
-                                               goto dn_match_cleanup;
-                                       }
-                               }
-
-                               got_match = !strcmp( pat.bv_val, op->o_ndn.bv_val + odnlen - patlen );
-
-dn_match_cleanup:;
-                               if ( pat.bv_val != b->a_dn_pat.bv_val ) {
-                                       free( pat.bv_val );
-                               }
+                               ndn = op->o_ndn;
+                       }
 
-                               if ( !got_match ) {
-                                       continue;
-                               }
+                       if ( acl_mask_dn( op, e, a, nmatch, matches,
+                               &b->a_realdn, &ndn ) )
+                       {
+                               continue;
                        }
                }
 
-               if ( b->a_sockurl_pat.bv_len ) {
+               if ( !BER_BVISEMPTY( &b->a_sockurl_pat ) ) {
                        if ( ! op->o_conn->c_listener ) {
                                continue;
                        }
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                                  "acl_mask: conn %lu  check a_sockurl_pat: %s\n",
-                                  op->o_connid, b->a_sockurl_pat.bv_val , 0 );
-#else
                        Debug( LDAP_DEBUG_ACL, "<= check a_sockurl_pat: %s\n",
                                b->a_sockurl_pat.bv_val, 0, 0 );
-#endif
 
                        if ( !ber_bvccmp( &b->a_sockurl_pat, '*' ) ) {
                                if ( b->a_sockurl_style == ACL_STYLE_REGEX) {
                                        if (!regex_matches( &b->a_sockurl_pat, op->o_conn->c_listener_url.bv_val,
-                                                       e->e_ndn, matches ) ) 
+                                                       e->e_ndn, nmatch, matches ) ) 
+                                       {
+                                               continue;
+                                       }
+
+                               } else if ( b->a_sockurl_style == ACL_STYLE_EXPAND ) {
+                                       struct berval   bv;
+                                       char buf[ACL_BUF_SIZE];
+
+                                       bv.bv_len = sizeof( buf ) - 1;
+                                       bv.bv_val = buf;
+                                       if ( string_expand( &bv, &b->a_sockurl_pat,
+                                                       e->e_ndn, nmatch, matches ) )
+                                       {
+                                               continue;
+                                       }
+
+                                       if ( ber_bvstrcasecmp( &bv, &op->o_conn->c_listener_url ) != 0 )
                                        {
                                                continue;
                                        }
+
                                } else {
                                        if ( ber_bvstrcasecmp( &b->a_sockurl_pat, &op->o_conn->c_listener_url ) != 0 )
+                                       {
                                                continue;
+                                       }
                                }
                        }
                }
 
-               if ( b->a_domain_pat.bv_len ) {
+               if ( !BER_BVISEMPTY( &b->a_domain_pat ) ) {
                        if ( !op->o_conn->c_peer_domain.bv_val ) {
                                continue;
                        }
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                                  "acl_mask: conn %lu  check a_domain_pat: %s\n",
-                                  op->o_connid, b->a_domain_pat.bv_val , 0 );
-#else
                        Debug( LDAP_DEBUG_ACL, "<= check a_domain_pat: %s\n",
                                b->a_domain_pat.bv_val, 0, 0 );
-#endif
                        if ( !ber_bvccmp( &b->a_domain_pat, '*' ) ) {
                                if ( b->a_domain_style == ACL_STYLE_REGEX) {
                                        if (!regex_matches( &b->a_domain_pat, op->o_conn->c_peer_domain.bv_val,
-                                                       e->e_ndn, matches ) ) 
+                                                       e->e_ndn, nmatch, matches ) ) 
                                        {
                                                continue;
                                        }
@@ -940,7 +1551,11 @@ dn_match_cleanup:;
                                                bv.bv_len = sizeof(buf) - 1;
                                                bv.bv_val = buf;
 
-                                               string_expand(&bv, &b->a_domain_pat, e->e_ndn, matches);
+                                               if ( string_expand(&bv, &b->a_domain_pat,
+                                                               e->e_ndn, nmatch, matches) )
+                                               {
+                                                       continue;
+                                               }
                                                pat = bv;
                                        }
 
@@ -966,163 +1581,252 @@ dn_match_cleanup:;
                        }
                }
 
-               if ( b->a_peername_pat.bv_len ) {
+               if ( !BER_BVISEMPTY( &b->a_peername_pat ) ) {
                        if ( !op->o_conn->c_peer_name.bv_val ) {
                                continue;
                        }
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                                  "acl_mask: conn %lu  check a_peername_path: %s\n",
-                                  op->o_connid, b->a_peername_pat.bv_val , 0 );
-#else
                        Debug( LDAP_DEBUG_ACL, "<= check a_peername_path: %s\n",
                                b->a_peername_pat.bv_val, 0, 0 );
-#endif
                        if ( !ber_bvccmp( &b->a_peername_pat, '*' ) ) {
-                               if ( b->a_peername_style == ACL_STYLE_REGEX) {
+                               if ( b->a_peername_style == ACL_STYLE_REGEX ) {
                                        if (!regex_matches( &b->a_peername_pat, op->o_conn->c_peer_name.bv_val,
-                                                       e->e_ndn, matches ) ) 
+                                                       e->e_ndn, nmatch, matches ) ) 
                                        {
                                                continue;
                                        }
+
                                } else {
-                                       if ( ber_bvstrcasecmp( &b->a_peername_pat, &op->o_conn->c_peer_name ) != 0 )
-                                               continue;
+                                       /* try exact match */
+                                       if ( b->a_peername_style == ACL_STYLE_BASE ) {
+                                               if ( ber_bvstrcasecmp( &b->a_peername_pat, &op->o_conn->c_peer_name ) != 0 ) {
+                                                       continue;
+                                               }
+
+                                       } else if ( b->a_peername_style == ACL_STYLE_EXPAND ) {
+                                               struct berval   bv;
+                                               char buf[ACL_BUF_SIZE];
+
+                                               bv.bv_len = sizeof( buf ) - 1;
+                                               bv.bv_val = buf;
+                                               if ( string_expand( &bv, &b->a_peername_pat,
+                                                               e->e_ndn, nmatch, matches ) )
+                                               {
+                                                       continue;
+                                               }
+
+                                               if ( ber_bvstrcasecmp( &bv, &op->o_conn->c_peer_name ) != 0 ) {
+                                                       continue;
+                                               }
+
+                                       /* extract IP and try exact match */
+                                       } else if ( b->a_peername_style == ACL_STYLE_IP ) {
+                                               char            *port;
+                                               char            buf[] = "255.255.255.255";
+                                               struct berval   ip;
+                                               unsigned long   addr;
+                                               int             port_number = -1;
+                                               
+                                               if ( strncasecmp( op->o_conn->c_peer_name.bv_val, 
+                                                                       aci_bv_ip_eq.bv_val, aci_bv_ip_eq.bv_len ) != 0 ) 
+                                                       continue;
+
+                                               ip.bv_val = op->o_conn->c_peer_name.bv_val + aci_bv_ip_eq.bv_len;
+                                               ip.bv_len = op->o_conn->c_peer_name.bv_len - aci_bv_ip_eq.bv_len;
+
+                                               port = strrchr( ip.bv_val, ':' );
+                                               if ( port ) {
+                                                       char    *next;
+                                                       
+                                                       ip.bv_len = port - ip.bv_val;
+                                                       ++port;
+                                                       port_number = strtol( port, &next, 10 );
+                                                       if ( next[0] != '\0' )
+                                                               continue;
+                                               }
+                                               
+                                               /* the port check can be anticipated here */
+                                               if ( b->a_peername_port != -1 && port_number != b->a_peername_port )
+                                                       continue;
+                                               
+                                               /* address longer than expected? */
+                                               if ( ip.bv_len >= sizeof(buf) )
+                                                       continue;
+
+                                               AC_MEMCPY( buf, ip.bv_val, ip.bv_len );
+                                               buf[ ip.bv_len ] = '\0';
+
+                                               addr = inet_addr( buf );
+
+                                               /* unable to convert? */
+                                               if ( addr == (unsigned long)(-1) )
+                                                       continue;
+
+                                               if ( (addr & b->a_peername_mask) != b->a_peername_addr )
+                                                       continue;
+
+#ifdef LDAP_PF_LOCAL
+                                       /* extract path and try exact match */
+                                       } else if ( b->a_peername_style == ACL_STYLE_PATH ) {
+                                               struct berval path;
+                                               
+                                               if ( strncmp( op->o_conn->c_peer_name.bv_val,
+                                                                       aci_bv_path_eq.bv_val, aci_bv_path_eq.bv_len ) != 0 )
+                                                       continue;
+
+                                               path.bv_val = op->o_conn->c_peer_name.bv_val + aci_bv_path_eq.bv_len;
+                                               path.bv_len = op->o_conn->c_peer_name.bv_len - aci_bv_path_eq.bv_len;
+
+                                               if ( ber_bvcmp( &b->a_peername_pat, &path ) != 0 )
+                                                       continue;
+
+#endif /* LDAP_PF_LOCAL */
+
+                                       /* exact match (very unlikely...) */
+                                       } else if ( ber_bvcmp( &op->o_conn->c_peer_name, &b->a_peername_pat ) != 0 ) {
+                                                       continue;
+                                       }
                                }
                        }
                }
 
-               if ( b->a_sockname_pat.bv_len ) {
-                       if ( !op->o_conn->c_sock_name.bv_val ) {
+               if ( !BER_BVISEMPTY( &b->a_sockname_pat ) ) {
+                       if ( BER_BVISNULL( &op->o_conn->c_sock_name ) ) {
                                continue;
                        }
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                                  "acl_mask: conn %lu  check a_sockname_path: %s\n",
-                                  op->o_connid, b->a_sockname_pat.bv_val , 0 );
-#else
                        Debug( LDAP_DEBUG_ACL, "<= check a_sockname_path: %s\n",
                                b->a_sockname_pat.bv_val, 0, 0 );
-#endif
                        if ( !ber_bvccmp( &b->a_sockname_pat, '*' ) ) {
                                if ( b->a_sockname_style == ACL_STYLE_REGEX) {
                                        if (!regex_matches( &b->a_sockname_pat, op->o_conn->c_sock_name.bv_val,
-                                                       e->e_ndn, matches ) ) 
+                                                       e->e_ndn, nmatch, matches ) ) 
                                        {
                                                continue;
                                        }
+
+                               } else if ( b->a_sockname_style == ACL_STYLE_EXPAND ) {
+                                       struct berval   bv;
+                                       char buf[ACL_BUF_SIZE];
+
+                                       bv.bv_len = sizeof( buf ) - 1;
+                                       bv.bv_val = buf;
+                                       if ( string_expand( &bv, &b->a_sockname_pat,
+                                                       e->e_ndn, nmatch, matches ) )
+                                       {
+                                               continue;
+                                       }
+
+                                       if ( ber_bvstrcasecmp( &bv, &op->o_conn->c_sock_name ) != 0 ) {
+                                               continue;
+                                       }
+
                                } else {
-                                       if ( ber_bvstrcasecmp( &b->a_sockname_pat, &op->o_conn->c_sock_name ) != 0 )
+                                       if ( ber_bvstrcasecmp( &b->a_sockname_pat, &op->o_conn->c_sock_name ) != 0 ) {
                                                continue;
+                                       }
                                }
                        }
                }
 
                if ( b->a_dn_at != NULL ) {
-                       Attribute       *at;
-                       struct berval   bv;
-                       int rc, match = 0;
-                       const char *text;
-                       const char *attr = b->a_dn_at->ad_cname.bv_val;
-
-                       assert( attr != NULL );
-
-                       if ( op->o_ndn.bv_len == 0 ) {
+                       if ( acl_mask_dnattr( op, e, val, a, b, i,
+                                       matches, count, state,
+                                       &b->a_dn, &op->o_ndn ) )
+                       {
                                continue;
                        }
+               }
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                                  "acl_mask: conn %lu  check a_dn_pat: %s\n",
-                                  op->o_connid, attr , 0 );
-#else
-                       Debug( LDAP_DEBUG_ACL, "<= check a_dn_at: %s\n",
-                               attr, 0, 0);
-#endif
-                       bv = op->o_ndn;
+               if ( b->a_realdn_at != NULL ) {
+                       struct berval   ndn;
 
-                       /* see if asker is listed in dnattr */
-                       for( at = attrs_find( e->e_attrs, b->a_dn_at );
-                               at != NULL;
-                               at = attrs_find( at->a_next, b->a_dn_at ) )
+                       if ( op->o_conn && !BER_BVISNULL( &op->o_conn->c_ndn ) )
                        {
-                               if( value_find_ex( b->a_dn_at,
-                                       SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH |
-                                               SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
-                                       at->a_nvals,
-                                       &bv, op->o_tmpmemctx ) == 0 )
-                               {
-                                       /* found it */
-                                       match = 1;
-                                       break;
-                               }
-                       }
-
-                       if( match ) {
-                               /* have a dnattr match. if this is a self clause then
-                                * the target must also match the op dn.
-                                */
-                               if ( b->a_dn_self ) {
-                                       /* check if the target is an attribute. */
-                                       if ( val == NULL ) continue;
-
-                                       /* target is attribute, check if the attribute value
-                                        * is the op dn.
-                                        */
-                                       rc = value_match( &match, b->a_dn_at,
-                                               b->a_dn_at->ad_type->sat_equality, 0,
-                                               val, &bv, &text );
-                                       /* on match error or no match, fail the ACL clause */
-                                       if (rc != LDAP_SUCCESS || match != 0 )
-                                               continue;
-                               }
+                               ndn = op->o_conn->c_ndn;
                        } else {
-                               /* no dnattr match, check if this is a self clause */
-                               if ( ! b->a_dn_self )
-                                       continue;
-
-                               ACL_RECORD_VALUE_STATE;
-                               
-                               /* this is a self clause, check if the target is an
-                                * attribute.
-                                */
-                               if ( val == NULL )
-                                       continue;
-
-                               /* target is attribute, check if the attribute value
-                                * is the op dn.
-                                */
-                               rc = value_match( &match, b->a_dn_at,
-                                       b->a_dn_at->ad_type->sat_equality, 0,
-                                       val, &bv, &text );
+                               ndn = op->o_ndn;
+                       }
 
-                               /* on match error or no match, fail the ACL clause */
-                               if (rc != LDAP_SUCCESS || match != 0 )
-                                       continue;
+                       if ( acl_mask_dnattr( op, e, val, a, b, i,
+                                       matches, count, state,
+                                       &b->a_realdn, &ndn ) )
+                       {
+                               continue;
                        }
                }
 
-               if ( b->a_group_pat.bv_len ) {
+               if ( !BER_BVISEMPTY( &b->a_group_pat ) ) {
                        struct berval bv;
-                       struct berval ndn = { 0, NULL };
+                       struct berval ndn = BER_BVNULL;
                        int rc;
 
                        if ( op->o_ndn.bv_len == 0 ) {
                                continue;
                        }
 
+                       Debug( LDAP_DEBUG_ACL, "<= check a_group_pat: %s\n",
+                               b->a_group_pat.bv_val, 0, 0 );
+
                        /* b->a_group is an unexpanded entry name, expanded it should be an 
                         * entry with objectclass group* and we test to see if odn is one of
                         * the values in the attribute group
                         */
                        /* see if asker is listed in dnattr */
-                       if ( b->a_group_style == ACL_STYLE_REGEX ) {
-                               char buf[ACL_BUF_SIZE];
+                       if ( b->a_group_style == ACL_STYLE_EXPAND ) {
+                               char            buf[ACL_BUF_SIZE];
+                               int             tmp_nmatch;
+                               regmatch_t      tmp_matches[2],
+                                               *tmp_matchesp = tmp_matches;
+
                                bv.bv_len = sizeof(buf) - 1;
-                               bv.bv_val = buf; 
+                               bv.bv_val = buf;
+
+                               rc = 0;
+
+                               switch ( a->acl_dn_style ) {
+                               case ACL_STYLE_REGEX:
+                                       if ( !BER_BVISNULL( &a->acl_dn_pat ) ) {
+                                               tmp_matchesp = matches;
+                                               tmp_nmatch = nmatch;
+                                               break;
+                                       }
+
+                               /* FALLTHRU: applies also to ACL_STYLE_REGEX when pattern is "*" */
+                               case ACL_STYLE_BASE:
+                                       tmp_matches[0].rm_so = 0;
+                                       tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                                       tmp_nmatch = 1;
+                                       break;
+
+                               case ACL_STYLE_ONE:
+                               case ACL_STYLE_SUBTREE:
+                               case ACL_STYLE_CHILDREN:
+                                       tmp_matches[0].rm_so = 0;
+                                       tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                                       tmp_matches[1].rm_so = e->e_nname.bv_len - a->acl_dn_pat.bv_len;
+                                       tmp_matches[1].rm_eo = e->e_nname.bv_len;
+                                       tmp_nmatch = 2;
+                                       break;
+
+                               default:
+                                       /* error */
+                                       rc = 1;
+                                       break;
+                               }
+
+                               if ( rc ) {
+                                       continue;
+                               }
+                               
+                               if ( string_expand( &bv, &b->a_group_pat,
+                                               e->e_nname.bv_val,
+                                               tmp_nmatch, tmp_matchesp ) )
+                               {
+                                       continue;
+                               }
 
-                               string_expand( &bv, &b->a_group_pat, e->e_ndn, matches );
-                               if ( dnNormalize( 0, NULL, NULL, &bv, &ndn, op->o_tmpmemctx ) != LDAP_SUCCESS ) {
+                               if ( dnNormalize( 0, NULL, NULL, &bv, &ndn,
+                                               op->o_tmpmemctx ) != LDAP_SUCCESS )
+                               {
                                        /* did not expand to a valid dn */
                                        continue;
                                }
@@ -1136,105 +1840,206 @@ dn_match_cleanup:;
                        rc = backend_group( op, e, &bv, &op->o_ndn,
                                b->a_group_oc, b->a_group_at );
 
-                       if ( ndn.bv_val ) free( ndn.bv_val );
+                       if ( ndn.bv_val ) {
+                               slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
+                       }
 
                        if ( rc != 0 ) {
                                continue;
                        }
                }
 
-               if ( b->a_set_pat.bv_len != 0 ) {
-                       struct berval bv;
-                       char buf[ACL_BUF_SIZE];
-                       if( b->a_set_style == ACL_STYLE_REGEX ){
-                               bv.bv_len = sizeof(buf) - 1;
+               if ( !BER_BVISEMPTY( &b->a_set_pat ) ) {
+                       struct berval   bv;
+                       char            buf[ACL_BUF_SIZE];
+
+                       Debug( LDAP_DEBUG_ACL, "<= check a_set_pat: %s\n",
+                               b->a_set_pat.bv_val, 0, 0 );
+
+                       if ( b->a_set_style == ACL_STYLE_EXPAND ) {
+                               int             tmp_nmatch;
+                               regmatch_t      tmp_matches[2],
+                                               *tmp_matchesp = tmp_matches;
+                               int             rc = 0;
+
+                               bv.bv_len = sizeof( buf ) - 1;
                                bv.bv_val = buf;
-                               string_expand( &bv, &b->a_set_pat, e->e_ndn, matches );
-                       }else{
+
+                               rc = 0;
+
+                               switch ( a->acl_dn_style ) {
+                               case ACL_STYLE_REGEX:
+                                       if ( !BER_BVISNULL( &a->acl_dn_pat ) ) {
+                                               tmp_matchesp = matches;
+                                               tmp_nmatch = nmatch;
+                                               break;
+                                       }
+
+                               /* FALLTHRU: applies also to ACL_STYLE_REGEX when pattern is "*" */
+                               case ACL_STYLE_BASE:
+                                       tmp_matches[0].rm_so = 0;
+                                       tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                                       tmp_nmatch = 1;
+                                       break;
+
+                               case ACL_STYLE_ONE:
+                               case ACL_STYLE_SUBTREE:
+                               case ACL_STYLE_CHILDREN:
+                                       tmp_matches[0].rm_so = 0;
+                                       tmp_matches[0].rm_eo = e->e_nname.bv_len;
+                                       tmp_matches[1].rm_so = e->e_nname.bv_len - a->acl_dn_pat.bv_len;
+                                       tmp_matches[1].rm_eo = e->e_nname.bv_len;
+                                       tmp_nmatch = 2;
+                                       break;
+
+                               default:
+                                       /* error */
+                                       rc = 1;
+                                       break;
+                               }
+
+                               if ( rc ) {
+                                       continue;
+                               }
+                               
+                               if ( string_expand( &bv, &b->a_set_pat,
+                                               e->e_nname.bv_val,
+                                               tmp_nmatch, tmp_matchesp ) )
+                               {
+                                       continue;
+                               }
+
+                       } else {
                                bv = b->a_set_pat;
                        }
-                       if (aci_match_set( &bv, op, e, 0 ) == 0) {
+                       
+                       if ( aci_match_set( &bv, op, e, 0 ) == 0 ) {
                                continue;
                        }
                }
 
                if ( b->a_authz.sai_ssf ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_mask: conn %lu  check a_authz.sai_ssf: ACL %u > OP %u\n",
-                               op->o_connid, b->a_authz.sai_ssf, op->o_ssf  );
-#else
                        Debug( LDAP_DEBUG_ACL, "<= check a_authz.sai_ssf: ACL %u > OP %u\n",
                                b->a_authz.sai_ssf, op->o_ssf, 0 );
-#endif
                        if ( b->a_authz.sai_ssf >  op->o_ssf ) {
                                continue;
                        }
                }
 
                if ( b->a_authz.sai_transport_ssf ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_mask: conn %lu  check a_authz.sai_transport_ssf: "
-                               "ACL %u > OP %u\n",
-                               op->o_connid, b->a_authz.sai_transport_ssf, 
-                               op->o_transport_ssf  );
-#else
                        Debug( LDAP_DEBUG_ACL,
                                "<= check a_authz.sai_transport_ssf: ACL %u > OP %u\n",
                                b->a_authz.sai_transport_ssf, op->o_transport_ssf, 0 );
-#endif
                        if ( b->a_authz.sai_transport_ssf >  op->o_transport_ssf ) {
                                continue;
                        }
                }
 
                if ( b->a_authz.sai_tls_ssf ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                               "acl_mask: conn %lu  check a_authz.sai_tls_ssf: ACL %u > "
-                               "OP %u\n",
-                               op->o_connid, b->a_authz.sai_tls_ssf, op->o_tls_ssf  );
-#else
                        Debug( LDAP_DEBUG_ACL,
                                "<= check a_authz.sai_tls_ssf: ACL %u > OP %u\n",
                                b->a_authz.sai_tls_ssf, op->o_tls_ssf, 0 );
-#endif
                        if ( b->a_authz.sai_tls_ssf >  op->o_tls_ssf ) {
                                continue;
                        }
                }
 
                if ( b->a_authz.sai_sasl_ssf ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                          "acl_mask: conn %lu check a_authz.sai_sasl_ssf: " 
-                          "ACL %u > OP %u\n",
-                               op->o_connid, b->a_authz.sai_sasl_ssf, op->o_sasl_ssf );
-#else
                        Debug( LDAP_DEBUG_ACL,
                                "<= check a_authz.sai_sasl_ssf: ACL %u > OP %u\n",
                                b->a_authz.sai_sasl_ssf, op->o_sasl_ssf, 0 );
-#endif
                        if ( b->a_authz.sai_sasl_ssf >  op->o_sasl_ssf ) {
                                continue;
                        }
                }
 
+#ifdef SLAP_DYNACL
+               if ( b->a_dynacl ) {
+                       slap_dynacl_t   *da;
+                       slap_access_t   tgrant, tdeny;
+
+                       Debug( LDAP_DEBUG_ACL, "<= check a_dynacl\n",
+                               0, 0, 0 );
+
+                       /* this case works different from the others above.
+                        * since aci's themselves give permissions, we need
+                        * to first check b->a_access_mask, the ACL's access level.
+                        */
+                       if ( BER_BVISEMPTY( &e->e_nname ) ) {
+                               /* no ACIs in the root DSE */
+                               continue;
+                       }
+
+                       /* first check if the right being requested
+                        * is allowed by the ACL clause.
+                        */
+                       if ( ! ACL_GRANT( b->a_access_mask, *mask ) ) {
+                               continue;
+                       }
+
+                       /* start out with nothing granted, nothing denied */
+                       ACL_INIT(tgrant);
+                       ACL_INIT(tdeny);
+
+                       for ( da = b->a_dynacl; da; da = da->da_next ) {
+                               slap_access_t   grant, deny;
+
+                               Debug( LDAP_DEBUG_ACL, "    <= check a_dynacl: %s\n",
+                                       da->da_name, 0, 0 );
+
+                               (void)( *da->da_mask )( da->da_private, op, e, desc, val, nmatch, matches, &grant, &deny );
+
+                               tgrant |= grant;
+                               tdeny |= deny;
+                       }
+
+                       /* remove anything that the ACL clause does not allow */
+                       tgrant &= b->a_access_mask & ACL_PRIV_MASK;
+                       tdeny &= ACL_PRIV_MASK;
+
+                       /* see if we have anything to contribute */
+                       if( ACL_IS_INVALID(tgrant) && ACL_IS_INVALID(tdeny) ) { 
+                               continue;
+                       }
+
+                       /* this could be improved by changing slap_acl_mask so that it can deal with
+                        * by clauses that return grant/deny pairs.  Right now, it does either
+                        * additive or subtractive rights, but not both at the same time.  So,
+                        * we need to combine the grant/deny pair into a single rights mask in
+                        * a smart way:  if either grant or deny is "empty", then we use the
+                        * opposite as is, otherwise we remove any denied rights from the grant
+                        * rights mask and construct an additive mask.
+                        */
+                       if (ACL_IS_INVALID(tdeny)) {
+                               modmask = tgrant | ACL_PRIV_ADDITIVE;
+
+                       } else if (ACL_IS_INVALID(tgrant)) {
+                               modmask = tdeny | ACL_PRIV_SUBSTRACTIVE;
+
+                       } else {
+                               modmask = (tgrant & ~tdeny) | ACL_PRIV_ADDITIVE;
+                       }
+
+               } else
+#else /* !SLAP_DYNACL */
+
 #ifdef SLAPD_ACI_ENABLED
                if ( b->a_aci_at != NULL ) {
                        Attribute       *at;
-                       slap_access_t grant, deny, tgrant, tdeny;
-                       struct berval parent_ndn, old_parent_ndn;
-                       BerVarray bvals = NULL;
-                       int ret,stop;
+                       slap_access_t   grant, deny, tgrant, tdeny;
+                       struct berval   parent_ndn;
+                       BerVarray       bvals = NULL;
+                       int             ret, stop;
+
+                       Debug( LDAP_DEBUG_ACL, "    <= check a_aci_at: %s\n",
+                               b->a_aci_at->ad_cname.bv_val, 0, 0 );
 
                        /* this case works different from the others above.
                         * since aci's themselves give permissions, we need
                         * to first check b->a_access_mask, the ACL's access level.
                         */
 
-                       if ( e->e_nname.bv_len == 0 ) {
+                       if ( BER_BVISEMPTY( &e->e_nname ) ) {
                                /* no ACIs in the root DSE */
                                continue;
                        }
@@ -1252,79 +2057,94 @@ dn_match_cleanup:;
                        /* get the aci attribute */
                        at = attr_find( e->e_attrs, b->a_aci_at );
                        if ( at != NULL ) {
+#if 0
+                               /* FIXME: this breaks acl caching;
+                                * see also ACL_RECORD_VALUE_STATE below */
                                ACL_RECORD_VALUE_STATE;
+#endif
                                /* the aci is an multi-valued attribute.  The
                                * rights are determined by OR'ing the individual
                                * rights given by the acis.
                                */
-                               for ( i = 0; at->a_vals[i].bv_val != NULL; i++ ) {
+                               for ( i = 0; !BER_BVISNULL( &at->a_nvals[i] ); i++ ) {
                                        if (aci_mask( op,
                                                e, desc, val,
                                                &at->a_nvals[i],
-                                               matches, &grant, &deny,  &aci_bv_entry ) != 0)
+                                               nmatch, matches,
+                                               &grant, &deny, SLAP_ACI_SCOPE_ENTRY ) != 0)
                                        {
                                                tgrant |= grant;
                                                tdeny |= deny;
                                        }
                                }
                                Debug(LDAP_DEBUG_ACL, "<= aci_mask grant %s deny %s\n",
-                                         accessmask2str(tgrant,accessmaskbuf), 
-                                         accessmask2str(tdeny, accessmaskbuf1), 0);
+                                         accessmask2str(tgrant, accessmaskbuf, 1), 
+                                         accessmask2str(tdeny, accessmaskbuf1, 1), 0);
 
                        }
                        /* If the entry level aci didn't contain anything valid for the 
                         * current operation, climb up the tree and evaluate the
                         * acis with scope set to subtree
                         */
-                       if( (tgrant == ACL_PRIV_NONE) && (tdeny == ACL_PRIV_NONE) ){
-                               dnParent(&(e->e_nname), &parent_ndn);
-                               while ( parent_ndn.bv_val != old_parent_ndn.bv_val ){
-                                       old_parent_ndn = parent_ndn;
+                       if ( (tgrant == ACL_PRIV_NONE) && (tdeny == ACL_PRIV_NONE) ) {
+                               dnParent( &e->e_nname, &parent_ndn );
+                               while ( !BER_BVISEMPTY( &parent_ndn ) ) {
                                        Debug(LDAP_DEBUG_ACL, "checking ACI of %s\n", parent_ndn.bv_val, 0, 0);
-                                       ret=backend_attribute(op, NULL, &parent_ndn, b->a_aci_at, &bvals);
+                                       ret = backend_attribute(op, NULL, &parent_ndn, b->a_aci_at, &bvals, ACL_AUTH);
                                        switch(ret){
-                                               case LDAP_SUCCESS :
-                                                       if(bvals){
-                                                               for( i = 0; bvals[i].bv_val != NULL; i++){
-                                                                       ACL_RECORD_VALUE_STATE;
-                                                                       if (aci_mask(op, e, desc, val, &bvals[i], matches,
-                                                                                       &grant, &deny, &aci_bv_children) != 0) {
-                                                                               tgrant |= grant;
-                                                                               tdeny |= deny;
-                                                                               /* evaluation stops as soon as either a "deny" or a 
-                                                                                * "grant" directive matches.
-                                                                                */
-                                                                               if( (tgrant != ACL_PRIV_NONE) || (tdeny != ACL_PRIV_NONE) ){
-                                                                                       stop=1;
-                                                                               }
-                                                                       }
-                                                                       Debug(LDAP_DEBUG_ACL, "<= aci_mask grant %s deny %s\n", 
-                                                                               accessmask2str(tgrant,accessmaskbuf),
-                                                                               accessmask2str(tdeny, accessmaskbuf1), 0);
+                                       case LDAP_SUCCESS :
+                                               stop = 0;
+                                               if (!bvals){
+                                                       break;
+                                               }
+
+                                               for( i = 0; bvals[i].bv_val != NULL; i++){
+#if 0
+                                                       /* FIXME: this breaks acl caching;
+                                                        * see also ACL_RECORD_VALUE_STATE above */
+                                                       ACL_RECORD_VALUE_STATE;
+#endif
+                                                       if (aci_mask(op, e, desc, val, &bvals[i],
+                                                                       nmatch, matches,
+                                                                       &grant, &deny, SLAP_ACI_SCOPE_CHILDREN ) != 0 )
+                                                       {
+                                                               tgrant |= grant;
+                                                               tdeny |= deny;
+                                                               /* evaluation stops as soon as either a "deny" or a 
+                                                                * "grant" directive matches.
+                                                                */
+                                                               if( (tgrant != ACL_PRIV_NONE) || (tdeny != ACL_PRIV_NONE) ){
+                                                                       stop = 1;
                                                                }
                                                        }
-                                                       stop=0;
-                                                       break;
-                                               case LDAP_NO_SUCH_ATTRIBUTE:
-                                                       /* just go on if the aci-Attribute is not present in
-                                                        * the current entry 
-                                                        */
-                                                       Debug(LDAP_DEBUG_ACL, "no such attribute\n", 0, 0, 0);
-                                                       stop=0;
-                                                       break;
-                                               case LDAP_NO_SUCH_OBJECT:
-                                                       /* We have reached the base object */
-                                                       Debug(LDAP_DEBUG_ACL, "no such object\n", 0, 0, 0);
-                                                       stop=1;
-                                                       break;
-                                               default:
-                                                       stop=1;
-                                                       break;
+                                                       Debug(LDAP_DEBUG_ACL, "<= aci_mask grant %s deny %s\n", 
+                                                               accessmask2str(tgrant, accessmaskbuf, 1),
+                                                               accessmask2str(tdeny, accessmaskbuf1, 1), 0);
+                                               }
+                                               break;
+
+                                       case LDAP_NO_SUCH_ATTRIBUTE:
+                                               /* just go on if the aci-Attribute is not present in
+                                                * the current entry 
+                                                */
+                                               Debug(LDAP_DEBUG_ACL, "no such attribute\n", 0, 0, 0);
+                                               stop = 0;
+                                               break;
+
+                                       case LDAP_NO_SUCH_OBJECT:
+                                               /* We have reached the base object */
+                                               Debug(LDAP_DEBUG_ACL, "no such object\n", 0, 0, 0);
+                                               stop = 1;
+                                               break;
+
+                                       default:
+                                               stop = 1;
+                                               break;
                                        }
-                                       if(stop){
+                                       if (stop){
                                                break;
                                        }
-                                       dnParent(&old_parent_ndn, &parent_ndn);
+                                       dnParent( &parent_ndn, &parent_ndn );
                                }
                        }
 
@@ -1338,7 +2158,7 @@ dn_match_cleanup:;
                                continue;
                        }
 
-                       /* this could be improved by changing acl_mask so that it can deal with
+                       /* this could be improved by changing slap_acl_mask so that it can deal with
                         * by clauses that return grant/deny pairs.  Right now, it does either
                         * additive or subtractive rights, but not both at the same time.  So,
                         * we need to combine the grant/deny pair into a single rights mask in
@@ -1357,27 +2177,20 @@ dn_match_cleanup:;
                        }
 
                } else
-#endif
+#endif /* SLAPD_ACI_ENABLED */
+#endif /* !SLAP_DYNACL */
                {
                        modmask = b->a_access_mask;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, RESULTS, 
-                          "acl_mask: [%d] applying %s (%s)\n",
-                          i, accessmask2str( modmask, accessmaskbuf),
-                          b->a_type == ACL_CONTINUE ? "continue" : b->a_type == ACL_BREAK
-                          ? "break" : "stop"  );
-#else
                Debug( LDAP_DEBUG_ACL,
                        "<= acl_mask: [%d] applying %s (%s)\n",
-                       i, accessmask2str( modmask, accessmaskbuf ), 
+                       i, accessmask2str( modmask, accessmaskbuf, 1 ), 
                        b->a_type == ACL_CONTINUE
                                ? "continue"
                                : b->a_type == ACL_BREAK
                                        ? "break"
                                        : "stop" );
-#endif
                /* save old mask */
                oldmask = *mask;
 
@@ -1400,15 +2213,9 @@ dn_match_cleanup:;
                        *mask = modmask;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                          "acl_mask: conn %lu  [%d] mask: %s\n",
-                          op->o_connid, i, accessmask2str( *mask, accessmaskbuf)  );
-#else
                Debug( LDAP_DEBUG_ACL,
                        "<= acl_mask: [%d] mask: %s\n",
-                       i, accessmask2str(*mask, accessmaskbuf), 0 );
-#endif
+                       i, accessmask2str(*mask, accessmaskbuf, 1), 0 );
 
                if( b->a_type == ACL_CONTINUE ) {
                        continue;
@@ -1424,15 +2231,9 @@ dn_match_cleanup:;
        /* implicit "by * none" clause */
        ACL_INIT(*mask);
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, RESULTS, 
-                  "acl_mask: conn %lu  no more <who> clauses, returning %d (stop)\n",
-                  op->o_connid, accessmask2str( *mask, accessmaskbuf) , 0 );
-#else
        Debug( LDAP_DEBUG_ACL,
                "<= acl_mask: no more <who> clauses, returning %s (stop)\n",
-               accessmask2str(*mask, accessmaskbuf), 0, 0 );
-#endif
+               accessmask2str(*mask, accessmaskbuf, 1), 0, 0 );
        return ACL_STOP;
 }
 
@@ -1440,7 +2241,7 @@ dn_match_cleanup:;
  * acl_check_modlist - check access control on the given entry to see if
  * it allows the given modifications by the user associated with op.
  * returns     1       if mods allowed ok
- *                     0       mods not allowed
+ *             0       mods not allowed
  */
 
 int
@@ -1458,60 +2259,52 @@ acl_check_modlist(
 
        be = op->o_bd;
        if ( be == NULL ) {
-               be = &backends[0];
+               be = LDAP_STAILQ_FIRST(&backendDB);
                be_null = 1;
                op->o_bd = be;
        }
        assert( be != NULL );
 
        /* short circuit root database access */
-       if ( be_isroot( op->o_bd, &op->o_ndn ) ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                          "acl_check_modlist: conn %lu  access granted to root user\n",
-                          op->o_connid, 0, 0 );
-#else
+       if ( be_isroot( op ) ) {
                Debug( LDAP_DEBUG_ACL,
                        "<= acl_access_allowed: granted to database root\n",
                    0, 0, 0 );
-#endif
                goto done;
        }
 
        /* use backend default access if no backend acls */
        if( op->o_bd != NULL && op->o_bd->be_acl == NULL ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, DETAIL1, 
-                       "acl_check_modlist: backend default %s access %s to \"%s\"\n",
-                       access2str( ACL_WRITE ),
-                       op->o_bd->be_dfltaccess >= ACL_WRITE ? "granted" : "denied", 
-                       op->o_dn.bv_val  );
-#else
                Debug( LDAP_DEBUG_ACL,
                        "=> access_allowed: backend default %s access %s to \"%s\"\n",
                        access2str( ACL_WRITE ),
-                       op->o_bd->be_dfltaccess >= ACL_WRITE ? "granted" : "denied", op->o_dn.bv_val );
-#endif
+                       op->o_bd->be_dfltaccess >= ACL_WRITE
+                               ? "granted" : "denied",
+                       op->o_dn.bv_val );
                ret = (op->o_bd->be_dfltaccess >= ACL_WRITE);
                goto done;
        }
 
        for ( ; mlist != NULL; mlist = mlist->sml_next ) {
+               /*
+                * Internal mods are ignored by ACL_WRITE checking
+                */
+               if ( mlist->sml_flags & SLAP_MOD_INTERNAL ) {
+                       Debug( LDAP_DEBUG_ACL, "acl: internal mod %s:"
+                               " modify access granted\n",
+                               mlist->sml_desc->ad_cname.bv_val, 0, 0 );
+                       continue;
+               }
+
                /*
                 * no-user-modification operational attributes are ignored
                 * by ACL_WRITE checking as any found here are not provided
                 * by the user
                 */
                if ( is_at_no_user_mod( mlist->sml_desc->ad_type ) ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( ACL, DETAIL1, 
-                                  "acl_check_modlist: conn %lu  no-user-mod %s: modify access granted\n",
-                                  op->o_connid, mlist->sml_desc->ad_cname.bv_val , 0 );
-#else
                        Debug( LDAP_DEBUG_ACL, "acl: no-user-mod %s:"
                                " modify access granted\n",
                                mlist->sml_desc->ad_cname.bv_val, 0, 0 );
-#endif
                        continue;
                }
 
@@ -1523,25 +2316,25 @@ acl_check_modlist(
                         * This prevents abuse from selfwriters.
                         */
                        if ( ! access_allowed( op, e,
-                               mlist->sml_desc, NULL, ACL_WRITE, &state ) )
+                               mlist->sml_desc, NULL, ACL_WDEL, &state ) )
                        {
                                ret = 0;
                                goto done;
                        }
 
-                       if ( mlist->sml_bvalues == NULL ) break;
+                       if ( mlist->sml_values == NULL ) break;
 
                        /* fall thru to check value to add */
 
                case LDAP_MOD_ADD:
-                       assert( mlist->sml_bvalues != NULL );
+                       assert( mlist->sml_values != NULL );
 
                        for ( bv = mlist->sml_nvalues
                                        ? mlist->sml_nvalues : mlist->sml_values;
                                bv->bv_val != NULL; bv++ )
                        {
                                if ( ! access_allowed( op, e,
-                                       mlist->sml_desc, bv, ACL_WRITE, &state ) )
+                                       mlist->sml_desc, bv, ACL_WADD, &state ) )
                                {
                                        ret = 0;
                                        goto done;
@@ -1550,9 +2343,9 @@ acl_check_modlist(
                        break;
 
                case LDAP_MOD_DELETE:
-                       if ( mlist->sml_bvalues == NULL ) {
+                       if ( mlist->sml_values == NULL ) {
                                if ( ! access_allowed( op, e,
-                                       mlist->sml_desc, NULL, ACL_WRITE, NULL ) )
+                                       mlist->sml_desc, NULL, ACL_WDEL, NULL ) )
                                {
                                        ret = 0;
                                        goto done;
@@ -1564,7 +2357,7 @@ acl_check_modlist(
                                bv->bv_val != NULL; bv++ )
                        {
                                if ( ! access_allowed( op, e,
-                                       mlist->sml_desc, bv, ACL_WRITE, &state ) )
+                                       mlist->sml_desc, bv, ACL_WDEL, &state ) )
                                {
                                        ret = 0;
                                        goto done;
@@ -1572,84 +2365,288 @@ acl_check_modlist(
                        }
                        break;
 
-               case SLAP_MOD_SOFTADD:
-                       /* allow adding attribute via modrdn thru */
-                       break;
+               case SLAP_MOD_SOFTADD:
+                       /* allow adding attribute via modrdn thru */
+                       break;
+
+               default:
+                       assert( 0 );
+                       /* not reached */
+                       ret = 0;
+                       break;
+               }
+       }
+
+done:
+       if (be_null) op->o_bd = NULL;
+       return( ret );
+}
+
+static int
+aci_get_part(
+       struct berval   *list,
+       int             ix,
+       char            sep,
+       struct berval   *bv )
+{
+       int     len;
+       char    *p;
+
+       if ( bv ) {
+               BER_BVZERO( bv );
+       }
+       len = list->bv_len;
+       p = list->bv_val;
+       while ( len >= 0 && --ix >= 0 ) {
+               while ( --len >= 0 && *p++ != sep )
+                       ;
+       }
+       while ( len >= 0 && *p == ' ' ) {
+               len--;
+               p++;
+       }
+       if ( len < 0 ) {
+               return -1;
+       }
+
+       if ( !bv ) {
+               return 0;
+       }
+
+       bv->bv_val = p;
+       while ( --len >= 0 && *p != sep ) {
+               bv->bv_len++;
+               p++;
+       }
+       while ( bv->bv_len > 0 && *--p == ' ' ) {
+               bv->bv_len--;
+       }
+       
+       return bv->bv_len;
+}
+
+typedef struct aci_set_gather_t {
+       SetCookie               *cookie;
+       BerVarray               bvals;
+} aci_set_gather_t;
+
+static int
+aci_set_cb_gather( Operation *op, SlapReply *rs )
+{
+       aci_set_gather_t        *p = (aci_set_gather_t *)op->o_callback->sc_private;
+       
+       if ( rs->sr_type == REP_SEARCH ) {
+               BerValue        bvals[ 2 ];
+               BerVarray       bvalsp = NULL;
+               int             j;
+
+               for ( j = 0; !BER_BVISNULL( &rs->sr_attrs[ j ].an_name ); j++ ) {
+                       AttributeDescription    *desc = rs->sr_attrs[ j ].an_desc;
+                       
+                       if ( desc == slap_schema.si_ad_entryDN ) {
+                               bvalsp = bvals;
+                               bvals[ 0 ] = rs->sr_entry->e_nname;
+                               BER_BVZERO( &bvals[ 1 ] );
+
+                       } else {
+                               Attribute       *a;
+
+                               a = attr_find( rs->sr_entry->e_attrs, desc );
+                               if ( a != NULL ) {
+                                       int     i;
+
+                                       for ( i = 0; !BER_BVISNULL( &a->a_nvals[ i ] ); i++ )
+                                               ;
+
+                                       bvalsp = a->a_nvals;
+                               }
+                       }
+               }
+
+               if ( bvals ) {
+                       p->bvals = slap_set_join( p->cookie, p->bvals,
+                                       ( '|' | SLAP_SET_RREF ), bvalsp );
+               }
+
+       } else {
+               assert( rs->sr_type == REP_RESULT );
+       }
+
+       return 0;
+}
+
+BerVarray
+aci_set_gather( SetCookie *cookie, struct berval *name, AttributeDescription *desc )
+{
+       AciSetCookie            *cp = (AciSetCookie *)cookie;
+       int                     rc = 0;
+       LDAPURLDesc             *ludp = NULL;
+       Operation               op2 = { 0 };
+       SlapReply               rs = {REP_RESULT};
+       AttributeName           anlist[ 2 ], *anlistp = NULL;
+       int                     nattrs = 0;
+       slap_callback           cb = { NULL, aci_set_cb_gather, NULL, NULL };
+       aci_set_gather_t        p = { 0 };
+       const char              *text = NULL;
+       static struct berval    defaultFilter_bv = BER_BVC( "(objectClass=*)" );
+
+       /* this routine needs to return the bervals instead of
+        * plain strings, since syntax is not known.  It should
+        * also return the syntax or some "comparison cookie".
+        */
+       if ( strncasecmp( name->bv_val, "ldap:///", STRLENOF( "ldap:///" ) ) != 0 ) {
+               return aci_set_gather2( cookie, name, desc );
+       }
+
+       rc = ldap_url_parse( name->bv_val, &ludp );
+       if ( rc != LDAP_URL_SUCCESS ) {
+               rc = LDAP_PROTOCOL_ERROR;
+               goto url_done;
+       }
+       
+       if ( ( ludp->lud_host && ludp->lud_host[0] ) || ludp->lud_exts )
+       {
+               /* host part must be empty */
+               /* extensions parts must be empty */
+               rc = LDAP_PROTOCOL_ERROR;
+               goto url_done;
+       }
+
+       /* Grab the searchbase and see if an appropriate database can be found */
+       ber_str2bv( ludp->lud_dn, 0, 0, &op2.o_req_dn );
+       rc = dnNormalize( 0, NULL, NULL, &op2.o_req_dn,
+                       &op2.o_req_ndn, cp->op->o_tmpmemctx );
+       BER_BVZERO( &op2.o_req_dn );
+       if ( rc != LDAP_SUCCESS ) {
+               goto url_done;
+       }
+
+       op2.o_bd = select_backend( &op2.o_req_ndn, 0, 1 );
+       if ( ( op2.o_bd == NULL ) || ( op2.o_bd->be_search == NULL ) ) {
+               rc = LDAP_NO_SUCH_OBJECT;
+               goto url_done;
+       }
+
+       /* Grab the filter */
+       if ( ludp->lud_filter ) {
+               ber_str2bv_x( ludp->lud_filter, 0, 0, &op2.ors_filterstr,
+                               cp->op->o_tmpmemctx );
+               
+       } else {
+               op2.ors_filterstr = defaultFilter_bv;
+       }
 
-               default:
-                       assert( 0 );
-                       /* not reached */
-                       ret = 0;
-                       break;
+       op2.ors_filter = str2filter_x( cp->op, op2.ors_filterstr.bv_val );
+       if ( op2.ors_filter == NULL ) {
+               rc = LDAP_PROTOCOL_ERROR;
+               goto url_done;
+       }
+
+       /* Grab the scope */
+       op2.ors_scope = ludp->lud_scope;
+
+       /* Grap the attributes */
+       if ( ludp->lud_attrs ) {
+               for ( ; ludp->lud_attrs[ nattrs ]; nattrs++ )
+                       ;
+
+               anlistp = slap_sl_malloc( sizeof( AttributeName ) * ( nattrs + 2 ),
+                               cp->op->o_tmpmemctx );
+
+               for ( ; ludp->lud_attrs[ nattrs ]; nattrs++ ) {
+                       ber_str2bv( ludp->lud_attrs[ nattrs ], 0, 0, &anlistp[ nattrs ].an_name );
+                       anlistp[ nattrs ].an_desc = NULL;
+                       rc = slap_bv2ad( &anlistp[ nattrs ].an_name,
+                                       &anlistp[ nattrs ].an_desc, &text );
+                       if ( rc != LDAP_SUCCESS ) {
+                               goto url_done;
+                       }
                }
+
+       } else {
+               anlistp = anlist;
        }
 
-done:
-       if (be_null) op->o_bd = NULL;
-       return( ret );
-}
+       anlistp[ nattrs ].an_name = desc->ad_cname;
+       anlistp[ nattrs ].an_desc = desc;
 
-static int
-aci_get_part(
-       struct berval *list,
-       int ix,
-       char sep,
-       struct berval *bv )
-{
-       int len;
-       char *p;
+       BER_BVZERO( &anlistp[ nattrs + 1 ].an_name );
+       
+       p.cookie = cookie;
+       
+       op2.o_hdr = cp->op->o_hdr;
+       op2.o_tag = LDAP_REQ_SEARCH;
+       op2.o_ndn = op2.o_bd->be_rootndn;
+       op2.o_callback = &cb;
+       op2.o_time = slap_get_time();
+       op2.o_do_not_cache = 1;
+       op2.o_is_auth_check = 0;
+       ber_dupbv_x( &op2.o_req_dn, &op2.o_req_ndn, cp->op->o_tmpmemctx );
+       op2.ors_slimit = SLAP_NO_LIMIT;
+       op2.ors_tlimit = SLAP_NO_LIMIT;
+       op2.ors_attrs = anlistp;
+       op2.ors_attrsonly = 0;
+       op2.o_private = cp->op->o_private;
+
+       cb.sc_private = &p;
+
+       rc = op2.o_bd->be_search( &op2, &rs );
+       if ( rc != 0 ) {
+               goto url_done;
+       }
 
-       if (bv) {
-               bv->bv_len = 0;
-               bv->bv_val = NULL;
+url_done:;
+       if ( op2.ors_filter ) {
+               filter_free_x( cp->op, op2.ors_filter );
        }
-       len = list->bv_len;
-       p = list->bv_val;
-       while (len >= 0 && --ix >= 0) {
-               while (--len >= 0 && *p++ != sep) ;
+       if ( !BER_BVISNULL( &op2.o_req_ndn ) ) {
+               slap_sl_free( op2.o_req_ndn.bv_val, cp->op->o_tmpmemctx );
        }
-       while (len >= 0 && *p == ' ') {
-               len--;
-               p++;
+       if ( !BER_BVISNULL( &op2.o_req_dn ) ) {
+               slap_sl_free( op2.o_req_dn.bv_val, cp->op->o_tmpmemctx );
        }
-       if (len < 0)
-               return(-1);
-
-       if (!bv)
-               return(0);
-
-       bv->bv_val = p;
-       while (--len >= 0 && *p != sep) {
-               bv->bv_len++;
-               p++;
+       if ( ludp ) {
+               ldap_free_urldesc( ludp );
        }
-       while (bv->bv_len > 0 && *--p == ' ')
-               bv->bv_len--;
-       return(bv->bv_len);
+       if ( anlistp && anlistp != anlist ) {
+               slap_sl_free( anlistp, cp->op->o_tmpmemctx );
+       }
+
+       return p.bvals;
 }
 
 BerVarray
-aci_set_gather (SetCookie *cookie, struct berval *name, struct berval *attr)
+aci_set_gather2( SetCookie *cookie, struct berval *name, AttributeDescription *desc )
 {
-       AciSetCookie *cp = (AciSetCookie *)cookie;
-       BerVarray bvals = NULL;
-       struct berval ndn;
+       AciSetCookie    *cp = (AciSetCookie *)cookie;
+       BerVarray       bvals = NULL;
+       struct berval   ndn;
+       int             rc = 0;
 
        /* this routine needs to return the bervals instead of
         * plain strings, since syntax is not known.  It should
         * also return the syntax or some "comparison cookie".
         */
+       rc = dnNormalize( 0, NULL, NULL, name, &ndn, cp->op->o_tmpmemctx );
+       if ( rc == LDAP_SUCCESS ) {
+               if ( desc == slap_schema.si_ad_entryDN ) {
+                       bvals = (BerVarray)slap_sl_malloc( sizeof( BerValue ) * 2,
+                                       cp->op->o_tmpmemctx );
+                       bvals[ 0 ] = ndn;
+                       BER_BVZERO( &bvals[ 1 ] );
+                       BER_BVZERO( &ndn );
+
+               } else {
+                       backend_attribute( cp->op,
+                               cp->e, &ndn, desc, &bvals, ACL_NONE );
+               }
 
-       if (dnNormalize(0, NULL, NULL, name, &ndn, cp->op->o_tmpmemctx) == LDAP_SUCCESS) {
-               const char *text;
-               AttributeDescription *desc = NULL;
-               if (slap_bv2ad(attr, &desc, &text) == LDAP_SUCCESS) {
-                       backend_attribute(cp->op,
-                               cp->e, &ndn, desc, &bvals);
+               if ( !BER_BVISNULL( &ndn ) ) {
+                       slap_sl_free( ndn.bv_val, cp->op->o_tmpmemctx );
                }
-               sl_free(ndn.bv_val, cp->op->o_tmpmemctx);
        }
-       return(bvals);
+
+       return bvals;
 }
 
 static int
@@ -1660,63 +2657,61 @@ aci_match_set (
        int setref
 )
 {
-       struct berval set = { 0, NULL };
-       int rc = 0;
-       AciSetCookie cookie;
+       struct berval   set = BER_BVNULL;
+       int             rc = 0;
+       AciSetCookie    cookie;
 
-       if (setref == 0) {
+       if ( setref == 0 ) {
                ber_dupbv_x( &set, subj, op->o_tmpmemctx );
+
        } else {
-               struct berval subjdn, ndn = { 0, NULL };
-               struct berval setat;
-               BerVarray bvals;
-               const char *text;
-               AttributeDescription *desc = NULL;
+               struct berval           subjdn, ndn = BER_BVNULL;
+               struct berval           setat;
+               BerVarray               bvals;
+               const char              *text;
+               AttributeDescription    *desc = NULL;
 
                /* format of string is "entry/setAttrName" */
-               if (aci_get_part(subj, 0, '/', &subjdn) < 0) {
-                       return(0);
+               if ( aci_get_part( subj, 0, '/', &subjdn ) < 0 ) {
+                       return 0;
                }
 
-               if ( aci_get_part(subj, 1, '/', &setat) < 0 ) {
-                       setat.bv_val = SLAPD_ACI_SET_ATTR;
-                       setat.bv_len = sizeof(SLAPD_ACI_SET_ATTR)-1;
+               if ( aci_get_part( subj, 1, '/', &setat ) < 0 ) {
+                       setat = aci_bv_set_attr;
                }
 
-               if ( setat.bv_val != NULL ) {
-                       /*
-                        * NOTE: dnNormalize honors the ber_len field
-                        * as the length of the dn to be normalized
-                        */
-                       if ( dnNormalize(0, NULL, NULL, &subjdn, &ndn, op->o_tmpmemctx) == LDAP_SUCCESS
-                               && slap_bv2ad(&setat, &desc, &text) == LDAP_SUCCESS )
+               /*
+                * NOTE: dnNormalize honors the ber_len field
+                * as the length of the dn to be normalized
+                */
+               if ( slap_bv2ad( &setat, &desc, &text ) == LDAP_SUCCESS ) {
+                       if ( dnNormalize( 0, NULL, NULL, &subjdn, &ndn, op->o_tmpmemctx ) == LDAP_SUCCESS )
                        {
-                               backend_attribute(op, e,
-                                       &ndn, desc, &bvals);
-                               if ( bvals != NULL ) {
-                                       if ( bvals[0].bv_val != NULL ) {
-                                               int i;
-                                               set = bvals[0];
-                                               bvals[0].bv_val = NULL;
-                                               for (i=1;bvals[i].bv_val;i++);
-                                               bvals[0].bv_val = bvals[i-1].bv_val;
-                                               bvals[i-1].bv_val = NULL;
-                                       }
-                                       ber_bvarray_free_x(bvals, op->o_tmpmemctx);
+                               backend_attribute( op, e, &ndn, desc, &bvals, ACL_NONE );
+                               if ( bvals != NULL && !BER_BVISNULL( &bvals[0] ) ) {
+                                       int     i;
+
+                                       set = bvals[0];
+                                       BER_BVZERO( &bvals[0] );
+                                       for ( i = 1; !BER_BVISNULL( &bvals[i] ); i++ )
+                                               /* count */ ;
+                                       bvals[0].bv_val = bvals[i-1].bv_val;
+                                       BER_BVZERO( &bvals[i-1] );
                                }
+                               ber_bvarray_free_x( bvals, op->o_tmpmemctx );
+                               slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
                        }
-                       if (ndn.bv_val)
-                               free(ndn.bv_val);
                }
        }
 
-       if (set.bv_val != NULL) {
+       if ( !BER_BVISNULL( &set ) ) {
                cookie.op = op;
                cookie.e = e;
-               rc = (slap_set_filter(aci_set_gather, (SetCookie *)&cookie, &set,
-                       &op->o_ndn, &e->e_nname, NULL) > 0);
-               sl_free(set.bv_val, op->o_tmpmemctx);
+               rc = ( slap_set_filter( aci_set_gather, (SetCookie *)&cookie, &set,
+                       &op->o_ndn, &e->e_nname, NULL ) > 0 );
+               slap_sl_free( set.bv_val, op->o_tmpmemctx );
        }
+
        return(rc);
 }
 
@@ -1878,11 +2873,12 @@ aci_list_get_rights(
 
 static int
 aci_group_member (
-       struct berval *subj,
-       struct berval *defgrpoc,
-       struct berval *defgrpat,
-       Operation               *op,
+       struct berval   *subj,
+       struct berval   *defgrpoc,
+       struct berval   *defgrpat,
+       Operation       *op,
        Entry           *e,
+       int             nmatch,
        regmatch_t      *matches
 )
 {
@@ -1921,11 +2917,16 @@ aci_group_member (
                struct berval bv, ndn;
                bv.bv_len = sizeof( buf ) - 1;
                bv.bv_val = (char *)&buf;
-               string_expand(&bv, &subjdn, e->e_ndn, matches);
-               if ( dnNormalize(0, NULL, NULL, &bv, &ndn, op->o_tmpmemctx) == LDAP_SUCCESS ) {
-                       rc = (backend_group(op, e, &ndn, &op->o_ndn,
-                               grp_oc, grp_ad) == 0);
-                       free( ndn.bv_val );
+               if ( string_expand(&bv, &subjdn,
+                               e->e_ndn, nmatch, matches) )
+               {
+                       rc = LDAP_OTHER;
+                       goto done;
+               }
+               if ( dnNormalize( 0, NULL, NULL, &bv, &ndn, op->o_tmpmemctx ) == LDAP_SUCCESS ) {
+                       rc = ( backend_group( op, e, &ndn, &op->o_ndn,
+                               grp_oc, grp_ad ) == 0 );
+                       slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
                }
        }
 
@@ -1935,84 +2936,201 @@ done:
 
 static int
 aci_mask(
-    Operation          *op,
-    Entry                      *e,
-       AttributeDescription *desc,
-    struct berval      *val,
-    struct berval      *aci,
+       Operation               *op,
+       Entry                   *e,
+       AttributeDescription    *desc,
+       struct berval           *val,
+       struct berval           *aci,
+       int                     nmatch,
        regmatch_t              *matches,
-       slap_access_t   *grant,
-       slap_access_t   *deny,
-       struct berval   *scope
+       slap_access_t           *grant,
+       slap_access_t           *deny,
+       slap_aci_scope_t        asserted_scope
 )
 {
-    struct berval bv, perms, sdn;
-       int rc;
+       struct berval           bv, scope, perms, type, sdn;
+       int                     rc;
                
 
-       assert( desc->ad_cname.bv_val != NULL );
+       assert( !BER_BVISNULL( &desc->ad_cname ) );
 
        /* parse an aci of the form:
-               oid#scope#action;rights;attr;rights;attr$action;rights;attr;rights;attr#dnType#subjectDN
+               oid # scope # action;rights;attr;rights;attr 
+                       $ action;rights;attr;rights;attr # type # subject
+
+          [NOTE: the following comment is very outdated,
+          as the draft version it refers to (Ando, 2004-11-20)].
 
           See draft-ietf-ldapext-aci-model-04.txt section 9.1 for
           a full description of the format for this attribute.
           Differences: "this" in the draft is "self" here, and
-          "self" and "public" is in the position of dnType.
+          "self" and "public" is in the position of type.
+
+          <scope> = {entry|children|subtree}
+          <type> = {public|users|access-id|subtree|onelevel|children|
+                    self|dnattr|group|role|set|set-ref}
 
-          For now, this routine only supports scope=entry.
+          This routine now supports scope={ENTRY,CHILDREN}
+          with the semantics:
+            - ENTRY applies to "entry" and "subtree";
+            - CHILDREN aplies to "children" and "subtree"
         */
+
        /* check that the aci has all 5 components */
-       if (aci_get_part(aci, 4, '#', NULL) < 0)
-               return(0);
+       if ( aci_get_part( aci, 4, '#', NULL ) < 0 ) {
+               return 0;
+       }
 
        /* check that the aci family is supported */
-       if (aci_get_part(aci, 0, '#', &bv) < 0)
-               return(0);
+       if ( aci_get_part( aci, 0, '#', &bv ) < 0 ) {
+               return 0;
+       }
 
        /* check that the scope matches */
-       if (aci_get_part(aci, 1, '#', &bv) < 0
-               || ber_bvstrcasecmp( scope, &bv ) != 0)
-       {
-               return(0);
+       if ( aci_get_part( aci, 1, '#', &scope ) < 0 ) {
+               return 0;
+       }
+
+       /* note: scope can be either ENTRY or CHILDREN;
+        * they respectively match "entry" and "children" in bv
+        * both match "subtree" */
+       switch ( asserted_scope ) {
+       case SLAP_ACI_SCOPE_ENTRY:
+               if ( ber_bvstrcasecmp( &scope, &aci_bv_entry ) != 0
+                               && ber_bvstrcasecmp( &scope, &aci_bv_subtree ) != 0 )
+               {
+                       return 0;
+               }
+               break;
+
+       case SLAP_ACI_SCOPE_CHILDREN:
+               if ( ber_bvstrcasecmp( &scope, &aci_bv_children ) != 0
+                               && ber_bvstrcasecmp( &scope, &aci_bv_subtree ) != 0 )
+               {
+                       return 0;
+               }
+               break;
+
+       default:
+               return 0;
        }
 
        /* get the list of permissions clauses, bail if empty */
-       if (aci_get_part(aci, 2, '#', &perms) <= 0)
-               return(0);
+       if ( aci_get_part( aci, 2, '#', &perms ) <= 0 ) {
+               return 0;
+       }
 
        /* check if any permissions allow desired access */
-       if (aci_list_get_rights(&perms, &desc->ad_cname, val, grant, deny) == 0)
-               return(0);
+       if ( aci_list_get_rights( &perms, &desc->ad_cname, val, grant, deny ) == 0 ) {
+               return 0;
+       }
 
        /* see if we have a DN match */
-       if (aci_get_part(aci, 3, '#', &bv) < 0)
-               return(0);
+       if ( aci_get_part( aci, 3, '#', &type ) < 0 ) {
+               return 0;
+       }
 
-       if (aci_get_part(aci, 4, '#', &sdn) < 0)
-               return(0);
+       /* see if we have a public (i.e. anonymous) access */
+       if ( ber_bvstrcasecmp( &aci_bv_public, &type ) == 0 ) {
+               return 1;
+       }
+       
+       /* otherwise require an identity */
+       if ( BER_BVISNULL( &op->o_ndn ) || BER_BVISEMPTY( &op->o_ndn ) ) {
+               return 0;
+       }
+
+       /* see if we have a users access */
+       if ( ber_bvstrcasecmp( &aci_bv_users, &type ) == 0 ) {
+               return 1;
+       }
+       
+       /* NOTE: this may fail if a DN contains a valid '#' (unescaped);
+        * just grab all the berval up to its end (ITS#3303).
+        * NOTE: the problem could be solved by providing the DN with
+        * the embedded '#' encoded as hexpairs: "cn=Foo#Bar" would 
+        * become "cn=Foo\23Bar" and be safely used by aci_mask(). */
+#if 0
+       if ( aci_get_part( aci, 4, '#', &sdn ) < 0 ) {
+               return 0;
+       }
+#endif
+       sdn.bv_val = type.bv_val + type.bv_len + STRLENOF( "#" );
+       sdn.bv_len = aci->bv_len - ( sdn.bv_val - aci->bv_val );
 
-       if (ber_bvstrcasecmp( &aci_bv_access_id, &bv ) == 0) {
+       if ( ber_bvstrcasecmp( &aci_bv_access_id, &type ) == 0 ) {
                struct berval ndn;
-               rc = 0;
-               if ( dnNormalize(0, NULL, NULL, &sdn, &ndn, op->o_tmpmemctx) == LDAP_SUCCESS ) {
-                       if (dn_match( &op->o_ndn, &ndn))
-                               rc = 1;
-                       free(ndn.bv_val);
+               
+               rc = dnNormalize( 0, NULL, NULL, &sdn, &ndn, op->o_tmpmemctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return 0;
+               }
+
+               if ( dn_match( &op->o_ndn, &ndn ) ) {
+                       rc = 1;
+               }
+               slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
+
+               return rc;
+
+       } else if ( ber_bvstrcasecmp( &aci_bv_subtree, &type ) == 0 ) {
+               struct berval ndn;
+               
+               rc = dnNormalize( 0, NULL, NULL, &sdn, &ndn, op->o_tmpmemctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return 0;
+               }
+
+               if ( dnIsSuffix( &op->o_ndn, &ndn ) ) {
+                       rc = 1;
+               }
+               slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
+
+               return rc;
+
+       } else if ( ber_bvstrcasecmp( &aci_bv_onelevel, &type ) == 0 ) {
+               struct berval ndn, pndn;
+               
+               rc = dnNormalize( 0, NULL, NULL, &sdn, &ndn, op->o_tmpmemctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return 0;
+               }
+
+               dnParent( &ndn, &pndn );
+
+               if ( dn_match( &op->o_ndn, &pndn ) ) {
+                       rc = 1;
+               }
+               slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
+
+               return rc;
+
+       } else if ( ber_bvstrcasecmp( &aci_bv_children, &type ) == 0 ) {
+               struct berval ndn;
+               
+               rc = dnNormalize( 0, NULL, NULL, &sdn, &ndn, op->o_tmpmemctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return 0;
+               }
+
+               if ( !dn_match( &op->o_ndn, &ndn )
+                               && dnIsSuffix( &op->o_ndn, &ndn ) )
+               {
+                       rc = 1;
                }
-               return (rc);
+               slap_sl_free( ndn.bv_val, op->o_tmpmemctx );
 
-       } else if (ber_bvstrcasecmp( &aci_bv_public, &bv ) == 0) {
-               return(1);
+               return rc;
 
-       } else if (ber_bvstrcasecmp( &aci_bv_self, &bv ) == 0) {
-               if (dn_match(&op->o_ndn, &e->e_nname))
-                       return(1);
+       } else if ( ber_bvstrcasecmp( &aci_bv_self, &type ) == 0 ) {
+               if ( dn_match( &op->o_ndn, &e->e_nname ) ) {
+                       return 1;
+               }
 
-       } else if (ber_bvstrcasecmp( &aci_bv_dnattr, &bv ) == 0) {
-               Attribute *at;
-               AttributeDescription *ad = NULL;
-               const char *text;
+       } else if ( ber_bvstrcasecmp( &aci_bv_dnattr, &type ) == 0 ) {
+               Attribute               *at;
+               AttributeDescription    *ad = NULL;
+               const char              *text;
 
                rc = slap_bv2ad( &sdn, &ad, &text );
 
@@ -2022,17 +3140,15 @@ aci_mask(
 
                rc = 0;
 
-               bv = op->o_ndn;
-
-               for(at = attrs_find( e->e_attrs, ad );
-                       at != NULL;
-                       at = attrs_find( at->a_next, ad ) )
+               for ( at = attrs_find( e->e_attrs, ad );
+                               at != NULL;
+                               at = attrs_find( at->a_next, ad ) )
                {
-                       if (value_find_ex( ad,
+                       if ( value_find_ex( ad,
                                SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH |
                                        SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH,
                                at->a_nvals,
-                               &bv, op->o_tmpmemctx) == 0 )
+                               &op->o_ndn, op->o_tmpmemctx ) == 0 )
                        {
                                rc = 1;
                                break;
@@ -2041,36 +3157,343 @@ aci_mask(
 
                return rc;
 
+       } else if ( ber_bvstrcasecmp( &aci_bv_group, &type ) == 0 ) {
+               if ( aci_group_member( &sdn, &aci_bv_group_class,
+                               &aci_bv_group_attr, op, e, nmatch, matches ) )
+               {
+                       return 1;
+               }
+
+       } else if ( ber_bvstrcasecmp( &aci_bv_role, &type ) == 0 ) {
+               if ( aci_group_member( &sdn, &aci_bv_role_class,
+                               &aci_bv_role_attr, op, e, nmatch, matches ) )
+               {
+                       return 1;
+               }
+
+       } else if ( ber_bvstrcasecmp( &aci_bv_set, &type ) == 0 ) {
+               if ( aci_match_set( &sdn, op, e, 0 ) ) {
+                       return 1;
+               }
+
+       } else if ( ber_bvstrcasecmp( &aci_bv_set_ref, &type ) == 0 ) {
+               if ( aci_match_set( &sdn, op, e, 1 ) ) {
+                       return 1;
+               }
+       }
 
-       } else if (ber_bvstrcasecmp( &aci_bv_group, &bv ) == 0) {
-               if (aci_group_member(&sdn, &aci_bv_group_class, &aci_bv_group_attr, op, e, matches))
-                       return(1);
+       return 0;
+}
 
-       } else if (ber_bvstrcasecmp( &aci_bv_role, &bv ) == 0) {
-               if (aci_group_member(&sdn, &aci_bv_role_class, &aci_bv_role_attr, op, e, matches))
-                       return(1);
+#ifdef SLAP_DYNACL
+/*
+ * FIXME: there is a silly dependence that makes it difficult
+ * to move ACIs in a run-time loadable module under the "dynacl" 
+ * umbrella, because sets share some helpers with ACIs.
+ */
+static int
+dynacl_aci_parse( const char *fname, int lineno, slap_style_t sty, const char *right, void **privp )
+{
+       AttributeDescription    *ad = NULL;
+       const char              *text = NULL;
+
+       if ( sty != ACL_STYLE_REGEX && sty != ACL_STYLE_BASE ) {
+               fprintf( stderr, "%s: line %d: "
+                       "inappropriate style \"%s\" in \"aci\" by clause\n",
+                       fname, lineno, style_strings[sty] );
+               return -1;
+       }
 
-       } else if (ber_bvstrcasecmp( &aci_bv_set, &bv ) == 0) {
-               if (aci_match_set(&sdn, op, e, 0))
-                       return(1);
+       if ( right != NULL && *right != '\0' ) {
+               if ( slap_str2ad( right, &ad, &text ) != LDAP_SUCCESS ) {
+                       fprintf( stderr,
+                               "%s: line %d: aci \"%s\": %s\n",
+                               fname, lineno, right, text );
+                       return -1;
+               }
 
-       } else if (ber_bvstrcasecmp( &aci_bv_set_ref, &bv ) == 0) {
-               if (aci_match_set(&sdn, op, e, 1))
-                       return(1);
+       } else {
+               ad = slap_schema.si_ad_aci;
+       }
 
+       if ( !is_at_syntax( ad->ad_type, SLAPD_ACI_SYNTAX) ) {
+               fprintf( stderr, "%s: line %d: "
+                       "aci \"%s\": inappropriate syntax: %s\n",
+                       fname, lineno, right,
+                       ad->ad_type->sat_syntax_oid );
+               return -1;
        }
 
-       return(0);
+       *privp = (void *)ad;
+
+       return 0;
+}
+
+static int
+dynacl_aci_unparse( void *priv, struct berval *bv )
+{
+       AttributeDescription    *ad = ( AttributeDescription * )priv;
+       char *ptr;
+
+       assert( ad != NULL );
+
+       bv->bv_val = ch_malloc( STRLENOF(" aci=") + ad->ad_cname.bv_len + 1 );
+       ptr = lutil_strcopy( bv->bv_val, " aci=" );
+       ptr = lutil_strcopy( ptr, ad->ad_cname.bv_val );
+       bv->bv_len = ptr - bv->bv_val;
+
+       return 0;
+}
+
+
+static int
+dynacl_aci_mask(
+               void                    *priv,
+               Operation               *op,
+               Entry                   *e,
+               AttributeDescription    *desc,
+               struct berval           *val,
+               int                     nmatch,
+               regmatch_t              *matches,
+               slap_access_t           *grantp,
+               slap_access_t           *denyp )
+{
+       AttributeDescription    *ad = ( AttributeDescription * )priv;
+       Attribute               *at;
+       slap_access_t           tgrant, tdeny, grant, deny;
+#ifdef LDAP_DEBUG
+       char                    accessmaskbuf[ACCESSMASK_MAXLEN];
+       char                    accessmaskbuf1[ACCESSMASK_MAXLEN];
+#endif /* LDAP_DEBUG */
+
+       /* start out with nothing granted, nothing denied */
+       ACL_INIT(tgrant);
+       ACL_INIT(tdeny);
+
+       /* get the aci attribute */
+       at = attr_find( e->e_attrs, ad );
+       if ( at != NULL ) {
+               int             i;
+
+               /* the aci is an multi-valued attribute.  The
+                * rights are determined by OR'ing the individual
+                * rights given by the acis.
+                */
+               for ( i = 0; !BER_BVISNULL( &at->a_nvals[i] ); i++ ) {
+                       if ( aci_mask( op, e, desc, val, &at->a_nvals[i],
+                                       nmatch, matches, &grant, &deny,
+                                       SLAP_ACI_SCOPE_ENTRY ) != 0 )
+                       {
+                               tgrant |= grant;
+                               tdeny |= deny;
+                       }
+               }
+               
+               Debug( LDAP_DEBUG_ACL, "<= aci_mask grant %s deny %s\n",
+                         accessmask2str( tgrant, accessmaskbuf, 1 ), 
+                         accessmask2str( tdeny, accessmaskbuf1, 1 ), 0 );
+       }
+
+       /* If the entry level aci didn't contain anything valid for the 
+        * current operation, climb up the tree and evaluate the
+        * acis with scope set to subtree
+        */
+       if ( tgrant == ACL_PRIV_NONE && tdeny == ACL_PRIV_NONE ) {
+               struct berval   parent_ndn;
+
+#if 1
+               /* to solve the chicken'n'egg problem of accessing
+                * the OpenLDAPaci attribute, the direct access
+                * to the entry's attribute is unchecked; however,
+                * further accesses to OpenLDAPaci values in the 
+                * ancestors occur through backend_attribute(), i.e.
+                * with the identity of the operation, requiring
+                * further access checking.  For uniformity, this
+                * makes further requests occur as the rootdn, if
+                * any, i.e. searching for the OpenLDAPaci attribute
+                * is considered an internal search.  If this is not
+                * acceptable, then the same check needs be performed
+                * when accessing the entry's attribute. */
+               Operation       op2 = *op;
+
+               if ( !BER_BVISNULL( &op->o_bd->be_rootndn ) ) {
+                       op2.o_dn = op->o_bd->be_rootdn;
+                       op2.o_ndn = op->o_bd->be_rootndn;
+               }
+#endif
+
+               dnParent( &e->e_nname, &parent_ndn );
+               while ( !BER_BVISEMPTY( &parent_ndn ) ){
+                       int             i;
+                       BerVarray       bvals = NULL;
+                       int             ret, stop;
+
+                       Debug( LDAP_DEBUG_ACL, "checking ACI of \"%s\"\n", parent_ndn.bv_val, 0, 0 );
+                       ret = backend_attribute( &op2, NULL, &parent_ndn, ad, &bvals, ACL_AUTH );
+
+                       switch ( ret ) {
+                       case LDAP_SUCCESS :
+                               stop = 0;
+                               if ( !bvals ) {
+                                       break;
+                               }
+
+                               for ( i = 0; !BER_BVISNULL( &bvals[i] ); i++) {
+                                       if ( aci_mask( op, e, desc, val,
+                                                       &bvals[i],
+                                                       nmatch, matches,
+                                                       &grant, &deny,
+                                                       SLAP_ACI_SCOPE_CHILDREN ) != 0 )
+                                       {
+                                               tgrant |= grant;
+                                               tdeny |= deny;
+                                               /* evaluation stops as soon as either a "deny" or a 
+                                                * "grant" directive matches.
+                                                */
+                                               if ( tgrant != ACL_PRIV_NONE || tdeny != ACL_PRIV_NONE ) {
+                                                       stop = 1;
+                                               }
+                                       }
+                                       Debug( LDAP_DEBUG_ACL, "<= aci_mask grant %s deny %s\n", 
+                                               accessmask2str( tgrant, accessmaskbuf, 1 ),
+                                               accessmask2str( tdeny, accessmaskbuf1, 1 ), 0 );
+                               }
+                               break;
+
+                       case LDAP_NO_SUCH_ATTRIBUTE:
+                               /* just go on if the aci-Attribute is not present in
+                                * the current entry 
+                                */
+                               Debug( LDAP_DEBUG_ACL, "no such attribute\n", 0, 0, 0 );
+                               stop = 0;
+                               break;
+
+                       case LDAP_NO_SUCH_OBJECT:
+                               /* We have reached the base object */
+                               Debug( LDAP_DEBUG_ACL, "no such object\n", 0, 0, 0 );
+                               stop = 1;
+                               break;
+
+                       default:
+                               stop = 1;
+                               break;
+                       }
+
+                       if ( stop ) {
+                               break;
+                       }
+                       dnParent( &parent_ndn, &parent_ndn );
+               }
+       }
+
+       *grantp = tgrant;
+       *denyp = tdeny;
+
+       return 0;
 }
 
+/* need to register this at some point */
+static slap_dynacl_t   dynacl_aci = {
+       "aci",
+       dynacl_aci_parse,
+       dynacl_aci_unparse,
+       dynacl_aci_mask,
+       NULL,
+       NULL,
+       NULL
+};
+
+#endif /* SLAP_DYNACL */
+
 #endif /* SLAPD_ACI_ENABLED */
 
-static void
+#ifdef SLAP_DYNACL
+
+/*
+ * dynamic ACL infrastructure
+ */
+static slap_dynacl_t   *da_list = NULL;
+
+int
+slap_dynacl_register( slap_dynacl_t *da )
+{
+       slap_dynacl_t   *tmp;
+
+       for ( tmp = da_list; tmp; tmp = tmp->da_next ) {
+               if ( strcasecmp( da->da_name, tmp->da_name ) == 0 ) {
+                       break;
+               }
+       }
+
+       if ( tmp != NULL ) {
+               return -1;
+       }
+       
+       if ( da->da_mask == NULL ) {
+               return -1;
+       }
+       
+       da->da_private = NULL;
+       da->da_next = da_list;
+       da_list = da;
+
+       return 0;
+}
+
+static slap_dynacl_t *
+slap_dynacl_next( slap_dynacl_t *da )
+{
+       if ( da ) {
+               return da->da_next;
+       }
+       return da_list;
+}
+
+slap_dynacl_t *
+slap_dynacl_get( const char *name )
+{
+       slap_dynacl_t   *da;
+
+       for ( da = slap_dynacl_next( NULL ); da; da = slap_dynacl_next( da ) ) {
+               if ( strcasecmp( da->da_name, name ) == 0 ) {
+                       break;
+               }
+       }
+
+       return da;
+}
+#endif /* SLAP_DYNACL */
+
+int
+acl_init( void )
+{
+#ifdef SLAP_DYNACL
+       int             i, rc;
+       slap_dynacl_t   *known_dynacl[] = {
+#ifdef SLAPD_ACI_ENABLED
+               &dynacl_aci,
+#endif  /* SLAPD_ACI_ENABLED */
+               NULL
+       };
+
+       for ( i = 0; known_dynacl[ i ]; i++ ) {
+               rc = slap_dynacl_register( known_dynacl[ i ] ); 
+               if ( rc ) {
+                       return rc;
+               }
+       }
+#endif /* SLAP_DYNACL */
+
+       return 0;
+}
+
+static int
 string_expand(
-       struct berval *bv,
-       struct berval *pat,
-       char *match,
-       regmatch_t *matches)
+       struct berval   *bv,
+       struct berval   *pat,
+       char            *match,
+       int             nmatch,
+       regmatch_t      *matches)
 {
        ber_len_t       size;
        char   *sp;
@@ -2110,12 +3533,14 @@ string_expand(
                                        }
 
                                        if ( *sp != /*'{'*/ '}' ) {
-                                               /* error */
+                                               /* FIXME: error */
+                                               return 1;
                                        }
                                }
 
-                               if ( n >= MAXREMATCHES ) {
-                               
+                               if ( n >= nmatch ) {
+                                       /* FIXME: error */
+                                       return 1;
                                }
                                
                                *dp = '\0';
@@ -2147,22 +3572,19 @@ string_expand(
        *dp = '\0';
        bv->bv_len = size;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, DETAIL1, 
-          "string_expand:  pattern = %.*s\n", (int)pat->bv_len, pat->bv_val, 0 );
-       LDAP_LOG( ACL, DETAIL1, "string_expand:  expanded = %s\n", bv->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "=> string_expand: pattern:  %.*s\n", (int)pat->bv_len, pat->bv_val, 0 );
        Debug( LDAP_DEBUG_TRACE, "=> string_expand: expanded: %s\n", bv->bv_val, 0, 0 );
-#endif
+
+       return 0;
 }
 
 static int
 regex_matches(
-       struct berval *pat,                     /* pattern to expand and match against */
-       char *str,                              /* string to match against pattern */
-       char *buf,                              /* buffer with $N expansion variables */
-       regmatch_t *matches             /* offsets in buffer for $N expansion variables */
+       struct berval   *pat,           /* pattern to expand and match against */
+       char            *str,           /* string to match against pattern */
+       char            *buf,           /* buffer with $N expansion variables */
+       int             nmatch, /* size of the matches array */
+       regmatch_t      *matches        /* offsets in buffer for $N expansion variables */
 )
 {
        regex_t re;
@@ -2170,42 +3592,33 @@ regex_matches(
        struct berval bv;
        int     rc;
 
-       bv.bv_len = sizeof(newbuf) - 1;
+       bv.bv_len = sizeof( newbuf ) - 1;
        bv.bv_val = newbuf;
 
-       if(str == NULL) str = "";
+       if (str == NULL) {
+               str = "";
+       };
 
-       string_expand(&bv, pat, buf, matches);
-       if (( rc = regcomp(&re, newbuf, REG_EXTENDED|REG_ICASE))) {
+       string_expand( &bv, pat, buf, nmatch, matches );
+       rc = regcomp( &re, newbuf, REG_EXTENDED|REG_ICASE );
+       if ( rc ) {
                char error[ACL_BUF_SIZE];
-               regerror(rc, &re, error, sizeof(error));
+               regerror( rc, &re, error, sizeof( error ) );
 
-#ifdef NEW_LOGGING
-               LDAP_LOG( ACL, ERR, 
-                          "regex_matches: compile( \"%s\", \"%s\") failed %s\n",
-                          pat->bv_val, str, error  );
-#else
                Debug( LDAP_DEBUG_TRACE,
                    "compile( \"%s\", \"%s\") failed %s\n",
                        pat->bv_val, str, error );
-#endif
                return( 0 );
        }
 
-       rc = regexec(&re, str, 0, NULL, 0);
+       rc = regexec( &re, str, 0, NULL, 0 );
        regfree( &re );
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( ACL, DETAIL2, "regex_matches: string:   %s\n", str, 0, 0 );
-       LDAP_LOG( ACL, DETAIL2, "regex_matches: rc:     %d  %s\n",
-                  rc, rc ? "matches" : "no matches", 0  );
-#else
        Debug( LDAP_DEBUG_TRACE,
            "=> regex_matches: string:   %s\n", str, 0, 0 );
        Debug( LDAP_DEBUG_TRACE,
            "=> regex_matches: rc: %d %s\n",
                rc, !rc ? "matches" : "no matches", 0 );
-#endif
        return( !rc );
 }