]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/add.c
ITS#3097 fix undefined objectclass assertion
[openldap] / servers / slapd / add.c
index 365b315ebe654249bad2ac23a81f4361dc5efeff..078bd73075540fe4df27eb98ea5767937cc38c69 100644 (file)
@@ -1,10 +1,18 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
-/*
- * Copyright (c) 1995 Regents of the University of Michigan.
+/* Portions Copyright (c) 1995 Regents of the University of Michigan.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms are permitted
 #include "slap.h"
 
 #ifdef LDAP_SLAPI
-#include "slapi.h"
-static Slapi_PBlock *initAddPlugin( Backend *be, Connection *conn, Operation *op,
-       struct berval *dn, Entry *e, int manageDSAit );
-static int doPreAddPluginFNs( Backend *be, Slapi_PBlock *pb );
-static void doPostAddPluginFNs( Backend *be, Slapi_PBlock *pb );
+#include "slapi/slapi.h"
+
+static void init_add_pblock( Operation *op, struct berval *dn, Entry *e,
+       int manageDSAit );
+static int call_add_preop_plugins( Operation *op );
+static void call_add_postop_plugins( Operation *op );
 #endif /* LDAP_SLAPI */
 
 int
-do_add( Connection *conn, Operation *op )
+do_add( Operation *op, SlapReply *rs )
 {
        BerElement      *ber = op->o_ber;
        char            *last;
-       struct berval dn = { 0, NULL };
+       struct berval dn = BER_BVNULL;
        ber_len_t       len;
        ber_tag_t       tag;
        Entry           *e;
-       Backend         *be;
        Modifications   *modlist = NULL;
        Modifications   **modtail = &modlist;
        Modifications   tmp;
-       const char *text;
-       int                     rc = LDAP_SUCCESS;
        int     manageDSAit;
-#ifdef LDAP_SLAPI
-       Slapi_PBlock    *pb = NULL;
-#endif /* LDAP_SLAPI */
 
 #ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ENTRY, "do_add: conn %d enter\n", conn->c_connid,0,0 );
+       LDAP_LOG( OPERATION, ENTRY, "do_add: conn %d enter\n", op->o_connid,0,0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "do_add\n", 0, 0, 0 );
 #endif
@@ -74,34 +77,36 @@ do_add( Connection *conn, Operation *op )
        if ( ber_scanf( ber, "{m", /*}*/ &dn ) == LBER_ERROR ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ERR, 
-                       "do_add: conn %d ber_scanf failed\n", conn->c_connid,0,0 );
+                       "do_add: conn %d ber_scanf failed\n", op->o_connid,0,0 );
 #else
                Debug( LDAP_DEBUG_ANY, "do_add: ber_scanf failed\n", 0, 0, 0 );
 #endif
-               send_ldap_disconnect( conn, op,
-                       LDAP_PROTOCOL_ERROR, "decoding error" );
+               send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" );
                return -1;
        }
 
        e = (Entry *) ch_calloc( 1, sizeof(Entry) );
 
-       rc = dnPrettyNormal( NULL, &dn, &e->e_name, &e->e_nname );
+       rs->sr_err = dnPrettyNormal( NULL, &dn, &op->o_req_dn, &op->o_req_ndn,
+               op->o_tmpmemctx );
 
-       if( rc != LDAP_SUCCESS ) {
+       if( rs->sr_err != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ERR, 
-                       "do_add: conn %d invalid dn (%s)\n", conn->c_connid, dn.bv_val, 0 );
+                       "do_add: conn %d invalid dn (%s)\n", op->o_connid, dn.bv_val, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "do_add: invalid dn (%s)\n", dn.bv_val, 0, 0 );
 #endif
-               send_ldap_result( conn, op, rc = LDAP_INVALID_DN_SYNTAX, NULL,
-                           "invalid DN", NULL, NULL );
+               send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid DN" );
                goto done;
        }
 
+       ber_dupbv( &e->e_name, &op->o_req_dn );
+       ber_dupbv( &e->e_nname, &op->o_req_ndn );
+
 #ifdef NEW_LOGGING
        LDAP_LOG( OPERATION, ARGS, 
-               "do_add: conn %d  dn (%s)\n", conn->c_connid, e->e_dn, 0 );
+               "do_add: conn %d  dn (%s)\n", op->o_connid, e->e_dn, 0 );
 #else
        Debug( LDAP_DEBUG_ARGS, "do_add: dn (%s)\n", e->e_dn, 0, 0 );
 #endif
@@ -113,22 +118,19 @@ do_add( Connection *conn, Operation *op )
                Modifications *mod;
                ber_tag_t rtag;
 
-#ifdef SLAP_NVALUES
                tmp.sml_nvalues = NULL;
-#endif
 
                rtag = ber_scanf( ber, "{m{W}}", &tmp.sml_type, &tmp.sml_values );
 
                if ( rtag == LBER_ERROR ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR, 
-                                  "do_add: conn %d      decoding error \n", conn->c_connid, 0, 0 );
+                                  "do_add: conn %d      decoding error \n", op->o_connid, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY, "do_add: decoding error\n", 0, 0, 0 );
 #endif
-                       send_ldap_disconnect( conn, op,
-                               LDAP_PROTOCOL_ERROR, "decoding error" );
-                       rc = -1;
+                       send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" );
+                       rs->sr_err = -1;
                        goto done;
                }
 
@@ -136,13 +138,13 @@ do_add( Connection *conn, Operation *op )
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, INFO, 
                                "do_add: conn %d         no values for type %s\n",
-                               conn->c_connid, tmp.sml_type.bv_val, 0 );
+                               op->o_connid, tmp.sml_type.bv_val, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY, "no values for type %s\n",
                                tmp.sml_type.bv_val, 0, 0 );
 #endif
-                       send_ldap_result( conn, op, rc = LDAP_PROTOCOL_ERROR,
-                               NULL, "no values for attribute type", NULL, NULL );
+                       send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
+                               "no values for attribute type" );
                        goto done;
                }
 
@@ -152,9 +154,7 @@ do_add( Connection *conn, Operation *op )
                mod->sml_desc = NULL;
                mod->sml_type = tmp.sml_type;
                mod->sml_values = tmp.sml_values;
-#ifdef SLAP_NVALUES
                mod->sml_nvalues = NULL;
-#endif
 
                *modtail = mod;
                modtail = &mod->sml_next;
@@ -163,20 +163,19 @@ do_add( Connection *conn, Operation *op )
        if ( ber_scanf( ber, /*{*/ "}") == LBER_ERROR ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ERR, 
-                       "do_add: conn %d ber_scanf failed\n", conn->c_connid, 0, 0 );
+                       "do_add: conn %d ber_scanf failed\n", op->o_connid, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "do_add: ber_scanf failed\n", 0, 0, 0 );
 #endif
-               send_ldap_disconnect( conn, op,
-                       LDAP_PROTOCOL_ERROR, "decoding error" );
-               rc = -1;
+               send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" );
+               rs->sr_err = -1;
                goto done;
        }
 
-       if( (rc = get_ctrls( conn, op, 1 )) != LDAP_SUCCESS ) {
+       if( get_ctrls( op, rs, 1 ) != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, INFO, 
-                       "do_add: conn %d get_ctrls failed\n", conn->c_connid, 0, 0 );
+                       "do_add: conn %d get_ctrls failed\n", op->o_connid, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "do_add: get_ctrls failed\n", 0, 0, 0 );
 #endif
@@ -184,25 +183,23 @@ do_add( Connection *conn, Operation *op )
        } 
 
        if ( modlist == NULL ) {
-               send_ldap_result( conn, op, rc = LDAP_PROTOCOL_ERROR,
-                       NULL, "no attributes provided", NULL, NULL );
+               send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR,
+                       "no attributes provided" );
                goto done;
        }
 
        Statslog( LDAP_DEBUG_STATS, "conn=%lu op=%lu ADD dn=\"%s\"\n",
-           op->o_connid, op->o_opid, e->e_dn, 0, 0 );
+           op->o_connid, op->o_opid, e->e_name.bv_val, 0, 0 );
 
        if( e->e_nname.bv_len == 0 ) {
                /* protocolError may be a more appropriate error */
-               send_ldap_result( conn, op, rc = LDAP_ALREADY_EXISTS,
-                       NULL, "root DSE already exists",
-                       NULL, NULL );
+               send_ldap_error( op, rs, LDAP_ALREADY_EXISTS,
+                       "root DSE already exists" );
                goto done;
 
        } else if ( bvmatch( &e->e_nname, &global_schemandn ) ) {
-               send_ldap_result( conn, op, rc = LDAP_ALREADY_EXISTS,
-                       NULL, "subschema subentry already exists",
-                       NULL, NULL );
+               send_ldap_error( op, rs, LDAP_ALREADY_EXISTS,
+                       "subschema subentry already exists" );
                goto done;
        }
 
@@ -213,34 +210,38 @@ do_add( Connection *conn, Operation *op )
         * appropriate one, or send a referral to our "referral server"
         * if we don't hold it.
         */
-       be = select_backend( &e->e_nname, manageDSAit, 0 );
-       if ( be == NULL ) {
-               BerVarray ref = referral_rewrite( default_referral,
+       op->o_bd = select_backend( &e->e_nname, manageDSAit, 0 );
+       if ( op->o_bd == NULL ) {
+               rs->sr_ref = referral_rewrite( default_referral,
                        NULL, &e->e_name, LDAP_SCOPE_DEFAULT );
+               if ( !rs->sr_ref ) rs->sr_ref = default_referral;
+               if ( rs->sr_ref ) {
+                       rs->sr_err = LDAP_REFERRAL;
+                       send_ldap_result( op, rs );
 
-               send_ldap_result( conn, op, rc = LDAP_REFERRAL,
-                       NULL, NULL, ref ? ref : default_referral, NULL );
-
-               if ( ref ) ber_bvarray_free( ref );
+                       if ( rs->sr_ref != default_referral ) {
+                               ber_bvarray_free( rs->sr_ref );
+                       }
+               } else {
+                       send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+                               "no global superior knowledge" );
+               }
                goto done;
        }
 
        /* check restrictions */
-       rc = backend_check_restrictions( be, conn, op, NULL, &text ) ;
-       if( rc != LDAP_SUCCESS ) {
-               send_ldap_result( conn, op, rc,
-                       NULL, text, NULL, NULL );
+       if( backend_check_restrictions( op, rs, NULL ) != LDAP_SUCCESS ) {
+               send_ldap_result( op, rs );
                goto done;
        }
 
        /* check for referrals */
-       rc = backend_check_referrals( be, conn, op, &e->e_name, &e->e_nname );
-       if ( rc != LDAP_SUCCESS ) {
+       if( backend_check_referrals( op, rs ) != LDAP_SUCCESS ) {
                goto done;
        }
 
 #ifdef LDAP_SLAPI
-       pb = initAddPlugin( be, conn, op, &dn, e, manageDSAit );
+       if ( op->o_pb ) init_add_pblock( op, &dn, e, manageDSAit );
 #endif /* LDAP_SLAPI */
 
        /*
@@ -249,23 +250,23 @@ do_add( Connection *conn, Operation *op )
         * 2) this backend is master for what it holds;
         * 3) it's a replica and the dn supplied is the updatedn.
         */
-       if ( be->be_add ) {
+       if ( op->o_bd->be_add ) {
                /* do the update here */
-               int repl_user = be_isupdate(be, &op->o_ndn );
+               int repl_user = be_isupdate( op );
 #ifndef SLAPD_MULTIMASTER
-               if ( !be->be_update_ndn.bv_len || repl_user )
+               if ( !SLAP_SHADOW(op->o_bd) || repl_user )
 #endif
                {
-                       int update = be->be_update_ndn.bv_len;
+                       int update = op->o_bd->be_update_ndn.bv_len;
                        char textbuf[SLAP_TEXT_BUFLEN];
                        size_t textlen = sizeof textbuf;
+                       slap_callback cb = { NULL, slap_replog_cb, NULL, NULL };
 
-                       rc = slap_mods_check( modlist, update, &text,
-                               textbuf, textlen );
+                       rs->sr_err = slap_mods_check( modlist, update, &rs->sr_text,
+                                 textbuf, textlen, NULL );
 
-                       if( rc != LDAP_SUCCESS ) {
-                               send_ldap_result( conn, op, rc,
-                                       NULL, text, NULL, NULL );
+                       if( rs->sr_err != LDAP_SUCCESS ) {
+                               send_ldap_result( op, rs );
                                goto done;
                        }
 
@@ -277,20 +278,18 @@ do_add( Connection *conn, Operation *op )
                                        assert( (*modtail)->sml_op == LDAP_MOD_ADD );
                                        assert( (*modtail)->sml_desc != NULL );
                                }
-                               rc = slap_mods_opattrs( be, op, modlist, modtail, &text,
-                                       textbuf, textlen );
-                               if( rc != LDAP_SUCCESS ) {
-                                       send_ldap_result( conn, op, rc,
-                                               NULL, text, NULL, NULL );
+                               rs->sr_err = slap_mods_opattrs( op, modlist, modtail,
+                                       &rs->sr_text, textbuf, textlen );
+                               if( rs->sr_err != LDAP_SUCCESS ) {
+                                       send_ldap_result( op, rs );
                                        goto done;
                                }
                        }
 
-                       rc = slap_mods2entry( modlist, &e, repl_user, &text,
-                               textbuf, textlen );
-                       if( rc != LDAP_SUCCESS ) {
-                               send_ldap_result( conn, op, rc,
-                                       NULL, text, NULL, NULL );
+                       rs->sr_err = slap_mods2entry( modlist, &e, repl_user, 0,
+                               &rs->sr_text, textbuf, textlen );
+                       if( rs->sr_err != LDAP_SUCCESS ) {
+                               send_ldap_result( op, rs );
                                goto done;
                        }
 
@@ -299,82 +298,104 @@ do_add( Connection *conn, Operation *op )
                         * Call the preoperation plugin here, because the entry
                         * will actually contain something.
                         */
-                       rc = doPreAddPluginFNs( be, pb );
-                       if ( rc != LDAP_SUCCESS ) {
-                               /* plugin will have sent result */
-                               goto done;
+                       if ( op->o_pb ) {
+                               rs->sr_err = call_add_preop_plugins( op );
+                               if ( rs->sr_err != LDAP_SUCCESS ) {
+                                       /* plugin will have sent result */
+                                       goto done;
+                               }
                        }
 #endif /* LDAP_SLAPI */
 
-                       if ( (*be->be_add)( be, conn, op, e ) == 0 ) {
+                       op->ora_e = e;
 #ifdef SLAPD_MULTIMASTER
-                               if ( !repl_user )
+                       if ( !repl_user )
 #endif
-                               {
-                                       replog( be, op, &e->e_name, &e->e_nname, e );
-                               }
-                               be_entry_release_w( be, conn, op, e );
+                       {
+                               cb.sc_next = op->o_callback;
+                               op->o_callback = &cb;
+                       }
+                       if ( (op->o_bd->be_add)( op, rs ) == 0 ) {
+                               be_entry_release_w( op, e );
                                e = NULL;
                        }
 
 #ifndef SLAPD_MULTIMASTER
                } else {
-                       BerVarray defref;
-                       BerVarray ref;
+                       BerVarray defref = NULL;
 #ifdef LDAP_SLAPI
                        /*
                         * SLAPI_ADD_ENTRY will be empty, but this may be acceptable
                         * on replicas (for now, it involves the minimum code intrusion).
                         */
-                       rc = doPreAddPluginFNs( be, pb );
-                       if ( rc != LDAP_SUCCESS ) {
-                               /* plugin will have sent result */
-                               goto done;
+                       if ( op->o_pb ) {
+                               rs->sr_err = call_add_preop_plugins( op );
+                               if ( rs->sr_err != LDAP_SUCCESS ) {
+                                       /* plugin will have sent result */
+                                       goto done;
+                               }
                        }
 #endif /* LDAP_SLAPI */
 
-                       defref = be->be_update_refs
-                               ? be->be_update_refs : default_referral;
-                       ref = referral_rewrite( defref,
-                               NULL, &e->e_name, LDAP_SCOPE_DEFAULT );
+                       defref = op->o_bd->be_update_refs
+                               ? op->o_bd->be_update_refs : default_referral;
 
-                       send_ldap_result( conn, op, rc = LDAP_REFERRAL, NULL, NULL,
-                               ref ? ref : defref, NULL );
+                       if ( defref != NULL ) {
+                               rs->sr_ref = referral_rewrite( defref,
+                                       NULL, &e->e_name, LDAP_SCOPE_DEFAULT );
+                               if ( rs->sr_ref == NULL ) rs->sr_ref = defref;
+                               rs->sr_err = LDAP_REFERRAL;
+                               if (!rs->sr_ref) rs->sr_ref = default_referral;
+                               send_ldap_result( op, rs );
 
-                       if ( ref ) ber_bvarray_free( ref );
+                               if ( rs->sr_ref != default_referral ) {
+                                       ber_bvarray_free( rs->sr_ref );
+                               }
+                       } else {
+                               send_ldap_error( op, rs,
+                                       LDAP_UNWILLING_TO_PERFORM,
+                                       "shadow context; no update referral" );
+                       }
 #endif /* SLAPD_MULTIMASTER */
                }
        } else {
 #ifdef LDAP_SLAPI
-           rc = doPreAddPluginFNs( be, pb );
-           if ( rc != LDAP_SUCCESS ) {
-               /* plugin will have sent result */
-               goto done;
-           }
+               if ( op->o_pb ) {
+                       rs->sr_err = call_add_preop_plugins( op );
+                       if ( rs->sr_err != LDAP_SUCCESS ) {
+                               /* plugin will have sent result */
+                               goto done;
+                       }
+               }
 #endif
 #ifdef NEW_LOGGING
            LDAP_LOG( OPERATION, INFO, 
-                      "do_add: conn %d  no backend support\n", conn->c_connid, 0, 0 );
+                      "do_add: conn %d  no backend support\n", op->o_connid, 0, 0 );
 #else
            Debug( LDAP_DEBUG_ARGS, "    do_add: no backend support\n", 0, 0, 0 );
 #endif
-           send_ldap_result( conn, op, rc = LDAP_UNWILLING_TO_PERFORM,
-                             NULL, "operation not supported within namingContext", NULL, NULL );
+           send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM,
+                       "operation not supported within namingContext" );
        }
 
 #ifdef LDAP_SLAPI
-       doPostAddPluginFNs( be, pb );
+       if ( op->o_pb ) call_add_postop_plugins( op );
 #endif /* LDAP_SLAPI */
 
 done:
+
+       slap_graduate_commit_csn( op );
+
        if( modlist != NULL ) {
                slap_mods_free( modlist );
        }
        if( e != NULL ) {
                entry_free( e );
        }
+       op->o_tmpfree( op->o_req_dn.bv_val, op->o_tmpmemctx );
+       op->o_tmpfree( op->o_req_ndn.bv_val, op->o_tmpmemctx );
 
-       return rc;
+       return rs->sr_err;
 }
 
 int
@@ -382,6 +403,7 @@ slap_mods2entry(
        Modifications *mods,
        Entry **e,
        int repl_user,
+       int dup,
        const char **text,
        char *textbuf, size_t textlen )
 {
@@ -393,7 +415,9 @@ slap_mods2entry(
        for( ; mods != NULL; mods = mods->sml_next ) {
                Attribute *attr;
 
-               assert( mods->sml_op == LDAP_MOD_ADD );
+               if ( !repl_user ) {
+                       assert( mods->sml_op == LDAP_MOD_ADD );
+               }
                assert( mods->sml_desc != NULL );
 
                attr = attr_find( (*e)->e_attrs, mods->sml_desc );
@@ -430,7 +454,6 @@ slap_mods2entry(
                        ch_free( mods->sml_values );
                        mods->sml_values = NULL;
 
-#ifdef SLAP_NVALUES
                        if( mods->sml_nvalues ) {
                                attr->a_nvals = ch_realloc( attr->a_nvals,
                                        sizeof( struct berval ) * (i+j) );
@@ -441,10 +464,10 @@ slap_mods2entry(
                                /* trim the mods array */
                                ch_free( mods->sml_nvalues );
                                mods->sml_nvalues = NULL;
+
                        } else {
                                attr->a_nvals = attr->a_vals;
                        }
-#endif
 
                        continue;
 #else
@@ -462,11 +485,12 @@ slap_mods2entry(
 
                        /* check if the values we're adding already exist */
                        if( mr == NULL || !mr->smr_match ) {
-                               for ( i = 0; mods->sml_bvalues[i].bv_val != NULL; i++ ) {
+                               for ( i = 1; mods->sml_values[i].bv_val != NULL; i++ ) {
                                        /* test asserted values against themselves */
                                        for( j = 0; j < i; j++ ) {
-                                               if ( bvmatch( &mods->sml_bvalues[i],
-                                                       &mods->sml_bvalues[j] ) ) {
+                                               if ( bvmatch( &mods->sml_values[i],
+                                                       &mods->sml_values[j] ) )
+                                               {
                                                        /* value exists already */
                                                        snprintf( textbuf, textlen,
                                                                "%s: value #%d provided more than once",
@@ -477,35 +501,37 @@ slap_mods2entry(
                                }
 
                        } else {
-                               int             rc;
-#ifdef SLAP_NVALUES
+                               int     rc;
                                int match;
 
-                               for ( i = 0; mods->sml_nvalues[i].bv_val != NULL; i++ ) {
+                               for ( i = 1; mods->sml_values[i].bv_val != NULL; i++ ) {
                                        /* test asserted values against themselves */
                                        for( j = 0; j < i; j++ ) {
                                                rc = value_match( &match, mods->sml_desc, mr,
-                                                       SLAP_MR_EQUALITY | SLAP_MR_VALUE_OF_ASSERTION_SYNTAX
+                                                       SLAP_MR_EQUALITY
+                                                       | SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX
                                                        | SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH
                                                        | SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH,
-                                                       &mods->sml_nvalues[i], &mods->sml_nvalues[j], &text );
+                                                       mods->sml_nvalues
+                                                               ? &mods->sml_nvalues[i]
+                                                               : &mods->sml_values[i],
+                                                       mods->sml_nvalues
+                                                               ? &mods->sml_nvalues[j]
+                                                               : &mods->sml_values[j],
+                                                       text );
+
                                                if ( rc == LDAP_SUCCESS && match == 0 ) {
                                                        /* value exists already */
                                                        snprintf( textbuf, textlen,
                                                                "%s: value #%d provided more than once",
                                                                mods->sml_desc->ad_cname.bv_val, j );
                                                        return LDAP_TYPE_OR_VALUE_EXISTS;
+
+                                               } else if ( rc != LDAP_SUCCESS ) {
+                                                       return rc;
                                                }
                                        }
                                }
-#else
-                               rc = modify_check_duplicates( mods->sml_desc, mr,
-                                               NULL, mods->sml_bvalues, 0,
-                                               text, textbuf, textlen );
-#endif
-                               if ( rc != LDAP_SUCCESS ) {
-                                       return rc;
-                               }
                        }
                }
 
@@ -513,21 +539,41 @@ slap_mods2entry(
 
                /* move ad to attr structure */
                attr->a_desc = mods->sml_desc;
-               mods->sml_desc = NULL;
+               if ( !dup ) mods->sml_desc = NULL;
 
                /* move values to attr structure */
                /*      should check for duplicates */
-               attr->a_vals = mods->sml_values;
-               mods->sml_values = NULL;
+               if ( dup ) { 
+                       int i;
+                       for ( i = 0; mods->sml_values[i].bv_val; i++ ) /* EMPTY */;
+                       attr->a_vals = (BerVarray) ch_calloc( i+1, sizeof( BerValue ));
+                       for ( i = 0; mods->sml_values[i].bv_val; i++ ) {
+                               ber_dupbv( &attr->a_vals[i], &mods->sml_values[i] );
+                       }
+                       attr->a_vals[i].bv_len = 0;
+                       attr->a_vals[i].bv_val = NULL;
+               } else {
+                       attr->a_vals = mods->sml_values;
+                       mods->sml_values = NULL;
+               }
 
-#ifdef SLAP_NVALUES
                if ( mods->sml_nvalues ) {
-                       attr->a_nvals = mods->sml_nvalues;
-                       mods->sml_nvalues = NULL;
+                       if ( dup ) {
+                               int i;
+                               for ( i = 0; mods->sml_nvalues[i].bv_val; i++ ) /* EMPTY */;
+                               attr->a_nvals = (BerVarray) ch_calloc( i+1, sizeof( BerValue ));
+                               for ( i = 0; mods->sml_nvalues[i].bv_val; i++ ) {
+                                       ber_dupbv( &attr->a_nvals[i], &mods->sml_nvalues[i] );
+                               }
+                               attr->a_nvals[i].bv_len = 0;
+                               attr->a_nvals[i].bv_val = NULL;
+                       } else {
+                               attr->a_nvals = mods->sml_nvalues;
+                               mods->sml_nvalues = NULL;
+                       }
                } else {
                        attr->a_nvals = attr->a_vals;
                }
-#endif
 
                *tail = attr;
                tail = &attr->a_next;
@@ -536,44 +582,108 @@ slap_mods2entry(
        return LDAP_SUCCESS;
 }
 
-#ifdef LDAP_SLAPI
-static Slapi_PBlock *initAddPlugin( Backend *be, Connection *conn, Operation *op,
-       struct berval *dn, Entry *e, int manageDSAit )
+int
+slap_entry2mods(
+       Entry *e,
+       Modifications **mods,
+       const char **text,
+       char *textbuf, size_t textlen )
 {
-       Slapi_PBlock *pb;
+       Modifications   *modhead = NULL;
+       Modifications   *mod;
+       Modifications   **modtail = &modhead;
+       Attribute               *a_new;
+       AttributeDescription    *a_new_desc;
+       int                             i, count;
+
+       a_new = e->e_attrs;
+
+       while ( a_new != NULL ) {
+               a_new_desc = a_new->a_desc;
+               mod = (Modifications *) malloc( sizeof( Modifications ));
+               
+               mod->sml_op = LDAP_MOD_REPLACE;
+
+               mod->sml_type = a_new_desc->ad_cname;
+
+               for ( count = 0; a_new->a_vals[count].bv_val; count++ ) /* EMPTY */;
+
+               mod->sml_values = (struct berval*) malloc(
+                       (count+1) * sizeof( struct berval) );
+
+               /* see slap_mods_check() comments...
+                * if a_vals == a_nvals, there is no normalizer.
+                * in this case, mod->sml_nvalues must be left NULL.
+                */
+               if ( a_new->a_vals != a_new->a_nvals ) {
+                       mod->sml_nvalues = (struct berval*) malloc(
+                               (count+1) * sizeof( struct berval) );
+               } else {
+                       mod->sml_nvalues = NULL;
+               }
 
-       pb = op->o_pb;
+               for ( i = 0; i < count; i++ ) {
+                       ber_dupbv(mod->sml_values+i, a_new->a_vals+i); 
+                       if ( mod->sml_nvalues ) {
+                               ber_dupbv( mod->sml_nvalues+i, a_new->a_vals+i ); 
+                       } 
+               }
 
-       slapi_x_backend_set_pb( pb, be );
-       slapi_x_connection_set_pb( pb, conn );
-       slapi_x_operation_set_pb( pb, op );
+               mod->sml_values[count].bv_val = NULL; 
+               mod->sml_values[count].bv_len = 0; 
 
-       slapi_pblock_set( pb, SLAPI_ADD_TARGET, (void *)dn->bv_val );
-       slapi_pblock_set( pb, SLAPI_ADD_ENTRY, (void *)e );
-       slapi_pblock_set( pb, SLAPI_MANAGEDSAIT, (void *)manageDSAit );
+               if ( mod->sml_nvalues ) {
+                       mod->sml_nvalues[count].bv_val = NULL; 
+                       mod->sml_nvalues[count].bv_len = 0; 
+               }
 
-       return pb;
+               mod->sml_desc = a_new_desc;
+               mod->sml_next =NULL;
+               *modtail = mod;
+               modtail = &mod->sml_next;
+               a_new = a_new->a_next; 
+       }
+
+       *mods = modhead;
+
+       return LDAP_SUCCESS;
 }
 
-static int doPreAddPluginFNs( Backend *be, Slapi_PBlock *pb )
+#ifdef LDAP_SLAPI
+static void init_add_pblock( Operation *op,
+       struct berval *dn, Entry *e, int manageDSAit )
+{
+       slapi_int_pblock_set_operation( op->o_pb, op );
+       slapi_pblock_set( op->o_pb, SLAPI_ADD_TARGET, (void *)dn->bv_val );
+       slapi_pblock_set( op->o_pb, SLAPI_ADD_ENTRY, (void *)e );
+       slapi_pblock_set( op->o_pb, SLAPI_MANAGEDSAIT, (void *)manageDSAit );
+}
+
+static int call_add_preop_plugins( Operation *op )
 {
        int rc;
 
-       rc = doPluginFNs( be, SLAPI_PLUGIN_PRE_ADD_FN, pb );
-       if ( rc != 0 ) {
+       rc = slapi_int_call_plugins( op->o_bd, SLAPI_PLUGIN_PRE_ADD_FN, op->o_pb );
+       if ( rc < 0 ) {
                /*
                 * A preoperation plugin failure will abort the
                 * entire operation.
                 */
 #ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, INFO, "do_add: add preoperation plugin failed\n",
-                               0, 0, 0);
+               LDAP_LOG( OPERATION, INFO,
+                       "do_add: add preoperation plugin failed\n",
+                       0, 0, 0);
 #else
-               Debug(LDAP_DEBUG_TRACE, "do_add: add preoperation plugin failed.\n",
-                               0, 0, 0);
-               if ( slapi_pblock_get( pb, SLAPI_RESULT_CODE, (void *)&rc ) != 0 )
-                       rc = LDAP_OTHER;
+               Debug(LDAP_DEBUG_TRACE,
+                       "do_add: add preoperation plugin failed.\n",
+                       0, 0, 0);
 #endif
+
+               if (( slapi_pblock_get( op->o_pb, SLAPI_RESULT_CODE,
+                       (void *)&rc ) != 0 ) || rc == LDAP_SUCCESS )
+               {
+                       rc = LDAP_OTHER;
+               }
        } else {
                rc = LDAP_SUCCESS;
        }
@@ -581,18 +691,20 @@ static int doPreAddPluginFNs( Backend *be, Slapi_PBlock *pb )
        return rc;
 }
 
-static void doPostAddPluginFNs( Backend *be, Slapi_PBlock *pb )
+static void call_add_postop_plugins( Operation *op )
 {
        int rc;
 
-       rc = doPluginFNs( be, SLAPI_PLUGIN_POST_ADD_FN, pb );
-       if ( rc != 0 ) {
+       rc = slapi_int_call_plugins( op->o_bd, SLAPI_PLUGIN_POST_ADD_FN, op->o_pb );
+       if ( rc < 0 ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG( OPERATION, INFO, "do_add: add postoperation plugin failed\n",
-                               0, 0, 0);
+               LDAP_LOG( OPERATION, INFO,
+                       "do_add: add postoperation plugin failed\n",
+                       0, 0, 0);
 #else
-               Debug(LDAP_DEBUG_TRACE, "do_add: add preoperation plugin failed.\n",
-                               0, 0, 0);
+               Debug(LDAP_DEBUG_TRACE,
+                       "do_add: add postoperation plugin failed\n",
+                       0, 0, 0);
 #endif
        }
 }