a = LDAP_STAILQ_FIRST(&attr_list);
LDAP_STAILQ_REMOVE_HEAD(&attr_list, sat_next);
- if (a->sat_subtypes) ldap_memfree(a->sat_subtypes);
+ if ( a->sat_equality ) {
+ MatchingRule *mr;
+
+ mr = mr_find( a->sat_equality->smr_oid );
+ assert( mr != NULL );
+ if ( mr != a->sat_equality ) {
+ ch_free( a->sat_equality );
+ a->sat_equality = NULL;
+ }
+ }
+
+ assert( a->sat_syntax != NULL );
+ if ( a->sat_syntax != NULL ) {
+ Syntax *syn;
+
+ syn = syn_find( a->sat_syntax->ssyn_oid );
+ assert( syn != NULL );
+ if ( syn != a->sat_syntax ) {
+ ch_free( a->sat_syntax );
+ a->sat_syntax = NULL;
+ }
+ }
+
+ if ( a->sat_oidmacro ) ldap_memfree( a->sat_oidmacro );
+ if ( a->sat_subtypes ) ldap_memfree( a->sat_subtypes );
ad_destroy(a->sat_ad);
ldap_pvt_thread_mutex_destroy(&a->sat_ad_mutex);
ldap_attributetype_free((LDAPAttributeType *)a);
if ( slap_schema.si_at_undefined ) {
ad_destroy(slap_schema.si_at_undefined->sat_ad);
}
+
+ if ( slap_schema.si_at_proxied ) {
+ ad_destroy(slap_schema.si_at_proxied->sat_ad);
+ }
}
int
at_start( AttributeType **at )
{
- assert( at );
+ assert( at != NULL );
*at = LDAP_STAILQ_FIRST(&attr_list);
int
at_next( AttributeType **at )
{
- assert( at );
+ assert( at != NULL );
#if 1 /* pedantic check */
{
}
}
- assert( tmp );
+ assert( tmp != NULL );
}
#endif
}
}
+ if ( sat->sat_oid ) {
+ slap_ad_undef_promote( sat->sat_oid, sat );
+ }
+
+ names = sat->sat_names;
+ if ( names ) {
+ while ( *names ) {
+ slap_ad_undef_promote( *names, sat );
+ names++;
+ }
+ }
+
LDAP_STAILQ_INSERT_TAIL( &attr_list, sat, sat_next );
return 0;
int
at_add(
- LDAPAttributeType *at,
- int user,
- AttributeType **rsat,
- const char **err )
+ LDAPAttributeType *at,
+ int user,
+ AttributeType **rsat,
+ const char **err )
{
AttributeType *sat;
MatchingRule *mr;
if ( supsat == NULL ) {
*err = at->at_sup_oid;
- return SLAP_SCHERR_ATTR_NOT_FOUND;
+ code = SLAP_SCHERR_ATTR_NOT_FOUND;
+ goto error_return;
}
sat->sat_sup = supsat;
if ( at_append_to_list(sat, &supsat->sat_subtypes) ) {
- return SLAP_SCHERR_OUTOFMEM;
+ code = SLAP_SCHERR_OUTOFMEM;
+ goto error_return;
}
if ( sat->sat_usage != supsat->sat_usage ) {
/* subtypes must have same usage as their SUP */
- return SLAP_SCHERR_ATTR_BAD_USAGE;
+ code = SLAP_SCHERR_ATTR_BAD_USAGE;
+ goto error_return;
}
if ( supsat->sat_obsolete && !sat->sat_obsolete ) {
/* subtypes must be obsolete if super is */
- return SLAP_SCHERR_ATTR_BAD_SUP;
+ code = SLAP_SCHERR_ATTR_BAD_SUP;
+ goto error_return;
}
if ( sat->sat_flags & SLAP_AT_FINAL ) {
/* cannot subtype a "final" attribute type */
- return SLAP_SCHERR_ATTR_BAD_SUP;
+ code = SLAP_SCHERR_ATTR_BAD_SUP;
+ goto error_return;
}
}
if ( sat->sat_extensions ) {
for (i=0; sat->sat_extensions[i]; i++) {
if (!strcasecmp( sat->sat_extensions[i]->lsei_name,
- "X-ORDERED" ) && sat->sat_extensions[i]->lsei_values &&
- !strcasecmp( sat->sat_extensions[i]->lsei_values[0],
- "VALUES" )) {
- sat->sat_flags |= SLAP_AT_ORDERED;
- break;
+ "X-ORDERED" ) && sat->sat_extensions[i]->lsei_values ) {
+ if ( !strcasecmp( sat->sat_extensions[i]->lsei_values[0],
+ "VALUES" )) {
+ sat->sat_flags |= SLAP_AT_ORDERED_VAL;
+ break;
+ } else if ( !strcasecmp( sat->sat_extensions[i]->lsei_values[0],
+ "SIBLINGS" )) {
+ sat->sat_flags |= SLAP_AT_ORDERED_SIB;
+ break;
+ }
}
}
}
syn = syn_find(sat->sat_syntax_oid);
if ( syn == NULL ) {
*err = sat->sat_syntax_oid;
- return SLAP_SCHERR_SYN_NOT_FOUND;
+ code = SLAP_SCHERR_SYN_NOT_FOUND;
+ goto error_return;
}
if( sat->sat_syntax != NULL && sat->sat_syntax != syn ) {
- return SLAP_SCHERR_ATTR_BAD_SUP;
+ code = SLAP_SCHERR_ATTR_BAD_SUP;
+ goto error_return;
}
sat->sat_syntax = syn;
} else if ( sat->sat_syntax == NULL ) {
- return SLAP_SCHERR_ATTR_INCOMPLETE;
+ code = SLAP_SCHERR_ATTR_INCOMPLETE;
+ goto error_return;
}
if ( sat->sat_equality_oid ) {
if( mr == NULL ) {
*err = sat->sat_equality_oid;
- return SLAP_SCHERR_MR_NOT_FOUND;
+ code = SLAP_SCHERR_MR_NOT_FOUND;
+ goto error_return;
}
if(( mr->smr_usage & SLAP_MR_EQUALITY ) != SLAP_MR_EQUALITY ) {
*err = sat->sat_equality_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
if( sat->sat_syntax != mr->smr_syntax ) {
if( mr->smr_compat_syntaxes == NULL ) {
*err = sat->sat_equality_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
for(i=0; mr->smr_compat_syntaxes[i]; i++) {
if( i >= 0 ) {
*err = sat->sat_equality_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
}
if ( sat->sat_ordering_oid ) {
if( !sat->sat_equality ) {
*err = sat->sat_ordering_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
mr = mr_find(sat->sat_ordering_oid);
if( mr == NULL ) {
*err = sat->sat_ordering_oid;
- return SLAP_SCHERR_MR_NOT_FOUND;
+ code = SLAP_SCHERR_MR_NOT_FOUND;
+ goto error_return;
}
if(( mr->smr_usage & SLAP_MR_ORDERING ) != SLAP_MR_ORDERING ) {
*err = sat->sat_ordering_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
if( sat->sat_syntax != mr->smr_syntax ) {
if( mr->smr_compat_syntaxes == NULL ) {
*err = sat->sat_ordering_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
for(i=0; mr->smr_compat_syntaxes[i]; i++) {
if( i >= 0 ) {
*err = sat->sat_ordering_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
}
if ( sat->sat_substr_oid ) {
if( !sat->sat_equality ) {
*err = sat->sat_substr_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
mr = mr_find(sat->sat_substr_oid);
if( mr == NULL ) {
*err = sat->sat_substr_oid;
- return SLAP_SCHERR_MR_NOT_FOUND;
+ code = SLAP_SCHERR_MR_NOT_FOUND;
+ goto error_return;
}
if(( mr->smr_usage & SLAP_MR_SUBSTR ) != SLAP_MR_SUBSTR ) {
*err = sat->sat_substr_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
/* due to funky LDAP builtin substring rules,
if( sat->sat_syntax != sat->sat_equality->smr_syntax ) {
if( sat->sat_equality->smr_compat_syntaxes == NULL ) {
*err = sat->sat_substr_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
for(i=0; sat->sat_equality->smr_compat_syntaxes[i]; i++) {
if( i >= 0 ) {
*err = sat->sat_substr_oid;
- return SLAP_SCHERR_ATTR_BAD_MR;
+ code = SLAP_SCHERR_ATTR_BAD_MR;
+ goto error_return;
}
}
}
code = at_insert( sat, err );
- if ( code == 0 && rsat )
+ if ( code != 0 ) {
+error_return:;
+ if ( sat ) {
+ ldap_pvt_thread_mutex_destroy( &sat->sat_ad_mutex );
+ ch_free( sat );
+ }
+
+ if ( oidm ) {
+ SLAP_FREE( at->at_oid );
+ at->at_oid = oidm;
+ }
+
+ } else if ( rsat ) {
*rsat = sat;
+ }
+
return code;
}
projects / openldap / blobdiff