]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/at.c
Import ITS#4158 fixes from HEAD
[openldap] / servers / slapd / at.c
index 047480a0404ecbb785f8b1f73f3fdce0e2631cf8..fe603c9aed9e554ff68edaed55fb35099637e161 100644 (file)
@@ -1,9 +1,18 @@
+/* at.c - routines for dealing with attribute types */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2005 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
-/* at.c - routines for dealing with attribute types */
 
 #include "portable.h"
 
@@ -49,14 +58,17 @@ struct aindexrec {
 };
 
 static Avlnode *attr_index = NULL;
-static AttributeType *attr_list = NULL;
+static LDAP_SLIST_HEAD(ATList, slap_attribute_type) attr_list
+       = LDAP_SLIST_HEAD_INITIALIZER(&attr_list);
 
 static int
 attr_index_cmp(
-    struct aindexrec   *air1,
-    struct aindexrec   *air2
+    const void *v_air1,
+    const void *v_air2
 )
 {
+       const struct aindexrec  *air1 = v_air1;
+       const struct aindexrec  *air2 = v_air2;
        int i = air1->air_name.bv_len - air2->air_name.bv_len;
        if (i)
                return i;
@@ -65,10 +77,12 @@ attr_index_cmp(
 
 static int
 attr_index_name_cmp(
-    struct berval      *type,
-    struct aindexrec   *air
+    const void *v_type,
+    const void *v_air
 )
 {
+    const struct berval    *type = v_type;
+    const struct aindexrec *air  = v_air;
        int i = type->bv_len - air->air_name.bv_len;
        if (i)
                return i;
@@ -96,8 +110,7 @@ at_bvfind(
 {
        struct aindexrec *air;
 
-       air = (struct aindexrec *) avl_find( attr_index, name,
-            (AVL_CMP) attr_index_name_cmp );
+       air = avl_find( attr_index, name, attr_index_name_cmp );
 
        return air != NULL ? air->air_at : NULL;
 }
@@ -194,34 +207,71 @@ at_find_in_list(
 void
 at_destroy( void )
 {
-       AttributeType *a, *n;
+       AttributeType *a;
        avl_free(attr_index, ldap_memfree);
 
-       for (a=attr_list; a; a=n) {
-               n = a->sat_next;
+       while( !LDAP_SLIST_EMPTY(&attr_list) ) {
+               a = LDAP_SLIST_FIRST(&attr_list);
+               LDAP_SLIST_REMOVE_HEAD(&attr_list, sat_next);
+
                if (a->sat_subtypes) ldap_memfree(a->sat_subtypes);
                ad_destroy(a->sat_ad);
                ldap_pvt_thread_mutex_destroy(&a->sat_ad_mutex);
                ldap_attributetype_free((LDAPAttributeType *)a);
        }
-       ad_destroy(slap_schema.si_at_undefined->sat_ad);
+
+       if ( slap_schema.si_at_undefined ) {
+               ad_destroy(slap_schema.si_at_undefined->sat_ad);
+       }
 }
 
+int
+at_start( AttributeType **at )
+{
+       assert( at );
+
+       *at = LDAP_SLIST_FIRST(&attr_list);
+
+       return (*at != NULL);
+}
+
+int
+at_next( AttributeType **at )
+{
+       assert( at );
+
+#if 1  /* pedantic check */
+       {
+               AttributeType *tmp = NULL;
+
+               LDAP_SLIST_FOREACH(tmp,&attr_list,sat_next) {
+                       if ( tmp == *at ) {
+                               break;
+                       }
+               }
+
+               assert( tmp );
+       }
+#endif
+
+       *at = LDAP_SLIST_NEXT(*at,sat_next);
+
+       return (*at != NULL);
+}
+       
+
+
 static int
 at_insert(
     AttributeType      *sat,
     const char         **err
 )
 {
-       AttributeType           **atp;
        struct aindexrec        *air;
        char                    **names;
 
-       atp = &attr_list;
-       while ( *atp != NULL ) {
-               atp = &(*atp)->sat_next;
-       }
-       *atp = sat;
+       LDAP_SLIST_NEXT( sat, sat_next ) = NULL;
+       LDAP_SLIST_INSERT_HEAD( &attr_list, sat, sat_next );
 
        if ( sat->sat_oid ) {
                air = (struct aindexrec *)
@@ -230,11 +280,10 @@ at_insert(
                air->air_name.bv_len = strlen(sat->sat_oid);
                air->air_at = sat;
                if ( avl_insert( &attr_index, (caddr_t) air,
-                                (AVL_CMP) attr_index_cmp,
-                                (AVL_DUP) avl_dup_error ) ) {
+                                attr_index_cmp, avl_dup_error ) ) {
                        *err = sat->sat_oid;
                        ldap_memfree(air);
-                       return SLAP_SCHERR_DUP_ATTR;
+                       return SLAP_SCHERR_ATTR_DUP;
                }
                /* FIX: temporal consistency check */
                at_bvfind(&air->air_name);
@@ -248,11 +297,10 @@ at_insert(
                        air->air_name.bv_len = strlen(*names);
                        air->air_at = sat;
                        if ( avl_insert( &attr_index, (caddr_t) air,
-                                        (AVL_CMP) attr_index_cmp,
-                                        (AVL_DUP) avl_dup_error ) ) {
+                                        attr_index_cmp, avl_dup_error ) ) {
                                *err = *names;
                                ldap_memfree(air);
-                               return SLAP_SCHERR_DUP_ATTR;
+                               return SLAP_SCHERR_ATTR_DUP;
                        }
                        /* FIX: temporal consistency check */
                        at_bvfind(&air->air_name);
@@ -272,14 +320,43 @@ at_add(
        AttributeType   *sat;
        MatchingRule    *mr;
        Syntax          *syn;
+       int             i;
        int             code;
-       char                    *cname;
+       char    *cname;
+       char    *oid;
+
+       if ( !OID_LEADCHAR( at->at_oid[0] )) {
+               /* Expand OID macros */
+               oid = oidm_find( at->at_oid );
+               if ( !oid ) {
+                       *err = at->at_oid;
+                       return SLAP_SCHERR_OIDM;
+               }
+               if ( oid != at->at_oid ) {
+                       ldap_memfree( at->at_oid );
+                       at->at_oid = oid;
+               }
+       }
+
+       if ( at->at_syntax_oid && !OID_LEADCHAR( at->at_syntax_oid[0] )) {
+               /* Expand OID macros */
+               oid = oidm_find( at->at_syntax_oid );
+               if ( !oid ) {
+                       *err = at->at_syntax_oid;
+                       return SLAP_SCHERR_OIDM;
+               }
+               if ( oid != at->at_syntax_oid ) {
+                       ldap_memfree( at->at_syntax_oid );
+                       at->at_syntax_oid = oid;
+               }
+       }
 
        if ( at->at_names && at->at_names[0] ) {
                int i;
 
                for( i=0; at->at_names[i]; i++ ) {
                        if( !slap_valid_descr( at->at_names[i] ) ) {
+                               *err = at->at_names[i];
                                return SLAP_SCHERR_BAD_DESCR;
                        }
                }
@@ -288,12 +365,29 @@ at_add(
 
        } else if ( at->at_oid ) {
                cname = at->at_oid;
+
        } else {
+               *err = "";
                return SLAP_SCHERR_ATTR_INCOMPLETE;
        }
 
+       *err = cname;
+
+       if ( !at->at_usage && at->at_no_user_mod ) {
+               /* user attribute must be modifable */
+               return SLAP_SCHERR_ATTR_BAD_USAGE;
+       }
+
        if ( at->at_collective ) {
-               return SLAP_SCHERR_NOT_SUPPORTED;
+               if( at->at_usage ) {
+                       /* collective attributes cannot be operational */
+                       return SLAP_SCHERR_ATTR_BAD_USAGE;
+               }
+
+               if( at->at_single_value ) {
+                       /* collective attributes cannot be single-valued */
+                       return SLAP_SCHERR_ATTR_BAD_USAGE;
+               }
        }
 
        sat = (AttributeType *) ch_calloc( 1, sizeof(AttributeType) );
@@ -306,7 +400,7 @@ at_add(
        if ( at->at_sup_oid ) {
                AttributeType *supsat = at_find(at->at_sup_oid);
 
-               if ( (supsat == NULL ) ) {
+               if ( supsat == NULL ) {
                        *err = at->at_sup_oid;
                        return SLAP_SCHERR_ATTR_NOT_FOUND;
                }
@@ -314,9 +408,23 @@ at_add(
                sat->sat_sup = supsat;
 
                if ( at_append_to_list(sat, &supsat->sat_subtypes) ) {
-                       *err = cname;
                        return SLAP_SCHERR_OUTOFMEM;
                }
+
+               if ( sat->sat_usage != supsat->sat_usage ) {
+                       /* subtypes must have same usage as their SUP */
+                       return SLAP_SCHERR_ATTR_BAD_USAGE;
+               }
+
+               if ( supsat->sat_obsolete && !sat->sat_obsolete ) {
+                       /* subtypes must be obsolete if super is */
+                       return SLAP_SCHERR_ATTR_BAD_SUP;
+               }
+
+               if ( sat->sat_flags & SLAP_AT_FINAL ) {
+                       /* cannot subtype a "final" attribute type */
+                       return SLAP_SCHERR_ATTR_BAD_SUP;
+               }
        }
 
        /*
@@ -333,45 +441,143 @@ at_add(
        }
 
        if ( at->at_syntax_oid ) {
-               if ( (syn = syn_find(sat->sat_syntax_oid)) ) {
-                       sat->sat_syntax = syn;
-               } else {
+               syn = syn_find(sat->sat_syntax_oid);
+               if ( syn == NULL ) {
                        *err = sat->sat_syntax_oid;
                        return SLAP_SCHERR_SYN_NOT_FOUND;
                }
 
+               if( sat->sat_syntax != NULL && sat->sat_syntax != syn ) {
+                       return SLAP_SCHERR_ATTR_BAD_SUP;
+               }
+
+               sat->sat_syntax = syn;
 
        } else if ( sat->sat_syntax == NULL ) {
                return SLAP_SCHERR_ATTR_INCOMPLETE;
        }
 
        if ( sat->sat_equality_oid ) {
-               if ( (mr = mr_find(sat->sat_equality_oid)) ) {
-                       sat->sat_equality = mr;
-                       sat->sat_approx = mr->smr_associated;
-               } else {
+               mr = mr_find(sat->sat_equality_oid);
+
+               if( mr == NULL ) {
                        *err = sat->sat_equality_oid;
                        return SLAP_SCHERR_MR_NOT_FOUND;
                }
 
+               if(( mr->smr_usage & SLAP_MR_EQUALITY ) != SLAP_MR_EQUALITY ) {
+                       *err = sat->sat_equality_oid;
+                       return SLAP_SCHERR_ATTR_BAD_MR;
+               }
+
+               if( sat->sat_syntax != mr->smr_syntax ) {
+                       if( mr->smr_compat_syntaxes == NULL ) {
+                               *err = sat->sat_equality_oid;
+                               return SLAP_SCHERR_ATTR_BAD_MR;
+                       }
+
+                       for(i=0; mr->smr_compat_syntaxes[i]; i++) {
+                               if( sat->sat_syntax == mr->smr_compat_syntaxes[i] ) {
+                                       i = -1;
+                                       break;
+                               }
+                       }
+
+                       if( i >= 0 ) {
+                               *err = sat->sat_equality_oid;
+                               return SLAP_SCHERR_ATTR_BAD_MR;
+                       }
+               }
+
+               sat->sat_equality = mr;
+               sat->sat_approx = mr->smr_associated;
        }
 
        if ( sat->sat_ordering_oid ) {
-               if ( (mr = mr_find(sat->sat_ordering_oid)) ) {
-                       sat->sat_ordering = mr;
-               } else {
+               if( !sat->sat_equality ) {
+                       *err = sat->sat_ordering_oid;
+                       return SLAP_SCHERR_ATTR_BAD_MR;
+               }
+
+               mr = mr_find(sat->sat_ordering_oid);
+
+               if( mr == NULL ) {
                        *err = sat->sat_ordering_oid;
                        return SLAP_SCHERR_MR_NOT_FOUND;
                }
+
+               if(( mr->smr_usage & SLAP_MR_ORDERING ) != SLAP_MR_ORDERING ) {
+                       *err = sat->sat_ordering_oid;
+                       return SLAP_SCHERR_ATTR_BAD_MR;
+               }
+
+               if( sat->sat_syntax != mr->smr_syntax ) {
+                       if( mr->smr_compat_syntaxes == NULL ) {
+                               *err = sat->sat_ordering_oid;
+                               return SLAP_SCHERR_ATTR_BAD_MR;
+                       }
+
+                       for(i=0; mr->smr_compat_syntaxes[i]; i++) {
+                               if( sat->sat_syntax == mr->smr_compat_syntaxes[i] ) {
+                                       i = -1;
+                                       break;
+                               }
+                       }
+
+                       if( i >= 0 ) {
+                               *err = sat->sat_ordering_oid;
+                               return SLAP_SCHERR_ATTR_BAD_MR;
+                       }
+               }
+
+               sat->sat_ordering = mr;
        }
 
        if ( sat->sat_substr_oid ) {
-               if ( (mr = mr_find(sat->sat_substr_oid)) ) {
-                       sat->sat_substr = mr;
-               } else {
+               if( !sat->sat_equality ) {
+                       *err = sat->sat_substr_oid;
+                       return SLAP_SCHERR_ATTR_BAD_MR;
+               }
+
+               mr = mr_find(sat->sat_substr_oid);
+
+               if( mr == NULL ) {
                        *err = sat->sat_substr_oid;
                        return SLAP_SCHERR_MR_NOT_FOUND;
                }
+
+               if(( mr->smr_usage & SLAP_MR_SUBSTR ) != SLAP_MR_SUBSTR ) {
+                       *err = sat->sat_substr_oid;
+                       return SLAP_SCHERR_ATTR_BAD_MR;
+               }
+
+               /* due to funky LDAP builtin substring rules, we
+                * we check against the equality rule assertion
+                * syntax and compat syntaxes instead of those
+                * associated with the substrings rule.
+                */
+               if( sat->sat_syntax != sat->sat_equality->smr_syntax ) {
+                       if( sat->sat_equality->smr_compat_syntaxes == NULL ) {
+                               *err = sat->sat_substr_oid;
+                               return SLAP_SCHERR_ATTR_BAD_MR;
+                       }
+
+                       for(i=0; sat->sat_equality->smr_compat_syntaxes[i]; i++) {
+                               if( sat->sat_syntax ==
+                                       sat->sat_equality->smr_compat_syntaxes[i] )
+                               {
+                                       i = -1;
+                                       break;
+                               }
+                       }
+
+                       if( i >= 0 ) {
+                               *err = sat->sat_substr_oid;
+                               return SLAP_SCHERR_ATTR_BAD_MR;
+                       }
+               }
+
+               sat->sat_substr = mr;
        }
 
        code = at_insert(sat,err);
@@ -380,9 +586,9 @@ at_add(
 
 #ifdef LDAP_DEBUG
 static int
-at_index_printnode( struct aindexrec *air )
+at_index_printnode( void *v_air, void *ignore )
 {
-
+       struct aindexrec *air = v_air;
        printf("%s = %s\n",
                air->air_name.bv_val,
                ldap_attributetype2str(&air->air_at->sat_atype) );
@@ -393,33 +599,33 @@ static void
 at_index_print( void )
 {
        printf("Printing attribute type index:\n");
-       (void) avl_apply( attr_index, (AVL_APPLY) at_index_printnode,
-               0, -1, AVL_INORDER );
+       (void) avl_apply( attr_index, at_index_printnode, 0, -1, AVL_INORDER );
 }
 #endif
 
-#if defined( SLAPD_SCHEMA_DN )
 int
 at_schema_info( Entry *e )
 {
-       struct berval   vals[2];
+       AttributeDescription *ad_attributeTypes = slap_schema.si_ad_attributeTypes;
        AttributeType   *at;
+       struct berval   val;
+       struct berval   nval;
 
-       AttributeDescription *ad_attributeTypes = slap_schema.si_ad_attributeTypes;
+       LDAP_SLIST_FOREACH(at,&attr_list,sat_next) {
+               if( at->sat_flags & SLAP_AT_HIDE ) continue;
+
+               if ( ldap_attributetype2bv( &at->sat_atype, &val ) == NULL ) {
+                       return -1;
+               }
 
-       vals[1].bv_val = NULL;
+               nval.bv_val = at->sat_oid;
+               nval.bv_len = strlen(at->sat_oid);
 
-       for ( at = attr_list; at; at = at->sat_next ) {
-               if ( ldap_attributetype2bv( &at->sat_atype, vals ) == NULL ) {
+               if( attr_merge_one( e, ad_attributeTypes, &val, &nval ) )
+               {
                        return -1;
                }
-#if 0
-               Debug( LDAP_DEBUG_TRACE, "Merging at [%ld] %s\n",
-                      (long) vals[0].bv_len, vals[0].bv_val, 0 );
-#endif
-               attr_merge( e, ad_attributeTypes, vals );
-               ldap_memfree( vals[0].bv_val );
+               ldap_memfree( val.bv_val );
        }
        return 0;
 }
-#endif