]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/add.c
cleanup
[openldap] / servers / slapd / back-bdb / add.c
index 185bb7ef887680ef9852d74a993094d16283bdb7..983ddd9dba9c5c56ab6d25c083c8f70a85c7885c 100644 (file)
@@ -13,8 +13,6 @@
 #include "back-bdb.h"
 #include "external.h"
 
-static char bdb_gid[DB_XIDDATASIZE];
-
 int
 bdb_add(
        BackendDB       *be,
@@ -25,7 +23,7 @@ bdb_add(
        struct bdb_info *bdb = (struct bdb_info *) be->be_private;
        struct berval   pdn;
        Entry           *p = NULL;
-       int                     rc
+       int             rc, ret
        const char      *text;
        char textbuf[SLAP_TEXT_BUFLEN];
        size_t textlen = sizeof textbuf;
@@ -35,19 +33,30 @@ bdb_add(
 #ifdef BDB_SUBENTRIES
        int subentry;
 #endif
+       u_int32_t       locker;
+       DB_LOCK         lock;
 #if 0
        u_int32_t       lockid;
        DB_LOCK         lock;
 #endif
 
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ARGS, "==> bdb_add: %s\n", e->e_dn, 0, 0 );
+#else
        Debug(LDAP_DEBUG_ARGS, "==> bdb_add: %s\n", e->e_dn, 0, 0);
+#endif
 
        /* check entry's schema */
        rc = entry_schema_check( be, e, NULL, &text, textbuf, textlen );
        if ( rc != LDAP_SUCCESS ) {
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ERR, 
+               "bdb_add: entry failed schema check: %s (%d)\n", text, rc, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE,
                        "bdb_add: entry failed schema check: %s (%d)\n",
                        text, rc, 0 );
+#endif
                goto return_results;
        }
 
@@ -61,9 +70,14 @@ bdb_add(
         */
        rc = bdb_next_id( be, NULL, &e->e_id );
        if( rc != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ERR, 
+                       "bdb_add: next_id failed (%d)\n", rc, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE,
                        "bdb_add: next_id failed (%d)\n",
                        rc, 0, 0 );
+#endif
                rc = LDAP_OTHER;
                text = "internal error";
                goto return_results;
@@ -87,13 +101,20 @@ retry:     /* transaction retry */
                bdb->bi_db_opflags );
        text = NULL;
        if( rc != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ERR, 
+                       "bdb_add: txn_begin failed: %s (%d)\n", db_strerror(rc), rc, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE,
                        "bdb_add: txn_begin failed: %s (%d)\n",
                        db_strerror(rc), rc, 0 );
+#endif
                rc = LDAP_OTHER;
                text = "internal error";
                goto return_results;
        }
+
+       locker = TXN_ID ( ltid );
 #if 0
        lockid = TXN_ID( ltid );
 #endif
@@ -128,7 +149,7 @@ retry:      /* transaction retry */
 #endif
 
                /* get parent */
-               rc = bdb_dn2entry_r( be, ltid, &pdn, &p, &matched, 0 );
+               rc = bdb_dn2entry_r( be, ltid, &pdn, &p, &matched, 0, locker, &lock );
 
                switch( rc ) {
                case 0:
@@ -137,6 +158,9 @@ retry:      /* transaction retry */
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        goto retry;
+               case LDAP_BUSY:
+                       text = "ldap server busy";
+                       goto return_results;
                default:
                        rc = LDAP_OTHER;
                        text = "internal error";
@@ -152,7 +176,7 @@ retry:      /* transaction retry */
                                refs = is_entry_referral( matched )
                                        ? get_entry_referrals( be, conn, op, matched )
                                        : NULL;
-                               bdb_cache_return_entry_r(&bdb->bi_cache, matched);
+                               bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, matched );
                                matched = NULL;
 
                        } else {
@@ -160,8 +184,13 @@ retry:     /* transaction retry */
                                        NULL, &e->e_name, LDAP_SCOPE_DEFAULT );
                        }
 
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "bdb_add: parent does not exist\n", 0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE, "bdb_add: parent does not exist\n",
                                0, 0, 0 );
+#endif
 
                        send_ldap_result( conn, op, rc = LDAP_REFERRAL,
                                matched_dn, NULL, refs, NULL );
@@ -179,14 +208,19 @@ retry:    /* transaction retry */
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        /* free parent and reader lock */
-                       bdb_cache_return_entry_r( &bdb->bi_cache, p );
+                       bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
                        p = NULL;
                        goto retry;
                }
 
                if ( ! rc ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "bdb_add: no write access to parent\n", 0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE, "bdb_add: no write access to parent\n",
                                0, 0, 0 );
+#endif
                        rc = LDAP_INSUFFICIENT_ACCESS;
                        text = "no write access to parent";
                        goto return_results;;
@@ -195,8 +229,13 @@ retry:     /* transaction retry */
 #ifdef BDB_SUBENTRIES
                if ( is_entry_subentry( p ) ) {
                        /* parent is a subentry, don't allow add */
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "bdb_add: parent is subentry\n", 0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE, "bdb_add: parent is subentry\n",
                                0, 0, 0 );
+#endif
                        rc = LDAP_OBJECT_CLASS_VIOLATION;
                        text = "parent is a subentry";
                        goto return_results;;
@@ -205,8 +244,13 @@ retry:     /* transaction retry */
 #ifdef BDB_ALIASES
                if ( is_entry_alias( p ) ) {
                        /* parent is an alias, don't allow add */
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "bdb_add: parent is alias\n", 0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE, "bdb_add: parent is alias\n",
                                0, 0, 0 );
+#endif
                        rc = LDAP_ALIAS_PROBLEM;
                        text = "parent is an alias";
                        goto return_results;;
@@ -218,14 +262,19 @@ retry:    /* transaction retry */
                        char *matched_dn = p->e_dn;
                        BerVarray refs = get_entry_referrals( be, conn, op, p );
 
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "bdb_add: parent is referral\n", 0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE, "bdb_add: parent is referral\n",
                                0, 0, 0 );
+#endif
 
                        send_ldap_result( conn, op, rc = LDAP_REFERRAL,
                                matched_dn, NULL, refs, NULL );
 
                        ber_bvarray_free( refs );
-                       bdb_cache_return_entry_r( &bdb->bi_cache, p );
+                       bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
                        p = NULL;
                        goto done;
                }
@@ -238,7 +287,7 @@ retry:      /* transaction retry */
 #endif
 
                /* free parent and reader lock */
-               bdb_cache_return_entry_r( &bdb->bi_cache, p );
+               bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
                p = NULL;
 
        } else {
@@ -263,18 +312,28 @@ retry:    /* transaction retry */
                                }
 
                                if ( ! rc ) {
+#ifdef NEW_LOGGING
+                                       LDAP_LOG ( OPERATION, DETAIL1, 
+                                               "bdb_add: no write access to parent\n", 0, 0, 0 );
+#else
                                        Debug( LDAP_DEBUG_TRACE,
                                                "bdb_add: no write access to parent\n",
                                                0, 0, 0 );
+#endif
                                        rc = LDAP_INSUFFICIENT_ACCESS;
                                        text = "no write access to parent";
                                        goto return_results;;
                                }
 
                        } else {
+#ifdef NEW_LOGGING
+                               LDAP_LOG ( OPERATION, DETAIL1, "bdb_add: %s denied\n", 
+                                       pdn.bv_len == 0 ? "suffix" : "entry at root", 0, 0 );
+#else
                                Debug( LDAP_DEBUG_TRACE, "bdb_add: %s denied\n",
                                        pdn.bv_len == 0 ? "suffix" : "entry at root",
                                        0, 0 );
+#endif
                                rc = LDAP_INSUFFICIENT_ACCESS;
                                goto return_results;
                        }
@@ -282,9 +341,14 @@ retry:     /* transaction retry */
 
 #ifdef BDB_SUBENTRIES
                if( subentry ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, DETAIL1, 
+                               "bdb_add: no parent, cannot add subentry\n", 0, 0, 0 );
+#else
                        Debug( LDAP_DEBUG_TRACE,
                                "bdb_add: no parent, cannot add subentry\n",
                                0, 0, 0 );
+#endif
                        rc = LDAP_INSUFFICIENT_ACCESS;
                        text = "no parent, cannot add subentry";
                        goto return_results;;
@@ -304,8 +368,13 @@ retry:     /* transaction retry */
        /* dn2id index */
        rc = bdb_dn2id_add( be, ltid, &pdn, e );
        if ( rc != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ERR, 
+                       "bdb_add: dn2id_add failed: %s (%d)\n", db_strerror(rc), rc, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE, "bdb_add: dn2id_add failed: %s (%d)\n",
                        db_strerror(rc), rc, 0 );
+#endif
 
                switch( rc ) {
                case DB_LOCK_DEADLOCK:
@@ -323,8 +392,12 @@ retry:     /* transaction retry */
        /* id2entry index */
        rc = bdb_id2entry_add( be, ltid, e );
        if ( rc != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ERR, "bdb_add: id2entry_add failed\n", 0, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE, "bdb_add: id2entry_add failed\n",
                        0, 0, 0 );
+#endif
                switch( rc ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
@@ -339,8 +412,13 @@ retry:     /* transaction retry */
        /* attribute indexes */
        rc = bdb_index_entry_add( be, ltid, e, e->e_attrs );
        if ( rc != LDAP_SUCCESS ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ERR, 
+                       "bdb_add: index_entry_add failed\n", 0, 0, 0 );
+#else
                Debug( LDAP_DEBUG_TRACE, "bdb_add: index_entry_add failed\n",
                        0, 0, 0 );
+#endif
                switch( rc ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
@@ -360,13 +438,31 @@ retry:    /* transaction retry */
                }
 
        } else {
-               if (( rc=TXN_PREPARE( ltid, bdb_gid )) != 0 ) {
+               char gid[DB_XIDDATASIZE];
+
+               snprintf( gid, sizeof( gid ), "%s-%08lx-%08lx",
+                       bdb_uuid.bv_val, (long) op->o_connid, (long) op->o_opid );
+
+               if (( rc=TXN_PREPARE( ltid, gid )) != 0 ) {
                        text = "txn_prepare failed";
 
                } else {
+                       ret = bdb_cache_add_entry_rw(bdb->bi_dbenv, &bdb->bi_cache, e, CACHE_WRITE_LOCK, locker, &lock);
+#if 0
                        if ( bdb_cache_add_entry_rw(&bdb->bi_cache,
                                e, CACHE_WRITE_LOCK) != 0 )
-                       {
+#endif
+                       switch ( ret ) {
+                       case 0:
+                               break;
+                       case DB_LOCK_DEADLOCK:
+                       case DB_LOCK_NOTGRANTED:
+                               goto retry;
+                       default:
+                               ret = LDAP_OTHER;
+                       }
+
+                       if ( ret ) {
                                if(( rc=TXN_ABORT( ltid )) != 0 ) {
                                        text = "cache add & txn_abort failed";
                                } else {
@@ -387,14 +483,25 @@ retry:    /* transaction retry */
        op->o_private = NULL;
 
        if (rc == LDAP_SUCCESS) {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, RESULTS, 
+                       "bdb_add: added%s id=%08lx dn=\"%s\"\n", 
+                       op->o_noop ? " (no-op)" : "", e->e_id, e->e_dn );
+#else
                Debug(LDAP_DEBUG_TRACE, "bdb_add: added%s id=%08lx dn=\"%s\"\n",
                        op->o_noop ? " (no-op)" : "", e->e_id, e->e_dn );
+#endif
                text = NULL;
                bdb_cache_entry_commit( e );
        }
        else {
+#ifdef NEW_LOGGING
+               LDAP_LOG ( OPERATION, ERR, 
+                       "bdb_add: %s : %s (%d)\n",  text, db_strerror(rc), rc );
+#else
                Debug( LDAP_DEBUG_TRACE, "bdb_add: %s : %s (%d)\n",
                        text, db_strerror(rc), rc );
+#endif
                rc = LDAP_OTHER;
        }