]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/add.c
Import ITS#4439 (slapd not responding) fix for BDB/HDB cache from HEAD
[openldap] / servers / slapd / back-bdb / add.c
index c807f24416ebfe26ebbdcc78acbba10e2b60367f..cd37908a20a8f29e479e798f8d1af21a60d3884a 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2000-2003 The OpenLDAP Foundation.
+ * Copyright 2000-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 #include <ac/string.h>
 
 #include "back-bdb.h"
-#include "external.h"
 
 int
 bdb_add(Operation *op, SlapReply *rs )
 {
        struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        struct berval   pdn;
-       Entry           *p;
+       Entry           *p = NULL;
        EntryInfo       *ei;
        char textbuf[SLAP_TEXT_BUFLEN];
        size_t textlen = sizeof textbuf;
        AttributeDescription *children = slap_schema.si_ad_children;
        AttributeDescription *entry = slap_schema.si_ad_entry;
        DB_TXN          *ltid = NULL, *lt2;
-       struct bdb_op_info opinfo;
-#ifdef BDB_SUBENTRIES
+       struct bdb_op_info opinfo = {0};
        int subentry;
-#endif
        u_int32_t       locker = 0;
        DB_LOCK         lock;
-       int             noop = 0;
 
        int             num_retries = 0;
 
-       Operation* ps_list;
-       int             rc;
-       EntryInfo       *suffix_ei = NULL;
-       Entry           *ctxcsn_e;
-       int                     ctxcsn_added = 0;
-
+       LDAPControl **postread_ctrl = NULL;
        LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
        int num_ctrls = 0;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ARGS, "==> bdb_add: %s\n", op->oq_add.rs_e->e_name.bv_val, 0, 0 );
-#else
-       Debug(LDAP_DEBUG_ARGS, "==> bdb_add: %s\n", op->oq_add.rs_e->e_name.bv_val, 0, 0);
-#endif
+       Debug(LDAP_DEBUG_ARGS, "==> " LDAP_XSTRING(bdb_add) ": %s\n",
+               op->oq_add.rs_e->e_name.bv_val, 0, 0);
+
+       ctrls[num_ctrls] = 0;
+
+       /* add opattrs to shadow as well, only missing attrs will actually
+        * be added; helps compatibility with older OL versions */
+       slap_add_opattrs( op, &rs->sr_text, textbuf, textlen, 1 );
 
        /* check entry's schema */
-       rs->sr_err = entry_schema_check( op->o_bd, op->oq_add.rs_e, NULL, &rs->sr_text, textbuf, textlen );
+       rs->sr_err = entry_schema_check( op, op->oq_add.rs_e, NULL,
+               get_manageDIT(op), &rs->sr_text, textbuf, textlen );
        if ( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ERR, 
-               "bdb_add: entry failed schema check: %s (%d)\n", rs->sr_text, rs->sr_err, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_add: entry failed schema check: %s (%d)\n",
-                       rs->sr_text, rs->sr_err, 0 );
-#endif
+                       LDAP_XSTRING(bdb_add) ": entry failed schema check: "
+                       "%s (%d)\n", rs->sr_text, rs->sr_err, 0 );
                goto return_results;
        }
 
-#ifdef BDB_SUBENTRIES
        subentry = is_entry_subentry( op->oq_add.rs_e );
-#endif
 
        /*
         * acquire an ID outside of the operation transaction
@@ -83,13 +71,9 @@ bdb_add(Operation *op, SlapReply *rs )
         */
        rs->sr_err = bdb_next_id( op->o_bd, NULL, &op->oq_add.rs_e->e_id );
        if( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_add: next_id failed (%d)\n", rs->sr_err, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_add: next_id failed (%d)\n", rs->sr_err, 0, 0 );
-#endif
+                       LDAP_XSTRING(bdb_add) ": next_id failed (%d)\n",
+                       rs->sr_err, 0, 0 );
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "internal error";
                goto return_results;
@@ -111,7 +95,10 @@ retry:      /* transaction retry */
                        rs->sr_text = "internal error";
                        goto return_results;
                }
-               ldap_pvt_thread_yield();
+               if ( op->o_abandon ) {
+                       rs->sr_err = SLAPD_ABANDON;
+                       goto return_results;
+               }
                bdb_trans_backoff( ++num_retries );
        }
 
@@ -120,14 +107,9 @@ retry:     /* transaction retry */
                bdb->bi_db_opflags );
        rs->sr_text = NULL;
        if( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_add: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_add: txn_begin failed: %s (%d)\n",
+                       LDAP_XSTRING(bdb_add) ": txn_begin failed: %s (%d)\n",
                        db_strerror(rs->sr_err), rs->sr_err, 0 );
-#endif
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "internal error";
                goto return_results;
@@ -182,27 +164,17 @@ retry:    /* transaction retry */
                                : NULL;
                        bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
                        p = NULL;
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_add: parent does not exist\n", 0, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE, "bdb_add: parent does not exist\n",
-                               0, 0, 0 );
-#endif
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(bdb_add) ": parent "
+                               "does not exist\n", 0, 0, 0 );
 
                        rs->sr_err = LDAP_REFERRAL;
-                       send_ldap_result( op, rs );
-
-                       ber_bvarray_free( rs->sr_ref );
-                       op->o_tmpfree( (char *)rs->sr_matched, op->o_tmpmemctx );
-                       rs->sr_ref = NULL;
-                       rs->sr_matched = NULL;
-
-                       goto done;
+                       rs->sr_flags = REP_MATCHED_MUSTBEFREED | REP_REF_MUSTBEFREED;
+                       goto return_results;
                }
 
                rs->sr_err = access_allowed( op, p,
-                       children, NULL, ACL_WRITE, NULL );
+                       children, NULL, ACL_WADD, NULL );
 
                if ( ! rs->sr_err ) {
                        switch( opinfo.boi_err ) {
@@ -211,79 +183,53 @@ retry:    /* transaction retry */
                                goto retry;
                        }
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_add: no write access to parent\n", 0, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE, "bdb_add: no write access to parent\n",
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(bdb_add) ": no write access to parent\n",
                                0, 0, 0 );
-#endif
                        rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
                        rs->sr_text = "no write access to parent";
                        goto return_results;;
                }
 
-#ifdef BDB_SUBENTRIES
                if ( is_entry_subentry( p ) ) {
                        /* parent is a subentry, don't allow add */
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_add: parent is subentry\n", 0, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE, "bdb_add: parent is subentry\n",
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(bdb_add) ": parent is subentry\n",
                                0, 0, 0 );
-#endif
                        rs->sr_err = LDAP_OBJECT_CLASS_VIOLATION;
                        rs->sr_text = "parent is a subentry";
                        goto return_results;;
                }
-#endif
-#ifdef BDB_ALIASES
                if ( is_entry_alias( p ) ) {
                        /* parent is an alias, don't allow add */
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_add: parent is alias\n", 0, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE, "bdb_add: parent is alias\n",
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(bdb_add) ": parent is alias\n",
                                0, 0, 0 );
-#endif
                        rs->sr_err = LDAP_ALIAS_PROBLEM;
                        rs->sr_text = "parent is an alias";
                        goto return_results;;
                }
-#endif
 
                if ( is_entry_referral( p ) ) {
                        /* parent is a referral, don't allow add */
-                       rs->sr_matched = p->e_name.bv_val;
+                       rs->sr_matched = ber_strdup_x( p->e_name.bv_val,
+                               op->o_tmpmemctx );
                        rs->sr_ref = get_entry_referrals( op, p );
-
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_add: parent is referral\n", 0, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE, "bdb_add: parent is referral\n",
+                       bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
+                       p = NULL;
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(bdb_add) ": parent is referral\n",
                                0, 0, 0 );
-#endif
 
                        rs->sr_err = LDAP_REFERRAL;
-                       send_ldap_result( op, rs );
-
-                       ber_bvarray_free( rs->sr_ref );
-                       bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
-                       rs->sr_ref = NULL;
-                       rs->sr_matched = NULL;
-                       p = NULL;
-                       goto done;
+                       rs->sr_flags = REP_MATCHED_MUSTBEFREED | REP_REF_MUSTBEFREED;
+                       goto return_results;
                }
 
-#ifdef BDB_SUBENTRIES
                if ( subentry ) {
                        /* FIXME: */
                        /* parent must be an administrative point of the required kind */
                }
-#endif
 
                /* free parent and reader lock */
                bdb_unlocked_cache_return_entry_r( &bdb->bi_cache, p );
@@ -294,32 +240,20 @@ retry:    /* transaction retry */
                 * no parent!
                 *  if not attempting to add entry at suffix or with parent ""
                 */
-               if (( !be_isroot( op->o_bd, &op->o_ndn ) || pdn.bv_len > 0 )
-                       && !is_entry_glue( op->oq_add.rs_e ))
+               if ((( !be_isroot( op ) && !be_shadow_update(op) )
+                       || pdn.bv_len > 0 ) && !is_entry_glue( op->oq_add.rs_e ))
                {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, "bdb_add: %s denied\n", 
-                               pdn.bv_len == 0 ? "suffix" : "entry at root", 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE, "bdb_add: %s denied\n",
+                       Debug( LDAP_DEBUG_TRACE,
+                               LDAP_XSTRING(bdb_add) ": %s denied\n",
                                pdn.bv_len == 0 ? "suffix" : "entry at root",
                                0, 0 );
-#endif
                        rs->sr_err = LDAP_NO_SUCH_OBJECT;
                        goto return_results;
                }
        }
 
-       if ( get_assert( op ) &&
-               ( test_filter( op, op->oq_add.rs_e, get_assertion( op ))
-                       != LDAP_COMPARE_TRUE ))
-       {
-               rs->sr_err = LDAP_ASSERTION_FAILED;
-               goto return_results;
-       }
-
        rs->sr_err = access_allowed( op, op->oq_add.rs_e,
-               entry, NULL, ACL_WRITE, NULL );
+               entry, NULL, ACL_WADD, NULL );
 
        if ( ! rs->sr_err ) {
                switch( opinfo.boi_err ) {
@@ -328,48 +262,22 @@ retry:    /* transaction retry */
                        goto retry;
                }
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "bdb_add: no write access to entry\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "bdb_add: no write access to entry\n",
+               Debug( LDAP_DEBUG_TRACE,
+                       LDAP_XSTRING(bdb_add) ": no write access to entry\n",
                        0, 0, 0 );
-#endif
                rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
                rs->sr_text = "no write access to entry";
                goto return_results;;
        }
 
-       /* post-read */
-       if( op->o_postread ) {
-               if ( slap_read_controls( op, rs, op->oq_add.rs_e,
-                       &slap_post_read_bv, &ctrls[num_ctrls] ) )
-               {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "<=- bdb_add: post-read failed!\n", 0, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_TRACE,
-                               "<=- bdb_add: post-read failed!\n", 0, 0, 0 );
-#endif
-                       goto return_results;
-               }
-               ctrls[++num_ctrls] = NULL;
-       }
-
        /* nested transaction */
        rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
                bdb->bi_db_opflags );
        rs->sr_text = NULL;
        if( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_add: txn_begin(2) failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_add: txn_begin(2) failed: %s (%d)\n",
-                       db_strerror(rs->sr_err), rs->sr_err, 0 );
-#endif
+                       LDAP_XSTRING(bdb_add) ": txn_begin(2) failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "internal error";
                goto return_results;
@@ -378,13 +286,9 @@ retry:     /* transaction retry */
        /* dn2id index */
        rs->sr_err = bdb_dn2id_add( op, lt2, ei, op->oq_add.rs_e );
        if ( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_add: dn2id_add failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "bdb_add: dn2id_add failed: %s (%d)\n",
+               Debug( LDAP_DEBUG_TRACE,
+                       LDAP_XSTRING(bdb_add) ": dn2id_add failed: %s (%d)\n",
                        db_strerror(rs->sr_err), rs->sr_err, 0 );
-#endif
 
                switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
@@ -399,15 +303,12 @@ retry:    /* transaction retry */
                goto return_results;
        }
 
-       /* id2entry index */
-       rs->sr_err = bdb_id2entry_add( op->o_bd, lt2, op->oq_add.rs_e );
-       if ( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, "bdb_add: id2entry_add failed\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "bdb_add: id2entry_add failed\n",
+       /* attribute indexes */
+       rs->sr_err = bdb_index_entry_add( op, lt2, op->oq_add.rs_e );
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               Debug( LDAP_DEBUG_TRACE,
+                       LDAP_XSTRING(bdb_add) ": index_entry_add failed\n",
                        0, 0, 0 );
-#endif
                switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
@@ -415,20 +316,16 @@ retry:    /* transaction retry */
                default:
                        rs->sr_err = LDAP_OTHER;
                }
-               rs->sr_text = "entry store failed";
+               rs->sr_text = "index generation failed";
                goto return_results;
        }
 
-       /* attribute indexes */
-       rs->sr_err = bdb_index_entry_add( op, lt2, op->oq_add.rs_e );
-       if ( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_add: index_entry_add failed\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "bdb_add: index_entry_add failed\n",
+       /* id2entry index */
+       rs->sr_err = bdb_id2entry_add( op->o_bd, lt2, op->oq_add.rs_e );
+       if ( rs->sr_err != 0 ) {
+               Debug( LDAP_DEBUG_TRACE,
+                       LDAP_XSTRING(bdb_add) ": id2entry_add failed\n",
                        0, 0, 0 );
-#endif
                switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
@@ -436,23 +333,29 @@ retry:    /* transaction retry */
                default:
                        rs->sr_err = LDAP_OTHER;
                }
-               rs->sr_text = "index generation failed";
+               rs->sr_text = "entry store failed";
                goto return_results;
        }
+
        if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "txn_commit(2) failed";
                goto return_results;
        }
 
-       if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
-               rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
-                       &ctxcsn_e, &ctxcsn_added, locker );
-               switch ( rc ) {
-               case BDB_CSN_ABORT :
+       /* post-read */
+       if( op->o_postread ) {
+               if( postread_ctrl == NULL ) {
+                       postread_ctrl = &ctrls[num_ctrls++];
+                       ctrls[num_ctrls] = NULL;
+               }
+               if ( slap_read_controls( op, rs, op->oq_add.rs_e,
+                       &slap_post_read_bv, postread_ctrl ) )
+               {
+                       Debug( LDAP_DEBUG_TRACE,
+                               "<=- " LDAP_XSTRING(bdb_add) ": post-read "
+                               "failed!\n", 0, 0, 0 );
                        goto return_results;
-               case BDB_CSN_RETRY :
-                       goto retry;
                }
        }
 
@@ -460,104 +363,68 @@ retry:   /* transaction retry */
                if (( rs->sr_err=TXN_ABORT( ltid )) != 0 ) {
                        rs->sr_text = "txn_abort (no-op) failed";
                } else {
-                       noop = 1;
-                       rs->sr_err = LDAP_SUCCESS;
+                       rs->sr_err = LDAP_X_NO_OPERATION;
+                       ltid = NULL;
+                       goto return_results;
                }
 
        } else {
-               char gid[DB_XIDDATASIZE];
-
-               memset( gid, 0, sizeof(gid) );
-               snprintf( gid, sizeof( gid ), "%s-%08lx-%08lx",
-                       bdb_uuid.bv_val, (long) op->o_connid, (long) op->o_opid );
-
-               if (( rs->sr_err=TXN_PREPARE( ltid, gid )) != 0 ) {
-                       rs->sr_text = "txn_prepare failed";
+               struct berval nrdn;
+               Entry *e = entry_dup( op->ora_e );
 
+               /* pick the RDN if not suffix; otherwise pick the entire DN */
+               if (pdn.bv_len) {
+                       nrdn.bv_val = e->e_nname.bv_val;
+                       nrdn.bv_len = pdn.bv_val - op->ora_e->e_nname.bv_val - 1;
                } else {
-                       struct berval nrdn;
-                       Entry *e = entry_dup( op->ora_e );
-
-                       if (pdn.bv_len) {
-                               nrdn.bv_val = e->e_nname.bv_val;
-                               nrdn.bv_len = pdn.bv_val - op->ora_e->e_nname.bv_val - 1;
-                       } else {
-                               nrdn = e->e_nname;
-                       }
-
-                       bdb_cache_add( bdb, ei, e, &nrdn, locker );
-
-                       if ( suffix_ei == NULL ) {
-                               suffix_ei = e->e_private;
-                       }
-
-                       if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
-                               if ( ctxcsn_added ) {
-                                       bdb_cache_add( bdb, suffix_ei, ctxcsn_e,
-                                                       (struct berval *)&slap_ldapsync_cn_bv, locker );
-                               }
-                       }
+                       nrdn = e->e_nname;
+               }
 
-                       if ( rs->sr_err == LDAP_SUCCESS && !noop && !op->o_no_psearch ) {
-                               ldap_pvt_thread_rdwr_rlock( &bdb->bi_pslist_rwlock );
-                               LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
-                                       bdb_psearch( op, rs, ps_list, op->oq_add.rs_e, LDAP_PSEARCH_BY_ADD );
-                               }
-                               ldap_pvt_thread_rdwr_runlock( &bdb->bi_pslist_rwlock );
-                       }
+               bdb_cache_add( bdb, ei, e, &nrdn, locker );
 
-                       if(( rs->sr_err=TXN_COMMIT( ltid, 0 )) != 0 ) {
-                               rs->sr_text = "txn_commit failed";
-                       } else {
-                               rs->sr_err = LDAP_SUCCESS;
-                       }
+               if(( rs->sr_err=TXN_COMMIT( ltid, 0 )) != 0 ) {
+                       rs->sr_text = "txn_commit failed";
+               } else {
+                       rs->sr_err = LDAP_SUCCESS;
                }
        }
 
        ltid = NULL;
        op->o_private = NULL;
 
-       if (rs->sr_err != LDAP_SUCCESS) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_add: %s : %s (%d)\n",  rs->sr_text,
-                               db_strerror(rs->sr_err), rs->sr_err );
-#else
-               Debug( LDAP_DEBUG_TRACE, "bdb_add: %s : %s (%d)\n",
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               Debug( LDAP_DEBUG_TRACE,
+                       LDAP_XSTRING(bdb_add) ": %s : %s (%d)\n",
                        rs->sr_text, db_strerror(rs->sr_err), rs->sr_err );
-#endif
                rs->sr_err = LDAP_OTHER;
                goto return_results;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, RESULTS, 
-               "bdb_add: added%s id=%08lx dn=\"%s\"\n", 
+       Debug(LDAP_DEBUG_TRACE,
+               LDAP_XSTRING(bdb_add) ": added%s id=%08lx dn=\"%s\"\n",
                op->o_noop ? " (no-op)" : "",
                op->oq_add.rs_e->e_id, op->oq_add.rs_e->e_dn );
-#else
-       Debug(LDAP_DEBUG_TRACE, "bdb_add: added%s id=%08lx dn=\"%s\"\n",
-               op->o_noop ? " (no-op)" : "",
-               op->oq_add.rs_e->e_id, op->oq_add.rs_e->e_dn );
-#endif
 
        rs->sr_text = NULL;
        if( num_ctrls ) rs->sr_ctrls = ctrls;
 
 return_results:
        send_ldap_result( op, rs );
+       slap_graduate_commit_csn( op );
 
-       if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
-               ldap_pvt_thread_yield();
-               TXN_CHECKPOINT( bdb->bi_dbenv,
-                       bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
-       }
-
-done:
        if( ltid != NULL ) {
                TXN_ABORT( ltid );
-               op->o_private = NULL;
+       }
+       op->o_private = NULL;
+
+       if( postread_ctrl != NULL ) {
+               slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
+               slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
        }
 
-       return ( ( rs->sr_err == LDAP_SUCCESS ) ? noop : rs->sr_err );
+       if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
+               TXN_CHECKPOINT( bdb->bi_dbenv,
+                       bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
+       }
+       return rs->sr_err;
 }