]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/cache.c
Move MSVC port to the Attic
[openldap] / servers / slapd / back-bdb / cache.c
index e5875e0c37324bf2f8356537db24305aceac5e87..d306add2a5003f326f0a2ad43543455477a0148b 100644 (file)
@@ -1,8 +1,17 @@
 /* cache.c - routines to maintain an in-core cache of entries */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 2000-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
@@ -22,13 +31,28 @@ static int  bdb_cache_delete_internal(Cache *cache, EntryInfo *e);
 static void    bdb_lru_print(Cache *cache);
 #endif
 
+static int bdb_txn_get( Operation *op, DB_ENV *env, DB_TXN **txn );
+
 static EntryInfo *
-bdb_cache_entryinfo_new( )
+bdb_cache_entryinfo_new( Cache *cache )
 {
-       EntryInfo *ei;
+       EntryInfo *ei = NULL;
 
-       ei = ch_calloc(1, sizeof(struct bdb_entry_info));
-       ldap_pvt_thread_mutex_init( &ei->bei_kids_mutex );
+       if ( cache->c_eifree ) {
+               ldap_pvt_thread_rdwr_wlock( &cache->c_rwlock );
+               if ( cache->c_eifree ) {
+                       ei = cache->c_eifree;
+                       cache->c_eifree = ei->bei_lrunext;
+               }
+               ldap_pvt_thread_rdwr_wunlock( &cache->c_rwlock );
+       }
+       if ( ei ) {
+               ei->bei_lrunext = NULL;
+               ei->bei_state = 0;
+       } else {
+               ei = ch_calloc(1, sizeof(struct bdb_entry_info));
+               ldap_pvt_thread_mutex_init( &ei->bei_kids_mutex );
+       }
 
        return ei;
 }
@@ -52,8 +76,8 @@ bdb_cache_entry_db_relock(
 
        if ( !lock ) return 0;
 
-       lockobj.data = ei;
-       lockobj.size = sizeof(ei->bei_parent) + sizeof(ei->bei_id);
+       lockobj.data = &ei->bei_id;
+       lockobj.size = sizeof(ei->bei_id) + 1;
 
        list[0].op = DB_LOCK_PUT;
        list[0].lock = *lock;
@@ -64,7 +88,7 @@ bdb_cache_entry_db_relock(
        rc = env->lock_vec(env, locker, tryOnly ? DB_LOCK_NOWAIT : 0,
                list, 2, NULL );
 
-       if (rc) {
+       if (rc && !tryOnly) {
 #ifdef NEW_LOGGING
                LDAP_LOG( CACHE, DETAIL1, 
                        "bdb_cache_entry_db_relock: entry %ld, rw %d, rc %d\n",
@@ -80,9 +104,10 @@ bdb_cache_entry_db_relock(
        return rc;
 #endif
 }
+
 static int
-bdb_cache_entry_db_lock
-( DB_ENV *env, u_int32_t locker, EntryInfo *ei, int rw, int tryOnly, DB_LOCK *lock )
+bdb_cache_entry_db_lock( DB_ENV *env, u_int32_t locker, EntryInfo *ei,
+       int rw, int tryOnly, DB_LOCK *lock )
 {
 #ifdef NO_THREADS
        return 0;
@@ -98,12 +123,12 @@ bdb_cache_entry_db_lock
        else
                db_rw = DB_LOCK_READ;
 
-       lockobj.data = ei;
-       lockobj.size = sizeof(ei->bei_parent) + sizeof(ei->bei_id);
+       lockobj.data = &ei->bei_id;
+       lockobj.size = sizeof(ei->bei_id) + 1;
 
        rc = LOCK_GET(env, locker, tryOnly ? DB_LOCK_NOWAIT : 0,
                                        &lockobj, db_rw, lock);
-       if (rc) {
+       if (rc && !tryOnly) {
 #ifdef NEW_LOGGING
                LDAP_LOG( CACHE, DETAIL1, 
                        "bdb_cache_entry_db_lock: entry %ld, rw %d, rc %d\n",
@@ -119,14 +144,15 @@ bdb_cache_entry_db_lock
 }
 
 int
-bdb_cache_entry_db_unlock
-( DB_ENV *env, DB_LOCK *lock )
+bdb_cache_entry_db_unlock ( DB_ENV *env, DB_LOCK *lock )
 {
 #ifdef NO_THREADS
        return 0;
 #else
        int rc;
 
+       if ( !lock ) return 0;
+
        rc = LOCK_PUT ( env, lock );
        return rc;
 #endif
@@ -155,6 +181,7 @@ bdb_cache_entryinfo_destroy( EntryInfo *e )
        } else { \
                (cache)->c_lrutail = (ei)->bei_lruprev; \
        } \
+       (ei)->bei_lrunext = (ei)->bei_lruprev = NULL; \
 } while(0)
 
 #define LRU_ADD( cache, ei ) do { \
@@ -175,8 +202,10 @@ bdb_rdn_cmp( const void *v_e1, const void *v_e2 )
 {
        const EntryInfo *e1 = v_e1, *e2 = v_e2;
        int rc = e1->bei_nrdn.bv_len - e2->bei_nrdn.bv_len;
-       if (rc == 0) rc = strncmp( e1->bei_nrdn.bv_val, e2->bei_nrdn.bv_val,
-               e1->bei_nrdn.bv_len );
+       if (rc == 0) {
+               rc = strncmp( e1->bei_nrdn.bv_val, e2->bei_nrdn.bv_val,
+                       e1->bei_nrdn.bv_len );
+       }
        return rc;
 }
 
@@ -193,14 +222,13 @@ static int
 bdb_entryinfo_add_internal(
        struct bdb_info *bdb,
        EntryInfo *ei,
-       EntryInfo **res
-)
+       EntryInfo **res )
 {
        EntryInfo *ei2 = NULL;
 
        *res = NULL;
 
-       ei2 = bdb_cache_entryinfo_new();
+       ei2 = bdb_cache_entryinfo_new( &bdb->bi_cache );
 
        ldap_pvt_thread_rdwr_wlock( &bdb->bi_cache.c_rwlock );
        bdb_cache_entryinfo_lock( ei->bei_parent );
@@ -247,8 +275,7 @@ bdb_cache_find_ndn(
        Operation       *op,
        DB_TXN          *txn,
        struct berval   *ndn,
-       EntryInfo       **res
-)
+       EntryInfo       **res )
 {
        struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        EntryInfo       ei, *eip, *ei2;
@@ -266,6 +293,16 @@ bdb_cache_find_ndn(
                ptr = ndn->bv_val + ndn->bv_len - op->o_bd->be_nsuffix[0].bv_len;
                ei.bei_nrdn.bv_val = ptr;
                ei.bei_nrdn.bv_len = op->o_bd->be_nsuffix[0].bv_len;
+               /* Skip to next rdn if suffix is empty */
+               if ( ei.bei_nrdn.bv_len == 0 ) {
+                       for (ptr = ei.bei_nrdn.bv_val - 2; ptr > ndn->bv_val
+                               && !DN_SEPARATOR(*ptr); ptr--) /* empty */;
+                       if ( ptr >= ndn->bv_val ) {
+                               if (DN_SEPARATOR(*ptr)) ptr++;
+                               ei.bei_nrdn.bv_len = ei.bei_nrdn.bv_val - ptr;
+                               ei.bei_nrdn.bv_val = ptr;
+                       }
+               }
                eip = &bdb->bi_cache.c_dntree;
        }
        
@@ -275,7 +312,8 @@ bdb_cache_find_ndn(
                if ( !ei2 ) {
                        int len = ei.bei_nrdn.bv_len;
                                
-                       ei.bei_nrdn.bv_len = ndn->bv_len - (ei.bei_nrdn.bv_val - ndn->bv_val);
+                       ei.bei_nrdn.bv_len = ndn->bv_len -
+                               (ei.bei_nrdn.bv_val - ndn->bv_val);
                        bdb_cache_entryinfo_unlock( eip );
 
                        rc = bdb_dn2id( op, txn, &ei.bei_nrdn, &ei );
@@ -311,7 +349,7 @@ bdb_cache_find_ndn(
 
                /* Advance to next lower RDN */
                for (ptr = ei.bei_nrdn.bv_val - 2; ptr > ndn->bv_val
-                       && !DN_SEPARATOR(*ptr); ptr--);
+                       && !DN_SEPARATOR(*ptr); ptr--) /* empty */;
                if ( ptr >= ndn->bv_val ) {
                        if (DN_SEPARATOR(*ptr)) ptr++;
                        ei.bei_nrdn.bv_len = ei.bei_nrdn.bv_val - ptr - 1;
@@ -335,8 +373,7 @@ hdb_cache_find_parent(
        Operation *op,
        DB_TXN *txn,
        ID id,
-       EntryInfo **res
-)
+       EntryInfo **res )
 {
        struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        EntryInfo ei, eip, *ei2 = NULL, *ein = NULL, *eir = NULL;
@@ -356,7 +393,7 @@ hdb_cache_find_parent(
                ei2 = ein;
 
                /* Create a new node for the current ID */
-               ein = bdb_cache_entryinfo_new();
+               ein = bdb_cache_entryinfo_new( &bdb->bi_cache );
                ein->bei_id = ei.bei_id;
                ein->bei_kids = ei.bei_kids;
                ein->bei_nrdn = ei.bei_nrdn;
@@ -473,10 +510,15 @@ static void
 bdb_cache_lru_add(
        struct bdb_info *bdb,
        u_int32_t       locker,
-       EntryInfo *ei
-)
+       EntryInfo *ei )
 {
-       DB_LOCK         lock;
+       DB_LOCK         lock, *lockp;
+
+       if ( locker ) {
+               lockp = &lock;
+       } else {
+               lockp = NULL;
+       }
 
        /* See if we're above the cache size limit */
        if ( bdb->bi_cache.c_cursize > bdb->bi_cache.c_maxsize ) {
@@ -493,21 +535,21 @@ bdb_cache_lru_add(
                        /* If we can successfully writelock it, then
                         * the object is idle.
                         */
-                       if ( bdb_cache_entry_db_lock( bdb->bi_dbenv, locker, elru, 1, 1,
-                               &lock ) == 0 ) {
+                       if ( bdb_cache_entry_db_lock( bdb->bi_dbenv, bdb->bi_cache.c_locker, elru, 1, 1,
+                               lockp ) == 0 ) {
                                /* If there's no entry, or this node is in
                                 * the process of linking into the cache,
                                 * skip it.
                                 */
                                if ( !elru->bei_e || (elru->bei_state & CACHE_ENTRY_NOT_LINKED) ) {
-                                       bdb_cache_entry_db_unlock( bdb->bi_dbenv, &lock );
+                                       bdb_cache_entry_db_unlock( bdb->bi_dbenv, lockp );
                                        continue;
                                }
                                LRU_DELETE( &bdb->bi_cache, elru );
                                elru->bei_e->e_private = NULL;
                                bdb_entry_return( elru->bei_e );
                                elru->bei_e = NULL;
-                               bdb_cache_entry_db_unlock( bdb->bi_dbenv, &lock );
+                               bdb_cache_entry_db_unlock( bdb->bi_dbenv, lockp );
                                --bdb->bi_cache.c_cursize;
                                if (bdb->bi_cache.c_cursize < bdb->bi_cache.c_maxsize)
                                        break;
@@ -518,6 +560,22 @@ bdb_cache_lru_add(
        ldap_pvt_thread_mutex_unlock( &bdb->bi_cache.lru_mutex );
 }
 
+EntryInfo *
+bdb_cache_find_info(
+       struct bdb_info *bdb,
+       ID id )
+{
+       EntryInfo ei, *ei2;
+
+       ei.bei_id = id;
+
+       ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
+       ei2 = (EntryInfo *) avl_find( bdb->bi_cache.c_idtree,
+                                       (caddr_t) &ei, bdb_id_cmp );
+       ldap_pvt_thread_rdwr_runlock( &bdb->bi_cache.c_rwlock );
+       return ei2;
+}
+
 /*
  * cache_find_id - find an entry in the cache, given id.
  * The entry is locked for Read upon return. Call with islocked TRUE if
@@ -532,22 +590,20 @@ bdb_cache_find_id(
        EntryInfo       **eip,
        int             islocked,
        u_int32_t       locker,
-       DB_LOCK         *lock
-)
+       DB_LOCK         *lock )
 {
        struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        Entry   *ep = NULL;
        int     rc = 0;
        EntryInfo ei;
-       int lru_del = 0;
 
        ei.bei_id = id;
 
        /* If we weren't given any info, see if we have it already cached */
        if ( !*eip ) {
-again:         ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
+again: ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
                *eip = (EntryInfo *) avl_find( bdb->bi_cache.c_idtree,
-                                       (caddr_t) &ei, bdb_id_cmp );
+                       (caddr_t) &ei, bdb_id_cmp );
                if ( *eip ) {
                        /* If the lock attempt fails, the info is in use */
                        if ( ldap_pvt_thread_mutex_trylock(
@@ -584,8 +640,7 @@ again:              ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
                if ( rc == 0 ) {
                        rc = bdb_cache_find_ndn( op, tid,
                                &ep->e_nname, eip );
-                       if ( *eip )
-                               islocked = 1;
+                       if ( *eip ) islocked = 1;
                        if ( rc ) {
                                bdb_entry_return( ep );
                                ep = NULL;
@@ -593,8 +648,7 @@ again:              ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
                }
 #else
                rc = hdb_cache_find_parent(op, tid, id, eip );
-               if ( rc == 0 && *eip )
-                       islocked = 1;
+               if ( rc == 0 && *eip ) islocked = 1;
 #endif
        }
 
@@ -603,54 +657,115 @@ again:           ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
                if ( (*eip)->bei_state & CACHE_ENTRY_DELETED ) {
                        rc = DB_NOTFOUND;
                } else {
-                       bdb_cache_entry_db_lock( bdb->bi_dbenv, locker,
-                                       *eip, 0, 0, lock );
-                       if ( !(*eip)->bei_e ) {
-                               if (!ep) {
-                                       rc = bdb_id2entry( op->o_bd, tid, id, &ep );
-                               }
-                               if ( rc == 0 ) {
-                                       bdb_cache_entry_db_relock( bdb->bi_dbenv, locker,
-                                               *eip, 1, 0, lock );
-                                       /* Make sure no other modifier beat us to it */
-                                       if ( (*eip)->bei_e ) {
-                                               bdb_entry_return( ep );
-                                               ep = NULL;
+                       int load = 0;
+                       /* Make sure only one thread tries to load the entry */
+load1:         if ( !(*eip)->bei_e && !((*eip)->bei_state & CACHE_ENTRY_LOADING)) {
+                               load = 1;
+                               (*eip)->bei_state |= CACHE_ENTRY_LOADING;
+                       }
+                       if ( islocked ) {
+                               bdb_cache_entryinfo_unlock( *eip );
+                               islocked = 0;
+                       }
+                       rc = bdb_cache_entry_db_lock( bdb->bi_dbenv, locker, *eip, 0, 0, lock );
+                       if ( (*eip)->bei_state & CACHE_ENTRY_DELETED ) {
+                               rc = DB_NOTFOUND;
+                               bdb_cache_entry_db_unlock( bdb->bi_dbenv, lock );
+                       } else if ( rc == 0 ) {
+                               if ( load ) {
+                                       DB_TXN *ltid;
+                                       u_int32_t locker2 = locker;
+
+                                       /* We don't wrap entire read operations in txn's, but
+                                        * we need our cache entry lock and any DB page locks
+                                        * to be associated, in order for deadlock detection
+                                        * to work properly. So if we need to read from the DB,
+                                        * we use a long-lived per-thread txn for this step.
+                                        */
+                                       if ( !ep && !tid ) {
+                                               rc = bdb_txn_get( op, bdb->bi_dbenv, &ltid );
+                                               if ( ltid )
+                                                       locker2 = TXN_ID( ltid );
                                        } else {
+                                               ltid = tid;
+                                       }
+                                       /* Give up original read lock, obtain write lock with
+                                        * (possibly) new locker ID.
+                                        */
+                                   if ( rc == 0 ) {
+                                               rc = bdb_cache_entry_db_relock( bdb->bi_dbenv, locker2,
+                                                       *eip, 1, 0, lock );
+                                       }
+                                       if ( rc == 0 && !ep) {
+                                               rc = bdb_id2entry( op->o_bd, ltid, id, &ep );
+                                       }
+                                       if ( rc == 0 ) {
                                                ep->e_private = *eip;
 #ifdef BDB_HIER
                                                bdb_fix_dn( ep, 0 );
 #endif
                                                (*eip)->bei_e = ep;
+                                               ep = NULL;
                                        }
-                                       bdb_cache_entry_db_relock( bdb->bi_dbenv, locker,
-                                               *eip, 0, 0, lock );
-                               }
-                       } else {
-                               /* If we had the entry already, this item
-                                * is on the LRU list.
-                                */
-                               lru_del = 1;
+                                       (*eip)->bei_state ^= CACHE_ENTRY_LOADING;
+                                       if ( rc == 0 ) {
+                                               /* If we succeeded, downgrade back to a readlock. */
+                                               rc = bdb_cache_entry_db_relock( bdb->bi_dbenv, locker,
+                                                       *eip, 0, 0, lock );
+                                       } else {
+                                               /* Otherwise, release the lock. */
+                                               bdb_cache_entry_db_unlock( bdb->bi_dbenv, lock );
+                                       }
+                                       if ( locker2 != locker ) {
+                                               /* If we're using the per-thread txn, release all
+                                                * of its page locks now.
+                                                */
+                                               DB_LOCKREQ list;
+                                               list.op = DB_LOCK_PUT_ALL;
+                                               list.obj = NULL;
+                                               bdb->bi_dbenv->lock_vec( bdb->bi_dbenv, locker2,
+                                                       0, &list, 1, NULL );
+                                       }
+                               } else if ( !(*eip)->bei_e ) {
+                                       /* Some other thread is trying to load the entry,
+                                        * give it a chance to finish.
+                                        */
+                                       bdb_cache_entry_db_unlock( bdb->bi_dbenv, lock );
+                                       ldap_pvt_thread_yield();
+                                       bdb_cache_entryinfo_lock( *eip );
+                                       islocked = 1;
+                                       goto load1;
 #ifdef BDB_HIER
-                               rc = bdb_fix_dn( (*eip)->bei_e, 1 );
-                               if ( rc ) {
-                                       bdb_cache_entry_db_relock( bdb->bi_dbenv,
-                                               locker, *eip, 1, 0, lock );
-                                       /* check again in case other modifier did it already */
-                                       if ( bdb_fix_dn( (*eip)->bei_e, 1 ) )
-                                               rc = bdb_fix_dn( (*eip)->bei_e, 2 );
-                                       bdb_cache_entry_db_relock( bdb->bi_dbenv,
-                                               locker, *eip, 0, 0, lock );
-                               }
+                               } else {
+                                       /* Check for subtree renames
+                                        */
+                                       rc = bdb_fix_dn( (*eip)->bei_e, 1 );
+                                       if ( rc ) {
+                                               bdb_cache_entry_db_relock( bdb->bi_dbenv,
+                                                       locker, *eip, 1, 0, lock );
+                                               /* check again in case other modifier did it already */
+                                               if ( bdb_fix_dn( (*eip)->bei_e, 1 ) )
+                                                       rc = bdb_fix_dn( (*eip)->bei_e, 2 );
+                                               bdb_cache_entry_db_relock( bdb->bi_dbenv,
+                                                       locker, *eip, 0, 0, lock );
+                                       }
 #endif
+                               }
+
                        }
                }
        }
+       if ( islocked ) {
+               bdb_cache_entryinfo_unlock( *eip );
+       }
+       if ( ep ) {
+               bdb_entry_return( ep );
+       }
        if ( rc == 0 ) {
                /* set lru mutex */
                ldap_pvt_thread_mutex_lock( &bdb->bi_cache.lru_mutex );
-               /* if entry is old, remove from old spot on LRU list */
-               if ( lru_del ) {
+               /* if entry is on LRU list, remove from old spot */
+               if ( (*eip)->bei_lrunext || (*eip)->bei_lruprev ) {
                        LRU_DELETE( &bdb->bi_cache, *eip );
                } else {
                /* if entry is new, bump cache size */
@@ -660,9 +775,6 @@ again:              ldap_pvt_thread_rdwr_rlock( &bdb->bi_cache.c_rwlock );
                bdb_cache_lru_add( bdb, locker, *eip );
        }
 
-       if ( islocked ) {
-               bdb_cache_entryinfo_unlock( *eip );
-       }
        return rc;
 }
 
@@ -670,8 +782,7 @@ int
 bdb_cache_children(
        Operation *op,
        DB_TXN *txn,
-       Entry *e
-)
+       Entry *e )
 {
        int rc;
 
@@ -683,7 +794,7 @@ bdb_cache_children(
        }
        rc = bdb_dn2id_children( op, txn, e );
        if ( rc == DB_NOTFOUND ) {
-               BEI(e)->bei_state |= CACHE_ENTRY_NO_KIDS;
+               BEI(e)->bei_state |= CACHE_ENTRY_NO_KIDS | CACHE_ENTRY_NO_GRANDKIDS;
        }
        return rc;
 }
@@ -695,16 +806,27 @@ bdb_cache_add(
        EntryInfo *eip,
        Entry *e,
        struct berval *nrdn,
-       u_int32_t locker
-)
+       u_int32_t locker )
 {
        EntryInfo *new, ei;
        struct berval rdn = e->e_name;
+       DB_LOCK lock;
        int rc;
 
        ei.bei_id = e->e_id;
        ei.bei_parent = eip;
        ei.bei_nrdn = *nrdn;
+       ei.bei_lockpad = 0;
+
+       /* Lock this entry so that bdb_add can run to completion.
+        * It can only fail if BDB has run out of lock resources.
+        */
+       rc = bdb_cache_entry_db_lock( bdb->bi_dbenv, locker, &ei, 1, 0, &lock );
+       if ( rc ) {
+               bdb_cache_entryinfo_unlock( eip );
+               return rc;
+       }
+
 #ifdef BDB_HIER
        if ( nrdn->bv_len != e->e_nname.bv_len ) {
                char *ptr = strchr( rdn.bv_val, ',' );
@@ -713,11 +835,20 @@ bdb_cache_add(
        ber_dupbv( &ei.bei_rdn, &rdn );
        if ( eip->bei_dkids ) eip->bei_dkids++;
 #endif
+
        rc = bdb_entryinfo_add_internal( bdb, &ei, &new );
+       /* bdb_csn_commit can cause this when adding the database root entry */
+       if ( new->bei_e ) {
+               new->bei_e->e_private = NULL;
+               bdb_entry_return( new->bei_e );
+       }
        new->bei_e = e;
        e->e_private = new;
-       new->bei_state = CACHE_ENTRY_NO_KIDS;
+       new->bei_state = CACHE_ENTRY_NO_KIDS | CACHE_ENTRY_NO_GRANDKIDS;
        eip->bei_state &= ~CACHE_ENTRY_NO_KIDS;
+       if (eip->bei_parent) {
+               eip->bei_parent->bei_state &= ~CACHE_ENTRY_NO_GRANDKIDS;
+       }
 
        /* set lru mutex */
        ldap_pvt_thread_mutex_lock( &bdb->bi_cache.lru_mutex );
@@ -736,23 +867,23 @@ bdb_cache_modify(
        Attribute *newAttrs,
        DB_ENV *env,
        u_int32_t locker,
-       DB_LOCK *lock
-)
+       DB_LOCK *lock )
 {
        EntryInfo *ei = BEI(e);
-       
+       int rc;
        /* Get write lock on data */
-       bdb_cache_entry_db_relock( env, locker, ei, 1, 0, lock );
+       rc = bdb_cache_entry_db_relock( env, locker, ei, 1, 0, lock );
 
        /* If we've done repeated mods on a cached entry, then e_attrs
         * is no longer contiguous with the entry, and must be freed.
         */
-       if ( (void *)e->e_attrs != (void *)(e+1) ) {
-               attrs_free( e->e_attrs );
+       if ( ! rc ) {
+               if ( (void *)e->e_attrs != (void *)(e+1) ) {
+                       attrs_free( e->e_attrs ); 
+               }
+               e->e_attrs = newAttrs;
        }
-       e->e_attrs = newAttrs;
-
-       return 0;
+       return rc;
 }
 
 /*
@@ -766,15 +897,15 @@ bdb_cache_modrdn(
        EntryInfo *ein,
        DB_ENV *env,
        u_int32_t locker,
-       DB_LOCK *lock
-)
+       DB_LOCK *lock )
 {
        EntryInfo *ei = BEI(e), *pei;
        struct berval rdn;
-       int rc = 0;
+       int rc;
 
        /* Get write lock on data */
-       bdb_cache_entry_db_relock( env, locker, ei, 1, 0, lock );
+       rc =  bdb_cache_entry_db_relock( env, locker, ei, 1, 0, lock );
+       if ( rc ) return rc;
 
        /* If we've done repeated mods on a cached entry, then e_attrs
         * is no longer contiguous with the entry, and must be freed.
@@ -783,8 +914,9 @@ bdb_cache_modrdn(
                attrs_free( e->e_attrs );
        }
        e->e_attrs = new->e_attrs;
-       if( e->e_nname.bv_val < e->e_bv.bv_val || e->e_nname.bv_val >
-               e->e_bv.bv_val + e->e_bv.bv_len ) {
+       if( e->e_nname.bv_val < e->e_bv.bv_val ||
+               e->e_nname.bv_val > e->e_bv.bv_val + e->e_bv.bv_len )
+       {
                ch_free(e->e_name.bv_val);
                ch_free(e->e_nname.bv_val);
        }
@@ -816,11 +948,11 @@ bdb_cache_modrdn(
                bdb_cache_entryinfo_lock( ein );
        }
 #ifdef BDB_HIER
-       { int max = ei->bei_modrdns;
-       /* Record the generation number of this change */
+       {
+               int max = ei->bei_modrdns;
+               /* Record the generation number of this change */
                for ( pei = ein; pei->bei_parent; pei = pei->bei_parent ) {
-                       if ( pei->bei_modrdns > max )
-                               max = pei->bei_modrdns;
+                       if ( pei->bei_modrdns > max ) max = pei->bei_modrdns;
                }
                ei->bei_modrdns = max + 1;
        }
@@ -842,8 +974,7 @@ bdb_cache_delete(
     Entry              *e,
     DB_ENV     *env,
     u_int32_t  locker,
-    DB_LOCK    *lock
-)
+    DB_LOCK    *lock )
 {
        EntryInfo *ei = BEI(e);
        int     rc;
@@ -857,7 +988,13 @@ bdb_cache_delete(
        bdb_cache_entryinfo_lock( ei );
 
        /* Get write lock on the data */
-       bdb_cache_entry_db_relock( env, locker, ei, 1, 0, lock );
+       rc = bdb_cache_entry_db_relock( env, locker, ei, 1, 0, lock );
+       if ( rc ) {
+               /* couldn't lock, undo and give up */
+               ei->bei_state ^= CACHE_ENTRY_DELETED;
+               bdb_cache_entryinfo_unlock( ei );
+               return rc;
+       }
 
        /* set cache write lock */
        ldap_pvt_thread_rdwr_wlock( &cache->c_rwlock );
@@ -890,20 +1027,39 @@ bdb_cache_delete(
 
 void
 bdb_cache_delete_cleanup(
-       Entry *e
-)
+       Cache *cache,
+       Entry *e )
 {
-       bdb_cache_entryinfo_unlock( BEI(e) );
-       bdb_cache_entryinfo_destroy( e->e_private );
+       EntryInfo *ei = BEI(e);
+
+       ei->bei_e = NULL;
        e->e_private = NULL;
        bdb_entry_return( e );
+
+       free( ei->bei_nrdn.bv_val );
+       ei->bei_nrdn.bv_val = NULL;
+#ifdef BDB_HIER
+       free( ei->bei_rdn.bv_val );
+       ei->bei_rdn.bv_val = NULL;
+       ei->bei_modrdns = 0;
+       ei->bei_ckids = 0;
+       ei->bei_dkids = 0;
+#endif
+       ei->bei_parent = NULL;
+       ei->bei_kids = NULL;
+       ei->bei_lruprev = NULL;
+
+       ldap_pvt_thread_rdwr_wlock( &cache->c_rwlock );
+       ei->bei_lrunext = cache->c_eifree;
+       cache->c_eifree = ei;
+       ldap_pvt_thread_rdwr_wunlock( &cache->c_rwlock );
+       bdb_cache_entryinfo_unlock( ei );
 }
-       
+
 static int
 bdb_cache_delete_internal(
     Cache      *cache,
-    EntryInfo          *e
-)
+    EntryInfo          *e )
 {
        int rc = 0;     /* return code */
 
@@ -912,14 +1068,14 @@ bdb_cache_delete_internal(
        if ( e->bei_parent->bei_dkids ) e->bei_parent->bei_dkids--;
 #endif
        /* dn tree */
-       if ( avl_delete( &e->bei_parent->bei_kids, (caddr_t) e, bdb_rdn_cmp ) == NULL )
+       if ( avl_delete( &e->bei_parent->bei_kids, (caddr_t) e, bdb_rdn_cmp )
+               == NULL )
        {
                rc = -1;
        }
 
        /* id tree */
-       if ( avl_delete( &cache->c_idtree, (caddr_t) e, bdb_id_cmp ) == NULL )
-       {
+       if ( avl_delete( &cache->c_idtree, (caddr_t) e, bdb_id_cmp ) == NULL ) {
                rc = -1;
        }
 
@@ -969,6 +1125,10 @@ bdb_cache_release_all( Cache *cache )
 
        avl_free( cache->c_dntree.bei_kids, NULL );
        avl_free( cache->c_idtree, bdb_entryinfo_release );
+       for (;cache->c_eifree;cache->c_eifree = cache->c_lruhead) {
+               cache->c_lruhead = cache->c_eifree->bei_lrunext;
+               bdb_cache_entryinfo_destroy(cache->c_eifree);
+       }
        cache->c_lruhead = NULL;
        cache->c_lrutail = NULL;
 
@@ -997,6 +1157,60 @@ bdb_lru_print( Cache *cache )
 }
 #endif
 
+static void
+bdb_txn_free( void *key, void *data )
+{
+       DB_TXN *txn = data;
+       TXN_ABORT( txn );
+}
+
+/* Obtain a long-lived transaction for the current thread */
+static int
+bdb_txn_get( Operation *op, DB_ENV *env, DB_TXN **txn )
+{
+       int i, rc, lockid;
+       void *ctx, *data;
+
+       /* If no op was provided, try to find the ctx anyway... */
+       if ( op ) {
+               ctx = op->o_threadctx;
+       } else {
+               ctx = ldap_pvt_thread_pool_context();
+       }
+
+       /* Shouldn't happen unless we're single-threaded */
+       if ( !ctx ) {
+               *txn = NULL;
+               return 0;
+       }
+
+       if ( ldap_pvt_thread_pool_getkey( ctx, ((char *)env)+1, &data, NULL ) ) {
+               for ( i=0, rc=1; rc != 0 && i<4; i++ ) {
+                       rc = TXN_BEGIN( env, NULL, txn, 0 );
+                       if (rc) ldap_pvt_thread_yield();
+               }
+               if ( rc != 0) {
+                       return rc;
+               }
+               if ( ( rc = ldap_pvt_thread_pool_setkey( ctx, ((char *)env)+1,
+                       *txn, bdb_txn_free ) ) ) {
+                       TXN_ABORT( *txn );
+#ifdef NEW_LOGGING
+                       LDAP_LOG( BACK_BDB, ERR, "bdb_txn_get: err %s(%d)\n",
+                               db_strerror(rc), rc, 0 );
+#else
+                       Debug( LDAP_DEBUG_ANY, "bdb_txn_get: err %s(%d)\n",
+                               db_strerror(rc), rc, 0 );
+#endif
+
+                       return rc;
+               }
+       } else {
+               *txn = data;
+       }
+       return 0;
+}
+
 #ifdef BDB_REUSE_LOCKERS
 static void
 bdb_locker_id_free( void *key, void *data )
@@ -1005,7 +1219,6 @@ bdb_locker_id_free( void *key, void *data )
        int lockid = (int) data;
        int rc;
 
-
        rc = XLOCK_ID_FREE( env, lockid );
        if ( rc == EINVAL ) {
                DB_LOCKREQ lr;
@@ -1018,10 +1231,9 @@ bdb_locker_id_free( void *key, void *data )
                        "bdb_locker_id_free: %d err %s(%d)\n",
                        lockid, db_strerror(rc), rc );
 #endif
-               memset( &lr, 0, sizeof(lr) );
-
                /* release all locks held by this locker. */
                lr.op = DB_LOCK_PUT_ALL;
+               lr.obj = NULL;
                env->lock_vec( env, lockid, 0, &lr, 1, NULL );
                XLOCK_ID_FREE( env, lockid );
        }
@@ -1087,7 +1299,8 @@ bdb_cache_delete_entry(
        DB_LOCK *lock )
 {
        ldap_pvt_thread_rdwr_wlock( &bdb->bi_cache.c_rwlock );
-       if ( bdb_cache_entry_db_lock( bdb->bi_dbenv, locker, ei, 1, 1, &lock ) == 0 ) {
+       if ( bdb_cache_entry_db_lock( bdb->bi_dbenv, bdb->bi_cache.c_locker, ei, 1, 1, lock ) == 0 )
+       {
                if ( ei->bei_e && !(ei->bei_state & CACHE_ENTRY_NOT_LINKED )) {
                        LRU_DELETE( &bdb->bi_cache, ei );
                        ei->bei_e->e_private = NULL;
@@ -1095,7 +1308,7 @@ bdb_cache_delete_entry(
                        ei->bei_e = NULL;
                        --bdb->bi_cache.c_cursize;
                }
-               bdb_cache_entry_db_unlock( bdb->bi_dbenv, &lock );
+               bdb_cache_entry_db_unlock( bdb->bi_dbenv, lock );
        }
        ldap_pvt_thread_rdwr_wunlock( &bdb->bi_cache.c_rwlock );
 }