]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/delete.c
use slab memory for proxyauthz
[openldap] / servers / slapd / back-bdb / delete.c
index 045e5e28bf8f9b180b53299d71231b6faf351f34..a8d144b6312dd27544e9b22800fcab57249984ee 100644 (file)
@@ -1,8 +1,17 @@
 /* delete.c - bdb backend delete routine */
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 2000-2006 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
 #include <stdio.h>
 #include <ac/string.h>
 
+#include "lutil.h"
 #include "back-bdb.h"
-#include "external.h"
 
 int
-bdb_delete(
-       BackendDB       *be,
-       Connection      *conn,
-       Operation       *op,
-       struct berval   *dn,
-       struct berval   *ndn
-)
+bdb_delete( Operation *op, SlapReply *rs )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
-       Entry   *matched;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
+       Entry   *matched = NULL;
        struct berval   pdn = {0, NULL};
        Entry   *e = NULL;
        Entry   *p = NULL;
-       int     rc;
-       const char *text;
+       EntryInfo       *ei = NULL, *eip = NULL;
        int             manageDSAit = get_manageDSAit( op );
        AttributeDescription *children = slap_schema.si_ad_children;
        AttributeDescription *entry = slap_schema.si_ad_entry;
-       DB_TXN          *ltid = NULL;
-       struct bdb_op_info opinfo;
-
-       u_int32_t       locker;
-       DB_LOCK         lock;
-#if 0
-       u_int32_t       lockid;
-       DB_LOCK         lock;
-#endif
+       DB_TXN          *ltid = NULL, *lt2;
+       struct bdb_op_info opinfo = {0};
+       ID      eid;
 
-       int             noop = 0;
+       u_int32_t       locker = 0;
+       DB_LOCK         lock, plock;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ARGS,  "==> bdb_delete: %s\n", dn->bv_val, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_ARGS, "==> bdb_delete: %s\n",
-               dn->bv_val, 0, 0 );
-#endif
+       int             num_retries = 0;
+
+       int     rc;
+
+       LDAPControl **preread_ctrl = NULL;
+       LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
+       int num_ctrls = 0;
+
+       int     parent_is_glue = 0;
+       int parent_is_leaf = 0;
+
+       ctrls[num_ctrls] = 0;
+
+       Debug( LDAP_DEBUG_ARGS, "==> " LDAP_XSTRING(bdb_delete) ": %s\n",
+               op->o_req_dn.bv_val, 0, 0 );
+
+       /* allocate CSN */
+       if ( !SLAP_SHADOW( op->o_bd )) {
+               struct berval csn;
+               char csnbuf[LDAP_LUTIL_CSNSTR_BUFSIZE];
+
+               csn.bv_val = csnbuf;
+               csn.bv_len = sizeof(csnbuf);
+               slap_get_csn( op, &csn, 1 );
+       }
 
        if( 0 ) {
 retry: /* transaction retry */
                if( e != NULL ) {
                        bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
+                       e = NULL;
                }
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "==> bdb_delete: retrying...\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "==> bdb_delete: retrying...\n",
+               if( p != NULL ) {
+                       bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, p);
+                       p = NULL;
+               }
+               Debug( LDAP_DEBUG_TRACE,
+                       "==> " LDAP_XSTRING(bdb_delete) ": retrying...\n",
                        0, 0, 0 );
-#endif
-               rc = TXN_ABORT( ltid );
+               rs->sr_err = TXN_ABORT( ltid );
                ltid = NULL;
                op->o_private = NULL;
-               if( rc != 0 ) {
-                       rc = LDAP_OTHER;
-                       text = "internal error";
+               op->o_do_not_cache = opinfo.boi_acl_cache;
+               if( rs->sr_err != 0 ) {
+                       rs->sr_err = LDAP_OTHER;
+                       rs->sr_text = "internal error";
                        goto return_results;
                }
+               if ( op->o_abandon ) {
+                       rs->sr_err = SLAPD_ABANDON;
+                       goto return_results;
+               }
+               parent_is_glue = 0;
+               parent_is_leaf = 0;
                ldap_pvt_thread_yield();
+               bdb_trans_backoff( ++num_retries );
        }
 
        /* begin transaction */
-       rc = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
+       rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, NULL, &ltid, 
                bdb->bi_db_opflags );
-       text = NULL;
-       if( rc != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "==> bdb_delete: txn_begin failed: %s (%d)\n",
-                       db_strerror(rc), rc, 0 );
-#else
+       rs->sr_text = NULL;
+       if( rs->sr_err != 0 ) {
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_delete: txn_begin failed: %s (%d)\n",
-                       db_strerror(rc), rc, 0 );
-#endif
-               rc = LDAP_OTHER;
-               text = "internal error";
+                       LDAP_XSTRING(bdb_delete) ": txn_begin failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
+               rs->sr_err = LDAP_OTHER;
+               rs->sr_text = "internal error";
                goto return_results;
        }
 
        locker = TXN_ID ( ltid );
-#if 0
-       lockid = TXN_ID( ltid );
-#endif
 
-       opinfo.boi_bdb = be;
+       opinfo.boi_bdb = op->o_bd;
        opinfo.boi_txn = ltid;
+       opinfo.boi_locker = locker;
        opinfo.boi_err = 0;
+       opinfo.boi_acl_cache = op->o_do_not_cache;
        op->o_private = &opinfo;
 
-       if ( !be_issuffix( be, ndn ) ) {
-               dnParent( ndn, &pdn );
+       if ( !be_issuffix( op->o_bd, &op->o_req_ndn ) ) {
+               dnParent( &op->o_req_ndn, &pdn );
        }
 
-       if( pdn.bv_len != 0 ) {
-#if 0
-               if ( ltid ) {
-                       DBT obj;
-                       obj.data = pdn.bv_val-1;
-                       obj.size = pdn.bv_len+1;
-                       rc = LOCK_GET( bdb->bi_dbenv, lockid, 0, &obj,
-                               DB_LOCK_WRITE, &lock);
-               }
-#endif
-               /* get parent */
-               rc = bdb_dn2entry_r( be, ltid, &pdn, &p, NULL, 0, locker, &lock );
+       /* get entry */
+       rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
+               locker, &lock );
 
-               switch( rc ) {
-               case 0:
-               case DB_NOTFOUND:
-                       break;
-               case DB_LOCK_DEADLOCK:
-               case DB_LOCK_NOTGRANTED:
-                       goto retry;
-               case LDAP_BUSY:
-                       text = "ldap server busy";
-                       goto return_results;
-               default:
-                       rc = LDAP_OTHER;
-                       text = "internal error";
-                       goto return_results;
+       switch( rs->sr_err ) {
+       case 0:
+       case DB_NOTFOUND:
+               break;
+       case DB_LOCK_DEADLOCK:
+       case DB_LOCK_NOTGRANTED:
+               goto retry;
+       case LDAP_BUSY:
+               rs->sr_text = "ldap server busy";
+               goto return_results;
+       default:
+               rs->sr_err = LDAP_OTHER;
+               rs->sr_text = "internal error";
+               goto return_results;
+       }
+
+       if ( rs->sr_err == 0 ) {
+               e = ei->bei_e;
+               eip = ei->bei_parent;
+       } else {
+               matched = ei->bei_e;
+       }
+
+       /* FIXME : dn2entry() should return non-glue entry */
+       if ( e == NULL || ( !manageDSAit && is_entry_glue( e ))) {
+               Debug( LDAP_DEBUG_ARGS,
+                       "<=- " LDAP_XSTRING(bdb_delete) ": no such object %s\n",
+                       op->o_req_dn.bv_val, 0, 0);
+
+               if ( matched != NULL ) {
+                       rs->sr_matched = ch_strdup( matched->e_dn );
+                       rs->sr_ref = is_entry_referral( matched )
+                               ? get_entry_referrals( op, matched )
+                               : NULL;
+                       bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, matched);
+                       matched = NULL;
+
+               } else {
+                       rs->sr_ref = referral_rewrite( default_referral, NULL,
+                                       &op->o_req_dn, LDAP_SCOPE_DEFAULT );
                }
 
-               if( p == NULL) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "<=- bdb_delete: parent does not exist\n", 0, 0, 0 );
-#else
+               rs->sr_err = LDAP_REFERRAL;
+               rs->sr_flags = REP_MATCHED_MUSTBEFREED | REP_REF_MUSTBEFREED;
+               goto return_results;
+       }
+
+       rc = bdb_cache_find_id( op, ltid, eip->bei_id, &eip, 0, locker, &plock );
+       switch( rc ) {
+       case DB_LOCK_DEADLOCK:
+       case DB_LOCK_NOTGRANTED:
+               goto retry;
+       case 0:
+       case DB_NOTFOUND:
+               break;
+       default:
+               rs->sr_err = LDAP_OTHER;
+               rs->sr_text = "internal error";
+               goto return_results;
+       }
+       if ( eip ) p = eip->bei_e;
+
+       if ( pdn.bv_len != 0 ) {
+               if( p == NULL || !bvmatch( &pdn, &p->e_nname )) {
                        Debug( LDAP_DEBUG_TRACE,
-                               "<=- bdb_delete: parent does not exist\n",
-                               0, 0, 0);
-#endif
-                       rc = LDAP_OTHER;
-                       text = "could not locate parent of entry";
+                               "<=- " LDAP_XSTRING(bdb_delete) ": parent "
+                               "does not exist\n", 0, 0, 0 );
+                       rs->sr_err = LDAP_OTHER;
+                       rs->sr_text = "could not locate parent of entry";
                        goto return_results;
                }
 
                /* check parent for "children" acl */
-               rc = access_allowed( be, conn, op, p,
-                       children, NULL, ACL_WRITE, NULL );
-
-               bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, p);
-               p = NULL;
-
-               switch( opinfo.boi_err ) {
-               case DB_LOCK_DEADLOCK:
-               case DB_LOCK_NOTGRANTED:
-                       goto retry;
-               }
+               rs->sr_err = access_allowed( op, p,
+                       children, NULL, ACL_WDEL, NULL );
+
+               if ( !rs->sr_err  ) {
+                       switch( opinfo.boi_err ) {
+                       case DB_LOCK_DEADLOCK:
+                       case DB_LOCK_NOTGRANTED:
+                               goto retry;
+                       }
 
-               if ( !rc  ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "<=- bdb_delete: no access to parent\n", 0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
-                               "<=- bdb_delete: no access to parent\n",
-                               0, 0, 0 );
-#endif
-                       rc = LDAP_INSUFFICIENT_ACCESS;
+                               "<=- " LDAP_XSTRING(bdb_delete) ": no write "
+                               "access to parent\n", 0, 0, 0 );
+                       rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
+                       rs->sr_text = "no write access to parent";
                        goto return_results;
                }
 
        } else {
                /* no parent, must be root to delete */
-               if( ! be_isroot( be, &op->o_ndn ) ) {
-                       if ( be_issuffix( be, (struct berval *)&slap_empty_bv )
-                               || be_isupdate( be, &op->o_ndn ) ) {
+               if( ! be_isroot( op ) ) {
+                       if ( be_issuffix( op->o_bd, (struct berval *)&slap_empty_bv )
+                               || be_shadow_update( op ) ) {
                                p = (Entry *)&slap_entry_root;
 
                                /* check parent for "children" acl */
-                               rc = access_allowed( be, conn, op, p,
-                                       children, NULL, ACL_WRITE, NULL );
+                               rs->sr_err = access_allowed( op, p,
+                                       children, NULL, ACL_WDEL, NULL );
 
                                p = NULL;
 
-                               switch( opinfo.boi_err ) {
-                               case DB_LOCK_DEADLOCK:
-                               case DB_LOCK_NOTGRANTED:
-                                       goto retry;
-                               }
+                               if ( !rs->sr_err  ) {
+                                       switch( opinfo.boi_err ) {
+                                       case DB_LOCK_DEADLOCK:
+                                       case DB_LOCK_NOTGRANTED:
+                                               goto retry;
+                                       }
 
-                               if ( !rc  ) {
-#ifdef NEW_LOGGING
-                                       LDAP_LOG ( OPERATION, DETAIL1, 
-                                               "<=- bdb_delete: no access to parent\n", 0, 0, 0 );
-#else
                                        Debug( LDAP_DEBUG_TRACE,
-                                               "<=- bdb_delete: no access "
-                                               "to parent\n", 0, 0, 0 );
-#endif
-                                       rc = LDAP_INSUFFICIENT_ACCESS;
+                                               "<=- " LDAP_XSTRING(bdb_delete)
+                                               ": no access to parent\n",
+                                               0, 0, 0 );
+                                       rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
+                                       rs->sr_text = "no write access to parent";
                                        goto return_results;
                                }
 
                        } else {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, DETAIL1, 
-                                       "<=- bdb_delete: no parent and not root\n", 0, 0, 0 );
-#else
                                Debug( LDAP_DEBUG_TRACE,
-                                       "<=- bdb_delete: no parent "
-                                       "and not root\n", 0, 0, 0);
-#endif
-                               rc = LDAP_INSUFFICIENT_ACCESS;
+                                       "<=- " LDAP_XSTRING(bdb_delete)
+                                       ": no parent and not root\n", 0, 0, 0 );
+                               rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
                                goto return_results;
                        }
                }
-
-#if 0
-               if ( ltid ) {
-                       DBT obj;
-                       obj.data = ",";
-                       obj.size = 1;
-                       rc = LOCK_GET( bdb->bi_dbenv, lockid, 0, &obj,
-                               DB_LOCK_WRITE, &lock);
-               }
-#endif
        }
 
-       /* get entry for read/modify/write */
-       rc = bdb_dn2entry_w( be, ltid, ndn, &e, &matched, DB_RMW, locker, &lock );
-
-       switch( rc ) {
-       case 0:
-       case DB_NOTFOUND:
-               break;
-       case DB_LOCK_DEADLOCK:
-       case DB_LOCK_NOTGRANTED:
-               goto retry;
-       case LDAP_BUSY:
-               text = "ldap server busy";
-               goto return_results;
-       default:
-               rc = LDAP_OTHER;
-               text = "internal error";
+       if ( get_assert( op ) &&
+               ( test_filter( op, e, get_assertion( op )) != LDAP_COMPARE_TRUE ))
+       {
+               rs->sr_err = LDAP_ASSERTION_FAILED;
                goto return_results;
        }
 
-       if ( e == NULL ) {
-               char *matched_dn = NULL;
-               BerVarray refs;
-
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ARGS, 
-                       "<=- bdb_delete: no such object %s\n", dn->bv_val, 0, 0);
-#else
-               Debug( LDAP_DEBUG_ARGS,
-                       "<=- bdb_delete: no such object %s\n",
-                       dn->bv_val, 0, 0);
-#endif
+       rs->sr_err = access_allowed( op, e,
+               entry, NULL, ACL_WDEL, NULL );
 
-               if ( matched != NULL ) {
-                       matched_dn = ch_strdup( matched->e_dn );
-                       refs = is_entry_referral( matched )
-                               ? get_entry_referrals( be, conn, op, matched )
-                               : NULL;
-                       bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, matched);
-                       matched = NULL;
-
-               } else {
-                       refs = referral_rewrite( default_referral,
-                               NULL, dn, LDAP_SCOPE_DEFAULT );
+       if ( !rs->sr_err  ) {
+               switch( opinfo.boi_err ) {
+               case DB_LOCK_DEADLOCK:
+               case DB_LOCK_NOTGRANTED:
+                       goto retry;
                }
 
-               send_ldap_result( conn, op, LDAP_REFERRAL,
-                       matched_dn, NULL, refs, NULL );
-
-               ber_bvarray_free( refs );
-               free( matched_dn );
-
-               rc = -1;
-               goto done;
-       }
-
-       rc = access_allowed( be, conn, op, e,
-               entry, NULL, ACL_WRITE, NULL );
-
-       switch( opinfo.boi_err ) {
-       case DB_LOCK_DEADLOCK:
-       case DB_LOCK_NOTGRANTED:
-               goto retry;
-       }
-
-       if ( !rc  ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "<=- bdb_delete: no access to entry\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "<=- bdb_delete: no access to entry\n",
-                       0, 0, 0 );
-#endif
-               rc = LDAP_INSUFFICIENT_ACCESS;
+                       "<=- " LDAP_XSTRING(bdb_delete) ": no write access "
+                       "to entry\n", 0, 0, 0 );
+               rs->sr_err = LDAP_INSUFFICIENT_ACCESS;
+               rs->sr_text = "no write access to entry";
                goto return_results;
        }
 
        if ( !manageDSAit && is_entry_referral( e ) ) {
                /* entry is a referral, don't allow delete */
-               BerVarray refs = get_entry_referrals( be,
-                       conn, op, e );
+               rs->sr_ref = get_entry_referrals( op, e );
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "<=- bdb_delete: entry is referral\n", 0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_delete: entry is referral\n",
+                       LDAP_XSTRING(bdb_delete) ": entry is referral\n",
                        0, 0, 0 );
-#endif
 
-               send_ldap_result( conn, op, LDAP_REFERRAL,
-                       e->e_dn, NULL, refs, NULL );
+               rs->sr_err = LDAP_REFERRAL;
+               rs->sr_matched = ch_strdup( e->e_name.bv_val );
+               rs->sr_flags = REP_MATCHED_MUSTBEFREED | REP_REF_MUSTBEFREED;
+               goto return_results;
+       }
 
-               ber_bvarray_free( refs );
+       /* pre-read */
+       if( op->o_preread ) {
+               if( preread_ctrl == NULL ) {
+                       preread_ctrl = &ctrls[num_ctrls++];
+                       ctrls[num_ctrls] = NULL;
+               }
+               if( slap_read_controls( op, rs, e,
+                       &slap_pre_read_bv, preread_ctrl ) )
+               {
+                       Debug( LDAP_DEBUG_TRACE,
+                               "<=- " LDAP_XSTRING(bdb_delete) ": pre-read "
+                               "failed!\n", 0, 0, 0 );
+                       goto return_results;
+               }
+       }
 
-               rc = 1;
-               goto done;
+       /* nested transaction */
+       rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
+               bdb->bi_db_opflags );
+       rs->sr_text = NULL;
+       if( rs->sr_err != 0 ) {
+               Debug( LDAP_DEBUG_TRACE,
+                       LDAP_XSTRING(bdb_delete) ": txn_begin(2) failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
+               rs->sr_err = LDAP_OTHER;
+               rs->sr_text = "internal error";
+               goto return_results;
        }
 
-       rc = bdb_dn2id_children( be, ltid, &e->e_nname, 0 );
-       if( rc != DB_NOTFOUND ) {
-               switch( rc ) {
+       /* Can't do it if we have kids */
+       rs->sr_err = bdb_cache_children( op, lt2, e );
+       if( rs->sr_err != DB_NOTFOUND ) {
+               switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        goto retry;
                case 0:
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "<=- bdb_delete: non-leaf %s\n", dn->bv_val, 0, 0 );
-#else
                        Debug(LDAP_DEBUG_ARGS,
-                               "<=- bdb_delete: non-leaf %s\n",
-                               dn->bv_val, 0, 0);
-#endif
-                       rc = LDAP_NOT_ALLOWED_ON_NONLEAF;
-                       text = "subtree delete not supported";
+                               "<=- " LDAP_XSTRING(bdb_delete)
+                               ": non-leaf %s\n",
+                               op->o_req_dn.bv_val, 0, 0);
+                       rs->sr_err = LDAP_NOT_ALLOWED_ON_NONLEAF;
+                       rs->sr_text = "subordinate objects must be deleted first";
                        break;
                default:
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, 
-                               "<=- bdb_delete: has_children failed %s (%d)\n",
-                               db_strerror(rc), rc, 0 );
-#else
                        Debug(LDAP_DEBUG_ARGS,
-                               "<=- bdb_delete: has_children failed: %s (%d)\n",
-                               db_strerror(rc), rc, 0 );
-#endif
-                       rc = LDAP_OTHER;
-                       text = "internal error";
+                               "<=- " LDAP_XSTRING(bdb_delete)
+                               ": has_children failed: %s (%d)\n",
+                               db_strerror(rs->sr_err), rs->sr_err, 0 );
+                       rs->sr_err = LDAP_OTHER;
+                       rs->sr_text = "internal error";
                }
                goto return_results;
        }
 
        /* delete from dn2id */
-       rc = bdb_dn2id_delete( be, ltid, pdn.bv_val, e );
-       if ( rc != 0 ) {
-               switch( rc ) {
+       rs->sr_err = bdb_dn2id_delete( op, lt2, eip, e );
+       if ( rs->sr_err != 0 ) {
+               Debug(LDAP_DEBUG_TRACE,
+                       "<=- " LDAP_XSTRING(bdb_delete) ": dn2id failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
+               switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        goto retry;
-               default:
-                       rc = LDAP_OTHER;
                }
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "<=- bdb_delete: dn2id failed %s (%d)\n", db_strerror(rc), rc, 0 );
-#else
-               Debug(LDAP_DEBUG_ARGS,
-                       "<=- bdb_delete: dn2id failed: %s (%d)\n",
-                       db_strerror(rc), rc, 0 );
-#endif
-               text = "DN index delete failed";
+               rs->sr_text = "DN index delete failed";
+               rs->sr_err = LDAP_OTHER;
                goto return_results;
        }
 
-       /* delete from id2entry */
-       rc = bdb_id2entry_delete( be, ltid, e );
-       if ( rc != 0 ) {
-               switch( rc ) {
+       /* delete indices for old attributes */
+       rs->sr_err = bdb_index_entry_del( op, lt2, e );
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+               Debug(LDAP_DEBUG_TRACE,
+                       "<=- " LDAP_XSTRING(bdb_delete) ": index failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
+               switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        goto retry;
-               default:
-                       rc = LDAP_OTHER;
                }
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "<=- bdb_delete: id2entry failed: %s (%d)\n", 
-                       db_strerror(rc), rc, 0 );
-#else
-               Debug(LDAP_DEBUG_ARGS,
-                       "<=- bdb_delete: id2entry failed: %s (%d)\n",
-                       db_strerror(rc), rc, 0 );
-#endif
-               text = "entry delete failed";
+               rs->sr_text = "entry index delete failed";
+               rs->sr_err = LDAP_OTHER;
                goto return_results;
        }
 
-       /* delete indices for old attributes */
-       rc = bdb_index_entry_del( be, ltid, e, e->e_attrs );
-       if ( rc != LDAP_SUCCESS ) {
-               switch( rc ) {
+       /* fixup delete CSN */
+       if ( !SLAP_SHADOW( op->o_bd )) {
+               struct berval vals[2];
+
+               assert( !BER_BVISNULL( &op->o_csn ) );
+               vals[0] = op->o_csn;
+               BER_BVZERO( &vals[1] );
+               rs->sr_err = bdb_index_values( op, lt2, slap_schema.si_ad_entryCSN,
+                       vals, 0, SLAP_INDEX_ADD_OP );
+       if ( rs->sr_err != LDAP_SUCCESS ) {
+                       switch( rs->sr_err ) {
+                       case DB_LOCK_DEADLOCK:
+                       case DB_LOCK_NOTGRANTED:
+                               goto retry;
+                       }
+                       rs->sr_text = "entryCSN index update failed";
+                       rs->sr_err = LDAP_OTHER;
+                       goto return_results;
+               }
+       }
+
+       /* delete from id2entry */
+       rs->sr_err = bdb_id2entry_delete( op->o_bd, lt2, e );
+       if ( rs->sr_err != 0 ) {
+               Debug( LDAP_DEBUG_TRACE,
+                       "<=- " LDAP_XSTRING(bdb_delete) ": id2entry failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
+               switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        goto retry;
-               default:
-                       rc = LDAP_OTHER;
                }
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "<=- bdb_delete: entry index delete failed!\n", 0, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_ANY, "entry index delete failed!\n",
-                       0, 0, 0 );
-#endif
-               text = "entry index delete failed";
+               rs->sr_text = "entry delete failed";
+               rs->sr_err = LDAP_OTHER;
+               goto return_results;
+       }
+
+       if ( pdn.bv_len != 0 ) {
+               parent_is_glue = is_entry_glue(p);
+               rs->sr_err = bdb_cache_children( op, lt2, p );
+               if ( rs->sr_err != DB_NOTFOUND ) {
+                       switch( rs->sr_err ) {
+                       case DB_LOCK_DEADLOCK:
+                       case DB_LOCK_NOTGRANTED:
+                               goto retry;
+                       case 0:
+                               break;
+                       default:
+                               Debug(LDAP_DEBUG_ARGS,
+                                       "<=- " LDAP_XSTRING(bdb_delete)
+                                       ": has_children failed: %s (%d)\n",
+                                       db_strerror(rs->sr_err), rs->sr_err, 0 );
+                               rs->sr_err = LDAP_OTHER;
+                               rs->sr_text = "internal error";
+                               goto return_results;
+                       }
+                       parent_is_leaf = 1;
+               }
+               bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, p);
+               p = NULL;
+       }
+
+       if ( TXN_COMMIT( lt2, 0 ) != 0 ) {
+               rs->sr_err = LDAP_OTHER;
+               rs->sr_text = "txn_commit(2) failed";
                goto return_results;
        }
 
+       eid = e->e_id;
+
 #if 0  /* Do we want to reclaim deleted IDs? */
        ldap_pvt_thread_mutex_lock( &bdb->bi_lastid_mutex );
        if ( e->e_id == bdb->bi_lastid ) {
-               bdb_last_id( be, ltid );
+               bdb_last_id( op->o_bd, ltid );
        }
        ldap_pvt_thread_mutex_unlock( &bdb->bi_lastid_mutex );
 #endif
 
        if( op->o_noop ) {
-               if ( ( rc = TXN_ABORT( ltid ) ) != 0 ) {
-                       text = "txn_abort (no-op) failed";
+               if ( ( rs->sr_err = TXN_ABORT( ltid ) ) != 0 ) {
+                       rs->sr_text = "txn_abort (no-op) failed";
                } else {
-                       noop = 1;
-                       rc = LDAP_SUCCESS;
+                       rs->sr_err = LDAP_X_NO_OPERATION;
+                       ltid = NULL;
+                       goto return_results;
                }
        } else {
-               rc = TXN_COMMIT( ltid, 0 );
+               rc = bdb_cache_delete( &bdb->bi_cache, e, bdb->bi_dbenv,
+                       locker, &lock );
+               switch( rc ) {
+               case DB_LOCK_DEADLOCK:
+               case DB_LOCK_NOTGRANTED:
+                       goto retry;
+               }
+
+               rs->sr_err = TXN_COMMIT( ltid, 0 );
        }
        ltid = NULL;
        op->o_private = NULL;
 
-       if( rc != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_delete: txn_%s failed: %s (%d)\n",
-                       op->o_noop ? "abort (no-op)" : "commit", db_strerror(rc), rc );
-#else
+       if( rs->sr_err != 0 ) {
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_delete: txn_%s failed: %s (%d)\n",
+                       LDAP_XSTRING(bdb_delete) ": txn_%s failed: %s (%d)\n",
                        op->o_noop ? "abort (no-op)" : "commit",
-                       db_strerror(rc), rc );
-#endif
-               rc = LDAP_OTHER;
-               text = "commit failed";
+                       db_strerror(rs->sr_err), rs->sr_err );
+               rs->sr_err = LDAP_OTHER;
+               rs->sr_text = "commit failed";
 
-       } else {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, RESULTS, 
-                       "bdb_delete: deleted%s id=%08lx db=\"%s\"\n",
-                       op->o_noop ? " (no-op)" : "", e->e_id, e->e_dn );
-#else
-               Debug( LDAP_DEBUG_TRACE,
-                       "bdb_delete: deleted%s id=%08lx dn=\"%s\"\n",
-                       op->o_noop ? " (no-op)" : "",
-                       e->e_id, e->e_dn );
-#endif
-               rc = LDAP_SUCCESS;
-               text = NULL;
+               goto return_results;
        }
 
-return_results:
-       send_ldap_result( conn, op, rc, NULL, text, NULL, NULL );
+       Debug( LDAP_DEBUG_TRACE,
+               LDAP_XSTRING(bdb_delete) ": deleted%s id=%08lx dn=\"%s\"\n",
+               op->o_noop ? " (no-op)" : "",
+               eid, op->o_req_dn.bv_val );
+       rs->sr_err = LDAP_SUCCESS;
+       rs->sr_text = NULL;
+       if( num_ctrls ) rs->sr_ctrls = ctrls;
 
-       if(rc == LDAP_SUCCESS && bdb->bi_txn_cp ) {
-               ldap_pvt_thread_yield();
-               TXN_CHECKPOINT( bdb->bi_dbenv,
-                       bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
+return_results:
+       if ( rs->sr_err == LDAP_SUCCESS && parent_is_glue && parent_is_leaf ) {
+               op->o_delete_glue_parent = 1;
        }
 
-done:
+       if ( p )
+               bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, p);
+
        /* free entry */
        if( e != NULL ) {
-               bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
+               if ( rs->sr_err == LDAP_SUCCESS ) {
+                       /* Free the EntryInfo and the Entry */
+                       bdb_cache_delete_cleanup( &bdb->bi_cache, BEI(e) );
+               } else {
+                       bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
+               }
        }
 
        if( ltid != NULL ) {
                TXN_ABORT( ltid );
-               op->o_private = NULL;
+       }
+       op->o_private = NULL;
+
+       send_ldap_result( op, rs );
+       if ( !SLAP_SHADOW( op->o_bd ))
+               slap_graduate_commit_csn( op );
+
+       if( preread_ctrl != NULL ) {
+               slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
+               slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
        }
 
-       return ( ( rc == LDAP_SUCCESS ) ? noop : rc );
+       if( rs->sr_err == LDAP_SUCCESS && bdb->bi_txn_cp ) {
+               ldap_pvt_thread_yield();
+               TXN_CHECKPOINT( bdb->bi_dbenv,
+                       bdb->bi_txn_cp_kbyte, bdb->bi_txn_cp_min, 0 );
+       }
+       return rs->sr_err;
 }