]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/dn2id.c
plug leaks
[openldap] / servers / slapd / back-bdb / dn2id.c
index 3352278c061975a2a556e0ecebd15a0192e5d897..64231082728892978f1ab39b0e5dfe2c6651b834 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2000-2005 The OpenLDAP Foundation.
+ * Copyright 2000-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -178,7 +178,7 @@ bdb_dn2id_delete(
 #endif
        {
                buf[0] = DN_SUBTREE_PREFIX;
-               rc = db->del( db, txn, &key, 0 );
+               rc = bdb_idl_delete_key( op->o_bd, db, txn, &key, e->e_id );
                if( rc != 0 ) {
                        Debug( LDAP_DEBUG_ANY,
                        "=> bdb_dn2id_delete: subtree (%s) delete failed: %d\n",
@@ -381,10 +381,7 @@ bdb_dn2idl(
 }
 
 #else  /* BDB_HIER */
-/* Experimental management routines for a hierarchically structured database.
- *
- * Unsupported! Use at your own risk!
- * -- Howard Chu, Symas Corp. 2003.
+/* Management routines for a hierarchically structured database.
  *
  * Instead of a ldbm-style dn2id database, we use a hierarchical one. Each
  * entry in this database is a struct diskNode, keyed by entryID and with
@@ -402,9 +399,9 @@ bdb_dn2idl(
  */
 typedef struct diskNode {
        unsigned char nrdnlen[2];
-       unsigned char nrdn[1];
-       unsigned char rdn[1];
-       unsigned char entryID[sizeof(ID)];
+       char nrdn[1];
+       char rdn[1];                        /* variable placement */
+       unsigned char entryID[sizeof(ID)];  /* variable placement */
 } diskNode;
 
 /* This function constructs a full DN for a given entry.
@@ -505,18 +502,13 @@ hdb_dn2id_add(
        key.flags = DB_DBT_USERMEM;
        BDB_ID2DISK( eip->bei_id, &nid );
 
-       /* Delete parent's IDL cache entry */
-       if ( bdb->bi_idl_cache_size ) {
-               key.data = &eip->bei_id;
-               bdb_idl_cache_del( bdb, db, &key );
-       }
        key.data = &nid;
 
        /* Need to make dummy root node once. Subsequent attempts
         * will fail harmlessly.
         */
        if ( eip->bei_id == 0 ) {
-               diskNode dummy = {0};
+               diskNode dummy = {{0, 0}, "", "", ""};
                data.data = &dummy;
                data.size = sizeof(diskNode);
                data.flags = DB_DBT_USERMEM;
@@ -538,6 +530,21 @@ hdb_dn2id_add(
                rc = db->put( db, txn, &key, &data, DB_NODUPDATA );
        }
 
+       /* Update all parents' IDL cache entries */
+       if ( rc == 0 && bdb->bi_idl_cache_size ) {
+               ID tmp[2];
+               char *ptr = ((char *)&tmp[1])-1;
+               key.data = ptr;
+               key.size = sizeof(ID)+1;
+               tmp[1] = eip->bei_id;
+               *ptr = DN_ONE_PREFIX;
+               bdb_idl_cache_add_id( bdb, db, &key, e->e_id );
+               *ptr = DN_SUBTREE_PREFIX;
+               for (; eip && eip->bei_parent->bei_id; eip = eip->bei_parent) {
+                       tmp[1] = eip->bei_id;
+                       bdb_idl_cache_add_id( bdb, db, &key, e->e_id );
+               }
+       }
        op->o_tmpfree( d, op->o_tmpmemctx );
 
        return rc;
@@ -571,15 +578,6 @@ hdb_dn2id_delete(
        data.dlen = data.size;
        data.flags = DB_DBT_USERMEM | DB_DBT_PARTIAL;
 
-       /* Delete IDL cache entries */
-       if ( bdb->bi_idl_cache_size ) {
-               /* Ours */
-               key.data = &e->e_id;
-               bdb_idl_cache_del( bdb, db, &key );
-               /* Parent's */
-               key.data = &eip->bei_id;
-               bdb_idl_cache_del( bdb, db, &key );
-       }
        key.data = &nid;
        rc = db->cursor( db, txn, &cursor, bdb->bi_db_opflags );
        if ( rc ) return rc;
@@ -615,6 +613,21 @@ hdb_dn2id_delete(
        cursor->c_close( cursor );
        op->o_tmpfree( d, op->o_tmpmemctx );
 
+       /* Delete IDL cache entries */
+       if ( rc == 0 && bdb->bi_idl_cache_size ) {
+               ID tmp[2];
+               char *ptr = ((char *)&tmp[1])-1;
+               key.data = ptr;
+               key.size = sizeof(ID)+1;
+               tmp[1] = eip->bei_id;
+               *ptr = DN_ONE_PREFIX;
+               bdb_idl_cache_del_id( bdb, db, &key, e->e_id );
+               *ptr = DN_SUBTREE_PREFIX;
+               for (; eip && eip->bei_parent->bei_id; eip = eip->bei_parent) {
+                       tmp[1] = eip->bei_id;
+                       bdb_idl_cache_del_id( bdb, db, &key, e->e_id );
+               }
+       }
        return rc;
 }
 
@@ -634,7 +647,7 @@ hdb_dn2id(
        diskNode *d;
        char    *ptr;
        unsigned char dlen[2];
-       ID idp;
+       ID idp, parentID;
 
        nrlen = dn_rdnlen( op->o_bd, in );
        if (!nrlen) nrlen = in->bv_len;
@@ -644,7 +657,8 @@ hdb_dn2id(
        key.data = &idp;
        key.ulen = sizeof(ID);
        key.flags = DB_DBT_USERMEM;
-       BDB_ID2DISK( ei->bei_parent->bei_id, &idp );
+       parentID = ( ei->bei_parent != NULL ) ? ei->bei_parent->bei_id : 0;
+       BDB_ID2DISK( parentID, &idp );
 
        DBTzero(&data);
        data.size = sizeof(diskNode) + nrlen - sizeof(ID) - 1;
@@ -675,7 +689,7 @@ hdb_dn2id(
                ei->bei_rdn.bv_len = data.size - sizeof(diskNode) - nrlen;
                ptr = d->nrdn + nrlen + 1;
                ber_str2bv( ptr, ei->bei_rdn.bv_len, 1, &ei->bei_rdn );
-               if ( !ei->bei_parent->bei_dkids ) {
+               if ( ei->bei_parent != NULL && !ei->bei_parent->bei_dkids ) {
                        db_recno_t dkids;
                        /* How many children does the parent have? */
                        /* FIXME: do we need to lock the parent
@@ -695,6 +709,7 @@ int
 hdb_dn2id_parent(
        Operation *op,
        DB_TXN *txn,
+       u_int32_t       locker,
        EntryInfo *ei,
        ID *idp )
 {
@@ -719,6 +734,9 @@ hdb_dn2id_parent(
 
        rc = db->cursor( db, txn, &cursor, bdb->bi_db_opflags );
        if ( rc ) return rc;
+       if ( !txn && locker ) {
+               cursor->locker = locker;
+       }
 
        data.ulen = sizeof(diskNode) + (SLAP_LDAPDN_MAXLEN * 2);
        d = op->o_tmpalloc( data.ulen, op->o_tmpmemctx );
@@ -811,21 +829,22 @@ hdb_dn2id_children(
 
 struct dn2id_cookie {
        struct bdb_info *bdb;
-       DB *db;
-       int prefix;
-       int rc;
+       Operation *op;
        EntryInfo *ei;
-       ID id;
-       ID nid;
-       ID dbuf;
        ID *ids;
-       void *ptr;
-       ID tmp[BDB_IDL_UM_SIZE];
+       ID *tmp;
        ID *buf;
+       DB *db;
+       DBC *dbc;
        DBT key;
        DBT data;
-       DBC *dbc;
-       Operation *op;
+       ID dbuf;
+       ID id;
+       ID nid;
+       int rc;
+       int depth;
+       char need_sort;
+       char prefix;
 };
 
 static int
@@ -847,23 +866,31 @@ hdb_dn2idl_internal(
 {
        BDB_IDL_ZERO( cx->tmp );
 
-       if ( !cx->ei ) {
-               cx->ei = bdb_cache_find_info( cx->bdb, cx->id );
-               if ( !cx->ei ) {
-                       cx->rc = DB_NOTFOUND;
-                       goto saveit;
-               }
-       }
-
        if ( cx->bdb->bi_idl_cache_size ) {
-               cx->key.data = &cx->id;
-               cx->rc = bdb_idl_cache_get(cx->bdb, cx->db, &cx->key, cx->tmp);
-               if ( cx->rc == DB_NOTFOUND ) {
-                       return cx->rc;
+               char *ptr = ((char *)&cx->id)-1;
+
+               cx->key.data = ptr;
+               cx->key.size = sizeof(ID)+1;
+               if ( cx->prefix == DN_SUBTREE_PREFIX ) {
+                       ID *ids = cx->depth ? cx->tmp : cx->ids;
+                       *ptr = cx->prefix;
+                       cx->rc = bdb_idl_cache_get(cx->bdb, cx->db, &cx->key, ids);
+                       if ( cx->rc == LDAP_SUCCESS ) {
+                               if ( cx->depth ) {
+                                       bdb_idl_append( cx->ids, cx->tmp );
+                                       cx->need_sort = 1;
+                               }
+                               return cx->rc;
+                       }
                }
+               *ptr = DN_ONE_PREFIX;
+               cx->rc = bdb_idl_cache_get(cx->bdb, cx->db, &cx->key, cx->tmp);
                if ( cx->rc == LDAP_SUCCESS ) {
                        goto gotit;
                }
+               if ( cx->rc == DB_NOTFOUND ) {
+                       return cx->rc;
+               }
        }
 
        bdb_cache_entryinfo_lock( cx->ei );
@@ -876,11 +903,24 @@ hdb_dn2idl_internal(
                db_recno_t dkids = cx->ei->bei_dkids;
                ei.bei_parent = cx->ei;
 
+               /* Only one thread should load the cache */
+               while ( cx->ei->bei_state & CACHE_ENTRY_ONELEVEL ) {
+                       bdb_cache_entryinfo_unlock( cx->ei );
+                       ldap_pvt_thread_yield();
+                       bdb_cache_entryinfo_lock( cx->ei );
+                       if ( cx->ei->bei_ckids+1 == cx->ei->bei_dkids ) {
+                               goto synced;
+                       }
+               }
+
+               cx->ei->bei_state |= CACHE_ENTRY_ONELEVEL;
+
                bdb_cache_entryinfo_unlock( cx->ei );
 
                cx->rc = cx->db->cursor( cx->db, NULL, &cx->dbc,
                        cx->bdb->bi_db_opflags );
-               if ( cx->rc ) return cx->rc;
+               if ( cx->rc )
+                       goto done_one;
 
                cx->data.data = &cx->dbuf;
                cx->data.ulen = sizeof(ID);
@@ -889,11 +929,11 @@ hdb_dn2idl_internal(
 
                /* The first item holds the parent ID. Ignore it. */
                cx->key.data = &cx->nid;
+               cx->key.size = sizeof(ID);
                cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data, DB_SET );
                if ( cx->rc ) {
                        cx->dbc->c_close( cx->dbc );
-                       if ( cx->rc == DB_NOTFOUND ) goto saveit;
-                       return cx->rc;
+                       goto done_one;
                }
 
                /* If the on-disk count is zero we've never checked it.
@@ -908,43 +948,55 @@ hdb_dn2idl_internal(
                cx->data.ulen = BDB_IDL_UM_SIZE * sizeof(ID);
                cx->data.flags = DB_DBT_USERMEM;
 
-               /* Fetch the rest of the IDs in a loop... */
-               while ( (cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data,
-                       DB_MULTIPLE | DB_NEXT_DUP )) == 0 ) {
-                       u_int8_t *j;
-                       size_t len;
-                       DB_MULTIPLE_INIT( cx->ptr, &cx->data );
-                       while (cx->ptr) {
-                               DB_MULTIPLE_NEXT( cx->ptr, &cx->data, j, len );
-                               if (j) {
-                                       EntryInfo *ei2;
-                                       diskNode *d = (diskNode *)j;
-                                       short nrlen;
-
-                                       BDB_DISK2ID( j + len - sizeof(ID), &ei.bei_id );
-                                       nrlen = ((d->nrdnlen[0] ^ 0x80) << 8) | d->nrdnlen[1];
-                                       ei.bei_nrdn.bv_len = nrlen;
-                                       /* nrdn/rdn are set in-place.
-                                        * hdb_cache_load will copy them as needed
-                                        */
-                                       ei.bei_nrdn.bv_val = d->nrdn;
-                                       ei.bei_rdn.bv_len = len - sizeof(diskNode)
-                                               - ei.bei_nrdn.bv_len;
-                                       ei.bei_rdn.bv_val = d->nrdn + ei.bei_nrdn.bv_len + 1;
-                                       bdb_idl_append_one( cx->tmp, ei.bei_id );
-                                       hdb_cache_load( cx->bdb, &ei, &ei2 );
+               if ( dkids > 1 ) {
+                       /* Fetch the rest of the IDs in a loop... */
+                       while ( (cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data,
+                               DB_MULTIPLE | DB_NEXT_DUP )) == 0 ) {
+                               u_int8_t *j;
+                               size_t len;
+                               void *ptr;
+                               DB_MULTIPLE_INIT( ptr, &cx->data );
+                               while (ptr) {
+                                       DB_MULTIPLE_NEXT( ptr, &cx->data, j, len );
+                                       if (j) {
+                                               EntryInfo *ei2;
+                                               diskNode *d = (diskNode *)j;
+                                               short nrlen;
+
+                                               BDB_DISK2ID( j + len - sizeof(ID), &ei.bei_id );
+                                               nrlen = ((d->nrdnlen[0] ^ 0x80) << 8) | d->nrdnlen[1];
+                                               ei.bei_nrdn.bv_len = nrlen;
+                                               /* nrdn/rdn are set in-place.
+                                                * hdb_cache_load will copy them as needed
+                                                */
+                                               ei.bei_nrdn.bv_val = d->nrdn;
+                                               ei.bei_rdn.bv_len = len - sizeof(diskNode)
+                                                       - ei.bei_nrdn.bv_len;
+                                               ei.bei_rdn.bv_val = d->nrdn + ei.bei_nrdn.bv_len + 1;
+                                               bdb_idl_append_one( cx->tmp, ei.bei_id );
+                                               hdb_cache_load( cx->bdb, &ei, &ei2 );
+                                       }
                                }
                        }
                }
+
                cx->rc = cx->dbc->c_close( cx->dbc );
+done_one:
+               bdb_cache_entryinfo_lock( cx->ei );
+               cx->ei->bei_state ^= CACHE_ENTRY_ONELEVEL;
+               bdb_cache_entryinfo_unlock( cx->ei );
+               if ( cx->rc )
+                       return cx->rc;
+
        } else {
                /* The in-memory cache is in sync with the on-disk data.
                 * do we have any kids?
                 */
+synced:
                cx->rc = 0;
                if ( cx->ei->bei_ckids > 0 ) {
-                       /* Walk the kids tree; order is irrelevant since bdb_idl_insert
-                        * will insert in sorted order.
+                       /* Walk the kids tree; order is irrelevant since bdb_idl_sort
+                        * will sort it later.
                         */
                        avl_apply( cx->ei->bei_kids, apply_func,
                                cx->tmp, -1, AVL_POSTORDER );
@@ -952,16 +1004,21 @@ hdb_dn2idl_internal(
                bdb_cache_entryinfo_unlock( cx->ei );
        }
 
-saveit:
-       if ( cx->bdb->bi_idl_cache_max_size ) {
-               cx->key.data = &cx->id;
+       if ( !BDB_IDL_IS_RANGE( cx->tmp ) && cx->tmp[0] > 3 )
+               bdb_idl_sort( cx->tmp, cx->buf );
+       if ( cx->bdb->bi_idl_cache_max_size && !BDB_IDL_IS_ZERO( cx->tmp )) {
+               char *ptr = ((char *)&cx->id)-1;
+               cx->key.data = ptr;
+               cx->key.size = sizeof(ID)+1;
+               *ptr = DN_ONE_PREFIX;
                bdb_idl_cache_put( cx->bdb, cx->db, &cx->key, cx->tmp, cx->rc );
        }
-       ;
+
 gotit:
        if ( !BDB_IDL_IS_ZERO( cx->tmp )) {
                if ( cx->prefix == DN_SUBTREE_PREFIX ) {
                        bdb_idl_append( cx->ids, cx->tmp );
+                       cx->need_sort = 1;
                        if ( !(cx->ei->bei_state & CACHE_ENTRY_NO_GRANDKIDS)) {
                                ID *save, idcurs;
                                EntryInfo *ei = cx->ei;
@@ -971,15 +1028,21 @@ gotit:
                                BDB_IDL_CPY( save, cx->tmp );
 
                                idcurs = 0;
+                               cx->depth++;
                                for ( cx->id = bdb_idl_first( save, &idcurs );
                                        cx->id != NOID;
                                        cx->id = bdb_idl_next( save, &idcurs )) {
+                                       cx->ei = bdb_cache_find_info( cx->bdb, cx->id );
+                                       if ( !cx->ei ||
+                                               ( cx->ei->bei_state & CACHE_ENTRY_NO_KIDS ))
+                                               continue;
+
                                        BDB_ID2DISK( cx->id, &cx->nid );
-                                       cx->ei = NULL;
                                        hdb_dn2idl_internal( cx );
                                        if ( !BDB_IDL_IS_ZERO( cx->tmp ))
                                                nokids = 0;
                                }
+                               cx->depth--;
                                cx->op->o_tmpfree( save, cx->op->o_tmpmemctx );
                                if ( nokids ) ei->bei_state |= CACHE_ENTRY_NO_GRANDKIDS;
                        }
@@ -1024,13 +1087,20 @@ hdb_dn2idl(
        cx.prefix = (op->ors_scope == LDAP_SCOPE_ONELEVEL) ?
                DN_ONE_PREFIX : DN_SUBTREE_PREFIX;
        cx.ids = ids;
-       cx.buf = stack;
+       cx.tmp = stack;
+       cx.buf = stack + BDB_IDL_UM_SIZE;
        cx.op = op;
+       cx.need_sort = 0;
+       cx.depth = 0;
 
-       BDB_IDL_ZERO( ids );
        if ( cx.prefix == DN_SUBTREE_PREFIX ) {
-               bdb_idl_insert( ids, cx.id );
+               ids[0] = 1;
+               ids[1] = cx.id;
+       } else {
+               BDB_IDL_ZERO( ids );
        }
+       if ( cx.ei->bei_state & CACHE_ENTRY_NO_KIDS )
+               return LDAP_SUCCESS;
 
        DBTzero(&cx.key);
        cx.key.ulen = sizeof(ID);
@@ -1040,8 +1110,19 @@ hdb_dn2idl(
        DBTzero(&cx.data);
 
        hdb_dn2idl_internal(&cx);
-       if ( !BDB_IDL_IS_ZERO( ids ) && !BDB_IDL_IS_RANGE( ids ))
-               bdb_idl_sort( ids );
+       if ( cx.need_sort ) {
+               char *ptr = ((char *)&cx.id)-1;
+               if ( !BDB_IDL_IS_RANGE( cx.ids ) && cx.ids[0] > 3 ) 
+                       bdb_idl_sort( cx.ids, cx.tmp );
+               cx.key.data = ptr;
+               cx.key.size = sizeof(ID)+1;
+               *ptr = cx.prefix;
+               cx.id = e->e_id;
+               bdb_idl_cache_put( cx.bdb, cx.db, &cx.key, cx.ids, cx.rc );
+       }
+
+       if ( cx.rc == DB_NOTFOUND )
+               cx.rc = LDAP_SUCCESS;
 
        return cx.rc;
 }