]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/dn2id.c
More for 2.2beta
[openldap] / servers / slapd / back-bdb / dn2id.c
index 78a14c26b788a99857d5f7575d4ff11d8af4fdbc..c3cef02e80d30311594fbb1952be28f90e7887e1 100644 (file)
 #ifndef BDB_HIER
 int
 bdb_dn2id_add(
-       BackendDB       *be,
+       Operation *op,
        DB_TXN *txn,
        EntryInfo *eip,
-       Entry           *e,
-       void *ctx )
+       Entry           *e )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
        int             rc;
        DBT             key, data;
@@ -43,7 +42,7 @@ bdb_dn2id_add(
        key.size = e->e_nname.bv_len + 2;
        key.ulen = key.size;
        key.flags = DB_DBT_USERMEM;
-       buf = sl_malloc( key.size, ctx );
+       buf = op->o_tmpalloc( key.size, op->o_tmpmemctx );
        key.data = buf;
        buf[0] = DN_BASE_PREFIX;
        ptr.bv_val = buf + 1;
@@ -69,7 +68,7 @@ bdb_dn2id_add(
        }
 
 #ifndef BDB_MULTIPLE_SUFFIXES
-       if( !be_issuffix( be, &ptr )) {
+       if( !be_issuffix( op->o_bd, &ptr )) {
 #endif
                buf[0] = DN_SUBTREE_PREFIX;
                rc = db->put( db, txn, &key, &data, DB_NOOVERWRITE );
@@ -87,7 +86,7 @@ bdb_dn2id_add(
                }
                
 #ifdef BDB_MULTIPLE_SUFFIXES
-       if( !be_issuffix( be, &ptr )) {
+       if( !be_issuffix( op->o_bd, &ptr )) {
 #endif
                dnParent( &ptr, &pdn );
        
@@ -97,7 +96,7 @@ bdb_dn2id_add(
                key.data = pdn.bv_val-1;
                ptr = pdn;
 
-               rc = bdb_idl_insert_key( be, db, txn, &key, e->e_id );
+               rc = bdb_idl_insert_key( op->o_bd, db, txn, &key, e->e_id );
 
                if( rc != 0 ) {
 #ifdef NEW_LOGGING
@@ -114,13 +113,13 @@ bdb_dn2id_add(
 #ifndef BDB_MULTIPLE_SUFFIXES
        }
 
-       while( !be_issuffix( be, &ptr )) {
+       while( !be_issuffix( op->o_bd, &ptr )) {
 #else
        for (;;) {
 #endif
                ptr.bv_val[-1] = DN_SUBTREE_PREFIX;
 
-               rc = bdb_idl_insert_key( be, db, txn, &key, e->e_id );
+               rc = bdb_idl_insert_key( op->o_bd, db, txn, &key, e->e_id );
 
                if( rc != 0 ) {
 #ifdef NEW_LOGGING
@@ -135,7 +134,7 @@ bdb_dn2id_add(
                        break;
                }
 #ifdef BDB_MULTIPLE_SUFFIXES
-               if( be_issuffix( be, &ptr )) break;
+               if( be_issuffix( op->o_bd, &ptr )) break;
 #endif
                dnParent( &ptr, &pdn );
 
@@ -149,7 +148,7 @@ bdb_dn2id_add(
 #endif
 
 done:
-       sl_free( buf, ctx );
+       op->o_tmpfree( buf, op->o_tmpmemctx );
 #ifdef NEW_LOGGING
        LDAP_LOG ( INDEX, RESULTS, "<= bdb_dn2id_add: %d\n", rc, 0, 0 );
 #else
@@ -160,13 +159,12 @@ done:
 
 int
 bdb_dn2id_delete(
-       BackendDB       *be,
+       Operation *op,
        DB_TXN *txn,
        EntryInfo       *eip,
-       Entry           *e,
-       void *ctx )
+       Entry           *e )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
        int             rc;
        DBT             key;
@@ -183,7 +181,7 @@ bdb_dn2id_delete(
 
        DBTzero( &key );
        key.size = e->e_nname.bv_len + 2;
-       buf = sl_malloc( key.size, ctx );
+       buf = op->o_tmpalloc( key.size, op->o_tmpmemctx );
        key.data = buf;
        key.flags = DB_DBT_USERMEM;
        buf[0] = DN_BASE_PREFIX;
@@ -207,7 +205,7 @@ bdb_dn2id_delete(
        }
 
 #ifndef BDB_MULTIPLE_SUFFIXES
-       if( !be_issuffix( be, &ptr )) {
+       if( !be_issuffix( op->o_bd, &ptr )) {
 #endif
                buf[0] = DN_SUBTREE_PREFIX;
                rc = db->del( db, txn, &key, 0 );
@@ -225,7 +223,7 @@ bdb_dn2id_delete(
                }
 
 #ifdef BDB_MULTIPLE_SUFFIXES
-       if( !be_issuffix( be, &ptr )) {
+       if( !be_issuffix( op->o_bd, &ptr )) {
 #endif
                dnParent( &ptr, &pdn );
 
@@ -235,7 +233,7 @@ bdb_dn2id_delete(
                key.data = pdn.bv_val - 1;
                ptr = pdn;
 
-               rc = bdb_idl_delete_key( be, db, txn, &key, e->e_id );
+               rc = bdb_idl_delete_key( op->o_bd, db, txn, &key, e->e_id );
 
                if( rc != 0 ) {
 #ifdef NEW_LOGGING
@@ -252,13 +250,13 @@ bdb_dn2id_delete(
 #ifndef BDB_MULTIPLE_SUFFIXES
        }
 
-       while( !be_issuffix( be, &ptr )) {
+       while( !be_issuffix( op->o_bd, &ptr )) {
 #else
        for (;;) {
 #endif
                ptr.bv_val[-1] = DN_SUBTREE_PREFIX;
 
-               rc = bdb_idl_delete_key( be, db, txn, &key, e->e_id );
+               rc = bdb_idl_delete_key( op->o_bd, db, txn, &key, e->e_id );
                if( rc != 0 ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG ( INDEX, ERR, 
@@ -272,7 +270,7 @@ bdb_dn2id_delete(
                        goto done;
                }
 #ifdef BDB_MULTIPLE_SUFFIXES
-               if( be_issuffix( be, &ptr )) break;
+               if( be_issuffix( op->o_bd, &ptr )) break;
 #endif
                dnParent( &ptr, &pdn );
 
@@ -286,7 +284,7 @@ bdb_dn2id_delete(
 #endif
 
 done:
-       sl_free( buf, ctx );
+       op->o_tmpfree( buf, op->o_tmpmemctx );
 #ifdef NEW_LOGGING
        LDAP_LOG ( INDEX, RESULTS, "<= bdb_dn2id_delete %d\n", rc, 0, 0 );
 #else
@@ -297,15 +295,14 @@ done:
 
 int
 bdb_dn2id(
-       BackendDB       *be,
+       Operation *op,
        DB_TXN *txn,
        struct berval   *dn,
-       EntryInfo *ei,
-       void *ctx )
+       EntryInfo *ei )
 {
        int             rc;
        DBT             key, data;
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
 
 #ifdef NEW_LOGGING
@@ -315,7 +312,7 @@ bdb_dn2id(
 #endif
        DBTzero( &key );
        key.size = dn->bv_len + 2;
-       key.data = sl_malloc( key.size, ctx );
+       key.data = op->o_tmpalloc( key.size, op->o_tmpmemctx );
        ((char *)key.data)[0] = DN_BASE_PREFIX;
        AC_MEMCPY( &((char *)key.data)[1], dn->bv_val, key.size - 1 );
 
@@ -346,7 +343,7 @@ bdb_dn2id(
 #endif
        }
 
-       sl_free( key.data, ctx );
+       op->o_tmpfree( key.data, op->o_tmpmemctx );
        return rc;
 }
 
@@ -371,7 +368,7 @@ bdb_dn2id_children(
 #endif
        DBTzero( &key );
        key.size = e->e_nname.bv_len + 2;
-       key.data = sl_malloc( key.size, op->o_tmpmemctx );
+       key.data = op->o_tmpalloc( key.size, op->o_tmpmemctx );
        ((char *)key.data)[0] = DN_ONE_PREFIX;
        AC_MEMCPY( &((char *)key.data)[1], e->e_nname.bv_val, key.size - 1 );
 
@@ -379,7 +376,7 @@ bdb_dn2id_children(
        if ( bdb->bi_idl_cache_size ) {
                rc = bdb_idl_cache_get( bdb, db, &key, NULL );
                if ( rc != LDAP_NO_SUCH_OBJECT ) {
-                       sl_free( key.data, op->o_tmpmemctx );
+                       op->o_tmpfree( key.data, op->o_tmpmemctx );
                        return rc;
                }
        }
@@ -393,7 +390,7 @@ bdb_dn2id_children(
        data.dlen = sizeof(id);
 
        rc = db->get( db, txn, &key, &data, bdb->bi_db_opflags );
-       sl_free( key.data, op->o_tmpmemctx );
+       op->o_tmpfree( key.data, op->o_tmpmemctx );
 
 #ifdef NEW_LOGGING
        LDAP_LOG ( INDEX, DETAIL1, 
@@ -412,27 +409,27 @@ bdb_dn2id_children(
 
 int
 bdb_dn2idl(
-       BackendDB       *be,
-       struct berval   *dn,
-       int prefix,
+       Operation *op,
+       Entry *e,
        ID *ids,
-       ID *stack,
-       void *ctx )
+       ID *stack )
 {
        int             rc;
        DBT             key;
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
+       int prefix = op->ors_scope == LDAP_SCOPE_SUBTREE ? DN_SUBTREE_PREFIX :
+                       DN_ONE_PREFIX;
 
 #ifdef NEW_LOGGING
        LDAP_LOG ( INDEX, ARGS, 
-               "=> bdb_dn2ididl( \"%s\" )\n", dn->bv_val, 0, 0 );
+               "=> bdb_dn2ididl( \"%s\" )\n", e->e_nname.bv_val, 0, 0 );
 #else
-       Debug( LDAP_DEBUG_TRACE, "=> bdb_dn2idl( \"%s\" )\n", dn->bv_val, 0, 0 );
+       Debug( LDAP_DEBUG_TRACE, "=> bdb_dn2idl( \"%s\" )\n", e->e_nname.bv_val, 0, 0 );
 #endif
 
 #ifndef        BDB_MULTIPLE_SUFFIXES
-       if (prefix == DN_SUBTREE_PREFIX && be_issuffix(be, dn))
+       if (prefix == DN_SUBTREE_PREFIX && BEI(e)->bei_parent->bei_id == 0 )
        {
                BDB_IDL_ALL(bdb, ids);
                return 0;
@@ -440,14 +437,14 @@ bdb_dn2idl(
 #endif
 
        DBTzero( &key );
-       key.size = dn->bv_len + 2;
+       key.size = e->e_nname.bv_len + 2;
        key.ulen = key.size;
        key.flags = DB_DBT_USERMEM;
-       key.data = sl_malloc( key.size, ctx );
+       key.data = op->o_tmpalloc( key.size, op->o_tmpmemctx );
        ((char *)key.data)[0] = prefix;
-       AC_MEMCPY( &((char *)key.data)[1], dn->bv_val, key.size - 1 );
+       AC_MEMCPY( &((char *)key.data)[1], e->e_nname.bv_val, key.size - 1 );
 
-       rc = bdb_idl_fetch_key( be, db, NULL, &key, ids );
+       rc = bdb_idl_fetch_key( op->o_bd, db, NULL, &key, ids );
 
        if( rc != 0 ) {
 #ifdef NEW_LOGGING
@@ -473,7 +470,7 @@ bdb_dn2idl(
 #endif
        }
 
-       sl_free( key.data, ctx );
+       op->o_tmpfree( key.data, op->o_tmpmemctx );
        return rc;
 }
 #else  /* BDB_HIER */
@@ -506,7 +503,7 @@ typedef struct diskNode {
  * Sorts based on normalized RDN, in length order.
  */
 int
-bdb_dup_compare(
+hdb_dup_compare(
        DB *db, 
        const DBT *usrkey,
        const DBT *curkey
@@ -531,7 +528,7 @@ bdb_dup_compare(
 
 /* This function constructs a full DN for a given entry.
  */
-int bdb_fix_dn(
+int hdb_fix_dn(
        Entry *e,
        int checkit
 )
@@ -540,7 +537,8 @@ int bdb_fix_dn(
        int rlen = 0, nrlen = 0;
        char *ptr, *nptr;
        int max = 0;
-       
+
+       /* count length of all DN components */
        for ( ei = BEI(e); ei && ei->bei_id; ei=ei->bei_parent ) {
                rlen += ei->bei_rdn.bv_len + 1;
                nrlen += ei->bei_nrdn.bv_len + 1;
@@ -558,12 +556,13 @@ int bdb_fix_dn(
                }
                /* checkit == 2. do the fix. */
                free( e->e_name.bv_val );
+               free( e->e_nname.bv_val );
        }
 
        e->e_name.bv_len = rlen - 1;
        e->e_nname.bv_len = nrlen - 1;
-       e->e_name.bv_val = ch_malloc(rlen + nrlen);
-       e->e_nname.bv_val = e->e_name.bv_val + rlen;
+       e->e_name.bv_val = ch_malloc(rlen);
+       e->e_nname.bv_val = ch_malloc(nrlen);
        ptr = e->e_name.bv_val;
        nptr = e->e_nname.bv_val;
        for ( ei = BEI(e); ei && ei->bei_id; ei=ei->bei_parent ) {
@@ -586,29 +585,28 @@ int bdb_fix_dn(
  * child's entryID containing the parent's entryID.
  */
 int
-bdb_dn2id_add(
-       BackendDB       *be,
+hdb_dn2id_add(
+       Operation       *op,
        DB_TXN *txn,
        EntryInfo       *eip,
-       Entry           *e,
-       void *ctx )
+       Entry           *e )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
        DBT             key, data;
        int             rc, rlen, nrlen;
        diskNode *d;
        char *ptr;
 
-       nrlen = dn_rdnlen( be, &e->e_nname );
+       nrlen = dn_rdnlen( op->o_bd, &e->e_nname );
        if (nrlen) {
-               rlen = dn_rdnlen( be, &e->e_name );
+               rlen = dn_rdnlen( op->o_bd, &e->e_name );
        } else {
                nrlen = e->e_nname.bv_len;
                rlen = e->e_name.bv_len;
        }
 
-       d = sl_malloc(sizeof(diskNode) + rlen + nrlen, ctx);
+       d = op->o_tmpalloc(sizeof(diskNode) + rlen + nrlen, op->o_tmpmemctx);
        d->entryID = e->e_id;
        d->nrdnlen = nrlen;
        ptr = lutil_strncopy( d->nrdn, e->e_nname.bv_val, nrlen );
@@ -641,20 +639,19 @@ bdb_dn2id_add(
                rc = db->put( db, txn, &key, &data, DB_NODUPDATA );
        }
 
-       sl_free( d, ctx );
+       op->o_tmpfree( d, op->o_tmpmemctx );
 
        return rc;
 }
 
 int
-bdb_dn2id_delete(
-       BackendDB       *be,
+hdb_dn2id_delete(
+       Operation       *op,
        DB_TXN *txn,
        EntryInfo       *eip,
-       Entry   *e,
-       void    *ctx )
+       Entry   *e )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
        DBT             key, data;
        DBC     *cursor;
@@ -681,7 +678,7 @@ bdb_dn2id_delete(
        rc = db->cursor( db, txn, &cursor, bdb->bi_db_opflags );
        if ( rc ) return rc;
 
-       d = sl_malloc( data.size, ctx );
+       d = op->o_tmpalloc( data.size, op->o_tmpmemctx );
        d->entryID = e->e_id;
        d->nrdnlen = BEI(e)->bei_nrdn.bv_len;
        strcpy( d->nrdn, BEI(e)->bei_nrdn.bv_val );
@@ -703,20 +700,20 @@ bdb_dn2id_delete(
                        rc = cursor->c_del( cursor, 0 );
        }
        cursor->c_close( cursor );
-       sl_free( d, ctx );
+       op->o_tmpfree( d, op->o_tmpmemctx );
 
        return rc;
 }
 
+
 int
-bdb_dn2id(
-       BackendDB       *be,
+hdb_dn2id(
+       Operation       *op,
        DB_TXN *txn,
        struct berval   *in,
-       EntryInfo       *ei,
-       void *ctx )
+       EntryInfo       *ei )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
        DBT             key, data;
        DBC     *cursor;
@@ -725,7 +722,7 @@ bdb_dn2id(
        char    *ptr;
        ID idp = ei->bei_parent->bei_id;
 
-       nrlen = dn_rdnlen( be, in );
+       nrlen = dn_rdnlen( op->o_bd, in );
        if (!nrlen) nrlen = in->bv_len;
 
        DBTzero(&key);
@@ -742,36 +739,42 @@ bdb_dn2id(
        rc = db->cursor( db, txn, &cursor, bdb->bi_db_opflags );
        if ( rc ) return rc;
 
-       d = sl_malloc( data.size * 3, ctx );
+       d = op->o_tmpalloc( data.size * 3, op->o_tmpmemctx );
        d->nrdnlen = nrlen;
        ptr = lutil_strncopy( d->nrdn, in->bv_val, nrlen );
        *ptr = '\0';
        data.data = d;
 
        rc = cursor->c_get( cursor, &key, &data, DB_GET_BOTH );
-       cursor->c_close( cursor );
-
        if ( rc == 0 ) {
-               AC_MEMCPY( &ei->bei_id, &d->entryID, sizeof(ID) );
+               ei->bei_id = d->entryID;
                ei->bei_rdn.bv_len = data.size - sizeof(diskNode) - nrlen;
                ptr = d->nrdn + nrlen + 1;
-               ei->bei_rdn.bv_val = ch_malloc( ei->bei_rdn.bv_len + 1 );
-               strcpy( ei->bei_rdn.bv_val, ptr );
+               ber_str2bv( ptr, ei->bei_rdn.bv_len, 1, &ei->bei_rdn );
+               if ( !ei->bei_parent->bei_dkids ) {
+                       db_recno_t dkids;
+                       /* How many children does the parent have? */
+                       /* FIXME: do we need to lock the parent
+                        * entryinfo? Seems safe...
+                        */
+                       cursor->c_count( cursor, &dkids, 0 );
+                       ei->bei_parent->bei_dkids = dkids;
+               }
        }
-       sl_free( d, ctx );
+       cursor->c_close( cursor );
+       op->o_tmpfree( d, op->o_tmpmemctx );
 
        return rc;
 }
 
 int
-bdb_dn2id_parent(
-       Backend *be,
+hdb_dn2id_parent(
+       Operation *op,
        DB_TXN *txn,
        EntryInfo *ei,
-       ID *idp,
-       void *ctx )
+       ID *idp )
 {
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct bdb_info *bdb = (struct bdb_info *) op->o_bd->be_private;
        DB *db = bdb->bi_dn2id->bdi_db;
        DBT             key, data;
        DBC     *cursor;
@@ -793,29 +796,34 @@ bdb_dn2id_parent(
        if ( rc ) return rc;
 
        data.ulen = sizeof(diskNode) + (SLAP_LDAPDN_MAXLEN * 2);
-       d = sl_malloc( data.ulen, ctx );
+       d = op->o_tmpalloc( data.ulen, op->o_tmpmemctx );
        data.data = d;
 
        rc = cursor->c_get( cursor, &key, &data, DB_SET );
-       cursor->c_close( cursor );
        if ( rc == 0 ) {
                if (d->nrdnlen >= 0) {
-                       return LDAP_OTHER;
+                       rc = LDAP_OTHER;
+               } else {
+                       db_recno_t dkids;
+                       *idp = d->entryID;
+                       ei->bei_nrdn.bv_len = 0 - d->nrdnlen;
+                       ber_str2bv( d->nrdn, ei->bei_nrdn.bv_len, 1, &ei->bei_nrdn );
+                       ei->bei_rdn.bv_len = data.size - sizeof(diskNode) -
+                               ei->bei_nrdn.bv_len;
+                       ptr = d->nrdn + ei->bei_nrdn.bv_len + 1;
+                       ber_str2bv( ptr, ei->bei_rdn.bv_len, 1, &ei->bei_rdn );
+                       /* How many children does this node have? */
+                       cursor->c_count( cursor, &dkids, 0 );
+                       ei->bei_dkids = dkids;
                }
-               AC_MEMCPY( idp, &d->entryID, sizeof(ID) );
-               ei->bei_nrdn.bv_len = 0 - d->nrdnlen;
-               ber_str2bv( d->nrdn, ei->bei_nrdn.bv_len, 1, &ei->bei_nrdn );
-               ei->bei_rdn.bv_len = data.size - sizeof(diskNode) -
-                       ei->bei_nrdn.bv_len;
-               ptr = d->nrdn + ei->bei_nrdn.bv_len + 1;
-               ber_str2bv( ptr, ei->bei_rdn.bv_len, 1, &ei->bei_rdn );
        }
-       sl_free( d, ctx );
+       cursor->c_close( cursor );
+       op->o_tmpfree( d, op->o_tmpmemctx );
        return rc;
 }
 
 int
-bdb_dn2id_children(
+hdb_dn2id_children(
        Operation *op,
        DB_TXN *txn,
        Entry *e )
@@ -852,7 +860,12 @@ bdb_dn2id_children(
 
        rc = cursor->c_get( cursor, &key, &data, DB_SET );
        if ( rc == 0 ) {
-               rc = cursor->c_get( cursor, &key, &data, DB_NEXT_DUP );
+               db_recno_t dkids;
+               rc = cursor->c_count( cursor, &dkids, 0 );
+               if ( rc == 0 ) {
+                       BEI(e)->bei_dkids = dkids;
+                       if ( dkids < 2 ) rc = DB_NOTFOUND;
+               }
        }
        cursor->c_close( cursor );
        return rc;
@@ -873,6 +886,7 @@ struct dn2id_cookie {
        DB *db;
        int prefix;
        int rc;
+       EntryInfo *ei;
        ID id;
        ID dbuf;
        ID *ids;
@@ -882,14 +896,38 @@ struct dn2id_cookie {
        DBT key;
        DBT data;
        DBC *dbc;
-       void *ctx;
+       Operation *op;
 };
 
+/* Stuff for iterating over a bei_kids AVL tree and adding the
+ * IDs to an IDL
+ */
+struct apply_arg {
+       ID *idl;
+       EntryInfo **ei;
+};
+
+static int
+apply_func(
+       void *data,
+       void *arg )
+{
+       EntryInfo *ei = data;
+       struct apply_arg *ap = arg;
+
+       bdb_idl_insert( ap->idl, ei->bei_id );
+       if ( ap->ei ) {
+               *(ap->ei)++ = ei;
+       }
+       return 0;
+}
+
 static int
-bdb_dn2idl_internal(
+hdb_dn2idl_internal(
        struct dn2id_cookie *cx
 )
 {
+       EntryInfo **eilist = NULL, **ptr;
 #ifdef SLAP_IDL_CACHE
        if ( cx->bdb->bi_idl_cache_size ) {
                cx->rc = bdb_idl_cache_get(cx->bdb, cx->db, &cx->key, cx->tmp);
@@ -897,45 +935,106 @@ bdb_dn2idl_internal(
                        return cx->rc;
                }
                if ( cx->rc == LDAP_SUCCESS ) {
-                       goto saveit;
+                       goto gotit;
                }
        }
 #endif
-
-       cx->rc = cx->db->cursor( cx->db, NULL, &cx->dbc,
-               cx->bdb->bi_db_opflags );
-       if ( cx->rc ) return cx->rc;
        BDB_IDL_ZERO( cx->tmp );
 
-       cx->data.data = &cx->dbuf;
-       cx->data.ulen = sizeof(ID);
-       cx->data.dlen = sizeof(ID);
-       cx->data.flags = DB_DBT_USERMEM | DB_DBT_PARTIAL;
-
-       /* The first item holds the parent ID. Ignore it. */
-       cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data, DB_SET );
-       if ( cx->rc == DB_NOTFOUND ) goto saveit;
-       if ( cx->rc ) return cx->rc;
-
-       cx->data.data = cx->buf;
-       cx->data.ulen = BDB_IDL_UM_SIZE * sizeof(ID);
-       cx->data.flags = DB_DBT_USERMEM;
-
-       /* Fetch the rest of the IDs in a loop... */
-       while ( (cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data,
-               DB_MULTIPLE | DB_NEXT_DUP )) == 0 ) {
-               u_int8_t *j;
-               size_t len;
-               DB_MULTIPLE_INIT( cx->ptr, &cx->data );
-               while (cx->ptr) {
-                       DB_MULTIPLE_NEXT( cx->ptr, &cx->data, j, len );
-                       if (j) {
-                               AC_MEMCPY( &cx->dbuf, j, sizeof(ID) );
-                               bdb_idl_insert( cx->tmp, cx->dbuf );
+       /* If number of kids in the cache differs from on-disk, load
+        * up all the kids from the database
+        */
+       if ( cx->ei->bei_ckids+1 != cx->ei->bei_dkids ) {
+               EntryInfo ei;
+               ei.bei_parent = cx->ei;
+
+               cx->rc = cx->db->cursor( cx->db, NULL, &cx->dbc,
+                       cx->bdb->bi_db_opflags );
+               if ( cx->rc ) return cx->rc;
+
+               cx->data.data = &cx->dbuf;
+               cx->data.ulen = sizeof(ID);
+               cx->data.dlen = sizeof(ID);
+               cx->data.flags = DB_DBT_USERMEM | DB_DBT_PARTIAL;
+
+               /* The first item holds the parent ID. Ignore it. */
+               cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data, DB_SET );
+               if ( cx->rc == DB_NOTFOUND ) goto saveit;
+               if ( cx->rc ) return cx->rc;
+
+               /* If the on-disk count is zero we've never checked it.
+                * Count it now.
+                */
+               if ( !cx->ei->bei_dkids ) {
+                       db_recno_t dkids;
+                       cx->dbc->c_count( cx->dbc, &dkids, 0 );
+                       cx->ei->bei_dkids = dkids;
+               }
+
+               /* If there are kids and this is a subtree search, allocate
+                * temp storage for the list of kids.
+                */
+               if ( cx->prefix == DN_SUBTREE_PREFIX && cx->ei->bei_dkids > 1 ) {
+                       eilist = cx->op->o_tmpalloc( sizeof(EntryInfo *) * cx->ei->bei_dkids, cx->op->o_tmpmemctx );
+                       eilist[cx->ei->bei_dkids-1] = NULL;
+                       ptr = eilist;
+               }
+
+               cx->data.data = cx->buf;
+               cx->data.ulen = BDB_IDL_UM_SIZE * sizeof(ID);
+               cx->data.flags = DB_DBT_USERMEM;
+
+               /* Fetch the rest of the IDs in a loop... */
+               while ( (cx->rc = cx->dbc->c_get( cx->dbc, &cx->key, &cx->data,
+                       DB_MULTIPLE | DB_NEXT_DUP )) == 0 ) {
+                       u_int8_t *j;
+                       size_t len;
+                       DB_MULTIPLE_INIT( cx->ptr, &cx->data );
+                       while (cx->ptr) {
+                               DB_MULTIPLE_NEXT( cx->ptr, &cx->data, j, len );
+                               if (j) {
+                                       EntryInfo *ei2;
+                                       diskNode *d = (diskNode *)j;
+
+                                       AC_MEMCPY( &ei.bei_id, &d->entryID, sizeof(ID) );
+                                       AC_MEMCPY( &ei.bei_nrdn.bv_len, &d->nrdnlen, sizeof(d->nrdnlen) );
+                                       /* nrdn/rdn are set in-place.
+                                        * hdb_cache_load will copy them as needed
+                                        */
+                                       ei.bei_nrdn.bv_val = d->nrdn;
+                                       ei.bei_rdn.bv_len = len - sizeof(diskNode) - ei.bei_nrdn.bv_len;
+                                       ei.bei_rdn.bv_val = d->nrdn + ei.bei_nrdn.bv_len + 1;
+                                       bdb_idl_insert( cx->tmp, ei.bei_id );
+                                       hdb_cache_load( cx->bdb, &ei, &ei2 );
+                                       if ( eilist )
+                                               *ptr++ = ei2;
+                               }
                        }
                }
+               cx->dbc->c_close( cx->dbc );
+       } else {
+               /* The in-memory cache is in sync with the on-disk data.
+                * do we have any kids?
+                */
+               if ( cx->ei->bei_ckids > 0 ) {
+                       struct apply_arg ap;
+
+                       /* Temp storage for subtree search */
+                       if ( cx->prefix == DN_SUBTREE_PREFIX ) {
+                               eilist = cx->op->o_tmpalloc( sizeof(EntryInfo *) * cx->ei->bei_dkids, cx->op->o_tmpmemctx );
+                               eilist[cx->ei->bei_dkids-1] = NULL;
+                       }
+
+                       /* Walk the kids tree; order is irrelevant since bdb_idl_insert
+                        * will insert in sorted order.
+                        */
+                       ap.idl = cx->tmp;
+                       ap.ei = eilist;
+                       bdb_cache_entryinfo_lock( cx->ei );
+                       avl_apply( cx->ei->bei_kids, apply_func, &ap, -1, AVL_POSTORDER );
+                       bdb_cache_entryinfo_unlock( cx->ei );
+               }
        }
-       cx->dbc->c_close( cx->dbc );
 
        /* If we got some records, treat as success */
        if (!BDB_IDL_IS_ZERO(cx->tmp)) {
@@ -948,21 +1047,18 @@ saveit:
                bdb_idl_cache_put( cx->bdb, cx->db, &cx->key, cx->tmp, cx->rc );
        }
 #endif
+       ;
+gotit:
        if ( cx->rc == 0 ) {
-               if ( cx->prefix == DN_SUBTREE_PREFIX ) {
-                       ID *save, idcurs;
-
-                       save = sl_malloc( BDB_IDL_SIZEOF( cx->tmp ), cx->ctx );
-                       BDB_IDL_CPY( save, cx->tmp );
+               /* If eilist is NULL, cx->tmp is empty... */
+               if ( cx->prefix == DN_SUBTREE_PREFIX && eilist ) {
                        bdb_idl_union( cx->ids, cx->tmp );
-       
-                       idcurs = 0;
-                       for ( cx->id = bdb_idl_first( save, &idcurs );
-                               cx->id != NOID;
-                               cx->id = bdb_idl_next( save, &idcurs )) {
-                               bdb_dn2idl_internal( cx );
+                       for (ptr = eilist; *ptr; ptr++) {
+                               cx->ei = *ptr;
+                               cx->id = cx->ei->bei_id;
+                               hdb_dn2idl_internal( cx );
                        }
-                       sl_free( save, cx->ctx );
+                       cx->op->o_tmpfree( eilist, cx->op->o_tmpmemctx );
                        cx->rc = 0;
                } else {
                        BDB_IDL_CPY( cx->ids, cx->tmp );
@@ -972,35 +1068,42 @@ saveit:
 }
 
 int
-bdb_dn2idl(
-       BackendDB       *be,
-       struct berval   *dn,
-       int prefix,
+hdb_dn2idl(
+       Operation       *op,
+       Entry           *e,
        ID *ids,
-       ID *stack,
-       void *ctx )
+       ID *stack )
 {
+       struct bdb_info *bdb = (struct bdb_info *)op->o_bd->be_private;
        struct dn2id_cookie cx;
-       EntryInfo *ei = (EntryInfo *)dn;
+
+#ifdef NEW_LOGGING
+       LDAP_LOG ( INDEX, ARGS, 
+               "=> hdb_dn2ididl( \"%s\" )\n", e->e_nname.bv_val, 0, 0 );
+#else
+       Debug( LDAP_DEBUG_TRACE, "=> hdb_dn2idl( \"%s\" )\n", e->e_nname.bv_val, 0, 0 );
+#endif
 
 #ifndef BDB_MULTIPLE_SUFFIXES
-       if ( ei->bei_parent->bei_id == 0 ) {
-               struct bdb_info *bdb = (struct bdb_info *)be->be_private;
+       if ( op->ors_scope == LDAP_SCOPE_SUBTREE && 
+               BEI(e)->bei_parent->bei_id == 0 ) {
                BDB_IDL_ALL( bdb, ids );
                return 0;
        }
 #endif
 
-       cx.id = ei->bei_id;
-       cx.bdb = (struct bdb_info *)be->be_private;
+       cx.id = e->e_id;
+       cx.ei = BEI(e);
+       cx.bdb = bdb;
        cx.db = cx.bdb->bi_dn2id->bdi_db;
-       cx.prefix = prefix;
+       cx.prefix = op->ors_scope == LDAP_SCOPE_SUBTREE ? DN_SUBTREE_PREFIX :
+                       DN_ONE_PREFIX;
        cx.ids = ids;
        cx.buf = stack;
-       cx.ctx = ctx;
+       cx.op = op;
 
        BDB_IDL_ZERO( ids );
-       if ( prefix == DN_SUBTREE_PREFIX ) {
+       if ( cx.prefix == DN_SUBTREE_PREFIX ) {
                bdb_idl_insert( ids, cx.id );
        }
 
@@ -1012,6 +1115,6 @@ bdb_dn2idl(
 
        DBTzero(&cx.data);
 
-       return bdb_dn2idl_internal(&cx);
+       return hdb_dn2idl_internal(&cx);
 }
 #endif /* BDB_HIER */