Never let ldif_parse_line() return a NULL value with success.

[openldap] / servers / slapd / back-bdb / index.c

diff --git a/servers/slapd/back-bdb/index.c b/servers/slapd/back-bdb/index.c
index c62e09d63fa592718bec842bb8d9a315d6271226..5a7b2a49b0fb135bc0a8c56ba5c58d6b0b92400f 100644 (file)
--- a/servers/slapd/back-bdb/index.c
+++ b/servers/slapd/back-bdb/index.c
@@ -43,7 +43,7 @@ static slap_mask_t index_mask(
                /* has language tag */
                bdb_attr_mask( be->be_private, desc->ad_type->sat_ad, &mask );
 
-               if (! ( mask & SLAP_INDEX_NOLANG ) ) {
+               if ( mask && ( mask ^ SLAP_INDEX_NOLANG ) ) {
                        *atname = desc->ad_type->sat_cname;
                        *dbname = desc->ad_type->sat_cname.bv_val;
                        return mask;
@@ -57,19 +57,11 @@ static slap_mask_t index_mask(
 
                bdb_attr_mask( be->be_private, at->sat_ad, &mask );
 
-               if( mask & SLAP_INDEX_AUTO_SUBTYPES ) {
-                       *atname = desc->ad_type->sat_cname;
-                       *dbname = at->sat_cname.bv_val;
-                       return mask;
-               }
-
-               if( !( mask & SLAP_INDEX_NOSUBTYPES ) ) {
+               if ( mask && ( mask ^ SLAP_INDEX_NOSUBTYPES ) ) {
                        *atname = at->sat_cname;
                        *dbname = at->sat_cname.bv_val;
                        return mask;
                }
-
-               if( mask ) break;
        }
 
        return 0;
@@ -79,7 +71,6 @@ int bdb_index_is_indexed(
        Backend *be,
        AttributeDescription *desc )
 {
-       int rc;
        slap_mask_t mask;
        char *dbname;
        struct berval prefix;
@@ -90,7 +81,7 @@ int bdb_index_is_indexed(
                return LDAP_INAPPROPRIATE_MATCHING;
        }
 
-       return LDAP_SUCCESS;
+       return LDAP_SUCCESS;
 }
 
 int bdb_index_param(
@@ -121,6 +112,7 @@ int bdb_index_param(
        switch( ftype ) {
        case LDAP_FILTER_PRESENT:
                if( IS_SLAP_INDEX( mask, SLAP_INDEX_PRESENT ) ) {
+                       *prefixp = presence_key;
                        goto done;
                }
                break;
@@ -160,7 +152,7 @@ static int indexer(
        DB_TXN *txn,
        char *dbname,
        struct berval *atname,
-       BVarray vals,
+       BerVarray vals,
        ID id,
        int op,
        slap_mask_t mask )
@@ -177,8 +169,8 @@ static int indexer(
        
        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "index", LDAP_LEVEL_ERR,
-                       "bdb_index_read: Could not open DB %s\n", dbname));
+               LDAP_LOG( INDEX, ERR, 
+                       "bdb_index_read: Could not open DB %s\n", dbname, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
                        "<= bdb_index_read NULL (could not open %s)\n",
@@ -209,11 +201,11 @@ static int indexer(
                        for( i=0; keys[i].bv_val != NULL; i++ ) {
                                rc = bdb_key_change( be, db, txn, &keys[i], id, op );
                                if( rc ) {
-                                       bvarray_free( keys );
+                                       ber_bvarray_free( keys );
                                        goto done;
                                }
                        }
-                       bvarray_free( keys );
+                       ber_bvarray_free( keys );
                }
                rc = LDAP_SUCCESS;
        }
@@ -230,11 +222,11 @@ static int indexer(
                        for( i=0; keys[i].bv_val != NULL; i++ ) {
                                rc = bdb_key_change( be, db, txn, &keys[i], id, op );
                                if( rc ) {
-                                       bvarray_free( keys );
+                                       ber_bvarray_free( keys );
                                        goto done;
                                }
                        }
-                       bvarray_free( keys );
+                       ber_bvarray_free( keys );
                }
 
                rc = LDAP_SUCCESS;
@@ -252,11 +244,11 @@ static int indexer(
                        for( i=0; keys[i].bv_val != NULL; i++ ) {
                                bdb_key_change( be, db, txn, &keys[i], id, op );
                                if( rc ) {
-                                       bvarray_free( keys );
+                                       ber_bvarray_free( keys );
                                        goto done;
                                }
                        }
-                       bvarray_free( keys );
+                       ber_bvarray_free( keys );
                }
 
                rc = LDAP_SUCCESS;
@@ -271,23 +263,18 @@ static int index_at_values(
        DB_TXN *txn,
        AttributeType *type,
        struct berval *lang,
-       BVarray vals,
+       BerVarray vals,
        ID id,
-       int op,
-       char ** dbnamep,
-       slap_mask_t *maskp )
+       int op )
 {
        int rc;
        slap_mask_t mask = 0;
-       slap_mask_t tmpmask = 0;
-       int lindex = 0;
 
        if( type->sat_sup ) {
                /* recurse */
                rc = index_at_values( be, txn,
                        type->sat_sup, lang,
-                       vals, id, op,
-                       dbnamep, &tmpmask );
+                       vals, id, op );
 
                if( rc ) return rc;
        }
@@ -298,13 +285,7 @@ static int index_at_values(
        }
 
        if( mask ) {
-               *dbnamep = type->sat_cname.bv_val;
-       } else if ( !( tmpmask & SLAP_INDEX_AUTO_SUBTYPES ) ) {
-               mask = tmpmask;
-       }
-
-       if( mask ) {
-               rc = indexer( be, txn, *dbnamep,
+               rc = indexer( be, txn, type->sat_cname.bv_val,
                        &type->sat_cname,
                        vals, id, op,
                        mask );
@@ -313,32 +294,21 @@ static int index_at_values(
        }
 
        if( lang->bv_len ) {
-               char *dbname = NULL;
-               struct berval lname;
                AttributeDescription *desc;
 
-               tmpmask = 0;
-               lname.bv_val = NULL;
+               mask = 0;
 
                desc = ad_find_lang( type, lang );
                if( desc ) {
-                       bdb_attr_mask( be->be_private, desc, &tmpmask );
+                       bdb_attr_mask( be->be_private, desc, &mask );
                }
 
-               if( tmpmask ) {
-                       dbname = desc->ad_cname.bv_val;
-                       lname = desc->ad_cname;
-                       mask = tmpmask;
-               }
-
-               if( dbname != NULL ) {
-                       rc = indexer( be, txn, dbname, &lname,
+               if( mask ) {
+                       rc = indexer( be, txn, desc->ad_cname.bv_val,
+                               &desc->ad_cname,
                                vals, id, op,
                                mask );
 
-                       if( !tmpmask ) {
-                               ch_free( lname.bv_val );
-                       }
                        if( rc ) {
                                return rc;
                        }
@@ -352,18 +322,15 @@ int bdb_index_values(
        Backend *be,
        DB_TXN *txn,
        AttributeDescription *desc,
-       BVarray vals,
+       BerVarray vals,
        ID id,
        int op )
 {
        int rc;
-       char *dbname = NULL;
-       slap_mask_t mask;
 
        rc = index_at_values( be, txn,
                desc->ad_type, &desc->ad_lang,
-               vals, id, op,
-               &dbname, &mask );
+               vals, id, op );
 
        return rc;
 }
@@ -379,10 +346,8 @@ bdb_index_entry(
        int rc;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "index", LDAP_LEVEL_ENTRY,
-               "index_entry: %s (%s) %ld\n",
-               op == SLAP_INDEX_ADD_OP ? "add" : "del",
-               e->e_dn, (long) e->e_id ));
+       LDAP_LOG( INDEX, ENTRY, "index_entry: %s (%s) %ld\n",
+               op == SLAP_INDEX_ADD_OP ? "add" : "del", e->e_dn, (long) e->e_id );
 #else
        Debug( LDAP_DEBUG_TRACE, "=> index_entry_%s( %ld, \"%s\" )\n",
                op == SLAP_INDEX_ADD_OP ? "add" : "del",
@@ -396,11 +361,11 @@ bdb_index_entry(
 
                if( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "index", LDAP_LEVEL_ENTRY,
-                               "index_entry: success\n" ));
+                       LDAP_LOG( INDEX, ENTRY, 
+                               "index_entry: failure (%d)\n", rc, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_TRACE,
-                               "<= index_entry_%s( %ld, \"%s\" ) success\n",
+                               "<= index_entry_%s( %ld, \"%s\" ) failure\n",
                                op == SLAP_INDEX_ADD_OP ? "add" : "del",
                                (long) e->e_id, e->e_dn );
 #endif
@@ -409,8 +374,7 @@ bdb_index_entry(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "index", LDAP_LEVEL_ENTRY,
-               "index_entry: success\n" ));
+       LDAP_LOG( INDEX, ENTRY, "index_entry: success\n", 0, 0, 0  );
 #else
        Debug( LDAP_DEBUG_TRACE, "<= index_entry_%s( %ld, \"%s\" ) success\n",
                op == SLAP_INDEX_ADD_OP ? "add" : "del",