]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/init.c
use slab memory for proxyauthz
[openldap] / servers / slapd / back-bdb / init.c
index e9ef03be63cc2de7b123b569a00559cddb3899b0..eff1b5db620375bf5c7791fa3c0187ca1d9fc391 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2000-2005 The OpenLDAP Foundation.
+ * Copyright 2000-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -20,7 +20,8 @@
 #include <ac/string.h>
 #include <ac/unistd.h>
 #include <ac/stdlib.h>
-
+#include <ac/errno.h>
+#include <sys/stat.h>
 #include "back-bdb.h"
 #include <lutil.h>
 #include <ldap_rq.h>
@@ -65,39 +66,42 @@ bdb_db_init( BackendDB *be )
 
        ldap_pvt_thread_mutex_init( &bdb->bi_database_mutex );
        ldap_pvt_thread_mutex_init( &bdb->bi_lastid_mutex );
-       ldap_pvt_thread_mutex_init( &bdb->bi_cache.lru_mutex );
+#ifdef BDB_HIER
+       ldap_pvt_thread_mutex_init( &bdb->bi_modrdns_mutex );
+#endif
+       ldap_pvt_thread_mutex_init( &bdb->bi_cache.lru_head_mutex );
+       ldap_pvt_thread_mutex_init( &bdb->bi_cache.lru_tail_mutex );
        ldap_pvt_thread_mutex_init( &bdb->bi_cache.c_dntree.bei_kids_mutex );
        ldap_pvt_thread_rdwr_init ( &bdb->bi_cache.c_rwlock );
+       ldap_pvt_thread_rdwr_init( &bdb->bi_idl_tree_rwlock );
+       ldap_pvt_thread_mutex_init( &bdb->bi_idl_tree_lrulock );
 
        be->be_private = bdb;
-       be->be_cf_table = be->bd_info->bi_cf_table;
+       be->be_cf_ocs = be->bd_info->bi_cf_ocs;
 
        return 0;
 }
 
-static void *
-bdb_checkpoint( void *ctx, void *arg )
-{
-       struct re_s *rtask = arg;
-       struct bdb_info *bdb = rtask->arg;
-       
-       TXN_CHECKPOINT( bdb->bi_dbenv, bdb->bi_txn_cp_kbyte,
-               bdb->bi_txn_cp_min, 0 );
-       ldap_pvt_thread_mutex_lock( &slapd_rq.rq_mutex );
-       ldap_pvt_runqueue_stoptask( &slapd_rq, rtask );
-       ldap_pvt_thread_mutex_unlock( &slapd_rq.rq_mutex );
-       return NULL;
-}
+static int
+bdb_db_close( BackendDB *be );
 
 static int
 bdb_db_open( BackendDB *be )
 {
        int rc, i;
        struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       struct stat stat1, stat2;
        u_int32_t flags;
-#ifdef HAVE_EBCDIC
        char path[MAXPATHLEN];
-#endif
+       char *dbhome;
+       int do_recover = 0, do_alock_recover = 0, open_env = 1, got_env = 0;
+
+       if ( be->be_suffix == NULL ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "bdb_db_open: need suffix\n",
+                       0, 0, 0 );
+               return -1;
+       }
 
        Debug( LDAP_DEBUG_ARGS,
                "bdb_db_open: %s\n",
@@ -110,67 +114,87 @@ bdb_db_open( BackendDB *be )
                return -1;
        }
 #endif
-       /* we should check existance of dbenv_home and db_directory */
 
-       rc = db_env_create( &bdb->bi_dbenv, 0 );
-       if( rc != 0 ) {
+       /* Check existence of dbenv_home. Any error means trouble */
+       rc = stat( bdb->bi_dbenv_home, &stat1 );
+       if( rc !=0 ) {
                Debug( LDAP_DEBUG_ANY,
-                       "bdb_db_open: db_env_create failed: %s (%d)\n",
-                       db_strerror(rc), rc, 0 );
-               return rc;
+                       "bdb_db_open: Cannot access database directory %s (%d)\n",
+                       bdb->bi_dbenv_home, errno, 0 );
+                       return -1;
        }
 
-       flags = DB_INIT_MPOOL | DB_THREAD | DB_CREATE;
+       /* Perform database use arbitration/recovery logic */
+       rc = alock_open( &bdb->bi_alock_info, 
+                               "slapd", 
+                               bdb->bi_dbenv_home,
+                               slapMode & SLAP_TOOL_READONLY ?
+                               ALOCK_LOCKED : ALOCK_UNIQUE );
 
-       if ( !( slapMode & SLAP_TOOL_QUICK ))
-               flags |= DB_INIT_LOCK | DB_INIT_LOG | DB_INIT_TXN;
-       
-       rc = alock_open( &bdb->bi_alock_info, "slapd", bdb->bi_dbenv_home,
-               slapMode & SLAP_TOOL_READONLY ?  ALOCK_LOCKED : ALOCK_UNIQUE );
        if( rc == ALOCK_RECOVER ) {
                Debug( LDAP_DEBUG_ANY,
-                       "bdb_db_open: alock_open: recovery required\n", 0, 0, 0 );
-               flags |= DB_RECOVER;
+                       "bdb_db_open: unclean shutdown detected;"
+                       " attempting recovery.\n", 
+                       0, 0, 0 );
+               do_alock_recover = 1;
+               do_recover = 1;
        } else if( rc == ALOCK_BUSY ) {
                Debug( LDAP_DEBUG_ANY,
-                  "bdb_db_open: alock_open: database in use\n", 0, 0, 0 );
+                       "bdb_db_open: database already in use\n", 
+                       0, 0, 0 );
                return -1;
        } else if( rc != ALOCK_CLEAN ) {
                Debug( LDAP_DEBUG_ANY,
-                  "bdb_db_open: alock_open: database unstable\n", 0, 0, 0 );
+                       "bdb_db_open: alock package is unstable\n", 
+                       0, 0, 0 );
                return -1;
        }
 
-       /* If a key was set, use shared memory for the BDB environment */
-       if ( bdb->bi_shm_key ) {
-               bdb->bi_dbenv->set_shm_key( bdb->bi_dbenv, bdb->bi_shm_key );
-               flags |= DB_SYSTEM_MEM;
+       /*
+        * The DB_CONFIG file may have changed. If so, recover the
+        * database so that new settings are put into effect. Also
+        * note the possible absence of DB_CONFIG in the log.
+        */
+       if( stat( bdb->bi_db_config_path, &stat1 ) == 0 ) {
+               if ( !do_recover ) {
+                       char *ptr = lutil_strcopy(path, bdb->bi_dbenv_home);
+                       *ptr++ = LDAP_DIRSEP[0];
+                       strcpy( ptr, "__db.001" );
+                       if( stat( path, &stat2 ) == 0 ) {
+                               if( stat2.st_mtime <= stat1.st_mtime ) {
+                                       Debug( LDAP_DEBUG_ANY,
+                                               "bdb_db_open: DB_CONFIG for suffix %s has changed.\n"
+                                               "Performing database recovery to activate new settings.\n",
+                                               be->be_suffix[0].bv_val, 0, 0 );
+                                       do_recover = 1;
+                               }
+                       }
+               }
+       }
+       else {
+               Debug( LDAP_DEBUG_ANY,
+                       "bdb_db_open: Warning - No DB_CONFIG file found "
+                       "in directory %s: (%d)\n"
+                       "Expect poor performance for suffix %s.\n",
+                       bdb->bi_dbenv_home, errno, be->be_suffix[0].bv_val );
+       }
+
+       rc = db_env_create( &bdb->bi_dbenv, 0 );
+       if( rc != 0 ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "bdb_db_open: db_env_create failed: %s (%d)\n",
+                       db_strerror(rc), rc, 0 );
+               goto fail;
        }
 
        bdb->bi_dbenv->set_errpfx( bdb->bi_dbenv, be->be_suffix[0].bv_val );
        bdb->bi_dbenv->set_errcall( bdb->bi_dbenv, bdb_errcall );
+
        bdb->bi_dbenv->set_lk_detect( bdb->bi_dbenv, bdb->bi_lock_detect );
 
        /* One long-lived TXN per thread, two TXNs per write op */
        bdb->bi_dbenv->set_tx_max( bdb->bi_dbenv, connection_pool_max * 3 );
 
-#ifdef SLAP_ZONE_ALLOC
-       if ( bdb->bi_cache.c_maxsize ) {
-               bdb->bi_cache.c_zctx = slap_zn_mem_create(
-                                                               SLAP_ZONE_INITSIZE,
-                                                               SLAP_ZONE_MAXSIZE,
-                                                               SLAP_ZONE_DELTA,
-                                                               SLAP_ZONE_SIZE);
-       }
-#endif
-
-       if ( bdb->bi_idl_cache_max_size ) {
-               bdb->bi_idl_tree = NULL;
-               ldap_pvt_thread_rdwr_init( &bdb->bi_idl_tree_rwlock );
-               ldap_pvt_thread_mutex_init( &bdb->bi_idl_tree_lrulock );
-               bdb->bi_idl_cache_size = 0;
-       }
-
        if( bdb->bi_dbenv_xflags != 0 ) {
                rc = bdb->bi_dbenv->set_flags( bdb->bi_dbenv,
                        bdb->bi_dbenv_xflags, 1);
@@ -178,42 +202,212 @@ bdb_db_open( BackendDB *be )
                        Debug( LDAP_DEBUG_ANY,
                                "bdb_db_open: dbenv_set_flags failed: %s (%d)\n",
                                db_strerror(rc), rc, 0 );
-                       return rc;
+                       goto fail;
                }
        }
 
-       Debug( LDAP_DEBUG_TRACE,
-               "bdb_db_open: dbenv_open(%s)\n",
-               bdb->bi_dbenv_home, 0, 0);
+#define        BDB_TXN_FLAGS   (DB_INIT_LOCK | DB_INIT_LOG | DB_INIT_TXN)
 
 #ifdef HAVE_EBCDIC
        strcpy( path, bdb->bi_dbenv_home );
        __atoe( path );
-       rc = bdb->bi_dbenv->open( bdb->bi_dbenv,
-               path,
-               flags,
-               bdb->bi_dbenv_mode );
+       dbhome = path;
 #else
-       rc = bdb->bi_dbenv->open( bdb->bi_dbenv,
-               bdb->bi_dbenv_home,
-               flags,
-               bdb->bi_dbenv_mode );
+       dbhome = bdb->bi_dbenv_home;
 #endif
-       if( rc != 0 ) {
-               Debug( LDAP_DEBUG_ANY,
-                       "bdb_db_open: dbenv_open failed: %s (%d)\n",
-                       db_strerror(rc), rc, 0 );
-               return rc;
+
+       Debug( LDAP_DEBUG_TRACE,
+               "bdb_db_open: dbenv_open(%s)\n",
+               bdb->bi_dbenv_home, 0, 0);
+
+       /* Check if there is a usable existing environment */
+       flags = DB_JOINENV | DB_THREAD;
+
+       rc = bdb->bi_dbenv->open( bdb->bi_dbenv, dbhome,
+               flags, bdb->bi_dbenv_mode );
+       if( rc == 0 ) {
+               int flags_ok = 0;
+
+               got_env = 1;
+
+               rc = bdb->bi_dbenv->get_open_flags( bdb->bi_dbenv, &flags );
+               if ( rc == 0 ) {
+                       int flag2 = flags & BDB_TXN_FLAGS;
+
+                       /* In quick mode, none of these flags are allowed */
+                       if ( slapMode & SLAP_TOOL_QUICK ) {
+                               if ( !flag2 )
+                                       flags_ok = 1;
+                       } else {
+                       /* In normal mode, all of these flags are required */
+                               if ( flag2 == BDB_TXN_FLAGS )
+                                       flags_ok = 1;
+                       }
+               }
+
+               /* In Quick mode, we cannot Recover... */
+               if ( slapMode & SLAP_TOOL_QUICK ) {
+                       /* If we need to recover but we had no TXNs, just fail */
+                       if ( do_recover && flags_ok ) {
+                               Debug( LDAP_DEBUG_ANY,
+                                       "bdb_db_open: Database cannot be recovered. "
+                                       "Restore from backup!\n", 0, 0, 0);
+                               rc = -1;
+                               goto fail;
+                       }
+                       /* We need to recover, and we had TXN support before:
+                        * Close this env, open a new one with recovery flags.
+                        */
+                       if ( do_recover ) {
+                               bdb->bi_dbenv->close( bdb->bi_dbenv, 0 );
+                               bdb->bi_dbenv = NULL;
+                               rc = db_env_create( &bdb->bi_dbenv, 0 );
+                               if( rc != 0 ) {
+                                       Debug( LDAP_DEBUG_ANY,
+                                               "bdb_db_open: db_env_create failed: %s (%d)\n",
+                                               db_strerror(rc), rc, 0 );
+                                       goto fail;
+                               }
+                               bdb->bi_dbenv->set_errpfx( bdb->bi_dbenv,
+                                       be->be_suffix[0].bv_val );
+                               bdb->bi_dbenv->set_errcall( bdb->bi_dbenv, bdb_errcall );
+                               rc = bdb->bi_dbenv->open( bdb->bi_dbenv, dbhome,
+                                       flags | DB_RECOVER, bdb->bi_dbenv_mode );
+                               if( rc != 0 ) {
+                                       Debug( LDAP_DEBUG_ANY,
+                                               "bdb_db_open: recovery failed: %s (%d)\n",
+                                               db_strerror(rc), rc, 0 );
+                                       goto fail;
+                               }
+                               do_recover = 0;
+                       }
+                       /* Prev environment had TXN support, get rid of it */
+                       if ( !flags_ok ) {
+                               bdb->bi_dbenv->close( bdb->bi_dbenv, 0 );
+                               bdb->bi_dbenv = NULL;
+                               rc = db_env_create( &bdb->bi_dbenv, 0 );
+                               if( rc != 0 ) {
+                                       Debug( LDAP_DEBUG_ANY,
+                                               "bdb_db_open: db_env_create failed: %s (%d)\n",
+                                               db_strerror(rc), rc, 0 );
+                                       goto fail;
+                               }
+                               bdb->bi_dbenv->remove( bdb->bi_dbenv, dbhome, 0 );
+                               bdb->bi_dbenv = NULL;
+                       }
+               /* Normal TXN mode */
+               } else {
+                       /* If we need to recover but we had no TXNs, just fail */
+                       if ( do_recover && !flags_ok ) {
+                               Debug( LDAP_DEBUG_ANY,
+                                       "bdb_db_open: Database cannot be recovered. "
+                                       "Restore from backup!\n", 0, 0, 0);
+                               rc = -1;
+                               goto fail;
+                       }
+                       /* Prev environment had no TXN support, close it */
+                       if ( !flags_ok ) {
+                               bdb->bi_dbenv->close( bdb->bi_dbenv, 0 );
+                               bdb->bi_dbenv = NULL;
+                               do_recover = 1;
+                       }
+               }
+
+               if ( flags_ok && !do_recover ) {
+                       /* This environment is fine, don't reopen it */
+                       open_env = 0;
+               } else {
+                       /* Create a new env that can take the desired settings */
+                       if ( bdb->bi_dbenv != NULL ) {
+                               bdb->bi_dbenv->close( bdb->bi_dbenv, 0 );
+                               bdb->bi_dbenv = NULL;
+                       }
+                       rc = db_env_create( &bdb->bi_dbenv, 0 );
+                       if( rc != 0 ) {
+                               Debug( LDAP_DEBUG_ANY,
+                                       "bdb_db_open: db_env_create failed: %s (%d)\n",
+                                       db_strerror(rc), rc, 0 );
+                               goto fail;
+                       }
+
+                       bdb->bi_dbenv->set_errpfx( bdb->bi_dbenv, be->be_suffix[0].bv_val );
+                       bdb->bi_dbenv->set_errcall( bdb->bi_dbenv, bdb_errcall );
+                       bdb->bi_dbenv->set_lk_detect( bdb->bi_dbenv, bdb->bi_lock_detect );
+
+                       /* One long-lived TXN per thread, two TXNs per write op */
+                       bdb->bi_dbenv->set_tx_max( bdb->bi_dbenv, connection_pool_max * 3 );
+
+                       if( bdb->bi_dbenv_xflags != 0 ) {
+                               rc = bdb->bi_dbenv->set_flags( bdb->bi_dbenv,
+                                       bdb->bi_dbenv_xflags, 1);
+                               if( rc != 0 ) {
+                                       Debug( LDAP_DEBUG_ANY,
+                                               "bdb_db_open: dbenv_set_flags failed: %s (%d)\n",
+                                               db_strerror(rc), rc, 0 );
+                                       goto fail;
+                               }
+                       }
+               }
+       }
+
+       /* If we need to recover but there was no existing environment,
+        * then we assume that someone has already manually recovered using
+        * db_recover. Just ignore it.
+        */
+       if ( do_recover && !got_env ) {
+               do_recover = 0;
+               Debug( LDAP_DEBUG_TRACE,
+                       "bdb_db_open: Recovery needed but environment is missing - "
+                       "assuming recovery was done manually...\n", 0, 0, 0 );
        }
-       if( flags & DB_RECOVER ) {
-               rc = alock_recover (&bdb->bi_alock_info);
+
+       if ( open_env ) {
+               flags = DB_INIT_MPOOL | DB_THREAD | DB_CREATE;
+               if ( !( slapMode & SLAP_TOOL_QUICK ))
+                       flags |= BDB_TXN_FLAGS;
+
+               if ( do_recover )
+                       flags |= DB_RECOVER;
+
+               /* If a key was set, use shared memory for the BDB environment */
+               if ( bdb->bi_shm_key ) {
+                       bdb->bi_dbenv->set_shm_key( bdb->bi_dbenv, bdb->bi_shm_key );
+                       flags |= DB_SYSTEM_MEM;
+               }
+
+               rc = bdb->bi_dbenv->open( bdb->bi_dbenv, dbhome,
+                       flags, bdb->bi_dbenv_mode );
                if( rc != 0 ) {
                        Debug( LDAP_DEBUG_ANY,
-                          "bdb_db_open: unable to alock_recover\n", 0, 0, 0 );
-                       return -1;
+                               "bdb_db_open: dbenv_open failed: %s (%d)\n",
+                               db_strerror(rc), rc, 0 );
+                       goto fail;
                }
        }
 
+       if ( do_alock_recover && alock_recover (&bdb->bi_alock_info) != 0 ) {
+               Debug( LDAP_DEBUG_ANY,
+                       "bdb_db_open: alock_recover failed\n",
+                       0, 0, 0 );
+               rc = -1;
+               goto fail;
+       }
+
+#ifdef SLAP_ZONE_ALLOC
+       if ( bdb->bi_cache.c_maxsize ) {
+               bdb->bi_cache.c_zctx = slap_zn_mem_create(
+                                                               SLAP_ZONE_INITSIZE,
+                                                               SLAP_ZONE_MAXSIZE,
+                                                               SLAP_ZONE_DELTA,
+                                                               SLAP_ZONE_SIZE);
+       }
+#endif
+
+       if ( bdb->bi_idl_cache_max_size ) {
+               bdb->bi_idl_tree = NULL;
+               bdb->bi_idl_cache_size = 0;
+       }
+
        flags = DB_THREAD | bdb->bi_db_opflags;
 
 #ifdef DB_AUTO_COMMIT
@@ -235,10 +429,14 @@ bdb_db_open( BackendDB *be )
                        Debug( LDAP_DEBUG_ANY,
                                "bdb_db_open: db_create(%s) failed: %s (%d)\n",
                                bdb->bi_dbenv_home, db_strerror(rc), rc );
-                       return rc;
+                       goto fail;
                }
 
                if( i == BDB_ID2ENTRY ) {
+                       if ( slapMode & SLAP_TOOL_MODE )
+                               db->bdi_db->mpf->set_priority( db->bdi_db->mpf,
+                                       DB_PRIORITY_VERY_LOW );
+
                        rc = db->bdi_db->set_pagesize( db->bdi_db,
                                BDB_ID2ENTRY_PAGESIZE );
                        if ( slapMode & SLAP_TOOL_READMAIN ) {
@@ -292,7 +490,8 @@ bdb_db_open( BackendDB *be )
                        Debug( LDAP_DEBUG_ANY,
                                "bdb_db_open: db_open(%s) failed: %s (%d)\n",
                                buf, db_strerror(rc), rc );
-                       return rc;
+                       db->bdi_db->close( db->bdi_db, 0 );
+                       goto fail;
                }
 
                flags &= ~(DB_CREATE | DB_RDONLY);
@@ -309,53 +508,20 @@ bdb_db_open( BackendDB *be )
                Debug( LDAP_DEBUG_ANY,
                        "bdb_db_open: last_id(%s) failed: %s (%d)\n",
                        bdb->bi_dbenv_home, db_strerror(rc), rc );
-               return rc;
+               goto fail;
        }
 
        if ( !( slapMode & SLAP_TOOL_QUICK )) {
                XLOCK_ID(bdb->bi_dbenv, &bdb->bi_cache.c_locker);
        }
 
-       /* If we're in server mode and time-based checkpointing is enabled,
-        * submit a task to perform periodic checkpoints.
-        */
-       if (( slapMode & SLAP_SERVER_MODE ) && bdb->bi_txn_cp &&
-               bdb->bi_txn_cp_min )  {
-               ldap_pvt_thread_mutex_lock( &slapd_rq.rq_mutex );
-               ldap_pvt_runqueue_insert( &slapd_rq, bdb->bi_txn_cp_min*60,
-                       bdb_checkpoint, bdb );
-               ldap_pvt_thread_mutex_unlock( &slapd_rq.rq_mutex );
-       }
-
-       if ( slapMode & SLAP_SERVER_MODE && bdb->bi_db_has_config ) {
-               char    buf[SLAP_TEXT_BUFLEN];
-               FILE *f = fopen( bdb->bi_db_config_path, "r" );
-               struct berval bv;
-
-               if ( f ) {
-                       while ( fgets( buf, sizeof(buf), f )) {
-                               ber_str2bv( buf, 0, 1, &bv );
-                               if ( bv.bv_val[bv.bv_len-1] == '\n' ) {
-                                       bv.bv_len--;
-                                       bv.bv_val[bv.bv_len] = '\0';
-                               }
-                               /* shouldn't need this, but ... */
-                               if ( bv.bv_val[bv.bv_len-1] == '\r' ) {
-                                       bv.bv_len--;
-                                       bv.bv_val[bv.bv_len] = '\0';
-                               }
-                               ber_bvarray_add( &bdb->bi_db_config, &bv );
-                       }
-                       fclose( f );
-               } else {
-                       /* Eh? It disappeared between config and open?? */
-                       bdb->bi_db_has_config = 0;
-               }
-
-       }
-       bdb->bi_db_is_open = 1;
+       bdb->bi_flags |= BDB_IS_OPEN;
 
        return 0;
+
+fail:
+       bdb_db_close( be );
+       return rc;
 }
 
 static int
@@ -366,11 +532,12 @@ bdb_db_close( BackendDB *be )
        struct bdb_db_info *db;
        bdb_idl_cache_entry_t *entry, *next_entry;
 
-       bdb->bi_db_is_open = 0;
+       bdb->bi_flags &= ~BDB_IS_OPEN;
 
        ber_bvarray_free( bdb->bi_db_config );
+       bdb->bi_db_config = NULL;
 
-       while( bdb->bi_ndatabases-- ) {
+       while( bdb->bi_databases && bdb->bi_ndatabases-- ) {
                db = bdb->bi_databases[bdb->bi_ndatabases];
                rc = db->bdi_db->close( db->bdi_db, 0 );
                /* Lower numbered names are not strdup'd */
@@ -379,13 +546,13 @@ bdb_db_close( BackendDB *be )
                free( db );
        }
        free( bdb->bi_databases );
-       bdb_attr_index_destroy( bdb->bi_attrs );
+       bdb->bi_databases = NULL;
 
        bdb_cache_release_all (&bdb->bi_cache);
 
        if ( bdb->bi_idl_cache_max_size ) {
-               ldap_pvt_thread_rdwr_wlock ( &bdb->bi_idl_tree_rwlock );
                avl_free( bdb->bi_idl_tree, NULL );
+               bdb->bi_idl_tree = NULL;
                entry = bdb->bi_idl_lru_head;
                while ( entry != NULL ) {
                        next_entry = entry->idl_lru_next;
@@ -395,30 +562,25 @@ bdb_db_close( BackendDB *be )
                        free( entry );
                        entry = next_entry;
                }
-               ldap_pvt_thread_rdwr_wunlock ( &bdb->bi_idl_tree_rwlock );
+               bdb->bi_idl_lru_head = bdb->bi_idl_lru_tail = NULL;
        }
 
-       if ( !( slapMode & SLAP_TOOL_QUICK )) {
-               XLOCK_ID_FREE(bdb->bi_dbenv, bdb->bi_cache.c_locker);
-       }
-
-       return 0;
-}
-
-static int
-bdb_db_destroy( BackendDB *be )
-{
-       int rc;
-       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
-
        /* close db environment */
        if( bdb->bi_dbenv ) {
-               /* force a checkpoint */
+               /* Free cache locker if we enabled locking */
                if ( !( slapMode & SLAP_TOOL_QUICK )) {
+                       XLOCK_ID_FREE(bdb->bi_dbenv, bdb->bi_cache.c_locker);
+                       bdb->bi_cache.c_locker = 0;
+               }
+
+               /* force a checkpoint, but not if we were ReadOnly,
+                * and not in Quick mode since there are no transactions there.
+                */
+               if ( !( slapMode & ( SLAP_TOOL_QUICK|SLAP_TOOL_READONLY ))) {
                        rc = TXN_CHECKPOINT( bdb->bi_dbenv, 0, 0, DB_FORCE );
                        if( rc != 0 ) {
                                Debug( LDAP_DEBUG_ANY,
-                                       "bdb_db_destroy: txn_checkpoint failed: %s (%d)\n",
+                                       "bdb_db_close: txn_checkpoint failed: %s (%d)\n",
                                        db_strerror(rc), rc, 0 );
                        }
                }
@@ -427,7 +589,7 @@ bdb_db_destroy( BackendDB *be )
                bdb->bi_dbenv = NULL;
                if( rc != 0 ) {
                        Debug( LDAP_DEBUG_ANY,
-                               "bdb_db_destroy: close failed: %s (%d)\n",
+                               "bdb_db_close: close failed: %s (%d)\n",
                                db_strerror(rc), rc, 0 );
                        return rc;
                }
@@ -436,22 +598,34 @@ bdb_db_destroy( BackendDB *be )
        rc = alock_close( &bdb->bi_alock_info );
        if( rc != 0 ) {
                Debug( LDAP_DEBUG_ANY,
-                       "bdb_db_destroy: alock_close failed\n", 0, 0, 0 );
+                       "bdb_db_close: alock_close failed\n", 0, 0, 0 );
                return -1;
        }
 
+       return 0;
+}
+
+static int
+bdb_db_destroy( BackendDB *be )
+{
+       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+
        if( bdb->bi_dbenv_home ) ch_free( bdb->bi_dbenv_home );
        if( bdb->bi_db_config_path ) ch_free( bdb->bi_db_config_path );
 
+       bdb_attr_index_destroy( bdb );
+
        ldap_pvt_thread_rdwr_destroy ( &bdb->bi_cache.c_rwlock );
-       ldap_pvt_thread_mutex_destroy( &bdb->bi_cache.lru_mutex );
+       ldap_pvt_thread_mutex_destroy( &bdb->bi_cache.lru_head_mutex );
+       ldap_pvt_thread_mutex_destroy( &bdb->bi_cache.lru_tail_mutex );
        ldap_pvt_thread_mutex_destroy( &bdb->bi_cache.c_dntree.bei_kids_mutex );
+#ifdef BDB_HIER
+       ldap_pvt_thread_mutex_destroy( &bdb->bi_modrdns_mutex );
+#endif
        ldap_pvt_thread_mutex_destroy( &bdb->bi_lastid_mutex );
        ldap_pvt_thread_mutex_destroy( &bdb->bi_database_mutex );
-       if ( bdb->bi_idl_cache_max_size ) {
-               ldap_pvt_thread_rdwr_destroy( &bdb->bi_idl_tree_rwlock );
-               ldap_pvt_thread_mutex_destroy( &bdb->bi_idl_tree_lrulock );
-       }
+       ldap_pvt_thread_rdwr_destroy( &bdb->bi_idl_tree_rwlock );
+       ldap_pvt_thread_mutex_destroy( &bdb->bi_idl_tree_lrulock );
 
        ch_free( bdb );
        be->be_private = NULL;
@@ -470,12 +644,8 @@ bdb_back_initialize(
                LDAP_CONTROL_MANAGEDSAIT,
                LDAP_CONTROL_NOOP,
                LDAP_CONTROL_PAGEDRESULTS,
-#ifdef LDAP_CONTROL_SUBENTRIES
                LDAP_CONTROL_SUBENTRIES,
-#endif
-#ifdef LDAP_CONTROL_X_PERMISSIVE_MODIFY
                LDAP_CONTROL_X_PERMISSIVE_MODIFY,
-#endif
                NULL
        };
 
@@ -486,9 +656,7 @@ bdb_back_initialize(
 
        bi->bi_flags |=
                SLAP_BFLAG_INCREMENT |
-#ifdef BDB_SUBENTRIES
                SLAP_BFLAG_SUBENTRIES |
-#endif
                SLAP_BFLAG_ALIASES |
                SLAP_BFLAG_REFERRALS;