]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/modify.c
Additional manageDIT changes.
[openldap] / servers / slapd / back-bdb / modify.c
index 772e89bc99e040dedef25b7d74b5ff32566fe4df..7e85e8b322d9954fe9adf47adb9c47e562c97d41 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2000-2004 The OpenLDAP Foundation.
+ * Copyright 2000-2005 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -21,7 +21,6 @@
 #include <ac/time.h>
 
 #include "back-bdb.h"
-#include "external.h"
 
 static struct berval scbva[] = {
        BER_BVC("glue"),
@@ -44,13 +43,8 @@ int bdb_modify_internal(
        Attribute       *ap;
        int                     glue_attr_delete = 0;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "bdb_modify_internal: 0x%08lx: %s\n", 
-               e->e_id, e->e_dn, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "bdb_modify_internal: 0x%08lx: %s\n",
                e->e_id, e->e_dn, 0);
-#endif
 
        if ( !acl_check_modlist( op, e, modlist )) {
                return LDAP_INSUFFICIENT_ACCESS;
@@ -68,11 +62,11 @@ int bdb_modify_internal(
                case LDAP_MOD_REPLACE:
                        if ( mod->sm_desc == slap_schema.si_ad_structuralObjectClass ) {
                                value_match( &match, slap_schema.si_ad_structuralObjectClass,
-                               slap_schema.si_ad_structuralObjectClass->ad_type->sat_equality,
-                               SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
-                               &mod->sm_values[0], &scbva[0], text );
-                               if ( !match )
-                                       glue_attr_delete = 1;
+                                       slap_schema.si_ad_structuralObjectClass->
+                                               ad_type->sat_equality,
+                                       SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
+                                       &mod->sm_values[0], &scbva[0], text );
+                               if ( !match ) glue_attr_delete = 1;
                        }
                }
                if ( glue_attr_delete )
@@ -97,21 +91,12 @@ int bdb_modify_internal(
 
                switch ( mod->sm_op ) {
                case LDAP_MOD_ADD:
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify_internal: add\n", 0,0,0);
-#else
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
-#endif
                        err = modify_add_values( e, mod, get_permissiveModify(op),
                                text, textbuf, textlen );
                        if( err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: %d %s\n", err, *text, 0 );
-#else
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
-#endif
                        }
                        break;
 
@@ -121,75 +106,40 @@ int bdb_modify_internal(
                                break;
                        }
 
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_modify_internal: delete\n", 0, 0, 0 );
-#else
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
-#endif
                        err = modify_delete_values( e, mod, get_permissiveModify(op),
                                text, textbuf, textlen );
                        assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
                        if( err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: %d %s\n", err, *text, 0 );
-#else
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
-#endif
                        }
                        break;
 
                case LDAP_MOD_REPLACE:
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_modify_internal: replace\n", 0, 0, 0 );
-#else
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
-#endif
                        err = modify_replace_values( e, mod, get_permissiveModify(op),
                                text, textbuf, textlen );
                        if( err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: %d %s\n", err, *text, 0 );
-#else
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
-#endif
                        }
                        break;
 
                case LDAP_MOD_INCREMENT:
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_modify_internal: increment\n", 0, 0, 0 );
-#else
                        Debug(LDAP_DEBUG_ARGS,
                                "bdb_modify_internal: increment\n", 0, 0, 0);
-#endif
                        err = modify_increment_values( e, mod, get_permissiveModify(op),
                                text, textbuf, textlen );
                        if( err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: %d %s\n", err, *text, 0 );
-#else
                                Debug(LDAP_DEBUG_ARGS,
                                        "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
-#endif
                        }
                        break;
 
                case SLAP_MOD_SOFTADD:
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1, 
-                               "bdb_modify_internal: softadd\n",0,0,0 );
-#else
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: softadd\n", 0, 0, 0);
-#endif
                        /* Avoid problems in index_add_mods()
                         * We need to add index if necessary.
                         */
@@ -205,33 +155,18 @@ int bdb_modify_internal(
                        }
 
                        if( err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: %d %s\n", err, *text, 0 );
-#else
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
-#endif
                        }
                        break;
 
                default:
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: invalid op %d\n", mod->sm_op, 0, 0 );
-#else
                        Debug(LDAP_DEBUG_ANY, "bdb_modify_internal: invalid op %d\n",
                                mod->sm_op, 0, 0);
-#endif
                        *text = "Invalid modify operation";
                        err = LDAP_OTHER;
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: %d %s\n", err, *text, 0 );
-#else
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                err, *text, 0);
-#endif
                }
 
                if ( err != LDAP_SUCCESS ) {
@@ -246,9 +181,7 @@ int bdb_modify_internal(
                        e->e_ocflags = 0;
                }
 
-               if ( glue_attr_delete ) {
-                       e->e_ocflags = 0;
-               }
+               if ( glue_attr_delete ) e->e_ocflags = 0;
 
                /* check if modified attribute was indexed
                 * but not in case of NOOP... */
@@ -263,21 +196,20 @@ int bdb_modify_internal(
        }
 
        /* check that the entry still obeys the schema */
-       rc = entry_schema_check( op->o_bd, e, save_attrs, text, textbuf, textlen );
+       rc = entry_schema_check( op->o_bd, e, save_attrs, get_manageDIT(op),
+               text, textbuf, textlen );
        if ( rc != LDAP_SUCCESS || op->o_noop ) {
                attrs_free( e->e_attrs );
+               /* clear the indexing flags */
+               for ( ap = save_attrs; ap != NULL; ap = ap->a_next ) {
+                       ap->a_flags = 0;
+               }
                e->e_attrs = save_attrs;
 
                if ( rc != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, ERR, "bdb_modify_internal: "
-                               "entry failed schema check %s\n", 
-                               *text, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_ANY,
                                "entry failed schema check: %s\n",
                                *text, 0, 0 );
-#endif
                }
 
                /* if NOOP then silently revert to saved attrs */
@@ -295,15 +227,9 @@ int bdb_modify_internal(
                        if ( rc != LDAP_SUCCESS ) {
                                attrs_free( e->e_attrs );
                                e->e_attrs = save_attrs;
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: attribute index delete failure\n",
-                                       0, 0, 0 );
-#else
                                Debug( LDAP_DEBUG_ANY,
                                       "Attribute index delete failure",
                                       0, 0, 0 );
-#endif
                                return rc;
                        }
                        ap->a_flags &= ~SLAP_ATTR_IXDEL;
@@ -319,15 +245,9 @@ int bdb_modify_internal(
                        if ( rc != LDAP_SUCCESS ) {
                                attrs_free( e->e_attrs );
                                e->e_attrs = save_attrs;
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR, 
-                                       "bdb_modify_internal: attribute index add failure\n", 
-                                       0, 0, 0 );
-#else
                                Debug( LDAP_DEBUG_ANY,
                                       "Attribute index add failure",
                                       0, 0, 0 );
-#endif
                                return rc;
                        }
                        ap->a_flags &= ~SLAP_ATTR_IXADD;
@@ -348,8 +268,9 @@ bdb_modify( Operation *op, SlapReply *rs )
        char textbuf[SLAP_TEXT_BUFLEN];
        size_t textlen = sizeof textbuf;
        DB_TXN  *ltid = NULL, *lt2;
-       struct bdb_op_info opinfo;
+       struct bdb_op_info opinfo = {0};
        Entry           dummy = {0};
+       int                     fakeroot = 0;
 
        u_int32_t       locker = 0;
        DB_LOCK         lock;
@@ -361,20 +282,10 @@ bdb_modify( Operation *op, SlapReply *rs )
        LDAPControl *ctrls[SLAP_MAX_RESPONSE_CONTROLS];
        int num_ctrls = 0;
 
-       Operation* ps_list;
-       struct psid_entry *pm_list, *pm_prev;
        int rc;
-       EntryInfo       *suffix_ei;
-       Entry           *ctxcsn_e;
-       int                     ctxcsn_added = 0;
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, ENTRY, "bdb_modify: %s\n",
-               op->o_req_dn.bv_val, 0, 0 );
-#else
-       Debug( LDAP_DEBUG_ARGS, "bdb_modify: %s\n",
+       Debug( LDAP_DEBUG_ARGS, LDAP_XSTRING(bdb_modify) ": %s\n",
                op->o_req_dn.bv_val, 0, 0 );
-#endif
 
        ctrls[num_ctrls] = NULL;
 
@@ -388,20 +299,8 @@ retry:     /* transaction retry */
                        bdb_unlocked_cache_return_entry_w(&bdb->bi_cache, e);
                        e = NULL;
                }
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, "bdb_modify: retrying...\n", 0, 0, 0 );
-#else
                Debug(LDAP_DEBUG_TRACE,
-                       "bdb_modify: retrying...\n", 0, 0, 0);
-#endif
-
-               pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
-               while ( pm_list != NULL ) {
-                       LDAP_LIST_REMOVE ( pm_list, ps_link );
-                       pm_prev = pm_list;
-                       pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
-                       ch_free( pm_prev );
-               }
+                       LDAP_XSTRING(bdb_modify) ": retrying...\n", 0, 0, 0);
 
                rs->sr_err = TXN_ABORT( ltid );
                ltid = NULL;
@@ -412,6 +311,10 @@ retry:     /* transaction retry */
                        rs->sr_text = "internal error";
                        goto return_results;
                }
+               if ( op->o_abandon ) {
+                       rs->sr_err = SLAPD_ABANDON;
+                       goto return_results;
+               }
                ldap_pvt_thread_yield();
                bdb_trans_backoff( ++num_retries );
        }
@@ -421,14 +324,9 @@ retry:     /* transaction retry */
                bdb->bi_db_opflags );
        rs->sr_text = NULL;
        if( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "bdb_modify: txn_begin failed: %s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: txn_begin failed: %s (%d)\n",
-                       db_strerror(rs->sr_err), rs->sr_err, 0 );
-#endif
+                       LDAP_XSTRING(bdb_modify) ": txn_begin failed: "
+                       "%s (%d)\n", db_strerror(rs->sr_err), rs->sr_err, 0 );
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "internal error";
                goto return_results;
@@ -447,20 +345,30 @@ retry:    /* transaction retry */
        rs->sr_err = bdb_dn2entry( op, ltid, &op->o_req_ndn, &ei, 1,
                locker, &lock );
 
+       e = ei->bei_e;
+
        if ( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1, 
-                       "bdb_modify: dn2entry failed: (%d)\n", rs->sr_err, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: dn2entry failed (%d)\n",
+                       LDAP_XSTRING(bdb_modify) ": dn2entry failed (%d)\n",
                        rs->sr_err, 0, 0 );
-#endif
                switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
                        goto retry;
                case DB_NOTFOUND:
+                       if ( BER_BVISEMPTY( &op->o_req_ndn )) {
+                               struct berval gluebv = BER_BVC("glue");
+                               e = ch_calloc( 1, sizeof(Entry));
+                               e->e_name.bv_val = ch_strdup( "" );
+                               ber_dupbv( &e->e_nname, &e->e_name );
+                               attr_merge_one( e, slap_schema.si_ad_objectClass,
+                                       &gluebv, NULL );
+                               attr_merge_one( e, slap_schema.si_ad_structuralObjectClass,
+                                       &gluebv, NULL );
+                               e->e_private = ei;
+                               fakeroot = 1;
+                               rs->sr_err = 0;
+                       }
                        break;
                case LDAP_BUSY:
                        rs->sr_text = "ldap server busy";
@@ -472,7 +380,6 @@ retry:      /* transaction retry */
                }
        }
 
-       e = ei->bei_e;
        /* acquire and lock entry */
        /* FIXME: dn2entry() should return non-glue entry */
        if (( rs->sr_err == DB_NOTFOUND ) ||
@@ -487,19 +394,8 @@ retry:     /* transaction retry */
                        e = NULL;
 
                } else {
-                       BerVarray deref = NULL;
-                       if ( !LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
-                               syncinfo_t *si;
-                               LDAP_STAILQ_FOREACH( si, &op->o_bd->be_syncinfo, si_next ) {
-                                       struct berval tmpbv;
-                                       ber_dupbv( &tmpbv, &si->si_provideruri_bv[0] );
-                                       ber_bvarray_add( &deref, &tmpbv );
-                }
-                       } else {
-                               deref = default_referral;
-                       }
-                       rs->sr_ref = referral_rewrite( deref, NULL, &op->o_req_dn,
-                               LDAP_SCOPE_DEFAULT );
+                       rs->sr_ref = referral_rewrite( default_referral, NULL,
+                               &op->o_req_dn, LDAP_SCOPE_DEFAULT );
                }
 
                rs->sr_err = LDAP_REFERRAL;
@@ -519,15 +415,9 @@ retry:     /* transaction retry */
                /* entry is a referral, don't allow modify */
                rs->sr_ref = get_entry_referrals( op, e );
 
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, DETAIL1,
-                       "bdb_modify: entry is referral\n",
-                       0, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: entry is referral\n",
+                       LDAP_XSTRING(bdb_modify) ": entry is referral\n",
                        0, 0, 0 );
-#endif
 
                rs->sr_err = LDAP_REFERRAL;
                rs->sr_matched = e->e_name.bv_val;
@@ -546,25 +436,6 @@ retry:     /* transaction retry */
                goto return_results;
        }
 
-       if ( rs->sr_err == LDAP_SUCCESS && !op->o_noop && !op->o_no_psearch ) {
-               ldap_pvt_thread_rdwr_wlock( &bdb->bi_pslist_rwlock );
-               LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
-                       rc = bdb_psearch(op, rs, ps_list, e, LDAP_PSEARCH_BY_PREMODIFY );
-                       if ( rc ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG ( OPERATION, ERR,
-                                       "bdb_modify: persistent search failed (%d,%d)\n",
-                                       rc, rs->sr_err, 0 );
-#else
-                               Debug( LDAP_DEBUG_TRACE,
-                                       "bdb_modify: persistent search failed (%d,%d)\n",
-                                       rc, rs->sr_err, 0 );
-#endif
-                       }
-               }
-               ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
-       }
-
        if( op->o_preread ) {
                if( preread_ctrl == NULL ) {
                        preread_ctrl = &ctrls[num_ctrls++];
@@ -573,31 +444,20 @@ retry:    /* transaction retry */
                if ( slap_read_controls( op, rs, e,
                        &slap_pre_read_bv, preread_ctrl ) )
                {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1,
-                               "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
-                               "<=- bdb_modify: pre-read failed!\n", 0, 0, 0 );
-#endif
+                               "<=- " LDAP_XSTRING(bdb_modify) ": pre-read failed!\n",
+                               0, 0, 0 );
                        goto return_results;
                }
        }
 
        /* nested transaction */
-       rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, 
-               bdb->bi_db_opflags );
+       rs->sr_err = TXN_BEGIN( bdb->bi_dbenv, ltid, &lt2, bdb->bi_db_opflags );
        rs->sr_text = NULL;
        if( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_modify: txn_begin(2) failed: %s (%d)\n",
-                       db_strerror(rs->sr_err), rs->sr_err, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: txn_begin(2) failed: %s (%d)\n",
+                       LDAP_XSTRING(bdb_modify) ": txn_begin(2) failed: " "%s (%d)\n",
                        db_strerror(rs->sr_err), rs->sr_err, 0 );
-#endif
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "internal error";
                goto return_results;
@@ -608,14 +468,9 @@ retry:     /* transaction retry */
                &dummy, &rs->sr_text, textbuf, textlen );
 
        if( rs->sr_err != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_modify: modify failed (%d)\n", rs->sr_err, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: modify failed (%d)\n",
+                       LDAP_XSTRING(bdb_modify) ": modify failed (%d)\n",
                        rs->sr_err, 0, 0 );
-#endif
                if ( (rs->sr_err == LDAP_INSUFFICIENT_ACCESS) && opinfo.boi_err ) {
                        rs->sr_err = opinfo.boi_err;
                }
@@ -632,14 +487,9 @@ retry:     /* transaction retry */
        /* change the entry itself */
        rs->sr_err = bdb_id2entry_update( op->o_bd, lt2, &dummy );
        if ( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_modify: id2entry update failed (%d)\n", rs->sr_err, 0, 0 );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: id2entry update failed (%d)\n",
+                       LDAP_XSTRING(bdb_modify) ": id2entry update failed " "(%d)\n",
                        rs->sr_err, 0, 0 );
-#endif
                switch( rs->sr_err ) {
                case DB_LOCK_DEADLOCK:
                case DB_LOCK_NOTGRANTED:
@@ -655,17 +505,6 @@ retry:     /* transaction retry */
                goto return_results;
        }
 
-       if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
-               rc = bdb_csn_commit( op, rs, ltid, ei, &suffix_ei,
-                       &ctxcsn_e, &ctxcsn_added, locker );
-               switch ( rc ) {
-               case BDB_CSN_ABORT :
-                       goto return_results;
-               case BDB_CSN_RETRY :
-                       goto retry;
-               }
-       }
-
        if( op->o_postread ) {
                if( postread_ctrl == NULL ) {
                        postread_ctrl = &ctrls[num_ctrls++];
@@ -674,13 +513,9 @@ retry:     /* transaction retry */
                if( slap_read_controls( op, rs, &dummy,
                        &slap_post_read_bv, postread_ctrl ) )
                {
-#ifdef NEW_LOGGING
-                       LDAP_LOG ( OPERATION, DETAIL1,
-                               "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
-#else
                        Debug( LDAP_DEBUG_TRACE,
-                               "<=- bdb_modify: post-read failed!\n", 0, 0, 0 );
-#endif
+                               "<=- " LDAP_XSTRING(bdb_modify)
+                               ": post-read failed!\n", 0, 0, 0 );
                        goto return_results;
                }
        }
@@ -693,60 +528,20 @@ retry:    /* transaction retry */
                        goto return_results;
                }
        } else {
-               rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
-               switch( rc ) {
-               case DB_LOCK_DEADLOCK:
-               case DB_LOCK_NOTGRANTED:
-                       goto retry;
-               }
-               dummy.e_attrs = NULL;
-
-               if ( LDAP_STAILQ_EMPTY( &op->o_bd->be_syncinfo )) {
-                       if ( ctxcsn_added ) {
-                               bdb_cache_add( bdb, suffix_ei, ctxcsn_e,
-                                       (struct berval *)&slap_ldapsync_cn_bv, locker );
-                       }
-               }
-
-               if ( rs->sr_err == LDAP_SUCCESS ) {
-                       /* Loop through in-scope entries for each psearch spec */
-                       ldap_pvt_thread_rdwr_wlock( &bdb->bi_pslist_rwlock );
-                       LDAP_LIST_FOREACH ( ps_list, &bdb->bi_psearch_list, o_ps_link ) {
-                               rc = bdb_psearch( op, rs, ps_list, e, LDAP_PSEARCH_BY_MODIFY );
-                               if ( rc ) {
-#ifdef NEW_LOGGING
-                                       LDAP_LOG ( OPERATION, ERR,
-                                               "bdb_modify: persistent search failed (%d,%d)\n",
-                                               rc, rs->sr_err, 0 );
-#else
-                                       Debug( LDAP_DEBUG_TRACE,
-                                               "bdb_modify: persistent search failed (%d,%d)\n",
-                                               rc, rs->sr_err, 0 );
-#endif
-                               }
-                       }
-                       pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
-                       while ( pm_list != NULL ) {
-                               rc = bdb_psearch(op, rs, pm_list->ps_op,
-                                                       e, LDAP_PSEARCH_BY_SCOPEOUT);
-                               if ( rc ) {
-#ifdef NEW_LOGGING
-                                       LDAP_LOG ( OPERATION, ERR,
-                                               "bdb_modify: persistent search failed (%d,%d)\n",
-                                               rc, rs->sr_err, 0 );
-#else
-                                       Debug( LDAP_DEBUG_TRACE,
-                                               "bdb_modify: persistent search failed (%d,%d)\n",
-                                               rc, rs->sr_err, 0 );
-#endif
-                               }
-                               LDAP_LIST_REMOVE ( pm_list, ps_link );
-                               pm_prev = pm_list;
-                               pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
-                               ch_free( pm_prev );
+               /* may have changed in bdb_modify_internal() */
+               e->e_ocflags = dummy.e_ocflags;
+               if ( fakeroot ) {
+                       e->e_private = NULL;
+                       entry_free( e );
+               } else {
+                       rc = bdb_cache_modify( e, dummy.e_attrs, bdb->bi_dbenv, locker, &lock );
+                       switch( rc ) {
+                       case DB_LOCK_DEADLOCK:
+                       case DB_LOCK_NOTGRANTED:
+                               goto retry;
                        }
-                       ldap_pvt_thread_rdwr_wunlock( &bdb->bi_pslist_rwlock );
                }
+               dummy.e_attrs = NULL;
 
                rs->sr_err = TXN_COMMIT( ltid, 0 );
        }
@@ -754,33 +549,20 @@ retry:    /* transaction retry */
        op->o_private = NULL;
 
        if( rs->sr_err != 0 ) {
-#ifdef NEW_LOGGING
-               LDAP_LOG ( OPERATION, ERR, 
-                       "bdb_modify: txn_%s failed %s (%d)\n", 
-                       op->o_noop ? "abort (no_op)" : "commit",
-                       db_strerror(rs->sr_err), rs->sr_err );
-#else
                Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify: txn_%s failed: %s (%d)\n",
+                       LDAP_XSTRING(bdb_modify) ": txn_%s failed: %s (%d)\n",
                        op->o_noop ? "abort (no-op)" : "commit",
                        db_strerror(rs->sr_err), rs->sr_err );
-#endif
                rs->sr_err = LDAP_OTHER;
                rs->sr_text = "commit failed";
 
                goto return_results;
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, DETAIL1, 
-               "bdb_modify: updated%s id=%08lx dn=\"%s\"\n", 
-               op->o_noop ? " (no_op)" : "", e->e_id, e->e_dn );
-#else
        Debug( LDAP_DEBUG_TRACE,
-               "bdb_modify: updated%s id=%08lx dn=\"%s\"\n",
+               LDAP_XSTRING(bdb_modify) ": updated%s id=%08lx dn=\"%s\"\n",
                op->o_noop ? " (no-op)" : "",
-               e->e_id, e->e_dn );
-#endif
+               dummy.e_id, op->o_req_dn.bv_val );
 
        rs->sr_err = LDAP_SUCCESS;
        rs->sr_text = NULL;
@@ -800,13 +582,6 @@ return_results:
 
 done:
        if( ltid != NULL ) {
-               pm_list = LDAP_LIST_FIRST(&op->o_pm_list);
-               while ( pm_list != NULL ) {
-                       LDAP_LIST_REMOVE ( pm_list, ps_link );
-                       pm_prev = pm_list;
-                       pm_list = LDAP_LIST_NEXT ( pm_list, ps_link );
-                       ch_free( pm_prev );
-               }
                TXN_ABORT( ltid );
                op->o_private = NULL;
        }
@@ -816,12 +591,12 @@ done:
        }
 
        if( preread_ctrl != NULL ) {
-               slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, &op->o_tmpmemctx );
-               slap_sl_free( *preread_ctrl, &op->o_tmpmemctx );
+               slap_sl_free( (*preread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
+               slap_sl_free( *preread_ctrl, op->o_tmpmemctx );
        }
        if( postread_ctrl != NULL ) {
-               slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, &op->o_tmpmemctx );
-               slap_sl_free( *postread_ctrl, &op->o_tmpmemctx );
+               slap_sl_free( (*postread_ctrl)->ldctl_value.bv_val, op->o_tmpmemctx );
+               slap_sl_free( *postread_ctrl, op->o_tmpmemctx );
        }
        return rs->sr_err;
 }