]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/modify.c
Set lock detector to DEFAULT, not NORUN.
[openldap] / servers / slapd / back-bdb / modify.c
index 66df842a08a2cf8ebd0dbfdfa8fb2c96e8ded43f..b00b60236c36116fbc6f2c90a483af970aa38a13 100644 (file)
 #include "back-bdb.h"
 #include "external.h"
 
-static int add_values( Entry *e, Modification *mod, char *dn );
-static int delete_values( Entry *e, Modification *mod, char *dn );
-static int replace_values( Entry *e, Modification *mod, char *dn );
-
 int bdb_modify_internal(
        BackendDB *be,
        Connection *conn,
@@ -51,10 +47,8 @@ int bdb_modify_internal(
                switch ( mod->sm_op ) {
                case LDAP_MOD_ADD:
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: add\n", 0, 0, 0);
-                       err = add_values( e, mod, op->o_ndn.bv_val );
-
+                       err = modify_add_values( e, mod, text, textbuf, textlen );
                        if( err != LDAP_SUCCESS ) {
-                               *text = "modify: add values failed";
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
                        }
@@ -62,10 +56,9 @@ int bdb_modify_internal(
 
                case LDAP_MOD_DELETE:
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: delete\n", 0, 0, 0);
-                       err = delete_values( e, mod, op->o_ndn.bv_val );
+                       err = modify_delete_values( e, mod, text, textbuf, textlen );
                        assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
                        if( err != LDAP_SUCCESS ) {
-                               *text = "modify: delete values failed";
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
                        }
@@ -73,10 +66,9 @@ int bdb_modify_internal(
 
                case LDAP_MOD_REPLACE:
                        Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: replace\n", 0, 0, 0);
-                       err = replace_values( e, mod, op->o_ndn.bv_val );
+                       err = modify_replace_values( e, mod, text, textbuf, textlen );
                        assert( err != LDAP_TYPE_OR_VALUE_EXISTS );
                        if( err != LDAP_SUCCESS ) {
-                               *text = "modify: replace values failed";
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
                        }
@@ -88,14 +80,13 @@ int bdb_modify_internal(
                         * We need to add index if necessary.
                         */
                        mod->sm_op = LDAP_MOD_ADD;
-                       err = add_values( e, mod, op->o_ndn.bv_val );
 
+                       err = modify_add_values( e, mod, text, textbuf, textlen );
                        if ( err == LDAP_TYPE_OR_VALUE_EXISTS ) {
                                err = LDAP_SUCCESS;
                        }
 
                        if( err != LDAP_SUCCESS ) {
-                               *text = "modify: (soft)add values failed";
                                Debug(LDAP_DEBUG_ARGS, "bdb_modify_internal: %d %s\n",
                                        err, *text, 0);
                        }
@@ -378,217 +369,3 @@ done:
        return rc;
 }
 
-static int
-add_values(
-       Entry   *e,
-       Modification    *mod,
-       char    *dn
-)
-{
-       int             i, j;
-       Attribute       *a;
-
-       /* char *desc = mod->sm_desc->ad_cname.bv_val; */
-       MatchingRule *mr = mod->sm_desc->ad_type->sat_equality;
-
-       a = attr_find( e->e_attrs, mod->sm_desc );
-
-       /* check if the values we're adding already exist */
-       if( mr == NULL || !mr->smr_match ) {
-               if ( a != NULL ) {
-                       /* do not allow add of additional attribute
-                               if no equality rule exists */
-                       return LDAP_INAPPROPRIATE_MATCHING;
-               }
-
-               for ( i = 0; mod->sm_bvalues[i].bv_val != NULL; i++ ) {
-                       /* test asserted values against existing values */
-                       if( a ) {
-                               for( j = 0; a->a_vals[j].bv_val != NULL; j++ ) {
-                                       int rc = ber_bvcmp( &mod->sm_bvalues[i],
-                                               &a->a_vals[j] );
-
-                                       if( rc == 0 ) {
-                                               /* value exists already */
-                                               return LDAP_TYPE_OR_VALUE_EXISTS;
-                                       }
-                               }
-                       }
-
-                       /* test asserted values against themselves */
-                       for( j = 0; j < i; j++ ) {
-                               int rc = ber_bvcmp( &mod->sm_bvalues[i],
-                                       &mod->sm_bvalues[j] );
-
-                               if( rc == 0 ) {
-                                       /* value exists already */
-                                       return LDAP_TYPE_OR_VALUE_EXISTS;
-                               }
-                       }
-               }
-
-       } else {
-               for ( i = 0; mod->sm_bvalues[i].bv_val != NULL; i++ ) {
-                       int rc, match;
-                       const char *text = NULL;
-                       struct berval asserted;
-
-                       rc = value_normalize( mod->sm_desc,
-                               SLAP_MR_EQUALITY,
-                               &mod->sm_bvalues[i],
-                               &asserted,
-                               &text );
-
-                       if( rc != LDAP_SUCCESS ) return rc;
-
-                       if( a ) {
-                               for ( j = 0; a->a_vals[j].bv_val != NULL; j++ ) {
-                                       int rc = value_match( &match, mod->sm_desc, mr,
-                                               SLAP_MR_VALUE_SYNTAX_MATCH,
-                                               &a->a_vals[j], &asserted, &text );
-
-                                       if( rc == LDAP_SUCCESS && match == 0 ) {
-                                               free( asserted.bv_val );
-                                               return LDAP_TYPE_OR_VALUE_EXISTS;
-                                       }
-                               }
-                       }
-
-                       for ( j = 0; j < i; j++ ) {
-                               int rc = value_match( &match, mod->sm_desc, mr,
-                                       SLAP_MR_VALUE_SYNTAX_MATCH,
-                                       &mod->sm_bvalues[j], &asserted, &text );
-
-                               if( rc == LDAP_SUCCESS && match == 0 ) {
-                                       free( asserted.bv_val );
-                                       return LDAP_TYPE_OR_VALUE_EXISTS;
-                               }
-                       }
-
-                       free( asserted.bv_val );
-               }
-       }
-
-       /* no - add them */
-       if( attr_merge( e, mod->sm_desc, mod->sm_bvalues ) != 0 ) {
-               /* this should return result of attr_merge */
-               return LDAP_OTHER;
-       }
-
-       return LDAP_SUCCESS;
-}
-
-static int
-delete_values(
-       Entry   *e,
-       Modification    *mod,
-       char    *dn
-)
-{
-       int             i, j, k, found;
-       Attribute       *a;
-       char *desc = mod->sm_desc->ad_cname.bv_val;
-       MatchingRule *mr = mod->sm_desc->ad_type->sat_equality;
-
-       /* delete the entire attribute */
-       if ( mod->sm_bvalues == NULL ) {
-               Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify_delete: removing entire attribute %s\n",
-                       desc, 0, 0 );
-               return attr_delete( &e->e_attrs, mod->sm_desc )
-                       ? LDAP_NO_SUCH_ATTRIBUTE : LDAP_SUCCESS;
-       }
-
-       if( mr == NULL || !mr->smr_match ) {
-               /* disallow specific attributes from being deleted if
-                       no equality rule */
-               return LDAP_INAPPROPRIATE_MATCHING;
-       }
-
-       /* delete specific values - find the attribute first */
-       if ( (a = attr_find( e->e_attrs, mod->sm_desc )) == NULL ) {
-               Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify_delete: could not find attribute %s\n",
-                       desc, 0, 0 );
-               return LDAP_NO_SUCH_ATTRIBUTE;
-       }
-
-       /* find each value to delete */
-       for ( i = 0; mod->sm_bvalues[i].bv_val != NULL; i++ ) {
-               int rc;
-               const char *text = NULL;
-
-               struct berval asserted;
-
-               rc = value_normalize( mod->sm_desc,
-                       SLAP_MR_EQUALITY,
-                       &mod->sm_bvalues[i],
-                       &asserted,
-                       &text );
-
-               if( rc != LDAP_SUCCESS ) return rc;
-
-               found = 0;
-               for ( j = 0; a->a_vals[j].bv_val != NULL; j++ ) {
-                       int match;
-                       int rc = value_match( &match, mod->sm_desc, mr,
-                               SLAP_MR_VALUE_SYNTAX_MATCH,
-                               &a->a_vals[j], &asserted, &text );
-
-                       if( rc == LDAP_SUCCESS && match != 0 ) {
-                               continue;
-                       }
-
-                       /* found a matching value */
-                       found = 1;
-
-                       /* delete it */
-                       free( a->a_vals[j].bv_val );
-                       for ( k = j + 1; a->a_vals[k].bv_val != NULL; k++ ) {
-                               a->a_vals[k - 1] = a->a_vals[k];
-                       }
-                       a->a_vals[k - 1].bv_val = NULL;
-                       a->a_vals[k - 1].bv_len = 0;
-
-                       break;
-               }
-
-               free( asserted.bv_val );
-
-               /* looked through them all w/o finding it */
-               if ( ! found ) {
-                       Debug( LDAP_DEBUG_TRACE,
-                               "bdb_modify_delete: could not find value for attr %s\n",
-                               desc, 0, 0 );
-                       return LDAP_NO_SUCH_ATTRIBUTE;
-               }
-       }
-
-       /* if no values remain, delete the entire attribute */
-       if ( a->a_vals[0].bv_val == NULL ) {
-               Debug( LDAP_DEBUG_TRACE,
-                       "bdb_modify_delete: removing entire attribute %s\n",
-                       desc, 0, 0 );
-               if ( attr_delete( &e->e_attrs, mod->sm_desc ) ) {
-                       return LDAP_NO_SUCH_ATTRIBUTE;
-               }
-       }
-
-       return LDAP_SUCCESS;
-}
-
-static int
-replace_values(
-       Entry   *e,
-       Modification    *mod,
-       char    *dn
-)
-{
-       (void) attr_delete( &e->e_attrs, mod->sm_desc );
-
-       if ( mod->sm_bvalues ) {
-               return add_values( e, mod, dn );
-       }
-
-       return LDAP_SUCCESS;
-}