]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/back-bdb/search.c
Plug memory leak
[openldap] / servers / slapd / back-bdb / search.c
index 30abec8b259f04faa3b171eb9271b65427b42879..949b1d93fb7092da9a7a53c11024acaa6d926505 100644 (file)
@@ -26,6 +26,12 @@ static int search_candidates(
        int scope,
        int deref,
        ID      *ids );
+static void send_pagerequest_response( 
+       Connection      *conn,
+       Operation *op,
+       ID  lastid,
+       int nentries,
+       int tentries );                 
 
 int
 bdb_search(
@@ -55,14 +61,21 @@ bdb_search(
        struct berval   realbase = { 0, NULL };
        int             nentries = 0;
        int             manageDSAit;
+       int             pagedresults;
+       int             tentries = 0;
+       ID              lastid = NOID;
+
+#ifdef LDAP_CLIENT_UPDATE
+       Filter lcupf, csnfnot, csnfeq, csnfand, csnfge;
+       AttributeAssertion aa_ge, aa_eq;
+       int             entry_count = 0;
+       struct berval entrycsn_bv = { 0, NULL };
+       struct berval latest_entrycsn_bv = { 0, NULL };
+#endif /* LDAP_CLIENT_UPDATE */
 
        struct slap_limits_set *limit = NULL;
        int isroot = 0;
 
-#ifdef SLAP_X_FILTER_HASSUBORDINATES
-       int             filter_hasSubordinates = 0;
-#endif /* SLAP_X_FILTER_HASSUBORDINATES */
-
        u_int32_t       locker;
        DB_LOCK         lock;
 
@@ -73,7 +86,17 @@ bdb_search(
                0, 0, 0);
 #endif
 
+#ifdef LDAP_CLIENT_UPDATE
+       if ( op->o_clientupdate_type & SLAP_LCUP_PERSIST ) {
+               bdb_add_psearch_spec( be, conn, op, base, base, scope,
+                       deref, slimit, tlimit, filter, filterstr, attrs, attrsonly );
+               return LDAP_SUCCESS;
+       }
+#endif
+
+
        manageDSAit = get_manageDSAit( op );
+       pagedresults = get_pagedresults( op );
 
        rc = LOCK_ID (bdb->bi_dbenv, &locker );
        switch(rc) {
@@ -234,13 +257,15 @@ dn2entry_retry:
                /* if requested limit higher than hard limit, abort */
                } else if ( tlimit > limit->lms_t_hard ) {
                        /* no hard limit means use soft instead */
-                       if ( limit->lms_t_hard == 0 && tlimit > limit->lms_t_soft ) {
+                       if ( limit->lms_t_hard == 0
+                                       && limit->lms_t_soft > -1
+                                       && tlimit > limit->lms_t_soft ) {
                                tlimit = limit->lms_t_soft;
 
                        /* positive hard limit means abort */
                        } else if ( limit->lms_t_hard > 0 ) {
                                send_search_result( conn, op, 
-                                               LDAP_UNWILLING_TO_PERFORM,
+                                               LDAP_ADMINLIMIT_EXCEEDED,
                                                NULL, NULL, NULL, NULL, 0 );
                                rc = 0;
                                goto done;
@@ -251,18 +276,24 @@ dn2entry_retry:
                
                /* if no limit is required, use soft limit */
                if ( slimit <= 0 ) {
-                       slimit = limit->lms_s_soft;
+                       if ( pagedresults && limit->lms_s_pr != 0 ) {
+                               slimit = limit->lms_s_pr;
+                       } else {
+                               slimit = limit->lms_s_soft;
+                       }
 
                /* if requested limit higher than hard limit, abort */
                } else if ( slimit > limit->lms_s_hard ) {
                        /* no hard limit means use soft instead */
-                       if ( limit->lms_s_hard == 0 && slimit > limit->lms_s_soft ) {
+                       if ( limit->lms_s_hard == 0
+                                       && limit->lms_s_soft > -1
+                                       && slimit > limit->lms_s_soft ) {
                                slimit = limit->lms_s_soft;
 
                        /* positive hard limit means abort */
                        } else if ( limit->lms_s_hard > 0 ) {
                                send_search_result( conn, op, 
-                                               LDAP_UNWILLING_TO_PERFORM,
+                                               LDAP_ADMINLIMIT_EXCEEDED,
                                                NULL, NULL, NULL, NULL, 0 );
                                rc = 0; 
                                goto done;
@@ -288,11 +319,9 @@ dn2entry_retry:
        /* need normalized dn below */
        ber_dupbv( &realbase, &e->e_nname );
 
-       /* start cursor at base entry's id 
-        * FIXME: hack to make "" base work
-        * FIXME: moddn needs to assign new ID for this to work
+       /* start cursor at beginning of candidates.
         */
-       cursor = e->e_id == NOID ? 1 : e->e_id;
+       cursor = 0;
 
        if ( e != &slap_entry_root ) {
                bdb_cache_return_entry_r(bdb->bi_dbenv, &bdb->bi_cache, e, &lock);
@@ -301,7 +330,8 @@ dn2entry_retry:
 
        if ( candidates[0] == 0 ) {
 #ifdef NEW_LOGGING
-       LDAP_LOG ( OPERATION, RESULTS, "bdb_search: no candidates\n", 0, 0, 0 );
+               LDAP_LOG ( OPERATION, RESULTS,
+                       "bdb_search: no candidates\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "bdb_search: no candidates\n",
                        0, 0, 0 );
@@ -326,23 +356,77 @@ dn2entry_retry:
                }
        }
 
-#ifdef SLAP_X_FILTER_HASSUBORDINATES
-       /*
-        * is hasSubordinates used in the filter ?
-        * FIXME: we may compute this directly when parsing the filter
-        */
-       filter_hasSubordinates = filter_has_subordinates( filter );
-#endif /* SLAP_X_FILTER_HASSUBORDINATES */
+       if ( isroot || !limit->lms_s_pr_hide ) {
+               tentries = BDB_IDL_N(candidates);
+       }
+
+       if ( pagedresults ) {
+               if ( op->o_pagedresults_state.ps_cookie == 0 ) {
+                       id = 0;
+               } else {
+                       if ( op->o_pagedresults_size == 0 ) {
+                               send_search_result( conn, op, LDAP_SUCCESS,
+                                       NULL, "search abandoned by pagedResult size=0",
+                                       NULL, NULL, 0);
+                               goto done;
+                       }
+                       for ( id = bdb_idl_first( candidates, &cursor );
+                               id != NOID && id <= (ID)( op->o_pagedresults_state.ps_cookie );
+                               id = bdb_idl_next( candidates, &cursor ) );
+               }
+               if ( cursor == NOID ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, RESULTS, 
+                               "bdb_search: no paged results candidates\n", 
+                       0, 0, 0 );
+#else
+                       Debug( LDAP_DEBUG_TRACE, 
+                               "bdb_search: no paged results candidates\n",
+                               0, 0, 0 );
+#endif
+                       send_pagerequest_response( conn, op, lastid, 0, 0 );
+
+                       rc = 1;
+                       goto done;
+               }
+               goto loop_begin;
+       }
+
+#ifdef LDAP_CLIENT_UPDATE
+       if ( op->o_clientupdate_type & SLAP_LCUP_SYNC ) {
+               lcupf.f_choice = LDAP_FILTER_AND;
+               lcupf.f_and = &csnfnot;
+               lcupf.f_next = NULL;
+
+               csnfnot.f_choice = LDAP_FILTER_NOT;
+               csnfnot.f_not = &csnfeq;
+               csnfnot.f_next = &csnfand;
+
+               csnfeq.f_choice = LDAP_FILTER_EQUALITY;
+               csnfeq.f_ava = &aa_eq;
+               csnfeq.f_av_desc = slap_schema.si_ad_entryCSN;
+               ber_dupbv( &csnfeq.f_av_value, &op->o_clientupdate_state );
+
+               csnfand.f_choice = LDAP_FILTER_AND;
+               csnfand.f_and = &csnfge;
+               csnfand.f_next = NULL;
+
+               csnfge.f_choice = LDAP_FILTER_GE;
+               csnfge.f_ava = &aa_ge;
+               csnfge.f_av_desc = slap_schema.si_ad_entryCSN;
+               ber_dupbv( &csnfge.f_av_value, &op->o_clientupdate_state );
+               csnfge.f_next = filter;
+       }
+#endif /* LDAP_CLIENT_UPDATE */
 
        for ( id = bdb_idl_first( candidates, &cursor );
                id != NOID;
                id = bdb_idl_next( candidates, &cursor ) )
        {
+
                int             scopeok = 0;
-#ifdef SLAP_X_FILTER_HASSUBORDINATES
-               Attribute       *hasSubordinates = NULL;
-#endif /* SLAP_X_FILTER_HASSUBORDINATES */
 
+loop_begin:
                /* check for abandon */
                if ( op->o_abandon ) {
                        rc = 0;
@@ -505,46 +589,15 @@ id2entry_retry:
                        goto loop_continue;
                }
 
-#ifdef SLAP_X_FILTER_HASSUBORDINATES
-               /*
-                * if hasSubordinates is used in the filter,
-                * append it to the entry's attributes
-                */
-               if ( filter_hasSubordinates ) {
-                       int     hs;
-
-                       rc = bdb_hasSubordinates( be, conn, op, e, &hs);
-                       if ( rc != LDAP_SUCCESS ) {
-                               goto loop_continue;
-                       }
-
-                       hasSubordinates = slap_operational_hasSubordinate( hs == LDAP_COMPARE_TRUE );
-                       if ( hasSubordinates == NULL ) {
-                               goto loop_continue;
-                       }
-
-                       hasSubordinates->a_next = e->e_attrs;
-                       e->e_attrs = hasSubordinates;
-               }
-#endif /* SLAP_X_FILTER_HASSUBORDINATES */
-
                /* if it matches the filter and scope, send it */
-               rc = test_filter( be, conn, op, e, filter );
-
-#ifdef SLAP_X_FILTER_HASSUBORDINATES
-               if ( hasSubordinates ) {
-                       /*
-                        * FIXME: this is fairly inefficient, because 
-                        * if hasSubordinates is among the required
-                        * attrs, it will be added again later;
-                        * maybe we should leave it and check
-                        * check later if it's already present,
-                        * if required
-                        */
-                       e->e_attrs = e->e_attrs->a_next;
-                       attr_free( hasSubordinates );
+#ifdef LDAP_CLIENT_UPDATE
+               if ( op->o_clientupdate_type & SLAP_LCUP_SYNC ) {
+                       rc = test_filter( be, conn, op, e, &lcupf );
+               } else
+#endif /* LDAP_CLIENT_UPDATE */
+               {
+                       rc = test_filter( be, conn, op, e, filter );
                }
-#endif /* SLAP_X_FILTER_HASSUBORDINATES */
 
                if ( rc == LDAP_COMPARE_TRUE ) {
                        struct berval   dn;
@@ -568,7 +621,8 @@ id2entry_retry:
                        if ( scopeok ) {
                                /* check size limit */
                                if ( --slimit == -1 ) {
-                                       bdb_cache_return_entry_r (bdb->bi_dbenv, &bdb->bi_cache, e, &lock);
+                                       bdb_cache_return_entry_r( bdb->bi_dbenv,
+                                               &bdb->bi_cache, e, &lock );
                                        e = NULL;
                                        send_search_result( conn, op,
                                                rc = LDAP_SIZELIMIT_EXCEEDED, NULL, NULL,
@@ -576,19 +630,124 @@ id2entry_retry:
                                        goto done;
                                }
 
+                               if ( pagedresults ) {
+                                       if ( nentries >= op->o_pagedresults_size ) {
+                                               send_pagerequest_response( conn, op, lastid, nentries, tentries );
+                                               goto done;
+                                       }
+                                       lastid = id;
+                               }
+
                                if (e) {
                                        int result;
                                        
 #if 0  /* noop is masked SLAP_CTRL_UPDATE */
                                        if( op->o_noop ) {
                                                result = 0;
-                                       } else {
+                                       } else
 #endif
-                                               result = send_search_entry( be, conn, op,
-                                                       e, attrs, attrsonly, NULL);
-#if 0
-                                       }
+                                       {
+#ifdef LDAP_CLIENT_UPDATE
+                                               if ( op->o_clientupdate_type & SLAP_LCUP_SYNC ) {
+                                                       Attribute* a;
+                                                       int ret;
+                                                       int res;
+                                                       const char *text = NULL;
+                                                       LDAPControl *ctrls[2];
+                                                       char berbuf[LBER_ELEMENT_SIZEOF];
+                                                       BerElement *ber = (BerElement *)berbuf;
+
+                                                       ber_init2( ber, 0, LBER_USE_DER );
+
+                                                       entry_count++;
+
+                                                       ctrls[0] = ch_malloc ( sizeof ( LDAPControl ) );
+                                                       ctrls[1] = NULL;
+
+                                                       if ( entry_count % op->o_clientupdate_interval == 0 ) {
+                                                               /* Send cookie */
+                                                               for ( a = e->e_attrs; a != NULL; a = a->a_next ) {
+                                                                       AttributeDescription *desc = a->a_desc;
+                                                                       if ( desc == slap_schema.si_ad_entryCSN ) {
+                                                                               ber_dupbv( &entrycsn_bv, &a->a_vals[0] );
+                                                                               if ( latest_entrycsn_bv.bv_val == NULL ) {
+                                                                                       ber_dupbv( &latest_entrycsn_bv, &entrycsn_bv );
+                                                                               } else {
+                                                                                       res = value_match( &ret, desc,
+                                                                                               desc->ad_type->sat_ordering,
+                                                                                               SLAP_MR_ASSERTION_SYNTAX_MATCH,
+                                                                                               &entrycsn_bv, &latest_entrycsn_bv, &text );
+                                                                                       if ( res != LDAP_SUCCESS ) {
+                                                                                               ret = 0;
+#ifdef NEW_LOGGING
+                                                                                               LDAP_LOG ( OPERATION, RESULTS, 
+                                                                                                       "bdb_search: value_match failed\n",
+                                                                                                       0, 0, 0 );
+#else
+                                                                                               Debug( LDAP_DEBUG_TRACE,
+                                                                                                       "bdb_search: value_match failed\n",
+                                                                                                       0, 0, 0 );
+#endif
+                                                                                       }
+
+                                                                                       if ( ret > 0 ) {
+                                                                                               ch_free( latest_entrycsn_bv.bv_val );
+                                                                                               latest_entrycsn_bv.bv_val = NULL;
+                                                                                               ber_dupbv( &latest_entrycsn_bv,
+                                                                                                       &entrycsn_bv );
+                                                                                       }
+                                                                               }
+                                                                       }
+                                                               }
+
+                                                               ber_printf( ber,
+                                                                       "{bb{sON}N}",
+                                                                       SLAP_LCUP_STATE_UPDATE_FALSE,
+                                                                       SLAP_LCUP_ENTRY_DELETED_FALSE,
+                                                                       LCUP_COOKIE_OID, &entrycsn_bv );
+
+                                                               ch_free( entrycsn_bv.bv_val );
+                                                               entrycsn_bv.bv_val = NULL;
+
+                                                       } else {
+                                                               /* Do not send cookie */
+                                                               ber_printf( ber,
+                                                                       "{bbN}",
+                                                                       SLAP_LCUP_STATE_UPDATE_FALSE,
+                                                                       SLAP_LCUP_ENTRY_DELETED_FALSE );
+                                                       }
+
+                                                       ctrls[0]->ldctl_oid = LDAP_CONTROL_ENTRY_UPDATE;
+                                                       ctrls[0]->ldctl_iscritical = op->o_clientupdate;
+                                                       ret = ber_flatten2( ber, &ctrls[0]->ldctl_value, 0 );
+                                                       if ( ret < 0 ) {
+                                                               ber_free_buf( ber );
+#ifdef NEW_LOGGING
+                                                               LDAP_LOG ( OPERATION, RESULTS, 
+                                                                       "bdb_search: ber_flatten2 failed\n",
+                                                                       0, 0, 0 );
+#else
+                                                               Debug( LDAP_DEBUG_TRACE,
+                                                                       "bdb_search: ber_flatten2 failed\n",
+                                                                       0, 0, 0 );
 #endif
+                                                               send_ldap_result( conn, op, rc=LDAP_OTHER,
+                                                                       NULL, "internal error", NULL, NULL );
+                                                               goto done;
+                                                       }
+
+                                                       result = send_search_entry( be, conn, op,
+                                                               e, attrs, attrsonly, ctrls);
+
+                                                       ber_free_buf( ber );
+                                                       ch_free( ctrls[0] );
+                                               } else
+#endif /* LDAP_CLIENT_UPDATE */
+                                               {
+                                                       result = send_search_entry( be, conn, op,
+                                                               e, attrs, attrsonly, NULL);
+                                               }
+                                       }
 
                                        switch (result) {
                                        case 0:         /* entry sent ok */
@@ -597,7 +756,8 @@ id2entry_retry:
                                        case 1:         /* entry not sent */
                                                break;
                                        case -1:        /* connection closed */
-                                               bdb_cache_return_entry_r(bdb->bi_dbenv, &bdb->bi_cache, e, &lock);
+                                               bdb_cache_return_entry_r(bdb->bi_dbenv,
+                                                       &bdb->bi_cache, e, &lock);
                                                e = NULL;
                                                rc = LDAP_OTHER;
                                                goto done;
@@ -627,15 +787,62 @@ id2entry_retry:
 loop_continue:
                if( e != NULL ) {
                        /* free reader lock */
-                        bdb_cache_return_entry_r ( bdb->bi_dbenv, &bdb->bi_cache, e , &lock);
-                        e = NULL;
+                       bdb_cache_return_entry_r( bdb->bi_dbenv,
+                               &bdb->bi_cache, e , &lock);
+                       e = NULL;
                }
 
                ldap_pvt_thread_yield();
        }
-       send_search_result( conn, op,
-               v2refs == NULL ? LDAP_SUCCESS : LDAP_REFERRAL,
-               NULL, NULL, v2refs, NULL, nentries );
+
+#ifdef LDAP_CLIENT_UPDATE
+       if ( op->o_clientupdate_type & SLAP_LCUP_SYNC ) {
+               int ret;
+               LDAPControl *ctrls[2];
+               char berbuf[LBER_ELEMENT_SIZEOF];
+               BerElement *ber = (BerElement *)berbuf;
+
+               ber_init2( ber, NULL, LBER_USE_DER );
+
+               ctrls[0] = ch_malloc ( sizeof ( LDAPControl ) );
+               ctrls[1] = NULL;
+
+               ber_printf( ber, "{sO", LCUP_COOKIE_OID, &latest_entrycsn_bv );
+               ber_printf( ber, "N}" );
+
+               ctrls[0]->ldctl_oid = LDAP_CONTROL_CLIENT_UPDATE_DONE;
+               ctrls[0]->ldctl_iscritical = op->o_clientupdate;
+               ret = ber_flatten2( ber, &ctrls[0]->ldctl_value, 0 );
+
+               if ( ret < 0 ) {
+                       ber_free_buf( ber );
+#ifdef NEW_LOGGING
+                       LDAP_LOG ( OPERATION, RESULTS, 
+                               "bdb_search: ber_flatten2 failed\n", 0, 0, 0 );
+#else
+                       Debug( LDAP_DEBUG_TRACE, "bdb_search: ber_flatten2 failed\n",
+                               0, 0, 0 );
+#endif
+                       send_ldap_result( conn, op, rc=LDAP_OTHER,
+                               NULL, "internal error", NULL, NULL );
+                       goto done;
+               }
+
+               send_search_result( conn, op,
+                       v2refs == NULL ? LDAP_SUCCESS : LDAP_REFERRAL,
+                       NULL, NULL, v2refs, ctrls, nentries );
+
+               ch_free( latest_entrycsn_bv.bv_val );
+               latest_entrycsn_bv.bv_val = NULL;
+               ch_free( ctrls[0] );
+               ber_free_buf( ber );
+       } else
+#endif /* LDAP_CLIENT_UPDATE */
+       {
+               send_search_result( conn, op,
+                       v2refs == NULL ? LDAP_SUCCESS : LDAP_REFERRAL,
+                       NULL, NULL, v2refs, NULL, nentries );
+       }
 
        rc = 0;
 
@@ -645,6 +852,18 @@ done:
                bdb_cache_return_entry_r ( bdb->bi_dbenv, &bdb->bi_cache, e, &lock );
        }
 
+#ifdef LDAP_CLIENT_UPDATE
+       if ( op->o_clientupdate_type & SLAP_LCUP_SYNC ) {
+               if ( csnfeq.f_ava != NULL && csnfeq.f_av_value.bv_val != NULL ) {
+                       ch_free( csnfeq.f_av_value.bv_val );
+               }
+       
+               if ( csnfge.f_ava != NULL && csnfge.f_av_value.bv_val != NULL ) {
+                       ch_free( csnfge.f_av_value.bv_val );
+               }
+       }
+#endif /* LDAP_CLIENT_UPDATE */
+
        LOCK_ID_FREE (bdb->bi_dbenv, locker );
 
        if( v2refs ) ber_bvarray_free( v2refs );
@@ -687,22 +906,57 @@ static int oc_filter(
 
        switch(f->f_choice) {
        case LDAP_FILTER_PRESENT:
-               if (f->f_desc == slap_schema.si_ad_objectClass)
+               if (f->f_desc == slap_schema.si_ad_objectClass) {
                        rc = 1;
+               }
                break;
 
        case LDAP_FILTER_AND:
        case LDAP_FILTER_OR:
                cur++;
-               for (f=f->f_and; f; f=f->f_next)
-                       rc |= oc_filter(f, cur, max);
+               for (f=f->f_and; f; f=f->f_next) {
+                       (void) oc_filter(f, cur, max);
+               }
                break;
+
        default:
                break;
        }
        return rc;
 }
 
+static void search_stack_free( void *key, void *data)
+{
+       ch_free(data);
+}
+
+static void *search_stack(
+       BackendDB *be,
+       Operation *op
+)
+{
+       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
+       void *ret = NULL;
+
+       if ( op->o_threadctx ) {
+               ldap_pvt_thread_pool_getkey( op->o_threadctx, search_stack,
+                       &ret, NULL );
+       } else {
+               ret = bdb->bi_search_stack;
+       }
+
+       if ( !ret ) {
+               ret = ch_malloc( bdb->bi_search_stack_depth * BDB_IDL_UM_SIZE * sizeof( ID ) );
+               if ( op->o_threadctx ) {
+                       ldap_pvt_thread_pool_setkey( op->o_threadctx, search_stack,
+                               ret, search_stack_free );
+               } else {
+                       bdb->bi_search_stack = ret;
+               }
+       }
+       return ret;
+}
+
 static int search_candidates(
        BackendDB *be,
        Operation *op,
@@ -712,6 +966,7 @@ static int search_candidates(
        int deref,
        ID      *ids )
 {
+       struct bdb_info *bdb = (struct bdb_info *) be->be_private;
        int rc, depth = 1;
        Filter          f, scopef, rf, xf;
        ID              *stack;
@@ -751,7 +1006,7 @@ static int search_candidates(
         */
        if (!oc_filter(filter, 1, &depth) && !get_subentries_visibility(op) ) {
                if( !get_manageDSAit(op) ) { /* match referrals */
-                       struct berval bv_ref = { sizeof("REFERRAL")-1, "REFERRAL" };
+                       struct berval bv_ref = { sizeof("referral")-1, "referral" };
                        rf.f_choice = LDAP_FILTER_EQUALITY;
                        rf.f_ava = &aa_ref;
                        rf.f_av_desc = slap_schema.si_ad_objectClass;
@@ -762,7 +1017,7 @@ static int search_candidates(
 
 #ifdef BDB_ALIASES
                if( deref & LDAP_DEREF_SEARCHING ) { /* match aliases */
-                       struct berval bv_alias = { sizeof("ALIAS")-1, "ALIAS" };
+                       struct berval bv_alias = { sizeof("alias")-1, "alias" };
                        af.f_choice = LDAP_FILTER_EQUALITY;
                        af.f_ava = &aa_alias;
                        af.f_av_desc = slap_schema.si_ad_objectClass;
@@ -799,11 +1054,17 @@ static int search_candidates(
 #endif
 
        /* Allocate IDL stack, plus 1 more for former tmp */
-       stack = ch_malloc( (depth + 1) * BDB_IDL_UM_SIZE * sizeof( ID ) );
+       if ( depth+1 > bdb->bi_search_stack_depth ) {
+               stack = ch_malloc( (depth + 1) * BDB_IDL_UM_SIZE * sizeof( ID ) );
+       } else {
+               stack = search_stack( be, op );
+       }
 
        rc = bdb_filter_candidates( be, &f, ids, stack, stack+BDB_IDL_UM_SIZE );
 
-       ch_free( stack );
+       if ( depth+1 > bdb->bi_search_stack_depth ) {
+               ch_free( stack );
+       }
 
        if( rc ) {
 #ifdef NEW_LOGGING
@@ -833,3 +1094,59 @@ static int search_candidates(
        return rc;
 }
 
+static void
+send_pagerequest_response( 
+       Connection      *conn,
+       Operation       *op,
+       ID              lastid,
+       int             nentries,
+       int             tentries )
+{
+       LDAPControl     ctrl, *ctrls[2];
+       char berbuf[LBER_ELEMENT_SIZEOF];
+       BerElement      *ber = (BerElement *)berbuf;
+       struct berval   cookie = { 0, NULL };
+       PagedResultsCookie respcookie;
+
+#ifdef NEW_LOGGING
+       LDAP_LOG ( OPERATION, ENTRY,
+               "send_pagerequest_response: lastid: (0x%08lx) "
+               "nentries: (0x%081x)\n", 
+               lastid, nentries, NULL );
+#else
+       Debug(LDAP_DEBUG_ARGS, "send_pagerequest_response: lastid: (0x%08lx) "
+                       "nentries: (0x%081x)\n", lastid, nentries, NULL );
+#endif
+
+       ctrl.ldctl_value.bv_val = NULL;
+       ctrls[0] = &ctrl;
+       ctrls[1] = NULL;
+
+       ber_init2( ber, NULL, LBER_USE_DER );
+
+       respcookie = ( PagedResultsCookie )lastid;
+       conn->c_pagedresults_state.ps_cookie = respcookie;
+       cookie.bv_len = sizeof( respcookie );
+       cookie.bv_val = (char *)&respcookie;
+
+       /*
+        * FIXME: we should consider sending an estimate of the entries
+        * left, after appropriate security check is done
+        */
+       ber_printf( ber, "{iO}", tentries, &cookie ); 
+
+       if ( ber_flatten2( ber, &ctrls[0]->ldctl_value, 0 ) == LBER_ERROR ) {
+               goto done;
+       }
+
+       ctrls[0]->ldctl_oid = LDAP_CONTROL_PAGEDRESULTS;
+       ctrls[0]->ldctl_iscritical = 0;
+
+       send_search_result( conn, op,
+               LDAP_SUCCESS,
+               NULL, NULL, NULL, ctrls, nentries );
+
+done:
+       (void) ber_free_buf( ber );
+}                      
+